)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8cba3e1e5d110d4ddbd5e6d941834f2bb3559eb6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9eda9c25_9171594e","updated":"2025-12-09 00:23:39.000000000","message":"Need to make an update based on failing devstack commands:\n\n$ oscwrap --os-cloud devstack --os-region RegionOne network create private -f value -c id\nError while executing command: BadRequestException: 400, Bad auto_allocate request: Not an external network.","commit_id":"f79737a2b6f3184600739c83cedbdce3d264e732"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4f74f3feb20df4d0e1b65c10dd63f3f74dca5bc0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"47ade68a_f5d9d753","updated":"2025-12-10 18:08:12.000000000","message":"recheck cover timeout","commit_id":"004b4c743b50236d13a39762f122a8751f1d2dd9"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7938cc900f933631dd9feaad28040121fa75c291","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"79778e2f_cd8e02bc","updated":"2025-12-10 20:36:21.000000000","message":"recheck unrelated functional failure","commit_id":"004b4c743b50236d13a39762f122a8751f1d2dd9"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9a925b02705ac5b1c19882a4b229cc02f2cd10cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1f75b2a1_7945f708","updated":"2025-12-11 00:01:39.000000000","message":"recheck unrelated py310 failure","commit_id":"004b4c743b50236d13a39762f122a8751f1d2dd9"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d35bfeec7201232c2880773cb55d2cb4a22aa540","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"44f32e40_affdc628","updated":"2025-12-10 17:05:12.000000000","message":"this solves the issue for me, thx","commit_id":"004b4c743b50236d13a39762f122a8751f1d2dd9"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c232739bf97d42235ea103f555c498617b96e051","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4c9f82c4_d5f4a5a9","in_reply_to":"44f32e40_affdc628","updated":"2025-12-10 17:15:23.000000000","message":"Thanks for testing, hopefully this version passes tempest.","commit_id":"004b4c743b50236d13a39762f122a8751f1d2dd9"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6ae5a5880f3ead38132b790a8af4290f72d1253e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1d2caf5d_96e90642","updated":"2025-12-12 15:39:58.000000000","message":"btw i did not test this on my live system, will see if n-t-p tests like it","commit_id":"4d196d1cd12182082e51f574626fd3002ac4c6b8"}],"neutron/services/auto_allocate/db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"63b717fd6443a8e2d632eacc98a86ec4ae652323","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                return"},{"line_number":62,"context_line":"            elif not orig.get(external_net_apidef.EXTERNAL):"},{"line_number":63,"context_line":"                raise n_exc.BadRequest(resource\u003d\u0027auto_allocate\u0027,"},{"line_number":64,"context_line":"                                       msg\u003d_(\u0027Not an external network\u0027))"},{"line_number":65,"context_line":"        if is_default:"},{"line_number":66,"context_line":"            # ensure only one default external network at any given time"},{"line_number":67,"context_line":"            pager \u003d base_obj.Pager(limit\u003d1)"}],"source_content_type":"text/x-python","patch_set":2,"id":"6c1c9241_9c154d95","line":64,"updated":"2025-12-09 22:03:53.000000000","message":"I\u0027m just going to change this to return and not raise","commit_id":"2ee305cf4cbeb57013d4a746f440d0045004f43b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"15b4b452b9c9ab46c16315c7e26da8cb32cb23ba","unresolved":true,"context_lines":[{"line_number":54,"context_line":"    def _do_ensure_external_network_default_value_callback("},{"line_number":55,"context_line":"            context, request, orig, network):"},{"line_number":56,"context_line":"        is_default \u003d request.get(api_const.IS_DEFAULT)"},{"line_number":57,"context_line":"        # the update request might not have external set to True, so"},{"line_number":58,"context_line":"        # verify by looking at the network"},{"line_number":59,"context_line":"        is_external \u003d (request.get(external_net_apidef.EXTERNAL) or"},{"line_number":60,"context_line":"                       network[external_net_apidef.EXTERNAL])"},{"line_number":61,"context_line":"        if is_default is None or not is_external:"}],"source_content_type":"text/x-python","patch_set":4,"id":"73de334d_342bebd4","line":58,"range":{"start_line":57,"start_character":8,"end_line":58,"end_character":42},"updated":"2025-12-12 10:35:12.000000000","message":"That\u0027s right. But this is why we should check if `request.get(external_net_apidef.EXTERNAL)` is not None, instead of the current boolean check. The value could be explicitly set to \"False\". In this case, we should also fast exit here.","commit_id":"004b4c743b50236d13a39762f122a8751f1d2dd9"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"fd2af398d4ed85d397742310232d83094020a777","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    def _do_ensure_external_network_default_value_callback("},{"line_number":55,"context_line":"            context, request, orig, network):"},{"line_number":56,"context_line":"        is_default \u003d request.get(api_const.IS_DEFAULT)"},{"line_number":57,"context_line":"        # the update request might not have external set to True, so"},{"line_number":58,"context_line":"        # verify by looking at the network"},{"line_number":59,"context_line":"        is_external \u003d (request.get(external_net_apidef.EXTERNAL) or"},{"line_number":60,"context_line":"                       network[external_net_apidef.EXTERNAL])"},{"line_number":61,"context_line":"        if is_default is None or not is_external:"}],"source_content_type":"text/x-python","patch_set":4,"id":"0142c25d_2ceb530f","line":58,"range":{"start_line":57,"start_character":8,"end_line":58,"end_character":42},"in_reply_to":"73de334d_342bebd4","updated":"2025-12-12 17:05:02.000000000","message":"Done","commit_id":"004b4c743b50236d13a39762f122a8751f1d2dd9"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d5a7b29af76fcbf61164834b4a3978ce05d8fa10","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        is_default \u003d request.get(api_const.IS_DEFAULT)"},{"line_number":57,"context_line":"        # the update request might not have external set to True, so"},{"line_number":58,"context_line":"        # verify by looking at the network"},{"line_number":59,"context_line":"        is_external \u003d (request.get(external_net_apidef.EXTERNAL) or"},{"line_number":60,"context_line":"                       network[external_net_apidef.EXTERNAL])"},{"line_number":61,"context_line":"        if is_default is None or not is_external:"},{"line_number":62,"context_line":"            return"},{"line_number":63,"context_line":"        if is_default:"},{"line_number":64,"context_line":"            # ensure only one default external network at any given time"}],"source_content_type":"text/x-python","patch_set":4,"id":"6b302db3_12b52dfd","line":61,"range":{"start_line":59,"start_character":0,"end_line":61,"end_character":49},"updated":"2025-12-12 12:27:27.000000000","message":"so you mean like this?\n```suggestion\n        req_external \u003d request.get(external_net_apidef.EXTERNAL)\n        net_external \u003d network[external_net_apidef.EXTERNAL]\n        if is_default is None or req_external \u003d False or not net_external:\n```","commit_id":"004b4c743b50236d13a39762f122a8751f1d2dd9"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7a6c4e27b807f4b87031850a65d8560ec9fae20f","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        is_default \u003d request.get(api_const.IS_DEFAULT)"},{"line_number":57,"context_line":"        # the update request might not have external set to True, so"},{"line_number":58,"context_line":"        # verify by looking at the network"},{"line_number":59,"context_line":"        is_external \u003d (request.get(external_net_apidef.EXTERNAL) or"},{"line_number":60,"context_line":"                       network[external_net_apidef.EXTERNAL])"},{"line_number":61,"context_line":"        if is_default is None or not is_external:"},{"line_number":62,"context_line":"            return"},{"line_number":63,"context_line":"        if is_default:"},{"line_number":64,"context_line":"            # ensure only one default external network at any given time"}],"source_content_type":"text/x-python","patch_set":4,"id":"d3c1eee8_f67f7c6e","line":61,"range":{"start_line":59,"start_character":0,"end_line":61,"end_character":49},"in_reply_to":"6b302db3_12b52dfd","updated":"2025-12-12 15:39:09.000000000","message":"I thought I tried this and it didn\u0027t quite work, let me send an update.","commit_id":"004b4c743b50236d13a39762f122a8751f1d2dd9"}]}