)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"85ee2221759d388b76dd533940459a9ad5a70f34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cc388d74_2c30c8d1","updated":"2025-12-12 10:13:43.000000000","message":"Code looks ok (and manually tested)\n\nMinor comment","commit_id":"816d076515054a73aa63ee646c0910ed242db5e7"}],"neutron/cmd/ovn/neutron_ovn_db_sync_util.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"85ee2221759d388b76dd533940459a9ad5a70f34","unresolved":true,"context_lines":[{"line_number":161,"context_line":"            return True"},{"line_number":162,"context_line":"        return ext.name \u003d\u003d driver_name"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    return enabled.EnabledExtensionManager("},{"line_number":165,"context_line":"        entry_point,"},{"line_number":166,"context_line":"        check_func\u003dload_driver,"},{"line_number":167,"context_line":"        invoke_on_load\u003dFalse)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"def load_synchronize_drivers(driver_name\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"c3b350f5_0fc13eb2","line":167,"range":{"start_line":164,"start_character":4,"end_line":167,"end_character":29},"updated":"2025-12-12 10:13:43.000000000","message":"Before returning here, I would introduce an extra check: all loaded extensions should inherit from `BaseOvnDbSynchronizer`. That will guarantee that the method `do_sync` call in `synchronize_ovn_dbs` exists.","commit_id":"816d076515054a73aa63ee646c0910ed242db5e7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4552bd33840b5518575790e37442c1d5a6865573","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            return True"},{"line_number":162,"context_line":"        return ext.name \u003d\u003d driver_name"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    return enabled.EnabledExtensionManager("},{"line_number":165,"context_line":"        entry_point,"},{"line_number":166,"context_line":"        check_func\u003dload_driver,"},{"line_number":167,"context_line":"        invoke_on_load\u003dFalse)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"def load_synchronize_drivers(driver_name\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"b2374ef0_6ca93e7a","line":167,"range":{"start_line":164,"start_character":4,"end_line":167,"end_character":29},"in_reply_to":"c3b350f5_0fc13eb2","updated":"2025-12-15 16:04:48.000000000","message":"Done","commit_id":"816d076515054a73aa63ee646c0910ed242db5e7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0efa1d33c096ee623cabc7ad64bc703ea0044057","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def load_driver(ext):"},{"line_number":161,"context_line":"        if not issubclass(ext.plugin, ovn_db_sync.BaseOvnDbSynchronizer):"},{"line_number":162,"context_line":"            LOG.error(\"Extension \u0027%s\u0027 is not an instance of \""},{"line_number":163,"context_line":"                      \"%s and will not be loaded\","},{"line_number":164,"context_line":"                      ext.name, ovn_db_sync.BaseOvnDbSynchronizer)"},{"line_number":165,"context_line":"            return False"},{"line_number":166,"context_line":"        if driver_name is None:"},{"line_number":167,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":6,"id":"5ffda752_25a7f795","line":164,"range":{"start_line":162,"start_character":12,"end_line":164,"end_character":66},"updated":"2025-12-17 08:00:33.000000000","message":"+1 thanks!","commit_id":"2faba4ede3291d49c1f74afb66fe93a73e3007ef"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_db_sync.py":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"03014a367c32612aaeb4d591973a50857a46d0a3","unresolved":true,"context_lines":[{"line_number":1480,"context_line":"        \"\"\"Method to sync the OVN_Southbound DB with neutron DB."},{"line_number":1481,"context_line":""},{"line_number":1482,"context_line":"        OvnSbSynchronizer will sync data from OVN_Southbound to neutron. And"},{"line_number":1483,"context_line":"        the synchronization will always be performed, no matter what mode it"},{"line_number":1484,"context_line":"        is."},{"line_number":1485,"context_line":"        \"\"\""},{"line_number":1486,"context_line":"        LOG.debug(\"OVN-Southbound DB sync process started @ %s\","}],"source_content_type":"text/x-python","patch_set":6,"id":"5f4385ab_1a2c6268","side":"PARENT","line":1483,"updated":"2025-12-18 09:40:33.000000000","message":"The behavior is being changed here while the commit says just about the refactoring so this change looks unintentionally changed?. Basically what being discussed in other issue https://review.opendev.org/c/openstack/neutron/+/899069/4/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_db_sync.py","commit_id":"4d2c562d2250a02b88524fcddae2066b1b17abe2"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"7c7cf7a171fcdfcdbc4245ba36044a84e74f8496","unresolved":false,"context_lines":[{"line_number":1480,"context_line":"        \"\"\"Method to sync the OVN_Southbound DB with neutron DB."},{"line_number":1481,"context_line":""},{"line_number":1482,"context_line":"        OvnSbSynchronizer will sync data from OVN_Southbound to neutron. And"},{"line_number":1483,"context_line":"        the synchronization will always be performed, no matter what mode it"},{"line_number":1484,"context_line":"        is."},{"line_number":1485,"context_line":"        \"\"\""},{"line_number":1486,"context_line":"        LOG.debug(\"OVN-Southbound DB sync process started @ %s\","}],"source_content_type":"text/x-python","patch_set":6,"id":"e721556c_69cb81e3","side":"PARENT","line":1483,"in_reply_to":"15cb9b1a_6cd8482f","updated":"2025-12-18 11:26:03.000000000","message":"Yes correct, or readding i see the mode is not being used in SBsynchroizer, thx for clarifying.","commit_id":"4d2c562d2250a02b88524fcddae2066b1b17abe2"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"737fe1c0ef357a749a7d1643c0fd15c364f2c6b7","unresolved":true,"context_lines":[{"line_number":1480,"context_line":"        \"\"\"Method to sync the OVN_Southbound DB with neutron DB."},{"line_number":1481,"context_line":""},{"line_number":1482,"context_line":"        OvnSbSynchronizer will sync data from OVN_Southbound to neutron. And"},{"line_number":1483,"context_line":"        the synchronization will always be performed, no matter what mode it"},{"line_number":1484,"context_line":"        is."},{"line_number":1485,"context_line":"        \"\"\""},{"line_number":1486,"context_line":"        LOG.debug(\"OVN-Southbound DB sync process started @ %s\","}],"source_content_type":"text/x-python","patch_set":6,"id":"15cb9b1a_6cd8482f","side":"PARENT","line":1483,"in_reply_to":"5f4385ab_1a2c6268","updated":"2025-12-18 09:47:22.000000000","message":"actually I don\u0027t think it is being changed. Yes, \"mode\" is now passed to the __init__ method of this synchronizer class but regardless of the value it will be performed. The only thing which have changed is that now user can run sync plugins selectively and in such case it may not be performed. But when this plugin is loaded then it will run always, regardless of the mode value. Am I missing something there?","commit_id":"4d2c562d2250a02b88524fcddae2066b1b17abe2"}]}