)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"c2bdcc9299b269db3bc7c24a7bc74f02c196a75f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When VM do not have fixed_ip, Allowed address pair rules"},{"line_number":10,"context_line":"should not allow all the IPs by default."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iad841f55ae176f30fdbeb81cebb0bcbcc1ea907e"},{"line_number":13,"context_line":"Closes-Bug: #1325986"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ae5cdf2_fabe2e64","line":11,"updated":"2014-06-04 03:52:37.000000000","message":"Add \u0027DocImpact\u0027 here.\n\nThis changes the behavior of the allowed address pairs.","commit_id":"b53815b84dbfe9a72231fa9f620b8e3668051329"},{"author":{"_account_id":9820,"name":"Liping Mao","email":"limao@cisco.com","username":"LipingMao"},"change_message_id":"265ddccf5d6dabefade07e5180f0c7c85824aada","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When VM do not have fixed_ip, Allowed address pair rules"},{"line_number":10,"context_line":"should not allow all the IPs by default."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iad841f55ae176f30fdbeb81cebb0bcbcc1ea907e"},{"line_number":13,"context_line":"Closes-Bug: #1325986"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ae5cdf2_f539e1a4","line":11,"in_reply_to":"1ae5cdf2_fabe2e64","updated":"2014-06-04 04:16:23.000000000","message":"Thanks for your review, Done","commit_id":"b53815b84dbfe9a72231fa9f620b8e3668051329"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"28c152f28a16b25e1b0500e4225c28f48e91cefd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allowed address pair rule error when VM without fixed_ip"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When VM do not have fixed_ip, Allowed address pair rules"},{"line_number":10,"context_line":"should not allow all the IPs by default."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1ae5cdf2_dd72b010","line":9,"updated":"2014-06-17 05:32:21.000000000","message":"This description does not help to understand the patch, it is just the same text that is included in the bug. Please, re-phrase it explaining a little bit the fix.","commit_id":"d54259687391cfc9f92e7e01d24950b2ced017c5"},{"author":{"_account_id":9820,"name":"Liping Mao","email":"limao@cisco.com","username":"LipingMao"},"change_message_id":"d0f90462e253352302fbe79766dfe4711fd94a09","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allowed address pair rule error when VM without fixed_ip"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When VM do not have fixed_ip, Allowed address pair rules"},{"line_number":10,"context_line":"should not allow all the IPs by default."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1ae5cdf2_10d4ff45","line":9,"in_reply_to":"1ae5cdf2_dd72b010","updated":"2014-06-17 05:57:28.000000000","message":"Done","commit_id":"d54259687391cfc9f92e7e01d24950b2ced017c5"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"28c152f28a16b25e1b0500e4225c28f48e91cefd","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"DocImpact"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Iad841f55ae176f30fdbeb81cebb0bcbcc1ea907e"},{"line_number":15,"context_line":"Closes-Bug: #1325986"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1ae5cdf2_9d2108ff","line":14,"updated":"2014-06-17 05:32:21.000000000","message":"Which part of the docs will be impacted?","commit_id":"d54259687391cfc9f92e7e01d24950b2ced017c5"},{"author":{"_account_id":9820,"name":"Liping Mao","email":"limao@cisco.com","username":"LipingMao"},"change_message_id":"d0f90462e253352302fbe79766dfe4711fd94a09","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"DocImpact"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Iad841f55ae176f30fdbeb81cebb0bcbcc1ea907e"},{"line_number":15,"context_line":"Closes-Bug: #1325986"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1ae5cdf2_90f48fd0","line":14,"in_reply_to":"1ae5cdf2_9d2108ff","updated":"2014-06-17 05:57:28.000000000","message":"I think we can add some descriptions about the VM without fixed_ips in following doc maybe.\n\nhttp://docs.openstack.org/api/openstack-network/2.0/content/allowed_address_pair_ext.html","commit_id":"d54259687391cfc9f92e7e01d24950b2ced017c5"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"9a542dd037220ce8137dc50a99a9755309883bd1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When VM do not have fixed_ip, the default iptables rule"},{"line_number":10,"context_line":"will allowed all the IPs in ip spoof chain. But in fact,"},{"line_number":11,"context_line":"the dedault rule should deny all the IPs. So I modify"},{"line_number":12,"context_line":"the default rule when VM do not have fixed_ip."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1ae5cdf2_d6abf485","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":11},"updated":"2014-06-27 06:27:46.000000000","message":"default","commit_id":"2c273e0b968add0fcceca52cdf57773a231a29db"},{"author":{"_account_id":9820,"name":"Liping Mao","email":"limao@cisco.com","username":"LipingMao"},"change_message_id":"2742813815f0d26134b54fa43e0d18c94cfc6b64","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When VM do not have fixed_ip, the default iptables rule"},{"line_number":10,"context_line":"will allowed all the IPs in ip spoof chain. But in fact,"},{"line_number":11,"context_line":"the dedault rule should deny all the IPs. So I modify"},{"line_number":12,"context_line":"the default rule when VM do not have fixed_ip."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"baada198_60f71f5a","line":11,"in_reply_to":"1ae5cdf2_d6abf485","updated":"2014-07-10 02:48:07.000000000","message":"Done","commit_id":"2c273e0b968add0fcceca52cdf57773a231a29db"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"d6a6e2bebc851159da81f025890dfcdf641effcb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allowed address pair rule error when VM without fixed_ip"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When VM do not have fixed_ip, the default iptables rule"},{"line_number":10,"context_line":"will allowed all the IPs in ip spoof chain. But in fact,"},{"line_number":11,"context_line":"the default rule should deny all the IPs. So I modify"},{"line_number":12,"context_line":"the default rule when VM do not have fixed_ip."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa98f980_d6d53bba","line":9,"updated":"2014-09-08 12:10:15.000000000","message":"VM do -\u003e a VM does","commit_id":"6cf0da0f4534388c7fc70a309f906a08f2d2245f"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"d6a6e2bebc851159da81f025890dfcdf641effcb","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Allowed address pair rule error when VM without fixed_ip"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When VM do not have fixed_ip, the default iptables rule"},{"line_number":10,"context_line":"will allowed all the IPs in ip spoof chain. But in fact,"},{"line_number":11,"context_line":"the default rule should deny all the IPs. So I modify"},{"line_number":12,"context_line":"the default rule when VM do not have fixed_ip."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1abeadc6_ef067c1b","line":10,"updated":"2014-09-08 12:10:15.000000000","message":"allowed -\u003e allow","commit_id":"6cf0da0f4534388c7fc70a309f906a08f2d2245f"}],"neutron/agent/linux/iptables_firewall.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"2f5922e6c313fa47a2851ae885cc525b73cc5311","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            chain_name \u003d self._port_chain_name(port, SPOOF_FILTER)"},{"line_number":191,"context_line":"            table.add_chain(chain_name)"},{"line_number":192,"context_line":"            for mac, ip in mac_ip_pairs:"},{"line_number":193,"context_line":"                if ip:"},{"line_number":194,"context_line":"                    table.add_rule(chain_name,"},{"line_number":195,"context_line":"                                   \u0027-m mac --mac-source %s -s %s -j RETURN\u0027"},{"line_number":196,"context_line":"                                   % (mac, ip))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_ab7ffaa9","line":193,"range":{"start_line":193,"start_character":16,"end_line":193,"end_character":22},"updated":"2014-06-04 06:12:33.000000000","message":"how about stopping adding None to the list and kill this conditional?","commit_id":"b1fbaa4b2fd4384d46d906935a4701191a918d4f"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"2f5922e6c313fa47a2851ae885cc525b73cc5311","unresolved":false,"context_lines":[{"line_number":224,"context_line":"                                           mac_ipv4_pairs, mac_ipv6_pairs)"},{"line_number":225,"context_line":"        if not port[\u0027fixed_ips\u0027]:"},{"line_number":226,"context_line":"            mac_ipv4_pairs.append((port[\u0027mac_address\u0027], None))"},{"line_number":227,"context_line":"            mac_ipv6_pairs.append((port[\u0027mac_address\u0027], None))"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        self._setup_spoof_filter_chain(port, self.iptables.ipv4[\u0027filter\u0027],"},{"line_number":230,"context_line":"                                       mac_ipv4_pairs, ipv4_rules)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_aba8da20","line":227,"updated":"2014-06-04 06:12:33.000000000","message":"how about removing L225-227 ?","commit_id":"b1fbaa4b2fd4384d46d906935a4701191a918d4f"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"54c546b62364205a95265573d1f3b8a574009697","unresolved":false,"context_lines":[{"line_number":188,"context_line":"    def _setup_spoof_filter_chain(self, port, table, mac_ip_pairs, rules):"},{"line_number":189,"context_line":"        chain_name \u003d self._port_chain_name(port, SPOOF_FILTER)"},{"line_number":190,"context_line":"        table.add_chain(chain_name)"},{"line_number":191,"context_line":"        if mac_ip_pairs:"},{"line_number":192,"context_line":"            for mac, ip in mac_ip_pairs:"},{"line_number":193,"context_line":"                table.add_rule(chain_name,"},{"line_number":194,"context_line":"                               \u0027-m mac --mac-source %s -s %s -j RETURN\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_32b8bac7","line":191,"range":{"start_line":191,"start_character":8,"end_line":191,"end_character":24},"updated":"2014-06-04 07:21:16.000000000","message":"this conditional seems redundant","commit_id":"fdafe79be1b223efe121953221bb16f94b498b63"},{"author":{"_account_id":9820,"name":"Liping Mao","email":"limao@cisco.com","username":"LipingMao"},"change_message_id":"c37cc2daeb1982711078666557ac2b51cccebec3","unresolved":false,"context_lines":[{"line_number":188,"context_line":"    def _setup_spoof_filter_chain(self, port, table, mac_ip_pairs, rules):"},{"line_number":189,"context_line":"        chain_name \u003d self._port_chain_name(port, SPOOF_FILTER)"},{"line_number":190,"context_line":"        table.add_chain(chain_name)"},{"line_number":191,"context_line":"        if mac_ip_pairs:"},{"line_number":192,"context_line":"            for mac, ip in mac_ip_pairs:"},{"line_number":193,"context_line":"                table.add_rule(chain_name,"},{"line_number":194,"context_line":"                               \u0027-m mac --mac-source %s -s %s -j RETURN\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_95a898dc","line":191,"in_reply_to":"1ae5cdf2_32b8bac7","updated":"2014-06-04 07:39:15.000000000","message":"Thanks for your review.\nDone","commit_id":"fdafe79be1b223efe121953221bb16f94b498b63"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"d6a6e2bebc851159da81f025890dfcdf641effcb","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        table.add_chain(chain_name)"},{"line_number":189,"context_line":"        for mac, ip in mac_ip_pairs:"},{"line_number":190,"context_line":"            table.add_rule(chain_name,"},{"line_number":191,"context_line":"                           \u0027-m mac --mac-source %s -s %s -j RETURN\u0027"},{"line_number":192,"context_line":"                           % (mac, ip))"},{"line_number":193,"context_line":"        table.add_rule(chain_name, \u0027-j DROP\u0027)"},{"line_number":194,"context_line":"        rules.append(\u0027-j $%s\u0027 % chain_name)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa98f980_568f8bcc","line":191,"updated":"2014-09-08 12:10:15.000000000","message":"nit: since \u003e 1 value used, could use named format specifier and dict.","commit_id":"6cf0da0f4534388c7fc70a309f906a08f2d2245f"}]}