)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"94fd71a13a89624968c4c8d725157876672a42ce","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     vikas \u003cvikas.d-m@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-06 19:25:18 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix for considering vpn objects while clearing"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"adding unit test cases"},{"line_number":10,"context_line":"router interface and router gateway."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_8851dada","line":7,"updated":"2014-06-09 08:18:48.000000000","message":"Be a little more specific about what this is affecting.\n\ne.g. \"Stop changes to router resources used by VPNaaS\"","commit_id":"2aff83c6670d3e54a17b94da743bc4a27e5b0e2f"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"94fd71a13a89624968c4c8d725157876672a42ce","unresolved":false,"context_lines":[{"line_number":7,"context_line":"fix for considering vpn objects while clearing"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"adding unit test cases"},{"line_number":10,"context_line":"router interface and router gateway."},{"line_number":11,"context_line":"Closes-Bug:1261598"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I7df2b8b130b47ec070d0b0a36b1a62df40532760"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_48f512ca","line":10,"updated":"2014-06-09 08:18:48.000000000","message":"Elaborate on this a little more. Naming two resources is too vague to have any idea what this patch is doing.","commit_id":"2aff83c6670d3e54a17b94da743bc4a27e5b0e2f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"5c332426206a992e9af0ff9fee0ef0aa6468631b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"we need to check if any VPN services are"},{"line_number":11,"context_line":"associated with that router."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Patchset5"},{"line_number":14,"context_line":"Rebased to latest code"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Patchset4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"baada198_50b6178a","line":13,"updated":"2014-08-01 14:41:53.000000000","message":"this history in the message is not necessary, please remove.","commit_id":"8eeefc525b0037d9eb81e73db92365ab60ea66fd"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"ef2651698f45d2fa4ec03db9ac4e69cad87ca725","unresolved":false,"context_lines":[{"line_number":10,"context_line":"we need to check if any VPN services are"},{"line_number":11,"context_line":"associated with that router."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Patchset5"},{"line_number":14,"context_line":"Rebased to latest code"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Patchset4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"baada198_e765b0b0","line":13,"in_reply_to":"baada198_50b6178a","updated":"2014-08-01 15:06:03.000000000","message":"+1","commit_id":"8eeefc525b0037d9eb81e73db92365ab60ea66fd"},{"author":{"_account_id":12737,"name":"Jacek Swiderski","email":"jacek.swiderski@codilime.com","username":"Altran"},"change_message_id":"d64205338fb7a4a6c6c3b8bdcde63576af5d59d0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"we need to check if any VPN services are"},{"line_number":11,"context_line":"associated with that router."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"patchset 7"},{"line_number":14,"context_line":"Changed according to juno code."},{"line_number":15,"context_line":"Added one more unit test case for updating the router"},{"line_number":16,"context_line":"while vpn is active."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7ac7a964_337e94af","line":13,"updated":"2014-08-14 09:29:44.000000000","message":"I think this is unnecessary - You can write it in comments to review maybe ? I\u0027m not sure where is appropriate place to put it if You want to do such summary of changes","commit_id":"0abab152f8c7fe1b9df06fc7a2ea6ca9841f1150"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"7d55ae6878f9272ff7389244f744df9394b44eac","unresolved":false,"context_lines":[{"line_number":10,"context_line":"we need to check if any VPN services are"},{"line_number":11,"context_line":"associated with that router."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"patchset 7"},{"line_number":14,"context_line":"Changed according to juno code."},{"line_number":15,"context_line":"Added one more unit test case for updating the router"},{"line_number":16,"context_line":"while vpn is active."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"baa201ad_1ff43a86","line":13,"in_reply_to":"7ac7a964_337e94af","updated":"2014-10-10 08:02:26.000000000","message":"+1","commit_id":"0abab152f8c7fe1b9df06fc7a2ea6ca9841f1150"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"50ebe1b45c9205a32efb29800990af3ca9d58b90","unresolved":false,"context_lines":[{"line_number":10,"context_line":"we need to check if any VPN services are"},{"line_number":11,"context_line":"associated with that router."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"patchset 7"},{"line_number":14,"context_line":"Changed according to juno code."},{"line_number":15,"context_line":"Added one more unit test case for updating the router"},{"line_number":16,"context_line":"while vpn is active."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"baa201ad_ee70a675","line":13,"in_reply_to":"baa201ad_1ff43a86","updated":"2014-10-10 10:53:42.000000000","message":"+1","commit_id":"0abab152f8c7fe1b9df06fc7a2ea6ca9841f1150"}],"neutron/db/l3_db.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"5c332426206a992e9af0ff9fee0ef0aa6468631b","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        vpnservice \u003d manager.NeutronManager.get_service_plugins().get("},{"line_number":165,"context_line":"            constants.VPN)"},{"line_number":166,"context_line":"        if vpnservice:"},{"line_number":167,"context_line":"            vpnservice.check_router_in_use(context, id)"},{"line_number":168,"context_line":"        gw_info \u003d r.pop(EXTERNAL_GW_INFO, attributes.ATTR_NOT_SPECIFIED)"},{"line_number":169,"context_line":"        # check whether router needs and can be rescheduled to the proper"},{"line_number":170,"context_line":"        # l3 agent (associated with given external network);"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_e45bee20","line":167,"updated":"2014-08-01 14:41:53.000000000","message":"This way we are preventing *all* update operations when a vpn is active. Like changing the name or Bringing admin status from up to down.\n\nIs that really what we want to do?","commit_id":"8eeefc525b0037d9eb81e73db92365ab60ea66fd"},{"author":{"_account_id":11447,"name":"vikas","email":"vikas.d-m@hpe.com","username":"vikas"},"change_message_id":"7ebeec94b3bedab9b7d00961710005c7b8ab0cae","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        vpnservice \u003d manager.NeutronManager.get_service_plugins().get("},{"line_number":165,"context_line":"            constants.VPN)"},{"line_number":166,"context_line":"        if vpnservice:"},{"line_number":167,"context_line":"            vpnservice.check_router_in_use(context, id)"},{"line_number":168,"context_line":"        gw_info \u003d r.pop(EXTERNAL_GW_INFO, attributes.ATTR_NOT_SPECIFIED)"},{"line_number":169,"context_line":"        # check whether router needs and can be rescheduled to the proper"},{"line_number":170,"context_line":"        # l3 agent (associated with given external network);"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_c5b5f27d","line":167,"in_reply_to":"baada198_67d7e022","updated":"2014-08-02 05:32:07.000000000","message":"yes we should prevent gateway related operation only,this function has been modified in juno  ,earlier when i submitted this check,the  function in icehouse GA was like\ndef update_router(self, context, id, router):\n        r \u003d router[\u0027router\u0027]\n        has_gw_info \u003d False\n        if EXTERNAL_GW_INFO in r:\n            has_gw_info \u003d True\n            gw_info \u003d r[EXTERNAL_GW_INFO]\n            (vpn check)\n            del r[EXTERNAL_GW_INFO]\n        with context.session.begin(subtransactions\u003dTrue):","commit_id":"8eeefc525b0037d9eb81e73db92365ab60ea66fd"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"ef2651698f45d2fa4ec03db9ac4e69cad87ca725","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        vpnservice \u003d manager.NeutronManager.get_service_plugins().get("},{"line_number":165,"context_line":"            constants.VPN)"},{"line_number":166,"context_line":"        if vpnservice:"},{"line_number":167,"context_line":"            vpnservice.check_router_in_use(context, id)"},{"line_number":168,"context_line":"        gw_info \u003d r.pop(EXTERNAL_GW_INFO, attributes.ATTR_NOT_SPECIFIED)"},{"line_number":169,"context_line":"        # check whether router needs and can be rescheduled to the proper"},{"line_number":170,"context_line":"        # l3 agent (associated with given external network);"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_67d7e022","line":167,"in_reply_to":"baada198_e45bee20","updated":"2014-08-01 15:06:03.000000000","message":"I agree, we should prevent gateway related operation only, right?","commit_id":"8eeefc525b0037d9eb81e73db92365ab60ea66fd"}],"neutron/db/vpn/vpn_db.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"94b33e0dcd3bf3cec303370fb9b96b1615d5e35b","unresolved":false,"context_lines":[{"line_number":633,"context_line":"                vpnservice_id\u003dvpnservices[0][\u0027id\u0027])"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"    def check_subnet_in_use(self, context, subnet_id):"},{"line_number":636,"context_line":"        vpnservices \u003d self.get_vpnservices("},{"line_number":637,"context_line":"            context, filters\u003d{\u0027subnet_id\u0027: [subnet_id]})"},{"line_number":638,"context_line":"        if vpnservices:"},{"line_number":639,"context_line":"            raise vpnaas.SubnetInUseByVPNService("}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_cb770a9e","line":636,"updated":"2014-06-10 23:57:51.000000000","message":"Why do we need to go through the collection interface?  Should be able to query on class directly.","commit_id":"b62d2a87356d6f44a6342dfd20c77052f6f70081"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"6dc9f15f26df40f7b67de8ff6e6f55e468e9b449","unresolved":false,"context_lines":[{"line_number":633,"context_line":"                vpnservice_id\u003dvpnservices[0][\u0027id\u0027])"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"    def check_subnet_in_use(self, context, subnet_id):"},{"line_number":636,"context_line":"        vpnservices \u003d self.get_vpnservices("},{"line_number":637,"context_line":"            context, filters\u003d{\u0027subnet_id\u0027: [subnet_id]})"},{"line_number":638,"context_line":"        if vpnservices:"},{"line_number":639,"context_line":"            raise vpnaas.SubnetInUseByVPNService("}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_c7592437","line":636,"in_reply_to":"1ae5cdf2_ca0a9689","updated":"2014-06-23 16:00:55.000000000","message":"The other interface is more expensive because you\u0027re making a call, invoking the a less efficient query and invoking serialization that you\u0027re throwing away when you want a count.\n\n replace line 636-7 with:\n\nwith context.session.begin(subtransactions\u003dTrue):\n    if context.session.query(VPNService).filter_by(subent_id\u003dsubnet_id).first():","commit_id":"b62d2a87356d6f44a6342dfd20c77052f6f70081"},{"author":{"_account_id":11447,"name":"vikas","email":"vikas.d-m@hpe.com","username":"vikas"},"change_message_id":"8eaffc396f728a9a675f56baebcf0ddafef5ee4f","unresolved":false,"context_lines":[{"line_number":633,"context_line":"                vpnservice_id\u003dvpnservices[0][\u0027id\u0027])"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"    def check_subnet_in_use(self, context, subnet_id):"},{"line_number":636,"context_line":"        vpnservices \u003d self.get_vpnservices("},{"line_number":637,"context_line":"            context, filters\u003d{\u0027subnet_id\u0027: [subnet_id]})"},{"line_number":638,"context_line":"        if vpnservices:"},{"line_number":639,"context_line":"            raise vpnaas.SubnetInUseByVPNService("}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_ca0a9689","line":636,"in_reply_to":"1ae5cdf2_cb770a9e","updated":"2014-06-11 10:12:47.000000000","message":"we need to go through the collection interface in order to get the particular vpnservice filtered by subnet_id.","commit_id":"b62d2a87356d6f44a6342dfd20c77052f6f70081"}],"neutron/extensions/vpnaas.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"56e60f0a75096a8c9682615f19a8bdce6eb9fb10","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class SubnetInUseByVPNService(qexception.InUse):"},{"line_number":70,"context_line":"    message \u003d _(\"Subnet %(subnet_id)s is used by VPNService %(vpnservice_id)s\")"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"class VPNStateInvalidToUpdate(qexception.BadRequest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_c0da3716","line":70,"updated":"2014-06-05 08:10:46.000000000","message":"If you are going to provide a vpnservice_id, make this take a list and then provide all of the ids that the subnet is being used by. Otherwise it\u0027s misleading to the user because they will see one error, delete one, get another error, and so on.","commit_id":"480e15827921133389aa9b9a6ec108295ab53221"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"207f26d81e797e4b47405b50452f23719a12d279","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class SubnetInUseByVPNService(qexception.InUse):"},{"line_number":70,"context_line":"    message \u003d _(\"Subnet %(subnet_id)s is used by VPNService %(vpnservice_id)s\")"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"class VPNStateInvalidToUpdate(qexception.BadRequest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_992245a1","line":70,"in_reply_to":"1ae5cdf2_1ac70865","updated":"2014-06-06 05:24:57.000000000","message":"That makes sense. I noticed on the file that calls this that it was just grabbing the first vpnservice in the list so I just assumed there could be more than one.","commit_id":"480e15827921133389aa9b9a6ec108295ab53221"},{"author":{"_account_id":11447,"name":"vikas","email":"vikas.d-m@hpe.com","username":"vikas"},"change_message_id":"15f1f1657a846c2f35f148437e00b88f5463a23f","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class SubnetInUseByVPNService(qexception.InUse):"},{"line_number":70,"context_line":"    message \u003d _(\"Subnet %(subnet_id)s is used by VPNService %(vpnservice_id)s\")"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"class VPNStateInvalidToUpdate(qexception.BadRequest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_1ac70865","line":70,"in_reply_to":"1ae5cdf2_c0da3716","updated":"2014-06-06 03:25:59.000000000","message":"since we can attach only one router to one subnet and there is only one vpnservice object for a subnet.so there is only one vpnservice_id per subnet.","commit_id":"480e15827921133389aa9b9a6ec108295ab53221"}],"neutron/tests/unit/db/vpn/test_db_vpnaas.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"5c332426206a992e9af0ff9fee0ef0aa6468631b","unresolved":false,"context_lines":[{"line_number":869,"context_line":"                                          if k in expected),"},{"line_number":870,"context_line":"                                     expected)"},{"line_number":871,"context_line":""},{"line_number":872,"context_line":"    def test_delete_router_interface_in_use_by_vpnservice(self):"},{"line_number":873,"context_line":"        \"\"\"Test delete router interface in use by vpn service.\"\"\""},{"line_number":874,"context_line":"        with self.subnet(cidr\u003d\u002710.2.0.0/24\u0027) as subnet:"},{"line_number":875,"context_line":"            with self.router() as router:"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_a493b6a2","line":872,"updated":"2014-08-01 14:41:53.000000000","message":"we should have a test that covers router update with a vpn active. Is there one?","commit_id":"8eeefc525b0037d9eb81e73db92365ab60ea66fd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"feebe4306e8aa40acfbde4d523f43250ae6cfd59","unresolved":false,"context_lines":[{"line_number":869,"context_line":""},{"line_number":870,"context_line":"    def test_delete_router_interface_in_use_by_vpnservice(self):"},{"line_number":871,"context_line":"        \"\"\"Test delete router interface in use by vpn service.\"\"\""},{"line_number":872,"context_line":"        with self.subnet(cidr\u003d\u002710.2.0.0/24\u0027) as subnet:"},{"line_number":873,"context_line":"            with self.router() as router:"},{"line_number":874,"context_line":"                with self.vpnservice(subnet\u003dsubnet,"},{"line_number":875,"context_line":"                                     router\u003drouter):"}],"source_content_type":"text/x-python","patch_set":8,"id":"baa201ad_257c3620","line":872,"updated":"2014-10-14 14:13:46.000000000","message":"not strictly necessary for this patch, but you could consider using contextlib.nested to simplify the structure and reduce the indentation a bit\n\nhttps://github.com/openstack/neutron/blob/master/neutron/tests/unit/db/vpn/test_db_vpnaas.py#L528","commit_id":"dcfcf31629706758cf7ace61dbf24e59c59f25d5"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"6ff281cf0b627f269a6d05fa7a1545b631712d52","unresolved":false,"context_lines":[{"line_number":897,"context_line":"                            public_sub[\u0027subnet\u0027][\u0027network_id\u0027],"},{"line_number":898,"context_line":"                            expected_code\u003dwebob.exc.HTTPConflict.code)"},{"line_number":899,"context_line":""},{"line_number":900,"context_line":"    def test_router_update_after_ipsec_site_connection(self):"},{"line_number":901,"context_line":"        \"\"\"Test case to update router after vpn connection.\"\"\""},{"line_number":902,"context_line":"        rname1 \u003d \"router_one\""},{"line_number":903,"context_line":"        rname2 \u003d \"router_two\""}],"source_content_type":"text/x-python","patch_set":8,"id":"baa201ad_ed064585","line":900,"updated":"2014-10-16 21:02:06.000000000","message":"it is nice to have this test, but I\u0027m not sure how this test connected with this bug fix. \ncould you mention this on commit message?","commit_id":"dcfcf31629706758cf7ace61dbf24e59c59f25d5"}]}
