)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"6084eb073366472b571ba73b621ca9325689b20e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"09635c13_adb01581","updated":"2026-02-26 20:04:46.000000000","message":"recheck","commit_id":"55e94b6763ae760201bc93a7f4d0c09eb637fec9"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"cc984f005b036190c24b70fd483d9122a0e96128","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3aea9629_664f54bf","updated":"2026-03-07 15:17:38.000000000","message":"hoping functional job passes","commit_id":"3f4d5dc93f762e78bf1442d94c7578702a156a7e"}],"neutron/tests/functional/agent/ovn/extensions/bgp/test_events.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"d33aa4aab835a4a560c0159c62bbcb9335d87517","unresolved":true,"context_lines":[{"line_number":333,"context_line":"            self.ovs_api.idl.notify_handler.watch_event("},{"line_number":334,"context_line":"                events.UpdateLocalOVSEvent(self.agent_api))"},{"line_number":335,"context_line":"            self.ovs_api.add_br(\u0027br-bgp-test\u0027).execute(check_error\u003dTrue)"},{"line_number":336,"context_line":"            with testtools.ExpectedException(NotCalledException):"},{"line_number":337,"context_line":"                utils.wait_until_true("},{"line_number":338,"context_line":"                    lambda: m_event.called,"},{"line_number":339,"context_line":"                    sleep\u003d0.1,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fe687329_45f79702","line":336,"updated":"2026-02-27 15:43:33.000000000","message":"I think this could just assert that event.wait() returns False, e.g. something like:\n```\ne \u003d events.UpdateLocalOVSEvent(self.agent_api, timeout\u003d5)\nself.ovs_api.idl.notify_handler.watch_event(e)\nadd_br()\nself.assertFalse(e.wait())\n```","commit_id":"55e94b6763ae760201bc93a7f4d0c09eb637fec9"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"38254c9e0b07d1601e57a2dccb2977e9a5574398","unresolved":false,"context_lines":[{"line_number":333,"context_line":"            self.ovs_api.idl.notify_handler.watch_event("},{"line_number":334,"context_line":"                events.UpdateLocalOVSEvent(self.agent_api))"},{"line_number":335,"context_line":"            self.ovs_api.add_br(\u0027br-bgp-test\u0027).execute(check_error\u003dTrue)"},{"line_number":336,"context_line":"            with testtools.ExpectedException(NotCalledException):"},{"line_number":337,"context_line":"                utils.wait_until_true("},{"line_number":338,"context_line":"                    lambda: m_event.called,"},{"line_number":339,"context_line":"                    sleep\u003d0.1,"}],"source_content_type":"text/x-python","patch_set":1,"id":"d7d4712e_307b4326","line":336,"in_reply_to":"905bd7b6_cdd27898","updated":"2026-03-04 20:18:26.000000000","message":"done","commit_id":"55e94b6763ae760201bc93a7f4d0c09eb637fec9"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"b20672bc111ca3c05493f1598f49910e2a963123","unresolved":true,"context_lines":[{"line_number":333,"context_line":"            self.ovs_api.idl.notify_handler.watch_event("},{"line_number":334,"context_line":"                events.UpdateLocalOVSEvent(self.agent_api))"},{"line_number":335,"context_line":"            self.ovs_api.add_br(\u0027br-bgp-test\u0027).execute(check_error\u003dTrue)"},{"line_number":336,"context_line":"            with testtools.ExpectedException(NotCalledException):"},{"line_number":337,"context_line":"                utils.wait_until_true("},{"line_number":338,"context_line":"                    lambda: m_event.called,"},{"line_number":339,"context_line":"                    sleep\u003d0.1,"}],"source_content_type":"text/x-python","patch_set":1,"id":"905bd7b6_cdd27898","line":336,"in_reply_to":"e3cdd6ce_452f50a2","updated":"2026-03-03 16:41:49.000000000","message":"Yeah, my original comment was silly. My brain just assumed \"event in a test file, must be a waitevent\" 😄 This is a clever solution. I tested running db_set after the assertFalse just to verify that `th_event.wait()` does actually transition to True when it should.","commit_id":"55e94b6763ae760201bc93a7f4d0c09eb637fec9"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e62d5b6e413d2880d8fcbf3720cebf136e0c8841","unresolved":true,"context_lines":[{"line_number":333,"context_line":"            self.ovs_api.idl.notify_handler.watch_event("},{"line_number":334,"context_line":"                events.UpdateLocalOVSEvent(self.agent_api))"},{"line_number":335,"context_line":"            self.ovs_api.add_br(\u0027br-bgp-test\u0027).execute(check_error\u003dTrue)"},{"line_number":336,"context_line":"            with testtools.ExpectedException(NotCalledException):"},{"line_number":337,"context_line":"                utils.wait_until_true("},{"line_number":338,"context_line":"                    lambda: m_event.called,"},{"line_number":339,"context_line":"                    sleep\u003d0.1,"}],"source_content_type":"text/x-python","patch_set":1,"id":"e3cdd6ce_452f50a2","line":336,"in_reply_to":"fe687329_45f79702","updated":"2026-02-27 22:15:21.000000000","message":"Not exactly the wait event but under the hood it\u0027s similar. Let me know what you think.","commit_id":"55e94b6763ae760201bc93a7f4d0c09eb637fec9"}]}
