)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7dff9adf459fa5ddb182f505a28acef6d6a33e48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"48c147dd_e19b9f28","updated":"2026-03-23 16:14:17.000000000","message":"Stephen - let me know if you want me to push an update","commit_id":"8d2c1d985b9a180fd6f606286e78bf7434fa48b0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6a1413c62eb37e42c89afeb6b53904d7c4a0d106","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e30bdb1e_d2bfd3d3","updated":"2026-03-24 13:23:23.000000000","message":"recheck server failed to build","commit_id":"beb94c0d22829de906a9427413b9a79be27ab222"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"20d94ed918835b9f773250915788213f0a9336f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ba3bc8a2_ad42c5e3","updated":"2026-03-24 15:33:15.000000000","message":"recheck zuul","commit_id":"beb94c0d22829de906a9427413b9a79be27ab222"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"112b53b9cb1ab340d703d22bd28365a6201363eb","unresolved":false,"context_lines":[{"line_number":961,"context_line":"            physnet \u003d net_physnet[net_id]"},{"line_number":962,"context_line":"            if (ovn_const.OVN_NETTYPE_EXT_ID_KEY not in ls.external_ids or"},{"line_number":963,"context_line":"                    (ovn_const.OVN_PHYSNET_EXT_ID_KEY not in ls.external_ids"},{"line_number":964,"context_line":"                     and physnet)):"},{"line_number":965,"context_line":"                external_ids \u003d {"},{"line_number":966,"context_line":"                    ovn_const.OVN_NETTYPE_EXT_ID_KEY: net_type[net_id]}"},{"line_number":967,"context_line":"                if physnet:"}],"source_content_type":"text/x-python","patch_set":1,"id":"0da8cfd1_57432dba","side":"PARENT","line":964,"updated":"2026-03-23 15:47:11.000000000","message":"nit this actuly was nice to read before imo but the update is valid","commit_id":"8730dbd1599dc5778e7c92e9f004f770b7a58ffe"}],"neutron/tests/common/test_db_base_plugin_v2.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"dcfdd00f3d69d826785562b6400ece56ce70c47d","unresolved":true,"context_lines":[{"line_number":2050,"context_line":"        responses \u003d [\u002712:34:56:78:00:00\u0027, \u002712:34:56:78:00:00\u0027,"},{"line_number":2051,"context_line":"                     \u002712:34:56:78:00:01\u0027]"},{"line_number":2052,"context_line":"        with mock.patch("},{"line_number":2053,"context_line":"            \u0027neutron_lib.utils.random_mac_generator\u0027,"},{"line_number":2054,"context_line":"            return_value\u003ditertools.cycle(responses)"},{"line_number":2055,"context_line":"        ) as grand_mac:"},{"line_number":2056,"context_line":"            with self.subnet() as s:"}],"source_content_type":"text/x-python","patch_set":1,"id":"10f3bac0_dfb10fd5","line":2053,"updated":"2026-03-20 15:17:11.000000000","message":"autopep8 needs to go back to AI school :-/","commit_id":"8d2c1d985b9a180fd6f606286e78bf7434fa48b0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"112b53b9cb1ab340d703d22bd28365a6201363eb","unresolved":true,"context_lines":[{"line_number":2050,"context_line":"        responses \u003d [\u002712:34:56:78:00:00\u0027, \u002712:34:56:78:00:00\u0027,"},{"line_number":2051,"context_line":"                     \u002712:34:56:78:00:01\u0027]"},{"line_number":2052,"context_line":"        with mock.patch("},{"line_number":2053,"context_line":"            \u0027neutron_lib.utils.random_mac_generator\u0027,"},{"line_number":2054,"context_line":"            return_value\u003ditertools.cycle(responses)"},{"line_number":2055,"context_line":"        ) as grand_mac:"},{"line_number":2056,"context_line":"            with self.subnet() as s:"}],"source_content_type":"text/x-python","patch_set":1,"id":"806a2fbe_3cf9acdc","line":2053,"in_reply_to":"10f3bac0_dfb10fd5","updated":"2026-03-23 15:47:11.000000000","message":"i dont think autopep8 will actully make this chagne so i think ai or stepehn must have made it. but yes its missing the .net\nhttps://github.com/openstack/neutron-lib/blob/master/neutron_lib/utils/net.py#L48\n\nspecificly i dont think autopep8 will change form \n with mock.patch.object to  with mock.patch","commit_id":"8d2c1d985b9a180fd6f606286e78bf7434fa48b0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d95a1d0fc61148089ef6927ab5df19e144b8405a","unresolved":false,"context_lines":[{"line_number":2050,"context_line":"        responses \u003d [\u002712:34:56:78:00:00\u0027, \u002712:34:56:78:00:00\u0027,"},{"line_number":2051,"context_line":"                     \u002712:34:56:78:00:01\u0027]"},{"line_number":2052,"context_line":"        with mock.patch("},{"line_number":2053,"context_line":"            \u0027neutron_lib.utils.random_mac_generator\u0027,"},{"line_number":2054,"context_line":"            return_value\u003ditertools.cycle(responses)"},{"line_number":2055,"context_line":"        ) as grand_mac:"},{"line_number":2056,"context_line":"            with self.subnet() as s:"}],"source_content_type":"text/x-python","patch_set":1,"id":"c297600e_3b744b73","line":2053,"in_reply_to":"806a2fbe_3cf9acdc","updated":"2026-03-23 17:08:07.000000000","message":"Yeah, this was me (flake8 complained about `net` being shadowed elsewhere in the file). Fixed now.","commit_id":"8d2c1d985b9a180fd6f606286e78bf7434fa48b0"}],"tox.ini":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"dcfdd00f3d69d826785562b6400ece56ce70c47d","unresolved":true,"context_lines":[{"line_number":235,"context_line":"# TODO(amotoki) check the following new rules should be fixed or ignored"},{"line_number":236,"context_line":"# E731 do not assign a lambda expression, use a def"},{"line_number":237,"context_line":"# W504 line break after binary operator"},{"line_number":238,"context_line":"ignore \u003d E126,E128,E231,E275,E731,I202,H405,N530,W504"},{"line_number":239,"context_line":"# H106: Don\u0027t put vim configuration in source files"},{"line_number":240,"context_line":"# H203: Use assertIs(Not)None to check for None"},{"line_number":241,"context_line":"# H204: Use assert(Not)Equal to check for equality"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3e5cd78d_1c7c109a","line":238,"updated":"2026-03-20 15:17:11.000000000","message":"Is this correct? the TODO crept back in somehow?","commit_id":"8d2c1d985b9a180fd6f606286e78bf7434fa48b0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d95a1d0fc61148089ef6927ab5df19e144b8405a","unresolved":false,"context_lines":[{"line_number":235,"context_line":"# TODO(amotoki) check the following new rules should be fixed or ignored"},{"line_number":236,"context_line":"# E731 do not assign a lambda expression, use a def"},{"line_number":237,"context_line":"# W504 line break after binary operator"},{"line_number":238,"context_line":"ignore \u003d E126,E128,E231,E275,E731,I202,H405,N530,W504"},{"line_number":239,"context_line":"# H106: Don\u0027t put vim configuration in source files"},{"line_number":240,"context_line":"# H203: Use assertIs(Not)None to check for None"},{"line_number":241,"context_line":"# H204: Use assert(Not)Equal to check for equality"}],"source_content_type":"text/x-properties","patch_set":1,"id":"c89eb400_479647d5","line":238,"in_reply_to":"16c1c8d0_53f74160","updated":"2026-03-23 17:08:07.000000000","message":"I just copy-pasted this section as it existed before be77ed3a813709eebb2659b5473b890b5978c743. It looks like it shouldn\u0027t have been here in the first place. Removed.","commit_id":"8d2c1d985b9a180fd6f606286e78bf7434fa48b0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"112b53b9cb1ab340d703d22bd28365a6201363eb","unresolved":true,"context_lines":[{"line_number":235,"context_line":"# TODO(amotoki) check the following new rules should be fixed or ignored"},{"line_number":236,"context_line":"# E731 do not assign a lambda expression, use a def"},{"line_number":237,"context_line":"# W504 line break after binary operator"},{"line_number":238,"context_line":"ignore \u003d E126,E128,E231,E275,E731,I202,H405,N530,W504"},{"line_number":239,"context_line":"# H106: Don\u0027t put vim configuration in source files"},{"line_number":240,"context_line":"# H203: Use assertIs(Not)None to check for None"},{"line_number":241,"context_line":"# H204: Use assert(Not)Equal to check for equality"}],"source_content_type":"text/x-properties","patch_set":1,"id":"8819fe3b_9d7ededa","line":238,"in_reply_to":"3e5cd78d_1c7c109a","updated":"2026-03-23 15:47:11.000000000","message":"i think the ignore list is likely correct as fo the next patch\nonce the preview rules are enabled\nhttps://review.opendev.org/c/openstack/neutron/+/981522/1/pyproject.toml","commit_id":"8d2c1d985b9a180fd6f606286e78bf7434fa48b0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7dff9adf459fa5ddb182f505a28acef6d6a33e48","unresolved":true,"context_lines":[{"line_number":235,"context_line":"# TODO(amotoki) check the following new rules should be fixed or ignored"},{"line_number":236,"context_line":"# E731 do not assign a lambda expression, use a def"},{"line_number":237,"context_line":"# W504 line break after binary operator"},{"line_number":238,"context_line":"ignore \u003d E126,E128,E231,E275,E731,I202,H405,N530,W504"},{"line_number":239,"context_line":"# H106: Don\u0027t put vim configuration in source files"},{"line_number":240,"context_line":"# H203: Use assertIs(Not)None to check for None"},{"line_number":241,"context_line":"# H204: Use assert(Not)Equal to check for equality"}],"source_content_type":"text/x-properties","patch_set":1,"id":"16c1c8d0_53f74160","line":238,"in_reply_to":"8819fe3b_9d7ededa","updated":"2026-03-23 16:14:17.000000000","message":"Ack. getting pep8 working again is more important, we can address removing this ignores later.","commit_id":"8d2c1d985b9a180fd6f606286e78bf7434fa48b0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"dcfdd00f3d69d826785562b6400ece56ce70c47d","unresolved":true,"context_lines":[{"line_number":241,"context_line":"# H204: Use assert(Not)Equal to check for equality"},{"line_number":242,"context_line":"# H205: Use assert(Greater|Less)(Equal) for comparison"},{"line_number":243,"context_line":"# H904: Delay string interpolations at logging calls"},{"line_number":244,"context_line":"enable-extensions\u003dH106,H203,H204,H205,H904"},{"line_number":245,"context_line":"show-source \u003d true"},{"line_number":246,"context_line":"exclude \u003d ./.*,build,dist,doc"},{"line_number":247,"context_line":"import-order-style \u003d pep8"}],"source_content_type":"text/x-properties","patch_set":1,"id":"0359137c_111da5e6","line":244,"range":{"start_line":244,"start_character":17,"end_line":244,"end_character":18},"updated":"2026-03-20 15:17:11.000000000","message":"nit: missing spaces around \u003d","commit_id":"8d2c1d985b9a180fd6f606286e78bf7434fa48b0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"112b53b9cb1ab340d703d22bd28365a6201363eb","unresolved":true,"context_lines":[{"line_number":241,"context_line":"# H204: Use assert(Not)Equal to check for equality"},{"line_number":242,"context_line":"# H205: Use assert(Greater|Less)(Equal) for comparison"},{"line_number":243,"context_line":"# H904: Delay string interpolations at logging calls"},{"line_number":244,"context_line":"enable-extensions\u003dH106,H203,H204,H205,H904"},{"line_number":245,"context_line":"show-source \u003d true"},{"line_number":246,"context_line":"exclude \u003d ./.*,build,dist,doc"},{"line_number":247,"context_line":"import-order-style \u003d pep8"}],"source_content_type":"text/x-properties","patch_set":1,"id":"39f22aaa_e30987c5","line":244,"range":{"start_line":244,"start_character":17,"end_line":244,"end_character":18},"in_reply_to":"0359137c_111da5e6","updated":"2026-03-23 15:47:11.000000000","message":"as an asisde there is a linit for tox.ini but i advise agaisnt using it.\nlast time i tried the tox specific one it tried to auto upgrade the tox file to more modern ways of doing it and it broke things by raisign the min version.\n\na generic ini liter might be nice at some point but i dont know of any that i can recommend.","commit_id":"8d2c1d985b9a180fd6f606286e78bf7434fa48b0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"599bd941d3668b7b14161270a9d8e76604ea9c9d","unresolved":false,"context_lines":[{"line_number":241,"context_line":"# H204: Use assert(Not)Equal to check for equality"},{"line_number":242,"context_line":"# H205: Use assert(Greater|Less)(Equal) for comparison"},{"line_number":243,"context_line":"# H904: Delay string interpolations at logging calls"},{"line_number":244,"context_line":"enable-extensions\u003dH106,H203,H204,H205,H904"},{"line_number":245,"context_line":"show-source \u003d true"},{"line_number":246,"context_line":"exclude \u003d ./.*,build,dist,doc"},{"line_number":247,"context_line":"import-order-style \u003d pep8"}],"source_content_type":"text/x-properties","patch_set":1,"id":"2b737b62_ba695054","line":244,"range":{"start_line":244,"start_character":17,"end_line":244,"end_character":18},"in_reply_to":"39f22aaa_e30987c5","updated":"2026-03-23 17:08:51.000000000","message":"yeah, again this was copy-pasted from be77ed3a813709eebb2659b5473b890b5978c743 and I tried to avoid any unnecessary changes. This one is small enough though so done.","commit_id":"8d2c1d985b9a180fd6f606286e78bf7434fa48b0"}]}