)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"f6c0985daa92f1fa0856f627040a28f4f6b6043a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8b568fe1_b0faa618","updated":"2026-04-01 16:12:57.000000000","message":"Looking at the dsvm-functional logs, it looks like only the bgp tests now have .db files.\n```twilson@fedora:/tmp/opt/stack/logs/dsvm-functional-logs$ find . -name \"*.db\"|grep -v bgp|wc -l\n0\ntwilson@fedora:/tmp/opt/stack/logs/dsvm-functional-logs$ find . -name \"*.db\"|wc -l\n292\n```","commit_id":"dc4c6c481b0db5a475449df8dd36eebec5934747"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a1b7f84374538b94c16d9434c25d96d7862b0da2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"33ee23c5_ea4f010c","in_reply_to":"755d078c_5496a5b1","updated":"2026-04-02 15:16:12.000000000","message":"I found out Neutron OvsdbFixture and ovsdbapp use different naming for log and DB files. I\u0027ll change the naming for Neutron. Good catch 😊","commit_id":"dc4c6c481b0db5a475449df8dd36eebec5934747"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"effcfe13c3dae3adaefbea37ccc3674cc99f8207","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"755d078c_5496a5b1","in_reply_to":"8b568fe1_b0faa618","updated":"2026-04-01 16:25:54.000000000","message":"Maybe something with removing the setup_test_logging call? Seems weird that if we always are doing the addCleanup instead of just in _start_ovsdb_server() that it wouldn\u0027t be called.\n\nExample output from one of the non-bgp tests:\n```\n026-03-30 16:54:17.217 79281 INFO neutron.tests.functional.base [None req-1035f524-031a-4987-a121-6ba6ba40d54a - 46f70361-ba71-4bd0-9769-3573fd227c4b - - - -] File /tmp/tmpwpidd9f0/ovnnb_db.log not found\n2026-03-30 16:54:17.217 79281 INFO neutron.tests.functional.base [None req-1035f524-031a-4987-a121-6ba6ba40d54a - 46f70361-ba71-4bd0-9769-3573fd227c4b - - - -] File /tmp/tmpwpidd9f0/ovnnb_db.db not found\n2026-03-30 16:54:17.218 79281 INFO neutron.tests.functional.base [None req-1035f524-031a-4987-a121-6ba6ba40d54a - 46f70361-ba71-4bd0-9769-3573fd227c4b - - - -] File /tmp/tmpwpidd9f0/ovnsb_db.log not found\n2026-03-30 16:54:17.218 79281 INFO neutron.tests.functional.base [None req-1035f524-031a-4987-a121-6ba6ba40d54a - 46f70361-ba71-4bd0-9769-3573fd227c4b - - - -] File /tmp/tmpwpidd9f0/ovnsb_db.db not found\n2026-03-30 16:54:17.218 79281 INFO neutron.tests.functional.base [None req-1035f524-031a-4987-a121-6ba6ba40d54a - 46f70361-ba71-4bd0-9769-3573fd227c4b - - - -] File /tmp/tmpwpidd9f0/db.log not found\n2026-03-30 16:54:17.218 79281 INFO neutron.tests.functional.base [None req-1035f524-031a-4987-a121-6ba6ba40d54a - 46f70361-ba71-4bd0-9769-3573fd227c4b - - - -] File /tmp/tmpwpidd9f0/db.db not found```\n```\nA northd log file was all that was in the directory.","commit_id":"dc4c6c481b0db5a475449df8dd36eebec5934747"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"8fe875c1af384334cbbff78059058f1b39147cf1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0c2935f2_f786bed9","updated":"2026-04-02 15:20:29.000000000","message":"Pushed new PS by accident, there were uncommited changes.","commit_id":"821dff4c54a16e849548f95e9a1435e922d010ff"}],"neutron/tests/functional/base.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"445483e715a5ff76459e56da4529e3524438bf37","unresolved":true,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def __init__(self, source_dir, test_id):"},{"line_number":75,"context_line":"        self.source_dir \u003d source_dir"},{"line_number":76,"context_line":"        self.destination_dir \u003d os.path.join(DEFAULT_LOG_DIR, test_id)"},{"line_number":77,"context_line":"        fileutils.ensure_tree(self.destination_dir, mode\u003d0o755)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def copy_file(self, src_filename, dst_filename):"}],"source_content_type":"text/x-python","patch_set":1,"id":"2a193fff_342a9f1f","line":76,"range":{"start_line":76,"start_character":44,"end_line":76,"end_character":59},"updated":"2026-03-27 20:20:29.000000000","message":"This should be the self.DEFAULT_LOG_DIR","commit_id":"2a97351f73bf887244573a2970de86a8ae9da535"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"bcd454c72e297a2ff4f1349491198b9896f3c7f3","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def __init__(self, source_dir, test_id):"},{"line_number":75,"context_line":"        self.source_dir \u003d source_dir"},{"line_number":76,"context_line":"        self.destination_dir \u003d os.path.join(DEFAULT_LOG_DIR, test_id)"},{"line_number":77,"context_line":"        fileutils.ensure_tree(self.destination_dir, mode\u003d0o755)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def copy_file(self, src_filename, dst_filename):"}],"source_content_type":"text/x-python","patch_set":1,"id":"426d9c40_00085cb2","line":76,"range":{"start_line":76,"start_character":44,"end_line":76,"end_character":59},"in_reply_to":"2a193fff_342a9f1f","updated":"2026-03-30 11:58:58.000000000","message":"Done","commit_id":"2a97351f73bf887244573a2970de86a8ae9da535"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"f6c0985daa92f1fa0856f627040a28f4f6b6043a","unresolved":true,"context_lines":[{"line_number":67,"context_line":"                               \u0027dsvm-functional-logs\u0027)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class LogCollector:"},{"line_number":71,"context_line":"    # Store it to the class in case we want to remove the global variable"},{"line_number":72,"context_line":"    DEFAULT_LOG_DIR \u003d DEFAULT_LOG_DIR"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2b80d7_c058f61b","line":70,"updated":"2026-04-01 16:12:57.000000000","message":"Could this be a Fixture and using useFixture automatically do the addCleanup?","commit_id":"dc4c6c481b0db5a475449df8dd36eebec5934747"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a41ddfaa4d1c8add0d4542e8ed4ac7134bd01aa3","unresolved":true,"context_lines":[{"line_number":67,"context_line":"                               \u0027dsvm-functional-logs\u0027)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class LogCollector:"},{"line_number":71,"context_line":"    # Store it to the class in case we want to remove the global variable"},{"line_number":72,"context_line":"    DEFAULT_LOG_DIR \u003d DEFAULT_LOG_DIR"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"a6f67397_33b1f43a","line":70,"in_reply_to":"7a2b80d7_c058f61b","updated":"2026-04-02 14:18:00.000000000","message":"Great idea!","commit_id":"dc4c6c481b0db5a475449df8dd36eebec5934747"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a1b7f84374538b94c16d9434c25d96d7862b0da2","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                               \u0027dsvm-functional-logs\u0027)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class LogCollector:"},{"line_number":71,"context_line":"    # Store it to the class in case we want to remove the global variable"},{"line_number":72,"context_line":"    DEFAULT_LOG_DIR \u003d DEFAULT_LOG_DIR"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"6a83735c_9a4f725e","line":70,"in_reply_to":"a6f67397_33b1f43a","updated":"2026-04-02 15:16:12.000000000","message":"Done","commit_id":"dc4c6c481b0db5a475449df8dd36eebec5934747"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"9606839f974fdda76958992c4fed29bc5cad8329","unresolved":true,"context_lines":[{"line_number":100,"context_line":"                dst_filename \u003d f\"{database}-{timestamp}.{file_suffix}\""},{"line_number":101,"context_line":"                files_to_copy.append((src_filename, dst_filename))"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        ovn_northd \u003d \"ovn_northd\""},{"line_number":104,"context_line":"        files_to_copy.append("},{"line_number":105,"context_line":"            (f\"{ovn_northd}.log\", f\"{ovn_northd}-{timestamp}.log\"))"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"b1b700ed_22312135","line":103,"updated":"2026-04-02 21:23:50.000000000","message":"This seems a little weird since ovn_northd is not a variable string and is being used as though it is in the f-string instead of just typing \"ovn_northd\" there.","commit_id":"43b9b3c8d446dcf6455800cfedcd3ce51b211c61"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6bb6ed02fb472ce5cb2d97ec75a0ee5bcc00441f","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                dst_filename \u003d f\"{database}-{timestamp}.{file_suffix}\""},{"line_number":101,"context_line":"                files_to_copy.append((src_filename, dst_filename))"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        ovn_northd \u003d \"ovn_northd\""},{"line_number":104,"context_line":"        files_to_copy.append("},{"line_number":105,"context_line":"            (f\"{ovn_northd}.log\", f\"{ovn_northd}-{timestamp}.log\"))"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"97abdea6_720009ce","line":103,"in_reply_to":"1fe61cb6_28fde3e1","updated":"2026-04-06 12:19:44.000000000","message":"Done","commit_id":"43b9b3c8d446dcf6455800cfedcd3ce51b211c61"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0c4becab50d3c82f873ca8793ccf311980854210","unresolved":true,"context_lines":[{"line_number":100,"context_line":"                dst_filename \u003d f\"{database}-{timestamp}.{file_suffix}\""},{"line_number":101,"context_line":"                files_to_copy.append((src_filename, dst_filename))"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        ovn_northd \u003d \"ovn_northd\""},{"line_number":104,"context_line":"        files_to_copy.append("},{"line_number":105,"context_line":"            (f\"{ovn_northd}.log\", f\"{ovn_northd}-{timestamp}.log\"))"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1fe61cb6_28fde3e1","line":103,"in_reply_to":"b1b700ed_22312135","updated":"2026-04-03 12:21:54.000000000","message":"That\u0027s what I changed, right? I also noticed I made a typo, a dash instead of the used underscore","commit_id":"43b9b3c8d446dcf6455800cfedcd3ce51b211c61"}]}
