)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b4cf538f81fd79fc3699f0fb5cddc9e21ed254a5","unresolved":true,"context_lines":[{"line_number":15,"context_line":"configured behavior. Documentation and release notes explain how to flip"},{"line_number":16,"context_line":"the knob when rolling out stateless security groups."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Related-RHOSRFE: https://redhat.atlassian.net/browse/RHOSRFE-249"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I300299262d1df0f45f0be4002687f508d55efc3c"},{"line_number":21,"context_line":"Signed-off-by: Yusho Yamaguchi \u003cys-yamaguchi@kddi.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"58c42da8_8d6f8a0d","line":18,"updated":"2026-03-29 23:06:24.000000000","message":"You need to create a neutron RFE bug to reference here, as the redhat link could go away at some time. See one of these two for reference:\n\ncontributor/contributing.rst\ncontributor/policies/bugs.rst\n\nWe would also need to meed to discuss this as it\u0027s a new feature, and there could be a more preferred way of doing this. For example, it could be part of the default SG extension template perhaps?\n\nThis could also be something we can add to the upcoming PTG agenda, I have been collecting ideas here - https://etherpad.opendev.org/p/apr2026-ptg-neutron","commit_id":"b72ccdcff7591f3a784d2976a1dfc73645bc631c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f5dcb5937de6ed5b5c97115eb97ac0975d749b2e","unresolved":true,"context_lines":[{"line_number":15,"context_line":"configured behavior. Documentation and release notes explain how to flip"},{"line_number":16,"context_line":"the knob when rolling out stateless security groups."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Related-RHOSRFE: https://redhat.atlassian.net/browse/RHOSRFE-249"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I300299262d1df0f45f0be4002687f508d55efc3c"},{"line_number":21,"context_line":"Signed-off-by: Yusho Yamaguchi \u003cys-yamaguchi@kddi.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d8693bcb_dd0ba55a","line":18,"in_reply_to":"58c42da8_8d6f8a0d","updated":"2026-03-30 07:37:28.000000000","message":"+1 this kind of changes require at least an RFE discussion. Maybe not a spec but for sure the approval of the community.\n\nAlso, as commented by Brian, the Jira ticket could be referred in the Launchpad bug, but here there should be a LP ID.","commit_id":"b72ccdcff7591f3a784d2976a1dfc73645bc631c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"98b4d0d0a031fa064101e03cc87a1402c36029e0","unresolved":true,"context_lines":[{"line_number":15,"context_line":"configured behavior. Documentation and release notes explain how to flip"},{"line_number":16,"context_line":"the knob when rolling out stateless security groups."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Related-RHOSRFE: https://redhat.atlassian.net/browse/RHOSRFE-249"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I300299262d1df0f45f0be4002687f508d55efc3c"},{"line_number":21,"context_line":"Signed-off-by: Yusho Yamaguchi \u003cys-yamaguchi@kddi.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"06cd865e_4de302df","line":18,"in_reply_to":"d8693bcb_dd0ba55a","updated":"2026-03-30 09:06:51.000000000","message":"+1 for RFE","commit_id":"b72ccdcff7591f3a784d2976a1dfc73645bc631c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f5dcb5937de6ed5b5c97115eb97ac0975d749b2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"16a26a88_4fbdf095","updated":"2026-03-30 07:37:28.000000000","message":"-2 to block this patch until we have a RFE discussion. Also the API change would require a new extension (but that\u0027s something to be discussed)","commit_id":"09c2976e16da4e88b38d128ccd09edc592318d74"}],"neutron/conf/extensions/stateful_security_group.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b4cf538f81fd79fc3699f0fb5cddc9e21ed254a5","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2026."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":1,"id":"024d6637_fc8e5894","line":1,"updated":"2026-03-29 23:06:24.000000000","message":"You don\u0027t need this unless line. And can you copy the below license from an existing file, just so all the spacing is the same, thanks.","commit_id":"b72ccdcff7591f3a784d2976a1dfc73645bc631c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b4cf538f81fd79fc3699f0fb5cddc9e21ed254a5","unresolved":true,"context_lines":[{"line_number":26,"context_line":"               \u0027automatically created default security groups.\u0027)),"},{"line_number":27,"context_line":"]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"_OPTS_REGISTERED \u003d False"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def register_stateful_security_group_opts(cfg\u003dcfg.CONF):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fc1515b0_0fc43374","line":29,"updated":"2026-03-29 23:06:24.000000000","message":"Not sure we need this do we? Other config options do not have it.","commit_id":"b72ccdcff7591f3a784d2976a1dfc73645bc631c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f5dcb5937de6ed5b5c97115eb97ac0975d749b2e","unresolved":true,"context_lines":[{"line_number":26,"context_line":"               \u0027automatically created default security groups.\u0027)),"},{"line_number":27,"context_line":"]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"_OPTS_REGISTERED \u003d False"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def register_stateful_security_group_opts(cfg\u003dcfg.CONF):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f1ee09f_a507dc6c","line":29,"in_reply_to":"fc1515b0_0fc43374","updated":"2026-03-30 07:37:28.000000000","message":"We removed something similar in Ic1532eb8de887ff1b1085206df11f53e22f7f524. We should ensure this is loaded before being used. This variable is not used nor needed.","commit_id":"b72ccdcff7591f3a784d2976a1dfc73645bc631c"}],"neutron/db/securitygroups_db.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f5dcb5937de6ed5b5c97115eb97ac0975d749b2e","unresolved":true,"context_lines":[{"line_number":53,"context_line":"from neutron import quota"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"stateful_sg_conf.register_stateful_security_group_opts()"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bb032567_57324041","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":2},"updated":"2026-03-30 07:37:28.000000000","message":"Because this is an","commit_id":"09c2976e16da4e88b38d128ccd09edc592318d74"}],"neutron/extensions/stateful_security_group.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f5dcb5937de6ed5b5c97115eb97ac0975d749b2e","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"stateful_sg_conf.register_stateful_security_group_opts()"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# Align API default with neutron.conf so unspecified creates follow"},{"line_number":24,"context_line":"# security_group_stateful_default instead of the neutron-lib hard default."},{"line_number":25,"context_line":"stateful_security_group.RESOURCE_ATTRIBUTE_MAP[\u0027security_groups\u0027]["},{"line_number":26,"context_line":"    \u0027stateful\u0027].update("},{"line_number":27,"context_line":"        {\u0027default\u0027: cfg.CONF.security_group_stateful_default})"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class Stateful_security_group(extensions.APIExtensionDescriptor):"}],"source_content_type":"text/x-python","patch_set":1,"id":"53347cba_9743f53d","line":27,"range":{"start_line":23,"start_character":0,"end_line":27,"end_character":62},"updated":"2026-03-30 07:37:28.000000000","message":"This is wrong. We can\u0027t/shouldn\u0027t change the API definition dynamically. We should implement an extension making public that the `stateful` parameter is no longer a static defined value but something configurable.","commit_id":"b72ccdcff7591f3a784d2976a1dfc73645bc631c"}]}
