)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"086963296e6e0045348978033f711d6e89d6a441","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If device_id is DEVICE_ID_RESERVED_DHCP_PORT, do not schedule"},{"line_number":10,"context_line":"dhcp-agent nor notify to dhcp-agent."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #13127000"},{"line_number":13,"context_line":"Change-Id: Idf88767596bf0fc31bf856a423d35cb1575b57f3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ae5cdf2_3aebe4dc","line":12,"range":{"start_line":12,"start_character":13,"end_line":12,"end_character":21},"updated":"2014-06-06 03:20:21.000000000","message":"wrong bug number?","commit_id":"36475deb9de5c57210a8beca4bfe53753665baf2"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"90da187fc791122fbb7bbad789b8c4d18ca754a6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If device_id is DEVICE_ID_RESERVED_DHCP_PORT, do not schedule"},{"line_number":10,"context_line":"dhcp-agent nor notify to dhcp-agent."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1327000"},{"line_number":13,"context_line":"Change-Id: Idf88767596bf0fc31bf856a423d35cb1575b57f3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1ae5cdf2_65461ac2","line":11,"updated":"2014-06-11 08:27:29.000000000","message":"please mention the associated blueprint.\nhttps://blueprints.launchpad.net/neutron/+spec/enable-to-set-dhcp-port-attributes","commit_id":"3b072f7700c8346ae52b552f0efee817a3eab2d4"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"aa393f4dc2e9e8d5a6bbe58c4b217ac36989f185","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Itsuro Oda \u003coda@valinux.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-12 07:47:07 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make not schedule dhcp-agent when dhcp port creation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If device_id is DEVICE_ID_RESERVED_DHCP_PORT, do not schedule"},{"line_number":10,"context_line":"dhcp-agent nor notify to dhcp-agent."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1ae5cdf2_24512662","line":7,"updated":"2014-06-13 07:39:27.000000000","message":"This is a little hard to understand. Can you update it to something like the following:\n\n\"Do not schedule reserved DHCP port to agents\"","commit_id":"5160f21d5c86a2d6c1c7ad0243660c719e7e2dab"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"f3e211e8b9fb60ba55e64d565145239032a70f6d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Itsuro Oda \u003coda@valinux.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-12 07:47:07 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make not schedule dhcp-agent when dhcp port creation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If device_id is DEVICE_ID_RESERVED_DHCP_PORT, do not schedule"},{"line_number":10,"context_line":"dhcp-agent nor notify to dhcp-agent."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1ae5cdf2_e4d8f020","line":7,"in_reply_to":"1ae5cdf2_24512662","updated":"2014-06-16 01:24:31.000000000","message":"exactly. thanks.","commit_id":"5160f21d5c86a2d6c1c7ad0243660c719e7e2dab"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"6b4eae59d1821c4b8c8a8cf7b0d90805e0bd4d0b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If device_id is DEVICE_ID_RESERVED_DHCP_PORT, do not schedule"},{"line_number":10,"context_line":"dhcp-agent nor notify to dhcp-agent."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related: blueprint enable-to-set-dhcp-port-attributes"},{"line_number":13,"context_line":"Closes-Bug: #1327000"},{"line_number":14,"context_line":"Change-Id: Idf88767596bf0fc31bf856a423d35cb1575b57f3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1ae5cdf2_6ce5fea2","line":12,"updated":"2014-06-12 05:47:31.000000000","message":"Implements: ?","commit_id":"5160f21d5c86a2d6c1c7ad0243660c719e7e2dab"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"7edf96cb73500c6d3fd1032b2f21244ac5cff9c7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If device_id is DEVICE_ID_RESERVED_DHCP_PORT, do not schedule"},{"line_number":10,"context_line":"dhcp-agent nor notify to dhcp-agent."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related: blueprint enable-to-set-dhcp-port-attributes"},{"line_number":13,"context_line":"Closes-Bug: #1327000"},{"line_number":14,"context_line":"Change-Id: Idf88767596bf0fc31bf856a423d35cb1575b57f3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1ae5cdf2_87114506","line":12,"in_reply_to":"1ae5cdf2_6ce5fea2","updated":"2014-06-12 06:00:20.000000000","message":"no.\nThe blueprint is intended to get consensus of creating DHCP port by API.\n\nThis patch fixes bug 1327000.","commit_id":"5160f21d5c86a2d6c1c7ad0243660c719e7e2dab"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"a617b16709110cafa86c74327311f9bd82c55092","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If device_id is DEVICE_ID_RESERVED_DHCP_PORT, do not schedule"},{"line_number":10,"context_line":"dhcp-agent nor notify to dhcp-agent."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related: blueprint enable-to-set-dhcp-port-attributes"},{"line_number":13,"context_line":"Closes-Bug: #1327000"},{"line_number":14,"context_line":"Change-Id: Idf88767596bf0fc31bf856a423d35cb1575b57f3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1ae5cdf2_cf1f8d6f","line":12,"in_reply_to":"1ae5cdf2_87114506","updated":"2014-06-16 02:49:55.000000000","message":"i don\u0027t understand your logic.\nis there a way to produce the \"bug\" without creating dhcp reserved port by hand?","commit_id":"5160f21d5c86a2d6c1c7ad0243660c719e7e2dab"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"c0637661b4680a8f853478fccd79e633025b8d99","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If device_id is DEVICE_ID_RESERVED_DHCP_PORT, do not schedule"},{"line_number":10,"context_line":"dhcp-agent nor notify to dhcp-agent."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related: blueprint enable-to-set-dhcp-port-attributes"},{"line_number":13,"context_line":"Closes-Bug: #1327000"},{"line_number":14,"context_line":"Change-Id: Idf88767596bf0fc31bf856a423d35cb1575b57f3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1ae5cdf2_951886d4","line":12,"in_reply_to":"1ae5cdf2_87114506","updated":"2014-06-12 10:14:47.000000000","message":"my understanding is that reserved_dhcp_port is not expected to be specified by a user.  ie. not a bug.","commit_id":"5160f21d5c86a2d6c1c7ad0243660c719e7e2dab"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"6bf3206d4fdce1de17f75e8b0e1db3a8e4ad6621","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If device_id is DEVICE_ID_RESERVED_DHCP_PORT, do not schedule"},{"line_number":10,"context_line":"dhcp-agent nor notify to dhcp-agent."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related: blueprint enable-to-set-dhcp-port-attributes"},{"line_number":13,"context_line":"Closes-Bug: #1327000"},{"line_number":14,"context_line":"Change-Id: Idf88767596bf0fc31bf856a423d35cb1575b57f3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1ae5cdf2_22c923ac","line":12,"in_reply_to":"1ae5cdf2_951886d4","updated":"2014-06-12 22:09:12.000000000","message":"I ask it in the blueprint. Actually, it is not prohibited.","commit_id":"5160f21d5c86a2d6c1c7ad0243660c719e7e2dab"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"65253c5a56e37c12ad4d587f4ac2353647889bfe","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Itsuro Oda \u003coda@valinux.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-07-28 08:15:42 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Do not schedule reserved DHCP port to agents"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If device_id is DEVICE_ID_RESERVED_DHCP_PORT, do not schedule"},{"line_number":10,"context_line":"dhcp-agent nor notify to dhcp-agent."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"baada198_1cf8037b","line":7,"updated":"2014-07-28 06:22:58.000000000","message":"\"schedule port\" sounds a bit odd. dhcp-agent-scheduler schedules not a port but a network.\n\n  Do not schedule network when creating reserved DHCP port","commit_id":"912fd51947e9df8ff09b416066f357b137826273"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"52e68171d08ea80bb3c5ee29a2b08803d7812503","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Itsuro Oda \u003coda@valinux.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-07-28 08:15:42 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Do not schedule reserved DHCP port to agents"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If device_id is DEVICE_ID_RESERVED_DHCP_PORT, do not schedule"},{"line_number":10,"context_line":"dhcp-agent nor notify to dhcp-agent."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"baada198_59318657","line":7,"in_reply_to":"baada198_1cf8037b","updated":"2014-07-29 00:11:18.000000000","message":"exactly. \ndone.","commit_id":"912fd51947e9df8ff09b416066f357b137826273"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"65253c5a56e37c12ad4d587f4ac2353647889bfe","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Do not schedule reserved DHCP port to agents"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If device_id is DEVICE_ID_RESERVED_DHCP_PORT, do not schedule"},{"line_number":10,"context_line":"dhcp-agent nor notify to dhcp-agent."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1327000"},{"line_number":13,"context_line":"Change-Id: Idf88767596bf0fc31bf856a423d35cb1575b57f3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"baada198_5ceefbb5","line":10,"updated":"2014-07-28 06:22:58.000000000","message":"dhcp-agent -\u003e network","commit_id":"912fd51947e9df8ff09b416066f357b137826273"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"52e68171d08ea80bb3c5ee29a2b08803d7812503","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Do not schedule reserved DHCP port to agents"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If device_id is DEVICE_ID_RESERVED_DHCP_PORT, do not schedule"},{"line_number":10,"context_line":"dhcp-agent nor notify to dhcp-agent."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1327000"},{"line_number":13,"context_line":"Change-Id: Idf88767596bf0fc31bf856a423d35cb1575b57f3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"baada198_b939c240","line":10,"in_reply_to":"baada198_5ceefbb5","updated":"2014-07-29 00:11:18.000000000","message":"done.","commit_id":"912fd51947e9df8ff09b416066f357b137826273"}],"neutron/api/rpc/agentnotifiers/dhcp_rpc_agent_api.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"8ab56263bfbab2c5f9d3fa474b40b5784f94f667","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            network_id \u003d obj_value[\u0027network_id\u0027]"},{"line_number":168,"context_line":"        if not network_id:"},{"line_number":169,"context_line":"            return"},{"line_number":170,"context_line":"        if obj_type \u003d\u003d \u0027port\u0027 and utils.is_reserved_dhcp_port(obj_value):"},{"line_number":171,"context_line":"            return"},{"line_number":172,"context_line":"        method_name \u003d method_name.replace(\".\", \"_\")"},{"line_number":173,"context_line":"        if method_name.endswith(\"_delete_end\"):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_f6d7864d","line":170,"updated":"2014-06-09 19:49:53.000000000","message":"this shouldn\u0027t be here, but embedded in the _notify_agents logic.","commit_id":"df998dd692bc1deb7ab88aa4d02434037207bd19"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"0a152591e8dfac50cb23d11273a20504f4996151","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            network_id \u003d obj_value[\u0027network_id\u0027]"},{"line_number":168,"context_line":"        if not network_id:"},{"line_number":169,"context_line":"            return"},{"line_number":170,"context_line":"        if obj_type \u003d\u003d \u0027port\u0027 and utils.is_reserved_dhcp_port(obj_value):"},{"line_number":171,"context_line":"            return"},{"line_number":172,"context_line":"        method_name \u003d method_name.replace(\".\", \"_\")"},{"line_number":173,"context_line":"        if method_name.endswith(\"_delete_end\"):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_7c2c304b","line":170,"in_reply_to":"1ae5cdf2_f6d7864d","updated":"2014-06-09 23:13:02.000000000","message":"exactly. will fix.","commit_id":"df998dd692bc1deb7ab88aa4d02434037207bd19"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0d6c573f4845175f504bbd1c8900876246606ccb","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def _is_reserved_dhcp_port(self, port):"},{"line_number":99,"context_line":"        return (\u0027device_id\u0027 in port and"},{"line_number":100,"context_line":"                port[\u0027device_id\u0027] \u003d\u003d constants.DEVICE_ID_RESERVED_DHCP_PORT)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def _notify_agents(self, context, method, payload, network_id):"},{"line_number":103,"context_line":"        \"\"\"Notify all the agents that are hosting the network.\"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_2a9b8174","line":100,"updated":"2014-07-29 11:51:58.000000000","message":"return port.get(\u0027device_id\u0027) \u003d\u003d constants.DEVICE_ID_RESERVED_DHCP_PORT","commit_id":"46cc8f3ee0d06afe883357701dc5a02ac28e1d2f"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"ad27f66d2e6d0fed8235904573689d724e1d57b8","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def _is_reserved_dhcp_port(self, port):"},{"line_number":99,"context_line":"        return (\u0027device_id\u0027 in port and"},{"line_number":100,"context_line":"                port[\u0027device_id\u0027] \u003d\u003d constants.DEVICE_ID_RESERVED_DHCP_PORT)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def _notify_agents(self, context, method, payload, network_id):"},{"line_number":103,"context_line":"        \"\"\"Notify all the agents that are hosting the network.\"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_716f1361","line":100,"in_reply_to":"baada198_2a9b8174","updated":"2014-07-29 22:12:24.000000000","message":"exactly. done.","commit_id":"46cc8f3ee0d06afe883357701dc5a02ac28e1d2f"}],"neutron/common/utils.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"65253c5a56e37c12ad4d587f4ac2353647889bfe","unresolved":false,"context_lines":[{"line_number":305,"context_line":""},{"line_number":306,"context_line":"def is_reserved_dhcp_port(port):"},{"line_number":307,"context_line":"    return (\u0027device_id\u0027 in port and"},{"line_number":308,"context_line":"            port[\u0027device_id\u0027] \u003d\u003d q_const.DEVICE_ID_RESERVED_DHCP_PORT)"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"def cpu_count():"}],"source_content_type":"text/x-python","patch_set":11,"id":"baada198_9c7973fe","line":308,"updated":"2014-07-28 06:22:58.000000000","message":"IMO common.utils should contain generic purpose methods. How about defining it in neutron/db/agentschedulers_db.py? (A static method may be good)","commit_id":"912fd51947e9df8ff09b416066f357b137826273"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"52e68171d08ea80bb3c5ee29a2b08803d7812503","unresolved":false,"context_lines":[{"line_number":305,"context_line":""},{"line_number":306,"context_line":"def is_reserved_dhcp_port(port):"},{"line_number":307,"context_line":"    return (\u0027device_id\u0027 in port and"},{"line_number":308,"context_line":"            port[\u0027device_id\u0027] \u003d\u003d q_const.DEVICE_ID_RESERVED_DHCP_PORT)"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"def cpu_count():"}],"source_content_type":"text/x-python","patch_set":11,"id":"baada198_19b62edc","line":308,"in_reply_to":"baada198_9c7973fe","updated":"2014-07-29 00:11:18.000000000","message":"I agree this method should not be in this file since it is used in dhcp_rpc_agent_api.py locally. \nSo I moved this method to dhcp_rpc_agent_api.py.","commit_id":"912fd51947e9df8ff09b416066f357b137826273"}],"neutron/tests/unit/openvswitch/test_agent_scheduler.py":[{"author":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"change_message_id":"4ec9deceb4783a5edcdb9abc3b9e453913c8b3cf","unresolved":false,"context_lines":[{"line_number":1156,"context_line":"                with mock.patch.object(self.dhcp_notifier,"},{"line_number":1157,"context_line":"                                       \u0027_schedule_network\u0027) as mock_func:"},{"line_number":1158,"context_line":"                    with self.port(subnet\u003dsubnet, device_id\u003ddevice_id):"},{"line_number":1159,"context_line":"                        self.assertFalse(mock_func.called)"},{"line_number":1160,"context_line":""},{"line_number":1161,"context_line":""},{"line_number":1162,"context_line":"class OvsL3AgentNotifierTestCase(test_l3_plugin.L3NatTestCaseMixin,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_9da00444","line":1159,"updated":"2014-06-25 06:48:29.000000000","message":"This test seems a bit fragile - in particular, if we rearranged the function to not call _schedule_network (and also broke the reserved_dhcp_port logic), then this test would still pass.\n\nPerhaps also assert that _schedule_network *is* called with the same net+subnet, but a different device_id?","commit_id":"957c026b17ab6f07781f4145cc38dadd55d730e4"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"9a74c09d554ce119d8eb1fe60bc675772fa5a291","unresolved":false,"context_lines":[{"line_number":1156,"context_line":"                with mock.patch.object(self.dhcp_notifier,"},{"line_number":1157,"context_line":"                                       \u0027_schedule_network\u0027) as mock_func:"},{"line_number":1158,"context_line":"                    with self.port(subnet\u003dsubnet, device_id\u003ddevice_id):"},{"line_number":1159,"context_line":"                        self.assertFalse(mock_func.called)"},{"line_number":1160,"context_line":""},{"line_number":1161,"context_line":""},{"line_number":1162,"context_line":"class OvsL3AgentNotifierTestCase(test_l3_plugin.L3NatTestCaseMixin,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_7f88676b","line":1159,"in_reply_to":"1ae5cdf2_9da00444","updated":"2014-06-25 23:53:08.000000000","message":"exactly. Thank you for a review.","commit_id":"957c026b17ab6f07781f4145cc38dadd55d730e4"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"d49b7376fa371a2b472eaf36d175875c6c3c4587","unresolved":false,"context_lines":[{"line_number":1159,"context_line":"                    with self.port(subnet\u003dsubnet, device_id\u003ddevice_id):"},{"line_number":1160,"context_line":"                        self.assertFalse(mock_func.called)"},{"line_number":1161,"context_line":"                    with self.port(subnet\u003dsubnet, device_id\u003d\u0027not_reserved\u0027):"},{"line_number":1162,"context_line":"                        self.assertTrue(mock_func.called)"},{"line_number":1163,"context_line":""},{"line_number":1164,"context_line":""},{"line_number":1165,"context_line":"class OvsL3AgentNotifierTestCase(test_l3_plugin.L3NatTestCaseMixin,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_ea6912c1","line":1162,"updated":"2014-06-26 04:01:52.000000000","message":"this test seems failing","commit_id":"3a4292ed5f6d9d8c017fd802d55a7778d49ad204"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"b657b7c9bcd7ff7bd7245f4dcf2eeaf2d4aba6bd","unresolved":false,"context_lines":[{"line_number":1159,"context_line":"                    with self.port(subnet\u003dsubnet, device_id\u003ddevice_id):"},{"line_number":1160,"context_line":"                        self.assertFalse(mock_func.called)"},{"line_number":1161,"context_line":"                    with self.port(subnet\u003dsubnet, device_id\u003d\u0027not_reserved\u0027):"},{"line_number":1162,"context_line":"                        self.assertTrue(mock_func.called)"},{"line_number":1163,"context_line":""},{"line_number":1164,"context_line":""},{"line_number":1165,"context_line":"class OvsL3AgentNotifierTestCase(test_l3_plugin.L3NatTestCaseMixin,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_ca3b769a","line":1162,"in_reply_to":"1ae5cdf2_ea6912c1","updated":"2014-06-26 04:08:22.000000000","message":"yes. fixed in the patch set 9.","commit_id":"3a4292ed5f6d9d8c017fd802d55a7778d49ad204"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"1e697c4c8519daa8e886d848ec60914180909d3f","unresolved":false,"context_lines":[{"line_number":1158,"context_line":"        for expected in expected_calls[DHCP_HOSTC]:"},{"line_number":1159,"context_line":"            self.assertIn(expected, self.dhcp_notifier_cast.call_args_list)"},{"line_number":1160,"context_line":""},{"line_number":1161,"context_line":"    def test_reserved_dhcp_port_creation(self):"},{"line_number":1162,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin()"},{"line_number":1163,"context_line":"        notifier \u003d plugin.agent_notifiers[constants.AGENT_TYPE_DHCP]"},{"line_number":1164,"context_line":"        device_id \u003d constants.DEVICE_ID_RESERVED_DHCP_PORT"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_5130bd06","line":1161,"updated":"2014-07-25 21:22:01.000000000","message":"This method tests 2 usecases, you split it 2 methods, one for each usecase (reserved/unreserved port).","commit_id":"8c9567df9795d87ae5bb5ff470752ec918af1b40"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"2a80b650be6c394e32e341b58d545bc012bf9fa5","unresolved":false,"context_lines":[{"line_number":1158,"context_line":"        for expected in expected_calls[DHCP_HOSTC]:"},{"line_number":1159,"context_line":"            self.assertIn(expected, self.dhcp_notifier_cast.call_args_list)"},{"line_number":1160,"context_line":""},{"line_number":1161,"context_line":"    def test_reserved_dhcp_port_creation(self):"},{"line_number":1162,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin()"},{"line_number":1163,"context_line":"        notifier \u003d plugin.agent_notifiers[constants.AGENT_TYPE_DHCP]"},{"line_number":1164,"context_line":"        device_id \u003d constants.DEVICE_ID_RESERVED_DHCP_PORT"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_253a12cd","line":1161,"in_reply_to":"baada198_5130bd06","updated":"2014-07-27 22:49:59.000000000","message":"Thank you for a review. \ndone (please check whether I understand your comment).","commit_id":"8c9567df9795d87ae5bb5ff470752ec918af1b40"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"65253c5a56e37c12ad4d587f4ac2353647889bfe","unresolved":false,"context_lines":[{"line_number":1163,"context_line":"        notifier \u003d plugin.agent_notifiers[constants.AGENT_TYPE_DHCP]"},{"line_number":1164,"context_line":"        device_id \u003d constants.DEVICE_ID_RESERVED_DHCP_PORT"},{"line_number":1165,"context_line":"        with self.network() as net:"},{"line_number":1166,"context_line":"            with self.subnet(network\u003dnet) as subnet:"},{"line_number":1167,"context_line":"                with mock.patch.object(plugin,"},{"line_number":1168,"context_line":"                                       \u0027get_dhcp_agents_hosting_networks\u0027,"},{"line_number":1169,"context_line":"                                       return_value\u003d[]):"}],"source_content_type":"text/x-python","patch_set":11,"id":"baada198_dc568b5d","line":1166,"updated":"2014-07-28 06:22:58.000000000","message":"with self.network() is unnecessary. Please use just subnet().\n\n  with self.subnet() as subnet:","commit_id":"912fd51947e9df8ff09b416066f357b137826273"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"52e68171d08ea80bb3c5ee29a2b08803d7812503","unresolved":false,"context_lines":[{"line_number":1163,"context_line":"        notifier \u003d plugin.agent_notifiers[constants.AGENT_TYPE_DHCP]"},{"line_number":1164,"context_line":"        device_id \u003d constants.DEVICE_ID_RESERVED_DHCP_PORT"},{"line_number":1165,"context_line":"        with self.network() as net:"},{"line_number":1166,"context_line":"            with self.subnet(network\u003dnet) as subnet:"},{"line_number":1167,"context_line":"                with mock.patch.object(plugin,"},{"line_number":1168,"context_line":"                                       \u0027get_dhcp_agents_hosting_networks\u0027,"},{"line_number":1169,"context_line":"                                       return_value\u003d[]):"}],"source_content_type":"text/x-python","patch_set":11,"id":"baada198_f94b3a25","line":1166,"in_reply_to":"baada198_dc568b5d","updated":"2014-07-29 00:11:18.000000000","message":"done.","commit_id":"912fd51947e9df8ff09b416066f357b137826273"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"65253c5a56e37c12ad4d587f4ac2353647889bfe","unresolved":false,"context_lines":[{"line_number":1169,"context_line":"                                       return_value\u003d[]):"},{"line_number":1170,"context_line":"                    with mock.patch.object(notifier,"},{"line_number":1171,"context_line":"                                           \u0027_schedule_network\u0027,"},{"line_number":1172,"context_line":"                                           return_value\u003d[]) as mock_func:"},{"line_number":1173,"context_line":"                        with self.port(subnet\u003dsubnet, device_id\u003ddevice_id):"},{"line_number":1174,"context_line":"                            self.assertFalse(mock_func.called)"},{"line_number":1175,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"baada198_fc598f8d","line":1172,"updated":"2014-07-28 06:22:58.000000000","message":"Please use contextlib.nested(). It reduces the number of indents.","commit_id":"912fd51947e9df8ff09b416066f357b137826273"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"52e68171d08ea80bb3c5ee29a2b08803d7812503","unresolved":false,"context_lines":[{"line_number":1169,"context_line":"                                       return_value\u003d[]):"},{"line_number":1170,"context_line":"                    with mock.patch.object(notifier,"},{"line_number":1171,"context_line":"                                           \u0027_schedule_network\u0027,"},{"line_number":1172,"context_line":"                                           return_value\u003d[]) as mock_func:"},{"line_number":1173,"context_line":"                        with self.port(subnet\u003dsubnet, device_id\u003ddevice_id):"},{"line_number":1174,"context_line":"                            self.assertFalse(mock_func.called)"},{"line_number":1175,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"baada198_195e2ee9","line":1172,"in_reply_to":"baada198_fc598f8d","updated":"2014-07-29 00:11:18.000000000","message":"done.","commit_id":"912fd51947e9df8ff09b416066f357b137826273"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"65253c5a56e37c12ad4d587f4ac2353647889bfe","unresolved":false,"context_lines":[{"line_number":1173,"context_line":"                        with self.port(subnet\u003dsubnet, device_id\u003ddevice_id):"},{"line_number":1174,"context_line":"                            self.assertFalse(mock_func.called)"},{"line_number":1175,"context_line":""},{"line_number":1176,"context_line":"    def test_unreserved_dhcp_port_creation(self):"},{"line_number":1177,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin()"},{"line_number":1178,"context_line":"        notifier \u003d plugin.agent_notifiers[constants.AGENT_TYPE_DHCP]"},{"line_number":1179,"context_line":"        with self.network() as net:"}],"source_content_type":"text/x-python","patch_set":11,"id":"baada198_1c548352","line":1176,"updated":"2014-07-28 06:22:58.000000000","message":"Same comments as the above two.","commit_id":"912fd51947e9df8ff09b416066f357b137826273"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"52e68171d08ea80bb3c5ee29a2b08803d7812503","unresolved":false,"context_lines":[{"line_number":1173,"context_line":"                        with self.port(subnet\u003dsubnet, device_id\u003ddevice_id):"},{"line_number":1174,"context_line":"                            self.assertFalse(mock_func.called)"},{"line_number":1175,"context_line":""},{"line_number":1176,"context_line":"    def test_unreserved_dhcp_port_creation(self):"},{"line_number":1177,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin()"},{"line_number":1178,"context_line":"        notifier \u003d plugin.agent_notifiers[constants.AGENT_TYPE_DHCP]"},{"line_number":1179,"context_line":"        with self.network() as net:"}],"source_content_type":"text/x-python","patch_set":11,"id":"baada198_396132a8","line":1176,"in_reply_to":"baada198_1c548352","updated":"2014-07-29 00:11:18.000000000","message":"done.","commit_id":"912fd51947e9df8ff09b416066f357b137826273"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0d6c573f4845175f504bbd1c8900876246606ccb","unresolved":false,"context_lines":[{"line_number":1171,"context_line":"                              \u0027_schedule_network\u0027,"},{"line_number":1172,"context_line":"                              return_value\u003d[])"},{"line_number":1173,"context_line":"                              ) as (subnet, _, mock_sched):"},{"line_number":1174,"context_line":"            with self.port(subnet\u003dsubnet, device_id\u003ddevice_id):"},{"line_number":1175,"context_line":"                self.assertFalse(mock_sched.called)"},{"line_number":1176,"context_line":""},{"line_number":1177,"context_line":"    def test_unreserved_dhcp_port_creation(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_0af15d96","line":1174,"updated":"2014-07-29 11:51:58.000000000","message":"Suggestion: Both methods are almost the same - device_id could be parametric here in helper function.","commit_id":"46cc8f3ee0d06afe883357701dc5a02ac28e1d2f"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"ad27f66d2e6d0fed8235904573689d724e1d57b8","unresolved":false,"context_lines":[{"line_number":1171,"context_line":"                              \u0027_schedule_network\u0027,"},{"line_number":1172,"context_line":"                              return_value\u003d[])"},{"line_number":1173,"context_line":"                              ) as (subnet, _, mock_sched):"},{"line_number":1174,"context_line":"            with self.port(subnet\u003dsubnet, device_id\u003ddevice_id):"},{"line_number":1175,"context_line":"                self.assertFalse(mock_sched.called)"},{"line_number":1176,"context_line":""},{"line_number":1177,"context_line":"    def test_unreserved_dhcp_port_creation(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_71a633ad","line":1174,"in_reply_to":"baada198_0af15d96","updated":"2014-07-29 22:12:24.000000000","message":"good suggestion. done.","commit_id":"46cc8f3ee0d06afe883357701dc5a02ac28e1d2f"}]}
