)]}'
{"neutron/plugins/nuage/common/constants.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"1cf3b2cb3a12208aaf0e9f53e73297165d1d7b9e","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"DEF_L3DOM_TEMPLATE_PFIX \u003d \u0027_def_L3_Template\u0027"},{"line_number":29,"context_line":"DEF_L2DOM_TEMPLATE_PFIX \u003d \u0027_def_L2_Template\u0027"},{"line_number":30,"context_line":"DEF_NUAGE_ZONE_PREFIX \u003d \u0027def_zone\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_31c0af4f","line":30,"updated":"2014-06-12 04:46:34.000000000","message":"where are these constants used?","commit_id":"4388a74caa31c86044097cb44e4f7d48a875cd59"},{"author":{"_account_id":11701,"name":"Divya ChanneGowda","email":"divya.hc@gmail.com","username":"divyahc"},"change_message_id":"f0ecbf3e5ab037434bf8ec60b26487c8a564a087","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"DEF_L3DOM_TEMPLATE_PFIX \u003d \u0027_def_L3_Template\u0027"},{"line_number":29,"context_line":"DEF_L2DOM_TEMPLATE_PFIX \u003d \u0027_def_L2_Template\u0027"},{"line_number":30,"context_line":"DEF_NUAGE_ZONE_PREFIX \u003d \u0027def_zone\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_02050710","line":30,"in_reply_to":"1ae5cdf2_31c0af4f","updated":"2014-06-12 21:58:33.000000000","message":"Done","commit_id":"4388a74caa31c86044097cb44e4f7d48a875cd59"}],"neutron/plugins/nuage/plugin.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"f05a5b0789eabcfd20a7349d827d68376870a9bd","unresolved":false,"context_lines":[{"line_number":734,"context_line":"                                                     def_netpart[\u0027l3dom_tid\u0027],"},{"line_number":735,"context_line":"                                                     def_netpart[\u0027l2dom_tid\u0027],"},{"line_number":736,"context_line":"                                                     default_net_part)"},{"line_number":737,"context_line":"                return(self._make_net_partition_dict(net_part))"},{"line_number":738,"context_line":"        else:"},{"line_number":739,"context_line":"            return(self._create_net_partition(session, default_net_part))"},{"line_number":740,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_517484fd","line":737,"updated":"2014-06-11 05:51:45.000000000","message":"The normal code style doesn\u0027t use return like a function. Just do the standard:\n\n return self._make_net_partition_dict(net_part)","commit_id":"67fc963fb48c80b7453acf8f3a27c23eda135a30"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"f05a5b0789eabcfd20a7349d827d68376870a9bd","unresolved":false,"context_lines":[{"line_number":736,"context_line":"                                                     default_net_part)"},{"line_number":737,"context_line":"                return(self._make_net_partition_dict(net_part))"},{"line_number":738,"context_line":"        else:"},{"line_number":739,"context_line":"            return(self._create_net_partition(session, default_net_part))"},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"    def create_net_partition(self, context, net_partition):"},{"line_number":742,"context_line":"        ent \u003d net_partition[\u0027net_partition\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_9161ac3b","line":739,"updated":"2014-06-11 05:51:45.000000000","message":"ditto","commit_id":"67fc963fb48c80b7453acf8f3a27c23eda135a30"}],"neutron/tests/unit/nuage/fake_nuageclient.py":[{"author":{"_account_id":7962,"name":"Ronak Shah","email":"ronak.malav.shah@gmail.com","username":"ronak"},"change_message_id":"c59fd5de4e1b5e99c5aa787d766697c32ac90edd","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        return fake_net_partition"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def get_def_netpartition_data(self, default_net_part):"},{"line_number":76,"context_line":"        if default_net_part \u003d\u003d \u0027defaultTestNp\u0027:"},{"line_number":77,"context_line":"            fake_defnetpart_data \u003d {"},{"line_number":78,"context_line":"                \u0027np_id\u0027: str(uuid.uuid4()),"},{"line_number":79,"context_line":"                \u0027l3dom_tid\u0027: str(uuid.uuid4()),"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_d6de7dd9","line":76,"updated":"2014-06-13 01:27:19.000000000","message":"default_test_np instead of defaultTestNp?","commit_id":"c0c5ea8f2d4499478eaa8459491c657abb64ddb6"},{"author":{"_account_id":11701,"name":"Divya ChanneGowda","email":"divya.hc@gmail.com","username":"divyahc"},"change_message_id":"f37b027fa055ae81ed8a25e1afc97f983646277a","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        return fake_net_partition"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def get_def_netpartition_data(self, default_net_part):"},{"line_number":76,"context_line":"        if default_net_part \u003d\u003d \u0027defaultTestNp\u0027:"},{"line_number":77,"context_line":"            fake_defnetpart_data \u003d {"},{"line_number":78,"context_line":"                \u0027np_id\u0027: str(uuid.uuid4()),"},{"line_number":79,"context_line":"                \u0027l3dom_tid\u0027: str(uuid.uuid4()),"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_901ea15d","line":76,"in_reply_to":"1ae5cdf2_d6de7dd9","updated":"2014-06-13 18:08:09.000000000","message":"Done","commit_id":"c0c5ea8f2d4499478eaa8459491c657abb64ddb6"},{"author":{"_account_id":7962,"name":"Ronak Shah","email":"ronak.malav.shah@gmail.com","username":"ronak"},"change_message_id":"c59fd5de4e1b5e99c5aa787d766697c32ac90edd","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def get_def_netpartition_data(self, default_net_part):"},{"line_number":76,"context_line":"        if default_net_part \u003d\u003d \u0027defaultTestNp\u0027:"},{"line_number":77,"context_line":"            fake_defnetpart_data \u003d {"},{"line_number":78,"context_line":"                \u0027np_id\u0027: str(uuid.uuid4()),"},{"line_number":79,"context_line":"                \u0027l3dom_tid\u0027: str(uuid.uuid4()),"},{"line_number":80,"context_line":"                \u0027l2dom_tid\u0027: str(uuid.uuid4()),"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_16f46559","line":77,"updated":"2014-06-13 01:27:19.000000000","message":"please use uuidutils.generate_uuid() instead to be consistent with rest of the code in file.","commit_id":"c0c5ea8f2d4499478eaa8459491c657abb64ddb6"},{"author":{"_account_id":11701,"name":"Divya ChanneGowda","email":"divya.hc@gmail.com","username":"divyahc"},"change_message_id":"f37b027fa055ae81ed8a25e1afc97f983646277a","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def get_def_netpartition_data(self, default_net_part):"},{"line_number":76,"context_line":"        if default_net_part \u003d\u003d \u0027defaultTestNp\u0027:"},{"line_number":77,"context_line":"            fake_defnetpart_data \u003d {"},{"line_number":78,"context_line":"                \u0027np_id\u0027: str(uuid.uuid4()),"},{"line_number":79,"context_line":"                \u0027l3dom_tid\u0027: str(uuid.uuid4()),"},{"line_number":80,"context_line":"                \u0027l2dom_tid\u0027: str(uuid.uuid4()),"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_b021dd9f","line":77,"in_reply_to":"1ae5cdf2_16f46559","updated":"2014-06-13 18:08:09.000000000","message":"Done","commit_id":"c0c5ea8f2d4499478eaa8459491c657abb64ddb6"},{"author":{"_account_id":1923,"name":"Mohammad Banikazemi","email":"mbanikazemi@gmail.com","username":"mb-s"},"change_message_id":"928a475f7b5990f17310a079abcb5679254784cf","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                \u0027l2dom_tid\u0027: uuidutils.generate_uuid(),"},{"line_number":81,"context_line":"            }"},{"line_number":82,"context_line":"            return fake_defnetpart_data"},{"line_number":83,"context_line":"        else:"},{"line_number":84,"context_line":"            pass"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def delete_net_partition(self, id, l3dom_id\u003dNone, l2dom_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_2642f7aa","line":83,"updated":"2014-06-13 19:38:11.000000000","message":"not necessary; please remove lines 83-84.","commit_id":"6d5d1dea2e7d5e1817ccc75a54d8f0c9e6d4f8a8"},{"author":{"_account_id":11701,"name":"Divya ChanneGowda","email":"divya.hc@gmail.com","username":"divyahc"},"change_message_id":"2845c189236404ee2a554638da27a9d17ad32023","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                \u0027l2dom_tid\u0027: uuidutils.generate_uuid(),"},{"line_number":81,"context_line":"            }"},{"line_number":82,"context_line":"            return fake_defnetpart_data"},{"line_number":83,"context_line":"        else:"},{"line_number":84,"context_line":"            pass"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def delete_net_partition(self, id, l3dom_id\u003dNone, l2dom_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_c4e86bb5","line":83,"in_reply_to":"1ae5cdf2_2642f7aa","updated":"2014-06-13 20:49:10.000000000","message":"Done","commit_id":"6d5d1dea2e7d5e1817ccc75a54d8f0c9e6d4f8a8"}],"neutron/tests/unit/nuage/test_netpartition.py":[{"author":{"_account_id":7962,"name":"Ronak Shah","email":"ronak.malav.shah@gmail.com","username":"ronak"},"change_message_id":"c59fd5de4e1b5e99c5aa787d766697c32ac90edd","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                             npart[\u0027net_partition\u0027][\u0027name\u0027])"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_create_default_netpartition(self):"},{"line_number":95,"context_line":"        name \u003d \u0027defaultTestNp\u0027"},{"line_number":96,"context_line":"        netpart1 \u003d self._make_netpartition(self.fmt, name)"},{"line_number":97,"context_line":"        nuage_plugin \u003d manager.NeutronManager.get_plugin()"},{"line_number":98,"context_line":"        netpart2 \u003d nuage_plugin._create_default_net_partition(name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_b62d71aa","line":95,"updated":"2014-06-13 01:27:19.000000000","message":"I think what is getting tested here is the case where the default netpartition already exist and its been retried for creation. Would it make sense to call this method test_create_of_existing_default_netpartition?","commit_id":"c0c5ea8f2d4499478eaa8459491c657abb64ddb6"},{"author":{"_account_id":11701,"name":"Divya ChanneGowda","email":"divya.hc@gmail.com","username":"divyahc"},"change_message_id":"f37b027fa055ae81ed8a25e1afc97f983646277a","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                             npart[\u0027net_partition\u0027][\u0027name\u0027])"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_create_default_netpartition(self):"},{"line_number":95,"context_line":"        name \u003d \u0027defaultTestNp\u0027"},{"line_number":96,"context_line":"        netpart1 \u003d self._make_netpartition(self.fmt, name)"},{"line_number":97,"context_line":"        nuage_plugin \u003d manager.NeutronManager.get_plugin()"},{"line_number":98,"context_line":"        netpart2 \u003d nuage_plugin._create_default_net_partition(name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_103291f1","line":95,"in_reply_to":"1ae5cdf2_b62d71aa","updated":"2014-06-13 18:08:09.000000000","message":"Done","commit_id":"c0c5ea8f2d4499478eaa8459491c657abb64ddb6"}]}