)]}'
{"neutron/plugins/ml2/drivers/l2pop/mech_driver.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c884e25736ce8dd04f07ab59a07b9a72565dde98","unresolved":true,"context_lines":[{"line_number":56,"context_line":"                except ValueError:"},{"line_number":57,"context_line":"                    pass"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def check_vlan_qinq(self, context):"},{"line_number":60,"context_line":"        \"\"\"L2population driver does not support QinQ.\"\"\""},{"line_number":61,"context_line":"        return False"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def _get_ha_port_agents_fdb("},{"line_number":64,"context_line":"            self, context, network_id, router_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"01935954_ec4006bd","line":61,"range":{"start_line":59,"start_character":4,"end_line":61,"end_character":20},"updated":"2026-05-14 09:37:34.000000000","message":"out of scope: I need to check with Slawek if that method needs to be here now","commit_id":"f895d21a0d88e71be7d191daabf826b8361eeaf9"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"539bd26accd6c6a6a0e91c6e6112b47fe96de445","unresolved":true,"context_lines":[{"line_number":56,"context_line":"                except ValueError:"},{"line_number":57,"context_line":"                    pass"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def check_vlan_qinq(self, context):"},{"line_number":60,"context_line":"        \"\"\"L2population driver does not support QinQ.\"\"\""},{"line_number":61,"context_line":"        return False"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def _get_ha_port_agents_fdb("},{"line_number":64,"context_line":"            self, context, network_id, router_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"f3646b99_4e6cdf8d","line":61,"range":{"start_line":59,"start_character":4,"end_line":61,"end_character":20},"in_reply_to":"01935954_ec4006bd","updated":"2026-05-14 09:51:08.000000000","message":"I think that the reason why it isn\u0027t removed with this commit is that it says explicitly that l2population driver don\u0027t support vlan_qinq, while for vlan_transparency it was saying that it is supported only to workaround the problem which actually this patch is fixing.\n\nBut to be honest, I think that we can remove it and return \"None\" from check_vlan_qiniq method in that driver as it is not really related to that driver. I don\u0027t remember why it was decided to return False originally.\nTo make that patch clean, I think that this can be removed in follow up patch with proper description why it\u0027s changed.","commit_id":"f895d21a0d88e71be7d191daabf826b8361eeaf9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"dee2a5e2bad01f67eadb04e99fdc435bb5c5e30d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                except ValueError:"},{"line_number":57,"context_line":"                    pass"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def check_vlan_qinq(self, context):"},{"line_number":60,"context_line":"        \"\"\"L2population driver does not support QinQ.\"\"\""},{"line_number":61,"context_line":"        return False"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def _get_ha_port_agents_fdb("},{"line_number":64,"context_line":"            self, context, network_id, router_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"162302a5_2968b584","line":61,"range":{"start_line":59,"start_character":4,"end_line":61,"end_character":20},"in_reply_to":"f3646b99_4e6cdf8d","updated":"2026-05-14 10:22:57.000000000","message":"right, that was my opinion too. I\u0027ll propose a follow-up patch later.","commit_id":"f895d21a0d88e71be7d191daabf826b8361eeaf9"}]}