)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"4c9573aa3b549bce395c20150b971f0546be18d3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ovs-agent: Ensure integration bridge is created"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ovs-agent will fail to launch if integration bridge(br-int by default) is not"},{"line_number":10,"context_line":"existed. To fix this, the agent should check and create the bridge if necessary"},{"line_number":11,"context_line":"during launching."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ae5cdf2_ed57c8c8","line":9,"updated":"2014-06-09 12:03:13.000000000","message":"Nit: is not existed -\u003e does not exist","commit_id":"27ee4a4b4224802a73953c1d7f552ec1c00866b4"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"f9c25b35bee0481d56f69bf3b30a6de3b599e55b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2014-06-09 20:08:10 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ovs-agent: Ensure integration bridge is created"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ovs-agent will fail to launch if integration bridge(br-int by default) does not"},{"line_number":10,"context_line":"exist. To fix this, the agent should check and create the bridge if necessary"},{"line_number":11,"context_line":"during launching."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_11b6cedc","line":8,"updated":"2014-06-09 12:34:49.000000000","message":"We\u0027re moving away from checks that are done every time the agent starts, towards a script ran by the deployment tool. Check it out: https://review.openstack.org/#/c/96525/","commit_id":"076e14388c82101a3f24f3507838eab07fe2ef53"},{"author":{"_account_id":4894,"name":"stanzgy","email":"stanzgy@gmail.com","username":"stanzgy"},"change_message_id":"dc5d765403c11537b456464a8f9dd0dd89911c72","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2014-06-09 20:08:10 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ovs-agent: Ensure integration bridge is created"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ovs-agent will fail to launch if integration bridge(br-int by default) does not"},{"line_number":10,"context_line":"exist. To fix this, the agent should check and create the bridge if necessary"},{"line_number":11,"context_line":"during launching."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_19b6d1dc","line":8,"in_reply_to":"1ae5cdf2_11b6cedc","updated":"2014-06-10 07:19:26.000000000","message":"hi muller, thanks for the suggestion. IMO that patch integrates some sanity checks into cmd tools. But here besides checks we need to create the bridge if necessary. So it\u0027s not appropriate to move this fix to neutron.cmd.sanity.checks","commit_id":"076e14388c82101a3f24f3507838eab07fe2ef53"}],"neutron/plugins/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":11825,"name":"Sudhakar Babu Gariganti","email":"sudhakar.gariganti@gmail.com","username":"sudhakar-gariganti"},"change_message_id":"6984a9bb740d2bdebb005b8963587fd34b24a070","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        self.int_br \u003d ovs_lib.OVSBridge(integ_br, self.root_helper)"},{"line_number":175,"context_line":"        # Ensure integration bridge is created"},{"line_number":176,"context_line":"        if not ip_lib.device_exists(integ_br, self.root_helper):"},{"line_number":177,"context_line":"            self.int_br.create()"},{"line_number":178,"context_line":"        # Stores port update notifications for processing in main rpc loop"},{"line_number":179,"context_line":"        self.updated_ports \u003d set()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_8b0feb87","line":176,"updated":"2014-06-10 06:11:35.000000000","message":"is setup_integration_br() method a good place to do this check instead of having it in the init method??","commit_id":"076e14388c82101a3f24f3507838eab07fe2ef53"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"e3b101100a66a075f97861367599d1aa3ee05fdb","unresolved":false,"context_lines":[{"line_number":726,"context_line":"        :param bridge_name: the name of the integration bridge."},{"line_number":727,"context_line":"        :returns: the integration bridge"},{"line_number":728,"context_line":"        \u0027\u0027\u0027"},{"line_number":729,"context_line":"        # XXX(stanzgy): Ensure the integration bridge is created."},{"line_number":730,"context_line":"        # ovs_lib.OVSBridge.create() will run"},{"line_number":731,"context_line":"        #   ovs-vsctl -- --may-exist add-br BRIDGE_NAME"},{"line_number":732,"context_line":"        # which does nothing if bridge already exists."}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_05672d26","line":729,"updated":"2014-06-10 18:20:02.000000000","message":"XXX is a TODO I\u0027m not sure it is neccessary to attribute an owner to this explanation.","commit_id":"c9a5749bd25eb73d455d5a6daeee1930fe608d1d"}]}
