)]}'
{"neutron/agent/l3_agent.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"a644452d5f7e95cd60830b5f1d99abf3444287f8","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        @raise n_rpc.RemoteError: with TooManyExternalNetworks"},{"line_number":84,"context_line":"                                       as exc_type if there are"},{"line_number":85,"context_line":"                                       more than one external network"},{"line_number":86,"context_line":"        \"\"\""},{"line_number":87,"context_line":"        return self.call(context,"},{"line_number":88,"context_line":"                         self.make_msg(\u0027get_external_network_id\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"1ae5cdf2_55b7de20","line":85,"updated":"2014-06-19 12:32:03.000000000","message":"please fix indent","commit_id":"af64cd660953c4ea70a73144a615d83624e557ce"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9d5eae5cd2e6002eaf4c947c8921863e87bb319c","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        @raise n_rpc.RemoteError: with TooManyExternalNetworks"},{"line_number":84,"context_line":"                                       as exc_type if there are"},{"line_number":85,"context_line":"                                       more than one external network"},{"line_number":86,"context_line":"        \"\"\""},{"line_number":87,"context_line":"        return self.call(context,"},{"line_number":88,"context_line":"                         self.make_msg(\u0027get_external_network_id\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"1ae5cdf2_d05bfc83","line":85,"in_reply_to":"1ae5cdf2_55b7de20","updated":"2014-06-20 07:31:50.000000000","message":"Done","commit_id":"af64cd660953c4ea70a73144a615d83624e557ce"}],"neutron/common/rpc.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"96831b2f3578c7558efde7ee6389875f6d5615bd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright (c) 2012 OpenStack Foundation."},{"line_number":4,"context_line":"# Copyright (c) 2014 Red Hat, Inc."},{"line_number":5,"context_line":"# All Rights Reserved."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ae5cdf2_be2f03f5","line":4,"updated":"2014-06-20 08:16:43.000000000","message":"unnecessary but I don\u0027t mind - if your employer asks you to do that it\u0027s fine","commit_id":"03c6ce147160e5bf2edcf06bdced26310b280493"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"466ad088f78b8009a2f16cb07da77283f9853715","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright (c) 2012 OpenStack Foundation."},{"line_number":4,"context_line":"# Copyright (c) 2014 Red Hat, Inc."},{"line_number":5,"context_line":"# All Rights Reserved."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ae5cdf2_4973ab4d","line":4,"in_reply_to":"1ae5cdf2_be2f03f5","updated":"2014-06-20 08:51:11.000000000","message":"Not that it was explicitly requested by my employer. I just thought this is something to update if you do major changes. If that\u0027s not desirable, I will avoid updating the section. For this patch, I\u0027ll leave it as is unless more changes are needed to avoid re-upload.","commit_id":"03c6ce147160e5bf2edcf06bdced26310b280493"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"96831b2f3578c7558efde7ee6389875f6d5615bd","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            ((opt, kwargs[opt])"},{"line_number":174,"context_line":"             for opt in (\u0027fanout\u0027, \u0027timeout\u0027, \u0027topic\u0027, \u0027version\u0027)"},{"line_number":175,"context_line":"             if kwargs.get(opt))"},{"line_number":176,"context_line":"        )"},{"line_number":177,"context_line":"        if msg[\u0027namespace\u0027]:"},{"line_number":178,"context_line":"            options[\u0027namespace\u0027] \u003d msg[\u0027namespace\u0027]"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"1ae5cdf2_be7d43e9","line":176,"updated":"2014-06-20 08:16:43.000000000","message":"this comment is unrelated to your patch - just seeking opinion\n\nHow is the above different from popping out from kwargs all the keys which are not in (\u0027fanout\u0027, \u0027timeout\u0027, \u0027topic\u0027, \u0027version\u0027)?","commit_id":"03c6ce147160e5bf2edcf06bdced26310b280493"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"466ad088f78b8009a2f16cb07da77283f9853715","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            ((opt, kwargs[opt])"},{"line_number":174,"context_line":"             for opt in (\u0027fanout\u0027, \u0027timeout\u0027, \u0027topic\u0027, \u0027version\u0027)"},{"line_number":175,"context_line":"             if kwargs.get(opt))"},{"line_number":176,"context_line":"        )"},{"line_number":177,"context_line":"        if msg[\u0027namespace\u0027]:"},{"line_number":178,"context_line":"            options[\u0027namespace\u0027] \u003d msg[\u0027namespace\u0027]"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"1ae5cdf2_299f3f51","line":176,"in_reply_to":"1ae5cdf2_be7d43e9","updated":"2014-06-20 08:51:11.000000000","message":"This is exactly the same thing, just creating a new dict instead of reusing kwargs. I hope you don\u0027t want me to re-upload to reuse the dict.","commit_id":"03c6ce147160e5bf2edcf06bdced26310b280493"}]}