)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5c07e26a546b54d3e56aa202d01df49d51c7e726","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6f2a3cb3_429f198b","updated":"2026-05-18 13:32:17.000000000","message":"-1 for the question\n\nSame as before, this patch requires a reno and documentation. The change is significant.","commit_id":"199d336bf0bcbf3a5ae795419a49fd542cd46c67"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"19fcaa30a17f0a3cad64ec00c762aeb876e5ae9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"47a28afc_72d918d5","updated":"2026-05-18 06:38:05.000000000","message":"recheck neutron-ovs-tempest-multinode-full","commit_id":"199d336bf0bcbf3a5ae795419a49fd542cd46c67"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d3735319d2107b236baf67bf678efbba15dc4dd8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"47e57146_1a46c506","updated":"2026-05-21 08:10:00.000000000","message":"Is this patch related to a bug?","commit_id":"90ee661f9ebc503adbd2095afda2e3aaeb13f93b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a43d33cf1df82aeef04b787dad53f3050eeec329","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"71c089f3_7c92ad83","in_reply_to":"47e57146_1a46c506","updated":"2026-05-21 11:56:55.000000000","message":"I can put it as related to 2152203 if needed.","commit_id":"90ee661f9ebc503adbd2095afda2e3aaeb13f93b"}],"neutron/services/bgp/plugin.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5c07e26a546b54d3e56aa202d01df49d51c7e726","unresolved":true,"context_lines":[{"line_number":61,"context_line":"                    \u0027BGP service plugin is enabled. \u0027"},{"line_number":62,"context_line":"                    \u0027Only flat provider networks are supported.\u0027)"},{"line_number":63,"context_line":"        if network_type \u003d\u003d n_const.TYPE_FLAT:"},{"line_number":64,"context_line":"            existing \u003d network_objects.NetworkSegment.get_objects("},{"line_number":65,"context_line":"                payload.context, network_type\u003dn_const.TYPE_FLAT)"},{"line_number":66,"context_line":"            other_flat \u003d [s for s in existing"},{"line_number":67,"context_line":"                          if s.network_id !\u003d payload.resource_id]"},{"line_number":68,"context_line":"            if other_flat:"},{"line_number":69,"context_line":"                raise n_exc.BadRequest("},{"line_number":70,"context_line":"                    resource\u003d\u0027network\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"0da62e13_46361823","line":67,"range":{"start_line":64,"start_character":12,"end_line":67,"end_character":65},"updated":"2026-05-18 13:32:17.000000000","message":"That it means we\u0027ll have one single flat provider network only for the whole cluster?","commit_id":"199d336bf0bcbf3a5ae795419a49fd542cd46c67"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"244c02db2739060202cb949a2fbddd7730b1cb8d","unresolved":true,"context_lines":[{"line_number":61,"context_line":"                    \u0027BGP service plugin is enabled. \u0027"},{"line_number":62,"context_line":"                    \u0027Only flat provider networks are supported.\u0027)"},{"line_number":63,"context_line":"        if network_type \u003d\u003d n_const.TYPE_FLAT:"},{"line_number":64,"context_line":"            existing \u003d network_objects.NetworkSegment.get_objects("},{"line_number":65,"context_line":"                payload.context, network_type\u003dn_const.TYPE_FLAT)"},{"line_number":66,"context_line":"            other_flat \u003d [s for s in existing"},{"line_number":67,"context_line":"                          if s.network_id !\u003d payload.resource_id]"},{"line_number":68,"context_line":"            if other_flat:"},{"line_number":69,"context_line":"                raise n_exc.BadRequest("},{"line_number":70,"context_line":"                    resource\u003d\u0027network\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"d3b28958_46d9d716","line":67,"range":{"start_line":64,"start_character":12,"end_line":67,"end_character":65},"in_reply_to":"0da62e13_46361823","updated":"2026-05-19 15:28:33.000000000","message":"Yes.","commit_id":"199d336bf0bcbf3a5ae795419a49fd542cd46c67"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a43d33cf1df82aeef04b787dad53f3050eeec329","unresolved":true,"context_lines":[{"line_number":61,"context_line":"                    \u0027BGP service plugin is enabled. \u0027"},{"line_number":62,"context_line":"                    \u0027Only flat provider networks are supported.\u0027)"},{"line_number":63,"context_line":"        if network_type \u003d\u003d n_const.TYPE_FLAT:"},{"line_number":64,"context_line":"            existing \u003d network_objects.NetworkSegment.get_objects("},{"line_number":65,"context_line":"                payload.context, network_type\u003dn_const.TYPE_FLAT)"},{"line_number":66,"context_line":"            other_flat \u003d [s for s in existing"},{"line_number":67,"context_line":"                          if s.network_id !\u003d payload.resource_id]"},{"line_number":68,"context_line":"            if other_flat:"},{"line_number":69,"context_line":"                raise n_exc.BadRequest("},{"line_number":70,"context_line":"                    resource\u003d\u0027network\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"a283b7d5_9d5f6a78","line":67,"range":{"start_line":64,"start_character":12,"end_line":67,"end_character":65},"in_reply_to":"5ec10896_b7bb0348","updated":"2026-05-21 11:56:55.000000000","message":"The release note was added in the previous patch - https://review.opendev.org/c/openstack/neutron/+/988146/5/releasenotes/notes/bgp-vlan-cdf6e0a15dfdeb67.yaml\n\nThis is just a consequence of banning the VLAN - hence removing a loop over multiple logical switch networks with localnets because in practice now there can\u0027t be more than 1.","commit_id":"199d336bf0bcbf3a5ae795419a49fd542cd46c67"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5363f8b7fda81e5475c20c80add6f182e6352ac9","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                    \u0027BGP service plugin is enabled. \u0027"},{"line_number":62,"context_line":"                    \u0027Only flat provider networks are supported.\u0027)"},{"line_number":63,"context_line":"        if network_type \u003d\u003d n_const.TYPE_FLAT:"},{"line_number":64,"context_line":"            existing \u003d network_objects.NetworkSegment.get_objects("},{"line_number":65,"context_line":"                payload.context, network_type\u003dn_const.TYPE_FLAT)"},{"line_number":66,"context_line":"            other_flat \u003d [s for s in existing"},{"line_number":67,"context_line":"                          if s.network_id !\u003d payload.resource_id]"},{"line_number":68,"context_line":"            if other_flat:"},{"line_number":69,"context_line":"                raise n_exc.BadRequest("},{"line_number":70,"context_line":"                    resource\u003d\u0027network\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"049f6a83_bb6d3681","line":67,"range":{"start_line":64,"start_character":12,"end_line":67,"end_character":65},"in_reply_to":"a283b7d5_9d5f6a78","updated":"2026-05-25 08:16:12.000000000","message":"Done","commit_id":"199d336bf0bcbf3a5ae795419a49fd542cd46c67"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d9e95e2db3de48b099867454bf455947da7e9f5e","unresolved":true,"context_lines":[{"line_number":61,"context_line":"                    \u0027BGP service plugin is enabled. \u0027"},{"line_number":62,"context_line":"                    \u0027Only flat provider networks are supported.\u0027)"},{"line_number":63,"context_line":"        if network_type \u003d\u003d n_const.TYPE_FLAT:"},{"line_number":64,"context_line":"            existing \u003d network_objects.NetworkSegment.get_objects("},{"line_number":65,"context_line":"                payload.context, network_type\u003dn_const.TYPE_FLAT)"},{"line_number":66,"context_line":"            other_flat \u003d [s for s in existing"},{"line_number":67,"context_line":"                          if s.network_id !\u003d payload.resource_id]"},{"line_number":68,"context_line":"            if other_flat:"},{"line_number":69,"context_line":"                raise n_exc.BadRequest("},{"line_number":70,"context_line":"                    resource\u003d\u0027network\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ec10896_b7bb0348","line":67,"range":{"start_line":64,"start_character":12,"end_line":67,"end_character":65},"in_reply_to":"d3b28958_46d9d716","updated":"2026-05-21 08:09:25.000000000","message":"Thanks. Please, add a reno and a doc somewhere. This change is relevant because you prevent from using a network type.","commit_id":"199d336bf0bcbf3a5ae795419a49fd542cd46c67"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"db95869e58899a8f6c04146c3412482ecfaf50f4","unresolved":true,"context_lines":[{"line_number":60,"context_line":"                msg\u003d\u0027VLAN provider networks are not supported when the \u0027"},{"line_number":61,"context_line":"                    \u0027BGP service plugin is enabled. \u0027"},{"line_number":62,"context_line":"                    \u0027Only flat provider networks are supported.\u0027)"},{"line_number":63,"context_line":"        if network_type \u003d\u003d n_const.TYPE_FLAT:"},{"line_number":64,"context_line":"            existing \u003d network_objects.NetworkSegment.get_objects("},{"line_number":65,"context_line":"                payload.context, network_type\u003dn_const.TYPE_FLAT)"},{"line_number":66,"context_line":"            other_flat \u003d [s for s in existing"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a633443_86529c48","line":63,"updated":"2026-05-25 10:26:06.000000000","message":"Maybe this is correct, but I have a concern.\n\nI am testing this patch on an environment with octavia amphora-provider.\nI tried to create a flat provider network and it failed because octavia had already created its own flat provider network.\nThat network has `physical_network\u003doctavia`, while the \"public\" provider network I want to create has `physical_network\u003ddatacentre`.\n\nAny chance we should support multiple flat networks as long as they use different physical networks?\nIf not, I think we should document this limitation: bgp can\u0027t be used with octavia amphora-provider LBs.\n\n\n```\nsh-5.1$ openstack network show octavia-provider-net\n+---------------------------+--------------------------------------+\n| Field                     | Value                                |\n+---------------------------+--------------------------------------+\n| admin_state_up            | UP                                   |\n| availability_zone_hints   |                                      |\n| availability_zones        |                                      |\n| created_at                | 2026-05-21T18:02:27Z                 |\n| description               | LBaaS Management Provider Network    |\n| dns_domain                |                                      |\n| id                        | 52aa037c-8c95-444e-aa25-14b087c0a31c |\n| ipv4_address_scope        | None                                 |\n| ipv6_address_scope        | None                                 |\n| is_default                | False                                |\n| is_vlan_transparent       | False                                |\n| l2_adjacency              | True                                 |\n| mtu                       | 1500                                 |\n| name                      | octavia-provider-net                 |\n| port_security_enabled     | True                                 |\n| project_id                | edc13bd7715b4fe5865e47d2d846d196     |\n| provider:network_type     | flat                                 |\n| provider:physical_network | octavia                              |\n| provider:segmentation_id  | None                                 |\n| qos_policy_id             | None                                 |\n| revision_number           | 3                                    |\n| router:external           | External                             |\n| segments                  | None                                 |\n| shared                    | False                                |\n| status                    | ACTIVE                               |\n| subnets                   | 377bd67a-4e40-4b3e-adee-dd4723949246 |\n| tags                      |                                      |\n| tenant_id                 | edc13bd7715b4fe5865e47d2d846d196     |\n| updated_at                | 2026-05-21T18:02:28Z                 |\n+---------------------------+--------------------------------------+\n```","commit_id":"90ee661f9ebc503adbd2095afda2e3aaeb13f93b"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"73df3b2923cb8ce6690854de1bbd6ac2aa2163f8","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                msg\u003d\u0027VLAN provider networks are not supported when the \u0027"},{"line_number":61,"context_line":"                    \u0027BGP service plugin is enabled. \u0027"},{"line_number":62,"context_line":"                    \u0027Only flat provider networks are supported.\u0027)"},{"line_number":63,"context_line":"        if network_type \u003d\u003d n_const.TYPE_FLAT:"},{"line_number":64,"context_line":"            existing \u003d network_objects.NetworkSegment.get_objects("},{"line_number":65,"context_line":"                payload.context, network_type\u003dn_const.TYPE_FLAT)"},{"line_number":66,"context_line":"            other_flat \u003d [s for s in existing"}],"source_content_type":"text/x-python","patch_set":3,"id":"69940551_6340052e","line":63,"in_reply_to":"1a633443_86529c48","updated":"2026-05-26 12:37:46.000000000","message":"Discussed and clarified with @libosvar@redhat.com\nFor the moment, only one flat provider network is supported and this affects octavia amphora-provider. This will be a known limitation and a solution will be implemented eventually.","commit_id":"90ee661f9ebc503adbd2095afda2e3aaeb13f93b"}]}