)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"8c9e1d1b5a03b4af685373b1c9c23b8bda8c8455","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"27458cf5_055e34ae","updated":"2026-06-16 14:20:22.000000000","message":"The rootwrap filter patch is almost merged. I will wait then rebase against master and update it with vty_socket\nhttps://review.opendev.org/c/openstack/neutron/+/993245","commit_id":"a8fc39d46f1abd900813e34c80a24a15b21c10a5"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"a9d56df1559313a693b4ba2220ee6dd993ee7b28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"927ad494_4c2a675a","updated":"2026-06-16 16:31:26.000000000","message":"rebased with rootwrap.filters changes from master","commit_id":"8df5beb298744123c5874df0e12e4cf33d1dc609"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"b1df9eaeffe6c5d83a7195fe98460b582ee22d33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"81aed4c2_1bdc2dc8","updated":"2026-06-18 01:24:29.000000000","message":"recheck unrelated test_resize_volume_backed_server_confirm failure","commit_id":"425f97dc8ce60a55f84b147c199b62437e4d378e"}],"neutron/conf/agent/ovn/evpn/config.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0637f4ea51ccaacd425de170711257dc9d07ffa3","unresolved":true,"context_lines":[{"line_number":31,"context_line":"        default\u003d49152,"},{"line_number":32,"context_line":"        help\u003d_(\u0027UDP port for the child VxLAN device used by EVPN\u0027)),"},{"line_number":33,"context_line":"    cfg.StrOpt("},{"line_number":34,"context_line":"        \u0027vty_socket\u0027,"},{"line_number":35,"context_line":"        default\u003d\u0027/run/frr\u0027,"},{"line_number":36,"context_line":"        help\u003d_(\u0027Path to the vtysh socket directory. This is passed \u0027"},{"line_number":37,"context_line":"               \u0027as --vty_socket to the vtysh command.\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"94b2266f_828dbe84","line":34,"range":{"start_line":34,"start_character":9,"end_line":34,"end_character":19},"updated":"2026-06-16 14:23:31.000000000","message":"Suggestion only: I\u0027d name it `frr_vty_socket` - to indicate it is for the frr, as VTY socket is a generic term","commit_id":"a8fc39d46f1abd900813e34c80a24a15b21c10a5"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"a9d56df1559313a693b4ba2220ee6dd993ee7b28","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        default\u003d49152,"},{"line_number":32,"context_line":"        help\u003d_(\u0027UDP port for the child VxLAN device used by EVPN\u0027)),"},{"line_number":33,"context_line":"    cfg.StrOpt("},{"line_number":34,"context_line":"        \u0027vty_socket\u0027,"},{"line_number":35,"context_line":"        default\u003d\u0027/run/frr\u0027,"},{"line_number":36,"context_line":"        help\u003d_(\u0027Path to the vtysh socket directory. This is passed \u0027"},{"line_number":37,"context_line":"               \u0027as --vty_socket to the vtysh command.\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f8fe05b_670644ff","line":34,"range":{"start_line":34,"start_character":9,"end_line":34,"end_character":19},"in_reply_to":"94b2266f_828dbe84","updated":"2026-06-16 16:31:26.000000000","message":"Done","commit_id":"a8fc39d46f1abd900813e34c80a24a15b21c10a5"}],"neutron/tests/unit/agent/linux/evpn_router/frr/test_frr_driver.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f96a69b7ccaf91c89109398a1f21dbbdb938dfed","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        )"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def test_execute_cli_cmd_custom_vty_socket(self):"},{"line_number":170,"context_line":"        from oslo_config import cfg"},{"line_number":171,"context_line":"        custom_path \u003d \u0027/custom/frr/socket\u0027"},{"line_number":172,"context_line":"        cfg.CONF.set_override(\u0027vty_socket\u0027, custom_path, group\u003d\u0027ovn_evpn\u0027)"},{"line_number":173,"context_line":"        self.execute.return_value \u003d \"output\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3471560e_1e56a6b6","line":170,"updated":"2026-06-15 17:53:13.000000000","message":"pep8: C0415: Import outside toplevel (oslo_config.cfg) (import-outside-toplevel)","commit_id":"08c426feb511a71c8f0882e19f14812fa335f374"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0637f4ea51ccaacd425de170711257dc9d07ffa3","unresolved":true,"context_lines":[{"line_number":167,"context_line":"        )"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def test_execute_cli_cmd_custom_vty_socket(self):"},{"line_number":170,"context_line":"        from oslo_config import cfg"},{"line_number":171,"context_line":"        custom_path \u003d \u0027/custom/frr/socket\u0027"},{"line_number":172,"context_line":"        cfg.CONF.set_override(\u0027vty_socket\u0027, custom_path, group\u003d\u0027ovn_evpn\u0027)"},{"line_number":173,"context_line":"        self.execute.return_value \u003d \"output\""}],"source_content_type":"text/x-python","patch_set":3,"id":"4d1ab395_060a4d7b","line":170,"updated":"2026-06-16 14:23:31.000000000","message":"AI? :)","commit_id":"a8fc39d46f1abd900813e34c80a24a15b21c10a5"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"e36e156e6bacda467a01f16684227d5503e1a5cf","unresolved":true,"context_lines":[{"line_number":167,"context_line":"        )"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def test_execute_cli_cmd_custom_vty_socket(self):"},{"line_number":170,"context_line":"        from oslo_config import cfg"},{"line_number":171,"context_line":"        custom_path \u003d \u0027/custom/frr/socket\u0027"},{"line_number":172,"context_line":"        cfg.CONF.set_override(\u0027vty_socket\u0027, custom_path, group\u003d\u0027ovn_evpn\u0027)"},{"line_number":173,"context_line":"        self.execute.return_value \u003d \"output\""}],"source_content_type":"text/x-python","patch_set":3,"id":"8de3483c_cfa7e447","line":170,"in_reply_to":"4d1ab395_060a4d7b","updated":"2026-06-16 14:35:03.000000000","message":"Thanks, I saw that earlier and forgot to update it! Yes, my friend Claude messed up. I also need to update my patch message","commit_id":"a8fc39d46f1abd900813e34c80a24a15b21c10a5"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"a9d56df1559313a693b4ba2220ee6dd993ee7b28","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        )"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def test_execute_cli_cmd_custom_vty_socket(self):"},{"line_number":170,"context_line":"        from oslo_config import cfg"},{"line_number":171,"context_line":"        custom_path \u003d \u0027/custom/frr/socket\u0027"},{"line_number":172,"context_line":"        cfg.CONF.set_override(\u0027vty_socket\u0027, custom_path, group\u003d\u0027ovn_evpn\u0027)"},{"line_number":173,"context_line":"        self.execute.return_value \u003d \"output\""}],"source_content_type":"text/x-python","patch_set":3,"id":"0874a3a3_fc472563","line":170,"in_reply_to":"8de3483c_cfa7e447","updated":"2026-06-16 16:31:26.000000000","message":"Done","commit_id":"a8fc39d46f1abd900813e34c80a24a15b21c10a5"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"3380169de9ebbc1e3cdfb37c64b52f52e3a9e526","unresolved":true,"context_lines":[{"line_number":21,"context_line":"from neutron.conf.agent.ovn.evpn import config as evpn_conf"},{"line_number":22,"context_line":"from neutron.tests import base"},{"line_number":23,"context_line":"from neutron_lib import exceptions"},{"line_number":24,"context_line":"from oslo_config import cfg"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def _build_test_evpn_router_config(vni):"}],"source_content_type":"text/x-python","patch_set":4,"id":"b17f9e10_6a0e22fe","line":24,"range":{"start_line":24,"start_character":5,"end_line":24,"end_character":16},"updated":"2026-06-17 18:21:32.000000000","message":"I know the previous block has already the neutron_lib wrong but maybe the oslo in this patch should go to it\u0027s \"3rd party\" block","commit_id":"8df5beb298744123c5874df0e12e4cf33d1dc609"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"45a2261df3209d29855caf70b70364f8a600f9d1","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron.conf.agent.ovn.evpn import config as evpn_conf"},{"line_number":22,"context_line":"from neutron.tests import base"},{"line_number":23,"context_line":"from neutron_lib import exceptions"},{"line_number":24,"context_line":"from oslo_config import cfg"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def _build_test_evpn_router_config(vni):"}],"source_content_type":"text/x-python","patch_set":4,"id":"daa6b223_46ed0799","line":24,"range":{"start_line":24,"start_character":5,"end_line":24,"end_character":16},"in_reply_to":"53fa4ede_bfe88ce6","updated":"2026-06-18 10:41:24.000000000","message":"thx @libosvar@redhat.com, I somehow missed that :)","commit_id":"8df5beb298744123c5874df0e12e4cf33d1dc609"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"9fec70be1ed8b1dde1171adf98ec25033d02d2f9","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron.conf.agent.ovn.evpn import config as evpn_conf"},{"line_number":22,"context_line":"from neutron.tests import base"},{"line_number":23,"context_line":"from neutron_lib import exceptions"},{"line_number":24,"context_line":"from oslo_config import cfg"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def _build_test_evpn_router_config(vni):"}],"source_content_type":"text/x-python","patch_set":4,"id":"53fa4ede_bfe88ce6","line":24,"range":{"start_line":24,"start_character":5,"end_line":24,"end_character":16},"in_reply_to":"b17f9e10_6a0e22fe","updated":"2026-06-17 23:01:14.000000000","message":"Done","commit_id":"8df5beb298744123c5874df0e12e4cf33d1dc609"}],"tools/rootwrap/testing.filters":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0637f4ea51ccaacd425de170711257dc9d07ffa3","unresolved":true,"context_lines":[{"line_number":67,"context_line":"frr_init_stop_libexec: RegExpFilter, /usr/libexec/frr/frrinit.sh, root, /usr/libexec/frr/frrinit.sh, stop, [a-z]+-[0-9a-f-]+"},{"line_number":68,"context_line":"vtysh_cmd: RegExpFilter, vtysh, root, vtysh, --vty_socket, /[a-z/]+, -N, [a-z]+-[0-9a-f-]+, -c, .*"},{"line_number":69,"context_line":"vtysh_dryrun: RegExpFilter, vtysh, root, vtysh, --vty_socket, /[a-z/]+, -N, [a-z]+-[0-9a-f-]+, --dryrun, -f, .*"},{"line_number":70,"context_line":"vtysh_apply: RegExpFilter, vtysh, root, vtysh, --vty_socket, /[a-z/]+, -N, [a-z]+-[0-9a-f-]+, -f, .*"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"2d4275d9_6019cf01","line":70,"updated":"2026-06-16 14:23:31.000000000","message":"That makes me think we should base this patch on https://review.opendev.org/c/openstack/neutron/+/993245 and update the filters there as well.","commit_id":"a8fc39d46f1abd900813e34c80a24a15b21c10a5"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"a9d56df1559313a693b4ba2220ee6dd993ee7b28","unresolved":false,"context_lines":[{"line_number":67,"context_line":"frr_init_stop_libexec: RegExpFilter, /usr/libexec/frr/frrinit.sh, root, /usr/libexec/frr/frrinit.sh, stop, [a-z]+-[0-9a-f-]+"},{"line_number":68,"context_line":"vtysh_cmd: RegExpFilter, vtysh, root, vtysh, --vty_socket, /[a-z/]+, -N, [a-z]+-[0-9a-f-]+, -c, .*"},{"line_number":69,"context_line":"vtysh_dryrun: RegExpFilter, vtysh, root, vtysh, --vty_socket, /[a-z/]+, -N, [a-z]+-[0-9a-f-]+, --dryrun, -f, .*"},{"line_number":70,"context_line":"vtysh_apply: RegExpFilter, vtysh, root, vtysh, --vty_socket, /[a-z/]+, -N, [a-z]+-[0-9a-f-]+, -f, .*"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5835197a_eb916733","line":70,"in_reply_to":"2d4275d9_6019cf01","updated":"2026-06-16 16:31:26.000000000","message":"Done","commit_id":"a8fc39d46f1abd900813e34c80a24a15b21c10a5"}]}