)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"564473a7c1a979580f6fea4cda991a604f4e8d6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"89283ae5_48071392","updated":"2026-09-11 10:34:41.000000000","message":"I\u0027ve proposed https://review.opendev.org/c/openstack/ovsdbapp/+/1005207. Once merged, I\u0027ll be able to continue with this patch.","commit_id":"f241d3cdc34aecb8cd546a142bbd163642ee1a31"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"782ee4eb00d858befd7531a0193cd4fa04a9abc9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d98800f8_e4577fff","updated":"2026-09-17 14:03:13.000000000","message":"recheck FT again","commit_id":"f241d3cdc34aecb8cd546a142bbd163642ee1a31"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/impl_idl_ovn.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ea37229fcba6c5168b023174de95df33918197a9","unresolved":true,"context_lines":[{"line_number":982,"context_line":"class OvsdbSbOvnIdl(sb_impl_idl.OvnSbApiIdlImpl, Backend):"},{"line_number":983,"context_line":"    def autocreate_indices(self):"},{"line_number":984,"context_line":"        super().autocreate_indices()"},{"line_number":985,"context_line":"        if \u0027hostname\u0027 in self.idl.tables[\u0027Chassis\u0027].columns:"},{"line_number":986,"context_line":"            self.create_index(\u0027Chassis\u0027, \u0027hostname\u0027)"},{"line_number":987,"context_line":""},{"line_number":988,"context_line":"    @n_utils.classproperty"}],"source_content_type":"text/x-python","patch_set":1,"id":"e3871640_c82d65a3","line":985,"updated":"2026-08-10 11:44:48.000000000","message":"Why do we check this? Hostname column was added 10 years ago. - https://github.com/ovn-org/ovn/commit/f1a9293cf7870d42fa4689dd77dd5125330c1bfe","commit_id":"f241d3cdc34aecb8cd546a142bbd163642ee1a31"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"220fffa45032d4c7ea6a393ab89f5915e2d004ac","unresolved":true,"context_lines":[{"line_number":982,"context_line":"class OvsdbSbOvnIdl(sb_impl_idl.OvnSbApiIdlImpl, Backend):"},{"line_number":983,"context_line":"    def autocreate_indices(self):"},{"line_number":984,"context_line":"        super().autocreate_indices()"},{"line_number":985,"context_line":"        if \u0027hostname\u0027 in self.idl.tables[\u0027Chassis\u0027].columns:"},{"line_number":986,"context_line":"            self.create_index(\u0027Chassis\u0027, \u0027hostname\u0027)"},{"line_number":987,"context_line":""},{"line_number":988,"context_line":"    @n_utils.classproperty"}],"source_content_type":"text/x-python","patch_set":1,"id":"77b76fbb_2fd083c6","line":985,"in_reply_to":"1aff64c6_a19acaaf","updated":"2026-09-17 21:08:53.000000000","message":"accidentally marked resolved before.","commit_id":"f241d3cdc34aecb8cd546a142bbd163642ee1a31"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"e83733037a1552600b15306480a424f657cf707a","unresolved":false,"context_lines":[{"line_number":982,"context_line":"class OvsdbSbOvnIdl(sb_impl_idl.OvnSbApiIdlImpl, Backend):"},{"line_number":983,"context_line":"    def autocreate_indices(self):"},{"line_number":984,"context_line":"        super().autocreate_indices()"},{"line_number":985,"context_line":"        if \u0027hostname\u0027 in self.idl.tables[\u0027Chassis\u0027].columns:"},{"line_number":986,"context_line":"            self.create_index(\u0027Chassis\u0027, \u0027hostname\u0027)"},{"line_number":987,"context_line":""},{"line_number":988,"context_line":"    @n_utils.classproperty"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aff64c6_a19acaaf","line":985,"in_reply_to":"61c0f396_a0b68b30","updated":"2026-09-17 14:57:08.000000000","message":"Some historical undocumented info:\n\n`autocreate_indices()` was basically the indexing equivalent of table\u0027s `register_all()`. I.e. \"This is probably inefficient and not what you want, but it\u0027ll get you up and going.\" and I wanted there to be some visible benefit from indexing by default. Ultimately, I thought we\u0027d get around to hand-crafting indexes to specifically what we needed.\n\nWith that in mind, I never really expected `autocreate_indices()` to be the place where people added their own indexes. That would just be done by `start\u003dFalse`and calling `create_index()`. But I also can see that if you don\u0027t already do `start\u003dFalse` the fact that there is no other pre-start callback method to use and that I did not name it `_autocreate_indices()` means that I made this usage inevitable.\n\nWhat would be more in-line with what my original plan was would be overriding start_connection(), e.g.\n\n```\ndef start_connection(self, connection):\n   self.create_index(\u0027Chassis\u0027, \u0027hostname\u0027)\n   super().start_connection(connection)\n```\n\nor a `pre_start()` or a c`reate_indexes()` where all indexes we cared about were defined, or whatever. But I\u0027m interested in what other people think about this.","commit_id":"f241d3cdc34aecb8cd546a142bbd163642ee1a31"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a40e63d507a0dcd0900a9479165ca02b26236f45","unresolved":false,"context_lines":[{"line_number":982,"context_line":"class OvsdbSbOvnIdl(sb_impl_idl.OvnSbApiIdlImpl, Backend):"},{"line_number":983,"context_line":"    def autocreate_indices(self):"},{"line_number":984,"context_line":"        super().autocreate_indices()"},{"line_number":985,"context_line":"        if \u0027hostname\u0027 in self.idl.tables[\u0027Chassis\u0027].columns:"},{"line_number":986,"context_line":"            self.create_index(\u0027Chassis\u0027, \u0027hostname\u0027)"},{"line_number":987,"context_line":""},{"line_number":988,"context_line":"    @n_utils.classproperty"}],"source_content_type":"text/x-python","patch_set":1,"id":"61c0f396_a0b68b30","line":985,"in_reply_to":"e3871640_c82d65a3","updated":"2026-09-11 08:30:32.000000000","message":"Yes, it doesn\u0027t make any sense","commit_id":"f241d3cdc34aecb8cd546a142bbd163642ee1a31"}]}