)]}'
{"neutron/tests/unit/nec/test_ofc_manager.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"57628bcdd2fb2d6acba1f7bb46c6ac2f4aee0e72","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        self.assertEqual(router.ofc_id, \"ofc-\" + r[:-4])"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def test_exists_ofc_router(self):"},{"line_number":240,"context_line":"        \"\"\"A test for exists_ofc_routeri.\"\"\""},{"line_number":241,"context_line":"        t, r, _n \u003d self.get_random_params()"},{"line_number":242,"context_line":"        self.ofc.create_ofc_tenant(self.ctx, t)"},{"line_number":243,"context_line":"        self.assertFalse(self.ofc.exists_ofc_router(self.ctx, r))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_e254b723","line":240,"updated":"2014-06-12 07:05:51.000000000","message":"i?\ni guess you are using vi.","commit_id":"000cc44c9224f159e46744f0b130a4b4147b091a"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"cbcbece2ed1fecdd6f758eb0bb464b198d391442","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        self.assertEqual(router.ofc_id, \"ofc-\" + r[:-4])"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def test_exists_ofc_router(self):"},{"line_number":240,"context_line":"        \"\"\"A test for exists_ofc_routeri.\"\"\""},{"line_number":241,"context_line":"        t, r, _n \u003d self.get_random_params()"},{"line_number":242,"context_line":"        self.ofc.create_ofc_tenant(self.ctx, t)"},{"line_number":243,"context_line":"        self.assertFalse(self.ofc.exists_ofc_router(self.ctx, r))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_39b88410","line":240,"in_reply_to":"1ae5cdf2_e254b723","updated":"2014-06-12 16:53:40.000000000","message":"yep :) fixed","commit_id":"000cc44c9224f159e46744f0b130a4b4147b091a"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0e5153f5da69b37c81fd574e29b2aa4f8b0e5110","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        return (tenant, router, network)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def test_create_ofc_router(self):"},{"line_number":230,"context_line":"        \"\"\"A test of ofc_router creation.\"\"\""},{"line_number":231,"context_line":"        t, r, _n \u003d self.get_random_params()"},{"line_number":232,"context_line":"        self.ofc.create_ofc_tenant(self.ctx, t)"},{"line_number":233,"context_line":"        self.assertFalse(ndb.get_ofc_item(self.ctx.session, \u0027ofc_router\u0027, r))"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_24ada631","line":230,"updated":"2014-06-13 07:45:41.000000000","message":"The question is whether these docstrings bring any additional value. Maybe it would be better to remove them. IMO the method\u0027s name says the same as the docstring.","commit_id":"b3c163b4f485a67347d889ea137581d22ea6c4f7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"418cd478dcc2dc23c6a522381fa001b1c5197518","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        return (tenant, router, network)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def test_create_ofc_router(self):"},{"line_number":230,"context_line":"        \"\"\"A test of ofc_router creation.\"\"\""},{"line_number":231,"context_line":"        t, r, _n \u003d self.get_random_params()"},{"line_number":232,"context_line":"        self.ofc.create_ofc_tenant(self.ctx, t)"},{"line_number":233,"context_line":"        self.assertFalse(ndb.get_ofc_item(self.ctx.session, \u0027ofc_router\u0027, r))"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_bb644ce5","line":230,"in_reply_to":"1ae5cdf2_24ada631","updated":"2014-06-14 20:57:13.000000000","message":"yeah I would agree that they are of dubious value, but I was trying to enable the check without disturbing too much code","commit_id":"b3c163b4f485a67347d889ea137581d22ea6c4f7"}],"tox.ini":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"db286e3ed5fb127c613e3bd4b5992201263d6133","unresolved":false,"context_lines":[{"line_number":49,"context_line":"# H304 no relative imports"},{"line_number":50,"context_line":"# H305 imports not grouped correctly"},{"line_number":51,"context_line":"# H307 like imports should be grouped together"},{"line_number":52,"context_line":"# H402 one line docstring needs punctuation"},{"line_number":53,"context_line":"# H405 multi line docstring summary not separated with an empty line"},{"line_number":54,"context_line":"# H904 Wrap long lines in parentheses instead of a backslash"},{"line_number":55,"context_line":"# TODO(marun) H404 multi line docstring should start with a summary"}],"source_content_type":"text/x-properties","patch_set":4,"id":"1ae5cdf2_44047217","line":52,"updated":"2014-06-13 07:47:48.000000000","message":"This line should be removed.","commit_id":"b3c163b4f485a67347d889ea137581d22ea6c4f7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"418cd478dcc2dc23c6a522381fa001b1c5197518","unresolved":false,"context_lines":[{"line_number":49,"context_line":"# H304 no relative imports"},{"line_number":50,"context_line":"# H305 imports not grouped correctly"},{"line_number":51,"context_line":"# H307 like imports should be grouped together"},{"line_number":52,"context_line":"# H402 one line docstring needs punctuation"},{"line_number":53,"context_line":"# H405 multi line docstring summary not separated with an empty line"},{"line_number":54,"context_line":"# H904 Wrap long lines in parentheses instead of a backslash"},{"line_number":55,"context_line":"# TODO(marun) H404 multi line docstring should start with a summary"}],"source_content_type":"text/x-properties","patch_set":4,"id":"1ae5cdf2_1b9d40bc","line":52,"in_reply_to":"1ae5cdf2_44047217","updated":"2014-06-14 20:57:13.000000000","message":"it is cleaned up in a subsequent patch","commit_id":"b3c163b4f485a67347d889ea137581d22ea6c4f7"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"8a05c2078b585556a25254783020d71fde2fab79","unresolved":false,"context_lines":[{"line_number":49,"context_line":"# H304 no relative imports"},{"line_number":50,"context_line":"# H305 imports not grouped correctly"},{"line_number":51,"context_line":"# H307 like imports should be grouped together"},{"line_number":52,"context_line":"# H402 one line docstring needs punctuation"},{"line_number":53,"context_line":"# H405 multi line docstring summary not separated with an empty line"},{"line_number":54,"context_line":"# H904 Wrap long lines in parentheses instead of a backslash"},{"line_number":55,"context_line":"# TODO(marun) H404 multi line docstring should start with a summary"}],"source_content_type":"text/x-properties","patch_set":6,"id":"1ae5cdf2_b647031c","line":52,"updated":"2014-06-14 23:18:12.000000000","message":"Remove this line.","commit_id":"8fe43dd93c6bc0c7672119196903bcb4e1c9d8c6"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"05c54b80d32c99b303e0760307bd2cc8857c7220","unresolved":false,"context_lines":[{"line_number":49,"context_line":"# H304 no relative imports"},{"line_number":50,"context_line":"# H305 imports not grouped correctly"},{"line_number":51,"context_line":"# H307 like imports should be grouped together"},{"line_number":52,"context_line":"# H402 one line docstring needs punctuation"},{"line_number":53,"context_line":"# H405 multi line docstring summary not separated with an empty line"},{"line_number":54,"context_line":"# H904 Wrap long lines in parentheses instead of a backslash"},{"line_number":55,"context_line":"# TODO(marun) H404 multi line docstring should start with a summary"}],"source_content_type":"text/x-properties","patch_set":6,"id":"1ae5cdf2_75dba84f","line":52,"in_reply_to":"1ae5cdf2_b647031c","updated":"2014-06-16 04:37:05.000000000","message":"note: https://review.openstack.org/#/c/99582/6 has the removal of this line","commit_id":"8fe43dd93c6bc0c7672119196903bcb4e1c9d8c6"}]}