)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f1c37c6b91085a979cf299c711add8db6fd4baf2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sridhar Venkat \u003csvenkat@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-03 23:16:07 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Checkin blueprint for nova-powervm SR-IOV VIFs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is the blueprint to add suppport for SR-IOV VIFs into"},{"line_number":10,"context_line":"nova-powervm."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7aa08908_a6e068fb","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":8},"updated":"2016-06-08 14:42:55.000000000","message":"I don\u0027t think \"Checkin\" is needed.","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f1c37c6b91085a979cf299c711add8db6fd4baf2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Checkin blueprint for nova-powervm SR-IOV VIFs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is the blueprint to add suppport for SR-IOV VIFs into"},{"line_number":10,"context_line":"nova-powervm."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I44600be808da3be9a485e0fc210116339bcfcb77"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7aa08908_c6b2d405","line":9,"range":{"start_line":9,"start_character":29,"end_line":9,"end_character":37},"updated":"2016-06-08 14:42:55.000000000","message":"support","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f1c37c6b91085a979cf299c711add8db6fd4baf2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is the blueprint to add suppport for SR-IOV VIFs into"},{"line_number":10,"context_line":"nova-powervm."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I44600be808da3be9a485e0fc210116339bcfcb77"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7aa08908_6c062c21","line":11,"updated":"2016-06-08 14:42:55.000000000","message":"Reference to the networking-powervm review?","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f1c37c6b91085a979cf299c711add8db6fd4baf2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7aa08908_a7294d8c","line":13,"updated":"2016-06-08 14:42:55.000000000","message":"Pointer to the launchpad blueprint?\n\n Implements: blueprint xxx","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"55b073a9606d3b56d7db258c04fe7cf5d45c827d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"powervm-sriov"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I44600be808da3be9a485e0fc210116339bcfcb77"},{"line_number":16,"context_line":"Implements: https://blueprints.launchpad.net/nova-powervm/"},{"line_number":17,"context_line":"+spec/powervm-sriov-nova"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1aa78d24_bdda8715","line":16,"updated":"2016-07-14 21:21:58.000000000","message":"Not sure, but you can probably cheat on the line length limit here for the sake of making this appear as an entire hyperlink in gerrit.","commit_id":"9fd69b6993929ac1ef8b0a44d253cef130cedd12"}],"specs/newton/powervm-sriov-nova.rst":[{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"2c3bf1fdd7283105ea31b130b3595ad133d4f4a2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Nova support for SR-IOV VIF Types"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova-powervm/+spec/powervm-sriov-nova"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9abb7d3a_8c34314a","line":9,"range":{"start_line":9,"start_character":33,"end_line":9,"end_character":71},"updated":"2016-06-01 13:57:16.000000000","message":"Shorten.","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"19b3286f78a702e39aa351548d3e8d037aa8f3c3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Nova support for SR-IOV VIF Types"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova-powervm/+spec/powervm-sriov-nova"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_6e49cfd0","line":9,"range":{"start_line":9,"start_character":33,"end_line":9,"end_character":71},"in_reply_to":"9abb7d3a_8c34314a","updated":"2016-06-04 02:03:54.000000000","message":"Done","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"2c3bf1fdd7283105ea31b130b3595ad133d4f4a2","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova-powervm/+spec/powervm-sriov-nova"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint will address support of SR-IOV in conjunction with PowerVM vNIC"},{"line_number":14,"context_line":"into nova-powervm. SR-IOV support was added to Juno release of OpenStack, this"},{"line_number":15,"context_line":"blueprint will attempt to fit PowerVM\u0027s SR-IOV implementation with vNIC into"},{"line_number":16,"context_line":"it. A separate blueprint will be made available for networking-powervm."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9abb7d3a_6cd3cdd5","line":14,"range":{"start_line":13,"start_character":66,"end_line":14,"end_character":17},"updated":"2016-06-01 13:57:16.000000000","message":"In discussions with Eric Larese, I thought that the plan was to support both VF direct to the VM and then also a separate VIF driver that would support VF to vNIC to VM (thus preparing for future live migration support).","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"19b3286f78a702e39aa351548d3e8d037aa8f3c3","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova-powervm/+spec/powervm-sriov-nova"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint will address support of SR-IOV in conjunction with PowerVM vNIC"},{"line_number":14,"context_line":"into nova-powervm. SR-IOV support was added to Juno release of OpenStack, this"},{"line_number":15,"context_line":"blueprint will attempt to fit PowerVM\u0027s SR-IOV implementation with vNIC into"},{"line_number":16,"context_line":"it. A separate blueprint will be made available for networking-powervm."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_4e4693c0","line":14,"range":{"start_line":13,"start_character":66,"end_line":14,"end_character":17},"in_reply_to":"9abb7d3a_6cd3cdd5","updated":"2016-06-04 02:03:54.000000000","message":"Done","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"2c3bf1fdd7283105ea31b130b3595ad133d4f4a2","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint will address support of SR-IOV in conjunction with PowerVM vNIC"},{"line_number":14,"context_line":"into nova-powervm. SR-IOV support was added to Juno release of OpenStack, this"},{"line_number":15,"context_line":"blueprint will attempt to fit PowerVM\u0027s SR-IOV implementation with vNIC into"},{"line_number":16,"context_line":"it. A separate blueprint will be made available for networking-powervm."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This blueprint will be implemented during Newton cycle of OpenStack"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9abb7d3a_6ceaad75","line":15,"range":{"start_line":15,"start_character":67,"end_line":15,"end_character":71},"updated":"2016-06-01 13:57:16.000000000","message":"See above.  All through doc.","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"19b3286f78a702e39aa351548d3e8d037aa8f3c3","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint will address support of SR-IOV in conjunction with PowerVM vNIC"},{"line_number":14,"context_line":"into nova-powervm. SR-IOV support was added to Juno release of OpenStack, this"},{"line_number":15,"context_line":"blueprint will attempt to fit PowerVM\u0027s SR-IOV implementation with vNIC into"},{"line_number":16,"context_line":"it. A separate blueprint will be made available for networking-powervm."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This blueprint will be implemented during Newton cycle of OpenStack"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_ae11f7b1","line":15,"range":{"start_line":15,"start_character":67,"end_line":15,"end_character":71},"in_reply_to":"9abb7d3a_6ceaad75","updated":"2016-06-04 02:03:54.000000000","message":"Done","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"2c3bf1fdd7283105ea31b130b3595ad133d4f4a2","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Problem Description"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":"OpenStack PowerVM drivers currently support networking aspect of PowerVM"},{"line_number":26,"context_line":"virtualization using Shared Ethernet Adapter only. There is a need for"},{"line_number":27,"context_line":"supporting SR-IOV in shared mode and with redundancy/failover. Users should be"},{"line_number":28,"context_line":"able to manage a VM with SR-IOV VF as a network interface. This management "},{"line_number":29,"context_line":"should include migration of VM with SR-IOV VF network interface attached to it."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9abb7d3a_0f1dd365","line":26,"range":{"start_line":25,"start_character":0,"end_line":26,"end_character":51},"updated":"2016-06-01 13:57:16.000000000","message":"Can you include a link to the PowerVM documentation on how SR-IOV is implemented.  Also a link on how the KVM implementation is done in OpenStack.  That will allow us to understand the differences in the platforms.","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"19b3286f78a702e39aa351548d3e8d037aa8f3c3","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Problem Description"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":"OpenStack PowerVM drivers currently support networking aspect of PowerVM"},{"line_number":26,"context_line":"virtualization using Shared Ethernet Adapter only. There is a need for"},{"line_number":27,"context_line":"supporting SR-IOV in shared mode and with redundancy/failover. Users should be"},{"line_number":28,"context_line":"able to manage a VM with SR-IOV VF as a network interface. This management "},{"line_number":29,"context_line":"should include migration of VM with SR-IOV VF network interface attached to it."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_2e6d0733","line":26,"range":{"start_line":25,"start_character":0,"end_line":26,"end_character":51},"in_reply_to":"9abb7d3a_0f1dd365","updated":"2016-06-04 02:03:54.000000000","message":"References section now includes additional links now.","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"2c3bf1fdd7283105ea31b130b3595ad133d4f4a2","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":"OpenStack PowerVM drivers currently support networking aspect of PowerVM"},{"line_number":26,"context_line":"virtualization using Shared Ethernet Adapter only. There is a need for"},{"line_number":27,"context_line":"supporting SR-IOV in shared mode and with redundancy/failover. Users should be"},{"line_number":28,"context_line":"able to manage a VM with SR-IOV VF as a network interface. This management "},{"line_number":29,"context_line":"should include migration of VM with SR-IOV VF network interface attached to it."},{"line_number":30,"context_line":"PowerVM\u0027s SR-IOV implementation will include support for redundancy/failover"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9abb7d3a_8f56e303","line":27,"range":{"start_line":27,"start_character":21,"end_line":27,"end_character":61},"updated":"2016-06-01 13:57:16.000000000","message":"Shared mode?  I think that this needs to at least have a reference that explains what it is.\n\nMaybe needs a glossary section.","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"19b3286f78a702e39aa351548d3e8d037aa8f3c3","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":"OpenStack PowerVM drivers currently support networking aspect of PowerVM"},{"line_number":26,"context_line":"virtualization using Shared Ethernet Adapter only. There is a need for"},{"line_number":27,"context_line":"supporting SR-IOV in shared mode and with redundancy/failover. Users should be"},{"line_number":28,"context_line":"able to manage a VM with SR-IOV VF as a network interface. This management "},{"line_number":29,"context_line":"should include migration of VM with SR-IOV VF network interface attached to it."},{"line_number":30,"context_line":"PowerVM\u0027s SR-IOV implementation will include support for redundancy/failover"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_0e6acb1a","line":27,"range":{"start_line":27,"start_character":21,"end_line":27,"end_character":61},"in_reply_to":"9abb7d3a_8f56e303","updated":"2016-06-04 02:03:54.000000000","message":"Glossary section added.","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"2c3bf1fdd7283105ea31b130b3595ad133d4f4a2","unresolved":false,"context_lines":[{"line_number":25,"context_line":"OpenStack PowerVM drivers currently support networking aspect of PowerVM"},{"line_number":26,"context_line":"virtualization using Shared Ethernet Adapter only. There is a need for"},{"line_number":27,"context_line":"supporting SR-IOV in shared mode and with redundancy/failover. Users should be"},{"line_number":28,"context_line":"able to manage a VM with SR-IOV VF as a network interface. This management "},{"line_number":29,"context_line":"should include migration of VM with SR-IOV VF network interface attached to it."},{"line_number":30,"context_line":"PowerVM\u0027s SR-IOV implementation will include support for redundancy/failover"},{"line_number":31,"context_line":"across two SR-IOV VFs at the VIOS level. This blueprint will also address these"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9abb7d3a_cc42b9ad","line":28,"range":{"start_line":28,"start_character":74,"end_line":28,"end_character":75},"updated":"2016-06-01 13:57:16.000000000","message":"white space","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"19b3286f78a702e39aa351548d3e8d037aa8f3c3","unresolved":false,"context_lines":[{"line_number":25,"context_line":"OpenStack PowerVM drivers currently support networking aspect of PowerVM"},{"line_number":26,"context_line":"virtualization using Shared Ethernet Adapter only. There is a need for"},{"line_number":27,"context_line":"supporting SR-IOV in shared mode and with redundancy/failover. Users should be"},{"line_number":28,"context_line":"able to manage a VM with SR-IOV VF as a network interface. This management "},{"line_number":29,"context_line":"should include migration of VM with SR-IOV VF network interface attached to it."},{"line_number":30,"context_line":"PowerVM\u0027s SR-IOV implementation will include support for redundancy/failover"},{"line_number":31,"context_line":"across two SR-IOV VFs at the VIOS level. This blueprint will also address these"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_6e770f03","line":28,"range":{"start_line":28,"start_character":74,"end_line":28,"end_character":75},"in_reply_to":"9abb7d3a_cc42b9ad","updated":"2016-06-04 02:03:54.000000000","message":"Done","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"2c3bf1fdd7283105ea31b130b3595ad133d4f4a2","unresolved":false,"context_lines":[{"line_number":26,"context_line":"virtualization using Shared Ethernet Adapter only. There is a need for"},{"line_number":27,"context_line":"supporting SR-IOV in shared mode and with redundancy/failover. Users should be"},{"line_number":28,"context_line":"able to manage a VM with SR-IOV VF as a network interface. This management "},{"line_number":29,"context_line":"should include migration of VM with SR-IOV VF network interface attached to it."},{"line_number":30,"context_line":"PowerVM\u0027s SR-IOV implementation will include support for redundancy/failover"},{"line_number":31,"context_line":"across two SR-IOV VFs at the VIOS level. This blueprint will also address these"},{"line_number":32,"context_line":"special cases."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9abb7d3a_6fa73f0b","line":29,"range":{"start_line":29,"start_character":15,"end_line":29,"end_character":45},"updated":"2016-06-01 13:57:16.000000000","message":"But how is this supported when the community code does not support live migration with SR-IOV yet?  I know there is a blueprint out there, but has it been confirmed for Mitaka?","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"19b3286f78a702e39aa351548d3e8d037aa8f3c3","unresolved":false,"context_lines":[{"line_number":26,"context_line":"virtualization using Shared Ethernet Adapter only. There is a need for"},{"line_number":27,"context_line":"supporting SR-IOV in shared mode and with redundancy/failover. Users should be"},{"line_number":28,"context_line":"able to manage a VM with SR-IOV VF as a network interface. This management "},{"line_number":29,"context_line":"should include migration of VM with SR-IOV VF network interface attached to it."},{"line_number":30,"context_line":"PowerVM\u0027s SR-IOV implementation will include support for redundancy/failover"},{"line_number":31,"context_line":"across two SR-IOV VFs at the VIOS level. This blueprint will also address these"},{"line_number":32,"context_line":"special cases."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_4e74d3fc","line":29,"range":{"start_line":29,"start_character":15,"end_line":29,"end_character":45},"in_reply_to":"9abb7d3a_6fa73f0b","updated":"2016-06-04 02:03:54.000000000","message":"Done","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"2c3bf1fdd7283105ea31b130b3595ad133d4f4a2","unresolved":false,"context_lines":[{"line_number":31,"context_line":"across two SR-IOV VFs at the VIOS level. This blueprint will also address these"},{"line_number":32,"context_line":"special cases."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"While it is possible to attach a SR-IOV VF or entire SR-IOV card directly to a"},{"line_number":35,"context_line":"VM, this scenario will not be supported at this time as VM migration with such"},{"line_number":36,"context_line":"an interface will not be possible. Based on PowerVM firmware design, a VF needs"},{"line_number":37,"context_line":"to be associated with a vNIC server on VIOS and it is subsequently associated"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9abb7d3a_2fd6d74e","line":34,"range":{"start_line":34,"start_character":60,"end_line":34,"end_character":64},"updated":"2016-06-01 13:57:16.000000000","message":"Don\u0027t you mean \u0027physical port\u0027?  As a card can have many ports.","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"19b3286f78a702e39aa351548d3e8d037aa8f3c3","unresolved":false,"context_lines":[{"line_number":31,"context_line":"across two SR-IOV VFs at the VIOS level. This blueprint will also address these"},{"line_number":32,"context_line":"special cases."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"While it is possible to attach a SR-IOV VF or entire SR-IOV card directly to a"},{"line_number":35,"context_line":"VM, this scenario will not be supported at this time as VM migration with such"},{"line_number":36,"context_line":"an interface will not be possible. Based on PowerVM firmware design, a VF needs"},{"line_number":37,"context_line":"to be associated with a vNIC server on VIOS and it is subsequently associated"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_8e64fb49","line":34,"range":{"start_line":34,"start_character":60,"end_line":34,"end_character":64},"in_reply_to":"9abb7d3a_2fd6d74e","updated":"2016-06-04 02:03:54.000000000","message":"Done","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"2c3bf1fdd7283105ea31b130b3595ad133d4f4a2","unresolved":false,"context_lines":[{"line_number":31,"context_line":"across two SR-IOV VFs at the VIOS level. This blueprint will also address these"},{"line_number":32,"context_line":"special cases."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"While it is possible to attach a SR-IOV VF or entire SR-IOV card directly to a"},{"line_number":35,"context_line":"VM, this scenario will not be supported at this time as VM migration with such"},{"line_number":36,"context_line":"an interface will not be possible. Based on PowerVM firmware design, a VF needs"},{"line_number":37,"context_line":"to be associated with a vNIC server on VIOS and it is subsequently associated"},{"line_number":38,"context_line":"with vNIC client interface on a VM. This intermediary vNIC is a mandatory"},{"line_number":39,"context_line":"requirement to support migration of such a VM from host to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9abb7d3a_8ff26304","line":36,"range":{"start_line":34,"start_character":0,"end_line":36,"end_character":35},"updated":"2016-06-01 13:57:16.000000000","message":"I\u0027d like to see an entire SR-IOV VF be able to connect directly to the VM.","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"19b3286f78a702e39aa351548d3e8d037aa8f3c3","unresolved":false,"context_lines":[{"line_number":31,"context_line":"across two SR-IOV VFs at the VIOS level. This blueprint will also address these"},{"line_number":32,"context_line":"special cases."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"While it is possible to attach a SR-IOV VF or entire SR-IOV card directly to a"},{"line_number":35,"context_line":"VM, this scenario will not be supported at this time as VM migration with such"},{"line_number":36,"context_line":"an interface will not be possible. Based on PowerVM firmware design, a VF needs"},{"line_number":37,"context_line":"to be associated with a vNIC server on VIOS and it is subsequently associated"},{"line_number":38,"context_line":"with vNIC client interface on a VM. This intermediary vNIC is a mandatory"},{"line_number":39,"context_line":"requirement to support migration of such a VM from host to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_0e512b63","line":36,"range":{"start_line":34,"start_character":0,"end_line":36,"end_character":35},"in_reply_to":"9abb7d3a_8ff26304","updated":"2016-06-04 02:03:54.000000000","message":"Done","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"2c3bf1fdd7283105ea31b130b3595ad133d4f4a2","unresolved":false,"context_lines":[{"line_number":37,"context_line":"to be associated with a vNIC server on VIOS and it is subsequently associated"},{"line_number":38,"context_line":"with vNIC client interface on a VM. This intermediary vNIC is a mandatory"},{"line_number":39,"context_line":"requirement to support migration of such a VM from host to"},{"line_number":40,"context_line":"host. This intermediary is also needed to support redundancy/failover across"},{"line_number":41,"context_line":"VFs."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"It is possible to associate a VF of SR-IOV interface to VIOS as a logical port"},{"line_number":44,"context_line":"which in-turn can be used as a backing physical device for Shared Ethernet"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9abb7d3a_cffc6bba","line":41,"range":{"start_line":40,"start_character":6,"end_line":41,"end_character":4},"updated":"2016-06-01 13:57:16.000000000","message":"Maybe explain how redundancy/failover is achieved with vNIC.  Also, is there any data model impact (or more specifically, with failover, how do you fit into the existing data model).","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"19b3286f78a702e39aa351548d3e8d037aa8f3c3","unresolved":false,"context_lines":[{"line_number":37,"context_line":"to be associated with a vNIC server on VIOS and it is subsequently associated"},{"line_number":38,"context_line":"with vNIC client interface on a VM. This intermediary vNIC is a mandatory"},{"line_number":39,"context_line":"requirement to support migration of such a VM from host to"},{"line_number":40,"context_line":"host. This intermediary is also needed to support redundancy/failover across"},{"line_number":41,"context_line":"VFs."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"It is possible to associate a VF of SR-IOV interface to VIOS as a logical port"},{"line_number":44,"context_line":"which in-turn can be used as a backing physical device for Shared Ethernet"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_2e77c7d5","line":41,"range":{"start_line":40,"start_character":6,"end_line":41,"end_character":4},"in_reply_to":"9abb7d3a_cffc6bba","updated":"2016-06-04 02:03:54.000000000","message":"I will assume that no data-model changes will be needed and failover/redundancy information for a given VM and its interface can be queried using pypowervm library.","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"2c3bf1fdd7283105ea31b130b3595ad133d4f4a2","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"It is possible to associate a VF of SR-IOV interface to VIOS as a logical port"},{"line_number":44,"context_line":"which in-turn can be used as a backing physical device for Shared Ethernet"},{"line_number":45,"context_line":"Adapter. This is business as usual for existing support of Shared Ethernet "},{"line_number":46,"context_line":"Adapter in nova-powervm. No additional work is needed via this blueprint to"},{"line_number":47,"context_line":"cover this scenario."},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9abb7d3a_4c15299a","line":45,"range":{"start_line":45,"start_character":74,"end_line":45,"end_character":75},"updated":"2016-06-01 13:57:16.000000000","message":"Whitespace","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"19b3286f78a702e39aa351548d3e8d037aa8f3c3","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"It is possible to associate a VF of SR-IOV interface to VIOS as a logical port"},{"line_number":44,"context_line":"which in-turn can be used as a backing physical device for Shared Ethernet"},{"line_number":45,"context_line":"Adapter. This is business as usual for existing support of Shared Ethernet "},{"line_number":46,"context_line":"Adapter in nova-powervm. No additional work is needed via this blueprint to"},{"line_number":47,"context_line":"cover this scenario."},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_0e748bcd","line":45,"range":{"start_line":45,"start_character":74,"end_line":45,"end_character":75},"in_reply_to":"9abb7d3a_4c15299a","updated":"2016-06-04 02:03:54.000000000","message":"Done","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"2c3bf1fdd7283105ea31b130b3595ad133d4f4a2","unresolved":false,"context_lines":[{"line_number":40,"context_line":"host. This intermediary is also needed to support redundancy/failover across"},{"line_number":41,"context_line":"VFs."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"It is possible to associate a VF of SR-IOV interface to VIOS as a logical port"},{"line_number":44,"context_line":"which in-turn can be used as a backing physical device for Shared Ethernet"},{"line_number":45,"context_line":"Adapter. This is business as usual for existing support of Shared Ethernet "},{"line_number":46,"context_line":"Adapter in nova-powervm. No additional work is needed via this blueprint to"},{"line_number":47,"context_line":"cover this scenario."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"In summary, this blueprint will solve support of SR-IOV in nova-powervm for"},{"line_number":50,"context_line":"these scenarios:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9abb7d3a_6f28df33","line":47,"range":{"start_line":43,"start_character":0,"end_line":47,"end_character":20},"updated":"2016-06-01 13:57:16.000000000","message":"Is this relevant to this blueprint?","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"19b3286f78a702e39aa351548d3e8d037aa8f3c3","unresolved":false,"context_lines":[{"line_number":40,"context_line":"host. This intermediary is also needed to support redundancy/failover across"},{"line_number":41,"context_line":"VFs."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"It is possible to associate a VF of SR-IOV interface to VIOS as a logical port"},{"line_number":44,"context_line":"which in-turn can be used as a backing physical device for Shared Ethernet"},{"line_number":45,"context_line":"Adapter. This is business as usual for existing support of Shared Ethernet "},{"line_number":46,"context_line":"Adapter in nova-powervm. No additional work is needed via this blueprint to"},{"line_number":47,"context_line":"cover this scenario."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"In summary, this blueprint will solve support of SR-IOV in nova-powervm for"},{"line_number":50,"context_line":"these scenarios:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_ee43ff6a","line":47,"range":{"start_line":43,"start_character":0,"end_line":47,"end_character":20},"in_reply_to":"9abb7d3a_6f28df33","updated":"2016-06-04 02:03:54.000000000","message":"I removed it, but included an entry in glossary related to this.","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"2c3bf1fdd7283105ea31b130b3595ad133d4f4a2","unresolved":false,"context_lines":[{"line_number":54,"context_line":"or across SR-IOV cards."},{"line_number":55,"context_line":"3. Ability to associate a VLAN with vNIC backed by SR-IOV VF"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Refer to separate blueprint for networking-powervm for changes in neutron. This"},{"line_number":58,"context_line":"blueprint will focus on changes to nova-powervm only."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9abb7d3a_cfeaabda","line":57,"range":{"start_line":57,"start_character":32,"end_line":57,"end_character":50},"updated":"2016-06-01 13:57:16.000000000","message":"Link.","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"2c3bf1fdd7283105ea31b130b3595ad133d4f4a2","unresolved":false,"context_lines":[{"line_number":54,"context_line":"or across SR-IOV cards."},{"line_number":55,"context_line":"3. Ability to associate a VLAN with vNIC backed by SR-IOV VF"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Refer to separate blueprint for networking-powervm for changes in neutron. This"},{"line_number":58,"context_line":"blueprint will focus on changes to nova-powervm only."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9abb7d3a_4fbd1bd7","line":57,"range":{"start_line":57,"start_character":66,"end_line":57,"end_character":73},"updated":"2016-06-01 13:57:16.000000000","message":"not neutron core.  But the PowerVM neutron networking component.","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"19b3286f78a702e39aa351548d3e8d037aa8f3c3","unresolved":false,"context_lines":[{"line_number":54,"context_line":"or across SR-IOV cards."},{"line_number":55,"context_line":"3. Ability to associate a VLAN with vNIC backed by SR-IOV VF"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Refer to separate blueprint for networking-powervm for changes in neutron. This"},{"line_number":58,"context_line":"blueprint will focus on changes to nova-powervm only."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_4e55f31b","line":57,"range":{"start_line":57,"start_character":66,"end_line":57,"end_character":73},"in_reply_to":"9abb7d3a_4fbd1bd7","updated":"2016-06-04 02:03:54.000000000","message":"Done","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"19b3286f78a702e39aa351548d3e8d037aa8f3c3","unresolved":false,"context_lines":[{"line_number":54,"context_line":"or across SR-IOV cards."},{"line_number":55,"context_line":"3. Ability to associate a VLAN with vNIC backed by SR-IOV VF"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Refer to separate blueprint for networking-powervm for changes in neutron. This"},{"line_number":58,"context_line":"blueprint will focus on changes to nova-powervm only."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_ae30d708","line":57,"range":{"start_line":57,"start_character":32,"end_line":57,"end_character":50},"in_reply_to":"9abb7d3a_cfeaabda","updated":"2016-06-04 02:03:54.000000000","message":"Done","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"2c3bf1fdd7283105ea31b130b3595ad133d4f4a2","unresolved":false,"context_lines":[{"line_number":63,"context_line":"2. Attach vNIC backed by SR-IOV VF to a VM after it is deployed"},{"line_number":64,"context_line":"3. Detach vNIC backed by SR-IOV VF from a VM"},{"line_number":65,"context_line":"4. When a VM with vNIC backed by SR-IOV is deleted, perform detach and cleanup"},{"line_number":66,"context_line":"5. Migrate a VM with vNIC backed by SR-IOV attached to it to another host"},{"line_number":67,"context_line":"6. Provide redundancy/failover support of vNIC backed by SR-IOV VF attached to"},{"line_number":68,"context_line":"a VM during both deploy and post deploy scenarios."},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9abb7d3a_cf98eb7a","line":66,"range":{"start_line":66,"start_character":0,"end_line":66,"end_character":73},"updated":"2016-06-01 13:57:16.000000000","message":"See above concerns with the overall OpenStack use case.","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"19b3286f78a702e39aa351548d3e8d037aa8f3c3","unresolved":false,"context_lines":[{"line_number":63,"context_line":"2. Attach vNIC backed by SR-IOV VF to a VM after it is deployed"},{"line_number":64,"context_line":"3. Detach vNIC backed by SR-IOV VF from a VM"},{"line_number":65,"context_line":"4. When a VM with vNIC backed by SR-IOV is deleted, perform detach and cleanup"},{"line_number":66,"context_line":"5. Migrate a VM with vNIC backed by SR-IOV attached to it to another host"},{"line_number":67,"context_line":"6. Provide redundancy/failover support of vNIC backed by SR-IOV VF attached to"},{"line_number":68,"context_line":"a VM during both deploy and post deploy scenarios."},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_8e351bf9","line":66,"range":{"start_line":66,"start_character":0,"end_line":66,"end_character":73},"in_reply_to":"9abb7d3a_cf98eb7a","updated":"2016-06-04 02:03:54.000000000","message":"Done","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"2c3bf1fdd7283105ea31b130b3595ad133d4f4a2","unresolved":false,"context_lines":[{"line_number":70,"context_line":"Proposed change"},{"line_number":71,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":72,"context_line":"The changes will be made in three areas:"},{"line_number":73,"context_line":"More details in this area will be provided later during the development cycle"},{"line_number":74,"context_line":"if needed."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"1. Compute virt driver."},{"line_number":77,"context_line":"PowerVM compute driver is in nova_powervm.virt.powervm.driver.PowerVMDriver"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9abb7d3a_4f8b5b1f","line":74,"range":{"start_line":73,"start_character":0,"end_line":74,"end_character":10},"updated":"2016-06-01 13:57:16.000000000","message":"Earlier is better.","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"19b3286f78a702e39aa351548d3e8d037aa8f3c3","unresolved":false,"context_lines":[{"line_number":70,"context_line":"Proposed change"},{"line_number":71,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":72,"context_line":"The changes will be made in three areas:"},{"line_number":73,"context_line":"More details in this area will be provided later during the development cycle"},{"line_number":74,"context_line":"if needed."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"1. Compute virt driver."},{"line_number":77,"context_line":"PowerVM compute driver is in nova_powervm.virt.powervm.driver.PowerVMDriver"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_ee3adfe6","line":74,"range":{"start_line":73,"start_character":0,"end_line":74,"end_character":10},"in_reply_to":"9abb7d3a_4f8b5b1f","updated":"2016-06-04 02:03:54.000000000","message":"Done","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"2c3bf1fdd7283105ea31b130b3595ad133d4f4a2","unresolved":false,"context_lines":[{"line_number":76,"context_line":"1. Compute virt driver."},{"line_number":77,"context_line":"PowerVM compute driver is in nova_powervm.virt.powervm.driver.PowerVMDriver"},{"line_number":78,"context_line":"and it will be enhanced for SR-IOV VF support. PyPowervm enhancements for vNIC"},{"line_number":79,"context_line":"will be required. PyPowervm is a bunch of library functions that help to"},{"line_number":80,"context_line":"interact with pvm-rest layer. PyPowervm will offer functions to manage SR-IOV"},{"line_number":81,"context_line":"adapters and ports and vNIC."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"2. VIF driver."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9abb7d3a_cfcd8b67","line":80,"range":{"start_line":79,"start_character":18,"end_line":80,"end_character":30},"updated":"2016-06-01 13:57:16.000000000","message":"I don\u0027t know that \u0027pypowervm enhancements\u0027 is relevant to the nova-powervm virt driver changes.  I\u0027d rather claim it as a dependency.\n\nI\u0027d also change how you refer to pypowervm.\n\npypowervm is a python library that runs on the NovaLink management VM and allows virtualization control of the system.  Similar to the python library for libvirt.","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"19b3286f78a702e39aa351548d3e8d037aa8f3c3","unresolved":false,"context_lines":[{"line_number":76,"context_line":"1. Compute virt driver."},{"line_number":77,"context_line":"PowerVM compute driver is in nova_powervm.virt.powervm.driver.PowerVMDriver"},{"line_number":78,"context_line":"and it will be enhanced for SR-IOV VF support. PyPowervm enhancements for vNIC"},{"line_number":79,"context_line":"will be required. PyPowervm is a bunch of library functions that help to"},{"line_number":80,"context_line":"interact with pvm-rest layer. PyPowervm will offer functions to manage SR-IOV"},{"line_number":81,"context_line":"adapters and ports and vNIC."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"2. VIF driver."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_2e2507c2","line":80,"range":{"start_line":79,"start_character":18,"end_line":80,"end_character":30},"in_reply_to":"9abb7d3a_cfcd8b67","updated":"2016-06-04 02:03:54.000000000","message":"Done","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"2c3bf1fdd7283105ea31b130b3595ad133d4f4a2","unresolved":false,"context_lines":[{"line_number":83,"context_line":"2. VIF driver."},{"line_number":84,"context_line":"PowerVM VIF driver is in nova_powervm.virt.powervm.vif.PvmVifDriver. A new"},{"line_number":85,"context_line":"VIF driver PvmvnicSriovVifDriver will be inherited and plug/unplug methods"},{"line_number":86,"context_line":"will be implemented with PyPowervm library. Plug and unplug methods will "},{"line_number":87,"context_line":"use PyPowervm code to create VF/vNIC server/vNIC clients and attach/detach"},{"line_number":88,"context_line":"them."},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9abb7d3a_6c0e2d8d","line":86,"range":{"start_line":86,"start_character":72,"end_line":86,"end_character":73},"updated":"2016-06-01 13:57:16.000000000","message":"White Space","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"19b3286f78a702e39aa351548d3e8d037aa8f3c3","unresolved":false,"context_lines":[{"line_number":83,"context_line":"2. VIF driver."},{"line_number":84,"context_line":"PowerVM VIF driver is in nova_powervm.virt.powervm.vif.PvmVifDriver. A new"},{"line_number":85,"context_line":"VIF driver PvmvnicSriovVifDriver will be inherited and plug/unplug methods"},{"line_number":86,"context_line":"will be implemented with PyPowervm library. Plug and unplug methods will "},{"line_number":87,"context_line":"use PyPowervm code to create VF/vNIC server/vNIC clients and attach/detach"},{"line_number":88,"context_line":"them."},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_6e2f0fa2","line":86,"range":{"start_line":86,"start_character":72,"end_line":86,"end_character":73},"in_reply_to":"9abb7d3a_6c0e2d8d","updated":"2016-06-04 02:03:54.000000000","message":"Done","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"2c3bf1fdd7283105ea31b130b3595ad133d4f4a2","unresolved":false,"context_lines":[{"line_number":85,"context_line":"VIF driver PvmvnicSriovVifDriver will be inherited and plug/unplug methods"},{"line_number":86,"context_line":"will be implemented with PyPowervm library. Plug and unplug methods will "},{"line_number":87,"context_line":"use PyPowervm code to create VF/vNIC server/vNIC clients and attach/detach"},{"line_number":88,"context_line":"them."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Deployment of VM with SR-IOV VF will involve picking PF, VIOS and"},{"line_number":91,"context_line":"invoking PyPowervm library. Similarly, attachment of the same to an existing VM"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9abb7d3a_2f1897d2","line":88,"updated":"2016-06-01 13:57:16.000000000","message":"Will they use the same exact plug/unplug mechanisms?  This is just a new vif driver?\n\nWhat is the vif type?","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"19b3286f78a702e39aa351548d3e8d037aa8f3c3","unresolved":false,"context_lines":[{"line_number":85,"context_line":"VIF driver PvmvnicSriovVifDriver will be inherited and plug/unplug methods"},{"line_number":86,"context_line":"will be implemented with PyPowervm library. Plug and unplug methods will "},{"line_number":87,"context_line":"use PyPowervm code to create VF/vNIC server/vNIC clients and attach/detach"},{"line_number":88,"context_line":"them."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Deployment of VM with SR-IOV VF will involve picking PF, VIOS and"},{"line_number":91,"context_line":"invoking PyPowervm library. Similarly, attachment of the same to an existing VM"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_4e2cd3ab","line":88,"in_reply_to":"9abb7d3a_2f1897d2","updated":"2016-06-04 02:03:54.000000000","message":"Done","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"2c3bf1fdd7283105ea31b130b3595ad133d4f4a2","unresolved":false,"context_lines":[{"line_number":88,"context_line":"them."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Deployment of VM with SR-IOV VF will involve picking PF, VIOS and"},{"line_number":91,"context_line":"invoking PyPowervm library. Similarly, attachment of the same to an existing VM"},{"line_number":92,"context_line":"will be implemented. Evacuate and migration of VM will be supported with"},{"line_number":93,"context_line":"changes to compute virt driver and VIF driver via PyPowervm library."},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9abb7d3a_4f7cfbeb","line":91,"range":{"start_line":91,"start_character":9,"end_line":91,"end_character":18},"updated":"2016-06-01 13:57:16.000000000","message":"pypowervm is all lowercase.","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"19b3286f78a702e39aa351548d3e8d037aa8f3c3","unresolved":false,"context_lines":[{"line_number":88,"context_line":"them."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Deployment of VM with SR-IOV VF will involve picking PF, VIOS and"},{"line_number":91,"context_line":"invoking PyPowervm library. Similarly, attachment of the same to an existing VM"},{"line_number":92,"context_line":"will be implemented. Evacuate and migration of VM will be supported with"},{"line_number":93,"context_line":"changes to compute virt driver and VIF driver via PyPowervm library."},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_ae173753","line":91,"range":{"start_line":91,"start_character":9,"end_line":91,"end_character":18},"in_reply_to":"9abb7d3a_4f7cfbeb","updated":"2016-06-04 02:03:54.000000000","message":"Done","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"2c3bf1fdd7283105ea31b130b3595ad133d4f4a2","unresolved":false,"context_lines":[{"line_number":114,"context_line":"offered by SR-IOV cards in the environment, scale tests will involve less"},{"line_number":115,"context_line":"number of VMs."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Deployer impact"},{"line_number":118,"context_line":"---------------"},{"line_number":119,"context_line":"None"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Developer impact"},{"line_number":122,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9abb7d3a_cfde2bdc","line":119,"range":{"start_line":117,"start_character":0,"end_line":119,"end_character":4},"updated":"2016-06-01 13:57:16.000000000","message":"How exactly do I go about using this new function?","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"19b3286f78a702e39aa351548d3e8d037aa8f3c3","unresolved":false,"context_lines":[{"line_number":114,"context_line":"offered by SR-IOV cards in the environment, scale tests will involve less"},{"line_number":115,"context_line":"number of VMs."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Deployer impact"},{"line_number":118,"context_line":"---------------"},{"line_number":119,"context_line":"None"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Developer impact"},{"line_number":122,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_ee113f5f","line":119,"range":{"start_line":117,"start_character":0,"end_line":119,"end_character":4},"in_reply_to":"9abb7d3a_cfde2bdc","updated":"2016-06-04 02:03:54.000000000","message":"Done","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"2c3bf1fdd7283105ea31b130b3595ad133d4f4a2","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Dependencies"},{"line_number":126,"context_line":"------------"},{"line_number":127,"context_line":"1. REST interface (pvm-rest on novalink)"},{"line_number":128,"context_line":"2. PyPowervm library"},{"line_number":129,"context_line":"2. PowerVM changes in hypervisor firmware."},{"line_number":130,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9abb7d3a_afae472b","line":127,"range":{"start_line":127,"start_character":0,"end_line":127,"end_character":40},"updated":"2016-06-01 13:57:16.000000000","message":"I would simply say \u0027An updated version of the NovaLink PowerVM feature.\u0027","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"19b3286f78a702e39aa351548d3e8d037aa8f3c3","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Dependencies"},{"line_number":126,"context_line":"------------"},{"line_number":127,"context_line":"1. REST interface (pvm-rest on novalink)"},{"line_number":128,"context_line":"2. PyPowervm library"},{"line_number":129,"context_line":"2. PowerVM changes in hypervisor firmware."},{"line_number":130,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_ce160355","line":127,"range":{"start_line":127,"start_character":0,"end_line":127,"end_character":40},"in_reply_to":"9abb7d3a_afae472b","updated":"2016-06-04 02:03:54.000000000","message":"Done","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"2c3bf1fdd7283105ea31b130b3595ad133d4f4a2","unresolved":false,"context_lines":[{"line_number":126,"context_line":"------------"},{"line_number":127,"context_line":"1. REST interface (pvm-rest on novalink)"},{"line_number":128,"context_line":"2. PyPowervm library"},{"line_number":129,"context_line":"2. PowerVM changes in hypervisor firmware."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Implementation"},{"line_number":132,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9abb7d3a_6fea9f75","line":129,"range":{"start_line":129,"start_character":0,"end_line":129,"end_character":1},"updated":"2016-06-01 13:57:16.000000000","message":"3?","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"2c3bf1fdd7283105ea31b130b3595ad133d4f4a2","unresolved":false,"context_lines":[{"line_number":126,"context_line":"------------"},{"line_number":127,"context_line":"1. REST interface (pvm-rest on novalink)"},{"line_number":128,"context_line":"2. PyPowervm library"},{"line_number":129,"context_line":"2. PowerVM changes in hypervisor firmware."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Implementation"},{"line_number":132,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9abb7d3a_cf7aabbc","line":129,"range":{"start_line":129,"start_character":3,"end_line":129,"end_character":42},"updated":"2016-06-01 13:57:16.000000000","message":"I think this would be covered by 1, if you use the updated wording.","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"19b3286f78a702e39aa351548d3e8d037aa8f3c3","unresolved":false,"context_lines":[{"line_number":126,"context_line":"------------"},{"line_number":127,"context_line":"1. REST interface (pvm-rest on novalink)"},{"line_number":128,"context_line":"2. PyPowervm library"},{"line_number":129,"context_line":"2. PowerVM changes in hypervisor firmware."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Implementation"},{"line_number":132,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_2e0ce741","line":129,"range":{"start_line":129,"start_character":0,"end_line":129,"end_character":1},"in_reply_to":"9abb7d3a_6fea9f75","updated":"2016-06-04 02:03:54.000000000","message":"Done","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"19b3286f78a702e39aa351548d3e8d037aa8f3c3","unresolved":false,"context_lines":[{"line_number":126,"context_line":"------------"},{"line_number":127,"context_line":"1. REST interface (pvm-rest on novalink)"},{"line_number":128,"context_line":"2. PyPowervm library"},{"line_number":129,"context_line":"2. PowerVM changes in hypervisor firmware."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Implementation"},{"line_number":132,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_0e092b32","line":129,"range":{"start_line":129,"start_character":3,"end_line":129,"end_character":42},"in_reply_to":"9abb7d3a_cf7aabbc","updated":"2016-06-04 02:03:54.000000000","message":"Done","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"2c3bf1fdd7283105ea31b130b3595ad133d4f4a2","unresolved":false,"context_lines":[{"line_number":131,"context_line":"Implementation"},{"line_number":132,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Assignee(s)"},{"line_number":135,"context_line":"-----------"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Work Items"},{"line_number":138,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9abb7d3a_8c9ef104","line":135,"range":{"start_line":134,"start_character":0,"end_line":135,"end_character":11},"updated":"2016-06-01 13:57:16.000000000","message":"Who is assigned to this?","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"19b3286f78a702e39aa351548d3e8d037aa8f3c3","unresolved":false,"context_lines":[{"line_number":131,"context_line":"Implementation"},{"line_number":132,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Assignee(s)"},{"line_number":135,"context_line":"-----------"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Work Items"},{"line_number":138,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_6e06ef21","line":135,"range":{"start_line":134,"start_character":0,"end_line":135,"end_character":11},"in_reply_to":"9abb7d3a_8c9ef104","updated":"2016-06-04 02:03:54.000000000","message":"Done","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"2c3bf1fdd7283105ea31b130b3595ad133d4f4a2","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Work Items"},{"line_number":138,"context_line":"----------"},{"line_number":139,"context_line":"1. PyPowervm changes"},{"line_number":140,"context_line":"2. nova-powervm changes"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Testing"},{"line_number":143,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9abb7d3a_6f461f7c","line":140,"range":{"start_line":139,"start_character":0,"end_line":140,"end_character":23},"updated":"2016-06-01 13:57:16.000000000","message":"Can you elaborate more here?","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"19b3286f78a702e39aa351548d3e8d037aa8f3c3","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Work Items"},{"line_number":138,"context_line":"----------"},{"line_number":139,"context_line":"1. PyPowervm changes"},{"line_number":140,"context_line":"2. nova-powervm changes"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Testing"},{"line_number":143,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_4e033310","line":140,"range":{"start_line":139,"start_character":0,"end_line":140,"end_character":23},"in_reply_to":"9abb7d3a_6f461f7c","updated":"2016-06-04 02:03:54.000000000","message":"Done","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"2c3bf1fdd7283105ea31b130b3595ad133d4f4a2","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Testing"},{"line_number":143,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":144,"context_line":"1. Unit test"},{"line_number":145,"context_line":"2. Function test"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Documentation impact"},{"line_number":148,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9abb7d3a_6f145f4c","line":145,"range":{"start_line":144,"start_character":0,"end_line":145,"end_character":16},"updated":"2016-06-01 13:57:16.000000000","message":"Elaborate more?\n\nHow about CI?  I don\u0027t think you\u0027ve accounted for CI?  Maybe a nightly job or something?  I know that creating a whole new CI for the SR-IOV may be challenging, so how can we bridge that gap?","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"19b3286f78a702e39aa351548d3e8d037aa8f3c3","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Testing"},{"line_number":143,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":144,"context_line":"1. Unit test"},{"line_number":145,"context_line":"2. Function test"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Documentation impact"},{"line_number":148,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_b1fe7a03","line":145,"range":{"start_line":144,"start_character":0,"end_line":145,"end_character":16},"in_reply_to":"9abb7d3a_6f145f4c","updated":"2016-06-04 02:03:54.000000000","message":"Done","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"2c3bf1fdd7283105ea31b130b3595ad133d4f4a2","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Documentation impact"},{"line_number":148,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":149,"context_line":"All use-cases need to be documented."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"References"},{"line_number":152,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9abb7d3a_921f285a","line":149,"range":{"start_line":149,"start_character":0,"end_line":149,"end_character":36},"updated":"2016-06-01 13:57:16.000000000","message":"Where?  In the developer docs?\n\nI know Adam is doing some work here.","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"19b3286f78a702e39aa351548d3e8d037aa8f3c3","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Documentation impact"},{"line_number":148,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":149,"context_line":"All use-cases need to be documented."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"References"},{"line_number":152,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_91037e0d","line":149,"range":{"start_line":149,"start_character":0,"end_line":149,"end_character":36},"in_reply_to":"9abb7d3a_921f285a","updated":"2016-06-04 02:03:54.000000000","message":"Done","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"2c3bf1fdd7283105ea31b130b3595ad133d4f4a2","unresolved":false,"context_lines":[{"line_number":168,"context_line":"   These wiki pages describe SR-IOV in OpenStack"},{"line_number":169,"context_line":"4. https://review.openstack.org/#/c/139910/"},{"line_number":170,"context_line":"   This blueprint addresses SR-IOV attach/detach function in nova."},{"line_number":171,"context_line":"5. networking-powervm blueprint for same work."},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"History"},{"line_number":174,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9abb7d3a_327abc88","line":171,"range":{"start_line":171,"start_character":0,"end_line":171,"end_character":46},"updated":"2016-06-01 13:57:16.000000000","message":"Link to review?","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"19b3286f78a702e39aa351548d3e8d037aa8f3c3","unresolved":false,"context_lines":[{"line_number":168,"context_line":"   These wiki pages describe SR-IOV in OpenStack"},{"line_number":169,"context_line":"4. https://review.openstack.org/#/c/139910/"},{"line_number":170,"context_line":"   This blueprint addresses SR-IOV attach/detach function in nova."},{"line_number":171,"context_line":"5. networking-powervm blueprint for same work."},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"History"},{"line_number":174,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_f108022b","line":171,"range":{"start_line":171,"start_character":0,"end_line":171,"end_character":46},"in_reply_to":"9abb7d3a_327abc88","updated":"2016-06-04 02:03:54.000000000","message":"Done","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"2c3bf1fdd7283105ea31b130b3595ad133d4f4a2","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"History"},{"line_number":174,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":175,"context_line":"Release Name\tDescription"},{"line_number":176,"context_line":"------------    -----------"},{"line_number":177,"context_line":"Newton          Introduced"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9abb7d3a_2c7f05e1","line":175,"range":{"start_line":175,"start_character":12,"end_line":175,"end_character":13},"updated":"2016-06-01 13:57:16.000000000","message":"Use spaces, not a tab.","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"19b3286f78a702e39aa351548d3e8d037aa8f3c3","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"History"},{"line_number":174,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":175,"context_line":"Release Name\tDescription"},{"line_number":176,"context_line":"------------    -----------"},{"line_number":177,"context_line":"Newton          Introduced"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_d10d0639","line":175,"range":{"start_line":175,"start_character":12,"end_line":175,"end_character":13},"in_reply_to":"9abb7d3a_2c7f05e1","updated":"2016-06-04 02:03:54.000000000","message":"Done","commit_id":"93513f6347f02505c96b04dce4091f89dad83626"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f1c37c6b91085a979cf299c711add8db6fd4baf2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7aa08908_27df1dda","updated":"2016-06-08 14:42:55.000000000","message":"Feels like we\u0027re lacking a lot of high-level design details.  We\u0027ll have consumer-facing setup/configuration that needs to be done to make this functionality work.  Is this not the right place for those details to be fleshed out?","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f1c37c6b91085a979cf299c711add8db6fd4baf2","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Nova support for SR-IOV VIF Types"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova-powervm/+spec/powervm-sriov-nova"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint will address support of SR-IOV in conjunction with both SR-IOV VF"},{"line_number":14,"context_line":"directly attached to VM and PowerVM vNIC into nova-powervm. SR-IOV support was"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_86a3acb1","line":11,"updated":"2016-06-08 14:42:55.000000000","message":"Make this a real RST link","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"4824770031b7f9667315022f116b245b2c81d061","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This blueprint will address support of SR-IOV in conjunction with both SR-IOV VF"},{"line_number":14,"context_line":"directly attached to VM and PowerVM vNIC into nova-powervm. SR-IOV support was"},{"line_number":15,"context_line":"added to Juno release of OpenStack, this blueprint will attempt to fit"},{"line_number":16,"context_line":"both scenario implementations into it."},{"line_number":17,"context_line":"A separate blueprint will be made available for design elements regarding"},{"line_number":18,"context_line":"networking-powervm. (Refer to https://review.openstack.org/#/c/322210/)"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_a309e133","line":16,"updated":"2016-06-06 12:53:45.000000000","message":"New paragraph, add line","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"4824770031b7f9667315022f116b245b2c81d061","unresolved":false,"context_lines":[{"line_number":27,"context_line":"Problem Description"},{"line_number":28,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":29,"context_line":"OpenStack PowerVM drivers currently support networking aspect of PowerVM"},{"line_number":30,"context_line":"virtualization using Shared Ethernet Adapter and OpenVSwitch. Support for Linux"},{"line_number":31,"context_line":"Bridge will be added in future. There is a need for supporting SR-IOV ports"},{"line_number":32,"context_line":"with redundancy/failover. Users should be able to manage a VM with"},{"line_number":33,"context_line":"SR-IOV VF as a network interface. This management"},{"line_number":34,"context_line":"should include migration of VM with SR-IOV VF network interface attached to it."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_7e44b273","line":31,"range":{"start_line":30,"start_character":44,"end_line":31,"end_character":31},"updated":"2016-06-06 12:53:45.000000000","message":"Just say Shared Ethernet, Open vSwitch and Linux Bridging.  No need to say in the future, it\u0027ll land this release.  It is pretty close.","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"4824770031b7f9667315022f116b245b2c81d061","unresolved":false,"context_lines":[{"line_number":30,"context_line":"virtualization using Shared Ethernet Adapter and OpenVSwitch. Support for Linux"},{"line_number":31,"context_line":"Bridge will be added in future. There is a need for supporting SR-IOV ports"},{"line_number":32,"context_line":"with redundancy/failover. Users should be able to manage a VM with"},{"line_number":33,"context_line":"SR-IOV VF as a network interface. This management"},{"line_number":34,"context_line":"should include migration of VM with SR-IOV VF network interface attached to it."},{"line_number":35,"context_line":"Migration support will be added only with vNIC based scenario and not with"},{"line_number":36,"context_line":"direct VF attached scenario."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_fe2f029f","line":33,"updated":"2016-06-06 12:53:45.000000000","message":"The lines aren\u0027t very well lines up here.  Can you extend this to 80 characters?","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"4824770031b7f9667315022f116b245b2c81d061","unresolved":false,"context_lines":[{"line_number":33,"context_line":"SR-IOV VF as a network interface. This management"},{"line_number":34,"context_line":"should include migration of VM with SR-IOV VF network interface attached to it."},{"line_number":35,"context_line":"Migration support will be added only with vNIC based scenario and not with"},{"line_number":36,"context_line":"direct VF attached scenario."},{"line_number":37,"context_line":"Migration support for SR-IOV is not supported currently, but there are"},{"line_number":38,"context_line":"efforts to support it for KVM using macvtap. There is a blueprint in progress"},{"line_number":39,"context_line":"in Newton: https://blueprints.launchpad.net/nova/+spec/sriov-live-migration"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_e0091c2e","line":36,"updated":"2016-06-06 12:53:45.000000000","message":"Is the next line a new paragraph, or same?  Looks like there are spacing issues here.  I\u0027ll just document the rest as \u0027spacing issue\u0027.","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f1c37c6b91085a979cf299c711add8db6fd4baf2","unresolved":false,"context_lines":[{"line_number":36,"context_line":"direct VF attached scenario."},{"line_number":37,"context_line":"Migration support for SR-IOV is not supported currently, but there are"},{"line_number":38,"context_line":"efforts to support it for KVM using macvtap. There is a blueprint in progress"},{"line_number":39,"context_line":"in Newton: https://blueprints.launchpad.net/nova/+spec/sriov-live-migration"},{"line_number":40,"context_line":"PowerVM\u0027s SR-IOV implementation will include support for redundancy/failover"},{"line_number":41,"context_line":"across two SR-IOV VFs at the VIOS level. This blueprint will also address these"},{"line_number":42,"context_line":"special cases."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_86060c84","line":39,"range":{"start_line":39,"start_character":11,"end_line":39,"end_character":75},"updated":"2016-06-08 14:42:55.000000000","message":"RST link","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"4824770031b7f9667315022f116b245b2c81d061","unresolved":false,"context_lines":[{"line_number":38,"context_line":"efforts to support it for KVM using macvtap. There is a blueprint in progress"},{"line_number":39,"context_line":"in Newton: https://blueprints.launchpad.net/nova/+spec/sriov-live-migration"},{"line_number":40,"context_line":"PowerVM\u0027s SR-IOV implementation will include support for redundancy/failover"},{"line_number":41,"context_line":"across two SR-IOV VFs at the VIOS level. This blueprint will also address these"},{"line_number":42,"context_line":"special cases."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"While it is possible to attach entire physical port of SR-IOV card directly to a"},{"line_number":45,"context_line":"VM, this scenario will not be supported at this time as VM migration with such"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_20b04443","line":42,"range":{"start_line":41,"start_character":40,"end_line":42,"end_character":14},"updated":"2016-06-06 12:53:45.000000000","message":"Can you change this wording?  I don\u0027t agree with it as is.\n\nInstead, I\u0027d say, \"This blueprint will be built to support the live migration work being done in core nova for SR-IOV, however if that does not land in Newton then the work here will still continue without live migration support until Ocata\"\n\nOr something about how nothing that is done here will prevent us from doing Live Migration.","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"4824770031b7f9667315022f116b245b2c81d061","unresolved":false,"context_lines":[{"line_number":42,"context_line":"special cases."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"While it is possible to attach entire physical port of SR-IOV card directly to a"},{"line_number":45,"context_line":"VM, this scenario will not be supported at this time as VM migration with such"},{"line_number":46,"context_line":"an interface will not be possible."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Based on PowerVM firmware design, a VF needs"},{"line_number":49,"context_line":"to be associated with a vNIC server on VIOS and it is subsequently associated"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_8063f8b0","line":46,"range":{"start_line":45,"start_character":52,"end_line":46,"end_character":34},"updated":"2016-06-06 12:53:45.000000000","message":"VM migration certainly isn\u0027t a strong enough reason not to do this.\n\nIf its a matter of work, I\u0027d just say \u0027A future blueprint will handle this scenario, but it is seen as more useful to start with VF attach to VMs.\u0027","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f1c37c6b91085a979cf299c711add8db6fd4baf2","unresolved":false,"context_lines":[{"line_number":42,"context_line":"special cases."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"While it is possible to attach entire physical port of SR-IOV card directly to a"},{"line_number":45,"context_line":"VM, this scenario will not be supported at this time as VM migration with such"},{"line_number":46,"context_line":"an interface will not be possible."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Based on PowerVM firmware design, a VF needs"},{"line_number":49,"context_line":"to be associated with a vNIC server on VIOS and it is subsequently associated"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_c6e654af","line":46,"range":{"start_line":45,"start_character":52,"end_line":46,"end_character":34},"in_reply_to":"7aa08908_8063f8b0","updated":"2016-06-08 14:42:55.000000000","message":"Do we support direct-attach of a regular ethernet pport to a VM?  If not, then why would we ever want to support direct-attach of an entire SRIOV pport?  (Is that the same as promiscuous mode?  And/or the same as dedicated mode?)","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"4824770031b7f9667315022f116b245b2c81d061","unresolved":false,"context_lines":[{"line_number":45,"context_line":"VM, this scenario will not be supported at this time as VM migration with such"},{"line_number":46,"context_line":"an interface will not be possible."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Based on PowerVM firmware design, a VF needs"},{"line_number":49,"context_line":"to be associated with a vNIC server on VIOS and it is subsequently associated"},{"line_number":50,"context_line":"with vNIC client interface on a VM. This intermediary vNIC is a mandatory"},{"line_number":51,"context_line":"requirement to support migration of such a VM from host to"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_606d2c98","line":48,"updated":"2016-06-06 12:53:45.000000000","message":"spacing issue.","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"4824770031b7f9667315022f116b245b2c81d061","unresolved":false,"context_lines":[{"line_number":46,"context_line":"an interface will not be possible."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Based on PowerVM firmware design, a VF needs"},{"line_number":49,"context_line":"to be associated with a vNIC server on VIOS and it is subsequently associated"},{"line_number":50,"context_line":"with vNIC client interface on a VM. This intermediary vNIC is a mandatory"},{"line_number":51,"context_line":"requirement to support migration of such a VM from host to"},{"line_number":52,"context_line":"host. This intermediary is also needed to support redundancy/failover across"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_00f708d4","line":49,"range":{"start_line":49,"start_character":39,"end_line":49,"end_character":43},"updated":"2016-06-06 12:53:45.000000000","message":"Define this in a glossary","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"4824770031b7f9667315022f116b245b2c81d061","unresolved":false,"context_lines":[{"line_number":46,"context_line":"an interface will not be possible."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Based on PowerVM firmware design, a VF needs"},{"line_number":49,"context_line":"to be associated with a vNIC server on VIOS and it is subsequently associated"},{"line_number":50,"context_line":"with vNIC client interface on a VM. This intermediary vNIC is a mandatory"},{"line_number":51,"context_line":"requirement to support migration of such a VM from host to"},{"line_number":52,"context_line":"host. This intermediary is also needed to support redundancy/failover across"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_400110ae","line":49,"range":{"start_line":49,"start_character":24,"end_line":49,"end_character":28},"updated":"2016-06-06 12:53:45.000000000","message":"Define this in a glossary.","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f1c37c6b91085a979cf299c711add8db6fd4baf2","unresolved":false,"context_lines":[{"line_number":50,"context_line":"with vNIC client interface on a VM. This intermediary vNIC is a mandatory"},{"line_number":51,"context_line":"requirement to support migration of such a VM from host to"},{"line_number":52,"context_line":"host. This intermediary is also needed to support redundancy/failover across"},{"line_number":53,"context_line":"VFs. For setting up redundancy, a n-number of SR-IOV PFs have to be provided"},{"line_number":54,"context_line":"to pypowervm layer and VFs and vNIC servers will be carved out of them and"},{"line_number":55,"context_line":"connected to vNIC client adapter on VM. Regarding data-model changes for"},{"line_number":56,"context_line":"failover/redundancy, there will be one port created in neutron. With this"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_31ce3f63","line":53,"range":{"start_line":53,"start_character":53,"end_line":53,"end_character":56},"updated":"2016-06-08 14:42:55.000000000","message":"Actually physical ports, which aren\u0027t the same as PFs.  Talk to @kriskend","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"4824770031b7f9667315022f116b245b2c81d061","unresolved":false,"context_lines":[{"line_number":53,"context_line":"VFs. For setting up redundancy, a n-number of SR-IOV PFs have to be provided"},{"line_number":54,"context_line":"to pypowervm layer and VFs and vNIC servers will be carved out of them and"},{"line_number":55,"context_line":"connected to vNIC client adapter on VM. Regarding data-model changes for"},{"line_number":56,"context_line":"failover/redundancy, there will be one port created in neutron. With this"},{"line_number":57,"context_line":"assumption, no additional data-model changes will be needed in nova and neutron."},{"line_number":58,"context_line":"It is my assumption that failover/redundancy information can be retrieved using"},{"line_number":59,"context_line":"pypowervm library whenever required."},{"line_number":60,"context_line":"It is also possible to associate SR-IOV VF to a VM directly and this path will"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_4018f01d","line":57,"range":{"start_line":56,"start_character":64,"end_line":57,"end_character":80},"updated":"2016-06-06 12:53:45.000000000","message":"How can this be?  Don\u0027t we have data model implications in nova and the PCI specs?\n\nCan you elaborate how the PCI spec data will be handled.","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"4824770031b7f9667315022f116b245b2c81d061","unresolved":false,"context_lines":[{"line_number":55,"context_line":"connected to vNIC client adapter on VM. Regarding data-model changes for"},{"line_number":56,"context_line":"failover/redundancy, there will be one port created in neutron. With this"},{"line_number":57,"context_line":"assumption, no additional data-model changes will be needed in nova and neutron."},{"line_number":58,"context_line":"It is my assumption that failover/redundancy information can be retrieved using"},{"line_number":59,"context_line":"pypowervm library whenever required."},{"line_number":60,"context_line":"It is also possible to associate SR-IOV VF to a VM directly and this path will"},{"line_number":61,"context_line":"also be supported by this design. However, such a setup will not provide"},{"line_number":62,"context_line":"migration support."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_60f24cd4","line":59,"range":{"start_line":58,"start_character":0,"end_line":59,"end_character":36},"updated":"2016-06-06 12:53:45.000000000","message":"This doesn\u0027t seem necessary.","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"4824770031b7f9667315022f116b245b2c81d061","unresolved":false,"context_lines":[{"line_number":57,"context_line":"assumption, no additional data-model changes will be needed in nova and neutron."},{"line_number":58,"context_line":"It is my assumption that failover/redundancy information can be retrieved using"},{"line_number":59,"context_line":"pypowervm library whenever required."},{"line_number":60,"context_line":"It is also possible to associate SR-IOV VF to a VM directly and this path will"},{"line_number":61,"context_line":"also be supported by this design. However, such a setup will not provide"},{"line_number":62,"context_line":"migration support."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"In summary, this blueprint will solve support of SR-IOV in nova-powervm for"},{"line_number":65,"context_line":"these scenarios:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_60a08ca0","line":62,"range":{"start_line":60,"start_character":0,"end_line":62,"end_character":18},"updated":"2016-06-06 12:53:45.000000000","message":"I\u0027d lead with this paragraph.  This is the support that is most synonymous with what KVM support has today.","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f1c37c6b91085a979cf299c711add8db6fd4baf2","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Refer to separate blueprint for networking-powervm for changes in PowerVM"},{"line_number":75,"context_line":"neutron networking component. This blueprint will focus on changes to"},{"line_number":76,"context_line":"nova-powervm only. Refer to https://review.openstack.org/#/c/322210/ for"},{"line_number":77,"context_line":"review of networking-powervm blueprint."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_96bf2960","line":76,"range":{"start_line":76,"start_character":28,"end_line":76,"end_character":68},"updated":"2016-06-08 14:42:55.000000000","message":"RST link.","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f1c37c6b91085a979cf299c711add8db6fd4baf2","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Use Cases"},{"line_number":80,"context_line":"---------"},{"line_number":81,"context_line":"1. Attach vNIC backed by SR-IOV VF to a VM during boot time"},{"line_number":82,"context_line":"2. Attach vNIC backed by SR-IOV VF to a VM after it is deployed"},{"line_number":83,"context_line":"3. Detach vNIC backed by SR-IOV VF from a VM"},{"line_number":84,"context_line":"4. When a VM with vNIC backed by SR-IOV is deleted, perform detach and cleanup"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_7669ddf8","line":81,"range":{"start_line":81,"start_character":32,"end_line":81,"end_character":34},"updated":"2016-06-08 14:42:55.000000000","message":"VF(s) (i.e. one or more)\n\nSame for other use cases.","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"4824770031b7f9667315022f116b245b2c81d061","unresolved":false,"context_lines":[{"line_number":82,"context_line":"2. Attach vNIC backed by SR-IOV VF to a VM after it is deployed"},{"line_number":83,"context_line":"3. Detach vNIC backed by SR-IOV VF from a VM"},{"line_number":84,"context_line":"4. When a VM with vNIC backed by SR-IOV is deleted, perform detach and cleanup"},{"line_number":85,"context_line":"5. Migrate  a VM with vNIC backed by SR-IOV attached to it to another host"},{"line_number":86,"context_line":"6. Provide redundancy/failover support of vNIC backed by SR-IOV VF attached to"},{"line_number":87,"context_line":"a VM during both deploy and post deploy scenarios."},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_c0ece0c9","line":85,"range":{"start_line":85,"start_character":3,"end_line":85,"end_character":74},"updated":"2016-06-06 12:53:45.000000000","message":"This is kind of hard to read.  Maybe just \"Live migrate a VM if using vNIC backed SR-IOV support\"","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"4824770031b7f9667315022f116b245b2c81d061","unresolved":false,"context_lines":[{"line_number":82,"context_line":"2. Attach vNIC backed by SR-IOV VF to a VM after it is deployed"},{"line_number":83,"context_line":"3. Detach vNIC backed by SR-IOV VF from a VM"},{"line_number":84,"context_line":"4. When a VM with vNIC backed by SR-IOV is deleted, perform detach and cleanup"},{"line_number":85,"context_line":"5. Migrate  a VM with vNIC backed by SR-IOV attached to it to another host"},{"line_number":86,"context_line":"6. Provide redundancy/failover support of vNIC backed by SR-IOV VF attached to"},{"line_number":87,"context_line":"a VM during both deploy and post deploy scenarios."},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_80949837","line":85,"range":{"start_line":85,"start_character":11,"end_line":85,"end_character":12},"updated":"2016-06-06 12:53:45.000000000","message":"spacing issue","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f1c37c6b91085a979cf299c711add8db6fd4baf2","unresolved":false,"context_lines":[{"line_number":91,"context_line":"The changes will be made in two areas:"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"1. Compute virt driver."},{"line_number":94,"context_line":"PowerVM compute driver is in nova_powervm.virt.powervm.driver.PowerVMDriver"},{"line_number":95,"context_line":"and it will be enhanced for SR-IOV VF support. pypowervm enhancements for vNIC"},{"line_number":96,"context_line":"will be required. pypowervm is a python library that runs on the NovaLink"},{"line_number":97,"context_line":"management VM and allows virtualization control of the system. This is similar"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_51182b75","line":94,"range":{"start_line":94,"start_character":29,"end_line":94,"end_character":75},"updated":"2016-06-08 14:42:55.000000000","message":"Should this perhaps say nova.virt.powervm.driver.PowerVMDriver?  That\u0027s currently the entry point for the driver, even though the real code lives under nova_powervm.  And then we would be covered for the future when we are in tree.","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f1c37c6b91085a979cf299c711add8db6fd4baf2","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"2. VIF driver."},{"line_number":102,"context_line":"PowerVM VIF driver is in nova_powervm.virt.powervm.vif.PvmVifDriver. A new"},{"line_number":103,"context_line":"VIF driver PvmvnicSriovVifDriver will be inherited and plug/unplug methods"},{"line_number":104,"context_line":"will be implemented with pypowervm library. Plug and unplug methods will"},{"line_number":105,"context_line":"use pypowervm code to create VF/vNIC server/vNIC clients and attach/detach"},{"line_number":106,"context_line":"them. This will be a new vif driver, with vif type pvc_vnic (configuration"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_91a733bc","line":103,"range":{"start_line":103,"start_character":11,"end_line":103,"end_character":32},"updated":"2016-06-08 14:42:55.000000000","message":"Do we also need a PvmVFSriovVifDriver (for direct attach)?","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"4824770031b7f9667315022f116b245b2c81d061","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"2. VIF driver."},{"line_number":102,"context_line":"PowerVM VIF driver is in nova_powervm.virt.powervm.vif.PvmVifDriver. A new"},{"line_number":103,"context_line":"VIF driver PvmvnicSriovVifDriver will be inherited and plug/unplug methods"},{"line_number":104,"context_line":"will be implemented with pypowervm library. Plug and unplug methods will"},{"line_number":105,"context_line":"use pypowervm code to create VF/vNIC server/vNIC clients and attach/detach"},{"line_number":106,"context_line":"them. This will be a new vif driver, with vif type pvc_vnic (configuration"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_80093898","line":103,"range":{"start_line":103,"start_character":11,"end_line":103,"end_character":32},"updated":"2016-06-06 12:53:45.000000000","message":"Perhaps PvmVnicSriovVifDriver","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"4824770031b7f9667315022f116b245b2c81d061","unresolved":false,"context_lines":[{"line_number":103,"context_line":"VIF driver PvmvnicSriovVifDriver will be inherited and plug/unplug methods"},{"line_number":104,"context_line":"will be implemented with pypowervm library. Plug and unplug methods will"},{"line_number":105,"context_line":"use pypowervm code to create VF/vNIC server/vNIC clients and attach/detach"},{"line_number":106,"context_line":"them. This will be a new vif driver, with vif type pvc_vnic (configuration"},{"line_number":107,"context_line":"including vNIC)/pvc_vf (VF directly connected to VM). Plug and unplug mechanisms"},{"line_number":108,"context_line":"will be different and specialized for PowerVM using pypowervm library."},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_c03a2036","line":106,"range":{"start_line":106,"start_character":51,"end_line":106,"end_character":59},"updated":"2016-06-06 12:53:45.000000000","message":"So are we able to use the \u0027direct\u0027 tag in networking-powervm","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f1c37c6b91085a979cf299c711add8db6fd4baf2","unresolved":false,"context_lines":[{"line_number":103,"context_line":"VIF driver PvmvnicSriovVifDriver will be inherited and plug/unplug methods"},{"line_number":104,"context_line":"will be implemented with pypowervm library. Plug and unplug methods will"},{"line_number":105,"context_line":"use pypowervm code to create VF/vNIC server/vNIC clients and attach/detach"},{"line_number":106,"context_line":"them. This will be a new vif driver, with vif type pvc_vnic (configuration"},{"line_number":107,"context_line":"including vNIC)/pvc_vf (VF directly connected to VM). Plug and unplug mechanisms"},{"line_number":108,"context_line":"will be different and specialized for PowerVM using pypowervm library."},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_91d9f359","line":106,"range":{"start_line":106,"start_character":51,"end_line":106,"end_character":59},"updated":"2016-06-08 14:42:55.000000000","message":"Typo.  I imagine these should be pvm_vnic/pvm_vf.\n\nI understand the need for pvm_vnic, but do we actually need pvm_vf?  Can\u0027t we override \u0027direct\u0027 for that guy?","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f1c37c6b91085a979cf299c711add8db6fd4baf2","unresolved":false,"context_lines":[{"line_number":107,"context_line":"including vNIC)/pvc_vf (VF directly connected to VM). Plug and unplug mechanisms"},{"line_number":108,"context_line":"will be different and specialized for PowerVM using pypowervm library."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Deployment of VM with SR-IOV VF will involve picking PF, VIOS and"},{"line_number":111,"context_line":"invoking pypowervm library. Similarly, attachment of the same to an existing VM"},{"line_number":112,"context_line":"will be implemented. Evacuate and migration of VM will be supported with"},{"line_number":113,"context_line":"changes to compute virt driver and VIF driver via pypowervm library."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_71dba71b","line":110,"range":{"start_line":110,"start_character":53,"end_line":110,"end_character":55},"updated":"2016-06-08 14:42:55.000000000","message":"Physical ports (see above).","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f1c37c6b91085a979cf299c711add8db6fd4baf2","unresolved":false,"context_lines":[{"line_number":108,"context_line":"will be different and specialized for PowerVM using pypowervm library."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Deployment of VM with SR-IOV VF will involve picking PF, VIOS and"},{"line_number":111,"context_line":"invoking pypowervm library. Similarly, attachment of the same to an existing VM"},{"line_number":112,"context_line":"will be implemented. Evacuate and migration of VM will be supported with"},{"line_number":113,"context_line":"changes to compute virt driver and VIF driver via pypowervm library."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"vNIC redundancy/failover across VFs within or across PFs or SR-IOV adapters"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_2c170449","line":112,"range":{"start_line":111,"start_character":28,"end_line":112,"end_character":19},"updated":"2016-06-08 14:42:55.000000000","message":"As I understand it, this all happens in one step.  So you\u0027re picking physical port(s) (one or more), VIOS(es) (one or more) and a VM.\n\n(If that\u0027s so, \u0027plug\u0027 will operate more like a \u0027create and plug\u0027 operation; \u0027unplug\u0027 more like \u0027unplug and destroy\u0027.)","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f1c37c6b91085a979cf299c711add8db6fd4baf2","unresolved":false,"context_lines":[{"line_number":112,"context_line":"will be implemented. Evacuate and migration of VM will be supported with"},{"line_number":113,"context_line":"changes to compute virt driver and VIF driver via pypowervm library."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"vNIC redundancy/failover across VFs within or across PFs or SR-IOV adapters"},{"line_number":116,"context_line":"will be an option in both deploy and attach scenarios. pypowervm library will"},{"line_number":117,"context_line":"be utilized to setup such a redundancy/failover configuration."},{"line_number":118,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_a7e02dce","line":115,"range":{"start_line":115,"start_character":5,"end_line":115,"end_character":24},"updated":"2016-06-08 14:42:55.000000000","message":"Seems like the redundancy discussion deserves more content.  We have the following models:\n\n- With direct attach VF, the consumer has to plug \u003e1 VIF to the VM, and the VM is responsible for handling failover (e.g. via NIB).\n- With vNIC, it is possible to specify more than one physical port and/or VIOS, whereupon failover is handled by the platform (VM sees a single interface).  The infrastructure/design for this model should be discussed somewhere - that is, how do you specify the physical port(s) and VIOS(es)?","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"4824770031b7f9667315022f116b245b2c81d061","unresolved":false,"context_lines":[{"line_number":112,"context_line":"will be implemented. Evacuate and migration of VM will be supported with"},{"line_number":113,"context_line":"changes to compute virt driver and VIF driver via pypowervm library."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"vNIC redundancy/failover across VFs within or across PFs or SR-IOV adapters"},{"line_number":116,"context_line":"will be an option in both deploy and attach scenarios. pypowervm library will"},{"line_number":117,"context_line":"be utilized to setup such a redundancy/failover configuration."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Alternatives"},{"line_number":120,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_40e3d0a3","line":117,"range":{"start_line":115,"start_character":0,"end_line":117,"end_character":62},"updated":"2016-06-06 12:53:45.000000000","message":"In discussions, we had discussed a need for two distinct vif drivers.  Depending on the nova.conf you have a default type, but then the glance image metadata can override which VIF type you use (vnic or VF direct).\n\nThis would be in line with the KVM support for say e1000 vs. virtio.\n\nI\u0027d like to see changes around each distinct VIF driver, and then how to decide which VIF driver to use.\n\nAlso, how do you plan to saturate the data model in nova for the pci-specs?","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"4824770031b7f9667315022f116b245b2c81d061","unresolved":false,"context_lines":[{"line_number":171,"context_line":"Updating of vNICs"},{"line_number":172,"context_line":"Creation of failover vNIC"},{"line_number":173,"context_line":"Management of failover vNICs (list, remove, update)"},{"line_number":174,"context_line":"migration with vNIC"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"2. nova-powervm changes"},{"line_number":177,"context_line":"Updates to PowerVM compute driver to support attachment of SR-IOV VF either"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_c0a4e058","line":174,"updated":"2016-06-06 12:53:45.000000000","message":"What about updating the pci specs?\nYou flip between vNIC and VF a lot.  Seems you should say both.\n\nWhy are pypowervm changes listed in the nova-powervm blueprint?  This is not relevant IMO","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"4824770031b7f9667315022f116b245b2c81d061","unresolved":false,"context_lines":[{"line_number":178,"context_line":"directly or via vNIC."},{"line_number":179,"context_line":"VIF driver for SR-IOV VF connected to VM directly"},{"line_number":180,"context_line":"VIF driver for SR-IOV VF connected to VM via vNIC"},{"line_number":181,"context_line":"migration of VM with SR-IOV VF connected to VM via vNIC"},{"line_number":182,"context_line":"failover/redundancy support for SR-IOV VF(s) connected to VM via vNIC(s)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_007548ca","line":181,"updated":"2016-06-06 12:53:45.000000000","message":"Capitalize\n\nIs it live migration/cold migration/both?","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"4824770031b7f9667315022f116b245b2c81d061","unresolved":false,"context_lines":[{"line_number":187,"context_line":"All developed code will accompany structured unit test around them. These"},{"line_number":188,"context_line":"tests validate granular function logic."},{"line_number":189,"context_line":"2. Function test"},{"line_number":190,"context_line":"Function test will be performed along with CI infrastructure.  Changes"},{"line_number":191,"context_line":"implemented for this blueprint will be tested via CI framework that exists"},{"line_number":192,"context_line":"and used by IBM team. CI framework needs to be enhanced with SR-IOV hardware."},{"line_number":193,"context_line":"The tests can be executed in batch mode, probably as nightly jobs."},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"Documentation impact"},{"line_number":196,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_c0406059","line":193,"range":{"start_line":190,"start_character":0,"end_line":193,"end_character":66},"updated":"2016-06-06 12:53:45.000000000","message":"Will you be providing the HW for the CI infrastructure?  I don\u0027t think our CI has sr-iov cards yet.\n\nWe can discuss in IRC.","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"4824770031b7f9667315022f116b245b2c81d061","unresolved":false,"context_lines":[{"line_number":230,"context_line":"Glossary"},{"line_number":231,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"1.SR-IOV - Single Root I/O Virtualization, used for virtual environments where"},{"line_number":234,"context_line":"VMs need direct access to network interface without any hypervisor overheads."},{"line_number":235,"context_line":"2.PF - Represents Physical port in SR-IOV adapter."},{"line_number":236,"context_line":"3.VF - Represents Virtual port belonging to a specific PF. Either directly or"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_8304a215","line":233,"updated":"2016-06-06 12:53:45.000000000","message":"space","commit_id":"12dc8eaa8a27d2028d01b53b5f981d213b77b242"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5e0c821086ac3a436477e7ec71605e66937e6eb3","unresolved":false,"context_lines":[{"line_number":42,"context_line":"and not with direct VF attached scenario. Migration support for SR-IOV is not"},{"line_number":43,"context_line":"supported currently, but there are efforts to support it for KVM using macvtap."},{"line_number":44,"context_line":"There is a blueprint in progress in Newton:"},{"line_number":45,"context_line":"https://blueprints.launchpad.net/ nova/+spec/sriov-live-migration"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"PowerVM\u0027s SR-IOV implementation should include"},{"line_number":48,"context_line":"support for redundancy/failover across two SR-IOV VFs at the VIOS level."}],"source_content_type":"text/x-rst","patch_set":3,"id":"7aa08908_013915a4","line":45,"range":{"start_line":45,"start_character":33,"end_line":45,"end_character":34},"updated":"2016-06-15 21:44:16.000000000","message":"Remove space.  And make this a real link.","commit_id":"048fab0a77af80c8b5c7a4b2acdab2ff409e3e7d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5e0c821086ac3a436477e7ec71605e66937e6eb3","unresolved":false,"context_lines":[{"line_number":44,"context_line":"There is a blueprint in progress in Newton:"},{"line_number":45,"context_line":"https://blueprints.launchpad.net/ nova/+spec/sriov-live-migration"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"PowerVM\u0027s SR-IOV implementation should include"},{"line_number":48,"context_line":"support for redundancy/failover across two SR-IOV VFs at the VIOS level."},{"line_number":49,"context_line":"This blueprint will be built to support the live migration work being done in"},{"line_number":50,"context_line":"core nova for SR-IOV, however if that does not land in Newton then the work"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7aa08908_413f9d86","line":47,"updated":"2016-06-15 21:44:16.000000000","message":"alignment","commit_id":"048fab0a77af80c8b5c7a4b2acdab2ff409e3e7d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5e0c821086ac3a436477e7ec71605e66937e6eb3","unresolved":false,"context_lines":[{"line_number":45,"context_line":"https://blueprints.launchpad.net/ nova/+spec/sriov-live-migration"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"PowerVM\u0027s SR-IOV implementation should include"},{"line_number":48,"context_line":"support for redundancy/failover across two SR-IOV VFs at the VIOS level."},{"line_number":49,"context_line":"This blueprint will be built to support the live migration work being done in"},{"line_number":50,"context_line":"core nova for SR-IOV, however if that does not land in Newton then the work"},{"line_number":51,"context_line":"here will still continue without live migration support until Ocata."}],"source_content_type":"text/x-rst","patch_set":3,"id":"7aa08908_2142510f","line":48,"updated":"2016-06-15 21:44:16.000000000","message":"or more","commit_id":"048fab0a77af80c8b5c7a4b2acdab2ff409e3e7d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5e0c821086ac3a436477e7ec71605e66937e6eb3","unresolved":false,"context_lines":[{"line_number":90,"context_line":"5. Live migrate a VM if using vNIC backed SR-IOV support"},{"line_number":91,"context_line":"6. Provide redundancy/failover support of vNIC backed by SR-IOV VF attached to"},{"line_number":92,"context_line":"a VM during both deploy and post deploy scenarios."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Proposed changes"},{"line_number":95,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":96,"context_line":"The changes will be made in two areas:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7aa08908_c118ad20","line":93,"updated":"2016-06-15 21:44:16.000000000","message":"Missing the direct-attach use cases.","commit_id":"048fab0a77af80c8b5c7a4b2acdab2ff409e3e7d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5e0c821086ac3a436477e7ec71605e66937e6eb3","unresolved":false,"context_lines":[{"line_number":96,"context_line":"The changes will be made in two areas:"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"1. Compute virt driver."},{"line_number":99,"context_line":"PowerVM compute driver is in nova_powervm.virt.powervm.driver.PowerVMDriver"},{"line_number":100,"context_line":"and it will be enhanced for SR-IOV VF support. pypowervm enhancements for vNIC"},{"line_number":101,"context_line":"will be required. pypowervm is a python library that runs on the NovaLink"},{"line_number":102,"context_line":"management VM and allows virtualization control of the system. This is similar"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7aa08908_41b2fd06","line":99,"range":{"start_line":99,"start_character":29,"end_line":99,"end_character":75},"updated":"2016-06-15 21:44:16.000000000","message":"Same comment as PS2: it might be better to use the nova.virt.powervm namespace.","commit_id":"048fab0a77af80c8b5c7a4b2acdab2ff409e3e7d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5e0c821086ac3a436477e7ec71605e66937e6eb3","unresolved":false,"context_lines":[{"line_number":107,"context_line":"PowerVM VIF driver is in nova_powervm.virt.powervm.vif.PvmVifDriver. Two new"},{"line_number":108,"context_line":"VIF drivers will be developed. One for direct VF to VM attach"},{"line_number":109,"context_line":"(PvmVFSriovVifDriver) and another via vNIC (PvmVnicSriovVifDriver) and plug/"},{"line_number":110,"context_line":"unplug methods will be implemented with pypowervm library. Plug and unplug"},{"line_number":111,"context_line":"methods will use pypowervm code to create VF/vNIC server/vNIC clients and"},{"line_number":112,"context_line":"attach/detach them. The vif types will be pvm_vnic (configuration including"},{"line_number":113,"context_line":"vNIC) or pvm_vf (VF directly connected to VM). The vnic_type for both"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7aa08908_61cbb972","line":110,"range":{"start_line":110,"start_character":35,"end_line":110,"end_character":57},"updated":"2016-06-15 21:44:16.000000000","message":"Makes it sound like the plug/unplug impls will live in pypowervm, which they won\u0027t.  You can remove \"with pypowervm library\" - the intent is covered in the next sentence.","commit_id":"048fab0a77af80c8b5c7a4b2acdab2ff409e3e7d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5e0c821086ac3a436477e7ec71605e66937e6eb3","unresolved":false,"context_lines":[{"line_number":110,"context_line":"unplug methods will be implemented with pypowervm library. Plug and unplug"},{"line_number":111,"context_line":"methods will use pypowervm code to create VF/vNIC server/vNIC clients and"},{"line_number":112,"context_line":"attach/detach them. The vif types will be pvm_vnic (configuration including"},{"line_number":113,"context_line":"vNIC) or pvm_vf (VF directly connected to VM). The vnic_type for both"},{"line_number":114,"context_line":"cases will be \u0027direct\u0027. Plug and unplug mechanisms will be different and"},{"line_number":115,"context_line":"specialized for PowerVM using pypowervm library. "},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Deployment of VM with SR-IOV VF will involve picking Physical Port(s),"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7aa08908_41fcbd71","line":114,"range":{"start_line":113,"start_character":47,"end_line":114,"end_character":22},"updated":"2016-06-15 21:44:16.000000000","message":"Okay, I don\u0027t understand how this works.  Where/how would I specify \"direct\" plus {\"pvm_vf\"|\"pvm_vnic\"} ?","commit_id":"048fab0a77af80c8b5c7a4b2acdab2ff409e3e7d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5e0c821086ac3a436477e7ec71605e66937e6eb3","unresolved":false,"context_lines":[{"line_number":120,"context_line":"VM will be supported with changes to compute virt driver and VIF driver via"},{"line_number":121,"context_line":"pypowervm library. As described above, two distinct vif drivers will be used"},{"line_number":122,"context_line":"depending on how VF is attached to VM. Depending on nova.conf, default type"},{"line_number":123,"context_line":"will be used, but then the glance image metadata can override with VIF type"},{"line_number":124,"context_line":"you use (pvm_vnic or direct)."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"For vNIC path, vNIC redundancy/failover across VFs within or across Physical"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7aa08908_21d251d1","line":123,"range":{"start_line":123,"start_character":27,"end_line":123,"end_character":48},"updated":"2016-06-15 21:44:16.000000000","message":"Eh?  What does glance image metadata have to do with anything?","commit_id":"048fab0a77af80c8b5c7a4b2acdab2ff409e3e7d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5e0c821086ac3a436477e7ec71605e66937e6eb3","unresolved":false,"context_lines":[{"line_number":121,"context_line":"pypowervm library. As described above, two distinct vif drivers will be used"},{"line_number":122,"context_line":"depending on how VF is attached to VM. Depending on nova.conf, default type"},{"line_number":123,"context_line":"will be used, but then the glance image metadata can override with VIF type"},{"line_number":124,"context_line":"you use (pvm_vnic or direct)."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"For vNIC path, vNIC redundancy/failover across VFs within or across Physical"},{"line_number":127,"context_line":"Ports or SR-IOV adapters will be an option in both deploy and attach scenario."}],"source_content_type":"text/x-rst","patch_set":3,"id":"7aa08908_0133d514","line":124,"range":{"start_line":124,"start_character":8,"end_line":124,"end_character":28},"updated":"2016-06-15 21:44:16.000000000","message":"This seems to contradict the above.  Need clarity on where/how I specify which driver to use.","commit_id":"048fab0a77af80c8b5c7a4b2acdab2ff409e3e7d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5e0c821086ac3a436477e7ec71605e66937e6eb3","unresolved":false,"context_lines":[{"line_number":128,"context_line":"pypowervm library will be utilized to setup such a redundancy/failover"},{"line_number":129,"context_line":"configuration. For VF - VM attach path, redundancy will still be achievable"},{"line_number":130,"context_line":"with NIB at VM level. With two VFs directly attached to a VM, a NIB can be"},{"line_number":131,"context_line":"setup across them inside VM. To the operating system on VM, both VFs will"},{"line_number":132,"context_line":"appear to be one network interface."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Regarding data-model changes for failover/redundancy, redundancy information"},{"line_number":135,"context_line":"will be stored in compute system metadata. When a VM deploy is attempted with"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7aa08908_446ccbcf","line":132,"range":{"start_line":131,"start_character":29,"end_line":132,"end_character":35},"updated":"2016-06-15 21:44:16.000000000","message":"Pretty sure this is wrong.  For direct attach, each VF will appear as a separate interface to the operating system.  That\u0027s why NIB is needed to aggregate them into one.\n\nWe shouldn\u0027t go into any detail on how NIB works.  We should say it\u0027s up to the consumer, not handled by nova-powervm in any way.","commit_id":"048fab0a77af80c8b5c7a4b2acdab2ff409e3e7d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5e0c821086ac3a436477e7ec71605e66937e6eb3","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Regarding data-model changes for failover/redundancy, redundancy information"},{"line_number":135,"context_line":"will be stored in compute system metadata. When a VM deploy is attempted with"},{"line_number":136,"context_line":"redundant support, system metadata record will be inserted with"},{"line_number":137,"context_line":"\u0027port_redundancy_\u003cneutron-port-id\u003e\u0027 as key and a comma separated value"},{"line_number":138,"context_line":"containing a list of adapter physical ports. Each entry will be"},{"line_number":139,"context_line":"\u0027\u003cadapter-id\u003e-\u003cphysical-port\u003e\u0027. VIF plug during deploy (or attach of"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7aa08908_1a0a1e20","line":136,"range":{"start_line":136,"start_character":19,"end_line":136,"end_character":34},"updated":"2016-06-15 21:44:16.000000000","message":"System metadata?  Noooo.\n\nI don\u0027t fully understand what we\u0027re gaining by storing this information.  What is there that we can\u0027t glean on the fly?","commit_id":"048fab0a77af80c8b5c7a4b2acdab2ff409e3e7d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5e0c821086ac3a436477e7ec71605e66937e6eb3","unresolved":false,"context_lines":[{"line_number":142,"context_line":"metadata, it will be assumed that redundancy is not needed. There will be one"},{"line_number":143,"context_line":"neutron port created for redundancy. This section is not applicable to VF -"},{"line_number":144,"context_line":"VM direct attach path. Refer to \u0027Proposed Changes\u0027 section on how to implement"},{"line_number":145,"context_line":"redundancy for VF-VM path, but it is outside the scope of this blueprint."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"SR-IOV implementation in OpenStack nova involves usage of pci-whitelist. This"},{"line_number":148,"context_line":"is a construct specified in nova configuration file to specify characteristics"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7aa08908_430c933b","line":145,"updated":"2016-06-15 21:44:16.000000000","message":"Per discussions, redundancy tailoring should be controlled by a combination of the number of phys ports in the whitelist entry (say \"NPP\"), and a new conf option indicating desired redundancy level (say \"DRL\").  If unspecified, DRL defaults to NPP (use all available pports for each vNIC); if specified, must be 1 \u003c\u003d DRL \u003c\u003d NPP.\n\nBecause this is a conf option, this setting applies to all VMs created during a given compute invocation.","commit_id":"048fab0a77af80c8b5c7a4b2acdab2ff409e3e7d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5e0c821086ac3a436477e7ec71605e66937e6eb3","unresolved":false,"context_lines":[{"line_number":144,"context_line":"VM direct attach path. Refer to \u0027Proposed Changes\u0027 section on how to implement"},{"line_number":145,"context_line":"redundancy for VF-VM path, but it is outside the scope of this blueprint."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"SR-IOV implementation in OpenStack nova involves usage of pci-whitelist. This"},{"line_number":148,"context_line":"is a construct specified in nova configuration file to specify characteristics"},{"line_number":149,"context_line":"of SR-IOV card like device name, address of physical ports and physical"},{"line_number":150,"context_line":"network etc. For SR-IOV implementation for PowerVM, pci-whitelist will be used"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7aa08908_68b358ea","line":147,"range":{"start_line":147,"start_character":58,"end_line":147,"end_character":71},"updated":"2016-06-15 21:44:16.000000000","message":"pci_passthrough_whitelist\n\nA reference wouldn\u0027t go amiss.","commit_id":"048fab0a77af80c8b5c7a4b2acdab2ff409e3e7d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5e0c821086ac3a436477e7ec71605e66937e6eb3","unresolved":false,"context_lines":[{"line_number":150,"context_line":"network etc. For SR-IOV implementation for PowerVM, pci-whitelist will be used"},{"line_number":151,"context_line":"to describe physical port data in a specific format. This configuration needs"},{"line_number":152,"context_line":"to be updated either manually or via any automated way (ansible). This is"},{"line_number":153,"context_line":"required for both VF to VM direct and vNIC paths. The following are the"},{"line_number":154,"context_line":"elements of a pci-whitelist entry:"},{"line_number":155,"context_line":"physical-network - specify name of the physical network."},{"line_number":156,"context_line":"devname - will represent a physical port. It can be either location code or a"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7aa08908_4802dc73","line":153,"updated":"2016-06-15 21:44:16.000000000","message":"Yeah, everything from here down has changed.","commit_id":"048fab0a77af80c8b5c7a4b2acdab2ff409e3e7d"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"cead3b5e0c931e44d571ec151dd4705b1d2d56e0","unresolved":false,"context_lines":[{"line_number":51,"context_line":"live migration support until Ocata."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"While it is possible to attach entire physical port of SR-IOV card directly to"},{"line_number":54,"context_line":"VM, this scenario will not be supported at this time due to reasons like VM"},{"line_number":55,"context_line":"migration with such an interface will not be possible. This path also does not"},{"line_number":56,"context_line":"utilize advantages of hardware level virtualization offered by SR-IOV"},{"line_number":57,"context_line":"architecture. A future blueprint will handle this scenario in a different way"},{"line_number":58,"context_line":"as it is more useful to start with VF(s) attached to VMs."}],"source_content_type":"text/x-rst","patch_set":4,"id":"7aa08908_a13cd2e1","line":55,"range":{"start_line":54,"start_character":60,"end_line":55,"end_character":54},"updated":"2016-06-17 16:33:01.000000000","message":"While this reason holds for the direct VF attach.  I\u0027d assert that its not being supported (yet) because it doesn\u0027t have as much demand for cloud workloads on PowerVM at the moment.","commit_id":"66679946e1ef51e172073c7c9724bdb3ba972c87"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"cead3b5e0c931e44d571ec151dd4705b1d2d56e0","unresolved":false,"context_lines":[{"line_number":54,"context_line":"VM, this scenario will not be supported at this time due to reasons like VM"},{"line_number":55,"context_line":"migration with such an interface will not be possible. This path also does not"},{"line_number":56,"context_line":"utilize advantages of hardware level virtualization offered by SR-IOV"},{"line_number":57,"context_line":"architecture. A future blueprint will handle this scenario in a different way"},{"line_number":58,"context_line":"as it is more useful to start with VF(s) attached to VMs."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Based on PowerVM firmware design, a VF(s) needs to be associated with a vNIC"},{"line_number":61,"context_line":"server on VIOS and it is subsequently associated with vNIC client interface on"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7aa08908_2129029c","line":58,"range":{"start_line":57,"start_character":14,"end_line":58,"end_character":57},"updated":"2016-06-17 16:33:01.000000000","message":"Like you said here.","commit_id":"66679946e1ef51e172073c7c9724bdb3ba972c87"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"cead3b5e0c931e44d571ec151dd4705b1d2d56e0","unresolved":false,"context_lines":[{"line_number":57,"context_line":"architecture. A future blueprint will handle this scenario in a different way"},{"line_number":58,"context_line":"as it is more useful to start with VF(s) attached to VMs."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Based on PowerVM firmware design, a VF(s) needs to be associated with a vNIC"},{"line_number":61,"context_line":"server on VIOS and it is subsequently associated with vNIC client interface on"},{"line_number":62,"context_line":"a VM. This intermediary vNIC is a mandatory requirement to support migration"},{"line_number":63,"context_line":"of such a VM from host to host. This intermediary is also needed to support"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7aa08908_41036e10","line":60,"range":{"start_line":60,"start_character":42,"end_line":60,"end_character":47},"updated":"2016-06-17 16:33:01.000000000","message":"can be...","commit_id":"66679946e1ef51e172073c7c9724bdb3ba972c87"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"cead3b5e0c931e44d571ec151dd4705b1d2d56e0","unresolved":false,"context_lines":[{"line_number":61,"context_line":"server on VIOS and it is subsequently associated with vNIC client interface on"},{"line_number":62,"context_line":"a VM. This intermediary vNIC is a mandatory requirement to support migration"},{"line_number":63,"context_line":"of such a VM from host to host. This intermediary is also needed to support"},{"line_number":64,"context_line":"redundancy/failover across VFs. For setting up redundancy, a n-number of SR-IOV"},{"line_number":65,"context_line":"Physical Ports have to be provided to pypowervm layer and VFs and vNIC servers"},{"line_number":66,"context_line":"will be carved out of them and connected to vNIC client adapter on VM. All VFs"},{"line_number":67,"context_line":"attached to a vNIC will carry same mac address."}],"source_content_type":"text/x-rst","patch_set":4,"id":"7aa08908_b3ff0900","line":64,"range":{"start_line":64,"start_character":59,"end_line":64,"end_character":60},"updated":"2016-06-17 16:33:01.000000000","message":"strike this","commit_id":"66679946e1ef51e172073c7c9724bdb3ba972c87"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"cead3b5e0c931e44d571ec151dd4705b1d2d56e0","unresolved":false,"context_lines":[{"line_number":64,"context_line":"redundancy/failover across VFs. For setting up redundancy, a n-number of SR-IOV"},{"line_number":65,"context_line":"Physical Ports have to be provided to pypowervm layer and VFs and vNIC servers"},{"line_number":66,"context_line":"will be carved out of them and connected to vNIC client adapter on VM. All VFs"},{"line_number":67,"context_line":"attached to a vNIC will carry same mac address."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"In summary, this blueprint will solve support of SR-IOV in nova-powervm for"},{"line_number":70,"context_line":"these scenarios:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7aa08908_932bed81","line":67,"updated":"2016-06-17 16:33:01.000000000","message":"and as such will be represented by one Neutron port?","commit_id":"66679946e1ef51e172073c7c9724bdb3ba972c87"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"cead3b5e0c931e44d571ec151dd4705b1d2d56e0","unresolved":false,"context_lines":[{"line_number":74,"context_line":"directly without migration support."},{"line_number":75,"context_line":"3. Ability to provide redundancy/failover support across VFs from Physical"},{"line_number":76,"context_line":"Ports within or across SR-IOV cards using vNIC intermediary."},{"line_number":77,"context_line":"4. Ability to associate a VLAN with vNIC backed by SR-IOV VF"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Refer to separate blueprint for networking-powervm for changes in PowerVM"},{"line_number":80,"context_line":"neutron networking component. This blueprint will focus on changes to"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7aa08908_333b19d3","line":77,"range":{"start_line":77,"start_character":27,"end_line":77,"end_character":31},"updated":"2016-06-17 16:33:01.000000000","message":"would we support \u0027flat\u0027 networks as well?","commit_id":"66679946e1ef51e172073c7c9724bdb3ba972c87"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"cead3b5e0c931e44d571ec151dd4705b1d2d56e0","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Proposed changes"},{"line_number":96,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":97,"context_line":"The changes will be made in two areas:"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"1. Compute virt driver."},{"line_number":100,"context_line":"PowerVM compute driver is in nova.virt.powervm.driver.PowerVMDriver"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7aa08908_9352cd11","line":97,"range":{"start_line":97,"start_character":0,"end_line":97,"end_character":38},"updated":"2016-06-17 16:33:01.000000000","message":"I think there are white list changes?  Or more, a specific interpretation of it?","commit_id":"66679946e1ef51e172073c7c9724bdb3ba972c87"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"cead3b5e0c931e44d571ec151dd4705b1d2d56e0","unresolved":false,"context_lines":[{"line_number":120,"context_line":"VM will be supported with changes to compute virt driver and VIF driver via"},{"line_number":121,"context_line":"pypowervm library. As described above, two distinct vif drivers will be used"},{"line_number":122,"context_line":"depending on how VF is attached to VM. Depending on nova.conf, default type"},{"line_number":123,"context_line":"will be used, but then the glance image metadata can override with VIF type"},{"line_number":124,"context_line":"you use (pvm_vf or pvm_vnic)."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"For vNIC path, vNIC redundancy/failover across VFs within or across Physical"},{"line_number":127,"context_line":"Ports or SR-IOV adapters will be an option in both deploy and attach scenario."}],"source_content_type":"text/x-rst","patch_set":4,"id":"7aa08908_f36a31b4","line":124,"range":{"start_line":123,"start_character":14,"end_line":124,"end_character":29},"updated":"2016-06-17 16:33:01.000000000","message":"I don\u0027t think this has been netted yet.  Lets just say for now it\u0027ll be limited by the nova.conf.","commit_id":"66679946e1ef51e172073c7c9724bdb3ba972c87"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"cead3b5e0c931e44d571ec151dd4705b1d2d56e0","unresolved":false,"context_lines":[{"line_number":130,"context_line":"with NIB at VM level. With two VFs directly attached to a VM, a NIB can be"},{"line_number":131,"context_line":"setup across them inside VM."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Regarding data-model changes for failover/redundancy, redundancy information"},{"line_number":134,"context_line":"will be stored in compute system metadata. When a VM deploy is attempted with"},{"line_number":135,"context_line":"redundant support, system metadata record will be inserted with"},{"line_number":136,"context_line":"\u0027port_redundancy_\u003cneutron-port-id\u003e\u0027 as key and a comma separated value"},{"line_number":137,"context_line":"containing a list of adapter physical ports. Each entry will be"},{"line_number":138,"context_line":"\u0027\u003cadapter-id\u003e-\u003cphysical-port\u003e\u0027. VIF plug during deploy (or attach of"},{"line_number":139,"context_line":"network interface to a VM) will pass this information to pypowervm library to"},{"line_number":140,"context_line":"create vNIC on VIOS with redundancy. If no such entry is present in system"},{"line_number":141,"context_line":"metadata, it will be assumed that redundancy is not needed. There will be one"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7aa08908_13941d89","line":138,"range":{"start_line":133,"start_character":0,"end_line":138,"end_character":32},"updated":"2016-06-17 16:33:01.000000000","message":"Why does this need to be stored?  Why can\u0027t it be looked up via the API?  I hate storing stuff in metadata unless we absolutely need it.","commit_id":"66679946e1ef51e172073c7c9724bdb3ba972c87"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"cead3b5e0c931e44d571ec151dd4705b1d2d56e0","unresolved":false,"context_lines":[{"line_number":159,"context_line":"This data specified in nova configuration file will describe the mapping"},{"line_number":160,"context_line":"between physical networks to SR-IOV physical ports.(need more clarifications)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"SR-IOV physical ports carry an attribute called \u0027label. A specific label value"},{"line_number":163,"context_line":"can preconfigured to represent multiple physical ports. There can be one"},{"line_number":164,"context_line":"pci-whitelist entry in nova configuration file per label instead of per"},{"line_number":165,"context_line":"physical port. There can be one label per physical network or multiple labels"},{"line_number":166,"context_line":"on the same physical network in the configuration.(do we need this paragraph?)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"For VM - VM direct attach of SR-IOV port to a VM, the request will include"},{"line_number":169,"context_line":"physical network name. PvmVFSriovVifDriver can lookup devname(s) associated"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7aa08908_9363edb0","line":166,"range":{"start_line":162,"start_character":0,"end_line":166,"end_character":78},"updated":"2016-06-17 16:33:01.000000000","message":"I defer to efried on this bit.","commit_id":"66679946e1ef51e172073c7c9724bdb3ba972c87"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"cead3b5e0c931e44d571ec151dd4705b1d2d56e0","unresolved":false,"context_lines":[{"line_number":234,"context_line":"VIF driver for SR-IOV VF connected to VM via vNIC"},{"line_number":235,"context_line":"Migration of VM with SR-IOV VF connected to VM via vNIC. This involves"},{"line_number":236,"context_line":"live migration, cold migration and evacuation."},{"line_number":237,"context_line":"Failover/redundancy support for SR-IOV VF(s) connected to VM via vNIC(s)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"Testing"},{"line_number":240,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7aa08908_13f7fdd3","line":237,"range":{"start_line":237,"start_character":0,"end_line":237,"end_character":72},"updated":"2016-06-17 16:33:01.000000000","message":"Testing indicates that you\u0027ll be updating the PowerVC CI infrastructure.  I\u0027d expect a work item for that.","commit_id":"66679946e1ef51e172073c7c9724bdb3ba972c87"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4145848e964e6efa08dc11555d7ee57fab5ffd03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3aaa91ec_bde8d27d","updated":"2016-06-22 13:43:10.000000000","message":"We need to refocus this blueprint to make it clear that it\u0027s about vNIC only.  We should discuss direct-VF, but only to the extent that we are designing with its *future* implementation in mind - it will not be implemented in Newton.\nAnd let\u0027s do that with an eye toward reducing the total number of words.  The blueprint will be more consumable if it is terse and to the point.","commit_id":"4c43b385fff6010b7d28fb0e226655496341367c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4145848e964e6efa08dc11555d7ee57fab5ffd03","unresolved":false,"context_lines":[{"line_number":172,"context_line":"can preconfigured to represent multiple physical ports. There can be one"},{"line_number":173,"context_line":"pci-whitelist entry in nova configuration file per label instead of per"},{"line_number":174,"context_line":"physical port. There can be one label per physical network or multiple labels"},{"line_number":175,"context_line":"on the same physical network in the configuration.(do we need this paragraph?)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"For VM - VM direct attach of SR-IOV port to a VM, the request will include"},{"line_number":178,"context_line":"physical network name. PvmVFSriovVifDriver can lookup devname(s) associated"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3aaa91ec_9d7236e4","line":175,"range":{"start_line":175,"start_character":50,"end_line":175,"end_character":78},"updated":"2016-06-22 13:43:10.000000000","message":"No, we decided not to use labels.","commit_id":"4c43b385fff6010b7d28fb0e226655496341367c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26913041a68d06d262009e0b697ee67231967342","unresolved":false,"context_lines":[{"line_number":42,"context_line":"architecture. This scenario does not have as much demand for cloud workloads"},{"line_number":43,"context_line":"on PowerVM at this moment."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Users should be able to manage a VM with SR-IOV VF as a network interface."},{"line_number":46,"context_line":"This management should include migration of VM with SR-IOV VF network interface"},{"line_number":47,"context_line":"attached to it.  Migration support for SR-IOV is not supported currently, but"},{"line_number":48,"context_line":"there are efforts to support it for KVM using macvtap. There is a blueprint in"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_77663052","line":45,"range":{"start_line":45,"start_character":48,"end_line":45,"end_character":50},"updated":"2016-06-29 18:43:34.000000000","message":"vNIC","commit_id":"6ab75904623f4400b81e4f248355b1f5fa64e9bd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26913041a68d06d262009e0b697ee67231967342","unresolved":false,"context_lines":[{"line_number":43,"context_line":"on PowerVM at this moment."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Users should be able to manage a VM with SR-IOV VF as a network interface."},{"line_number":46,"context_line":"This management should include migration of VM with SR-IOV VF network interface"},{"line_number":47,"context_line":"attached to it.  Migration support for SR-IOV is not supported currently, but"},{"line_number":48,"context_line":"there are efforts to support it for KVM using macvtap. There is a blueprint in"},{"line_number":49,"context_line":"progress in Newton:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_574cd4c7","line":46,"range":{"start_line":46,"start_character":59,"end_line":46,"end_character":79},"updated":"2016-06-29 18:43:34.000000000","message":"vNIC","commit_id":"6ab75904623f4400b81e4f248355b1f5fa64e9bd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26913041a68d06d262009e0b697ee67231967342","unresolved":false,"context_lines":[{"line_number":84,"context_line":"2. Attach vNIC backed by SR-IOV VF(s) to a VM after it is deployed"},{"line_number":85,"context_line":"3. Detach vNIC backed by SR-IOV VF(s) from a VM"},{"line_number":86,"context_line":"4. When a VM with vNIC backed by SR-IOV is deleted, perform detach and cleanup"},{"line_number":87,"context_line":"5. Live migrate a VM if using vNIC backed SR-IOV support"},{"line_number":88,"context_line":"6. Provide redundancy/failover support of vNIC backed by SR-IOV VF attached to"},{"line_number":89,"context_line":"a VM during both deploy and post deploy scenarios."},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_d76a84ec","line":87,"updated":"2016-06-29 18:43:34.000000000","message":"...assuming core support is in place in Newton","commit_id":"6ab75904623f4400b81e4f248355b1f5fa64e9bd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26913041a68d06d262009e0b697ee67231967342","unresolved":false,"context_lines":[{"line_number":88,"context_line":"6. Provide redundancy/failover support of vNIC backed by SR-IOV VF attached to"},{"line_number":89,"context_line":"a VM during both deploy and post deploy scenarios."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Attach SR-IOV VF to a VM directly will be a future implemented use-case."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Proposed changes"},{"line_number":94,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_f75ce04c","line":91,"updated":"2016-06-29 18:43:34.000000000","message":"Is it necessary to repeat this here?","commit_id":"6ab75904623f4400b81e4f248355b1f5fa64e9bd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26913041a68d06d262009e0b697ee67231967342","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"1. Compute virt driver."},{"line_number":98,"context_line":"PowerVM compute driver is in nova.virt.powervm.driver.PowerVMDriver"},{"line_number":99,"context_line":"and it will be enhanced for SR-IOV VF support. pypowervm enhancements for vNIC"},{"line_number":100,"context_line":"will be required. pypowervm is a python library that runs on the NovaLink"},{"line_number":101,"context_line":"management VM and allows virtualization control of the system. This is similar"},{"line_number":102,"context_line":"to the python library for libvirt. pypowervm will offer functions to manage"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_6205d00f","line":99,"updated":"2016-06-29 18:43:34.000000000","message":"Do we need to get any more specific here?","commit_id":"6ab75904623f4400b81e4f248355b1f5fa64e9bd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26913041a68d06d262009e0b697ee67231967342","unresolved":false,"context_lines":[{"line_number":97,"context_line":"1. Compute virt driver."},{"line_number":98,"context_line":"PowerVM compute driver is in nova.virt.powervm.driver.PowerVMDriver"},{"line_number":99,"context_line":"and it will be enhanced for SR-IOV VF support. pypowervm enhancements for vNIC"},{"line_number":100,"context_line":"will be required. pypowervm is a python library that runs on the NovaLink"},{"line_number":101,"context_line":"management VM and allows virtualization control of the system. This is similar"},{"line_number":102,"context_line":"to the python library for libvirt. pypowervm will offer functions to manage"},{"line_number":103,"context_line":"SR-IOV adapters and ports and vNIC."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"2. VIF driver."}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_d70f2437","line":102,"range":{"start_line":100,"start_character":18,"end_line":102,"end_character":34},"updated":"2016-06-29 18:43:34.000000000","message":"This can go in the glossary section.","commit_id":"6ab75904623f4400b81e4f248355b1f5fa64e9bd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26913041a68d06d262009e0b697ee67231967342","unresolved":false,"context_lines":[{"line_number":110,"context_line":"port carries binding:vif_type and binding:vnic_type attributes. The vif"},{"line_number":111,"context_line":"type for this implementation will be pvm_vnic. The vnic_type will be \u0027direct\u0027."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"A VIF driver (PvmFSriovVifDriver) for directly attached to VM may get"},{"line_number":114,"context_line":"implemented in future. Its vif_type will be pvm_vf and vnic_type \u0027direct\u0027."},{"line_number":115,"context_line":"Selection of vif_type will be driven by an entry in nova configuration file."},{"line_number":116,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_e2ad40ea","line":113,"range":{"start_line":113,"start_character":14,"end_line":113,"end_character":32},"updated":"2016-06-29 18:43:34.000000000","message":"PvmVFSriovVifDriver (missing V)","commit_id":"6ab75904623f4400b81e4f248355b1f5fa64e9bd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26913041a68d06d262009e0b697ee67231967342","unresolved":false,"context_lines":[{"line_number":111,"context_line":"type for this implementation will be pvm_vnic. The vnic_type will be \u0027direct\u0027."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"A VIF driver (PvmFSriovVifDriver) for directly attached to VM may get"},{"line_number":114,"context_line":"implemented in future. Its vif_type will be pvm_vf and vnic_type \u0027direct\u0027."},{"line_number":115,"context_line":"Selection of vif_type will be driven by an entry in nova configuration file."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Deployment of VM with SR-IOV VF will involve picking Physical Port(s),"},{"line_number":118,"context_line":"VIOS(es) and and a VM and invoking pypowervm library. Similarly, attachment"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_e200a036","line":115,"range":{"start_line":114,"start_character":22,"end_line":115,"end_character":76},"updated":"2016-06-29 18:43:34.000000000","message":"Not sure we need to nail this down here.","commit_id":"6ab75904623f4400b81e4f248355b1f5fa64e9bd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26913041a68d06d262009e0b697ee67231967342","unresolved":false,"context_lines":[{"line_number":114,"context_line":"implemented in future. Its vif_type will be pvm_vf and vnic_type \u0027direct\u0027."},{"line_number":115,"context_line":"Selection of vif_type will be driven by an entry in nova configuration file."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Deployment of VM with SR-IOV VF will involve picking Physical Port(s),"},{"line_number":118,"context_line":"VIOS(es) and and a VM and invoking pypowervm library. Similarly, attachment"},{"line_number":119,"context_line":"of the same to an existing VM will be implemented. Evacuate and migration of"},{"line_number":120,"context_line":"VM will be supported with changes to compute virt driver and VIF driver via"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_62cdd030","line":117,"range":{"start_line":117,"start_character":29,"end_line":117,"end_character":31},"updated":"2016-06-29 18:43:34.000000000","message":"vNIC","commit_id":"6ab75904623f4400b81e4f248355b1f5fa64e9bd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26913041a68d06d262009e0b697ee67231967342","unresolved":false,"context_lines":[{"line_number":115,"context_line":"Selection of vif_type will be driven by an entry in nova configuration file."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Deployment of VM with SR-IOV VF will involve picking Physical Port(s),"},{"line_number":118,"context_line":"VIOS(es) and and a VM and invoking pypowervm library. Similarly, attachment"},{"line_number":119,"context_line":"of the same to an existing VM will be implemented. Evacuate and migration of"},{"line_number":120,"context_line":"VM will be supported with changes to compute virt driver and VIF driver via"},{"line_number":121,"context_line":"pypowervm library. "}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_e294208c","line":118,"range":{"start_line":118,"start_character":13,"end_line":118,"end_character":16},"updated":"2016-06-29 18:43:34.000000000","message":"strike","commit_id":"6ab75904623f4400b81e4f248355b1f5fa64e9bd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26913041a68d06d262009e0b697ee67231967342","unresolved":false,"context_lines":[{"line_number":114,"context_line":"implemented in future. Its vif_type will be pvm_vf and vnic_type \u0027direct\u0027."},{"line_number":115,"context_line":"Selection of vif_type will be driven by an entry in nova configuration file."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Deployment of VM with SR-IOV VF will involve picking Physical Port(s),"},{"line_number":118,"context_line":"VIOS(es) and and a VM and invoking pypowervm library. Similarly, attachment"},{"line_number":119,"context_line":"of the same to an existing VM will be implemented. Evacuate and migration of"},{"line_number":120,"context_line":"VM will be supported with changes to compute virt driver and VIF driver via"},{"line_number":121,"context_line":"pypowervm library. "},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"vNIC redundancy/failover across VFs within or across Physical"},{"line_number":124,"context_line":"Ports or SR-IOV adapters will be an option in both deploy and attach scenario."}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_9d377d4c","line":121,"range":{"start_line":117,"start_character":0,"end_line":121,"end_character":19},"updated":"2016-06-29 18:43:34.000000000","message":"I think this paragraph is redundant and can be removed.","commit_id":"6ab75904623f4400b81e4f248355b1f5fa64e9bd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26913041a68d06d262009e0b697ee67231967342","unresolved":false,"context_lines":[{"line_number":118,"context_line":"VIOS(es) and and a VM and invoking pypowervm library. Similarly, attachment"},{"line_number":119,"context_line":"of the same to an existing VM will be implemented. Evacuate and migration of"},{"line_number":120,"context_line":"VM will be supported with changes to compute virt driver and VIF driver via"},{"line_number":121,"context_line":"pypowervm library. "},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"vNIC redundancy/failover across VFs within or across Physical"},{"line_number":124,"context_line":"Ports or SR-IOV adapters will be an option in both deploy and attach scenario."}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_028b2cc4","line":121,"range":{"start_line":121,"start_character":18,"end_line":121,"end_character":19},"updated":"2016-06-29 18:43:34.000000000","message":"trailing space","commit_id":"6ab75904623f4400b81e4f248355b1f5fa64e9bd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26913041a68d06d262009e0b697ee67231967342","unresolved":false,"context_lines":[{"line_number":120,"context_line":"VM will be supported with changes to compute virt driver and VIF driver via"},{"line_number":121,"context_line":"pypowervm library. "},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"vNIC redundancy/failover across VFs within or across Physical"},{"line_number":124,"context_line":"Ports or SR-IOV adapters will be an option in both deploy and attach scenario."},{"line_number":125,"context_line":"pypowervm library will be utilized to setup such a redundancy/failover"},{"line_number":126,"context_line":"configuration."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"For future implementation of VF - VM attach path, redundancy will still be"},{"line_number":129,"context_line":"achievable with NIB at VM level. With two VFs directly attached to a VM, a"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_3d4769bd","line":126,"range":{"start_line":123,"start_character":0,"end_line":126,"end_character":14},"updated":"2016-06-29 18:43:34.000000000","message":"I think this paragraph is redundant and can be removed.","commit_id":"6ab75904623f4400b81e4f248355b1f5fa64e9bd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26913041a68d06d262009e0b697ee67231967342","unresolved":false,"context_lines":[{"line_number":126,"context_line":"configuration."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"For future implementation of VF - VM attach path, redundancy will still be"},{"line_number":129,"context_line":"achievable with NIB at VM level. With two VFs directly attached to a VM, a"},{"line_number":130,"context_line":"NIB can be setup across them inside VM."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Regarding failover/redundancy, VIF plug during deploy (or attach of"},{"line_number":133,"context_line":"network interface to a VM) will pass more than one Physical port and VIOS(es)"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_42041417","line":130,"range":{"start_line":129,"start_character":33,"end_line":130,"end_character":39},"updated":"2016-06-29 18:43:34.000000000","message":"This sentence seems redundant.","commit_id":"6ab75904623f4400b81e4f248355b1f5fa64e9bd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26913041a68d06d262009e0b697ee67231967342","unresolved":false,"context_lines":[{"line_number":129,"context_line":"achievable with NIB at VM level. With two VFs directly attached to a VM, a"},{"line_number":130,"context_line":"NIB can be setup across them inside VM."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Regarding failover/redundancy, VIF plug during deploy (or attach of"},{"line_number":133,"context_line":"network interface to a VM) will pass more than one Physical port and VIOS(es)"},{"line_number":134,"context_line":"(as stated above in deploy scenario) to pypowervm library to create vNIC on"},{"line_number":135,"context_line":"VIOS with redundancy. To control redundancy a combination of data elements will"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_356addb3","line":132,"updated":"2016-06-29 18:43:34.000000000","message":"It should be mentioned that failover is handled automatically by the platform when a vNIC is backed by multiple VFs.","commit_id":"6ab75904623f4400b81e4f248355b1f5fa64e9bd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26913041a68d06d262009e0b697ee67231967342","unresolved":false,"context_lines":[{"line_number":134,"context_line":"(as stated above in deploy scenario) to pypowervm library to create vNIC on"},{"line_number":135,"context_line":"VIOS with redundancy. To control redundancy a combination of data elements will"},{"line_number":136,"context_line":"be used. One of them is the number of physical ports from"},{"line_number":137,"context_line":"pci_passthrough_whitelist(NPP) entry in nova configuration. And the other is"},{"line_number":138,"context_line":"desired_redundancy_level(DRL) from nova configuration. If DRL is not"},{"line_number":139,"context_line":"specified, redundancy will fallback to NPP (use all available physical ports"},{"line_number":140,"context_line":"for each vNIC). If DRL is specified, it should be a number between 1 and NPP."},{"line_number":141,"context_line":"DRL configuration option will be applied to all VMs created by the given"},{"line_number":142,"context_line":"compute driver invocation.  There will be one neutron port created for"},{"line_number":143,"context_line":"redundancy. "}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_ddd905f5","line":140,"range":{"start_line":137,"start_character":60,"end_line":140,"end_character":77},"updated":"2016-06-29 18:43:34.000000000","message":"Let\u0027s talk about this.  I feel like we should go out of the gate with a default policy and no configurability.  We should describe that policy.  We can state that we may add configurability later, which may include both a minimum and maximum redundancy level.","commit_id":"6ab75904623f4400b81e4f248355b1f5fa64e9bd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26913041a68d06d262009e0b697ee67231967342","unresolved":false,"context_lines":[{"line_number":140,"context_line":"for each vNIC). If DRL is specified, it should be a number between 1 and NPP."},{"line_number":141,"context_line":"DRL configuration option will be applied to all VMs created by the given"},{"line_number":142,"context_line":"compute driver invocation.  There will be one neutron port created for"},{"line_number":143,"context_line":"redundancy. "},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"SR-IOV implementation in OpenStack nova involves usage of"},{"line_number":146,"context_line":"pci_passthrough_whitelist. This is a construct specified in nova configuration"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_e2aee02c","line":143,"range":{"start_line":143,"start_character":11,"end_line":143,"end_character":12},"updated":"2016-06-29 18:43:34.000000000","message":"trailing space","commit_id":"6ab75904623f4400b81e4f248355b1f5fa64e9bd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26913041a68d06d262009e0b697ee67231967342","unresolved":false,"context_lines":[{"line_number":143,"context_line":"redundancy. "},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"SR-IOV implementation in OpenStack nova involves usage of"},{"line_number":146,"context_line":"pci_passthrough_whitelist. This is a construct specified in nova configuration"},{"line_number":147,"context_line":"file to specify characteristics of SR-IOV card like device name, address of"},{"line_number":148,"context_line":"physical ports and physical network etc. For SR-IOV implementation for PowerVM,"},{"line_number":149,"context_line":"pci_passthrough_whitelist will be used to describe physical port data in a"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_286729b8","line":146,"range":{"start_line":146,"start_character":0,"end_line":146,"end_character":25},"updated":"2016-06-29 18:43:34.000000000","message":"It would be nice to provide a reference of some kind here.  Probably the best thing is the documentation in the source code: https://github.com/openstack/nova/blob/master/nova/conf/pci.py#L63","commit_id":"6ab75904623f4400b81e4f248355b1f5fa64e9bd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26913041a68d06d262009e0b697ee67231967342","unresolved":false,"context_lines":[{"line_number":150,"context_line":"specific format. This configuration needs to be updated either manually or via"},{"line_number":151,"context_line":"any automated way (ansible)."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"The following are the elements of a pci_passthrough_whitelist entry:"},{"line_number":154,"context_line":"There will be a new property called \u0027physloc\u0027. This will contain physical"},{"line_number":155,"context_line":"network to physical port mapping. Physical port data may include location code"},{"line_number":156,"context_line":"or a combination of adapter ID and physical port ID."},{"line_number":157,"context_line":"This data specified in nova configuration file will describe the mapping"},{"line_number":158,"context_line":"between physical networks to SR-IOV physical ports."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"An example entry in nova configuration file will look like:"},{"line_number":161,"context_line":"pci_passthrough_whitelist \u003d [{\"physloc\": \"xxxx\", \"physical_network\":"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_dd490533","line":158,"range":{"start_line":153,"start_character":0,"end_line":158,"end_character":51},"updated":"2016-06-29 18:43:34.000000000","message":"It\u0027ll only allow a physical location code - not adapter+port IDs.  Suggest reword:\n\nThis implementation will introduce a new key to pci_passthrough_whitelist called \u0027physloc\u0027.  Its value will contain the (string) physical location code of a single SR-IOV physical port.  The existing \u0027physical_network\u0027 key will then be used to associate that physical port with a physical network name as usual.","commit_id":"6ab75904623f4400b81e4f248355b1f5fa64e9bd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26913041a68d06d262009e0b697ee67231967342","unresolved":false,"context_lines":[{"line_number":156,"context_line":"or a combination of adapter ID and physical port ID."},{"line_number":157,"context_line":"This data specified in nova configuration file will describe the mapping"},{"line_number":158,"context_line":"between physical networks to SR-IOV physical ports."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"An example entry in nova configuration file will look like:"},{"line_number":161,"context_line":"pci_passthrough_whitelist \u003d [{\"physloc\": \"xxxx\", \"physical_network\":"},{"line_number":162,"context_line":"\"foo_net\"}, {\"physloc\": \"yyyy\", \"physical_network\": \"foo_net\"}, {\"physloc\":"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_5d3235a8","line":159,"updated":"2016-06-29 18:43:34.000000000","message":"It is probably also worth discussing (either here or under \u0027alternatives\u0027) why we didn\u0027t use the existing \u0027address\u0027 or \u0027devname\u0027 fields.","commit_id":"6ab75904623f4400b81e4f248355b1f5fa64e9bd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26913041a68d06d262009e0b697ee67231967342","unresolved":false,"context_lines":[{"line_number":163,"context_line":"\"aaaa\", \"physical_network\": \"bar_net\"}, {\"physloc\": \"bbbb\", \"physical_network\":"},{"line_number":164,"context_line":" \"bar_net\"}, ...]"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"For future implementation of VM - VM direct attach of SR-IOV port to a VM, the"},{"line_number":167,"context_line":"request will include physical network name. PvmVFSriovVifDriver can lookup"},{"line_number":168,"context_line":"devname(s) associated with it from pci-whitelist, get physical port information"},{"line_number":169,"context_line":"and create a SR-IOV logical port on the corresponding VM. If there are multiple"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_28c3a958","line":166,"range":{"start_line":166,"start_character":61,"end_line":166,"end_character":65},"updated":"2016-06-29 18:43:34.000000000","message":"VF","commit_id":"6ab75904623f4400b81e4f248355b1f5fa64e9bd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26913041a68d06d262009e0b697ee67231967342","unresolved":false,"context_lines":[{"line_number":163,"context_line":"\"aaaa\", \"physical_network\": \"bar_net\"}, {\"physloc\": \"bbbb\", \"physical_network\":"},{"line_number":164,"context_line":" \"bar_net\"}, ...]"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"For future implementation of VM - VM direct attach of SR-IOV port to a VM, the"},{"line_number":167,"context_line":"request will include physical network name. PvmVFSriovVifDriver can lookup"},{"line_number":168,"context_line":"devname(s) associated with it from pci-whitelist, get physical port information"},{"line_number":169,"context_line":"and create a SR-IOV logical port on the corresponding VM. If there are multiple"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_fde841e4","line":166,"range":{"start_line":166,"start_character":29,"end_line":166,"end_character":37},"updated":"2016-06-29 18:43:34.000000000","message":"strike","commit_id":"6ab75904623f4400b81e4f248355b1f5fa64e9bd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26913041a68d06d262009e0b697ee67231967342","unresolved":false,"context_lines":[{"line_number":167,"context_line":"request will include physical network name. PvmVFSriovVifDriver can lookup"},{"line_number":168,"context_line":"devname(s) associated with it from pci-whitelist, get physical port information"},{"line_number":169,"context_line":"and create a SR-IOV logical port on the corresponding VM. If there are multiple"},{"line_number":170,"context_line":"devnames returned as many SR-IOV logical ports will be attached to the VM."},{"line_number":171,"context_line":"Using NIB technique, users can setup redundancy."},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"For VF - vNIC - VM attach of SR-IOV port to a VM, the request will include"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_6895b131","line":170,"updated":"2016-06-29 18:43:34.000000000","message":"...or we may introduce a conf option to allow the user to dictate how many ports to attach.","commit_id":"6ab75904623f4400b81e4f248355b1f5fa64e9bd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26913041a68d06d262009e0b697ee67231967342","unresolved":false,"context_lines":[{"line_number":177,"context_line":"added and a VNIC dedicated port on the corresponding VM will be created."},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"For migration scenario, physical network names should match on source and"},{"line_number":180,"context_line":"destination compute nodes."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"Alternatives"},{"line_number":183,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_c8578558","line":180,"updated":"2016-06-29 18:43:34.000000000","message":"We may want to go into more detail here as to the policy for migrating a vNIC network.  In particular, I feel like we should rebuild the vNIC based on the port configuration settings at the destination, without trying to match any particulars of the source configuration (e.g. number of backing VFs or QoS).  But let\u0027s talk over the details.","commit_id":"6ab75904623f4400b81e4f248355b1f5fa64e9bd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26913041a68d06d262009e0b697ee67231967342","unresolved":false,"context_lines":[{"line_number":212,"context_line":"Dependencies"},{"line_number":213,"context_line":"------------"},{"line_number":214,"context_line":"1. An updated version of Novalink PowerVM feature"},{"line_number":215,"context_line":"2. pypowervm library(pypowervm library(https://github.com/powervm/pypowervm)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"Implementation"},{"line_number":218,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_c89ca510","line":215,"range":{"start_line":215,"start_character":3,"end_line":215,"end_character":76},"updated":"2016-06-29 18:43:34.000000000","message":"Weird repetition \u0026 parens here","commit_id":"6ab75904623f4400b81e4f248355b1f5fa64e9bd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26913041a68d06d262009e0b697ee67231967342","unresolved":false,"context_lines":[{"line_number":222,"context_line":"Sridhar Venkat"},{"line_number":223,"context_line":"Eric Larese"},{"line_number":224,"context_line":"Esha Seth"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"Work Items"},{"line_number":227,"context_line":"----------"},{"line_number":228,"context_line":"nova-powervm changes:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_288e09d0","line":225,"updated":"2016-06-29 18:43:34.000000000","message":"I should probably be listed here.\n\nMaybe Drew too.","commit_id":"6ab75904623f4400b81e4f248355b1f5fa64e9bd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26913041a68d06d262009e0b697ee67231967342","unresolved":false,"context_lines":[{"line_number":227,"context_line":"----------"},{"line_number":228,"context_line":"nova-powervm changes:"},{"line_number":229,"context_line":"Updates to PowerVM compute driver to support attachment of SR-IOV VF via vNIC."},{"line_number":230,"context_line":"VIF driver for SR-IOV VF connected to VM via vNIC"},{"line_number":231,"context_line":"Migration of VM with SR-IOV VF connected to VM via vNIC. This involves"},{"line_number":232,"context_line":"live migration, cold migration and evacuation."},{"line_number":233,"context_line":"Failover/redundancy support for SR-IOV VF(s) connected to VM via vNIC(s)"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_68c2d1ea","line":230,"updated":"2016-06-29 18:43:34.000000000","message":".","commit_id":"6ab75904623f4400b81e4f248355b1f5fa64e9bd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26913041a68d06d262009e0b697ee67231967342","unresolved":false,"context_lines":[{"line_number":230,"context_line":"VIF driver for SR-IOV VF connected to VM via vNIC"},{"line_number":231,"context_line":"Migration of VM with SR-IOV VF connected to VM via vNIC. This involves"},{"line_number":232,"context_line":"live migration, cold migration and evacuation."},{"line_number":233,"context_line":"Failover/redundancy support for SR-IOV VF(s) connected to VM via vNIC(s)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"VIF driver for SR-IOV VF connected to VM directly will be a future work item"},{"line_number":236,"context_line":"and will not be implemented in newton timeframe."}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_48a8b520","line":233,"updated":"2016-06-29 18:43:34.000000000","message":".","commit_id":"6ab75904623f4400b81e4f248355b1f5fa64e9bd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26913041a68d06d262009e0b697ee67231967342","unresolved":false,"context_lines":[{"line_number":282,"context_line":"for comparison purposes."},{"line_number":283,"context_line":"9. https://wiki.openstack.org/wiki/SR-IOV-Passthrough-For-Networking"},{"line_number":284,"context_line":"   SR-IOV pci passthrough reference."},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"Glossary"},{"line_number":287,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":288,"context_line":"1.SR-IOV - Single Root I/O Virtualization, used for virtual environments where"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_4856f52a","line":285,"updated":"2016-06-29 18:43:34.000000000","message":"Reference for pypowervm","commit_id":"6ab75904623f4400b81e4f248355b1f5fa64e9bd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26913041a68d06d262009e0b697ee67231967342","unresolved":false,"context_lines":[{"line_number":295,"context_line":"3.VF - Represents Virtual port belonging to a specific PF. Either directly or"},{"line_number":296,"context_line":"indirectly (using vNIC) a VF is connected to a VM. This is otherwise called"},{"line_number":297,"context_line":"SR-IOV logical port."},{"line_number":298,"context_line":"4. Dedicated SR-IOV - A PF with all its VFs associated with a VM. This is an"},{"line_number":299,"context_line":"unsupported configuration."},{"line_number":300,"context_line":"5. Shared SR-IOV - A VF of a PF associated with a VM. This is an supported"},{"line_number":301,"context_line":"configuration however, will not support migration."},{"line_number":302,"context_line":"6. Shared Ethernet Adapter - Alternate technique to provide network interface"},{"line_number":303,"context_line":"to a VM."},{"line_number":304,"context_line":"This involves attachment to a physical interface on PowerVM host and one or"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_438ed679","line":301,"range":{"start_line":298,"start_character":0,"end_line":301,"end_character":50},"updated":"2016-06-29 18:43:34.000000000","message":"I don\u0027t like these terms or how they\u0027re defined.\n\nAn SR-IOV card in Dedicated mode can be used as if it was any regular ethernet card.  In the community, you could use this with SEA; in that sense, it *is* supported.\n\nWhat you\u0027re calling \"Shared SR-IOV\" you seem to be defining too narrowly as direct VF-to-VM - which is *not* supported in Netwon.  But an SR-IOV card in Sriov mode is what we\u0027ll be using for vNIC as described in this blueprint.  And also, an SR-IOV in Sriov mode can have a promiscuous VF assigned to the VIOS and configured for SEA (said configuration to be done outside of the auspices of OpenStack), which can then be used just like any other SEA configuration; and *is* supported (as described below).","commit_id":"6ab75904623f4400b81e4f248355b1f5fa64e9bd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"26913041a68d06d262009e0b697ee67231967342","unresolved":false,"context_lines":[{"line_number":309,"context_line":"7. vNIC - A vNIC is an intermediary between VF of PF and VM. This resides on"},{"line_number":310,"context_line":"VIOS and connects to a VF one one end and vNIC client adapter inside a VM."},{"line_number":311,"context_line":"This is mainly to support migration of VMs across hosts."},{"line_number":312,"context_line":"8. Dedicated vNIC - A one to one mapping between VF and vNIC which in turn is"},{"line_number":313,"context_line":"connected to a VM."},{"line_number":314,"context_line":"9. Shared vNIC - An unsupported scenario, where one VF is connected to many"},{"line_number":315,"context_line":"vNICs."},{"line_number":316,"context_line":"10. vNIC failover/redundancy - Multiple vNIC servers (connected to as many VFs"},{"line_number":317,"context_line":"that belong to as many PFs either on same SR-IOV card or across) connected to"},{"line_number":318,"context_line":"same VM as one network interface. Failure of one vNIC/VF/PF path will result"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_03c68e99","line":315,"range":{"start_line":312,"start_character":0,"end_line":315,"end_character":6},"updated":"2016-06-29 18:43:34.000000000","message":"Not sure we even want to mention this distinction here.  Shared vNIC isn\u0027t implemented in PowerVM.  If it ever does get implemented (which seems unlikely), and we decide to bring support for it into the community (ditto), we\u0027ll have to have a separate blueprint for that.","commit_id":"6ab75904623f4400b81e4f248355b1f5fa64e9bd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"36d2ed489589677d5a3d300ad56c8ea2eb760179","unresolved":false,"context_lines":[{"line_number":93,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":94,"context_line":"The changes will be made in two areas:"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"1. Compute virt driver."},{"line_number":97,"context_line":"PowerVM compute driver is in nova.virt.powervm.driver.PowerVMDriver"},{"line_number":98,"context_line":"and it will be enhanced for SR-IOV VF support. pypowervm enhancements for vNIC"},{"line_number":99,"context_line":"will be required. pypowervm will offer functions to manage SR-IOV adapters and"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3aaa91ec_fcfc7cb6","line":96,"updated":"2016-06-30 22:04:56.000000000","message":"More details required?  (@thorst?)","commit_id":"034e824f0fccfd2c0293a48c8945f5d6a686fa47"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"da61b36ac744ab6312afce06af08ae6ad0298493","unresolved":false,"context_lines":[{"line_number":93,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":94,"context_line":"The changes will be made in two areas:"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"1. Compute virt driver."},{"line_number":97,"context_line":"PowerVM compute driver is in nova.virt.powervm.driver.PowerVMDriver"},{"line_number":98,"context_line":"and it will be enhanced for SR-IOV VF support. pypowervm enhancements for vNIC"},{"line_number":99,"context_line":"will be required. pypowervm will offer functions to manage SR-IOV adapters and"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1aa78d24_e52d3e47","line":96,"in_reply_to":"3aaa91ec_fcfc7cb6","updated":"2016-07-06 13:15:33.000000000","message":"Yeah...is there any compute driver changes?  Or is it just the VIF driver?","commit_id":"034e824f0fccfd2c0293a48c8945f5d6a686fa47"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"36d2ed489589677d5a3d300ad56c8ea2eb760179","unresolved":false,"context_lines":[{"line_number":124,"context_line":"(as stated above in deploy scenario) to pypowervm library to create vNIC on"},{"line_number":125,"context_line":"VIOS with redundancy. It should be noted that failover is handled automatically"},{"line_number":126,"context_line":"by the platform when a vNIC is backed by multiple VFs. To control redundancy a"},{"line_number":127,"context_line":"combination of data elements will be used. One of them is the number of"},{"line_number":128,"context_line":"physical ports from pci_passthrough_whitelist(NPP) entry in nova configuration."},{"line_number":129,"context_line":"And the other is desired_redundancy_level(DRL) from nova configuration. If DRL"},{"line_number":130,"context_line":"is not specified, redundancy will fallback to NPP (use all available physical"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3aaa91ec_7c27ec62","line":127,"updated":"2016-06-30 22:04:56.000000000","message":"Still need to discuss this design.","commit_id":"034e824f0fccfd2c0293a48c8945f5d6a686fa47"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"974ab1fafccdde5ea1fb61a8a8b092282c5d424f","unresolved":false,"context_lines":[{"line_number":127,"context_line":"by the platform when a vNIC is backed by multiple VFs. To control redundancy a"},{"line_number":128,"context_line":"combination of data elements will be used. There will be an implementation of"},{"line_number":129,"context_line":"default policy that will determine appropriate minimum and maximum redundancy"},{"line_number":130,"context_line":"based on number of SR-IOV cards, number of VIOSes and number ofphysical ports"},{"line_number":131,"context_line":"from pci_passthrough_whitelist(NPP) entry in nova configuration and also is"},{"line_number":132,"context_line":"required_redundancy_level(RRL) from nova configuration. In powervm section in"},{"line_number":133,"context_line":"nova configuration, a new property called vnic_required_vfs will be added with"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1aa78d24_3d25f75b","line":130,"range":{"start_line":130,"start_character":61,"end_line":130,"end_character":71},"updated":"2016-07-14 21:21:19.000000000","message":"of physical","commit_id":"9fd69b6993929ac1ef8b0a44d253cef130cedd12"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This blueprint will address support of SR-IOV in conjunction with SR-IOV"},{"line_number":16,"context_line":"VF attached to VM via PowerVM vNIC into nova-powervm. SR-IOV support"},{"line_number":17,"context_line":"was added to Juno release of OpenStack, this blueprint will attempt to fit"},{"line_number":18,"context_line":"this scenario implementation into it."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"A separate blueprint will be made available for design elements regarding"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_0275c996","line":17,"range":{"start_line":17,"start_character":60,"end_line":17,"end_character":67},"updated":"2016-07-26 23:05:05.000000000","message":"It will.  Not necessarily attempt to.","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This blueprint will address support of SR-IOV in conjunction with SR-IOV"},{"line_number":16,"context_line":"VF attached to VM via PowerVM vNIC into nova-powervm. SR-IOV support"},{"line_number":17,"context_line":"was added to Juno release of OpenStack, this blueprint will attempt to fit"},{"line_number":18,"context_line":"this scenario implementation into it."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"A separate blueprint will be made available for design elements regarding"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_954b5f59","line":17,"range":{"start_line":17,"start_character":60,"end_line":17,"end_character":67},"in_reply_to":"dada55a8_0275c996","updated":"2016-08-08 13:47:10.000000000","message":"Done","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"was added to Juno release of OpenStack, this blueprint will attempt to fit"},{"line_number":18,"context_line":"this scenario implementation into it."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"A separate blueprint will be made available for design elements regarding"},{"line_number":21,"context_line":"networking-powervm. (Refer to https://review.openstack.org/#/c/322210/)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"These blueprints will be implemented during Newton cycle of OpenStack"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_426b41b9","line":20,"range":{"start_line":20,"start_character":21,"end_line":20,"end_character":28},"updated":"2016-07-26 23:05:05.000000000","message":"has been","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":17,"context_line":"was added to Juno release of OpenStack, this blueprint will attempt to fit"},{"line_number":18,"context_line":"this scenario implementation into it."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"A separate blueprint will be made available for design elements regarding"},{"line_number":21,"context_line":"networking-powervm. (Refer to https://review.openstack.org/#/c/322210/)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"These blueprints will be implemented during Newton cycle of OpenStack"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_35ac33ed","line":20,"range":{"start_line":20,"start_character":21,"end_line":20,"end_character":28},"in_reply_to":"dada55a8_426b41b9","updated":"2016-08-08 13:47:10.000000000","message":"Done","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"These blueprints will be implemented during Newton cycle of OpenStack"},{"line_number":24,"context_line":"development. Referring to Newton schedule, development should be completed"},{"line_number":25,"context_line":"between newton-2 and 3, between R-10 and R-6. Certainly by newton-3"},{"line_number":26,"context_line":"milestone(R5)."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Refer to glossary section for explanation of terms."}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_029ca9be","line":25,"range":{"start_line":25,"start_character":21,"end_line":25,"end_character":22},"updated":"2016-07-26 23:05:05.000000000","message":"We\u0027re past newton-2 now.  So I think you have to say newton-3","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"These blueprints will be implemented during Newton cycle of OpenStack"},{"line_number":24,"context_line":"development. Referring to Newton schedule, development should be completed"},{"line_number":25,"context_line":"between newton-2 and 3, between R-10 and R-6. Certainly by newton-3"},{"line_number":26,"context_line":"milestone(R5)."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Refer to glossary section for explanation of terms."}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_d5e83719","line":25,"range":{"start_line":25,"start_character":21,"end_line":25,"end_character":22},"in_reply_to":"dada55a8_029ca9be","updated":"2016-08-08 13:47:10.000000000","message":"Done","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Problem Description"},{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":32,"context_line":"OpenStack PowerVM drivers currently support networking aspect of PowerVM"},{"line_number":33,"context_line":"virtualization using Shared Ethernet Adapter, OpenVSwitch and Linux"},{"line_number":34,"context_line":"Bridge. There is a need for supporting SR-IOV ports with redundancy/failover"},{"line_number":35,"context_line":"and migration. It is possible to associate SR-IOV VF to a VM directly and this"},{"line_number":36,"context_line":"path will not be supported by this design. Such a setup will not provide"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_22a72d0c","line":33,"updated":"2016-07-26 23:05:05.000000000","message":"Space.  Open vSwitch.","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Problem Description"},{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":32,"context_line":"OpenStack PowerVM drivers currently support networking aspect of PowerVM"},{"line_number":33,"context_line":"virtualization using Shared Ethernet Adapter, OpenVSwitch and Linux"},{"line_number":34,"context_line":"Bridge. There is a need for supporting SR-IOV ports with redundancy/failover"},{"line_number":35,"context_line":"and migration. It is possible to associate SR-IOV VF to a VM directly and this"},{"line_number":36,"context_line":"path will not be supported by this design. Such a setup will not provide"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_f5f73bf3","line":33,"in_reply_to":"dada55a8_22a72d0c","updated":"2016-08-08 13:47:10.000000000","message":"Done","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":35,"context_line":"and migration. It is possible to associate SR-IOV VF to a VM directly and this"},{"line_number":36,"context_line":"path will not be supported by this design. Such a setup will not provide"},{"line_number":37,"context_line":"migration support anyway. Support for this configuration will"},{"line_number":38,"context_line":"be added in future. It is possible to attach entire physical port of SR-IOV"},{"line_number":39,"context_line":"card directly to VM, this scenario will not be supported at this time as"},{"line_number":40,"context_line":"migration with such an interface will not be possible. This path also does not"},{"line_number":41,"context_line":"utilize advantages of hardware level virtualization offered by SR-IOV"},{"line_number":42,"context_line":"architecture. This scenario does not have as much demand for cloud workloads"},{"line_number":43,"context_line":"on PowerVM at this moment."}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_a2b31d4c","line":40,"range":{"start_line":38,"start_character":20,"end_line":40,"end_character":55},"updated":"2016-07-26 23:05:05.000000000","message":"This is duplicate with the sentences beforehand.","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":35,"context_line":"and migration. It is possible to associate SR-IOV VF to a VM directly and this"},{"line_number":36,"context_line":"path will not be supported by this design. Such a setup will not provide"},{"line_number":37,"context_line":"migration support anyway. Support for this configuration will"},{"line_number":38,"context_line":"be added in future. It is possible to attach entire physical port of SR-IOV"},{"line_number":39,"context_line":"card directly to VM, this scenario will not be supported at this time as"},{"line_number":40,"context_line":"migration with such an interface will not be possible. This path also does not"},{"line_number":41,"context_line":"utilize advantages of hardware level virtualization offered by SR-IOV"},{"line_number":42,"context_line":"architecture. This scenario does not have as much demand for cloud workloads"},{"line_number":43,"context_line":"on PowerVM at this moment."}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_15cacfa1","line":40,"range":{"start_line":38,"start_character":20,"end_line":40,"end_character":55},"in_reply_to":"dada55a8_a2b31d4c","updated":"2016-08-08 13:47:10.000000000","message":"Done","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":39,"context_line":"card directly to VM, this scenario will not be supported at this time as"},{"line_number":40,"context_line":"migration with such an interface will not be possible. This path also does not"},{"line_number":41,"context_line":"utilize advantages of hardware level virtualization offered by SR-IOV"},{"line_number":42,"context_line":"architecture. This scenario does not have as much demand for cloud workloads"},{"line_number":43,"context_line":"on PowerVM at this moment."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Users should be able to manage a VM with SR-IOV vNIC as a network interface."},{"line_number":46,"context_line":"This management should include migration of VM with SR-IOV vNIC"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_c28d717d","line":43,"range":{"start_line":42,"start_character":14,"end_line":43,"end_character":26},"updated":"2016-07-26 23:05:05.000000000","message":"I would not include this.  I think it actually does have demand - for network nodes.","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":39,"context_line":"card directly to VM, this scenario will not be supported at this time as"},{"line_number":40,"context_line":"migration with such an interface will not be possible. This path also does not"},{"line_number":41,"context_line":"utilize advantages of hardware level virtualization offered by SR-IOV"},{"line_number":42,"context_line":"architecture. This scenario does not have as much demand for cloud workloads"},{"line_number":43,"context_line":"on PowerVM at this moment."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Users should be able to manage a VM with SR-IOV vNIC as a network interface."},{"line_number":46,"context_line":"This management should include migration of VM with SR-IOV vNIC"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_35c1d381","line":43,"range":{"start_line":42,"start_character":14,"end_line":43,"end_character":26},"in_reply_to":"dada55a8_c28d717d","updated":"2016-08-08 13:47:10.000000000","message":"Done","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Users should be able to manage a VM with SR-IOV vNIC as a network interface."},{"line_number":46,"context_line":"This management should include migration of VM with SR-IOV vNIC"},{"line_number":47,"context_line":"attached to it.  Migration support for SR-IOV is not supported currently, but"},{"line_number":48,"context_line":"there are efforts to support it for KVM using macvtap. There is a blueprint in"},{"line_number":49,"context_line":"progress in Newton:"},{"line_number":50,"context_line":"https://blueprints.launchpad.net/nova/+spec/sriov-live-migration"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_42f061fd","line":47,"updated":"2016-07-26 23:05:05.000000000","message":"KVM SR-IOV","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Users should be able to manage a VM with SR-IOV vNIC as a network interface."},{"line_number":46,"context_line":"This management should include migration of VM with SR-IOV vNIC"},{"line_number":47,"context_line":"attached to it.  Migration support for SR-IOV is not supported currently, but"},{"line_number":48,"context_line":"there are efforts to support it for KVM using macvtap. There is a blueprint in"},{"line_number":49,"context_line":"progress in Newton:"},{"line_number":50,"context_line":"https://blueprints.launchpad.net/nova/+spec/sriov-live-migration"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_75bb4b0f","line":47,"in_reply_to":"dada55a8_42f061fd","updated":"2016-08-08 13:47:10.000000000","message":"Done","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"core nova for SR-IOV, however if that does not land in Newton then the work"},{"line_number":53,"context_line":"here will still continue without live migration support until Ocata."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Based on PowerVM firmware design, VF(s) can be associated with a vNIC"},{"line_number":56,"context_line":"server on VIOS and it is subsequently associated with vNIC client interface on"},{"line_number":57,"context_line":"a VM. This intermediary vNIC is a mandatory requirement to support migration"},{"line_number":58,"context_line":"of such a VM from host to host. This intermediary is also needed to support"},{"line_number":59,"context_line":"redundancy/failover across VFs. For setting up redundancy, n-number of SR-IOV"},{"line_number":60,"context_line":"Physical Ports have to be provided to pypowervm layer and VFs and vNIC servers"},{"line_number":61,"context_line":"will be carved out of them and connected to vNIC client adapter on VM. All VFs"},{"line_number":62,"context_line":"attached to a vNIC will carry same mac address and will be represented by one"},{"line_number":63,"context_line":"neutron port."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"In summary, this blueprint will solve support of SR-IOV in nova-powervm for"},{"line_number":66,"context_line":"these scenarios:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_2243ad14","line":63,"range":{"start_line":55,"start_character":0,"end_line":63,"end_character":13},"updated":"2016-07-26 23:05:05.000000000","message":"Can we maybe just simplify this.\n\nPowerVM has a feature called vNIC which can be tied with SR-IOV.  By using vNIC, the following use cases are supported:\n - Fail over I/O to a different I/O Server and physical function\n - Live Migration with SR-IOV, without significant intervention\n\nThe vNIC is exposed to the VM, and the mac address of the client vNIC will match the neutron port.","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":52,"context_line":"core nova for SR-IOV, however if that does not land in Newton then the work"},{"line_number":53,"context_line":"here will still continue without live migration support until Ocata."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Based on PowerVM firmware design, VF(s) can be associated with a vNIC"},{"line_number":56,"context_line":"server on VIOS and it is subsequently associated with vNIC client interface on"},{"line_number":57,"context_line":"a VM. This intermediary vNIC is a mandatory requirement to support migration"},{"line_number":58,"context_line":"of such a VM from host to host. This intermediary is also needed to support"},{"line_number":59,"context_line":"redundancy/failover across VFs. For setting up redundancy, n-number of SR-IOV"},{"line_number":60,"context_line":"Physical Ports have to be provided to pypowervm layer and VFs and vNIC servers"},{"line_number":61,"context_line":"will be carved out of them and connected to vNIC client adapter on VM. All VFs"},{"line_number":62,"context_line":"attached to a vNIC will carry same mac address and will be represented by one"},{"line_number":63,"context_line":"neutron port."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"In summary, this blueprint will solve support of SR-IOV in nova-powervm for"},{"line_number":66,"context_line":"these scenarios:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_554ba72b","line":63,"range":{"start_line":55,"start_character":0,"end_line":63,"end_character":13},"in_reply_to":"dada55a8_2243ad14","updated":"2016-08-08 13:47:10.000000000","message":"Done","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"In summary, this blueprint will solve support of SR-IOV in nova-powervm for"},{"line_number":66,"context_line":"these scenarios:"},{"line_number":67,"context_line":"1. Ability to associate a SR-IOV VF to a VM as a network interface"},{"line_number":68,"context_line":"using vNIC intermediary during and after deployment, including migration."},{"line_number":69,"context_line":"2. Ability to provide redundancy/failover support across VFs from Physical"},{"line_number":70,"context_line":"Ports within or across SR-IOV cards using vNIC intermediary."}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_e26355af","line":67,"range":{"start_line":67,"start_character":14,"end_line":67,"end_character":23},"updated":"2016-07-26 23:05:05.000000000","message":"attach/detach","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"In summary, this blueprint will solve support of SR-IOV in nova-powervm for"},{"line_number":66,"context_line":"these scenarios:"},{"line_number":67,"context_line":"1. Ability to associate a SR-IOV VF to a VM as a network interface"},{"line_number":68,"context_line":"using vNIC intermediary during and after deployment, including migration."},{"line_number":69,"context_line":"2. Ability to provide redundancy/failover support across VFs from Physical"},{"line_number":70,"context_line":"Ports within or across SR-IOV cards using vNIC intermediary."}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_75522bdf","line":67,"range":{"start_line":67,"start_character":14,"end_line":67,"end_character":23},"in_reply_to":"dada55a8_e26355af","updated":"2016-08-08 13:47:10.000000000","message":"Done","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Ability to associate a SR-IOV VF directly to a VM will be done in future."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Refer to separate blueprint for networking-powervm for changes in PowerVM"},{"line_number":76,"context_line":"neutron networking component. This blueprint will focus on changes to"},{"line_number":77,"context_line":"nova-powervm only. Refer to https://review.openstack.org/#/c/322210/ for"},{"line_number":78,"context_line":"review of networking-powervm blueprint."},{"line_number":79,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_8273797f","line":76,"range":{"start_line":75,"start_character":66,"end_line":76,"end_character":18},"updated":"2016-07-26 23:05:05.000000000","message":"networking-powervm","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Ability to associate a SR-IOV VF directly to a VM will be done in future."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Refer to separate blueprint for networking-powervm for changes in PowerVM"},{"line_number":76,"context_line":"neutron networking component. This blueprint will focus on changes to"},{"line_number":77,"context_line":"nova-powervm only. Refer to https://review.openstack.org/#/c/322210/ for"},{"line_number":78,"context_line":"review of networking-powervm blueprint."},{"line_number":79,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_75698b8b","line":76,"range":{"start_line":75,"start_character":66,"end_line":76,"end_character":18},"in_reply_to":"dada55a8_8273797f","updated":"2016-08-08 13:47:10.000000000","message":"Done","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":83,"context_line":"2. Attach vNIC backed by SR-IOV VF(s) to a VM after it is deployed"},{"line_number":84,"context_line":"3. Detach vNIC backed by SR-IOV VF(s) from a VM"},{"line_number":85,"context_line":"4. When a VM with vNIC backed by SR-IOV is deleted, perform detach and cleanup"},{"line_number":86,"context_line":"5. Live migrate a VM if using vNIC backed SR-IOV support (assuming core support"},{"line_number":87,"context_line":"is in Newton)"},{"line_number":88,"context_line":"6. Provide redundancy/failover support of vNIC backed by SR-IOV VF attached to"},{"line_number":89,"context_line":"a VM during both deploy and post deploy scenarios."},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_62f765d3","line":87,"range":{"start_line":86,"start_character":57,"end_line":87,"end_character":13},"updated":"2016-07-26 23:05:05.000000000","message":"Given the new function where we will be deriving things from port labels...are we dependent on SR-IOV Live Migration coming in from Nova?\n\nAlso, given the time of the release, can we get a pulse on whether or not live migration with SR-IOV came in?  Is it done?  We should be able to tell if its punted.","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":83,"context_line":"2. Attach vNIC backed by SR-IOV VF(s) to a VM after it is deployed"},{"line_number":84,"context_line":"3. Detach vNIC backed by SR-IOV VF(s) from a VM"},{"line_number":85,"context_line":"4. When a VM with vNIC backed by SR-IOV is deleted, perform detach and cleanup"},{"line_number":86,"context_line":"5. Live migrate a VM if using vNIC backed SR-IOV support (assuming core support"},{"line_number":87,"context_line":"is in Newton)"},{"line_number":88,"context_line":"6. Provide redundancy/failover support of vNIC backed by SR-IOV VF attached to"},{"line_number":89,"context_line":"a VM during both deploy and post deploy scenarios."},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_95035fb8","line":87,"range":{"start_line":86,"start_character":57,"end_line":87,"end_character":13},"in_reply_to":"dada55a8_62f765d3","updated":"2016-08-08 13:47:10.000000000","message":"We will not be dependent on nova for migration. Adjusted this sentence.","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":93,"context_line":"The changes will be made in two areas:"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"1. Compute virt driver."},{"line_number":96,"context_line":"PowerVM compute driver is in nova.virt.powervm.driver.PowerVMDriver"},{"line_number":97,"context_line":"and it will be enhanced for SR-IOV VF support. Changes in compute driver will"},{"line_number":98,"context_line":"be limited to invocation of vif driver based on required network connectivity."},{"line_number":99,"context_line":"pypowervm enhancements for vNIC will be required. pypowervm will offer"},{"line_number":100,"context_line":"functions to manage SR-IOV adapters and ports and vNIC."}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_e2bfd5cd","line":97,"range":{"start_line":96,"start_character":0,"end_line":97,"end_character":45},"updated":"2016-07-26 23:05:05.000000000","message":"I don\u0027t understand what changes actually go in the driver...versus the vif driver.","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"1. Compute virt driver."},{"line_number":96,"context_line":"PowerVM compute driver is in nova.virt.powervm.driver.PowerVMDriver"},{"line_number":97,"context_line":"and it will be enhanced for SR-IOV VF support. Changes in compute driver will"},{"line_number":98,"context_line":"be limited to invocation of vif driver based on required network connectivity."},{"line_number":99,"context_line":"pypowervm enhancements for vNIC will be required. pypowervm will offer"},{"line_number":100,"context_line":"functions to manage SR-IOV adapters and ports and vNIC."}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_e2d87555","line":97,"range":{"start_line":97,"start_character":35,"end_line":97,"end_character":45},"updated":"2016-07-26 23:05:05.000000000","message":"vNIC?","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":93,"context_line":"The changes will be made in two areas:"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"1. Compute virt driver."},{"line_number":96,"context_line":"PowerVM compute driver is in nova.virt.powervm.driver.PowerVMDriver"},{"line_number":97,"context_line":"and it will be enhanced for SR-IOV VF support. Changes in compute driver will"},{"line_number":98,"context_line":"be limited to invocation of vif driver based on required network connectivity."},{"line_number":99,"context_line":"pypowervm enhancements for vNIC will be required. pypowervm will offer"},{"line_number":100,"context_line":"functions to manage SR-IOV adapters and ports and vNIC."}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_f5b8dbe7","line":97,"range":{"start_line":96,"start_character":0,"end_line":97,"end_character":45},"in_reply_to":"dada55a8_e2bfd5cd","updated":"2016-08-08 13:47:10.000000000","message":"I am referring to maintenance of dictionary of vif type vs vif driver classes. When a plug operation is needed, appropriate vif driver is invoked. Change is needed in this dictionary to add additional vif driver.","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"1. Compute virt driver."},{"line_number":96,"context_line":"PowerVM compute driver is in nova.virt.powervm.driver.PowerVMDriver"},{"line_number":97,"context_line":"and it will be enhanced for SR-IOV VF support. Changes in compute driver will"},{"line_number":98,"context_line":"be limited to invocation of vif driver based on required network connectivity."},{"line_number":99,"context_line":"pypowervm enhancements for vNIC will be required. pypowervm will offer"},{"line_number":100,"context_line":"functions to manage SR-IOV adapters and ports and vNIC."},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_22df2d3b","line":98,"range":{"start_line":97,"start_character":47,"end_line":98,"end_character":78},"updated":"2016-07-26 23:05:05.000000000","message":"I don\u0027t really get this sentence.","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"1. Compute virt driver."},{"line_number":96,"context_line":"PowerVM compute driver is in nova.virt.powervm.driver.PowerVMDriver"},{"line_number":97,"context_line":"and it will be enhanced for SR-IOV VF support. Changes in compute driver will"},{"line_number":98,"context_line":"be limited to invocation of vif driver based on required network connectivity."},{"line_number":99,"context_line":"pypowervm enhancements for vNIC will be required. pypowervm will offer"},{"line_number":100,"context_line":"functions to manage SR-IOV adapters and ports and vNIC."},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_35c71347","line":98,"range":{"start_line":97,"start_character":47,"end_line":98,"end_character":78},"in_reply_to":"dada55a8_22df2d3b","updated":"2016-08-08 13:47:10.000000000","message":"Removed.","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":96,"context_line":"PowerVM compute driver is in nova.virt.powervm.driver.PowerVMDriver"},{"line_number":97,"context_line":"and it will be enhanced for SR-IOV VF support. Changes in compute driver will"},{"line_number":98,"context_line":"be limited to invocation of vif driver based on required network connectivity."},{"line_number":99,"context_line":"pypowervm enhancements for vNIC will be required. pypowervm will offer"},{"line_number":100,"context_line":"functions to manage SR-IOV adapters and ports and vNIC."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"2. VIF driver."},{"line_number":103,"context_line":"PowerVM VIF driver is in nova_powervm.virt.powervm.vif.PvmVifDriver. A VIF"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_82e899e3","line":100,"range":{"start_line":99,"start_character":0,"end_line":100,"end_character":55},"updated":"2016-07-26 23:05:05.000000000","message":"I don\u0027t think this is needed...these changes are done aren\u0027t they?","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":96,"context_line":"PowerVM compute driver is in nova.virt.powervm.driver.PowerVMDriver"},{"line_number":97,"context_line":"and it will be enhanced for SR-IOV VF support. Changes in compute driver will"},{"line_number":98,"context_line":"be limited to invocation of vif driver based on required network connectivity."},{"line_number":99,"context_line":"pypowervm enhancements for vNIC will be required. pypowervm will offer"},{"line_number":100,"context_line":"functions to manage SR-IOV adapters and ports and vNIC."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"2. VIF driver."},{"line_number":103,"context_line":"PowerVM VIF driver is in nova_powervm.virt.powervm.vif.PvmVifDriver. A VIF"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_75c18b2e","line":100,"range":{"start_line":99,"start_character":0,"end_line":100,"end_character":55},"in_reply_to":"dada55a8_82e899e3","updated":"2016-08-08 13:47:10.000000000","message":"Removed.","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Deployment of VM with SR-IOV vNIC will involve picking Physical Port(s),"},{"line_number":114,"context_line":"VIOS(es) and a VM and invoking pypowervm library. Similarly, attachment"},{"line_number":115,"context_line":"of the same to an existing VM will be implemented. Evacuate and migration of"},{"line_number":116,"context_line":"VM will be supported with changes to compute virt driver and VIF driver via"},{"line_number":117,"context_line":"pypowervm library."},{"line_number":118,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_82cff97d","line":115,"updated":"2016-07-26 23:05:05.000000000","message":"Is RMC a requirement when you attach to an existing one?","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Deployment of VM with SR-IOV vNIC will involve picking Physical Port(s),"},{"line_number":114,"context_line":"VIOS(es) and a VM and invoking pypowervm library. Similarly, attachment"},{"line_number":115,"context_line":"of the same to an existing VM will be implemented. Evacuate and migration of"},{"line_number":116,"context_line":"VM will be supported with changes to compute virt driver and VIF driver via"},{"line_number":117,"context_line":"pypowervm library."},{"line_number":118,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_55d1e7fa","line":115,"in_reply_to":"dada55a8_82cff97d","updated":"2016-08-08 13:47:10.000000000","message":"Done","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":116,"context_line":"VM will be supported with changes to compute virt driver and VIF driver via"},{"line_number":117,"context_line":"pypowervm library."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Physical Port information will be derived from port label attribute of"},{"line_number":120,"context_line":"physical ports on SR-IOV adapters. Port label attribute of physical ports"},{"line_number":121,"context_line":"will have to be updated with \u0027physical network\u0027 names during configuration"},{"line_number":122,"context_line":"of the environment. During attachment of SR-IOV backed vNIC to a VM,"},{"line_number":123,"context_line":"physical network attribute of neutron network will be matched with port"},{"line_number":124,"context_line":"labels of physical ports to gather a list of physical ports."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"For future implementation of VF - VM attach path, redundancy will still be"},{"line_number":127,"context_line":"achievable with NIB at VM level."}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_8296d949","line":124,"range":{"start_line":119,"start_character":0,"end_line":124,"end_character":60},"updated":"2016-07-26 23:05:05.000000000","message":"Are the physical networks available?","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":116,"context_line":"VM will be supported with changes to compute virt driver and VIF driver via"},{"line_number":117,"context_line":"pypowervm library."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Physical Port information will be derived from port label attribute of"},{"line_number":120,"context_line":"physical ports on SR-IOV adapters. Port label attribute of physical ports"},{"line_number":121,"context_line":"will have to be updated with \u0027physical network\u0027 names during configuration"},{"line_number":122,"context_line":"of the environment. During attachment of SR-IOV backed vNIC to a VM,"},{"line_number":123,"context_line":"physical network attribute of neutron network will be matched with port"},{"line_number":124,"context_line":"labels of physical ports to gather a list of physical ports."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"For future implementation of VF - VM attach path, redundancy will still be"},{"line_number":127,"context_line":"achievable with NIB at VM level."}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_59cbe172","line":124,"range":{"start_line":119,"start_character":0,"end_line":124,"end_character":60},"in_reply_to":"dada55a8_8296d949","updated":"2016-08-08 13:47:10.000000000","message":"Physical network is available in neutron network object and also the same to be matched with port label on physical port.","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":123,"context_line":"physical network attribute of neutron network will be matched with port"},{"line_number":124,"context_line":"labels of physical ports to gather a list of physical ports."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"For future implementation of VF - VM attach path, redundancy will still be"},{"line_number":127,"context_line":"achievable with NIB at VM level."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Regarding failover/redundancy, VIF plug during deploy (or attach of network"},{"line_number":130,"context_line":"interface to a VM) will pass more than one Physical port and VIOS(es)"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_6293e55b","line":127,"range":{"start_line":126,"start_character":0,"end_line":127,"end_character":32},"updated":"2016-07-26 23:05:05.000000000","message":"What is this...","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":123,"context_line":"physical network attribute of neutron network will be matched with port"},{"line_number":124,"context_line":"labels of physical ports to gather a list of physical ports."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"For future implementation of VF - VM attach path, redundancy will still be"},{"line_number":127,"context_line":"achievable with NIB at VM level."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Regarding failover/redundancy, VIF plug during deploy (or attach of network"},{"line_number":130,"context_line":"interface to a VM) will pass more than one Physical port and VIOS(es)"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_d52af7e6","line":127,"range":{"start_line":126,"start_character":0,"end_line":127,"end_character":32},"in_reply_to":"dada55a8_6293e55b","updated":"2016-08-08 13:47:10.000000000","message":"Removed.","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":130,"context_line":"interface to a VM) will pass more than one Physical port and VIOS(es)"},{"line_number":131,"context_line":"(as stated above in deploy scenario) to pypowervm library to create vNIC on"},{"line_number":132,"context_line":"VIOS with redundancy. It should be noted that failover is handled automatically"},{"line_number":133,"context_line":"by the platform when a vNIC is backed by multiple VFs. To control redundancy a"},{"line_number":134,"context_line":"combination of data elements will be used. There will be an implementation of"},{"line_number":135,"context_line":"default policy that will determine appropriate minimum and maximum redundancy"},{"line_number":136,"context_line":"based on number of SR-IOV cards, number of VIOSes and number of physical ports"},{"line_number":137,"context_line":"from port label of physical ports(NPP) and also is"},{"line_number":138,"context_line":"required_redundancy_level(RRL) from nova configuration. In powervm section in"},{"line_number":139,"context_line":"nova configuration, a new property called vnic_required_vfs will be added with"},{"line_number":140,"context_line":"default value of 2 to represent RRL. If redundancy is not needed, this property"},{"line_number":141,"context_line":"should be set to 1. If RRL is specified, it should be a number between 1 and"},{"line_number":142,"context_line":"NPP. RRL configuration option will be applied to all VMs created by the given"},{"line_number":143,"context_line":"compute driver invocation.  There will be one neutron port created for"},{"line_number":144,"context_line":"redundancy. There will be an implementation of default policy that will"},{"line_number":145,"context_line":"determine appropriate minimum and maximum redundancy based on number of SR-IOV"},{"line_number":146,"context_line":"cards, number of VIOSes and number of physical ports."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"For future implementation of VF - VM direct attach of SR-IOV to a VM, the"},{"line_number":149,"context_line":"request will include physical network name. PvmVFSriovVifDriver can lookup"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_e294f537","line":146,"range":{"start_line":133,"start_character":55,"end_line":146,"end_character":53},"updated":"2016-07-26 23:05:05.000000000","message":"Can we just say that the redundancy level will be controlled by a conf file in the [powervm] section of nova configuration.  It will have a default of 2.","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":130,"context_line":"interface to a VM) will pass more than one Physical port and VIOS(es)"},{"line_number":131,"context_line":"(as stated above in deploy scenario) to pypowervm library to create vNIC on"},{"line_number":132,"context_line":"VIOS with redundancy. It should be noted that failover is handled automatically"},{"line_number":133,"context_line":"by the platform when a vNIC is backed by multiple VFs. To control redundancy a"},{"line_number":134,"context_line":"combination of data elements will be used. There will be an implementation of"},{"line_number":135,"context_line":"default policy that will determine appropriate minimum and maximum redundancy"},{"line_number":136,"context_line":"based on number of SR-IOV cards, number of VIOSes and number of physical ports"},{"line_number":137,"context_line":"from port label of physical ports(NPP) and also is"},{"line_number":138,"context_line":"required_redundancy_level(RRL) from nova configuration. In powervm section in"},{"line_number":139,"context_line":"nova configuration, a new property called vnic_required_vfs will be added with"},{"line_number":140,"context_line":"default value of 2 to represent RRL. If redundancy is not needed, this property"},{"line_number":141,"context_line":"should be set to 1. If RRL is specified, it should be a number between 1 and"},{"line_number":142,"context_line":"NPP. RRL configuration option will be applied to all VMs created by the given"},{"line_number":143,"context_line":"compute driver invocation.  There will be one neutron port created for"},{"line_number":144,"context_line":"redundancy. There will be an implementation of default policy that will"},{"line_number":145,"context_line":"determine appropriate minimum and maximum redundancy based on number of SR-IOV"},{"line_number":146,"context_line":"cards, number of VIOSes and number of physical ports."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"For future implementation of VF - VM direct attach of SR-IOV to a VM, the"},{"line_number":149,"context_line":"request will include physical network name. PvmVFSriovVifDriver can lookup"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_f539fb42","line":146,"range":{"start_line":133,"start_character":55,"end_line":146,"end_character":53},"in_reply_to":"dada55a8_e294f537","updated":"2016-08-08 13:47:10.000000000","message":"Done","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":149,"context_line":"request will include physical network name. PvmVFSriovVifDriver can lookup"},{"line_number":150,"context_line":"devname(s) associated with it from port label, get physical port information"},{"line_number":151,"context_line":"and create a SR-IOV logical port on the corresponding VM. If there are multiple"},{"line_number":152,"context_line":"devnames returned as many SR-IOV logical ports will be attached to the VM."},{"line_number":153,"context_line":"Or may include a configuration option to allow the user to dictate how many"},{"line_number":154,"context_line":"ports to attach. Using NIB technique, users can setup redundancy."},{"line_number":155,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_e2bb55c2","line":152,"range":{"start_line":152,"start_character":0,"end_line":152,"end_character":8},"updated":"2016-07-26 23:05:05.000000000","message":"I don\u0027t understand this.  How would it decide to attach multiple devices to the VM?  I think a direct VF will attach exactly one element to a VM.  No redundancy.","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":149,"context_line":"request will include physical network name. PvmVFSriovVifDriver can lookup"},{"line_number":150,"context_line":"devname(s) associated with it from port label, get physical port information"},{"line_number":151,"context_line":"and create a SR-IOV logical port on the corresponding VM. If there are multiple"},{"line_number":152,"context_line":"devnames returned as many SR-IOV logical ports will be attached to the VM."},{"line_number":153,"context_line":"Or may include a configuration option to allow the user to dictate how many"},{"line_number":154,"context_line":"ports to attach. Using NIB technique, users can setup redundancy."},{"line_number":155,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_9577df01","line":152,"range":{"start_line":152,"start_character":0,"end_line":152,"end_character":8},"in_reply_to":"dada55a8_e2bb55c2","updated":"2016-08-08 13:47:10.000000000","message":"Removed this line.","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":153,"context_line":"Or may include a configuration option to allow the user to dictate how many"},{"line_number":154,"context_line":"ports to attach. Using NIB technique, users can setup redundancy."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"For VF - vNIC - VM attach of SR-IOV port to a VM, the request will include"},{"line_number":157,"context_line":"physical network name, PvmVnicSriovVifDriver can lookup devname(s) associated"},{"line_number":158,"context_line":"with it from port label, get physical port information. Along with adapter"},{"line_number":159,"context_line":"ID and physical port ID, VIOS information will be"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_e2e235d4","line":156,"range":{"start_line":156,"start_character":54,"end_line":156,"end_character":61},"updated":"2016-07-26 23:05:05.000000000","message":"What request?  The vif request?  I don\u0027t understand how this would be achieved...","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":153,"context_line":"Or may include a configuration option to allow the user to dictate how many"},{"line_number":154,"context_line":"ports to attach. Using NIB technique, users can setup redundancy."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"For VF - vNIC - VM attach of SR-IOV port to a VM, the request will include"},{"line_number":157,"context_line":"physical network name, PvmVnicSriovVifDriver can lookup devname(s) associated"},{"line_number":158,"context_line":"with it from port label, get physical port information. Along with adapter"},{"line_number":159,"context_line":"ID and physical port ID, VIOS information will be"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_d5bb1774","line":156,"range":{"start_line":156,"start_character":54,"end_line":156,"end_character":61},"in_reply_to":"dada55a8_e2e235d4","updated":"2016-08-08 13:47:10.000000000","message":"Changed to neutron network object.","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":179,"context_line":"Performance impact"},{"line_number":180,"context_line":"------------------"},{"line_number":181,"context_line":"Since the number of VMs deployed on the host will depend on number of VFs"},{"line_number":182,"context_line":"offered by SR-IOV cards in the environment, scale tests will involve less"},{"line_number":183,"context_line":"number of VMs."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"Deployer impact"},{"line_number":186,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_82d259fe","line":183,"range":{"start_line":182,"start_character":61,"end_line":183,"end_character":14},"updated":"2016-07-26 23:05:05.000000000","message":"be limited in density of VMs.","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":179,"context_line":"Performance impact"},{"line_number":180,"context_line":"------------------"},{"line_number":181,"context_line":"Since the number of VMs deployed on the host will depend on number of VFs"},{"line_number":182,"context_line":"offered by SR-IOV cards in the environment, scale tests will involve less"},{"line_number":183,"context_line":"number of VMs."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"Deployer impact"},{"line_number":186,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_d5495790","line":183,"range":{"start_line":182,"start_character":61,"end_line":183,"end_character":14},"in_reply_to":"dada55a8_82d259fe","updated":"2016-08-08 13:47:10.000000000","message":"Done","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"Assignee(s)"},{"line_number":206,"context_line":"-----------"},{"line_number":207,"context_line":"Eric Fried"},{"line_number":208,"context_line":"Andrew Thorstensen"},{"line_number":209,"context_line":"Sridhar Venkat"},{"line_number":210,"context_line":"Eric Larese"},{"line_number":211,"context_line":"Esha Seth"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_42fb417b","line":208,"range":{"start_line":207,"start_character":0,"end_line":208,"end_character":18},"updated":"2016-07-26 23:05:05.000000000","message":"Eric Fried (efried)\nDrew Thorstensen (thorst)\n\nI can be last...as I think I have the least involvement here.","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"Assignee(s)"},{"line_number":206,"context_line":"-----------"},{"line_number":207,"context_line":"Eric Fried"},{"line_number":208,"context_line":"Andrew Thorstensen"},{"line_number":209,"context_line":"Sridhar Venkat"},{"line_number":210,"context_line":"Eric Larese"},{"line_number":211,"context_line":"Esha Seth"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_b535c3f8","line":208,"range":{"start_line":207,"start_character":0,"end_line":208,"end_character":18},"in_reply_to":"dada55a8_42fb417b","updated":"2016-08-08 13:47:10.000000000","message":"Done","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":213,"context_line":"Work Items"},{"line_number":214,"context_line":"----------"},{"line_number":215,"context_line":"nova-powervm changes:"},{"line_number":216,"context_line":"Updates to PowerVM compute driver to support attachment of SR-IOV VF via vNIC."},{"line_number":217,"context_line":"VIF driver for SR-IOV VF connected to VM via vNIC."},{"line_number":218,"context_line":"Migration of VM with SR-IOV VF connected to VM via vNIC. This involves"},{"line_number":219,"context_line":"live migration, cold migration and evacuation."}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_62f64590","line":216,"range":{"start_line":216,"start_character":0,"end_line":216,"end_character":78},"updated":"2016-07-26 23:05:05.000000000","message":"Still not clear to me what these are.","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":213,"context_line":"Work Items"},{"line_number":214,"context_line":"----------"},{"line_number":215,"context_line":"nova-powervm changes:"},{"line_number":216,"context_line":"Updates to PowerVM compute driver to support attachment of SR-IOV VF via vNIC."},{"line_number":217,"context_line":"VIF driver for SR-IOV VF connected to VM via vNIC."},{"line_number":218,"context_line":"Migration of VM with SR-IOV VF connected to VM via vNIC. This involves"},{"line_number":219,"context_line":"live migration, cold migration and evacuation."}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_f9fe1504","line":216,"range":{"start_line":216,"start_character":0,"end_line":216,"end_character":78},"in_reply_to":"dada55a8_62f64590","updated":"2016-08-08 13:47:10.000000000","message":"As described above, this is only to invoke appropriate vif driver based on vif type.","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":217,"context_line":"VIF driver for SR-IOV VF connected to VM via vNIC."},{"line_number":218,"context_line":"Migration of VM with SR-IOV VF connected to VM via vNIC. This involves"},{"line_number":219,"context_line":"live migration, cold migration and evacuation."},{"line_number":220,"context_line":"Failover/redundancy support for SR-IOV VF(s) connected to VM via vNIC(s)."},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"VIF driver for SR-IOV VF connected to VM directly will be a future work item."},{"line_number":223,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_c2ef31af","line":220,"range":{"start_line":220,"start_character":0,"end_line":220,"end_character":3},"updated":"2016-07-26 23:05:05.000000000","message":"Dashes for each item would be nice.","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":217,"context_line":"VIF driver for SR-IOV VF connected to VM via vNIC."},{"line_number":218,"context_line":"Migration of VM with SR-IOV VF connected to VM via vNIC. This involves"},{"line_number":219,"context_line":"live migration, cold migration and evacuation."},{"line_number":220,"context_line":"Failover/redundancy support for SR-IOV VF(s) connected to VM via vNIC(s)."},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"VIF driver for SR-IOV VF connected to VM directly will be a future work item."},{"line_number":223,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_d92a317e","line":220,"range":{"start_line":220,"start_character":0,"end_line":220,"end_character":3},"in_reply_to":"dada55a8_c2ef31af","updated":"2016-08-08 13:47:10.000000000","message":"Done","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":226,"context_line":"1. Unit test"},{"line_number":227,"context_line":"All developed code will accompany structured unit test around them. These"},{"line_number":228,"context_line":"tests validate granular function logic."},{"line_number":229,"context_line":"2. Function test"},{"line_number":230,"context_line":"Function test will be performed along with CI infrastructure.  Changes"},{"line_number":231,"context_line":"implemented for this blueprint will be tested via CI framework that exists"},{"line_number":232,"context_line":"and used by IBM team. CI framework needs to be enhanced with SR-IOV hardware."}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_a2ecbdbb","line":229,"updated":"2016-07-26 23:05:05.000000000","message":"Space.","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":226,"context_line":"1. Unit test"},{"line_number":227,"context_line":"All developed code will accompany structured unit test around them. These"},{"line_number":228,"context_line":"tests validate granular function logic."},{"line_number":229,"context_line":"2. Function test"},{"line_number":230,"context_line":"Function test will be performed along with CI infrastructure.  Changes"},{"line_number":231,"context_line":"implemented for this blueprint will be tested via CI framework that exists"},{"line_number":232,"context_line":"and used by IBM team. CI framework needs to be enhanced with SR-IOV hardware."}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_793a25cf","line":229,"in_reply_to":"dada55a8_a2ecbdbb","updated":"2016-08-08 13:47:10.000000000","message":"Done","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"Glossary"},{"line_number":274,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":275,"context_line":"1.SR-IOV - Single Root I/O Virtualization, used for virtual environments where"},{"line_number":276,"context_line":"VMs need direct access to network interface without any hypervisor overheads."},{"line_number":277,"context_line":"2.Physical Port - Represents Physical port in SR-IOV adapter. This is not same"},{"line_number":278,"context_line":"as Physical Function. A Physical Port can have many physical functions"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_a22e7d89","line":275,"updated":"2016-07-26 23:05:05.000000000","message":"Missing spaces after several periods","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"Glossary"},{"line_number":274,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":275,"context_line":"1.SR-IOV - Single Root I/O Virtualization, used for virtual environments where"},{"line_number":276,"context_line":"VMs need direct access to network interface without any hypervisor overheads."},{"line_number":277,"context_line":"2.Physical Port - Represents Physical port in SR-IOV adapter. This is not same"},{"line_number":278,"context_line":"as Physical Function. A Physical Port can have many physical functions"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_9931d9ef","line":275,"in_reply_to":"dada55a8_a22e7d89","updated":"2016-08-08 13:47:10.000000000","message":"Done","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":273,"context_line":"Glossary"},{"line_number":274,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":275,"context_line":"1.SR-IOV - Single Root I/O Virtualization, used for virtual environments where"},{"line_number":276,"context_line":"VMs need direct access to network interface without any hypervisor overheads."},{"line_number":277,"context_line":"2.Physical Port - Represents Physical port in SR-IOV adapter. This is not same"},{"line_number":278,"context_line":"as Physical Function. A Physical Port can have many physical functions"},{"line_number":279,"context_line":"associated with it. To clarify further, if a Physical Port supports RCoE, then"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_623805d4","line":276,"updated":"2016-07-26 23:05:05.000000000","message":"can you put new lines next to each of these items?","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":273,"context_line":"Glossary"},{"line_number":274,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":275,"context_line":"1.SR-IOV - Single Root I/O Virtualization, used for virtual environments where"},{"line_number":276,"context_line":"VMs need direct access to network interface without any hypervisor overheads."},{"line_number":277,"context_line":"2.Physical Port - Represents Physical port in SR-IOV adapter. This is not same"},{"line_number":278,"context_line":"as Physical Function. A Physical Port can have many physical functions"},{"line_number":279,"context_line":"associated with it. To clarify further, if a Physical Port supports RCoE, then"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_d9519110","line":276,"in_reply_to":"dada55a8_623805d4","updated":"2016-08-08 13:47:10.000000000","message":"Done","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":279,"context_line":"associated with it. To clarify further, if a Physical Port supports RCoE, then"},{"line_number":280,"context_line":"it will have two Physical Functions. In other words, one Physical Function per"},{"line_number":281,"context_line":"protocol that port supports."},{"line_number":282,"context_line":"3.VF - Represents Virtual port belonging to a specific PF. Either directly or"},{"line_number":283,"context_line":"indirectly (using vNIC) a VF is connected to a VM. This is otherwise called"},{"line_number":284,"context_line":"SR-IOV logical port."},{"line_number":285,"context_line":"4. Dedicated SR-IOV - This is equivalent to any regular ethernet card and it"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_22372d4e","line":282,"range":{"start_line":282,"start_character":2,"end_line":282,"end_character":4},"updated":"2016-07-26 23:05:05.000000000","message":"Virtual Function (VF)","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":279,"context_line":"associated with it. To clarify further, if a Physical Port supports RCoE, then"},{"line_number":280,"context_line":"it will have two Physical Functions. In other words, one Physical Function per"},{"line_number":281,"context_line":"protocol that port supports."},{"line_number":282,"context_line":"3.VF - Represents Virtual port belonging to a specific PF. Either directly or"},{"line_number":283,"context_line":"indirectly (using vNIC) a VF is connected to a VM. This is otherwise called"},{"line_number":284,"context_line":"SR-IOV logical port."},{"line_number":285,"context_line":"4. Dedicated SR-IOV - This is equivalent to any regular ethernet card and it"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_4232215f","line":282,"range":{"start_line":282,"start_character":55,"end_line":282,"end_character":57},"updated":"2016-07-26 23:05:05.000000000","message":"You never define PF.","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":279,"context_line":"associated with it. To clarify further, if a Physical Port supports RCoE, then"},{"line_number":280,"context_line":"it will have two Physical Functions. In other words, one Physical Function per"},{"line_number":281,"context_line":"protocol that port supports."},{"line_number":282,"context_line":"3.VF - Represents Virtual port belonging to a specific PF. Either directly or"},{"line_number":283,"context_line":"indirectly (using vNIC) a VF is connected to a VM. This is otherwise called"},{"line_number":284,"context_line":"SR-IOV logical port."},{"line_number":285,"context_line":"4. Dedicated SR-IOV - This is equivalent to any regular ethernet card and it"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_d9ed1127","line":282,"range":{"start_line":282,"start_character":2,"end_line":282,"end_character":4},"in_reply_to":"dada55a8_22372d4e","updated":"2016-08-08 13:47:10.000000000","message":"Done","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":279,"context_line":"associated with it. To clarify further, if a Physical Port supports RCoE, then"},{"line_number":280,"context_line":"it will have two Physical Functions. In other words, one Physical Function per"},{"line_number":281,"context_line":"protocol that port supports."},{"line_number":282,"context_line":"3.VF - Represents Virtual port belonging to a specific PF. Either directly or"},{"line_number":283,"context_line":"indirectly (using vNIC) a VF is connected to a VM. This is otherwise called"},{"line_number":284,"context_line":"SR-IOV logical port."},{"line_number":285,"context_line":"4. Dedicated SR-IOV - This is equivalent to any regular ethernet card and it"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_59dac179","line":282,"range":{"start_line":282,"start_character":55,"end_line":282,"end_character":57},"in_reply_to":"dada55a8_4232215f","updated":"2016-08-08 13:47:10.000000000","message":"Done","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":283,"context_line":"indirectly (using vNIC) a VF is connected to a VM. This is otherwise called"},{"line_number":284,"context_line":"SR-IOV logical port."},{"line_number":285,"context_line":"4. Dedicated SR-IOV - This is equivalent to any regular ethernet card and it"},{"line_number":286,"context_line":"can be used with SEA and in this sense, it is supported."},{"line_number":287,"context_line":"5. Shared SR-IOV - A VF to VM is not supported in Newton release. But an"},{"line_number":288,"context_line":"SR-IOV card in Sriov mode is what we will be used for vNIC as described in"},{"line_number":289,"context_line":"this blueprint. Also, a SR-IOV in Sriov mode can hae a promiscous VF assigned"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_220e0d8c","line":286,"range":{"start_line":286,"start_character":40,"end_line":286,"end_character":56},"updated":"2016-07-26 23:05:05.000000000","message":"The whole card?","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":283,"context_line":"indirectly (using vNIC) a VF is connected to a VM. This is otherwise called"},{"line_number":284,"context_line":"SR-IOV logical port."},{"line_number":285,"context_line":"4. Dedicated SR-IOV - This is equivalent to any regular ethernet card and it"},{"line_number":286,"context_line":"can be used with SEA and in this sense, it is supported."},{"line_number":287,"context_line":"5. Shared SR-IOV - A VF to VM is not supported in Newton release. But an"},{"line_number":288,"context_line":"SR-IOV card in Sriov mode is what we will be used for vNIC as described in"},{"line_number":289,"context_line":"this blueprint. Also, a SR-IOV in Sriov mode can hae a promiscous VF assigned"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_59c12180","line":286,"range":{"start_line":286,"start_character":40,"end_line":286,"end_character":56},"in_reply_to":"dada55a8_220e0d8c","updated":"2016-08-08 13:47:10.000000000","message":"Rephrased this sentence.","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":284,"context_line":"SR-IOV logical port."},{"line_number":285,"context_line":"4. Dedicated SR-IOV - This is equivalent to any regular ethernet card and it"},{"line_number":286,"context_line":"can be used with SEA and in this sense, it is supported."},{"line_number":287,"context_line":"5. Shared SR-IOV - A VF to VM is not supported in Newton release. But an"},{"line_number":288,"context_line":"SR-IOV card in Sriov mode is what we will be used for vNIC as described in"},{"line_number":289,"context_line":"this blueprint. Also, a SR-IOV in Sriov mode can hae a promiscous VF assigned"},{"line_number":290,"context_line":"to the VIOS and configured for SEA(said configuration to be done outside of"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_8227f910","line":287,"range":{"start_line":287,"start_character":3,"end_line":287,"end_character":16},"updated":"2016-07-26 23:05:05.000000000","message":"The whole card?","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":284,"context_line":"SR-IOV logical port."},{"line_number":285,"context_line":"4. Dedicated SR-IOV - This is equivalent to any regular ethernet card and it"},{"line_number":286,"context_line":"can be used with SEA and in this sense, it is supported."},{"line_number":287,"context_line":"5. Shared SR-IOV - A VF to VM is not supported in Newton release. But an"},{"line_number":288,"context_line":"SR-IOV card in Sriov mode is what we will be used for vNIC as described in"},{"line_number":289,"context_line":"this blueprint. Also, a SR-IOV in Sriov mode can hae a promiscous VF assigned"},{"line_number":290,"context_line":"to the VIOS and configured for SEA(said configuration to be done outside of"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_d93071a1","line":287,"range":{"start_line":287,"start_character":3,"end_line":287,"end_character":16},"in_reply_to":"dada55a8_8227f910","updated":"2016-08-08 13:47:10.000000000","message":"No, not whole card. this section describes pick a VF, configure it in promiscuous mode and use it as backing device for SEA.","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":285,"context_line":"4. Dedicated SR-IOV - This is equivalent to any regular ethernet card and it"},{"line_number":286,"context_line":"can be used with SEA and in this sense, it is supported."},{"line_number":287,"context_line":"5. Shared SR-IOV - A VF to VM is not supported in Newton release. But an"},{"line_number":288,"context_line":"SR-IOV card in Sriov mode is what we will be used for vNIC as described in"},{"line_number":289,"context_line":"this blueprint. Also, a SR-IOV in Sriov mode can hae a promiscous VF assigned"},{"line_number":290,"context_line":"to the VIOS and configured for SEA(said configuration to be done outside of"},{"line_number":291,"context_line":"the auspices of OpenStack), which can then be used just like any other SEA"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_c21d71bf","line":288,"range":{"start_line":288,"start_character":15,"end_line":288,"end_character":20},"updated":"2016-07-26 23:05:05.000000000","message":"sriov","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":285,"context_line":"4. Dedicated SR-IOV - This is equivalent to any regular ethernet card and it"},{"line_number":286,"context_line":"can be used with SEA and in this sense, it is supported."},{"line_number":287,"context_line":"5. Shared SR-IOV - A VF to VM is not supported in Newton release. But an"},{"line_number":288,"context_line":"SR-IOV card in Sriov mode is what we will be used for vNIC as described in"},{"line_number":289,"context_line":"this blueprint. Also, a SR-IOV in Sriov mode can hae a promiscous VF assigned"},{"line_number":290,"context_line":"to the VIOS and configured for SEA(said configuration to be done outside of"},{"line_number":291,"context_line":"the auspices of OpenStack), which can then be used just like any other SEA"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_b96c9d9d","line":288,"range":{"start_line":288,"start_character":15,"end_line":288,"end_character":20},"in_reply_to":"dada55a8_c21d71bf","updated":"2016-08-08 13:47:10.000000000","message":"Done","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":291,"context_line":"the auspices of OpenStack), which can then be used just like any other SEA"},{"line_number":292,"context_line":"configuration, and is supported (as described in next item below)."},{"line_number":293,"context_line":"6. Shared Ethernet Adapter - Alternate technique to provide network interface"},{"line_number":294,"context_line":"to a VM."},{"line_number":295,"context_line":"This involves attachment to a physical interface on PowerVM host and one or"},{"line_number":296,"context_line":"many virtual interfaces that are connected to VMs. A VF of PF in SR-IOV based"},{"line_number":297,"context_line":"environment can be a physical interface to Shared Ethernet Adapter. Existing"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_626be51e","line":294,"updated":"2016-07-26 23:05:05.000000000","message":"New line.","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":291,"context_line":"the auspices of OpenStack), which can then be used just like any other SEA"},{"line_number":292,"context_line":"configuration, and is supported (as described in next item below)."},{"line_number":293,"context_line":"6. Shared Ethernet Adapter - Alternate technique to provide network interface"},{"line_number":294,"context_line":"to a VM."},{"line_number":295,"context_line":"This involves attachment to a physical interface on PowerVM host and one or"},{"line_number":296,"context_line":"many virtual interfaces that are connected to VMs. A VF of PF in SR-IOV based"},{"line_number":297,"context_line":"environment can be a physical interface to Shared Ethernet Adapter. Existing"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_192b2932","line":294,"in_reply_to":"dada55a8_626be51e","updated":"2016-08-08 13:47:10.000000000","message":"Done","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":311,"context_line":"10. VM migration types"},{"line_number":312,"context_line":"- Live Migration: migration of VM while both host and VM are alive."},{"line_number":313,"context_line":"- Cold Migration: migration of VM while host is alive and VM is down."},{"line_number":314,"context_line":"- Evacuation: migration of VM while hots is down (VM is down as well)."},{"line_number":315,"context_line":"11. pypowervm - is a python library that runs on the NovaLink management"},{"line_number":316,"context_line":"VM and allows virtualization control of the system. This is similar to"},{"line_number":317,"context_line":"the python library for libvirt."}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_6252c568","line":314,"updated":"2016-07-26 23:05:05.000000000","message":"Rebuild.","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":311,"context_line":"10. VM migration types"},{"line_number":312,"context_line":"- Live Migration: migration of VM while both host and VM are alive."},{"line_number":313,"context_line":"- Cold Migration: migration of VM while host is alive and VM is down."},{"line_number":314,"context_line":"- Evacuation: migration of VM while hots is down (VM is down as well)."},{"line_number":315,"context_line":"11. pypowervm - is a python library that runs on the NovaLink management"},{"line_number":316,"context_line":"VM and allows virtualization control of the system. This is similar to"},{"line_number":317,"context_line":"the python library for libvirt."}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_f9d29533","line":314,"in_reply_to":"dada55a8_6252c568","updated":"2016-08-08 13:47:10.000000000","message":"Done","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"b784a272a3f9e071b6968f8c3e7dcd7101ab934f","unresolved":false,"context_lines":[{"line_number":312,"context_line":"- Live Migration: migration of VM while both host and VM are alive."},{"line_number":313,"context_line":"- Cold Migration: migration of VM while host is alive and VM is down."},{"line_number":314,"context_line":"- Evacuation: migration of VM while hots is down (VM is down as well)."},{"line_number":315,"context_line":"11. pypowervm - is a python library that runs on the NovaLink management"},{"line_number":316,"context_line":"VM and allows virtualization control of the system. This is similar to"},{"line_number":317,"context_line":"the python library for libvirt."},{"line_number":318,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"dada55a8_a2483db4","line":315,"range":{"start_line":315,"start_character":53,"end_line":315,"end_character":61},"updated":"2016-07-26 23:05:05.000000000","message":"PowerVM","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"3edc1761bfab9239c1fd4ca78f1fa4f0de9f4eec","unresolved":false,"context_lines":[{"line_number":312,"context_line":"- Live Migration: migration of VM while both host and VM are alive."},{"line_number":313,"context_line":"- Cold Migration: migration of VM while host is alive and VM is down."},{"line_number":314,"context_line":"- Evacuation: migration of VM while hots is down (VM is down as well)."},{"line_number":315,"context_line":"11. pypowervm - is a python library that runs on the NovaLink management"},{"line_number":316,"context_line":"VM and allows virtualization control of the system. This is similar to"},{"line_number":317,"context_line":"the python library for libvirt."},{"line_number":318,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9ad45d7e_d9d7d121","line":315,"range":{"start_line":315,"start_character":53,"end_line":315,"end_character":61},"in_reply_to":"dada55a8_a2483db4","updated":"2016-08-08 13:47:10.000000000","message":"Done","commit_id":"bf036e47637a02d830c2aa2774337b4b71597760"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4498de32bb258bad8ad79a9e33e31a9478efd6f1","unresolved":false,"context_lines":[{"line_number":41,"context_line":"This management should include migration of VM with SR-IOV vNIC"},{"line_number":42,"context_line":"attached to it."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"PowerVMm has a feature called vNIC which can be tied with SR-IOV. By using"},{"line_number":45,"context_line":"vNIC the following use cases are supported:"},{"line_number":46,"context_line":"- Fail over I/O to a different I/O Server and physical function"},{"line_number":47,"context_line":"- Live Migration with SR-IOV, without significant intervention"}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa7ab95a_783a70e8","line":44,"range":{"start_line":44,"start_character":7,"end_line":44,"end_character":8},"updated":"2016-08-30 13:49:16.000000000","message":"strike","commit_id":"42e19693af538f741342faf53d9d3676f51296dd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5cd42dded31dd08dfad25e58ae95ff923f5a7cf9","unresolved":false,"context_lines":[{"line_number":41,"context_line":"This management should include migration of VM with SR-IOV vNIC"},{"line_number":42,"context_line":"attached to it."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"PowerVMm has a feature called vNIC which can be tied with SR-IOV. By using"},{"line_number":45,"context_line":"vNIC the following use cases are supported:"},{"line_number":46,"context_line":"- Fail over I/O to a different I/O Server and physical function"},{"line_number":47,"context_line":"- Live Migration with SR-IOV, without significant intervention"}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa7ab95a_c1e7aaaa","line":44,"range":{"start_line":44,"start_character":7,"end_line":44,"end_character":8},"in_reply_to":"fa7ab95a_783a70e8","updated":"2016-08-31 16:37:46.000000000","message":"Done","commit_id":"42e19693af538f741342faf53d9d3676f51296dd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4498de32bb258bad8ad79a9e33e31a9478efd6f1","unresolved":false,"context_lines":[{"line_number":80,"context_line":"1. Compute virt driver."},{"line_number":81,"context_line":"PowerVM compute driver is in nova.virt.powervm.driver.PowerVMDriver"},{"line_number":82,"context_line":"and it will be enhanced for SR-IOV vNIC support."},{"line_number":83,"context_line":"There is a dictionary is maintained in virt driver vif code to map between"},{"line_number":84,"context_line":"vif type and vif driver class. Based on vif type of vif object that needs to be"},{"line_number":85,"context_line":"plugged, appropriate vif driver will be invoked. This dictionary will be"},{"line_number":86,"context_line":"modified to include a new vif driver class and its vif type (pvm_sriov)"}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa7ab95a_537aed88","line":83,"range":{"start_line":83,"start_character":0,"end_line":83,"end_character":9},"updated":"2016-08-30 13:49:16.000000000","message":"strike","commit_id":"42e19693af538f741342faf53d9d3676f51296dd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5cd42dded31dd08dfad25e58ae95ff923f5a7cf9","unresolved":false,"context_lines":[{"line_number":80,"context_line":"1. Compute virt driver."},{"line_number":81,"context_line":"PowerVM compute driver is in nova.virt.powervm.driver.PowerVMDriver"},{"line_number":82,"context_line":"and it will be enhanced for SR-IOV vNIC support."},{"line_number":83,"context_line":"There is a dictionary is maintained in virt driver vif code to map between"},{"line_number":84,"context_line":"vif type and vif driver class. Based on vif type of vif object that needs to be"},{"line_number":85,"context_line":"plugged, appropriate vif driver will be invoked. This dictionary will be"},{"line_number":86,"context_line":"modified to include a new vif driver class and its vif type (pvm_sriov)"}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa7ab95a_0102723e","line":83,"range":{"start_line":83,"start_character":0,"end_line":83,"end_character":9},"in_reply_to":"fa7ab95a_537aed88","updated":"2016-08-31 16:37:46.000000000","message":"Done","commit_id":"42e19693af538f741342faf53d9d3676f51296dd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4498de32bb258bad8ad79a9e33e31a9478efd6f1","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Deployment of VM with SR-IOV vNIC will involve picking Physical Port(s),"},{"line_number":100,"context_line":"VIOS(es) and a VM and invoking pypowervm library. Similarly, attachment"},{"line_number":101,"context_line":"of the same to an existing VM will be implemented (RMC will be required)"},{"line_number":102,"context_line":"Evacuate and migration of VM will be supported with changes to compute virt"},{"line_number":103,"context_line":"driver and VIF driver via pypowervm library."},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa7ab95a_937e3568","line":101,"updated":"2016-08-30 13:49:16.000000000","message":"period","commit_id":"42e19693af538f741342faf53d9d3676f51296dd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5cd42dded31dd08dfad25e58ae95ff923f5a7cf9","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Deployment of VM with SR-IOV vNIC will involve picking Physical Port(s),"},{"line_number":100,"context_line":"VIOS(es) and a VM and invoking pypowervm library. Similarly, attachment"},{"line_number":101,"context_line":"of the same to an existing VM will be implemented (RMC will be required)"},{"line_number":102,"context_line":"Evacuate and migration of VM will be supported with changes to compute virt"},{"line_number":103,"context_line":"driver and VIF driver via pypowervm library."},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa7ab95a_41fc7a3e","line":101,"in_reply_to":"fa7ab95a_937e3568","updated":"2016-08-31 16:37:46.000000000","message":"Done","commit_id":"42e19693af538f741342faf53d9d3676f51296dd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4498de32bb258bad8ad79a9e33e31a9478efd6f1","unresolved":false,"context_lines":[{"line_number":113,"context_line":"interface to a VM) will pass more than one Physical port and VIOS(es)"},{"line_number":114,"context_line":"(as stated above in deploy scenario) to pypowervm library to create vNIC on"},{"line_number":115,"context_line":"VIOS with redundancy. It should be noted that failover is handled automatically"},{"line_number":116,"context_line":"by the platform when a vNIC is backed by multiple VFs. The redundancy level"},{"line_number":117,"context_line":"will be controlled by a conf file in the powervm section of nova configuration."},{"line_number":118,"context_line":"It will have a default of 2. The redundancy level will also be controlled by"},{"line_number":119,"context_line":"binding profile data provided at the time of creating \u0027direct\u0027 port. The port"}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa7ab95a_1315c5e3","line":116,"range":{"start_line":116,"start_character":59,"end_line":116,"end_character":69},"updated":"2016-08-30 13:49:16.000000000","message":"capacity should also be mentioned \u0026 briefly explained here","commit_id":"42e19693af538f741342faf53d9d3676f51296dd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5cd42dded31dd08dfad25e58ae95ff923f5a7cf9","unresolved":false,"context_lines":[{"line_number":113,"context_line":"interface to a VM) will pass more than one Physical port and VIOS(es)"},{"line_number":114,"context_line":"(as stated above in deploy scenario) to pypowervm library to create vNIC on"},{"line_number":115,"context_line":"VIOS with redundancy. It should be noted that failover is handled automatically"},{"line_number":116,"context_line":"by the platform when a vNIC is backed by multiple VFs. The redundancy level"},{"line_number":117,"context_line":"will be controlled by a conf file in the powervm section of nova configuration."},{"line_number":118,"context_line":"It will have a default of 2. The redundancy level will also be controlled by"},{"line_number":119,"context_line":"binding profile data provided at the time of creating \u0027direct\u0027 port. The port"}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa7ab95a_61f97e4d","line":116,"range":{"start_line":116,"start_character":59,"end_line":116,"end_character":69},"in_reply_to":"fa7ab95a_1315c5e3","updated":"2016-08-31 16:37:46.000000000","message":"Done","commit_id":"42e19693af538f741342faf53d9d3676f51296dd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4498de32bb258bad8ad79a9e33e31a9478efd6f1","unresolved":false,"context_lines":[{"line_number":114,"context_line":"(as stated above in deploy scenario) to pypowervm library to create vNIC on"},{"line_number":115,"context_line":"VIOS with redundancy. It should be noted that failover is handled automatically"},{"line_number":116,"context_line":"by the platform when a vNIC is backed by multiple VFs. The redundancy level"},{"line_number":117,"context_line":"will be controlled by a conf file in the powervm section of nova configuration."},{"line_number":118,"context_line":"It will have a default of 2. The redundancy level will also be controlled by"},{"line_number":119,"context_line":"binding profile data provided at the time of creating \u0027direct\u0027 port. The port"},{"line_number":120,"context_line":"can be created with this parameter to neutron port-create:"}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa7ab95a_f30221b3","line":117,"range":{"start_line":117,"start_character":34,"end_line":117,"end_character":78},"updated":"2016-08-30 13:49:16.000000000","message":"Not anymore - controlled by ML2 configuration.","commit_id":"42e19693af538f741342faf53d9d3676f51296dd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5cd42dded31dd08dfad25e58ae95ff923f5a7cf9","unresolved":false,"context_lines":[{"line_number":114,"context_line":"(as stated above in deploy scenario) to pypowervm library to create vNIC on"},{"line_number":115,"context_line":"VIOS with redundancy. It should be noted that failover is handled automatically"},{"line_number":116,"context_line":"by the platform when a vNIC is backed by multiple VFs. The redundancy level"},{"line_number":117,"context_line":"will be controlled by a conf file in the powervm section of nova configuration."},{"line_number":118,"context_line":"It will have a default of 2. The redundancy level will also be controlled by"},{"line_number":119,"context_line":"binding profile data provided at the time of creating \u0027direct\u0027 port. The port"},{"line_number":120,"context_line":"can be created with this parameter to neutron port-create:"}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa7ab95a_8194c2e8","line":117,"range":{"start_line":117,"start_character":34,"end_line":117,"end_character":78},"in_reply_to":"fa7ab95a_f30221b3","updated":"2016-08-31 16:37:46.000000000","message":"Done","commit_id":"42e19693af538f741342faf53d9d3676f51296dd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4498de32bb258bad8ad79a9e33e31a9478efd6f1","unresolved":false,"context_lines":[{"line_number":116,"context_line":"by the platform when a vNIC is backed by multiple VFs. The redundancy level"},{"line_number":117,"context_line":"will be controlled by a conf file in the powervm section of nova configuration."},{"line_number":118,"context_line":"It will have a default of 2. The redundancy level will also be controlled by"},{"line_number":119,"context_line":"binding profile data provided at the time of creating \u0027direct\u0027 port. The port"},{"line_number":120,"context_line":"can be created with this parameter to neutron port-create:"},{"line_number":121,"context_line":"--binding:profile type\u003ddict vnic_required_vfs\u003d2,capacity\u003d0.2"},{"line_number":122,"context_line":"In this example, redundancy level is required to be 2."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"For future implementation of VF - VM direct attach of SR-IOV to a VM, the"}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa7ab95a_332f2940","line":121,"range":{"start_line":119,"start_character":0,"end_line":121,"end_character":60},"updated":"2016-08-30 13:49:16.000000000","message":"Not anymore.","commit_id":"42e19693af538f741342faf53d9d3676f51296dd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5cd42dded31dd08dfad25e58ae95ff923f5a7cf9","unresolved":false,"context_lines":[{"line_number":116,"context_line":"by the platform when a vNIC is backed by multiple VFs. The redundancy level"},{"line_number":117,"context_line":"will be controlled by a conf file in the powervm section of nova configuration."},{"line_number":118,"context_line":"It will have a default of 2. The redundancy level will also be controlled by"},{"line_number":119,"context_line":"binding profile data provided at the time of creating \u0027direct\u0027 port. The port"},{"line_number":120,"context_line":"can be created with this parameter to neutron port-create:"},{"line_number":121,"context_line":"--binding:profile type\u003ddict vnic_required_vfs\u003d2,capacity\u003d0.2"},{"line_number":122,"context_line":"In this example, redundancy level is required to be 2."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"For future implementation of VF - VM direct attach of SR-IOV to a VM, the"}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa7ab95a_a199c621","line":121,"range":{"start_line":119,"start_character":0,"end_line":121,"end_character":60},"in_reply_to":"fa7ab95a_332f2940","updated":"2016-08-31 16:37:46.000000000","message":"Done","commit_id":"42e19693af538f741342faf53d9d3676f51296dd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4498de32bb258bad8ad79a9e33e31a9478efd6f1","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"For migration scenario, physical network names should match on source and"},{"line_number":138,"context_line":"destination compute nodes. On destination, vNIC based port will be rebuilt"},{"line_number":139,"context_line":"based on the SR-IOV port configuration, without trying to match any"},{"line_number":140,"context_line":"particular source configuration (e.g, number of backing VFs)."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Alternatives"},{"line_number":143,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa7ab95a_d3243d0e","line":140,"range":{"start_line":139,"start_character":40,"end_line":140,"end_character":60},"updated":"2016-08-30 13:49:16.000000000","message":"I don\u0027t think this is true - pretty sure nvcastet is working on making the destination match the source pretty closely.  May want to get some details from him.\n\nThat said, not sure how much detail is required for the blueprint, since that stuff has nothing to do with the community code.  Perhaps just something like, \"the platform decides how to reconstruct the vNIC on the destination in terms of number and distribution of backing VFs, etc.\"","commit_id":"42e19693af538f741342faf53d9d3676f51296dd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5cd42dded31dd08dfad25e58ae95ff923f5a7cf9","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"For migration scenario, physical network names should match on source and"},{"line_number":138,"context_line":"destination compute nodes. On destination, vNIC based port will be rebuilt"},{"line_number":139,"context_line":"based on the SR-IOV port configuration, without trying to match any"},{"line_number":140,"context_line":"particular source configuration (e.g, number of backing VFs)."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Alternatives"},{"line_number":143,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa7ab95a_c19eca06","line":140,"range":{"start_line":139,"start_character":40,"end_line":140,"end_character":60},"in_reply_to":"fa7ab95a_d3243d0e","updated":"2016-08-31 16:37:46.000000000","message":"Done","commit_id":"42e19693af538f741342faf53d9d3676f51296dd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4498de32bb258bad8ad79a9e33e31a9478efd6f1","unresolved":false,"context_lines":[{"line_number":160,"context_line":"Deployer impact"},{"line_number":161,"context_line":"---------------"},{"line_number":162,"context_line":"To use the work implemented by this design, you will need a host with SR-IOV"},{"line_number":163,"context_line":"adapter card configured to be used with the host. Install/upgrade to a required"},{"line_number":164,"context_line":"level of pvm and nova-powervm and networking-powervm drivers on the host\u0027s"},{"line_number":165,"context_line":"OpenStack environment. Create neutron port with vnic type \u0027direct\u0027"},{"line_number":166,"context_line":"and attach it to VM."}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa7ab95a_7359b18d","line":163,"updated":"2016-08-30 13:49:16.000000000","message":"Should we mention firmware \u0026 VIOS level requirements here too?  (Not necessarily the specifics; but just that there *are* requirements?)","commit_id":"42e19693af538f741342faf53d9d3676f51296dd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5cd42dded31dd08dfad25e58ae95ff923f5a7cf9","unresolved":false,"context_lines":[{"line_number":160,"context_line":"Deployer impact"},{"line_number":161,"context_line":"---------------"},{"line_number":162,"context_line":"To use the work implemented by this design, you will need a host with SR-IOV"},{"line_number":163,"context_line":"adapter card configured to be used with the host. Install/upgrade to a required"},{"line_number":164,"context_line":"level of pvm and nova-powervm and networking-powervm drivers on the host\u0027s"},{"line_number":165,"context_line":"OpenStack environment. Create neutron port with vnic type \u0027direct\u0027"},{"line_number":166,"context_line":"and attach it to VM."}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa7ab95a_61909eed","line":163,"in_reply_to":"fa7ab95a_7359b18d","updated":"2016-08-31 16:37:46.000000000","message":"Moved hardware/firmware/software requirements to Dependencies; changed this section to deployer pre-config steps.","commit_id":"42e19693af538f741342faf53d9d3676f51296dd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4498de32bb258bad8ad79a9e33e31a9478efd6f1","unresolved":false,"context_lines":[{"line_number":173,"context_line":"------------"},{"line_number":174,"context_line":"1. An updated version of Novalink PowerVM feature"},{"line_number":175,"context_line":"2. pypowervm library - https://github.com/powervm/pypowervm"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"Implementation"},{"line_number":178,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa7ab95a_d3d99df4","line":176,"updated":"2016-08-30 13:49:16.000000000","message":"...and/or here (firmware/VIOS level)?  As well as hardware reqs?","commit_id":"42e19693af538f741342faf53d9d3676f51296dd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5cd42dded31dd08dfad25e58ae95ff923f5a7cf9","unresolved":false,"context_lines":[{"line_number":173,"context_line":"------------"},{"line_number":174,"context_line":"1. An updated version of Novalink PowerVM feature"},{"line_number":175,"context_line":"2. pypowervm library - https://github.com/powervm/pypowervm"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"Implementation"},{"line_number":178,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa7ab95a_e1baee6d","line":176,"in_reply_to":"fa7ab95a_d3d99df4","updated":"2016-08-31 16:37:46.000000000","message":"Done","commit_id":"42e19693af538f741342faf53d9d3676f51296dd"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"33410c1643f13328577fe2e0adef3c7c5a80d659","unresolved":false,"context_lines":[{"line_number":217,"context_line":"- Sridhar Venkat(svenkat)"},{"line_number":218,"context_line":"- Eric Larese(erlarese)"},{"line_number":219,"context_line":"- Esha Seth(eshaseth)"},{"line_number":220,"context_line":"- Andrew Thorstensen(thorst)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Work Items"},{"line_number":223,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":14,"id":"fa7ab95a_ab2a6be5","line":220,"range":{"start_line":220,"start_character":2,"end_line":220,"end_character":8},"updated":"2016-09-01 02:13:41.000000000","message":"Drew","commit_id":"a5b3e0f883201e90230feb51f734634cd4221535"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"c8c9a6a5f92b1abc084004c7fe923facbe9a7935","unresolved":false,"context_lines":[{"line_number":217,"context_line":"- Sridhar Venkat(svenkat)"},{"line_number":218,"context_line":"- Eric Larese(erlarese)"},{"line_number":219,"context_line":"- Esha Seth(eshaseth)"},{"line_number":220,"context_line":"- Andrew Thorstensen(thorst)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Work Items"},{"line_number":223,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":14,"id":"9a89bdaa_91ae56e4","line":220,"range":{"start_line":220,"start_character":2,"end_line":220,"end_character":8},"in_reply_to":"fa7ab95a_ab2a6be5","updated":"2016-09-07 16:06:12.000000000","message":"Done","commit_id":"a5b3e0f883201e90230feb51f734634cd4221535"}]}