)]}'
{"nova_powervm/virt/powervm/volume/vscsi.py":[{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"f1c548df902abac30685a999d28517028fde2831","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                vios_w, volume_id)"},{"line_number":119,"context_line":"            # If we found one, no need to check the others."},{"line_number":120,"context_line":"            found \u003d found or hdisk.good_discovery(status, device_name)"},{"line_number":121,"context_line":"            # if valid udid is returned save in mig_data"},{"line_number":122,"context_line":"            if udid is not None:"},{"line_number":123,"context_line":"                mig_data[\u0027vscsi-\u0027 + volume_id] \u003d udid"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        if not found:"},{"line_number":126,"context_line":"            ex_args \u003d dict(volume_id\u003dvolume_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_5086c965","line":123,"range":{"start_line":121,"start_character":0,"end_line":123,"end_character":53},"updated":"2016-07-05 14:38:21.000000000","message":"Is it valid to have found something, but not have a udid?","commit_id":"3c0a020ad74771b4dfe83dbacd281b6305a5b60e"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"f1c548df902abac30685a999d28517028fde2831","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        if not found:"},{"line_number":126,"context_line":"            ex_args \u003d dict(volume_id\u003dvolume_id,"},{"line_number":127,"context_line":"                           instance_name\u003dself.instance.name)"},{"line_number":128,"context_line":"            raise p_exc.VolumePreMigrationFailed(**ex_args)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def _cleanup_volume(self, udid):"},{"line_number":131,"context_line":"        \"\"\"Cleanup the hdisk associated with this udid.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_1069e18b","line":128,"range":{"start_line":128,"start_character":12,"end_line":128,"end_character":59},"updated":"2016-07-05 14:38:21.000000000","message":"Re comment above...do we need to throw an error if the UDID was not found anywhere?\n\nI think we DO require a udid to be found?  Just the ordering of the VIOSes was causing us to wipe it out with the last VIOS.","commit_id":"3c0a020ad74771b4dfe83dbacd281b6305a5b60e"},{"author":{"_account_id":13002,"name":"Shyama","email":"shyvenug@in.ibm.com","username":"shyama"},"change_message_id":"1b78ab0f02675472b5ae963b7c2ca128b328ca8c","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        if not found:"},{"line_number":126,"context_line":"            ex_args \u003d dict(volume_id\u003dvolume_id,"},{"line_number":127,"context_line":"                           instance_name\u003dself.instance.name)"},{"line_number":128,"context_line":"            raise p_exc.VolumePreMigrationFailed(**ex_args)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def _cleanup_volume(self, udid):"},{"line_number":131,"context_line":"        \"\"\"Cleanup the hdisk associated with this udid.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_8de92f83","line":128,"range":{"start_line":128,"start_character":12,"end_line":128,"end_character":59},"in_reply_to":"1aa78d24_1069e18b","updated":"2016-07-05 17:53:29.000000000","message":"Yes we do need a udid, but if udid is not found the device name and status would also not be returned. the \u0027found\u0027 flag would be false as well.","commit_id":"3c0a020ad74771b4dfe83dbacd281b6305a5b60e"},{"author":{"_account_id":13002,"name":"Shyama","email":"shyvenug@in.ibm.com","username":"shyama"},"change_message_id":"7a4f5c6d34de40a2f4caf12473077f26bdc79e34","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        if not found:"},{"line_number":126,"context_line":"            ex_args \u003d dict(volume_id\u003dvolume_id,"},{"line_number":127,"context_line":"                           instance_name\u003dself.instance.name)"},{"line_number":128,"context_line":"            raise p_exc.VolumePreMigrationFailed(**ex_args)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def _cleanup_volume(self, udid):"},{"line_number":131,"context_line":"        \"\"\"Cleanup the hdisk associated with this udid.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_b5005b67","line":128,"range":{"start_line":128,"start_character":12,"end_line":128,"end_character":59},"in_reply_to":"1aa78d24_255626ce","updated":"2016-07-07 04:52:44.000000000","message":"Yes if udid is None then the status returned is 6 or 7. So good_discovery would not be True.","commit_id":"3c0a020ad74771b4dfe83dbacd281b6305a5b60e"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"992ea36c9526803584d96bb06a88673bf4313031","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        if not found:"},{"line_number":126,"context_line":"            ex_args \u003d dict(volume_id\u003dvolume_id,"},{"line_number":127,"context_line":"                           instance_name\u003dself.instance.name)"},{"line_number":128,"context_line":"            raise p_exc.VolumePreMigrationFailed(**ex_args)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def _cleanup_volume(self, udid):"},{"line_number":131,"context_line":"        \"\"\"Cleanup the hdisk associated with this udid.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_255626ce","line":128,"range":{"start_line":128,"start_character":12,"end_line":128,"end_character":59},"in_reply_to":"1aa78d24_8de92f83","updated":"2016-07-06 13:14:23.000000000","message":"hmm....good_discovery doesn\u0027t require udid to be not None.  But your assertion is that if it was a good discovery then the udid would be set?\n\nIs that for sure?","commit_id":"3c0a020ad74771b4dfe83dbacd281b6305a5b60e"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"6ab619b6c7dd18f6ba1d90c87a4f1efdbfdd15c3","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        if not found:"},{"line_number":126,"context_line":"            ex_args \u003d dict(volume_id\u003dvolume_id,"},{"line_number":127,"context_line":"                           instance_name\u003dself.instance.name)"},{"line_number":128,"context_line":"            raise p_exc.VolumePreMigrationFailed(**ex_args)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def _cleanup_volume(self, udid):"},{"line_number":131,"context_line":"        \"\"\"Cleanup the hdisk associated with this udid.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_d8b26a4b","line":128,"range":{"start_line":128,"start_character":12,"end_line":128,"end_character":59},"in_reply_to":"1aa78d24_b5005b67","updated":"2016-07-07 11:44:38.000000000","message":"Not a huge fan of that (cause its implicit knowledge).  I\u0027d prefer you also change \u0027if not found or \u0027vscsi-\u0027+volume_id not in mig_data\u0027...\n\nJust to make it more explicit for those that don\u0027t know the ins and outs of the good_discovery and hdisk calls...","commit_id":"3c0a020ad74771b4dfe83dbacd281b6305a5b60e"},{"author":{"_account_id":13002,"name":"Shyama","email":"shyvenug@in.ibm.com","username":"shyama"},"change_message_id":"2ce793e40bcf8df1b1bac792601106d9d0ffa154","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        if not found:"},{"line_number":126,"context_line":"            ex_args \u003d dict(volume_id\u003dvolume_id,"},{"line_number":127,"context_line":"                           instance_name\u003dself.instance.name)"},{"line_number":128,"context_line":"            raise p_exc.VolumePreMigrationFailed(**ex_args)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def _cleanup_volume(self, udid):"},{"line_number":131,"context_line":"        \"\"\"Cleanup the hdisk associated with this udid.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_cb8a9163","line":128,"range":{"start_line":128,"start_character":12,"end_line":128,"end_character":59},"in_reply_to":"1aa78d24_d8b26a4b","updated":"2016-07-07 13:29:32.000000000","message":"will do","commit_id":"3c0a020ad74771b4dfe83dbacd281b6305a5b60e"},{"author":{"_account_id":18640,"name":"Ravi Kumar Kota","email":"ravkota3@in.ibm.com","username":"kotra03"},"change_message_id":"138c98d077569f27a9de92ab36ff359f91282d57","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        # use the connection information because LPM \u0027refreshes\u0027 it, which"},{"line_number":168,"context_line":"        # wipes out our data, so we use the data from the destination host"},{"line_number":169,"context_line":"        # to avoid having to discover the hdisk to get the udid."},{"line_number":170,"context_line":"        udid \u003d migrate_data.get(\u0027vscsi-\u0027 + self.volume_id, None)"},{"line_number":171,"context_line":"        self._cleanup_volume(udid)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def cleanup_volume_at_destination(self, migrate_data):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_2377be3b","line":170,"range":{"start_line":170,"start_character":57,"end_line":170,"end_character":63},"updated":"2016-07-04 08:47:36.000000000","message":"Do we really need this? This change brings in any difference?\n\nIf default is not given, doesn\u0027t it default to None?","commit_id":"3c0a020ad74771b4dfe83dbacd281b6305a5b60e"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"6ab619b6c7dd18f6ba1d90c87a4f1efdbfdd15c3","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        # use the connection information because LPM \u0027refreshes\u0027 it, which"},{"line_number":168,"context_line":"        # wipes out our data, so we use the data from the destination host"},{"line_number":169,"context_line":"        # to avoid having to discover the hdisk to get the udid."},{"line_number":170,"context_line":"        udid \u003d migrate_data.get(\u0027vscsi-\u0027 + self.volume_id, None)"},{"line_number":171,"context_line":"        self._cleanup_volume(udid)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def cleanup_volume_at_destination(self, migrate_data):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_38ef2e1f","line":170,"range":{"start_line":170,"start_character":57,"end_line":170,"end_character":63},"in_reply_to":"1aa78d24_2377be3b","updated":"2016-07-07 11:44:38.000000000","message":"+1, this is not needed.  And actually, can this ever be None???","commit_id":"3c0a020ad74771b4dfe83dbacd281b6305a5b60e"},{"author":{"_account_id":13002,"name":"Shyama","email":"shyvenug@in.ibm.com","username":"shyama"},"change_message_id":"2ce793e40bcf8df1b1bac792601106d9d0ffa154","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        # use the connection information because LPM \u0027refreshes\u0027 it, which"},{"line_number":168,"context_line":"        # wipes out our data, so we use the data from the destination host"},{"line_number":169,"context_line":"        # to avoid having to discover the hdisk to get the udid."},{"line_number":170,"context_line":"        udid \u003d migrate_data.get(\u0027vscsi-\u0027 + self.volume_id, None)"},{"line_number":171,"context_line":"        self._cleanup_volume(udid)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def cleanup_volume_at_destination(self, migrate_data):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_abe0e529","line":170,"range":{"start_line":170,"start_character":57,"end_line":170,"end_character":63},"in_reply_to":"1aa78d24_38ef2e1f","updated":"2016-07-07 13:29:32.000000000","message":"agree","commit_id":"3c0a020ad74771b4dfe83dbacd281b6305a5b60e"},{"author":{"_account_id":18640,"name":"Ravi Kumar Kota","email":"ravkota3@in.ibm.com","username":"kotra03"},"change_message_id":"138c98d077569f27a9de92ab36ff359f91282d57","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        :param migrate_data: migration data"},{"line_number":180,"context_line":"        \"\"\""},{"line_number":181,"context_line":"        udid \u003d migrate_data.get(\u0027vscsi-\u0027 + self.volume_id, None)"},{"line_number":182,"context_line":"        self._cleanup_volume(udid)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def is_volume_on_vios(self, vios_w):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_839e7254","line":181,"range":{"start_line":181,"start_character":57,"end_line":181,"end_character":63},"updated":"2016-07-04 08:47:36.000000000","message":"Do we really need this? This change brings in any difference?\n\nIf default is not given, doesn\u0027t it default to None?","commit_id":"3c0a020ad74771b4dfe83dbacd281b6305a5b60e"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"6ab619b6c7dd18f6ba1d90c87a4f1efdbfdd15c3","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        :param migrate_data: migration data"},{"line_number":180,"context_line":"        \"\"\""},{"line_number":181,"context_line":"        udid \u003d migrate_data.get(\u0027vscsi-\u0027 + self.volume_id, None)"},{"line_number":182,"context_line":"        self._cleanup_volume(udid)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def is_volume_on_vios(self, vios_w):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_d8e0aa2b","line":181,"range":{"start_line":181,"start_character":57,"end_line":181,"end_character":63},"in_reply_to":"1aa78d24_839e7254","updated":"2016-07-07 11:44:38.000000000","message":"Given statements above, could this ever actually be None?","commit_id":"3c0a020ad74771b4dfe83dbacd281b6305a5b60e"},{"author":{"_account_id":13002,"name":"Shyama","email":"shyvenug@in.ibm.com","username":"shyama"},"change_message_id":"2ce793e40bcf8df1b1bac792601106d9d0ffa154","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        :param migrate_data: migration data"},{"line_number":180,"context_line":"        \"\"\""},{"line_number":181,"context_line":"        udid \u003d migrate_data.get(\u0027vscsi-\u0027 + self.volume_id, None)"},{"line_number":182,"context_line":"        self._cleanup_volume(udid)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def is_volume_on_vios(self, vios_w):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_6bc9ddab","line":181,"range":{"start_line":181,"start_character":57,"end_line":181,"end_character":63},"in_reply_to":"1aa78d24_d8e0aa2b","updated":"2016-07-07 13:29:32.000000000","message":"agree","commit_id":"3c0a020ad74771b4dfe83dbacd281b6305a5b60e"}]}