)]}'
{"nova_powervm/tests/virt/powervm/test_driver.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d467634fb8bd5090455d397d436e46f6c369e361","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            \u0027pypowervm.util.sanitize_partition_name_for_api\u0027)).mock"},{"line_number":124,"context_line":"        self.san_lpar_name.side_effect \u003d lambda name: name"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        self.validate_vopt \u003d self.useFixture(fixtures.MockPatch("},{"line_number":127,"context_line":"            \u0027pypowervm.tasks.vopt.validate_vopt_repo_exists\u0027)).mock"},{"line_number":128,"context_line":"        self.validate_vopt.return_value \u003d None, None"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_2b92354c","line":126,"updated":"2016-07-07 13:37:29.000000000","message":"No need to make this an instance variable unless you\u0027re going to reference it somewhere (see below).","commit_id":"57ed28ac4293c2858d5664cf91f9d0151ca2796f"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"7d568a576635492c4afdf5f4a145bee90c56f49a","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            \u0027pypowervm.util.sanitize_partition_name_for_api\u0027)).mock"},{"line_number":124,"context_line":"        self.san_lpar_name.side_effect \u003d lambda name: name"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        self.validate_vopt \u003d self.useFixture(fixtures.MockPatch("},{"line_number":127,"context_line":"            \u0027pypowervm.tasks.vopt.validate_vopt_repo_exists\u0027)).mock"},{"line_number":128,"context_line":"        self.validate_vopt.return_value \u003d None, None"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_c6a4484c","line":126,"in_reply_to":"1aa78d24_2b92354c","updated":"2016-07-07 13:58:21.000000000","message":"Done","commit_id":"57ed28ac4293c2858d5664cf91f9d0151ca2796f"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d467634fb8bd5090455d397d436e46f6c369e361","unresolved":false,"context_lines":[{"line_number":332,"context_line":"                                         self.inst, self.inst.get_flavor(),"},{"line_number":333,"context_line":"                                         nvram\u003dNone)"},{"line_number":334,"context_line":"        # Config drive was called"},{"line_number":335,"context_line":"        self.assertTrue(mock_cfg_vopt.called)"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        # Power on was called"},{"line_number":338,"context_line":"        self.assertTrue(mock_pwron.called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_6baf1d7d","line":335,"updated":"2016-07-07 13:37:29.000000000","message":"Consider preserving this assertion, e.g. as\n\n self.assertTrue(self.validate_vopt.called)","commit_id":"57ed28ac4293c2858d5664cf91f9d0151ca2796f"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"7d568a576635492c4afdf5f4a145bee90c56f49a","unresolved":false,"context_lines":[{"line_number":332,"context_line":"                                         self.inst, self.inst.get_flavor(),"},{"line_number":333,"context_line":"                                         nvram\u003dNone)"},{"line_number":334,"context_line":"        # Config drive was called"},{"line_number":335,"context_line":"        self.assertTrue(mock_cfg_vopt.called)"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        # Power on was called"},{"line_number":338,"context_line":"        self.assertTrue(mock_pwron.called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_066930f9","line":335,"in_reply_to":"1aa78d24_6baf1d7d","updated":"2016-07-07 13:58:21.000000000","message":"Done","commit_id":"57ed28ac4293c2858d5664cf91f9d0151ca2796f"}],"nova_powervm/tests/virt/powervm/test_media.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d467634fb8bd5090455d397d436e46f6c369e361","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        self.apt \u003d self.useFixture(pvm_fx.AdapterFx()).adpt"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        self.validate_vopt \u003d self.useFixture(fixtures.MockPatch("},{"line_number":39,"context_line":"            \u0027pypowervm.tasks.vopt.validate_vopt_repo_exists\u0027)).mock"},{"line_number":40,"context_line":"        self.validate_vopt.return_value \u003d None, None"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_2b635543","line":38,"updated":"2016-07-07 13:37:29.000000000","message":"No need to make this an instance variable if you\u0027re not going to reference it anywhere.\n\nThat said, I feel like you should add in some\n\n self.validate_vopt.assert_called_once_with(...)\n\nto the test cases somewhere below.","commit_id":"57ed28ac4293c2858d5664cf91f9d0151ca2796f"}]}