)]}'
{"nova_powervm/virt/powervm/driver.py":[{"author":{"_account_id":13557,"name":"Matt Rabe","email":"mdrabe@us.ibm.com","username":"mdrabe"},"change_message_id":"87e1cc71e777021087b7615e73f38f382ba19ff0","unresolved":false,"context_lines":[{"line_number":584,"context_line":"            flow.add(tf_net.UnplugVifs(self.adapter, instance, network_info,"},{"line_number":585,"context_line":"                                       self.host_uuid, slot_mgr))"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"            pvm_tstor.add_lpar_storage_scrub_tasks("},{"line_number":588,"context_line":"                [vm.get_vm_id(self.adapter, pvm_inst_uuid)], stg_ftsk,"},{"line_number":589,"context_line":"                lpars_exist\u003dTrue)"},{"line_number":590,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_7454e653","line":587,"range":{"start_line":587,"start_character":22,"end_line":587,"end_character":50},"updated":"2016-07-27 21:25:27.000000000","message":"Alright so this guy would now be taking the place of the DeleteVOpt, DisconnectVolume, DetachDisk, and DeleteDisk tasks. If the end goal of these tasks is to remove the XML elements corresponding to their respective mappings/adapters/devices/etc. from the VIOS wrappers, and add_lpar_storage_scrub_tasks ultimately does the same thing then I\u0027d be okay with this.","commit_id":"b0ee1455d3298a8a9944b703bc6a4f482763bb57"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"67b7ef18fee3942cdeb3e76751c41fe64f9b42b5","unresolved":false,"context_lines":[{"line_number":584,"context_line":"            flow.add(tf_net.UnplugVifs(self.adapter, instance, network_info,"},{"line_number":585,"context_line":"                                       self.host_uuid, slot_mgr))"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"            pvm_tstor.add_lpar_storage_scrub_tasks("},{"line_number":588,"context_line":"                [vm.get_vm_id(self.adapter, pvm_inst_uuid)], stg_ftsk,"},{"line_number":589,"context_line":"                lpars_exist\u003dTrue)"},{"line_number":590,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_86d93b86","line":587,"range":{"start_line":587,"start_character":22,"end_line":587,"end_character":50},"in_reply_to":"bacf61ea_7454e653","updated":"2016-07-28 17:37:51.000000000","message":"Too much logic is removed here...\n\nWhat about flows where you don\u0027t want the disks destroyed?","commit_id":"b0ee1455d3298a8a9944b703bc6a4f482763bb57"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"db43bc67d213abe7d39cb9248effa329384c31c5","unresolved":false,"context_lines":[{"line_number":584,"context_line":"            flow.add(tf_net.UnplugVifs(self.adapter, instance, network_info,"},{"line_number":585,"context_line":"                                       self.host_uuid, slot_mgr))"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"            pvm_tstor.add_lpar_storage_scrub_tasks("},{"line_number":588,"context_line":"                [vm.get_vm_id(self.adapter, pvm_inst_uuid)], stg_ftsk,"},{"line_number":589,"context_line":"                lpars_exist\u003dTrue)"},{"line_number":590,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_0630ab9d","line":587,"range":{"start_line":587,"start_character":22,"end_line":587,"end_character":50},"in_reply_to":"bacf61ea_86d93b86","updated":"2016-07-28 17:40:17.000000000","message":"What flows would those be?","commit_id":"b0ee1455d3298a8a9944b703bc6a4f482763bb57"}]}