)]}'
{"nova_powervm/tests/virt/powervm/test_vif.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"ee7ecbb5ebfcc65747a8e6bdeabb3958fb719f64","unresolved":false,"context_lines":[{"line_number":798,"context_line":"        vif \u003d {\u0027devname\u0027: \u0027tap-dev\u0027, \u0027address\u0027: \u0027aa:bb:cc:dd:ee:ee\u0027,"},{"line_number":799,"context_line":"               \u0027network\u0027: {\u0027bridge\u0027: \u0027br-int\u0027}, \u0027id\u0027: \u0027vif_id\u0027}"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"        mock_vio \u003d mock.MagicMock(schema_type\u003d\u0027VIO\u0027, uuid\u003d\u0027uuid\u0027)"},{"line_number":802,"context_line":"        mock_get_part.return_value \u003d mock_vio"},{"line_number":803,"context_line":""},{"line_number":804,"context_line":"        trunk1 \u003d mock.Mock(pvid\u003d2, vswitch_id\u003d3, trunk_pri\u003d1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_1e403b07","line":801,"updated":"2016-11-04 15:11:32.000000000","message":"FWIW, I think you can do something like `spec\u003dvios.VIOS` to have it populate properties that\u0027ll break ya.  But the schema_type for VIOS is \u0027VirtualIOServer\u0027 anyway.  Must not be terribly important to the test, huh?","commit_id":"2428e5ec68399b508bf046490ebe6a366038ebb0"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"03ccb77c9e6947bf0f9ff12f81bc03fe396663f2","unresolved":false,"context_lines":[{"line_number":798,"context_line":"        vif \u003d {\u0027devname\u0027: \u0027tap-dev\u0027, \u0027address\u0027: \u0027aa:bb:cc:dd:ee:ee\u0027,"},{"line_number":799,"context_line":"               \u0027network\u0027: {\u0027bridge\u0027: \u0027br-int\u0027}, \u0027id\u0027: \u0027vif_id\u0027}"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"        mock_vio \u003d mock.MagicMock(schema_type\u003d\u0027VIO\u0027, uuid\u003d\u0027uuid\u0027)"},{"line_number":802,"context_line":"        mock_get_part.return_value \u003d mock_vio"},{"line_number":803,"context_line":""},{"line_number":804,"context_line":"        trunk1 \u003d mock.Mock(pvid\u003d2, vswitch_id\u003d3, trunk_pri\u003d1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_dbffaaa8","line":801,"in_reply_to":"ba5da102_1e403b07","updated":"2016-11-04 19:33:37.000000000","message":"Not important for the test.  Feel strongly about it?  Would just slow it down.","commit_id":"2428e5ec68399b508bf046490ebe6a366038ebb0"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"040d3015d67a63c2e98a81584bd0a13fbdc3e05e","unresolved":false,"context_lines":[{"line_number":798,"context_line":"        vif \u003d {\u0027devname\u0027: \u0027tap-dev\u0027, \u0027address\u0027: \u0027aa:bb:cc:dd:ee:ee\u0027,"},{"line_number":799,"context_line":"               \u0027network\u0027: {\u0027bridge\u0027: \u0027br-int\u0027}, \u0027id\u0027: \u0027vif_id\u0027}"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"        mock_vio \u003d mock.MagicMock(schema_type\u003d\u0027VIO\u0027, uuid\u003d\u0027uuid\u0027)"},{"line_number":802,"context_line":"        mock_get_part.return_value \u003d mock_vio"},{"line_number":803,"context_line":""},{"line_number":804,"context_line":"        trunk1 \u003d mock.Mock(pvid\u003d2, vswitch_id\u003d3, trunk_pri\u003d1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_74114c5d","line":801,"in_reply_to":"ba5da102_dbffaaa8","updated":"2016-11-04 21:41:49.000000000","message":"I don\u0027t feel strongly about it.  It did make me wonder why you need it to be here in the first place if the value\u0027s wrong.","commit_id":"2428e5ec68399b508bf046490ebe6a366038ebb0"}],"nova_powervm/virt/powervm/vif.py":[{"author":{"_account_id":18640,"name":"Ravi Kumar Kota","email":"ravkota3@in.ibm.com","username":"kotra03"},"change_message_id":"9b136138902f22ffc295fe5c67ee60ea4659bf64","unresolved":false,"context_lines":[{"line_number":813,"context_line":"        for adpt in child_adpts:"},{"line_number":814,"context_line":"            # We need a trunk adapter (so check trunk_pri).  Then the trunk"},{"line_number":815,"context_line":"            # is unique by PVID and PowerVM vSwitch ID."},{"line_number":816,"context_line":"            if (adpt.pvid \u003d\u003d vlan and adpt.vswitch_id \u003d\u003d vswitch_id and"},{"line_number":817,"context_line":"                    adpt.trunk_pri):"},{"line_number":818,"context_line":"                trunk \u003d adpt"},{"line_number":819,"context_line":"                break"},{"line_number":820,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_2a25c2aa","line":817,"range":{"start_line":816,"start_character":0,"end_line":817,"end_character":36},"updated":"2016-11-07 13:41:50.000000000","message":"I observed that this if clause results in \u0027False\u0027 always.\nThat is because the type of adpt.pvid is \u0027int\u0027 and the type of vlan is \u0027unicode\u0027. And the comparison between these 2 results in inequality even though they have the same value.","commit_id":"2428e5ec68399b508bf046490ebe6a366038ebb0"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"40952ec740a3fbfe51bfb54e37fe03bda6ba8500","unresolved":false,"context_lines":[{"line_number":813,"context_line":"        for adpt in child_adpts:"},{"line_number":814,"context_line":"            # We need a trunk adapter (so check trunk_pri).  Then the trunk"},{"line_number":815,"context_line":"            # is unique by PVID and PowerVM vSwitch ID."},{"line_number":816,"context_line":"            if (adpt.pvid \u003d\u003d vlan and adpt.vswitch_id \u003d\u003d vswitch_id and"},{"line_number":817,"context_line":"                    adpt.trunk_pri):"},{"line_number":818,"context_line":"                trunk \u003d adpt"},{"line_number":819,"context_line":"                break"},{"line_number":820,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_9a6df29a","line":817,"range":{"start_line":816,"start_character":0,"end_line":817,"end_character":36},"in_reply_to":"9a629dbe_2a25c2aa","updated":"2016-11-08 20:11:51.000000000","message":"Done","commit_id":"2428e5ec68399b508bf046490ebe6a366038ebb0"}]}