)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20137,"name":"Kris Kendall","email":"kriskend@us.ibm.com","username":"kriskend"},"change_message_id":"044a60ca04c4129460c0229b136ae843be83ba7e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Retry up to 3 times on disk create"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Excpetions can occur while downloading an image from glance, such"},{"line_number":10,"context_line":"as a checksum error or losing connection to the glance server."},{"line_number":11,"context_line":"Retrying can resolve these issues so we will retry creating the"},{"line_number":12,"context_line":"disk image up to 3 times for a total of 4 attempts."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a71b18c_0d9494e6","line":9,"updated":"2016-12-07 19:53:09.000000000","message":"typo","commit_id":"4cbadf6e194458b07a159f4d25078305a2adf4f3"}],"nova_powervm/tests/virt/powervm/disk/test_localdisk.py":[{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"3c9faaf4faa1ad19986d8f368d172165efa08bde","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        mock_img_api.side_effect \u003d Exception()"},{"line_number":113,"context_line":"        try:"},{"line_number":114,"context_line":"            vdisk \u003d self.get_ls(self.apt).create_disk_from_image("},{"line_number":115,"context_line":"                None, inst, powervm.TEST_IMAGE1, 20)"},{"line_number":116,"context_line":"        except Exception:"},{"line_number":117,"context_line":"            pass"},{"line_number":118,"context_line":"        self.assertEqual(mock_img_api.call_count, 3)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_671315b9","line":115,"updated":"2016-12-02 20:55:55.000000000","message":"This should be a \u0027self.assertRaises\u0027 call.","commit_id":"fd38202239e2eb886590edec4dadde23a159b523"}],"nova_powervm/virt/powervm/disk/driver.py":[{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"3c9faaf4faa1ad19986d8f368d172165efa08bde","unresolved":false,"context_lines":[{"line_number":323,"context_line":"                    context, instance, image_meta,"},{"line_number":324,"context_line":"                    disk_size, image_type\u003dimage_type)"},{"line_number":325,"context_line":"            except Exception as e:"},{"line_number":326,"context_line":"                LOG.info(_LI(\"Attempt # %(retry)d, retrying instance \""},{"line_number":327,"context_line":"                             \"%(instance)s\"), {\"retry\": retries,"},{"line_number":328,"context_line":"                                               \"instance\": instance})"},{"line_number":329,"context_line":"                error \u003d e"},{"line_number":330,"context_line":"        LOG.exception(error)"},{"line_number":331,"context_line":"        raise(error)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_c78789d5","line":328,"range":{"start_line":326,"start_character":0,"end_line":328,"end_character":69},"updated":"2016-12-02 20:55:55.000000000","message":"This should be a warning message.  Should indicate what went wrong if retries \u003c 3","commit_id":"fd38202239e2eb886590edec4dadde23a159b523"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"3c9faaf4faa1ad19986d8f368d172165efa08bde","unresolved":false,"context_lines":[{"line_number":326,"context_line":"                LOG.info(_LI(\"Attempt # %(retry)d, retrying instance \""},{"line_number":327,"context_line":"                             \"%(instance)s\"), {\"retry\": retries,"},{"line_number":328,"context_line":"                                               \"instance\": instance})"},{"line_number":329,"context_line":"                error \u003d e"},{"line_number":330,"context_line":"        LOG.exception(error)"},{"line_number":331,"context_line":"        raise(error)"},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_2722fd00","line":329,"updated":"2016-12-02 20:55:55.000000000","message":"I would just say \u0027if retries \u003d\u003d 3: raise\u0027","commit_id":"fd38202239e2eb886590edec4dadde23a159b523"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"3c9faaf4faa1ad19986d8f368d172165efa08bde","unresolved":false,"context_lines":[{"line_number":328,"context_line":"                                               \"instance\": instance})"},{"line_number":329,"context_line":"                error \u003d e"},{"line_number":330,"context_line":"        LOG.exception(error)"},{"line_number":331,"context_line":"        raise(error)"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    def connect_disk(self, context, instance, disk_info, stg_ftsk\u003dNone):"},{"line_number":334,"context_line":"        \"\"\"Connects the disk image to the Virtual Machine."}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_c71069ab","line":331,"range":{"start_line":331,"start_character":8,"end_line":331,"end_character":20},"updated":"2016-12-02 20:55:55.000000000","message":"raise error","commit_id":"fd38202239e2eb886590edec4dadde23a159b523"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"96bfdd7d9ef3cf1db410af2f2f7491cb0288ac11","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        \"\"\""},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        # Retry 3 times on exception"},{"line_number":320,"context_line":"        for attempts in range(0, 4):"},{"line_number":321,"context_line":"            try:"},{"line_number":322,"context_line":"                return self._create_disk_from_image("},{"line_number":323,"context_line":"                    context, instance, image_meta,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_62658d1c","line":320,"range":{"start_line":320,"start_character":12,"end_line":320,"end_character":20},"updated":"2016-12-05 16:07:53.000000000","message":"Maybe just \u0027attempt\u0027","commit_id":"6f638b2c8ee15cb98e0ff6a758679d9caa2cbde4"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"96bfdd7d9ef3cf1db410af2f2f7491cb0288ac11","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        # Retry 3 times on exception"},{"line_number":320,"context_line":"        for attempts in range(0, 4):"},{"line_number":321,"context_line":"            try:"},{"line_number":322,"context_line":"                return self._create_disk_from_image("},{"line_number":323,"context_line":"                    context, instance, image_meta,"},{"line_number":324,"context_line":"                    disk_size, image_type\u003dimage_type)"},{"line_number":325,"context_line":"            except Exception as error:"},{"line_number":326,"context_line":"                LOG.warning(_LW(\"Attempt # %(attempt)d, retrying instance \""},{"line_number":327,"context_line":"                                \"%(instance)s\"), {\"attempt\": attempts,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_c2474175","line":324,"range":{"start_line":322,"start_character":0,"end_line":324,"end_character":53},"updated":"2016-12-05 16:07:53.000000000","message":"This now needs to be defined as a method in the super class.  Have it \u0027pass\u0027 like this one did.\n\nMethod signature should indicate that it expects the implementor to handle clean up of the disk in case of error.","commit_id":"6f638b2c8ee15cb98e0ff6a758679d9caa2cbde4"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"96bfdd7d9ef3cf1db410af2f2f7491cb0288ac11","unresolved":false,"context_lines":[{"line_number":329,"context_line":"                if attempts \u003c 3:"},{"line_number":330,"context_line":"                    LOG.exception(error)"},{"line_number":331,"context_line":"                else:"},{"line_number":332,"context_line":"                    raise error"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    def connect_disk(self, context, instance, disk_info, stg_ftsk\u003dNone):"},{"line_number":335,"context_line":"        \"\"\"Connects the disk image to the Virtual Machine."}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_22a9d524","line":332,"range":{"start_line":332,"start_character":20,"end_line":332,"end_character":31},"updated":"2016-12-05 16:07:53.000000000","message":"Just \u0027raise\u0027. \n\nIf you \u0027raise error\u0027 you lose the original traceback.","commit_id":"6f638b2c8ee15cb98e0ff6a758679d9caa2cbde4"},{"author":{"_account_id":20137,"name":"Kris Kendall","email":"kriskend@us.ibm.com","username":"kriskend"},"change_message_id":"044a60ca04c4129460c0229b136ae843be83ba7e","unresolved":false,"context_lines":[{"line_number":323,"context_line":"                    context, instance, image_meta,"},{"line_number":324,"context_line":"                    disk_size, image_type\u003dimage_type)"},{"line_number":325,"context_line":"            except Exception as error:"},{"line_number":326,"context_line":"                LOG.warning(_LW(\"Attempt # %(attempt)d, retrying instance \""},{"line_number":327,"context_line":"                                \"%(instance)s\"), {\"attempt\": attempt,"},{"line_number":328,"context_line":"                                                  \"instance\": instance})"},{"line_number":329,"context_line":"                if attempt \u003c 3:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_adfe4036","line":326,"updated":"2016-12-07 19:53:09.000000000","message":"This warning ends up looking pretty gross, maybe you the display name and/or uuid of the instance only\n\n2016-12-05 11:28:53.419 143796 WARNING nova_powervm.virt.powervm.disk.driver [req-f57d9288-d5be-4baf-8f88-7380f385f56b 5eee0feada8142e8b147cd29749061cd 7dbe9a9c935b4aeea9d6c16c913e8c2c - - -] Attempt # 1, uretrying\ninstance Instance(access_ip_v4\u003dNone,access_ip_v6\u003dNone,architecture\u003dNone,auto_disk_config\u003dFalse,availability_zone\u003d\u0027nova\u0027,cell_name\u003dNone,cleaned\u003dFalse,config_drive\u003d\u0027\u0027,created_at\u003d2016-12-05T16:40:22Z,default_ephemeral_\ndevice\u003dNone,default_swap_device\u003dNone,deleted\u003dFalse,deleted_at\u003dNone,device_metadata\u003dNone,disable_terminate\u003dFalse,display_description\u003dNone,display_name\u003d\u0027KAx2-3\u0027,ec2_ids\u003dEC2Ids,ephemeral_gb\u003d0,ephemeral_key_uuid\u003dNone,fa\nult\u003d\u003c?\u003e,flavor\u003dFlavor(17),host\u003d\u0027z1403dneo\u0027,hostname\u003d\u0027kax2-3\u0027,id\u003d793,image_ref\u003d\u002777b313af-55b1-480f-a8dc-56ccb1bc75f0\u0027,info_cache\u003dInstanceInfoCache,instance_type_id\u003d17,kernel_id\u003d\u0027\u0027,key_data\u003dNone,key_name\u003dNone,keypairs\n\u003dKeyPairList,launch_index\u003d2,launched_at\u003dNone,launched_on\u003d\u0027z1403dneo\u0027,locked\u003dFalse,locked_by\u003dNone,memory_mb\u003d2048,metadata\u003d{},migration_context\u003d\u003c?\u003e,new_flavor\u003dNone,node\u003d\u00278408-E8E*106725V\u0027,numa_topology\u003dNone,old_flavor\n\u003dNone,os_type\u003dNone,pci_devices\u003d\u003c?\u003e,pci_requests\u003dInstancePCIRequests,power_state\u003d0,progress\u003d0,project_id\u003d\u00277dbe9a9c935b4aeea9d6c16c913e8c2c\u0027,ramdisk_id\u003d\u0027\u0027,reservation_id\u003d\u0027r-p3k8is9f\u0027,root_device_name\u003d\u0027/dev/sda\u0027,root_g\nb\u003d20,security_groups\u003dSecurityGroupList,services\u003d\u003c?\u003e,shutdown_terminate\u003dFalse,system_metadata\u003d{image_base_image_ref\u003d\u002777b313af-55b1-480f-a8dc-56ccb1bc75f0\u0027,image_container_format\u003d\u0027bare\u0027,image_disk_format\u003d\u0027raw\u0027,image_m\nin_disk\u003d\u002720\u0027,image_min_ram\u003d\u00270\u0027,network_allocated\u003d\u0027True\u0027},tags\u003d\u003c?\u003e,task_state\u003d\u0027spawning\u0027,terminated_at\u003dNone,updated_at\u003d2016-12-05T16:40:38Z,user_data\u003dNone,user_id\u003d\u00275eee0feada8142e8b147cd29749061cd\u0027,uuid\u003d96d1cdd6-1641\n-4840-ae1b-94fe84b402fd,vcpu_model\u003dNone,vcpus\u003d3,vm_mode\u003dNone,vm_state\u003d\u0027building\u0027)","commit_id":"4cbadf6e194458b07a159f4d25078305a2adf4f3"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"779f91a7328bcb34213e01f2cfb7b4bada138dcd","unresolved":false,"context_lines":[{"line_number":323,"context_line":"                    context, instance, image_meta,"},{"line_number":324,"context_line":"                    disk_size, image_type\u003dimage_type)"},{"line_number":325,"context_line":"            except Exception as error:"},{"line_number":326,"context_line":"                LOG.warning(_LW(\"Attempt # %(attempt)d, retrying instance \""},{"line_number":327,"context_line":"                                \"%(instance)s. \"),"},{"line_number":328,"context_line":"                            {\"attempt\": attempt, \"instance\": instance.name},"},{"line_number":329,"context_line":"                            instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_50d0dfc9","line":326,"range":{"start_line":326,"start_character":16,"end_line":326,"end_character":27},"updated":"2016-12-07 20:23:09.000000000","message":"Warning message can be odd.\n\nFirst pass through says \u0027Attempt 0\u0027\n\nLast attempt says \u0027Attempt 3\u0027 (which is really the 4th), but doesn\u0027t actually retry a fourth time.","commit_id":"1e16921d258f3fc041262464fb536a3c8a48965c"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"779f91a7328bcb34213e01f2cfb7b4bada138dcd","unresolved":false,"context_lines":[{"line_number":323,"context_line":"                    context, instance, image_meta,"},{"line_number":324,"context_line":"                    disk_size, image_type\u003dimage_type)"},{"line_number":325,"context_line":"            except Exception as error:"},{"line_number":326,"context_line":"                LOG.warning(_LW(\"Attempt # %(attempt)d, retrying instance \""},{"line_number":327,"context_line":"                                \"%(instance)s. \"),"},{"line_number":328,"context_line":"                            {\"attempt\": attempt, \"instance\": instance.name},"},{"line_number":329,"context_line":"                            instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_307d23e8","line":326,"range":{"start_line":326,"start_character":33,"end_line":326,"end_character":40},"updated":"2016-12-07 20:23:09.000000000","message":"What are we exactly attempting to do here?  To the operator they may want a bit more context in this warning message.\n\nPerhaps:\n\"Instance Disk Upload failed.  Retrying the upload.","commit_id":"1e16921d258f3fc041262464fb536a3c8a48965c"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"779f91a7328bcb34213e01f2cfb7b4bada138dcd","unresolved":false,"context_lines":[{"line_number":323,"context_line":"                    context, instance, image_meta,"},{"line_number":324,"context_line":"                    disk_size, image_type\u003dimage_type)"},{"line_number":325,"context_line":"            except Exception as error:"},{"line_number":326,"context_line":"                LOG.warning(_LW(\"Attempt # %(attempt)d, retrying instance \""},{"line_number":327,"context_line":"                                \"%(instance)s. \"),"},{"line_number":328,"context_line":"                            {\"attempt\": attempt, \"instance\": instance.name},"},{"line_number":329,"context_line":"                            instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_f0456bb3","line":326,"range":{"start_line":326,"start_character":42,"end_line":326,"end_character":43},"updated":"2016-12-07 20:23:09.000000000","message":"unnecessary space","commit_id":"1e16921d258f3fc041262464fb536a3c8a48965c"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"779f91a7328bcb34213e01f2cfb7b4bada138dcd","unresolved":false,"context_lines":[{"line_number":324,"context_line":"                    disk_size, image_type\u003dimage_type)"},{"line_number":325,"context_line":"            except Exception as error:"},{"line_number":326,"context_line":"                LOG.warning(_LW(\"Attempt # %(attempt)d, retrying instance \""},{"line_number":327,"context_line":"                                \"%(instance)s. \"),"},{"line_number":328,"context_line":"                            {\"attempt\": attempt, \"instance\": instance.name},"},{"line_number":329,"context_line":"                            instance\u003dinstance)"},{"line_number":330,"context_line":"                if attempt \u003c 3:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_70395b41","line":327,"range":{"start_line":327,"start_character":46,"end_line":327,"end_character":47},"updated":"2016-12-07 20:23:09.000000000","message":"Unnecessary space.","commit_id":"1e16921d258f3fc041262464fb536a3c8a48965c"},{"author":{"_account_id":20137,"name":"Kris Kendall","email":"kriskend@us.ibm.com","username":"kriskend"},"change_message_id":"d0bf27596cfe28d7054b2b69e776a9a11ec8a08d","unresolved":false,"context_lines":[{"line_number":324,"context_line":"                    disk_size, image_type\u003dimage_type)"},{"line_number":325,"context_line":"            except Exception as error:"},{"line_number":326,"context_line":"                if attempt \u003c 4:"},{"line_number":327,"context_line":"                    LOG.warning(_LW(\"Instance %(inst)s Disk Upload attempt \""},{"line_number":328,"context_line":"                                    \"#%(attempt)d failed. Retrying the \""},{"line_number":329,"context_line":"                                    \"upload.\"),"},{"line_number":330,"context_line":"                                {\"attempt\": attempt,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_460bc97d","line":327,"range":{"start_line":327,"start_character":20,"end_line":327,"end_character":31},"updated":"2016-12-07 21:13:06.000000000","message":"Warning now looks like this \n\n2016-12-07 15:05:43.844 37273 WARNING nova_powervm.virt.powervm.disk.driver [req-14c68c80-d8fd-42d5-9aae-1c997245404b 5eee0feada8142e8b147cd29749061cd 7dbe9a9c935b4aeea9d6c16c913e8c2c - - -] [instance:\n 69edfc45-cfdd-4c04-8daf-7c24e6a4e858] Instance instance-0000036d Disk Upload attempt #1 failed. Retrying the upload.","commit_id":"5d70a112c813c4a393dcffb0ef6664c0062ebe97"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"fe65a13ffd102b60b215721eec3925bb1355fb14","unresolved":false,"context_lines":[{"line_number":329,"context_line":"                                    \"upload.\"),"},{"line_number":330,"context_line":"                                {\"attempt\": attempt,"},{"line_number":331,"context_line":"                                \"inst\": instance.name}, instance\u003dinstance)"},{"line_number":332,"context_line":"                    LOG.exception(error)"},{"line_number":333,"context_line":"                else:"},{"line_number":334,"context_line":"                    raise"},{"line_number":335,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_7c410639","line":332,"range":{"start_line":332,"start_character":20,"end_line":332,"end_character":40},"updated":"2016-12-08 18:23:49.000000000","message":"Should probably flip the order of this.  Log the exception first, and then the fact that you\u0027re retrying.\n\nOr indicate in the log message that you are printing the exception for debug purposes (or something of that sort).","commit_id":"5d70a112c813c4a393dcffb0ef6664c0062ebe97"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"ad0265d31a1285a73af062943674108a43c52f70","unresolved":false,"context_lines":[{"line_number":329,"context_line":"                                    \"#%(attempt)d failed. Retrying the \""},{"line_number":330,"context_line":"                                    \"upload.\"),"},{"line_number":331,"context_line":"                                {\"attempt\": attempt,"},{"line_number":332,"context_line":"                                \"inst\": instance.name}, instance\u003dinstance)"},{"line_number":333,"context_line":"                else:"},{"line_number":334,"context_line":"                    raise"},{"line_number":335,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_f267fdb4","line":332,"range":{"start_line":332,"start_character":18,"end_line":332,"end_character":74},"updated":"2016-12-08 19:22:46.000000000","message":"Kris and I were talking about possibly adding jitter (maybe a randomized sleep statement) when we\u0027re going to retry.  Thoughts?","commit_id":"fb6030cb682c5bfb492825ae051283c94cea8d64"}],"nova_powervm/virt/powervm/disk/localdisk.py":[{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"96bfdd7d9ef3cf1db410af2f2f7491cb0288ac11","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    def _create_disk_from_image(self, context, instance, image_meta, disk_size,"},{"line_number":172,"context_line":"                                image_type\u003ddisk_dvr.DiskType.BOOT):"},{"line_number":173,"context_line":"        \"\"\"Creates a disk and copies the specified image to it."},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        :param context: nova context used to retrieve image from glance"},{"line_number":176,"context_line":"        :param instance: instance to create the disk for."},{"line_number":177,"context_line":"        :param nova.objects.ImageMeta image_meta:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_a23965f4","line":174,"updated":"2016-12-05 16:07:53.000000000","message":"Doc updates from parent should be reflected in children as well.","commit_id":"6f638b2c8ee15cb98e0ff6a758679d9caa2cbde4"}]}
