)]}'
{"nova_powervm/virt/powervm/driver.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"7ec0db168cc473cf74e8643ed180a9809448adcd","unresolved":false,"context_lines":[{"line_number":944,"context_line":"        \"\"\""},{"line_number":945,"context_line":"        self._log_operation(\u0027power_off\u0027, instance)"},{"line_number":946,"context_line":"        force_immediate \u003d (timeout \u003d\u003d 0)"},{"line_number":947,"context_line":"        timeout \u003d None if force_immediate else timeout"},{"line_number":948,"context_line":"        vm.power_off(self.adapter, instance, self.host_uuid,"},{"line_number":949,"context_line":"                     force_immediate\u003dforce_immediate, timeout\u003dtimeout)"},{"line_number":950,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_b334e0fb","line":947,"updated":"2017-01-24 18:08:35.000000000","message":"This is a bit convoluted; suggest:\n\n timeout \u003d timeout if timeout else None","commit_id":"5b797d10b008f029b62d41c57abb7357c3d39e7e"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"bcb10b89aed5c2e6fbc621e64a9a5f64f6169c1f","unresolved":false,"context_lines":[{"line_number":944,"context_line":"        \"\"\""},{"line_number":945,"context_line":"        self._log_operation(\u0027power_off\u0027, instance)"},{"line_number":946,"context_line":"        force_immediate \u003d (timeout \u003d\u003d 0)"},{"line_number":947,"context_line":"        timeout \u003d None if force_immediate else timeout"},{"line_number":948,"context_line":"        vm.power_off(self.adapter, instance, self.host_uuid,"},{"line_number":949,"context_line":"                     force_immediate\u003dforce_immediate, timeout\u003dtimeout)"},{"line_number":950,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_f65ad629","line":947,"in_reply_to":"5a3905b3_b334e0fb","updated":"2017-01-24 18:09:30.000000000","message":"Or even:\n\n timeout \u003d timeout or None","commit_id":"5b797d10b008f029b62d41c57abb7357c3d39e7e"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"da933306a58fb5a0c24ad4c882fc39c3c26f8f08","unresolved":false,"context_lines":[{"line_number":944,"context_line":"        \"\"\""},{"line_number":945,"context_line":"        self._log_operation(\u0027power_off\u0027, instance)"},{"line_number":946,"context_line":"        force_immediate \u003d (timeout \u003d\u003d 0)"},{"line_number":947,"context_line":"        timeout \u003d None if force_immediate else timeout"},{"line_number":948,"context_line":"        vm.power_off(self.adapter, instance, self.host_uuid,"},{"line_number":949,"context_line":"                     force_immediate\u003dforce_immediate, timeout\u003dtimeout)"},{"line_number":950,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_166762eb","line":947,"in_reply_to":"5a3905b3_f65ad629","updated":"2017-01-24 18:21:24.000000000","message":"Done","commit_id":"5b797d10b008f029b62d41c57abb7357c3d39e7e"}],"nova_powervm/virt/powervm/vm.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"7ec0db168cc473cf74e8643ed180a9809448adcd","unresolved":false,"context_lines":[{"line_number":664,"context_line":""},{"line_number":665,"context_line":"def power_off(adapter, instance, host_uuid, entry\u003dNone, add_parms\u003dNone,"},{"line_number":666,"context_line":"              force_immediate\u003dFalse, timeout\u003dNone):"},{"line_number":667,"context_line":"    \"\"\"Power\u0027s Off a VM."},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"    :param instance: The nova instance."},{"line_number":670,"context_line":"    :param host_uuid: The uuid of the host."}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_9329a4f5","line":667,"range":{"start_line":667,"start_character":7,"end_line":667,"end_character":14},"updated":"2017-01-24 18:08:35.000000000","message":"Powers","commit_id":"5b797d10b008f029b62d41c57abb7357c3d39e7e"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"da933306a58fb5a0c24ad4c882fc39c3c26f8f08","unresolved":false,"context_lines":[{"line_number":664,"context_line":""},{"line_number":665,"context_line":"def power_off(adapter, instance, host_uuid, entry\u003dNone, add_parms\u003dNone,"},{"line_number":666,"context_line":"              force_immediate\u003dFalse, timeout\u003dNone):"},{"line_number":667,"context_line":"    \"\"\"Power\u0027s Off a VM."},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"    :param instance: The nova instance."},{"line_number":670,"context_line":"    :param host_uuid: The uuid of the host."}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_b69e8eb6","line":667,"range":{"start_line":667,"start_character":7,"end_line":667,"end_character":14},"in_reply_to":"5a3905b3_9329a4f5","updated":"2017-01-24 18:21:24.000000000","message":"Done","commit_id":"5b797d10b008f029b62d41c57abb7357c3d39e7e"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"7ec0db168cc473cf74e8643ed180a9809448adcd","unresolved":false,"context_lines":[{"line_number":670,"context_line":"    :param host_uuid: The uuid of the host."},{"line_number":671,"context_line":"    :param entry: (Optional) The pypowervm wrapper for the entry.  If not"},{"line_number":672,"context_line":"                  provided, will be looked up."},{"line_number":673,"context_line":"    :param add_parms: (Optional) Additional parameters."},{"line_number":674,"context_line":"    :param force_immediate: (Optional, Default False) Should it be immediately"},{"line_number":675,"context_line":"                            shut down."},{"line_number":676,"context_line":"    :param timeout: (Optional, Default None) How long to wait for the job"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_734518b2","line":673,"updated":"2017-01-24 18:08:35.000000000","message":"...to the pypowervm power_off method.  See that method\u0027s docstring for details.","commit_id":"5b797d10b008f029b62d41c57abb7357c3d39e7e"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"da933306a58fb5a0c24ad4c882fc39c3c26f8f08","unresolved":false,"context_lines":[{"line_number":670,"context_line":"    :param host_uuid: The uuid of the host."},{"line_number":671,"context_line":"    :param entry: (Optional) The pypowervm wrapper for the entry.  If not"},{"line_number":672,"context_line":"                  provided, will be looked up."},{"line_number":673,"context_line":"    :param add_parms: (Optional) Additional parameters."},{"line_number":674,"context_line":"    :param force_immediate: (Optional, Default False) Should it be immediately"},{"line_number":675,"context_line":"                            shut down."},{"line_number":676,"context_line":"    :param timeout: (Optional, Default None) How long to wait for the job"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_36ab7ed8","line":673,"in_reply_to":"5a3905b3_734518b2","updated":"2017-01-24 18:21:24.000000000","message":"Done","commit_id":"5b797d10b008f029b62d41c57abb7357c3d39e7e"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"7ec0db168cc473cf74e8643ed180a9809448adcd","unresolved":false,"context_lines":[{"line_number":674,"context_line":"    :param force_immediate: (Optional, Default False) Should it be immediately"},{"line_number":675,"context_line":"                            shut down."},{"line_number":676,"context_line":"    :param timeout: (Optional, Default None) How long to wait for the job"},{"line_number":677,"context_line":"                    to complete.  If not provided, uses the base pypowervm"},{"line_number":678,"context_line":"                    timeout."},{"line_number":679,"context_line":"    :return: True if it was stopped.  False if it was not in a stoppable state."},{"line_number":680,"context_line":"    :raises: InstancePowerOffFailure"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_130bf42c","line":677,"range":{"start_line":677,"start_character":37,"end_line":677,"end_character":49},"updated":"2017-01-24 18:08:35.000000000","message":"(not provided or) None\n\n...since the latter is actually how you\u0027re using it.","commit_id":"5b797d10b008f029b62d41c57abb7357c3d39e7e"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"da933306a58fb5a0c24ad4c882fc39c3c26f8f08","unresolved":false,"context_lines":[{"line_number":674,"context_line":"    :param force_immediate: (Optional, Default False) Should it be immediately"},{"line_number":675,"context_line":"                            shut down."},{"line_number":676,"context_line":"    :param timeout: (Optional, Default None) How long to wait for the job"},{"line_number":677,"context_line":"                    to complete.  If not provided, uses the base pypowervm"},{"line_number":678,"context_line":"                    timeout."},{"line_number":679,"context_line":"    :return: True if it was stopped.  False if it was not in a stoppable state."},{"line_number":680,"context_line":"    :raises: InstancePowerOffFailure"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_36d9be84","line":677,"range":{"start_line":677,"start_character":37,"end_line":677,"end_character":49},"in_reply_to":"5a3905b3_130bf42c","updated":"2017-01-24 18:21:24.000000000","message":"Done","commit_id":"5b797d10b008f029b62d41c57abb7357c3d39e7e"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"7ec0db168cc473cf74e8643ed180a9809448adcd","unresolved":false,"context_lines":[{"line_number":692,"context_line":"        try:"},{"line_number":693,"context_line":"            LOG.debug(\"Power off executing for instance %(inst)s.\","},{"line_number":694,"context_line":"                      {\u0027inst\u0027: instance.name})"},{"line_number":695,"context_line":"            if timeout:"},{"line_number":696,"context_line":"                power.power_off("},{"line_number":697,"context_line":"                    entry, host_uuid, force_immediate\u003dforce_immediate,"},{"line_number":698,"context_line":"                    add_parms\u003dadd_parms, timeout\u003dtimeout)"},{"line_number":699,"context_line":"            else:"},{"line_number":700,"context_line":"                power.power_off("},{"line_number":701,"context_line":"                    entry, host_uuid, force_immediate\u003dforce_immediate,"},{"line_number":702,"context_line":"                    add_parms\u003dadd_parms)"},{"line_number":703,"context_line":"        except Exception as e:"},{"line_number":704,"context_line":"            LOG.exception(e)"},{"line_number":705,"context_line":"            raise exception.InstancePowerOffFailure(reason\u003dsix.text_type(e))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_73f8b84a","line":702,"range":{"start_line":695,"start_character":0,"end_line":702,"end_character":40},"updated":"2017-01-24 18:08:35.000000000","message":"Icky.\n\nAlso icky, but possibly slightly less icky:\n\n kwargs \u003d {\u0027timeout\u0027: timeout} if timeout else {}\n power.power_off(..., **kwargs)","commit_id":"5b797d10b008f029b62d41c57abb7357c3d39e7e"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"da933306a58fb5a0c24ad4c882fc39c3c26f8f08","unresolved":false,"context_lines":[{"line_number":692,"context_line":"        try:"},{"line_number":693,"context_line":"            LOG.debug(\"Power off executing for instance %(inst)s.\","},{"line_number":694,"context_line":"                      {\u0027inst\u0027: instance.name})"},{"line_number":695,"context_line":"            if timeout:"},{"line_number":696,"context_line":"                power.power_off("},{"line_number":697,"context_line":"                    entry, host_uuid, force_immediate\u003dforce_immediate,"},{"line_number":698,"context_line":"                    add_parms\u003dadd_parms, timeout\u003dtimeout)"},{"line_number":699,"context_line":"            else:"},{"line_number":700,"context_line":"                power.power_off("},{"line_number":701,"context_line":"                    entry, host_uuid, force_immediate\u003dforce_immediate,"},{"line_number":702,"context_line":"                    add_parms\u003dadd_parms)"},{"line_number":703,"context_line":"        except Exception as e:"},{"line_number":704,"context_line":"            LOG.exception(e)"},{"line_number":705,"context_line":"            raise exception.InstancePowerOffFailure(reason\u003dsix.text_type(e))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_d63f9a85","line":702,"range":{"start_line":695,"start_character":0,"end_line":702,"end_character":40},"in_reply_to":"5a3905b3_73f8b84a","updated":"2017-01-24 18:21:24.000000000","message":"Done","commit_id":"5b797d10b008f029b62d41c57abb7357c3d39e7e"}]}