)]}'
{"nova_powervm/virt/powervm/disk/localdisk.py":[{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"0a1515e93e5b73a1d1c9b829a3fc3fa59689a9be","unresolved":false,"context_lines":[{"line_number":313,"context_line":"                raise nova_exc.DiskNotFound("},{"line_number":314,"context_line":"                    location\u003dself.vg_name + \u0027/\u0027 + vol_name)"},{"line_number":315,"context_line":"            if (disk_found.backstore_type \u003d\u003d pvm_stg.BackStoreType.USER_QCOW"},{"line_number":316,"context_line":"               and disk_found.file_format !\u003d pvm_stg.FileFormatType.RAW):"},{"line_number":317,"context_line":"                raise nova_exc.ResizeError(reason\u003d\"Can only resize RAW files.\")"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"            # Set the new size"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_468e0a79","line":316,"updated":"2017-05-04 16:42:07.000000000","message":"Does this pass pep8?","commit_id":"2f4dcee698f2c29f4c5c58594c079e1664d513bf"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"aad3458e47ee8350894c37e22a483d740fc12b1d","unresolved":false,"context_lines":[{"line_number":313,"context_line":"                raise nova_exc.DiskNotFound("},{"line_number":314,"context_line":"                    location\u003dself.vg_name + \u0027/\u0027 + vol_name)"},{"line_number":315,"context_line":"            if (disk_found.backstore_type \u003d\u003d pvm_stg.BackStoreType.USER_QCOW"},{"line_number":316,"context_line":"               and disk_found.file_format !\u003d pvm_stg.FileFormatType.RAW):"},{"line_number":317,"context_line":"                raise nova_exc.ResizeError(reason\u003d\"Can only resize RAW files.\")"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"            # Set the new size"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_7b6634f0","line":316,"in_reply_to":"3f044301_268f7e24","updated":"2017-05-04 21:50:19.000000000","message":"Probably only because we\u0027re ignoring E125.  There\u0027s really no good way to make these pretty.","commit_id":"2f4dcee698f2c29f4c5c58594c079e1664d513bf"},{"author":{"_account_id":21099,"name":"Taylor Jakobson","email":"tjakobs@us.ibm.com","username":"tjakobs"},"change_message_id":"2a6aea26b1e1531d537c8a85a87b25462bd5de2f","unresolved":false,"context_lines":[{"line_number":313,"context_line":"                raise nova_exc.DiskNotFound("},{"line_number":314,"context_line":"                    location\u003dself.vg_name + \u0027/\u0027 + vol_name)"},{"line_number":315,"context_line":"            if (disk_found.backstore_type \u003d\u003d pvm_stg.BackStoreType.USER_QCOW"},{"line_number":316,"context_line":"               and disk_found.file_format !\u003d pvm_stg.FileFormatType.RAW):"},{"line_number":317,"context_line":"                raise nova_exc.ResizeError(reason\u003d\"Can only resize RAW files.\")"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"            # Set the new size"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_268f7e24","line":316,"in_reply_to":"3f044301_468e0a79","updated":"2017-05-04 17:08:56.000000000","message":"tox -e pep8 passes","commit_id":"2f4dcee698f2c29f4c5c58594c079e1664d513bf"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"0a1515e93e5b73a1d1c9b829a3fc3fa59689a9be","unresolved":false,"context_lines":[{"line_number":314,"context_line":"                    location\u003dself.vg_name + \u0027/\u0027 + vol_name)"},{"line_number":315,"context_line":"            if (disk_found.backstore_type \u003d\u003d pvm_stg.BackStoreType.USER_QCOW"},{"line_number":316,"context_line":"               and disk_found.file_format !\u003d pvm_stg.FileFormatType.RAW):"},{"line_number":317,"context_line":"                raise nova_exc.ResizeError(reason\u003d\"Can only resize RAW files.\")"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"            # Set the new size"},{"line_number":320,"context_line":"            disk_found.capacity \u003d size"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_46b5ea30","line":317,"updated":"2017-05-04 16:42:07.000000000","message":"Does this need to be translated?  I know log messages aren\u0027t anymore...but this seems like it needs to be.","commit_id":"2f4dcee698f2c29f4c5c58594c079e1664d513bf"},{"author":{"_account_id":21099,"name":"Taylor Jakobson","email":"tjakobs@us.ibm.com","username":"tjakobs"},"change_message_id":"2a6aea26b1e1531d537c8a85a87b25462bd5de2f","unresolved":false,"context_lines":[{"line_number":314,"context_line":"                    location\u003dself.vg_name + \u0027/\u0027 + vol_name)"},{"line_number":315,"context_line":"            if (disk_found.backstore_type \u003d\u003d pvm_stg.BackStoreType.USER_QCOW"},{"line_number":316,"context_line":"               and disk_found.file_format !\u003d pvm_stg.FileFormatType.RAW):"},{"line_number":317,"context_line":"                raise nova_exc.ResizeError(reason\u003d\"Can only resize RAW files.\")"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"            # Set the new size"},{"line_number":320,"context_line":"            disk_found.capacity \u003d size"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_869f724f","line":317,"in_reply_to":"3f044301_46b5ea30","updated":"2017-05-04 17:08:56.000000000","message":"Seems reasonable to me for this to be translated. Is there something I need to do?","commit_id":"2f4dcee698f2c29f4c5c58594c079e1664d513bf"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"aad3458e47ee8350894c37e22a483d740fc12b1d","unresolved":false,"context_lines":[{"line_number":314,"context_line":"                    location\u003dself.vg_name + \u0027/\u0027 + vol_name)"},{"line_number":315,"context_line":"            if (disk_found.backstore_type \u003d\u003d pvm_stg.BackStoreType.USER_QCOW"},{"line_number":316,"context_line":"               and disk_found.file_format !\u003d pvm_stg.FileFormatType.RAW):"},{"line_number":317,"context_line":"                raise nova_exc.ResizeError(reason\u003d\"Can only resize RAW files.\")"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"            # Set the new size"},{"line_number":320,"context_line":"            disk_found.capacity \u003d size"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_9b40e037","line":317,"in_reply_to":"3f044301_869f724f","updated":"2017-05-04 21:50:19.000000000","message":"Yeah, you need to say:\n\n reason\u003d_(\"Can only resize RAW files.\")","commit_id":"2f4dcee698f2c29f4c5c58594c079e1664d513bf"},{"author":{"_account_id":21099,"name":"Taylor Jakobson","email":"tjakobs@us.ibm.com","username":"tjakobs"},"change_message_id":"aedc9a39e9e9e394921f73961fd575d750dbd91f","unresolved":false,"context_lines":[{"line_number":314,"context_line":"                    location\u003dself.vg_name + \u0027/\u0027 + vol_name)"},{"line_number":315,"context_line":"            if (disk_found.backstore_type \u003d\u003d pvm_stg.BackStoreType.USER_QCOW"},{"line_number":316,"context_line":"               and disk_found.file_format !\u003d pvm_stg.FileFormatType.RAW):"},{"line_number":317,"context_line":"                raise nova_exc.ResizeError(reason\u003d\"Can only resize RAW files.\")"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"            # Set the new size"},{"line_number":320,"context_line":"            disk_found.capacity \u003d size"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_1b2bb0eb","line":317,"in_reply_to":"3f044301_9b40e037","updated":"2017-05-05 13:55:44.000000000","message":"Done","commit_id":"2f4dcee698f2c29f4c5c58594c079e1664d513bf"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"0a1515e93e5b73a1d1c9b829a3fc3fa59689a9be","unresolved":false,"context_lines":[{"line_number":330,"context_line":"                                             client_lpar_id\u003dlpar_uuid,"},{"line_number":331,"context_line":"                                             stg_elem\u003ddisk_found)"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"                # Remap the disk to refresh the size"},{"line_number":334,"context_line":"                for mapping in mappings:"},{"line_number":335,"context_line":"                    self.disconnect_disk(instance)"},{"line_number":336,"context_line":"                    target_dev \u003d mapping.target_dev"},{"line_number":337,"context_line":"                    self.connect_disk(instance, disk_found,"},{"line_number":338,"context_line":"                                      lua\u003dtarget_dev.lua,"},{"line_number":339,"context_line":"                                      target_name\u003dtarget_dev.name)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        # Get the disk name based on the instance and type"},{"line_number":342,"context_line":"        vol_name \u003d self._get_disk_name(disk_info[\u0027type\u0027], instance, short\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_26e9be19","line":339,"range":{"start_line":333,"start_character":0,"end_line":339,"end_character":66},"updated":"2017-05-04 16:42:07.000000000","message":"We really have to full blown remap??  What does the client think here?","commit_id":"2f4dcee698f2c29f4c5c58594c079e1664d513bf"},{"author":{"_account_id":21099,"name":"Taylor Jakobson","email":"tjakobs@us.ibm.com","username":"tjakobs"},"change_message_id":"2a6aea26b1e1531d537c8a85a87b25462bd5de2f","unresolved":false,"context_lines":[{"line_number":330,"context_line":"                                             client_lpar_id\u003dlpar_uuid,"},{"line_number":331,"context_line":"                                             stg_elem\u003ddisk_found)"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"                # Remap the disk to refresh the size"},{"line_number":334,"context_line":"                for mapping in mappings:"},{"line_number":335,"context_line":"                    self.disconnect_disk(instance)"},{"line_number":336,"context_line":"                    target_dev \u003d mapping.target_dev"},{"line_number":337,"context_line":"                    self.connect_disk(instance, disk_found,"},{"line_number":338,"context_line":"                                      lua\u003dtarget_dev.lua,"},{"line_number":339,"context_line":"                                      target_name\u003dtarget_dev.name)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        # Get the disk name based on the instance and type"},{"line_number":342,"context_line":"        vol_name \u003d self._get_disk_name(disk_info[\u0027type\u0027], instance, short\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_290511c3","line":339,"range":{"start_line":333,"start_character":0,"end_line":339,"end_character":66},"in_reply_to":"3f044301_26e9be19","updated":"2017-05-04 17:08:56.000000000","message":"The user:qcow handler doesn\u0027t currently support resizing. So the backstore needs to be remapped.\n\nThe client is powered off during the resize/remap flow. Once the client is back on I haven\u0027t found any issues. (Unless the backing storage is a qcow2 file, which is why that errors out above).","commit_id":"2f4dcee698f2c29f4c5c58594c079e1664d513bf"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"1814e5f461e660e3ce40990cec8a94d824a322f6","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            return image.udid"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def connect_disk(self, instance, disk_info, stg_ftsk\u003dNone,"},{"line_number":256,"context_line":"                     lua\u003dNone, target_name\u003dNone):"},{"line_number":257,"context_line":"        \"\"\"Connects the disk image to the Virtual Machine."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        :param instance: nova instance to connect the disk to."}],"source_content_type":"text/x-python","patch_set":4,"id":"1f013ff3_e44a957e","line":256,"range":{"start_line":256,"start_character":21,"end_line":256,"end_character":47},"updated":"2017-05-16 12:02:52.000000000","message":"So I\u0027m probably being nitpicky here, but this method implements an interface set up by the parent class.  You\u0027re now adding things for an internal use here.\n\nI\u0027d prefer we refactor this to be _connect_disk.\n\nWe would still have a connect_disk that does nothing but call _connect_disk and leave off the lua/target_name parameters.","commit_id":"c12166e355f0544172354793b7a4ff5a82239442"},{"author":{"_account_id":21099,"name":"Taylor Jakobson","email":"tjakobs@us.ibm.com","username":"tjakobs"},"change_message_id":"608f238974d3b061bc78de1d30f3cf923c9fe5ca","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            return image.udid"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def connect_disk(self, instance, disk_info, stg_ftsk\u003dNone,"},{"line_number":256,"context_line":"                     lua\u003dNone, target_name\u003dNone):"},{"line_number":257,"context_line":"        \"\"\"Connects the disk image to the Virtual Machine."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        :param instance: nova instance to connect the disk to."}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_047c0170","line":256,"range":{"start_line":256,"start_character":21,"end_line":256,"end_character":47},"in_reply_to":"1f013ff3_e44a957e","updated":"2017-05-23 05:29:10.000000000","message":"These arguments were added to support remapping a vdisk. Support for remapping is remove in PS5; thus, this is no longer required.","commit_id":"c12166e355f0544172354793b7a4ff5a82239442"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"1814e5f461e660e3ce40990cec8a94d824a322f6","unresolved":false,"context_lines":[{"line_number":265,"context_line":"                         mapping updates will be added to the FeedTask.  This"},{"line_number":266,"context_line":"                         defers the updates to some later point in time.  If"},{"line_number":267,"context_line":"                         the FeedTask is not provided, the updates will be run"},{"line_number":268,"context_line":"                         immediately when this method is executed."},{"line_number":269,"context_line":"        \"\"\""},{"line_number":270,"context_line":"        lpar_uuid \u003d vm.get_pvm_uuid(instance)"},{"line_number":271,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f013ff3_8407511d","line":268,"range":{"start_line":268,"start_character":0,"end_line":268,"end_character":66},"updated":"2017-05-16 12:02:52.000000000","message":"Need to add lua / target_name.","commit_id":"c12166e355f0544172354793b7a4ff5a82239442"},{"author":{"_account_id":21099,"name":"Taylor Jakobson","email":"tjakobs@us.ibm.com","username":"tjakobs"},"change_message_id":"608f238974d3b061bc78de1d30f3cf923c9fe5ca","unresolved":false,"context_lines":[{"line_number":265,"context_line":"                         mapping updates will be added to the FeedTask.  This"},{"line_number":266,"context_line":"                         defers the updates to some later point in time.  If"},{"line_number":267,"context_line":"                         the FeedTask is not provided, the updates will be run"},{"line_number":268,"context_line":"                         immediately when this method is executed."},{"line_number":269,"context_line":"        \"\"\""},{"line_number":270,"context_line":"        lpar_uuid \u003d vm.get_pvm_uuid(instance)"},{"line_number":271,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_c49969c4","line":268,"range":{"start_line":268,"start_character":0,"end_line":268,"end_character":66},"in_reply_to":"1f013ff3_8407511d","updated":"2017-05-23 05:29:10.000000000","message":"(see previous comment)","commit_id":"c12166e355f0544172354793b7a4ff5a82239442"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"1814e5f461e660e3ce40990cec8a94d824a322f6","unresolved":false,"context_lines":[{"line_number":304,"context_line":"            disk_found \u003d None"},{"line_number":305,"context_line":"            for vdisk in vdisks:"},{"line_number":306,"context_line":"                # Vdisk name can be either disk_name or /path/to/disk_name"},{"line_number":307,"context_line":"                if vdisk.name.split(\u0027/\u0027)[-1] \u003d\u003d vol_name.split(\u0027/\u0027)[-1]:"},{"line_number":308,"context_line":"                    disk_found \u003d vdisk"},{"line_number":309,"context_line":"                    break"},{"line_number":310,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f013ff3_8492b1f5","line":307,"range":{"start_line":307,"start_character":40,"end_line":307,"end_character":45},"updated":"2017-05-16 12:02:52.000000000","message":"-1?","commit_id":"c12166e355f0544172354793b7a4ff5a82239442"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"07c0448cd79cd8ea2b83ef2164ff1a44fe7ae219","unresolved":false,"context_lines":[{"line_number":304,"context_line":"            disk_found \u003d None"},{"line_number":305,"context_line":"            for vdisk in vdisks:"},{"line_number":306,"context_line":"                # Vdisk name can be either disk_name or /path/to/disk_name"},{"line_number":307,"context_line":"                if vdisk.name.split(\u0027/\u0027)[-1] \u003d\u003d vol_name.split(\u0027/\u0027)[-1]:"},{"line_number":308,"context_line":"                    disk_found \u003d vdisk"},{"line_number":309,"context_line":"                    break"},{"line_number":310,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_f2067a1c","line":307,"range":{"start_line":307,"start_character":40,"end_line":307,"end_character":45},"in_reply_to":"1f013ff3_8492b1f5","updated":"2017-05-22 21:57:04.000000000","message":"Per the comment, this is to accomodate the fact that the name can either be disk_name or /path/to/disk_name.  Taking the last element of a split on \u0027/\u0027 will get the disk_name part either way.\n\nArguably more efficient as rsplit(\u0027/\u0027, 1), but not worth the extra hspace ;-)","commit_id":"c12166e355f0544172354793b7a4ff5a82239442"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"1814e5f461e660e3ce40990cec8a94d824a322f6","unresolved":false,"context_lines":[{"line_number":313,"context_line":"                          instance\u003dinstance)"},{"line_number":314,"context_line":"                raise nova_exc.DiskNotFound("},{"line_number":315,"context_line":"                    location\u003dself.vg_name + \u0027/\u0027 + vol_name)"},{"line_number":316,"context_line":"            if (disk_found.backstore_type \u003d\u003d pvm_stg.BackStoreType.USER_QCOW"},{"line_number":317,"context_line":"               and disk_found.file_format !\u003d pvm_stg.FileFormatType.RAW):"},{"line_number":318,"context_line":"                raise nova_exc.ResizeError("},{"line_number":319,"context_line":"                    reason\u003d_(\"Can only resize RAW files.\"))"},{"line_number":320,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f013ff3_1f2dc894","line":317,"range":{"start_line":316,"start_character":12,"end_line":317,"end_character":73},"updated":"2017-05-16 12:02:52.000000000","message":"Are we planning to add more of these types?  I wouldn\u0027t mind a _validate_resizable method that starts out just with this check.","commit_id":"c12166e355f0544172354793b7a4ff5a82239442"},{"author":{"_account_id":21099,"name":"Taylor Jakobson","email":"tjakobs@us.ibm.com","username":"tjakobs"},"change_message_id":"608f238974d3b061bc78de1d30f3cf923c9fe5ca","unresolved":false,"context_lines":[{"line_number":313,"context_line":"                          instance\u003dinstance)"},{"line_number":314,"context_line":"                raise nova_exc.DiskNotFound("},{"line_number":315,"context_line":"                    location\u003dself.vg_name + \u0027/\u0027 + vol_name)"},{"line_number":316,"context_line":"            if (disk_found.backstore_type \u003d\u003d pvm_stg.BackStoreType.USER_QCOW"},{"line_number":317,"context_line":"               and disk_found.file_format !\u003d pvm_stg.FileFormatType.RAW):"},{"line_number":318,"context_line":"                raise nova_exc.ResizeError("},{"line_number":319,"context_line":"                    reason\u003d_(\"Can only resize RAW files.\"))"},{"line_number":320,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_4c30ede8","line":317,"range":{"start_line":316,"start_character":12,"end_line":317,"end_character":73},"in_reply_to":"1f013ff3_1f2dc894","updated":"2017-05-23 05:29:10.000000000","message":"Done","commit_id":"c12166e355f0544172354793b7a4ff5a82239442"},{"author":{"_account_id":20138,"name":"Steven Royer","email":"seroyer@us.ibm.com","username":"seroyer"},"change_message_id":"7394c33fa0f9b321a4741d15c0adb1b8bcca4ed5","unresolved":false,"context_lines":[{"line_number":313,"context_line":"                          instance\u003dinstance)"},{"line_number":314,"context_line":"                raise nova_exc.DiskNotFound("},{"line_number":315,"context_line":"                    location\u003dself.vg_name + \u0027/\u0027 + vol_name)"},{"line_number":316,"context_line":"            if (disk_found.backstore_type \u003d\u003d pvm_stg.BackStoreType.USER_QCOW"},{"line_number":317,"context_line":"               and disk_found.file_format !\u003d pvm_stg.FileFormatType.RAW):"},{"line_number":318,"context_line":"                raise nova_exc.ResizeError("},{"line_number":319,"context_line":"                    reason\u003d_(\"Can only resize RAW files.\"))"},{"line_number":320,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_fc8328a8","line":317,"range":{"start_line":316,"start_character":12,"end_line":317,"end_character":73},"in_reply_to":"1f013ff3_1f2dc894","updated":"2017-05-19 20:35:32.000000000","message":"We could support more types in the future.  In particular qcow2, Ceph RBD, or glfs.  Can\u0027t resize qcow2 at the moment, but I think we could resize RBD and glfs.","commit_id":"c12166e355f0544172354793b7a4ff5a82239442"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"1814e5f461e660e3ce40990cec8a94d824a322f6","unresolved":false,"context_lines":[{"line_number":323,"context_line":""},{"line_number":324,"context_line":"            # Post it to the VIOS"},{"line_number":325,"context_line":"            vg_wrap.update()"},{"line_number":326,"context_line":"            if disk_found.backstore_type \u003d\u003d pvm_stg.BackStoreType.USER_QCOW:"},{"line_number":327,"context_line":"                # Get mapping before removing to save target_name and lua"},{"line_number":328,"context_line":"                lpar_uuid \u003d vm.get_pvm_uuid(instance)"},{"line_number":329,"context_line":"                vios_w \u003d pvm_vios.VIOS.get(self.adapter, uuid\u003dself._vios_uuid,"},{"line_number":330,"context_line":"                                           xag\u003d[pvm_const.XAG.VIO_SMAP])"},{"line_number":331,"context_line":"                mappings \u003d tsk_map.find_maps(vios_w.scsi_mappings,"},{"line_number":332,"context_line":"                                             client_lpar_id\u003dlpar_uuid,"},{"line_number":333,"context_line":"                                             stg_elem\u003ddisk_found)"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"                # Remap the disk to refresh the size"},{"line_number":336,"context_line":"                for mapping in mappings:"},{"line_number":337,"context_line":"                    self.disconnect_disk(instance)"},{"line_number":338,"context_line":"                    target_dev \u003d mapping.target_dev"},{"line_number":339,"context_line":"                    self.connect_disk(instance, disk_found,"},{"line_number":340,"context_line":"                                      lua\u003dtarget_dev.lua,"},{"line_number":341,"context_line":"                                      target_name\u003dtarget_dev.name)"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        # Get the disk name based on the instance and type"},{"line_number":344,"context_line":"        vol_name \u003d self._get_disk_name(disk_info[\u0027type\u0027], instance, short\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f013ff3_84abd11b","line":341,"range":{"start_line":326,"start_character":0,"end_line":341,"end_character":66},"updated":"2017-05-16 12:02:52.000000000","message":"Can we separate this into a new method...\n\nI\u0027m still pretty uneasy with this, but if seroyer gives a +1 on this then I\u0027ll take his word that this is the right approach.  I guess I would have just blown up if they tried to resize something that couldn\u0027t be resized.\n\nMaybe check the state of the VM and only allow resize if powered off.\n\n\nAnother question...should we just ask the REST layer to detect this combination and do the disconn/reconn?","commit_id":"c12166e355f0544172354793b7a4ff5a82239442"},{"author":{"_account_id":20138,"name":"Steven Royer","email":"seroyer@us.ibm.com","username":"seroyer"},"change_message_id":"7394c33fa0f9b321a4741d15c0adb1b8bcca4ed5","unresolved":false,"context_lines":[{"line_number":323,"context_line":""},{"line_number":324,"context_line":"            # Post it to the VIOS"},{"line_number":325,"context_line":"            vg_wrap.update()"},{"line_number":326,"context_line":"            if disk_found.backstore_type \u003d\u003d pvm_stg.BackStoreType.USER_QCOW:"},{"line_number":327,"context_line":"                # Get mapping before removing to save target_name and lua"},{"line_number":328,"context_line":"                lpar_uuid \u003d vm.get_pvm_uuid(instance)"},{"line_number":329,"context_line":"                vios_w \u003d pvm_vios.VIOS.get(self.adapter, uuid\u003dself._vios_uuid,"},{"line_number":330,"context_line":"                                           xag\u003d[pvm_const.XAG.VIO_SMAP])"},{"line_number":331,"context_line":"                mappings \u003d tsk_map.find_maps(vios_w.scsi_mappings,"},{"line_number":332,"context_line":"                                             client_lpar_id\u003dlpar_uuid,"},{"line_number":333,"context_line":"                                             stg_elem\u003ddisk_found)"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"                # Remap the disk to refresh the size"},{"line_number":336,"context_line":"                for mapping in mappings:"},{"line_number":337,"context_line":"                    self.disconnect_disk(instance)"},{"line_number":338,"context_line":"                    target_dev \u003d mapping.target_dev"},{"line_number":339,"context_line":"                    self.connect_disk(instance, disk_found,"},{"line_number":340,"context_line":"                                      lua\u003dtarget_dev.lua,"},{"line_number":341,"context_line":"                                      target_name\u003dtarget_dev.name)"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        # Get the disk name based on the instance and type"},{"line_number":344,"context_line":"        vol_name \u003d self._get_disk_name(disk_info[\u0027type\u0027], instance, short\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_1c56dc5d","line":341,"range":{"start_line":326,"start_character":0,"end_line":341,"end_character":66},"in_reply_to":"1f013ff3_84abd11b","updated":"2017-05-19 20:35:32.000000000","message":"Two things:\n\n* tcmu-runner doesn\u0027t currently support resizing.  bgly is working on it, but upstream wants a more robust solution that requires kernel changes as well.\n\n* Even when tcmu-runner does support it, we\u0027ll need to detect the change in LIO.  Could be done via nova-powervm/rest for ephemeral, but that doesn\u0027t work for volumes.  So, we could instead have code on the NovaLink that scans periodically for changes.\n\nBarring those two tasks being complete, the only way to support resize is to unmap/remap.  I don\u0027t have a problem with saying resize isn\u0027t supported until the above tasks are complete if thorst says resize isn\u0027t required for now.","commit_id":"c12166e355f0544172354793b7a4ff5a82239442"},{"author":{"_account_id":21099,"name":"Taylor Jakobson","email":"tjakobs@us.ibm.com","username":"tjakobs"},"change_message_id":"608f238974d3b061bc78de1d30f3cf923c9fe5ca","unresolved":false,"context_lines":[{"line_number":323,"context_line":""},{"line_number":324,"context_line":"            # Post it to the VIOS"},{"line_number":325,"context_line":"            vg_wrap.update()"},{"line_number":326,"context_line":"            if disk_found.backstore_type \u003d\u003d pvm_stg.BackStoreType.USER_QCOW:"},{"line_number":327,"context_line":"                # Get mapping before removing to save target_name and lua"},{"line_number":328,"context_line":"                lpar_uuid \u003d vm.get_pvm_uuid(instance)"},{"line_number":329,"context_line":"                vios_w \u003d pvm_vios.VIOS.get(self.adapter, uuid\u003dself._vios_uuid,"},{"line_number":330,"context_line":"                                           xag\u003d[pvm_const.XAG.VIO_SMAP])"},{"line_number":331,"context_line":"                mappings \u003d tsk_map.find_maps(vios_w.scsi_mappings,"},{"line_number":332,"context_line":"                                             client_lpar_id\u003dlpar_uuid,"},{"line_number":333,"context_line":"                                             stg_elem\u003ddisk_found)"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"                # Remap the disk to refresh the size"},{"line_number":336,"context_line":"                for mapping in mappings:"},{"line_number":337,"context_line":"                    self.disconnect_disk(instance)"},{"line_number":338,"context_line":"                    target_dev \u003d mapping.target_dev"},{"line_number":339,"context_line":"                    self.connect_disk(instance, disk_found,"},{"line_number":340,"context_line":"                                      lua\u003dtarget_dev.lua,"},{"line_number":341,"context_line":"                                      target_name\u003dtarget_dev.name)"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        # Get the disk name based on the instance and type"},{"line_number":344,"context_line":"        vol_name \u003d self._get_disk_name(disk_info[\u0027type\u0027], instance, short\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_0c8b156e","line":341,"range":{"start_line":326,"start_character":0,"end_line":341,"end_character":66},"in_reply_to":"ff0f0b1f_1c56dc5d","updated":"2017-05-23 05:29:10.000000000","message":"Removing mapping code. We will fail on resizing file-backed instances. This will need to be updated once resizing is supported.","commit_id":"c12166e355f0544172354793b7a4ff5a82239442"}]}
