)]}'
{"nova_powervm/virt/powervm/live_migration.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"6935cfc2006bffac20cf02754b70a7ade3341818","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        LOG.info(_LI(\u0027Performing detach for volume %(volume)s\u0027),"},{"line_number":242,"context_line":"                 dict(volume\u003dvol_drv.volume_id), instance\u003dself.instance)"},{"line_number":243,"context_line":"        # Ensure the volume data is present before trying cleanup"},{"line_number":244,"context_line":"        if hasattr(self, \u0027pre_live_vol_data\u0027):"},{"line_number":245,"context_line":"            try:"},{"line_number":246,"context_line":"                vol_drv.cleanup_volume_at_destination(self.pre_live_vol_data)"},{"line_number":247,"context_line":"            except Exception:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_e25a5b28","line":244,"updated":"2017-05-08 18:07:57.000000000","message":"Are we sure that, if the attribute exists, it\u0027s populated with anything?  And if it\u0027s not, do we still want to make the call?  Or do we need to change this to:\n\n pre_live_vol_data \u003d getattr(self, \u0027pre_live_vol_data\u0027, None)\n if pre_live_vol_data:\n     ...","commit_id":"eef26669485ee152f805bb2e4cd5e5fe77436cce"},{"author":{"_account_id":10207,"name":"Manas Mandlekar","email":"manas.mandlekar@in.ibm.com","username":"manasmandlekar"},"change_message_id":"c8631e850f134a8615dec88ce5fc76137cedca57","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        LOG.info(_LI(\u0027Performing detach for volume %(volume)s\u0027),"},{"line_number":242,"context_line":"                 dict(volume\u003dvol_drv.volume_id), instance\u003dself.instance)"},{"line_number":243,"context_line":"        # Ensure the volume data is present before trying cleanup"},{"line_number":244,"context_line":"        if hasattr(self, \u0027pre_live_vol_data\u0027):"},{"line_number":245,"context_line":"            try:"},{"line_number":246,"context_line":"                vol_drv.cleanup_volume_at_destination(self.pre_live_vol_data)"},{"line_number":247,"context_line":"            except Exception:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_f3d104cf","line":244,"in_reply_to":"3f044301_e25a5b28","updated":"2017-05-09 09:38:43.000000000","message":"Would getattr check for attribute being empty or not? I don\u0027t think so. hasattr still seems a better approach to me.","commit_id":"eef26669485ee152f805bb2e4cd5e5fe77436cce"}]}