)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10207,"name":"Manas Mandlekar","email":"manas.mandlekar@in.ibm.com","username":"manasmandlekar"},"change_message_id":"b06429c84b9b8bb7f3f897b18239bfab0b9bb0e9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add enable LPAR metric parameter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds suport for the LPAR performance"},{"line_number":10,"context_line":"metric."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8b2a25114a57b6edaf30e28bcce6176de526b4a9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f287b81_2e155540","line":9,"range":{"start_line":9,"start_character":17,"end_line":9,"end_character":23},"updated":"2017-08-31 06:23:10.000000000","message":"Replace \u0027suport\u0027 with \u0027support\u0027.\nMaybe we should also add that this can be provided by the caller during deploy/resize request and the hypervisor would use this to enable performance metrics collection for VM.","commit_id":"ef2c1b5b33ce40ad35c4531b45d4c82fcce3aa46"}],"nova_powervm/tests/virt/powervm/test_vm.py":[{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"76d8413aaf928e688cc114423cc502b9f612ce30","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        self.san_lpar_name.assert_called_with(instance.name)"},{"line_number":122,"context_line":"        self.san_lpar_name.reset_mock()"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        # Test the Enable lpar Metircs for true value"},{"line_number":125,"context_line":"        flavor.extra_specs \u003d {\u0027powervm:enable_lpar_metric\u0027: \u0027true\u0027}"},{"line_number":126,"context_line":"        test_attrs \u003d dict(lpar_attrs, enable_lpar_metric\u003dTrue)"},{"line_number":127,"context_line":"        self.assertEqual(self.lpar_b._format_flavor(instance), test_attrs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_4e71c1a7","line":124,"range":{"start_line":124,"start_character":26,"end_line":124,"end_character":38},"updated":"2017-08-31 06:24:34.000000000","message":"s/lpar Metircs/LPAR Metrics/","commit_id":"ef2c1b5b33ce40ad35c4531b45d4c82fcce3aa46"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"76d8413aaf928e688cc114423cc502b9f612ce30","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        self.san_lpar_name.assert_called_with(instance.name)"},{"line_number":129,"context_line":"        self.san_lpar_name.reset_mock()"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        # Test the Enable lpar Metircs for false value"},{"line_number":132,"context_line":"        flavor.extra_specs \u003d {\u0027powervm:enable_lpar_metric\u0027: \u0027false\u0027}"},{"line_number":133,"context_line":"        test_attrs \u003d dict(lpar_attrs, enable_lpar_metric\u003dFalse)"},{"line_number":134,"context_line":"        self.assertEqual(self.lpar_b._format_flavor(instance), test_attrs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_2e6c35cc","line":131,"range":{"start_line":131,"start_character":26,"end_line":131,"end_character":38},"updated":"2017-08-31 06:24:34.000000000","message":"s/lpar Metircs/LPAR Metrics/","commit_id":"ef2c1b5b33ce40ad35c4531b45d4c82fcce3aa46"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"dbe21a48af7ae6aeccc8e973439040d9fc7850cd","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        self.san_lpar_name.assert_called_with(instance.name)"},{"line_number":122,"context_line":"        self.san_lpar_name.reset_mock()"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        # Test the Enable LPAR Metircs for true value"},{"line_number":125,"context_line":"        flavor.extra_specs \u003d {\u0027powervm:enable_lpar_metric\u0027: \u0027true\u0027}"},{"line_number":126,"context_line":"        test_attrs \u003d dict(lpar_attrs, enable_lpar_metric\u003dTrue)"},{"line_number":127,"context_line":"        self.assertEqual(self.lpar_b._format_flavor(instance), test_attrs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_f753926b","line":124,"range":{"start_line":124,"start_character":31,"end_line":124,"end_character":38},"updated":"2017-08-31 18:03:26.000000000","message":"Metrics","commit_id":"d7104170f662102eb51e609946b873dbe487304d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"dbe21a48af7ae6aeccc8e973439040d9fc7850cd","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        self.san_lpar_name.assert_called_with(instance.name)"},{"line_number":129,"context_line":"        self.san_lpar_name.reset_mock()"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        # Test the Enable LPAR Metircs for false value"},{"line_number":132,"context_line":"        flavor.extra_specs \u003d {\u0027powervm:enable_lpar_metric\u0027: \u0027false\u0027}"},{"line_number":133,"context_line":"        test_attrs \u003d dict(lpar_attrs, enable_lpar_metric\u003dFalse)"},{"line_number":134,"context_line":"        self.assertEqual(self.lpar_b._format_flavor(instance), test_attrs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_b74d0ac6","line":131,"range":{"start_line":131,"start_character":31,"end_line":131,"end_character":38},"updated":"2017-08-31 18:03:26.000000000","message":"Metrics","commit_id":"d7104170f662102eb51e609946b873dbe487304d"}],"nova_powervm/virt/powervm/vm.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"b67a9182fe8f40e411a58ef231830e1dd74f2493","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        _PVM_PROC_COMPAT: None,"},{"line_number":254,"context_line":"        _PVM_SHAR_PROC_POOL: None,"},{"line_number":255,"context_line":"        _PVM_SRR_CAPABILITY: None,"},{"line_number":256,"context_line":"        _PVM_ENABLE_LPAR_METRIC: None,"},{"line_number":257,"context_line":"    }"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    _DED_SHARING_MODES_MAP \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_8ae343a4","line":256,"updated":"2017-08-29 19:13:53.000000000","message":"Nope, I think you can just map this one directly\n\n \u0027powervm:enable_lpar_metric\u0027: lpar_bldr.ENABLE_LPAR_METRIC,\n\n(For that matter, it looks like srr_capability could have been done that way too.  But that\u0027s an unrelated change.)","commit_id":"1fe0170cb88e087cd2a5ed933ca33df73762ddf2"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d80dee256459d009b76bb5b7ea61764298d5bbd7","unresolved":false,"context_lines":[{"line_number":327,"context_line":"            # derive the complex type"},{"line_number":328,"context_line":"            if bldr_key is None:"},{"line_number":329,"context_line":"                self._build_complex_type(key, attrs, instance.flavor)"},{"line_number":330,"context_line":"            elif bldr_key \u003d\u003d lpar_bldr.ENABLE_LPAR_METRIC:"},{"line_number":331,"context_line":"                lpar_metric \u003d self._flavor_bool("},{"line_number":332,"context_line":"                    instance.flavor.extra_specs[key], key)"},{"line_number":333,"context_line":"                attrs[bldr_key] \u003d lpar_metric"},{"line_number":334,"context_line":"            else:"},{"line_number":335,"context_line":"                # We found a direct mapping"},{"line_number":336,"context_line":"                attrs[bldr_key] \u003d instance.flavor.extra_specs[key]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_afb02dde","line":333,"range":{"start_line":330,"start_character":0,"end_line":333,"end_character":45},"updated":"2017-08-30 20:10:17.000000000","message":"No, you can leave this out too.  Take a look at mdrabe\u0027s https://review.openstack.org/#/c/497977/","commit_id":"ef2c1b5b33ce40ad35c4531b45d4c82fcce3aa46"},{"author":{"_account_id":10207,"name":"Manas Mandlekar","email":"manas.mandlekar@in.ibm.com","username":"manasmandlekar"},"change_message_id":"b06429c84b9b8bb7f3f897b18239bfab0b9bb0e9","unresolved":false,"context_lines":[{"line_number":327,"context_line":"            # derive the complex type"},{"line_number":328,"context_line":"            if bldr_key is None:"},{"line_number":329,"context_line":"                self._build_complex_type(key, attrs, instance.flavor)"},{"line_number":330,"context_line":"            elif bldr_key \u003d\u003d lpar_bldr.ENABLE_LPAR_METRIC:"},{"line_number":331,"context_line":"                lpar_metric \u003d self._flavor_bool("},{"line_number":332,"context_line":"                    instance.flavor.extra_specs[key], key)"},{"line_number":333,"context_line":"                attrs[bldr_key] \u003d lpar_metric"},{"line_number":334,"context_line":"            else:"},{"line_number":335,"context_line":"                # We found a direct mapping"},{"line_number":336,"context_line":"                attrs[bldr_key] \u003d instance.flavor.extra_specs[key]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_eeb62d3e","line":333,"range":{"start_line":330,"start_character":0,"end_line":333,"end_character":45},"in_reply_to":"7f287b81_afb02dde","updated":"2017-08-31 06:23:10.000000000","message":"The benefit that we get by using boolean type is that the validation error message in case of an incorrect input is very explicit that only True or False is allowed as input. So I prefer to keep it this way.","commit_id":"ef2c1b5b33ce40ad35c4531b45d4c82fcce3aa46"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"ef30d285ed79361a85f3832101ca9cbe7cd763be","unresolved":false,"context_lines":[{"line_number":327,"context_line":"            # derive the complex type"},{"line_number":328,"context_line":"            if bldr_key is None:"},{"line_number":329,"context_line":"                self._build_complex_type(key, attrs, instance.flavor)"},{"line_number":330,"context_line":"            elif bldr_key \u003d\u003d lpar_bldr.ENABLE_LPAR_METRIC:"},{"line_number":331,"context_line":"                lpar_metric \u003d self._flavor_bool("},{"line_number":332,"context_line":"                    instance.flavor.extra_specs[key], key)"},{"line_number":333,"context_line":"                attrs[bldr_key] \u003d lpar_metric"},{"line_number":334,"context_line":"            else:"},{"line_number":335,"context_line":"                # We found a direct mapping"},{"line_number":336,"context_line":"                attrs[bldr_key] \u003d instance.flavor.extra_specs[key]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_12c877a3","line":333,"range":{"start_line":330,"start_character":0,"end_line":333,"end_character":45},"in_reply_to":"7f287b81_eeb62d3e","updated":"2017-08-31 11:59:24.000000000","message":"okay","commit_id":"ef2c1b5b33ce40ad35c4531b45d4c82fcce3aa46"}]}