)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"ad69c908da20de9c921f6878577e29d2fd34380d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Persist the max virtio slots number when resizing instances"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The DefaultStandarize object in pypowervm defaults the proc units"},{"line_number":10,"context_line":"factor, max virtio slots, uncapped weight, spp, availability"},{"line_number":11,"context_line":"priority, srr, proc compat, and lpar metric values. nova-powervm"},{"line_number":12,"context_line":"does not pass in these parameters when resizing."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f4e5783_d4a245fc","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":21},"updated":"2017-10-13 19:22:34.000000000","message":"spelling","commit_id":"7bba96959c366894752f86cb1c6d7a0a5d41bbc6"},{"author":{"_account_id":13557,"name":"Matt Rabe","email":"mdrabe@us.ibm.com","username":"mdrabe"},"change_message_id":"2870178450a03525c0c4380254fd566e7ce6c836","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Persist the max virtio slots number when resizing instances"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The DefaultStandarize object in pypowervm defaults the proc units"},{"line_number":10,"context_line":"factor, max virtio slots, uncapped weight, spp, availability"},{"line_number":11,"context_line":"priority, srr, proc compat, and lpar metric values. nova-powervm"},{"line_number":12,"context_line":"does not pass in these parameters when resizing."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f4e5783_57aad770","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":21},"in_reply_to":"5f4e5783_d4a245fc","updated":"2017-10-13 19:25:01.000000000","message":"Done","commit_id":"7bba96959c366894752f86cb1c6d7a0a5d41bbc6"}],"nova_powervm/virt/powervm/vm.py":[{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"ad69c908da20de9c921f6878577e29d2fd34380d","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        :param slot_mgr: NovaSlotManager for setting/saving the maximum number"},{"line_number":276,"context_line":"                         of virtual slots on the VM."},{"line_number":277,"context_line":"        :param cur_lpar_w: The LPAR wrapper of the instance. Passing in this"},{"line_number":278,"context_line":"                           parameter signfies a resize operation."},{"line_number":279,"context_line":"        \"\"\""},{"line_number":280,"context_line":"        self.adapter \u003d adapter"},{"line_number":281,"context_line":"        self.host_w \u003d host_w"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f4e5783_548f7574","line":278,"range":{"start_line":278,"start_character":37,"end_line":278,"end_character":45},"updated":"2017-10-13 19:22:34.000000000","message":"spelling","commit_id":"7bba96959c366894752f86cb1c6d7a0a5d41bbc6"},{"author":{"_account_id":13557,"name":"Matt Rabe","email":"mdrabe@us.ibm.com","username":"mdrabe"},"change_message_id":"2870178450a03525c0c4380254fd566e7ce6c836","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        :param slot_mgr: NovaSlotManager for setting/saving the maximum number"},{"line_number":276,"context_line":"                         of virtual slots on the VM."},{"line_number":277,"context_line":"        :param cur_lpar_w: The LPAR wrapper of the instance. Passing in this"},{"line_number":278,"context_line":"                           parameter signfies a resize operation."},{"line_number":279,"context_line":"        \"\"\""},{"line_number":280,"context_line":"        self.adapter \u003d adapter"},{"line_number":281,"context_line":"        self.host_w \u003d host_w"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f4e5783_97cdef67","line":278,"range":{"start_line":278,"start_character":37,"end_line":278,"end_character":45},"in_reply_to":"5f4e5783_548f7574","updated":"2017-10-13 19:25:01.000000000","message":"Done","commit_id":"7bba96959c366894752f86cb1c6d7a0a5d41bbc6"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9af81e836cb020e488b780d5d7dce5e28bb75aa5","unresolved":false,"context_lines":[{"line_number":290,"context_line":"            kwargs[\u0027proc_compat\u0027] \u003d cur_lpar_w.proc_compat_mode"},{"line_number":291,"context_line":"            kwargs[\u0027enable_lpar_metric\u0027] \u003d ("},{"line_number":292,"context_line":"                cur_lpar_w.allow_perf_data_collection)"},{"line_number":293,"context_line":"        elif slot_mgr is not None:"},{"line_number":294,"context_line":"            # This will already default if not set"},{"line_number":295,"context_line":"            kwargs[\u0027max_slots\u0027] \u003d slot_mgr.build_map.get_max_vslots()"},{"line_number":296,"context_line":"        self.stdz \u003d lpar_bldr.DefaultStandardize(self.host_w, **kwargs)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_a631ad5c","line":293,"range":{"start_line":293,"start_character":8,"end_line":293,"end_character":13},"updated":"2017-10-16 18:18:24.000000000","message":"I think this should just be `if`.\n\nWalk it through with me.\n\nIf we\u0027re rebuilding, there will be a cur_lpar_w *and* a slot_mgr, right?  In which case we want to use the slot_mgr\u0027s value?\n\nHm, which actually should be the same as whatever\u0027s in cur_lpar_w.  Would it ever not be?  In which case, do we even need to store max vslots in the slot mgr?\n\nEek.","commit_id":"a4ccc44ef424d051ca086e727cac8de95b0a72b5"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"8c2014b4c244876a87e399b9a797436c0f4e49d4","unresolved":false,"context_lines":[{"line_number":290,"context_line":"            kwargs[\u0027proc_compat\u0027] \u003d cur_lpar_w.proc_compat_mode"},{"line_number":291,"context_line":"            kwargs[\u0027enable_lpar_metric\u0027] \u003d ("},{"line_number":292,"context_line":"                cur_lpar_w.allow_perf_data_collection)"},{"line_number":293,"context_line":"        elif slot_mgr is not None:"},{"line_number":294,"context_line":"            # This will already default if not set"},{"line_number":295,"context_line":"            kwargs[\u0027max_slots\u0027] \u003d slot_mgr.build_map.get_max_vslots()"},{"line_number":296,"context_line":"        self.stdz \u003d lpar_bldr.DefaultStandardize(self.host_w, **kwargs)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_1f7c441d","line":293,"range":{"start_line":293,"start_character":8,"end_line":293,"end_character":13},"in_reply_to":"5f4e5783_247c951d","updated":"2017-10-16 20:26:57.000000000","message":"Yes, I agree it should be the greater of the two.","commit_id":"a4ccc44ef424d051ca086e727cac8de95b0a72b5"},{"author":{"_account_id":13557,"name":"Matt Rabe","email":"mdrabe@us.ibm.com","username":"mdrabe"},"change_message_id":"83134f46bb4253c398122c29553097a8107507b7","unresolved":false,"context_lines":[{"line_number":290,"context_line":"            kwargs[\u0027proc_compat\u0027] \u003d cur_lpar_w.proc_compat_mode"},{"line_number":291,"context_line":"            kwargs[\u0027enable_lpar_metric\u0027] \u003d ("},{"line_number":292,"context_line":"                cur_lpar_w.allow_perf_data_collection)"},{"line_number":293,"context_line":"        elif slot_mgr is not None:"},{"line_number":294,"context_line":"            # This will already default if not set"},{"line_number":295,"context_line":"            kwargs[\u0027max_slots\u0027] \u003d slot_mgr.build_map.get_max_vslots()"},{"line_number":296,"context_line":"        self.stdz \u003d lpar_bldr.DefaultStandardize(self.host_w, **kwargs)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_247c951d","line":293,"range":{"start_line":293,"start_character":8,"end_line":293,"end_character":13},"in_reply_to":"5f4e5783_66d3b5d6","updated":"2017-10-16 19:41:19.000000000","message":"Ok so I changed it to `if`, but I feel this is still a little weird. Perhaps it should be the greater value of the two that we end up using due to the way get_max_vslots is implemented?\n\nThough I\u0027m not very familiar with the history there.","commit_id":"a4ccc44ef424d051ca086e727cac8de95b0a72b5"},{"author":{"_account_id":13557,"name":"Matt Rabe","email":"mdrabe@us.ibm.com","username":"mdrabe"},"change_message_id":"d4bc83e6782fe2236dcec526732c7589b9b4088c","unresolved":false,"context_lines":[{"line_number":290,"context_line":"            kwargs[\u0027proc_compat\u0027] \u003d cur_lpar_w.proc_compat_mode"},{"line_number":291,"context_line":"            kwargs[\u0027enable_lpar_metric\u0027] \u003d ("},{"line_number":292,"context_line":"                cur_lpar_w.allow_perf_data_collection)"},{"line_number":293,"context_line":"        elif slot_mgr is not None:"},{"line_number":294,"context_line":"            # This will already default if not set"},{"line_number":295,"context_line":"            kwargs[\u0027max_slots\u0027] \u003d slot_mgr.build_map.get_max_vslots()"},{"line_number":296,"context_line":"        self.stdz \u003d lpar_bldr.DefaultStandardize(self.host_w, **kwargs)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_66d3b5d6","line":293,"range":{"start_line":293,"start_character":8,"end_line":293,"end_character":13},"in_reply_to":"5f4e5783_a631ad5c","updated":"2017-10-16 18:25:26.000000000","message":"Oo good catch. I think the max_vslots value in the slot manager can be different than what\u0027s in the LPAR wrapper.\n\nThe value in the slot manager is the *highest* slot value I\u0027m pretty sure. Based off https://github.com/powervm/pypowervm/blob/develop/pypowervm/tasks/slot_map.py#L513-L534.\n\nIn which case we\u0027d want to use the value in the slot manager...\n\nAlthough to be honest I\u0027m not sure we should be touching that value....","commit_id":"a4ccc44ef424d051ca086e727cac8de95b0a72b5"}]}