)]}'
{"nova_powervm/tests/virt/powervm/test_vm.py":[{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"0557c43d9e1e31eadac46e583ce0cdbef8b478dd","unresolved":false,"context_lines":[{"line_number":254,"context_line":"            \u0027affinity_check_capable\u0027)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        # Test secure boot not set when rebuilding to non-supported host"},{"line_number":257,"context_line":"        self.lpar_b.host_w.get_capability.reset_mock()"},{"line_number":258,"context_line":"        flavor.extra_specs \u003d {\u0027powervm:secure_boot\u0027: \u00272\u0027}"},{"line_number":259,"context_line":"        self.assertEqual(self.lpar_b._format_flavor(instance), test_attrs)"},{"line_number":260,"context_line":"        self.lpar_b.host_w.get_capability.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_03ae512d","line":257,"updated":"2018-09-05 15:27:47.000000000","message":"if this passes without mocking the get_capability.return_value  \u003d False (as in L244, but not done for affinity check test on L249)... how?","commit_id":"1821a7e5ddbb78c38d8c11d6e51300ce5bc5d5c1"},{"author":{"_account_id":13557,"name":"Matt Rabe","email":"mdrabe@us.ibm.com","username":"mdrabe"},"change_message_id":"21dc448ba9f19e629cfdc31c158bbe030ca18c1a","unresolved":false,"context_lines":[{"line_number":254,"context_line":"            \u0027affinity_check_capable\u0027)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        # Test secure boot not set when rebuilding to non-supported host"},{"line_number":257,"context_line":"        self.lpar_b.host_w.get_capability.reset_mock()"},{"line_number":258,"context_line":"        flavor.extra_specs \u003d {\u0027powervm:secure_boot\u0027: \u00272\u0027}"},{"line_number":259,"context_line":"        self.assertEqual(self.lpar_b._format_flavor(instance), test_attrs)"},{"line_number":260,"context_line":"        self.lpar_b.host_w.get_capability.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_f4cc2962","line":257,"in_reply_to":"3f79a3b5_03ae512d","updated":"2018-09-05 17:09:42.000000000","message":"reset_mock only resets the call attributes, not the return_value. For reference: https://docs.python.org/3/library/unittest.mock.html#unittest.mock.Mock.reset_mock","commit_id":"1821a7e5ddbb78c38d8c11d6e51300ce5bc5d5c1"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"01440118b5fc4468c9149cb1818aa36821bc634f","unresolved":false,"context_lines":[{"line_number":254,"context_line":"            \u0027affinity_check_capable\u0027)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        # Test secure boot not set when rebuilding to non-supported host"},{"line_number":257,"context_line":"        self.lpar_b.host_w.get_capability.reset_mock()"},{"line_number":258,"context_line":"        flavor.extra_specs \u003d {\u0027powervm:secure_boot\u0027: \u00272\u0027}"},{"line_number":259,"context_line":"        self.assertEqual(self.lpar_b._format_flavor(instance), test_attrs)"},{"line_number":260,"context_line":"        self.lpar_b.host_w.get_capability.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_0970ab3f","line":257,"in_reply_to":"3f79a3b5_f4cc2962","updated":"2018-09-05 20:54:36.000000000","message":"I know that, but if it was already mocked to return False, then how did the tests above that depend on it being True (L235) work?\n\nOh... the mock change on L244 isn\u0027t specific to that one test there, but rather for all subsequent tests. Duh.","commit_id":"1821a7e5ddbb78c38d8c11d6e51300ce5bc5d5c1"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"01440118b5fc4468c9149cb1818aa36821bc634f","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        flavor.extra_specs \u003d {\u0027powervm:ppt_ratio\u0027: \u00271:4096\u0027}"},{"line_number":242,"context_line":"        instance.task_state \u003d task_states.REBUILD_SPAWNING"},{"line_number":243,"context_line":"        test_attrs \u003d dict(lpar_attrs)"},{"line_number":244,"context_line":"        self.lpar_b.host_w.get_capability.return_value \u003d False"},{"line_number":245,"context_line":"        self.assertEqual(self.lpar_b._format_flavor(instance), test_attrs)"},{"line_number":246,"context_line":"        self.lpar_b.host_w.get_capability.assert_called_once_with("},{"line_number":247,"context_line":"            \u0027physical_page_table_ratio_capable\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_69091f82","line":244,"updated":"2018-09-05 20:54:36.000000000","message":"Please move this line up into its own section and give it a comment to help avoid the confusion in my comment on PS1... E.g.:\n\n        # Prep for unsupported host tests\n        self.lpar_b.host_w.get_capability.return_value \u003d False\n\n        # Test PPT ratio not set when rebuilding to non-supported host\n...","commit_id":"2f4effe4dc82696597984c1f7fe01184abfb7850"},{"author":{"_account_id":13557,"name":"Matt Rabe","email":"mdrabe@us.ibm.com","username":"mdrabe"},"change_message_id":"4daf032ce4144edd025b684695d0a24888c458e7","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        flavor.extra_specs \u003d {\u0027powervm:ppt_ratio\u0027: \u00271:4096\u0027}"},{"line_number":242,"context_line":"        instance.task_state \u003d task_states.REBUILD_SPAWNING"},{"line_number":243,"context_line":"        test_attrs \u003d dict(lpar_attrs)"},{"line_number":244,"context_line":"        self.lpar_b.host_w.get_capability.return_value \u003d False"},{"line_number":245,"context_line":"        self.assertEqual(self.lpar_b._format_flavor(instance), test_attrs)"},{"line_number":246,"context_line":"        self.lpar_b.host_w.get_capability.assert_called_once_with("},{"line_number":247,"context_line":"            \u0027physical_page_table_ratio_capable\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_afb737d8","line":244,"in_reply_to":"3f79a3b5_69091f82","updated":"2018-09-05 21:56:46.000000000","message":"Done","commit_id":"2f4effe4dc82696597984c1f7fe01184abfb7850"}],"nova_powervm/virt/powervm/vm.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"7ed47165109f14f25361b2df2ddd3bd25c0cd7d8","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        \u0027powervm:enable_lpar_metric\u0027: lpar_bldr.ENABLE_LPAR_METRIC,"},{"line_number":182,"context_line":"        _PVM_PPT_RATIO: lpar_bldr.PPT_RATIO,"},{"line_number":183,"context_line":"        _PVM_ENFORCE_AFFINITY_CHECK: lpar_bldr.ENFORCE_AFFINITY_CHECK,"},{"line_number":184,"context_line":"        _PVM_SECURE_BOOT: lpar_bldr.SECURE_BOOT,"},{"line_number":185,"context_line":"        _PVM_UNCAPPED: None,"},{"line_number":186,"context_line":"        _PVM_DED_SHAR_MODE: None,"},{"line_number":187,"context_line":"        _PVM_PROC_COMPAT: None,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_e0e772ab","line":184,"range":{"start_line":184,"start_character":26,"end_line":184,"end_character":47},"updated":"2018-08-24 16:17:13.000000000","message":"Guess we\u0027re needing a pypowervm change (and release) for this?","commit_id":"1821a7e5ddbb78c38d8c11d6e51300ce5bc5d5c1"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"0557c43d9e1e31eadac46e583ce0cdbef8b478dd","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        \u0027powervm:enable_lpar_metric\u0027: lpar_bldr.ENABLE_LPAR_METRIC,"},{"line_number":182,"context_line":"        _PVM_PPT_RATIO: lpar_bldr.PPT_RATIO,"},{"line_number":183,"context_line":"        _PVM_ENFORCE_AFFINITY_CHECK: lpar_bldr.ENFORCE_AFFINITY_CHECK,"},{"line_number":184,"context_line":"        _PVM_SECURE_BOOT: lpar_bldr.SECURE_BOOT,"},{"line_number":185,"context_line":"        _PVM_UNCAPPED: None,"},{"line_number":186,"context_line":"        _PVM_DED_SHAR_MODE: None,"},{"line_number":187,"context_line":"        _PVM_PROC_COMPAT: None,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_83ed8126","line":184,"range":{"start_line":184,"start_character":26,"end_line":184,"end_character":47},"in_reply_to":"3f79a3b5_e0e772ab","updated":"2018-09-05 15:27:47.000000000","message":"yep. Change is proposed (6708) but not merged or released.","commit_id":"1821a7e5ddbb78c38d8c11d6e51300ce5bc5d5c1"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"0557c43d9e1e31eadac46e583ce0cdbef8b478dd","unresolved":false,"context_lines":[{"line_number":305,"context_line":"                if (instance.task_state \u003d\u003d task_states.REBUILD_SPAWNING and not"},{"line_number":306,"context_line":"                   self.host_w.get_capability("},{"line_number":307,"context_line":"                        \u0027partition_secure_boot_capable\u0027)):"},{"line_number":308,"context_line":"                    LOG.info(\"Ignoring secure boot setting on rebuild to a \""},{"line_number":309,"context_line":"                             \"secure boot unsupported host.\","},{"line_number":310,"context_line":"                             instance\u003dinstance)"},{"line_number":311,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_e3ceb581","line":308,"updated":"2018-09-05 15:27:47.000000000","message":"a comment similar to L295-7 would be nice here. And it would be nice for the LOG wording to be more similar as well.","commit_id":"1821a7e5ddbb78c38d8c11d6e51300ce5bc5d5c1"},{"author":{"_account_id":13557,"name":"Matt Rabe","email":"mdrabe@us.ibm.com","username":"mdrabe"},"change_message_id":"21dc448ba9f19e629cfdc31c158bbe030ca18c1a","unresolved":false,"context_lines":[{"line_number":305,"context_line":"                if (instance.task_state \u003d\u003d task_states.REBUILD_SPAWNING and not"},{"line_number":306,"context_line":"                   self.host_w.get_capability("},{"line_number":307,"context_line":"                        \u0027partition_secure_boot_capable\u0027)):"},{"line_number":308,"context_line":"                    LOG.info(\"Ignoring secure boot setting on rebuild to a \""},{"line_number":309,"context_line":"                             \"secure boot unsupported host.\","},{"line_number":310,"context_line":"                             instance\u003dinstance)"},{"line_number":311,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_14b1a501","line":308,"in_reply_to":"3f79a3b5_e3ceb581","updated":"2018-09-05 17:09:42.000000000","message":"Done. Followed the suggestion in the next comment as far as the LOG is concerned.","commit_id":"1821a7e5ddbb78c38d8c11d6e51300ce5bc5d5c1"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"0557c43d9e1e31eadac46e583ce0cdbef8b478dd","unresolved":false,"context_lines":[{"line_number":305,"context_line":"                if (instance.task_state \u003d\u003d task_states.REBUILD_SPAWNING and not"},{"line_number":306,"context_line":"                   self.host_w.get_capability("},{"line_number":307,"context_line":"                        \u0027partition_secure_boot_capable\u0027)):"},{"line_number":308,"context_line":"                    LOG.info(\"Ignoring secure boot setting on rebuild to a \""},{"line_number":309,"context_line":"                             \"secure boot unsupported host.\","},{"line_number":310,"context_line":"                             instance\u003dinstance)"},{"line_number":311,"context_line":"                else:"},{"line_number":312,"context_line":"                    attrs[bldr_key] \u003d instance.flavor.extra_specs[key]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_23558dc2","line":309,"range":{"start_line":308,"start_character":73,"end_line":309,"end_character":58},"updated":"2018-09-05 15:27:47.000000000","message":"nit: grammar... either \"a host that does not support secure boot\" or \"a host lacking secure boot support\" or something like that... or just \"an unsupported host\", since the fact that it is secure boot which is unsupported is pretty clearly implied.","commit_id":"1821a7e5ddbb78c38d8c11d6e51300ce5bc5d5c1"},{"author":{"_account_id":13557,"name":"Matt Rabe","email":"mdrabe@us.ibm.com","username":"mdrabe"},"change_message_id":"21dc448ba9f19e629cfdc31c158bbe030ca18c1a","unresolved":false,"context_lines":[{"line_number":305,"context_line":"                if (instance.task_state \u003d\u003d task_states.REBUILD_SPAWNING and not"},{"line_number":306,"context_line":"                   self.host_w.get_capability("},{"line_number":307,"context_line":"                        \u0027partition_secure_boot_capable\u0027)):"},{"line_number":308,"context_line":"                    LOG.info(\"Ignoring secure boot setting on rebuild to a \""},{"line_number":309,"context_line":"                             \"secure boot unsupported host.\","},{"line_number":310,"context_line":"                             instance\u003dinstance)"},{"line_number":311,"context_line":"                else:"},{"line_number":312,"context_line":"                    attrs[bldr_key] \u003d instance.flavor.extra_specs[key]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b4c1d150","line":309,"range":{"start_line":308,"start_character":73,"end_line":309,"end_character":58},"in_reply_to":"3f79a3b5_23558dc2","updated":"2018-09-05 17:09:42.000000000","message":"Done","commit_id":"1821a7e5ddbb78c38d8c11d6e51300ce5bc5d5c1"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"aeef4575448612256737fe1672e3fc38116654fd","unresolved":false,"context_lines":[{"line_number":305,"context_line":"                if (instance.task_state \u003d\u003d task_states.REBUILD_SPAWNING and not"},{"line_number":306,"context_line":"                   self.host_w.get_capability("},{"line_number":307,"context_line":"                        \u0027partition_secure_boot_capable\u0027)):"},{"line_number":308,"context_line":"                    # We still want to be able to rebuild from hosts that"},{"line_number":309,"context_line":"                    # support secure boot to hosts that don\u0027t support secure"},{"line_number":310,"context_line":"                    # boot."},{"line_number":311,"context_line":"                    LOG.info(\"Ignoring the secure boot setting on rebuild to \""}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_a5c0c54b","line":308,"updated":"2018-09-18 14:47:30.000000000","message":"on further thought... I don\u0027t think this is true. I would expect a corporate security team to be furious if they found out this happened, at least without a user explicitly overriding warnings.","commit_id":"79e7b529a1553415b3f579202897a18de16c0d23"},{"author":{"_account_id":13557,"name":"Matt Rabe","email":"mdrabe@us.ibm.com","username":"mdrabe"},"change_message_id":"ed13947730580e6bbd9acba3e9a5975aa08546df","unresolved":false,"context_lines":[{"line_number":305,"context_line":"                if (instance.task_state \u003d\u003d task_states.REBUILD_SPAWNING and not"},{"line_number":306,"context_line":"                   self.host_w.get_capability("},{"line_number":307,"context_line":"                        \u0027partition_secure_boot_capable\u0027)):"},{"line_number":308,"context_line":"                    # We still want to be able to rebuild from hosts that"},{"line_number":309,"context_line":"                    # support secure boot to hosts that don\u0027t support secure"},{"line_number":310,"context_line":"                    # boot."},{"line_number":311,"context_line":"                    LOG.info(\"Ignoring the secure boot setting on rebuild to \""}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_48fd4806","line":308,"in_reply_to":"3f79a3b5_a5c0c54b","updated":"2018-09-18 15:10:43.000000000","message":"Mkay, so with PS10 this block is removed, meaning the secure boot value will be maintained and the spawn will fail on the hypervisor.","commit_id":"79e7b529a1553415b3f579202897a18de16c0d23"}],"requirements.txt":[{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"ace514f2ab060e0d0aef36d16a94c87670f636e1","unresolved":false,"context_lines":[{"line_number":8,"context_line":"oslo.log\u003e\u003d3.36.0 # Apache-2.0"},{"line_number":9,"context_line":"oslo.serialization!\u003d2.19.1,\u003e\u003d2.18.0 # Apache-2.0"},{"line_number":10,"context_line":"oslo.utils\u003e\u003d3.33.0 # Apache-2.0"},{"line_number":11,"context_line":"pypowervm\u003e\u003d1.1.17 # Apache-2.0"},{"line_number":12,"context_line":"python-swiftclient\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":13,"context_line":"taskflow\u003e\u003d2.16.0 # Apache-2.0"},{"line_number":14,"context_line":"setuptools!\u003d24.0.0,!\u003d34.0.0,!\u003d34.0.1,!\u003d34.0.2,!\u003d34.0.3,!\u003d34.1.0,!\u003d34.1.1,!\u003d34.2.0,!\u003d34.3.0,!\u003d34.3.1,!\u003d34.3.2,!\u003d36.2.0,\u003e\u003d21.0.0 # PSF/ZPL"}],"source_content_type":"text/plain","patch_set":4,"id":"3f79a3b5_5993a3a3","line":11,"updated":"2018-09-07 16:49:00.000000000","message":"we usually do this in a separate commit, but I\u0027m fine with this.","commit_id":"2d9f075ef6e5a193085f55ebb38bc16a46d0c68c"},{"author":{"_account_id":13557,"name":"Matt Rabe","email":"mdrabe@us.ibm.com","username":"mdrabe"},"change_message_id":"28e2c97bf6df623fe21c507cd19d855311d87087","unresolved":false,"context_lines":[{"line_number":8,"context_line":"oslo.log\u003e\u003d3.36.0 # Apache-2.0"},{"line_number":9,"context_line":"oslo.serialization!\u003d2.19.1,\u003e\u003d2.18.0 # Apache-2.0"},{"line_number":10,"context_line":"oslo.utils\u003e\u003d3.33.0 # Apache-2.0"},{"line_number":11,"context_line":"pypowervm\u003e\u003d1.1.17 # Apache-2.0"},{"line_number":12,"context_line":"python-swiftclient\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":13,"context_line":"taskflow\u003e\u003d2.16.0 # Apache-2.0"},{"line_number":14,"context_line":"setuptools!\u003d24.0.0,!\u003d34.0.0,!\u003d34.0.1,!\u003d34.0.2,!\u003d34.0.3,!\u003d34.1.0,!\u003d34.1.1,!\u003d34.2.0,!\u003d34.3.0,!\u003d34.3.1,!\u003d34.3.2,!\u003d36.2.0,\u003e\u003d21.0.0 # PSF/ZPL"}],"source_content_type":"text/plain","patch_set":4,"id":"3f79a3b5_e5d68027","line":11,"in_reply_to":"3f79a3b5_2a40c7a1","updated":"2018-09-07 20:30:33.000000000","message":"Done","commit_id":"2d9f075ef6e5a193085f55ebb38bc16a46d0c68c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5d08bcf0f4721a544663b900213189a082967ae9","unresolved":false,"context_lines":[{"line_number":8,"context_line":"oslo.log\u003e\u003d3.36.0 # Apache-2.0"},{"line_number":9,"context_line":"oslo.serialization!\u003d2.19.1,\u003e\u003d2.18.0 # Apache-2.0"},{"line_number":10,"context_line":"oslo.utils\u003e\u003d3.33.0 # Apache-2.0"},{"line_number":11,"context_line":"pypowervm\u003e\u003d1.1.17 # Apache-2.0"},{"line_number":12,"context_line":"python-swiftclient\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":13,"context_line":"taskflow\u003e\u003d2.16.0 # Apache-2.0"},{"line_number":14,"context_line":"setuptools!\u003d24.0.0,!\u003d34.0.0,!\u003d34.0.1,!\u003d34.0.2,!\u003d34.0.3,!\u003d34.1.0,!\u003d34.1.1,!\u003d34.2.0,!\u003d34.3.0,!\u003d34.3.1,!\u003d34.3.2,!\u003d36.2.0,\u003e\u003d21.0.0 # PSF/ZPL"}],"source_content_type":"text/plain","patch_set":4,"id":"3f79a3b5_2a40c7a1","line":11,"in_reply_to":"3f79a3b5_5993a3a3","updated":"2018-09-07 19:58:56.000000000","message":"yeah, this is fine. You\u0027ll need to fix lower-constraints, though.","commit_id":"2d9f075ef6e5a193085f55ebb38bc16a46d0c68c"}]}
