)]}'
{"nova_powervm/tests/virt/powervm/test_driver.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"b11e92fbdd2770cb52a174d8e020d992eab3624f","unresolved":false,"context_lines":[{"line_number":2078,"context_line":"                                   \u0027network_info\u0027)"},{"line_number":2079,"context_line":"        mock_destroy.assert_called_once_with("},{"line_number":2080,"context_line":"            \u0027context\u0027, self.lpm_inst, mock_block_device_info.return_value,"},{"line_number":2081,"context_line":"            destroy_disks\u003dFalse, shutdown\u003dFalse)"},{"line_number":2082,"context_line":""},{"line_number":2083,"context_line":"    @mock.patch(\u0027nova_powervm.virt.powervm.vm.rename\u0027, autospec\u003dTrue)"},{"line_number":2084,"context_line":"    def test_confirm_migration_same_host(self, mock_rename):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_581f38b6","line":2081,"updated":"2019-10-15 12:41:32.000000000","message":"you should also\n\n mock_block_device_info.assert_called_once_with(\u0027context\u0027, self.lpm_inst)","commit_id":"5f4e8dcd7e33fcc8bd6f058276556293f3614e4a"},{"author":{"_account_id":16551,"name":"Arun Mani","email":"arun.mani@in.ibm.com","username":"arunmani"},"change_message_id":"e88eb3d4e8a0b182a969788a9dada3e63c6c501e","unresolved":false,"context_lines":[{"line_number":1378,"context_line":"        # BDMs"},{"line_number":1379,"context_line":"        mock_bdms \u003d self._fake_bdms()"},{"line_number":1380,"context_line":""},{"line_number":1381,"context_line":"        # IBM cherry-pick start"},{"line_number":1382,"context_line":"        dest_host \u003d host + \u00271\u0027"},{"line_number":1383,"context_line":"        # Catch root disk resize smaller"},{"line_number":1384,"context_line":"        if dest_host \u003d\u003d host:"}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_2b7376b6","line":1381,"updated":"2019-12-04 09:01:58.000000000","message":"Ditto. Remove this","commit_id":"36e728a465c56613a55b1e86baac8770c7850755"},{"author":{"_account_id":16551,"name":"Arun Mani","email":"arun.mani@in.ibm.com","username":"arunmani"},"change_message_id":"e88eb3d4e8a0b182a969788a9dada3e63c6c501e","unresolved":false,"context_lines":[{"line_number":1387,"context_line":"                exc.InstanceFaultRollback, self.drv.migrate_disk_and_power_off,"},{"line_number":1388,"context_line":"                \u0027context\u0027, self.inst, \u0027dest\u0027, small_root, \u0027network_info\u0027,"},{"line_number":1389,"context_line":"                mock_bdms)"},{"line_number":1390,"context_line":""},{"line_number":1391,"context_line":"        # IBM cherry-pick end"},{"line_number":1392,"context_line":"        # Boot disk resize"},{"line_number":1393,"context_line":"        boot_flav \u003d objects.Flavor(vcpus\u003d1, memory_mb\u003d2048, root_gb\u003d12)"}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_4b76f2a5","line":1390,"updated":"2019-12-04 09:01:58.000000000","message":"Ditto.","commit_id":"36e728a465c56613a55b1e86baac8770c7850755"}],"nova_powervm/virt/powervm/driver.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"ba9f79688c4e79828b9f73f3ec02813cbad08f97","unresolved":false,"context_lines":[{"line_number":1398,"context_line":""},{"line_number":1399,"context_line":"        # Destroy the old VM."},{"line_number":1400,"context_line":"        destroy_disks \u003d not self.disk_dvr.capabilities[\u0027shared_storage\u0027]"},{"line_number":1401,"context_line":"\tblock_device_info \u003d self._get_block_device_info(context, instance)"},{"line_number":1402,"context_line":"        self._destroy(context, instance, block_device_info,"},{"line_number":1403,"context_line":"                      destroy_disks\u003ddestroy_disks, shutdown\u003dFalse)"},{"line_number":1404,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_2a7ade24","line":1401,"updated":"2019-08-23 14:18:07.000000000","message":"pep8 is going to ding you for this tab. Otherwise this seems like a legit change. You\u0027ll need unit test coverage, though.","commit_id":"79829363abfe21190a93adc39cfe079f99f36137"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"b11e92fbdd2770cb52a174d8e020d992eab3624f","unresolved":false,"context_lines":[{"line_number":1413,"context_line":"        # Destroy the old VM."},{"line_number":1414,"context_line":"        destroy_disks \u003d not self.disk_dvr.capabilities[\u0027shared_storage\u0027]"},{"line_number":1415,"context_line":"        block_device_info \u003d self._get_block_device_info(context, instance)"},{"line_number":1416,"context_line":"        self._destroy(context, instance, block_device_info,"},{"line_number":1417,"context_line":"                      destroy_disks\u003ddestroy_disks, shutdown\u003dFalse)"},{"line_number":1418,"context_line":""},{"line_number":1419,"context_line":"    def finish_revert_migration(self, context, instance, network_info,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_38191cd6","line":1416,"range":{"start_line":1416,"start_character":41,"end_line":1416,"end_character":58},"updated":"2019-10-15 12:41:32.000000000","message":"prefer naming kwargs\n\n block_device_info\u003dblock_device_info","commit_id":"5f4e8dcd7e33fcc8bd6f058276556293f3614e4a"},{"author":{"_account_id":16551,"name":"Arun Mani","email":"arun.mani@in.ibm.com","username":"arunmani"},"change_message_id":"e88eb3d4e8a0b182a969788a9dada3e63c6c501e","unresolved":false,"context_lines":[{"line_number":1192,"context_line":""},{"line_number":1193,"context_line":"        same_host \u003d dest \u003d\u003d self.get_host_ip_addr()"},{"line_number":1194,"context_line":"        if same_host:"},{"line_number":1195,"context_line":"            # IBM cherry-pick start"},{"line_number":1196,"context_line":"            if flavor and flavor.root_gb \u003c instance.root_gb:"},{"line_number":1197,"context_line":"                raise exception.InstanceFaultRollback("},{"line_number":1198,"context_line":"                    exception.ResizeError("}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_ab3d26bd","line":1195,"updated":"2019-12-04 09:01:58.000000000","message":"Remove these statements.","commit_id":"36e728a465c56613a55b1e86baac8770c7850755"},{"author":{"_account_id":16551,"name":"Arun Mani","email":"arun.mani@in.ibm.com","username":"arunmani"},"change_message_id":"e88eb3d4e8a0b182a969788a9dada3e63c6c501e","unresolved":false,"context_lines":[{"line_number":1197,"context_line":"                raise exception.InstanceFaultRollback("},{"line_number":1198,"context_line":"                    exception.ResizeError("},{"line_number":1199,"context_line":"                        reason\u003d_(\u0027Cannot reduce disk size.\u0027)))"},{"line_number":1200,"context_line":"            # IBM cherry-pick end"},{"line_number":1201,"context_line":"            self._log_operation(\u0027resize\u0027, instance)"},{"line_number":1202,"context_line":"        else:"},{"line_number":1203,"context_line":"            self._log_operation(\u0027migration\u0027, instance)"}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa7e38b_ab6686ed","line":1200,"updated":"2019-12-04 09:01:58.000000000","message":"Ditto","commit_id":"36e728a465c56613a55b1e86baac8770c7850755"}],"nova_powervm/virt/powervm/live_migration.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"b11e92fbdd2770cb52a174d8e020d992eab3624f","unresolved":false,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        # Check if VM is ready for migration"},{"line_number":295,"context_line":"        # Skip incase of cold migration"},{"line_number":296,"context_line":"        if self.instance.power_state \u003d\u003d power_state.RUNNING:"},{"line_number":297,"context_line":"            self._check_migration_ready(lpar_w, self.drvr.host_wrapper)"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        if lpar_w.migration_state !\u003d \u0027Not_Migrating\u0027:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_587418fe","line":296,"updated":"2019-10-15 12:41:32.000000000","message":"need test coverage for this delta","commit_id":"5f4e8dcd7e33fcc8bd6f058276556293f3614e4a"}]}