)]}'
{"specs/juno/get-floatingip-by-all-tenants.rst":[{"author":{"_account_id":8021,"name":"wingwj","email":"wingwj@gmail.com","username":"wingwj"},"change_message_id":"1099f44c013cf03c96fdad5f3113027d0069843d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Currently, in Nova API, there are several commands support \"all-tenants\" flag."},{"line_number":14,"context_line":"e.g. listing volumes, listing servers, list-secgroup. this blueprint support"},{"line_number":15,"context_line":"getting floatingips of all tenants."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_a0cf30b2","line":16,"updated":"2014-06-26 02:19:46.000000000","message":"IMO it\u0027s better to unify the writing usage, \u0027floationg ips\u0027 or \u0027floatingips\u0027?","commit_id":"8d365d86657ebd0b236f798cf977cc698667450b"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"e591e7cd4ca3e4c25d2a384e2490d59f53db812d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Currently, in Nova API, there are several commands support \"all-tenants\" flag."},{"line_number":14,"context_line":"e.g. listing volumes, listing servers, list-secgroup. this blueprint support"},{"line_number":15,"context_line":"getting floatingips of all tenants."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_807954c7","line":16,"in_reply_to":"1ae5cdf2_a0cf30b2","updated":"2014-06-26 02:40:06.000000000","message":"Done","commit_id":"8d365d86657ebd0b236f798cf977cc698667450b"},{"author":{"_account_id":8021,"name":"wingwj","email":"wingwj@gmail.com","username":"wingwj"},"change_message_id":"1099f44c013cf03c96fdad5f3113027d0069843d","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"There is a basic need that admin want to know how much floating ips has be"},{"line_number":21,"context_line":"created and how much associated as floating ip is a type of limited resource"},{"line_number":22,"context_line":"in operation scenario."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"For Neutron, Neutron API support admin getting floating ips by all tenants."},{"line_number":25,"context_line":"If we use neutron as network component,admin user (user has associated admin"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_009aa461","line":22,"updated":"2014-06-26 02:19:46.000000000","message":"Use this one:\n\n-------------\n\nThere is a basic requirement that admin wants to know how much floating ips have been created/associated because of \u0027floating ips\u0027 is one type of limited resources.","commit_id":"8d365d86657ebd0b236f798cf977cc698667450b"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"e591e7cd4ca3e4c25d2a384e2490d59f53db812d","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"There is a basic need that admin want to know how much floating ips has be"},{"line_number":21,"context_line":"created and how much associated as floating ip is a type of limited resource"},{"line_number":22,"context_line":"in operation scenario."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"For Neutron, Neutron API support admin getting floating ips by all tenants."},{"line_number":25,"context_line":"If we use neutron as network component,admin user (user has associated admin"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_54d9cd81","line":22,"in_reply_to":"1ae5cdf2_009aa461","updated":"2014-06-26 02:40:06.000000000","message":"Done","commit_id":"8d365d86657ebd0b236f798cf977cc698667450b"},{"author":{"_account_id":8021,"name":"wingwj","email":"wingwj@gmail.com","username":"wingwj"},"change_message_id":"1099f44c013cf03c96fdad5f3113027d0069843d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"If we use neutron as network component,admin user (user has associated admin"},{"line_number":26,"context_line":"role) can not get all tenants\u0027s floatingip by Nova API, this is because nova"},{"line_number":27,"context_line":"has add \"project_id\" as filter when calling neutronclient to get floatingips,"},{"line_number":28,"context_line":"this is hard-code."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"This blueprint try to relax the restriction of Nova API about listing"},{"line_number":31,"context_line":"floatingips."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_806eb462","line":28,"updated":"2014-06-26 02:19:46.000000000","message":"Please use this one:\n\n-----------\n\nThe neutron API supports admin to get all tenants\u0027 floating ips now.\nBut if we use neutron as network component, admin user(user has associated admin role) can not get all tenants\u0027 floating ips by Nova API, because nova adds the \u0027project_id\u0027 as one filter when calling neutronclient to get floatingips. This is hard-coding.","commit_id":"8d365d86657ebd0b236f798cf977cc698667450b"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"e591e7cd4ca3e4c25d2a384e2490d59f53db812d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"If we use neutron as network component,admin user (user has associated admin"},{"line_number":26,"context_line":"role) can not get all tenants\u0027s floatingip by Nova API, this is because nova"},{"line_number":27,"context_line":"has add \"project_id\" as filter when calling neutronclient to get floatingips,"},{"line_number":28,"context_line":"this is hard-code."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"This blueprint try to relax the restriction of Nova API about listing"},{"line_number":31,"context_line":"floatingips."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_b481314f","line":28,"in_reply_to":"1ae5cdf2_806eb462","updated":"2014-06-26 02:40:06.000000000","message":"Done","commit_id":"8d365d86657ebd0b236f798cf977cc698667450b"},{"author":{"_account_id":8021,"name":"wingwj","email":"wingwj@gmail.com","username":"wingwj"},"change_message_id":"1099f44c013cf03c96fdad5f3113027d0069843d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"this is hard-code."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"This blueprint try to relax the restriction of Nova API about listing"},{"line_number":31,"context_line":"floatingips."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Proposed change"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_c0935c4d","line":31,"updated":"2014-06-26 02:19:46.000000000","message":"relax --\u003e remove ?","commit_id":"8d365d86657ebd0b236f798cf977cc698667450b"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"e591e7cd4ca3e4c25d2a384e2490d59f53db812d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"this is hard-code."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"This blueprint try to relax the restriction of Nova API about listing"},{"line_number":31,"context_line":"floatingips."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Proposed change"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_9443553e","line":31,"in_reply_to":"1ae5cdf2_c0935c4d","updated":"2014-06-26 02:40:06.000000000","message":"Done","commit_id":"8d365d86657ebd0b236f798cf977cc698667450b"},{"author":{"_account_id":8021,"name":"wingwj","email":"wingwj@gmail.com","username":"wingwj"},"change_message_id":"1099f44c013cf03c96fdad5f3113027d0069843d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* Add a \"all_tenants\" flag to Nova indexing action of os-floating-ips API."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* Add policy rules and policy validation for all-tenants authority"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* Allow nova-network getting floatingips of all tennats, this need refactor"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_e5ab0a6f","line":37,"updated":"2014-06-26 02:19:46.000000000","message":"a --\u003e \u0027an\u0027","commit_id":"8d365d86657ebd0b236f798cf977cc698667450b"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"e591e7cd4ca3e4c25d2a384e2490d59f53db812d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* Add a \"all_tenants\" flag to Nova indexing action of os-floating-ips API."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* Add policy rules and policy validation for all-tenants authority"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* Allow nova-network getting floatingips of all tennats, this need refactor"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_e03f78dd","line":37,"in_reply_to":"1ae5cdf2_e5ab0a6f","updated":"2014-06-26 02:40:06.000000000","message":"Done","commit_id":"8d365d86657ebd0b236f798cf977cc698667450b"},{"author":{"_account_id":8021,"name":"wingwj","email":"wingwj@gmail.com","username":"wingwj"},"change_message_id":"1099f44c013cf03c96fdad5f3113027d0069843d","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* Allow nova-network getting floatingips of all tennats, this need refactor"},{"line_number":41,"context_line":"  the relevant methods and add db query methods."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* Add parameter that nova can get floatingips of all tenants and get"},{"line_number":44,"context_line":"  floatingips of current tenant by calling Neutronclient."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_e5f94a83","line":42,"updated":"2014-06-26 02:19:46.000000000","message":"need --\u003e needs, add --\u003e adds","commit_id":"8d365d86657ebd0b236f798cf977cc698667450b"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"e591e7cd4ca3e4c25d2a384e2490d59f53db812d","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* Allow nova-network getting floatingips of all tennats, this need refactor"},{"line_number":41,"context_line":"  the relevant methods and add db query methods."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* Add parameter that nova can get floatingips of all tenants and get"},{"line_number":44,"context_line":"  floatingips of current tenant by calling Neutronclient."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_0045446e","line":42,"in_reply_to":"1ae5cdf2_e5f94a83","updated":"2014-06-26 02:40:06.000000000","message":"Done","commit_id":"8d365d86657ebd0b236f798cf977cc698667450b"},{"author":{"_account_id":8021,"name":"wingwj","email":"wingwj@gmail.com","username":"wingwj"},"change_message_id":"1099f44c013cf03c96fdad5f3113027d0069843d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  floatingips of current tenant by calling Neutronclient."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* Novaclient support \"all_tenants\" flag of \"nova floating-ip-list\" command."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Alternatives"},{"line_number":49,"context_line":"------------"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_a503c274","line":47,"updated":"2014-06-26 02:19:46.000000000","message":"support --\u003e supports","commit_id":"8d365d86657ebd0b236f798cf977cc698667450b"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"e591e7cd4ca3e4c25d2a384e2490d59f53db812d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  floatingips of current tenant by calling Neutronclient."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* Novaclient support \"all_tenants\" flag of \"nova floating-ip-list\" command."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Alternatives"},{"line_number":49,"context_line":"------------"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_205de048","line":47,"in_reply_to":"1ae5cdf2_a503c274","updated":"2014-06-26 02:40:06.000000000","message":"Done","commit_id":"8d365d86657ebd0b236f798cf977cc698667450b"},{"author":{"_account_id":8021,"name":"wingwj","email":"wingwj@gmail.com","username":"wingwj"},"change_message_id":"1099f44c013cf03c96fdad5f3113027d0069843d","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"* GET /v2/{tenant_id}/os-floating-ips"},{"line_number":64,"context_line":"* GET /v2/{tenant_id}/os-floating-ips？all_tenants\u003d{True in bool}"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Security impact"},{"line_number":67,"context_line":"---------------"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_856ec662","line":65,"updated":"2014-06-26 02:19:46.000000000","message":"Please add req \u0026 resp bodys of your new APIs.\n\nDo you need to add the API in v3?\n\n?--\u003e ?","commit_id":"8d365d86657ebd0b236f798cf977cc698667450b"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"e591e7cd4ca3e4c25d2a384e2490d59f53db812d","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"* GET /v2/{tenant_id}/os-floating-ips"},{"line_number":64,"context_line":"* GET /v2/{tenant_id}/os-floating-ips？all_tenants\u003d{True in bool}"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Security impact"},{"line_number":67,"context_line":"---------------"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_74188976","line":65,"in_reply_to":"1ae5cdf2_856ec662","updated":"2014-06-26 02:40:06.000000000","message":"1. Done\n\n2. The floating ips API is not implemented yet, maybe The V3 API change will be implemented in V3 API blueprint.","commit_id":"8d365d86657ebd0b236f798cf977cc698667450b"},{"author":{"_account_id":8021,"name":"wingwj","email":"wingwj@gmail.com","username":"wingwj"},"change_message_id":"1099f44c013cf03c96fdad5f3113027d0069843d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"---------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Admin user can get other tenants\u0027s floatingip info."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Notifications impact"},{"line_number":72,"context_line":"--------------------"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_c0ba7cbf","line":70,"updated":"2014-06-26 02:19:46.000000000","message":"tenants\u0027s --\u003e tenants\u0027","commit_id":"8d365d86657ebd0b236f798cf977cc698667450b"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"e591e7cd4ca3e4c25d2a384e2490d59f53db812d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"---------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Admin user can get other tenants\u0027s floatingip info."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Notifications impact"},{"line_number":72,"context_line":"--------------------"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_c0351cf8","line":70,"in_reply_to":"1ae5cdf2_c0ba7cbf","updated":"2014-06-26 02:40:06.000000000","message":"Done","commit_id":"8d365d86657ebd0b236f798cf977cc698667450b"},{"author":{"_account_id":8021,"name":"wingwj","email":"wingwj@gmail.com","username":"wingwj"},"change_message_id":"1099f44c013cf03c96fdad5f3113027d0069843d","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Other end user impact"},{"line_number":77,"context_line":"---------------------"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"None"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_e01bf86c","line":78,"updated":"2014-06-26 02:19:46.000000000","message":"The python-novaclient will be modified according your message in \u0027Work Item\u0027 part. So you need to add the impact here.","commit_id":"8d365d86657ebd0b236f798cf977cc698667450b"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"e591e7cd4ca3e4c25d2a384e2490d59f53db812d","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Other end user impact"},{"line_number":77,"context_line":"---------------------"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"None"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_3467e1eb","line":78,"in_reply_to":"1ae5cdf2_e01bf86c","updated":"2014-06-26 02:40:06.000000000","message":"Done","commit_id":"8d365d86657ebd0b236f798cf977cc698667450b"},{"author":{"_account_id":8021,"name":"wingwj","email":"wingwj@gmail.com","username":"wingwj"},"change_message_id":"1099f44c013cf03c96fdad5f3113027d0069843d","unresolved":false,"context_lines":[{"line_number":121,"context_line":"  to test the functional API."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"* Update the API documents about this new API."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Dependencies"},{"line_number":126,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_05b71686","line":124,"updated":"2014-06-26 02:19:46.000000000","message":"documents --\u003e document","commit_id":"8d365d86657ebd0b236f798cf977cc698667450b"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"e591e7cd4ca3e4c25d2a384e2490d59f53db812d","unresolved":false,"context_lines":[{"line_number":121,"context_line":"  to test the functional API."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"* Update the API documents about this new API."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Dependencies"},{"line_number":126,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_602a8892","line":124,"in_reply_to":"1ae5cdf2_05b71686","updated":"2014-06-26 02:40:06.000000000","message":"Done","commit_id":"8d365d86657ebd0b236f798cf977cc698667450b"},{"author":{"_account_id":8021,"name":"wingwj","email":"wingwj@gmail.com","username":"wingwj"},"change_message_id":"1099f44c013cf03c96fdad5f3113027d0069843d","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Testing"},{"line_number":131,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"This code will be tested in unit tests for this function."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"The API will be tested by adding tempest."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_a562e213","line":132,"updated":"2014-06-26 02:19:46.000000000","message":"Do you need to test this function in Ceilometer side?","commit_id":"8d365d86657ebd0b236f798cf977cc698667450b"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"e591e7cd4ca3e4c25d2a384e2490d59f53db812d","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Testing"},{"line_number":131,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"This code will be tested in unit tests for this function."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"The API will be tested by adding tempest."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_f452d910","line":132,"in_reply_to":"1ae5cdf2_a562e213","updated":"2014-06-26 02:40:06.000000000","message":"This is a independent blueprint of Nova, because the ceilometer side change has been rejected.","commit_id":"8d365d86657ebd0b236f798cf977cc698667450b"},{"author":{"_account_id":8021,"name":"wingwj","email":"wingwj@gmail.com","username":"wingwj"},"change_message_id":"1099f44c013cf03c96fdad5f3113027d0069843d","unresolved":false,"context_lines":[{"line_number":130,"context_line":"Testing"},{"line_number":131,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"This code will be tested in unit tests for this function."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"The API will be tested by adding tempest."},{"line_number":136,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_c599ae20","line":133,"updated":"2014-06-26 02:19:46.000000000","message":"This code --\u003e The codes","commit_id":"8d365d86657ebd0b236f798cf977cc698667450b"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"e591e7cd4ca3e4c25d2a384e2490d59f53db812d","unresolved":false,"context_lines":[{"line_number":130,"context_line":"Testing"},{"line_number":131,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"This code will be tested in unit tests for this function."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"The API will be tested by adding tempest."},{"line_number":136,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_200b202c","line":133,"in_reply_to":"1ae5cdf2_c599ae20","updated":"2014-06-26 02:40:06.000000000","message":"Done","commit_id":"8d365d86657ebd0b236f798cf977cc698667450b"},{"author":{"_account_id":8021,"name":"wingwj","email":"wingwj@gmail.com","username":"wingwj"},"change_message_id":"1099f44c013cf03c96fdad5f3113027d0069843d","unresolved":false,"context_lines":[{"line_number":133,"context_line":"This code will be tested in unit tests for this function."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"The API will be tested by adding tempest."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Documentation Impact"},{"line_number":138,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_45859eab","line":136,"updated":"2014-06-26 02:19:46.000000000","message":"API --\u003e APIs","commit_id":"8d365d86657ebd0b236f798cf977cc698667450b"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"e591e7cd4ca3e4c25d2a384e2490d59f53db812d","unresolved":false,"context_lines":[{"line_number":133,"context_line":"This code will be tested in unit tests for this function."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"The API will be tested by adding tempest."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Documentation Impact"},{"line_number":138,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_c01c3c7a","line":136,"in_reply_to":"1ae5cdf2_45859eab","updated":"2014-06-26 02:40:06.000000000","message":"Done","commit_id":"8d365d86657ebd0b236f798cf977cc698667450b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"18fb269575fb68b11654e5c4ef3e4dd8a6a8837f","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Currently, in Nova API, there are several commands support \"all-tenants\" flag."},{"line_number":14,"context_line":"e.g. listing volumes, listing servers, list-secgroup. this blueprint support"},{"line_number":15,"context_line":"getting floatingips of all tenants."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_51dcab12","line":15,"updated":"2014-07-02 09:20:18.000000000","message":"Is this for ceilometer. \n\nWe rejected the patch that got in without a spec, not the general idea behind the patch.","commit_id":"8972fa92dde3052c0b2e8ad9503cf619c86d92e7"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"87363b665af3bfe8f579f9229d9fcd0e9ee32932","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Currently, in Nova API, there are several commands support \"all-tenants\" flag."},{"line_number":14,"context_line":"e.g. listing volumes, listing servers, list-secgroup. this blueprint support"},{"line_number":15,"context_line":"getting floatingips of all tenants."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_8ceaac0d","line":15,"in_reply_to":"baada198_51dcab12","updated":"2014-07-03 02:24:49.000000000","message":"this change is not for ceilometer because ceilometer polling floatingip info by Nova API will increase the load of Nova API, that change has been rejected by Matt Riedemann.","commit_id":"8972fa92dde3052c0b2e8ad9503cf619c86d92e7"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"18fb269575fb68b11654e5c4ef3e4dd8a6a8837f","unresolved":false,"context_lines":[{"line_number":25,"context_line":"use neutron as network component, admin user(user has associated admin role)"},{"line_number":26,"context_line":"can not get all tenants\u0027 floating ips by Nova API, because nova adds the"},{"line_number":27,"context_line":"\u0027project_id\u0027 as one filter when calling neutronclient to get floatingips."},{"line_number":28,"context_line":"This is hard-coding."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"This blueprint try to relax the restriction of Nova API about listing"},{"line_number":31,"context_line":"floatingips."}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_51f3cb9d","line":28,"updated":"2014-07-02 09:20:18.000000000","message":"But if you are using neutron, you should call neutron direction, the Nova APIs that proxy neutron are being deprecated.","commit_id":"8972fa92dde3052c0b2e8ad9503cf619c86d92e7"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"87363b665af3bfe8f579f9229d9fcd0e9ee32932","unresolved":false,"context_lines":[{"line_number":25,"context_line":"use neutron as network component, admin user(user has associated admin role)"},{"line_number":26,"context_line":"can not get all tenants\u0027 floating ips by Nova API, because nova adds the"},{"line_number":27,"context_line":"\u0027project_id\u0027 as one filter when calling neutronclient to get floatingips."},{"line_number":28,"context_line":"This is hard-coding."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"This blueprint try to relax the restriction of Nova API about listing"},{"line_number":31,"context_line":"floatingips."}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_54dc76e4","line":28,"in_reply_to":"baada198_51f3cb9d","updated":"2014-07-03 02:24:49.000000000","message":"As a aspect of this change, the nova-network will allow getting floatingip of all tenants.\nFor neutron, listing floatingip API will getting floatingip of all tenants as default by admin.\n\nthis change will allow floatingip-list API of nova support \"all-tenants\" flag whether nova use neutron or nova-network.","commit_id":"8972fa92dde3052c0b2e8ad9503cf619c86d92e7"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"18fb269575fb68b11654e5c4ef3e4dd8a6a8837f","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  tenants:"},{"line_number":68,"context_line":"  GET /v2/{tenant_id}/os-floating-ips？all_tenants\u003d{True in bool}"},{"line_number":69,"context_line":"  The new API response body format and response code is same as the original"},{"line_number":70,"context_line":"  API usage."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Security impact"},{"line_number":73,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_d15b5b85","line":70,"updated":"2014-07-02 09:20:18.000000000","message":"You need to add an extra extension to advertise the presence of this API new parameter, for example:\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/contrib/extended_rescue_with_image.py\n\nPlease also implement this in the v3 API.\n\nIf you see the template, it also asks for a json schema for the inputs to this API, as required for the docs and the v3 API validation. Please include that here.","commit_id":"8972fa92dde3052c0b2e8ad9503cf619c86d92e7"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"87363b665af3bfe8f579f9229d9fcd0e9ee32932","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  tenants:"},{"line_number":68,"context_line":"  GET /v2/{tenant_id}/os-floating-ips？all_tenants\u003d{True in bool}"},{"line_number":69,"context_line":"  The new API response body format and response code is same as the original"},{"line_number":70,"context_line":"  API usage."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Security impact"},{"line_number":73,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_f79f4cb2","line":70,"in_reply_to":"baada198_d15b5b85","updated":"2014-07-03 02:24:49.000000000","message":"Nova v3 API has not implemented the floatingip related APIs, because that has been decided not to port any of the network related functionality to v3.\nhttps://review.openstack.org/#/c/34754/\n\nAdditionally, you have mentioned that nova proxy neutron are being deprecated, do you think this bp is valueless? if so, I will abandon this spes.","commit_id":"8972fa92dde3052c0b2e8ad9503cf619c86d92e7"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"18fb269575fb68b11654e5c4ef3e4dd8a6a8837f","unresolved":false,"context_lines":[{"line_number":72,"context_line":"Security impact"},{"line_number":73,"context_line":"---------------"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Admin user can get other tenants\u0027 floatingip info."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Notifications impact"},{"line_number":78,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_51fd8b39","line":75,"updated":"2014-07-02 09:20:18.000000000","message":"To be clear, it should be an entry in policy.json that restricts who can use this parameter, and that needs to default to admin.\n\nPlease document the name of that option here, we need enough details for the docs to be written from the spec, ideally.","commit_id":"8972fa92dde3052c0b2e8ad9503cf619c86d92e7"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"87363b665af3bfe8f579f9229d9fcd0e9ee32932","unresolved":false,"context_lines":[{"line_number":72,"context_line":"Security impact"},{"line_number":73,"context_line":"---------------"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Admin user can get other tenants\u0027 floatingip info."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Notifications impact"},{"line_number":78,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_94fd2e3d","line":75,"in_reply_to":"baada198_51fd8b39","updated":"2014-07-03 02:24:49.000000000","message":"Done","commit_id":"8972fa92dde3052c0b2e8ad9503cf619c86d92e7"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"18fb269575fb68b11654e5c4ef3e4dd8a6a8837f","unresolved":false,"context_lines":[{"line_number":83,"context_line":"---------------------"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Allow user to specify \"all-tenants\" flag to get floatingips of all tenants,"},{"line_number":86,"context_line":"and this change is forward compatible."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Performance Impact"},{"line_number":89,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_b1998721","line":86,"updated":"2014-07-02 09:20:18.000000000","message":"Do you mean you are going to make the python-novaclient change to support this extra flag. That would be nice.","commit_id":"8972fa92dde3052c0b2e8ad9503cf619c86d92e7"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"87363b665af3bfe8f579f9229d9fcd0e9ee32932","unresolved":false,"context_lines":[{"line_number":83,"context_line":"---------------------"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Allow user to specify \"all-tenants\" flag to get floatingips of all tenants,"},{"line_number":86,"context_line":"and this change is forward compatible."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Performance Impact"},{"line_number":89,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_b4f8724a","line":86,"in_reply_to":"baada198_b1998721","updated":"2014-07-03 02:24:49.000000000","message":"yeah, as the last item of \"Proposed change\" said","commit_id":"8972fa92dde3052c0b2e8ad9503cf619c86d92e7"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"18fb269575fb68b11654e5c4ef3e4dd8a6a8837f","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"This code will be tested in unit tests for this function."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"The API will be tested by adding tempest."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Documentation Impact"},{"line_number":145,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_718fefcc","line":142,"updated":"2014-07-02 09:20:18.000000000","message":"no need to mention unit tests, but please do add tempest tests for this.","commit_id":"8972fa92dde3052c0b2e8ad9503cf619c86d92e7"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"87363b665af3bfe8f579f9229d9fcd0e9ee32932","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"This code will be tested in unit tests for this function."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"The API will be tested by adding tempest."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Documentation Impact"},{"line_number":145,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_34170253","line":142,"in_reply_to":"baada198_718fefcc","updated":"2014-07-03 02:24:49.000000000","message":"Done","commit_id":"8972fa92dde3052c0b2e8ad9503cf619c86d92e7"}]}