)]}'
{"specs/juno/rootwrap-daemon-mode.rst":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"829b324159e789bf154e58be3ce30d9f345b5feb","unresolved":false,"context_lines":[{"line_number":60,"context_line":"``nova-rootwrap-daemon``. It should be added to the ``sudoers`` file."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"All security issues with using client+daemon instead of plain rootwrap are"},{"line_number":63,"context_line":"covered in [#rw_bp]_."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Notifications impact"},{"line_number":66,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baada198_cf4788ba","line":63,"updated":"2014-07-08 09:53:04.000000000","message":"That link appears to have little to no detailed information about security risks inherent in opening an RPC service that allows remote clients to run commands as root.","commit_id":"19ddcf744706eb8aa2b3b3a264863bd804929834"},{"author":{"_account_id":8787,"name":"Dmitry Borodaenko","email":"angdraug@gmail.com","username":"angdraug"},"change_message_id":"ffb57ec06504ad4ab98aee943fa72753eba6cdda","unresolved":false,"context_lines":[{"line_number":60,"context_line":"``nova-rootwrap-daemon``. It should be added to the ``sudoers`` file."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"All security issues with using client+daemon instead of plain rootwrap are"},{"line_number":63,"context_line":"covered in [#rw_bp]_."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Notifications impact"},{"line_number":66,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baada198_51ce4884","line":63,"in_reply_to":"baada198_cf4788ba","updated":"2014-07-10 21:29:53.000000000","message":"As explained in cover comments here and in the spec at the link, the communication is exclusively over a UNIX socket, which excludes remote clients from consideration.","commit_id":"19ddcf744706eb8aa2b3b3a264863bd804929834"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"e17ae5fb5c7048eac689a2985b52c995883d72fd","unresolved":false,"context_lines":[{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"As you can see in [#ne_ml]_ rootwrap presents big performance overhead for"},{"line_number":25,"context_line":"Neutron. Impact on Nova is not as signigicant since most of the work is done"},{"line_number":26,"context_line":"with libvirt\u0027s API but it is still there."},{"line_number":27,"context_line":"Details of the overhead are covered in [#rw_bp]_."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_bb398ada","line":25,"range":{"start_line":25,"start_character":34,"end_line":25,"end_character":45},"updated":"2014-11-10 15:12:42.000000000","message":"s/signigicant/significant","commit_id":"505ec8701fffdc444722e0ee1e8d0886f31bd22f"}],"specs/kilo/approved/rootwrap-daemon-mode.rst":[{"author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"change_message_id":"83eceb022be992a3b64cb8515e1c4435f41f51d8","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Proposed change"},{"line_number":42,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"This blueprint proposes adopting upcoming change in oslo.rootwrap that would"},{"line_number":45,"context_line":"allow to run rootwrap daemon. The daemon will work just as a usual rootwrap but"},{"line_number":46,"context_line":"will accept commands to be run over authenticated UNIX domain socket instead of"},{"line_number":47,"context_line":"command line and will run continuously in background."}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_2438b1d3","line":44,"updated":"2015-01-14 10:01:43.000000000","message":"That change is already there.","commit_id":"b133e125103451c61dd6e6a0f8fce45f3428bfc1"}],"specs/kilo/rootwrap-daemon-mode.rst":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"a1bd09ba880ff6aed5f24f1f63d7a8ff41b84dd7","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"As you can see in [#ne_ml]_ rootwrap presents big performance overhead for"},{"line_number":25,"context_line":"Neutron. Impact on Nova is not as signigicant since most of the work is done"},{"line_number":26,"context_line":"with libvirt\u0027s API but it is still there."},{"line_number":27,"context_line":"Details of the overhead are covered in [#rw_bp]_."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_11b93ae9","line":26,"updated":"2014-11-13 14:22:11.000000000","message":"Can we have some actual concrete examples \u0026 figures.","commit_id":"dfc8f8e93d67b9caa202f95392b03b69774a301c"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"a1bd09ba880ff6aed5f24f1f63d7a8ff41b84dd7","unresolved":false,"context_lines":[{"line_number":93,"context_line":"switches on new behavior. Note that by default ``use_rootwrap_daemon`` will be"},{"line_number":94,"context_line":"turned off so to get the speedup one will have to turn it on. With it turned on"},{"line_number":95,"context_line":"``nova-rootwrap-daemon`` is used to run commands that require root priviledges."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"This change also introduces new binary ``nova-rootwrap-daemon`` that should"},{"line_number":98,"context_line":"be deployed beside ``nova-rootwrap`` and added to ``sudoers``."},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_11b5bacc","line":96,"updated":"2014-11-13 14:22:11.000000000","message":"If the current performance bottleneck is a serious problem why would anyone wish to have this setting turned off ?  If it reliable IMHO we should just have it there permanently on, if it is unreliable then people won\u0027t be able to use it even if they want to.  I\u0027d also be concerned that with it defaulting off, developers will never be utilizing this code path in day to day work.\n\nIOW, we shouldn\u0027t add a config parameter which amounts to  \"make_it_fast\u003dyes|no\".\n\nJust always use daemon mode IMHO.","commit_id":"dfc8f8e93d67b9caa202f95392b03b69774a301c"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"a1bd09ba880ff6aed5f24f1f63d7a8ff41b84dd7","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"This change doesn\u0027t change APIs so it doesn\u0027t require additional integration"},{"line_number":129,"context_line":"tests. If tempest is happy with ``use_rootwrap_daemon`` turned on, the feature"},{"line_number":130,"context_line":"works."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Documentation Impact"},{"line_number":133,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_51f4a286","line":130,"updated":"2014-11-13 14:22:11.000000000","message":"If we have the config parameter, then we really ought to make sure we have tests that run with it enabled and tests that run with it disabled.\n\nTo me this is just an example of why we shouldn\u0027t have a config parameter for this. We should just unconditionally use daemon mode all the time and avoid adding 2 separate codepaths.","commit_id":"dfc8f8e93d67b9caa202f95392b03b69774a301c"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"a1bd09ba880ff6aed5f24f1f63d7a8ff41b84dd7","unresolved":false,"context_lines":[{"line_number":138,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":".. [#rw_bp] oslo.rootwrap blueprint:"},{"line_number":141,"context_line":"   https://blueprints.launchpad.net/oslo/+spec/rootwrap-daemon-mode"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":".. [#ne_ml] Original mailing list thread:"},{"line_number":144,"context_line":"   http://lists.openstack.org/pipermail/openstack-dev/2014-March/029017.html"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_11885ae6","line":141,"updated":"2014-11-13 14:22:11.000000000","message":"LP is giving me a 404 on this.","commit_id":"dfc8f8e93d67b9caa202f95392b03b69774a301c"}],"specs/liberty/approved/nova-rootwrap-daemon-mode.rst":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"02af654a8c18c4955c6ada99fe846907b0859d84","unresolved":false,"context_lines":[{"line_number":16,"context_line":"rootwrap produce significant performance overhead. This blueprint is one of the"},{"line_number":17,"context_line":"series of blueprints that would cover mitigating rootwrap part of the overhead"},{"line_number":18,"context_line":"using new mode of operations for rootwrap - daemon mode. These blueprints will"},{"line_number":19,"context_line":"be created in several projects starting with oslo.rootwrap [#rw_bp]_."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Problem description"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9af37de9_741707ee","line":19,"updated":"2015-05-11 15:00:52.000000000","message":"minor nit: I would just change this to more like:\n\nNeutron has adopted this now, it helped XX% lets adopt this in Nova.","commit_id":"32d8f39841f03213c16318628cf66d55e593b723"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"6928ef4a8e88f3997e36b907bad7e6b8b321c276","unresolved":false,"context_lines":[{"line_number":16,"context_line":"rootwrap produce significant performance overhead. This blueprint is one of the"},{"line_number":17,"context_line":"series of blueprints that would cover mitigating rootwrap part of the overhead"},{"line_number":18,"context_line":"using new mode of operations for rootwrap - daemon mode. These blueprints will"},{"line_number":19,"context_line":"be created in several projects starting with oslo.rootwrap [#rw_bp]_."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Problem description"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa32b979_ef8abb63","line":19,"in_reply_to":"9af37de9_741707ee","updated":"2015-06-23 19:12:22.000000000","message":"Done","commit_id":"32d8f39841f03213c16318628cf66d55e593b723"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"02af654a8c18c4955c6ada99fe846907b0859d84","unresolved":false,"context_lines":[{"line_number":24,"context_line":"As you can see in [#ne_ml]_ rootwrap presents big performance overhead for"},{"line_number":25,"context_line":"Neutron. Impact on Nova is not as signigicant since most of the work is done"},{"line_number":26,"context_line":"with libvirt\u0027s API but it is still there."},{"line_number":27,"context_line":"Details of the overhead are covered in [#rw_bp]_."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Use Cases"},{"line_number":30,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9af37de9_147c3b71","line":27,"updated":"2015-05-11 15:00:52.000000000","message":"I think its worth talking about neutron having adopted it already, assuming that effort is now complete?","commit_id":"32d8f39841f03213c16318628cf66d55e593b723"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"6928ef4a8e88f3997e36b907bad7e6b8b321c276","unresolved":false,"context_lines":[{"line_number":24,"context_line":"As you can see in [#ne_ml]_ rootwrap presents big performance overhead for"},{"line_number":25,"context_line":"Neutron. Impact on Nova is not as signigicant since most of the work is done"},{"line_number":26,"context_line":"with libvirt\u0027s API but it is still there."},{"line_number":27,"context_line":"Details of the overhead are covered in [#rw_bp]_."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Use Cases"},{"line_number":30,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa32b979_cfe4973d","line":27,"in_reply_to":"9af37de9_147c3b71","updated":"2015-06-23 19:12:22.000000000","message":"i\u0027ll post some numbers off from our CI runs. let\u0027s not focus on neutron.","commit_id":"32d8f39841f03213c16318628cf66d55e593b723"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"02af654a8c18c4955c6ada99fe846907b0859d84","unresolved":false,"context_lines":[{"line_number":36,"context_line":"-----------------"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The kilo priorities list is currently not defined. However under the currently"},{"line_number":39,"context_line":"proposed list of priorities it would fall under \"Performance\"."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Proposed change"},{"line_number":42,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9af37de9_745f070f","line":39,"updated":"2015-05-11 15:00:52.000000000","message":"please remove this bit.","commit_id":"32d8f39841f03213c16318628cf66d55e593b723"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"6928ef4a8e88f3997e36b907bad7e6b8b321c276","unresolved":false,"context_lines":[{"line_number":36,"context_line":"-----------------"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The kilo priorities list is currently not defined. However under the currently"},{"line_number":39,"context_line":"proposed list of priorities it would fall under \"Performance\"."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Proposed change"},{"line_number":42,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa32b979_2fc3c38a","line":39,"in_reply_to":"9af37de9_745f070f","updated":"2015-06-23 19:12:22.000000000","message":"Done","commit_id":"32d8f39841f03213c16318628cf66d55e593b723"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"02af654a8c18c4955c6ada99fe846907b0859d84","unresolved":false,"context_lines":[{"line_number":96,"context_line":"are required to be run with root priviledges in ``nova-compute`` and"},{"line_number":97,"context_line":"``nova-network``. Current state of rootwrap daemon shows over 10x speedup"},{"line_number":98,"context_line":"comparing to usual ``sudo rootwrap`` call. Total speedup for Nova will be less"},{"line_number":99,"context_line":"impressive but should be noticeable."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Other deployer impact"},{"line_number":102,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9af37de9_d4e7d310","line":99,"updated":"2015-05-11 15:00:52.000000000","message":"can we talk real numbers here now?","commit_id":"32d8f39841f03213c16318628cf66d55e593b723"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"6928ef4a8e88f3997e36b907bad7e6b8b321c276","unresolved":false,"context_lines":[{"line_number":96,"context_line":"are required to be run with root priviledges in ``nova-compute`` and"},{"line_number":97,"context_line":"``nova-network``. Current state of rootwrap daemon shows over 10x speedup"},{"line_number":98,"context_line":"comparing to usual ``sudo rootwrap`` call. Total speedup for Nova will be less"},{"line_number":99,"context_line":"impressive but should be noticeable."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Other deployer impact"},{"line_number":102,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa32b979_af1833d4","line":99,"in_reply_to":"9af37de9_d4e7d310","updated":"2015-06-23 19:12:22.000000000","message":"yes","commit_id":"32d8f39841f03213c16318628cf66d55e593b723"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"02af654a8c18c4955c6ada99fe846907b0859d84","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"This change doesn\u0027t change APIs so it doesn\u0027t require additional integration"},{"line_number":141,"context_line":"tests. If tempest is happy with ``use_rootwrap_daemon`` turned on, the feature"},{"line_number":142,"context_line":"works."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Documentation Impact"},{"line_number":145,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9af37de9_545e43ea","line":142,"updated":"2015-05-11 15:00:52.000000000","message":"are we going to turn this on in the gate jobs, or some combination of them?\n\nMany only turn it on in the nova-network job?","commit_id":"32d8f39841f03213c16318628cf66d55e593b723"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"6928ef4a8e88f3997e36b907bad7e6b8b321c276","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"This change doesn\u0027t change APIs so it doesn\u0027t require additional integration"},{"line_number":141,"context_line":"tests. If tempest is happy with ``use_rootwrap_daemon`` turned on, the feature"},{"line_number":142,"context_line":"works."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Documentation Impact"},{"line_number":145,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa32b979_cf1d77bf","line":142,"in_reply_to":"9af37de9_545e43ea","updated":"2015-06-23 19:12:22.000000000","message":"Done","commit_id":"32d8f39841f03213c16318628cf66d55e593b723"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"446b11cd44ecba5e1e8f76bcdcfccd2ccbed3d9c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Project Priority"},{"line_number":36,"context_line":"-----------------"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Performance enchancements"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Proposed change"},{"line_number":41,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"fa32b979_553ed88b","line":38,"updated":"2015-06-23 20:11:18.000000000","message":"this should just say none. perforamnnce isn\u0027t a priorty actaully","commit_id":"1a1caece1e62693faae090c660d3c07f7983a5ee"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"f216a6915d82ddcab016ea0e133699af578522ae","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Project Priority"},{"line_number":36,"context_line":"-----------------"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Performance enchancements"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Proposed change"},{"line_number":41,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"fa32b979_0704a315","line":38,"in_reply_to":"fa32b979_553ed88b","updated":"2015-06-23 20:57:28.000000000","message":"ack.","commit_id":"1a1caece1e62693faae090c660d3c07f7983a5ee"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"446b11cd44ecba5e1e8f76bcdcfccd2ccbed3d9c","unresolved":false,"context_lines":[{"line_number":101,"context_line":"daemon mode on and off, here\u0027s what we see:"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Daemon Off - Average 0.08981064764 seconds"},{"line_number":104,"context_line":"Daemon On  - Average 0.02984345922 seconds"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Other deployer impact"},{"line_number":107,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"fa32b979_b56404b9","line":104,"updated":"2015-06-23 20:11:18.000000000","message":"not bad, I assume this is per rootwrapped call.","commit_id":"1a1caece1e62693faae090c660d3c07f7983a5ee"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"f216a6915d82ddcab016ea0e133699af578522ae","unresolved":false,"context_lines":[{"line_number":101,"context_line":"daemon mode on and off, here\u0027s what we see:"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Daemon Off - Average 0.08981064764 seconds"},{"line_number":104,"context_line":"Daemon On  - Average 0.02984345922 seconds"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Other deployer impact"},{"line_number":107,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"fa32b979_aa0b3e23","line":104,"in_reply_to":"fa32b979_b56404b9","updated":"2015-06-23 20:57:28.000000000","message":"oops, will add a link to spreadsheet below","commit_id":"1a1caece1e62693faae090c660d3c07f7983a5ee"},{"author":{"_account_id":708,"name":"Yuriy Taraday","email":"yuriy@taraday.nl","username":"yorik-sar"},"change_message_id":"c0acdf6c9124e80956324c88dcb78335765610a5","unresolved":false,"context_lines":[{"line_number":73,"context_line":"---------------"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"This change requires additional endpoint to be available to run as root -"},{"line_number":76,"context_line":"``nova-rootwrap-daemon``. It should be added to the ``sudoers`` file."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"All security issues with using client+daemon instead of plain rootwrap are"},{"line_number":79,"context_line":"covered in [#rw_bp]_."}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa32b979_60da35ea","line":76,"updated":"2015-06-23 22:18:07.000000000","message":"I\u0027d like to suggest using oslo-rootwrap-daemon endpoint here. There\u0027s no point in adding another copy of that binary to Nova.","commit_id":"d17ae15825fa23bb58c9f0828f6f50048e9c8cb6"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"27a3a3f586b694f6a35a17c0fbe0572dd9867ab0","unresolved":false,"context_lines":[{"line_number":73,"context_line":"---------------"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"This change requires additional endpoint to be available to run as root -"},{"line_number":76,"context_line":"``nova-rootwrap-daemon``. It should be added to the ``sudoers`` file."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"All security issues with using client+daemon instead of plain rootwrap are"},{"line_number":79,"context_line":"covered in [#rw_bp]_."}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa32b979_83b88712","line":76,"in_reply_to":"fa32b979_60da35ea","updated":"2015-06-24 13:02:37.000000000","message":"yes, already done Yuriy - https://review.openstack.org/#/c/180695/30/setup.cfg,cm","commit_id":"d17ae15825fa23bb58c9f0828f6f50048e9c8cb6"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"974f2d77c431c6f1060664ff7f07096e183a76a1","unresolved":false,"context_lines":[{"line_number":73,"context_line":"---------------"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"This change requires additional endpoint to be available to run as root -"},{"line_number":76,"context_line":"``nova-rootwrap-daemon``. It should be added to the ``sudoers`` file."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"All security issues with using client+daemon instead of plain rootwrap are"},{"line_number":79,"context_line":"covered in [#rw_bp]_."}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa32b979_e322b353","line":76,"in_reply_to":"fa32b979_83b88712","updated":"2015-06-24 13:05:25.000000000","message":"So we should update the spec to represent this, but we can do that in a follow up patch.","commit_id":"d17ae15825fa23bb58c9f0828f6f50048e9c8cb6"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6d0716c7a062460e4ead638ee4164c3de42fd02e","unresolved":false,"context_lines":[{"line_number":156,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":".. [#rw_bp] oslo.rootwrap blueprint:"},{"line_number":159,"context_line":"   https://blueprints.launchpad.net/oslo.rootwrap/+spec/nova-rootwrap-daemon-mode"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":".. [#ne_ml] Original mailing list thread:"},{"line_number":162,"context_line":"   http://lists.openstack.org/pipermail/openstack-dev/2014-March/029017.html"}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa32b979_836647b9","line":159,"range":{"start_line":159,"start_character":3,"end_line":159,"end_character":81},"updated":"2015-06-24 13:03:35.000000000","message":"I think this should be:\nhttps://blueprints.launchpad.net/oslo.rootwrap/+spec/rootwrap-daemon-mode","commit_id":"d17ae15825fa23bb58c9f0828f6f50048e9c8cb6"}]}