)]}'
{"specs/kilo/approved/vif-driver-ib-passthrough.rst":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"4f85f5d2239b78447f88d1fce649c480e6f0520b","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Till Juno Release (including) InfiniBand SR-IOV networking was possible via"},{"line_number":21,"context_line":"out of the tree nova vif driver with neutron Mellanox Ml2 Mechanism Driver."},{"line_number":22,"context_line":"Due to Juno efforts to integrate SR-IOV as part of the nova, it is possible"},{"line_number":23,"context_line":"to add Infiniband SR-IOV vif plugging to LibvirtGenericVIFDriver."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aa7fdbe_59517cd7","line":22,"updated":"2014-10-29 19:45:49.000000000","message":"I don\u0027t follow this problem statement.\n\nAlso is the neutron Mellanox ML2 SR-IOV InfiniBand driver in neutron or out of tree?","commit_id":"679a16b7edbc96d03e7e4310915c5ec68733513b"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"adde18886ab0c8ae48cba66360c12a0942ba07d6","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Till Juno Release (including) InfiniBand SR-IOV networking was possible via"},{"line_number":21,"context_line":"out of the tree nova vif driver with neutron Mellanox Ml2 Mechanism Driver."},{"line_number":22,"context_line":"Due to Juno efforts to integrate SR-IOV as part of the nova, it is possible"},{"line_number":23,"context_line":"to add Infiniband SR-IOV vif plugging to LibvirtGenericVIFDriver."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aa7fdbe_548ce37f","line":22,"in_reply_to":"9aa7fdbe_59517cd7","updated":"2014-10-30 13:58:13.000000000","message":"No , neutron driver is in the tree, actually from the neutron side the IB related implementation is not different from the Ethernet one.\nRegarding the nova, it was possible to experiment with IB Fabric SR-IOV VIFDriver via libvirt/vif_driver, which was removed in Juno.","commit_id":"679a16b7edbc96d03e7e4310915c5ec68733513b"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"4f85f5d2239b78447f88d1fce649c480e6f0520b","unresolved":false,"context_lines":[{"line_number":76,"context_line":"Other end user impact"},{"line_number":77,"context_line":"---------------------"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"This blueprint adds no other end user impact."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Performance Impact"},{"line_number":82,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aa7fdbe_790480c6","line":79,"updated":"2014-10-29 19:45:49.000000000","message":"just say None","commit_id":"679a16b7edbc96d03e7e4310915c5ec68733513b"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"adde18886ab0c8ae48cba66360c12a0942ba07d6","unresolved":false,"context_lines":[{"line_number":76,"context_line":"Other end user impact"},{"line_number":77,"context_line":"---------------------"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"This blueprint adds no other end user impact."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Performance Impact"},{"line_number":82,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aa7fdbe_74e80717","line":79,"in_reply_to":"9aa7fdbe_790480c6","updated":"2014-10-30 13:58:13.000000000","message":"Done","commit_id":"679a16b7edbc96d03e7e4310915c5ec68733513b"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"4f85f5d2239b78447f88d1fce649c480e6f0520b","unresolved":false,"context_lines":[{"line_number":115,"context_line":"Dependencies"},{"line_number":116,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"*  ebrctl library is required."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Testing"},{"line_number":121,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aa7fdbe_396bd886","line":118,"updated":"2014-10-29 19:45:49.000000000","message":"can you elaborate on this. Is this a python dependency? Is it already in global-requirements? etc. Is this packaged up by distros already etc.","commit_id":"679a16b7edbc96d03e7e4310915c5ec68733513b"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"adde18886ab0c8ae48cba66360c12a0942ba07d6","unresolved":false,"context_lines":[{"line_number":115,"context_line":"Dependencies"},{"line_number":116,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"*  ebrctl library is required."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Testing"},{"line_number":121,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a8c0949_8231bca4","line":118,"in_reply_to":"9aa7fdbe_396bd886","updated":"2014-10-30 13:58:13.000000000","message":"This is management daemon which is part of the nic driver package (not upstream)","commit_id":"679a16b7edbc96d03e7e4310915c5ec68733513b"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"4f85f5d2239b78447f88d1fce649c480e6f0520b","unresolved":false,"context_lines":[{"line_number":121,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Unit tests will be added to validate these modifications."},{"line_number":124,"context_line":"Third party testing is already in place to verify the complete solution."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Documentation Impact"},{"line_number":127,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aa7fdbe_59689c87","line":124,"updated":"2014-10-29 19:45:49.000000000","message":"Link to the CI system for this?","commit_id":"679a16b7edbc96d03e7e4310915c5ec68733513b"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"adde18886ab0c8ae48cba66360c12a0942ba07d6","unresolved":false,"context_lines":[{"line_number":121,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Unit tests will be added to validate these modifications."},{"line_number":124,"context_line":"Third party testing is already in place to verify the complete solution."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Documentation Impact"},{"line_number":127,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aa7fdbe_f4db177b","line":124,"in_reply_to":"9aa7fdbe_59689c87","updated":"2014-10-30 13:58:13.000000000","message":"Done","commit_id":"679a16b7edbc96d03e7e4310915c5ec68733513b"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"ffd6ebc2587460985521fd7d3ac1b8cd8727ab93","unresolved":false,"context_lines":[{"line_number":20,"context_line":"Till Juno Release (including) InfiniBand (IB) SR-IOV networking was possible"},{"line_number":21,"context_line":"via out of the tree nova vif driver with neutron Mellanox Ml2 Mechanism Driver."},{"line_number":22,"context_line":"Due to Juno efforts to integrate SR-IOV device scheduling as part of the nova,"},{"line_number":23,"context_line":"it is possible to add IB SR-IOV vif plugging to LibvirtGenericVIFDriver."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Use Cases"},{"line_number":26,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a8c0949_3293effb","line":23,"updated":"2014-10-30 21:01:44.000000000","message":"it is not possible?","commit_id":"67144c2734998e54d8310ef07e1da44d3f28a705"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"bd612033396a76b513a1d9f485fb9abf3746b918","unresolved":false,"context_lines":[{"line_number":20,"context_line":"Till Juno Release (including) InfiniBand (IB) SR-IOV networking was possible"},{"line_number":21,"context_line":"via out of the tree nova vif driver with neutron Mellanox Ml2 Mechanism Driver."},{"line_number":22,"context_line":"Due to Juno efforts to integrate SR-IOV device scheduling as part of the nova,"},{"line_number":23,"context_line":"it is possible to add IB SR-IOV vif plugging to LibvirtGenericVIFDriver."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Use Cases"},{"line_number":26,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_8acf5f55","line":23,"in_reply_to":"7a8c0949_3293effb","updated":"2014-11-17 09:33:59.000000000","message":"Currently only ethernet SR-IOV is supported","commit_id":"67144c2734998e54d8310ef07e1da44d3f28a705"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"ffd6ebc2587460985521fd7d3ac1b8cd8727ab93","unresolved":false,"context_lines":[{"line_number":116,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"proprietary \u0027ebrctl\u0027 library is required. This is installed as part"},{"line_number":119,"context_line":"of the Driver OFED package."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Testing"},{"line_number":122,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a8c0949_12ad1332","line":119,"updated":"2014-10-30 21:01:44.000000000","message":"Don\u0027t knwo what OFED means. ahh  http://www.mellanox.com/products/ciov_ib_drivers_vi3-1.php","commit_id":"67144c2734998e54d8310ef07e1da44d3f28a705"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"ffd6ebc2587460985521fd7d3ac1b8cd8727ab93","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Unit tests will be added to validate these modifications."},{"line_number":125,"context_line":"Third party testing is already in place to verify the complete solution:"},{"line_number":126,"context_line":"https://wiki.openstack.org/wiki/ThirdPartySystems/Mellanox_CI"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Documentation Impact"},{"line_number":129,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a8c0949_7263b71a","line":126,"updated":"2014-10-30 21:01:44.000000000","message":"Thanks, hopefully at the summit we can flesh out what the exact third party CI testing requirements will be.","commit_id":"67144c2734998e54d8310ef07e1da44d3f28a705"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"bd612033396a76b513a1d9f485fb9abf3746b918","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Unit tests will be added to validate these modifications."},{"line_number":125,"context_line":"Third party testing is already in place to verify the complete solution:"},{"line_number":126,"context_line":"https://wiki.openstack.org/wiki/ThirdPartySystems/Mellanox_CI"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Documentation Impact"},{"line_number":129,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_0a19afd6","line":126,"in_reply_to":"7a8c0949_7263b71a","updated":"2014-11-17 09:33:59.000000000","message":"We are in progress of bringing CI job running on nova to verify SR-IOV. This will be applicable both for Ethernet and InfiniBand SR-IOV devices","commit_id":"67144c2734998e54d8310ef07e1da44d3f28a705"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"7db6c10e33b68a6d7b23b7b123b8e6c5dd1770ce","unresolved":false,"context_lines":[{"line_number":34,"context_line":"Project Priority"},{"line_number":35,"context_line":"-----------------"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Under proposed list of priorities it would fall under \"Performance\"."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Proposed change"},{"line_number":40,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a890539_d11316ff","line":37,"updated":"2014-12-02 20:54:56.000000000","message":"Performance is not a priority: http://specs.openstack.org/openstack/nova-specs/priorities/kilo-priorities.html\n\nThis should just say None","commit_id":"11eaf0340b41014f287877cebae021e2d5f7dc0e"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"283b9d827e96203647aa7ee011f3cd2385a76bf3","unresolved":false,"context_lines":[{"line_number":44,"context_line":"The VIF_TYPE_HOSTDEV is already supported by ML2 Mellanox Mechanism Driver"},{"line_number":45,"context_line":"and enables networking configuration of SR-IOV Virtual Functions on IB Fabric."},{"line_number":46,"context_line":"The vif_type name should be renamed to VIF_TYPE_IB_HOSTDEV to indicate specific"},{"line_number":47,"context_line":"InfiniBand vif_type."},{"line_number":48,"context_line":"Currently, there is no standard API to set InfiniBand vGuid (equivalent for"},{"line_number":49,"context_line":"Ethernet mac address), therefor special driver utility will be used to set it."},{"line_number":50,"context_line":"This utility is already used in case of mlnx_direct vif_type."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_14e58adc","line":47,"updated":"2014-12-11 09:55:39.000000000","message":"Renaming a VIF type will break backwards compatibility with existing deployments so we cannot do that. \n\nIf the VIF impl already exists with this different name, what exactly is this blueprint wanting todo besides rename it ?","commit_id":"5a8b787c493d326313c5b5c83f7051ee9c17d444"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"eb19263f4de6be5966bc4edfb759193567152e90","unresolved":false,"context_lines":[{"line_number":44,"context_line":"The VIF_TYPE_HOSTDEV is already supported by ML2 Mellanox Mechanism Driver"},{"line_number":45,"context_line":"and enables networking configuration of SR-IOV Virtual Functions on IB Fabric."},{"line_number":46,"context_line":"The vif_type name should be renamed to VIF_TYPE_IB_HOSTDEV to indicate specific"},{"line_number":47,"context_line":"InfiniBand vif_type."},{"line_number":48,"context_line":"Currently, there is no standard API to set InfiniBand vGuid (equivalent for"},{"line_number":49,"context_line":"Ethernet mac address), therefor special driver utility will be used to set it."},{"line_number":50,"context_line":"This utility is already used in case of mlnx_direct vif_type."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_77433042","line":47,"in_reply_to":"3a961159_149d8a0b","updated":"2014-12-11 10:09:52.000000000","message":"Oh whoops, you were refering to a neutron side vif_type, not nova side.","commit_id":"5a8b787c493d326313c5b5c83f7051ee9c17d444"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"45980b530a36dc68bce4c26ee37f610fa1f79bda","unresolved":false,"context_lines":[{"line_number":44,"context_line":"The VIF_TYPE_HOSTDEV is already supported by ML2 Mellanox Mechanism Driver"},{"line_number":45,"context_line":"and enables networking configuration of SR-IOV Virtual Functions on IB Fabric."},{"line_number":46,"context_line":"The vif_type name should be renamed to VIF_TYPE_IB_HOSTDEV to indicate specific"},{"line_number":47,"context_line":"InfiniBand vif_type."},{"line_number":48,"context_line":"Currently, there is no standard API to set InfiniBand vGuid (equivalent for"},{"line_number":49,"context_line":"Ethernet mac address), therefor special driver utility will be used to set it."},{"line_number":50,"context_line":"This utility is already used in case of mlnx_direct vif_type."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_149d8a0b","line":47,"in_reply_to":"3a961159_14e58adc","updated":"2014-12-11 10:00:25.000000000","message":"VIF implementation exists out of the tree and this blueprint proposes to make it part of the GenericLibvirtVifDriver.\nAs for renaming, the vif_type name currently used is \u0027hostdev\u0027, which will be probably rejected in terms of generic VIF driver.  \nRenaming it on neutron side is planned if/as soon as this spec if approved","commit_id":"5a8b787c493d326313c5b5c83f7051ee9c17d444"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"eb19263f4de6be5966bc4edfb759193567152e90","unresolved":false,"context_lines":[{"line_number":136,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"* Infiniband openstack solution documentation:"},{"line_number":139,"context_line":"  https://wiki.openstack.org/wiki/Mellanox-Neutron-Icehouse-Redhat#InfiniBand_Network"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_97aedce4","line":139,"updated":"2014-12-11 10:09:52.000000000","message":"Since you say the nova vif diver for this already exists out of free, can you provide a link to the out of tree impl, and also to the Neutron side impl","commit_id":"5a8b787c493d326313c5b5c83f7051ee9c17d444"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"b74720a4c880fe5050ceff5835f2a51e3b61b04a","unresolved":false,"context_lines":[{"line_number":136,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"* Infiniband openstack solution documentation:"},{"line_number":139,"context_line":"  https://wiki.openstack.org/wiki/Mellanox-Neutron-Icehouse-Redhat#InfiniBand_Network"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_b7d91824","line":139,"in_reply_to":"3a961159_97aedce4","updated":"2014-12-11 10:18:54.000000000","message":"sure:\nneutron side is:\nhttps://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/mlnx/mech_mlnx.py\n\nout of the tree vif driver:\nhttps://github.com/mellanox-openstack/mellanox-vif","commit_id":"5a8b787c493d326313c5b5c83f7051ee9c17d444"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a6c08e05908ba6914e038f97f6be2f2c86837b3a","unresolved":false,"context_lines":[{"line_number":91,"context_line":"To use this feature the deployer must use Infiniband enabled network adapters."},{"line_number":92,"context_line":"Infiniband Subnet Manager should be running to enable IB Fabric."},{"line_number":93,"context_line":"The \u0027ebrctl\u0027 utility should be installed on compute nodes."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Developer impact"},{"line_number":96,"context_line":"----------------"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_70ce1db9","line":94,"updated":"2015-01-13 10:25:52.000000000","message":"The above rename seems to suggest the upgrade will not be smooth. I guess you will have to upgrade the neutron plugin and the nova code in sync.\n\nI would rather you did the rename in the out of tree components, before proposing this spec, then you can skip the upgrade discussion, and just say that user need to be on the latest out of tree code, before upgrading to the in-tree version.","commit_id":"32e6580d488ce05b25f2f10f892855d4e9546a16"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"301346425e002b081963d3ed1a74f92026714a3b","unresolved":false,"context_lines":[{"line_number":91,"context_line":"To use this feature the deployer must use Infiniband enabled network adapters."},{"line_number":92,"context_line":"Infiniband Subnet Manager should be running to enable IB Fabric."},{"line_number":93,"context_line":"The \u0027ebrctl\u0027 utility should be installed on compute nodes."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Developer impact"},{"line_number":96,"context_line":"----------------"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_a58122a2","line":94,"in_reply_to":"3a961159_70ce1db9","updated":"2015-01-13 13:41:21.000000000","message":"I added limitations that upgrade is not going to be smooth","commit_id":"32e6580d488ce05b25f2f10f892855d4e9546a16"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a6c08e05908ba6914e038f97f6be2f2c86837b3a","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Unit tests will be added to validate these modifications."},{"line_number":127,"context_line":"Third party testing is already in place to verify the complete solution:"},{"line_number":128,"context_line":"https://wiki.openstack.org/wiki/ThirdPartySystems/Mellanox_CI"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Documentation Impact"},{"line_number":131,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_7080dd49","line":128,"updated":"2015-01-13 10:25:52.000000000","message":"I think we need to look at getting this CI to report on Nova code, not just neutron code. Is it possible to commit to doing that in this spec?","commit_id":"32e6580d488ce05b25f2f10f892855d4e9546a16"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"301346425e002b081963d3ed1a74f92026714a3b","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Unit tests will be added to validate these modifications."},{"line_number":127,"context_line":"Third party testing is already in place to verify the complete solution:"},{"line_number":128,"context_line":"https://wiki.openstack.org/wiki/ThirdPartySystems/Mellanox_CI"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Documentation Impact"},{"line_number":131,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_65457a6e","line":128,"in_reply_to":"3a961159_7080dd49","updated":"2015-01-13 13:41:21.000000000","message":"we plan to add  nova CI for SR IOV testing by the end of kilo","commit_id":"32e6580d488ce05b25f2f10f892855d4e9546a16"}]}