)]}'
{"specs/kilo/approved/iscsi-multipath-enhancement.rst":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"a043f837e17f12593d19dfaa360d41a28f284b15","unresolved":false,"context_lines":[{"line_number":51,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"When \u0027iscsi_use_multipath\u0027 is enabled in nova.conf, nova should pass new"},{"line_number":54,"context_line":"optional parameter \u0027multipath\u003dTrue\u0027 to Cinder\u0027s initialize_connection API."},{"line_number":55,"context_line":"If this is specified, some backend drivers of Cinder will return multiple"},{"line_number":56,"context_line":"iSCSI portal addresses and corresponding IQNs/LUNs to login to the iSCSI"},{"line_number":57,"context_line":"target."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_72c6e54a","line":54,"updated":"2015-01-14 19:11:07.000000000","message":"It should only set multipath to True if and only if:\n\nnova\u0027s iscsi_use_multipath is enabled AND\nthe multipath daemon is installed and running.\n\nelse, nova should send back \nmultipath\u003dFalse","commit_id":"e11d8ebd7898ed6417ac2410f3e6a86f6f35c2a0"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"b7030f1be6a4fb9e9ca17de29741510a7bd0d7f6","unresolved":false,"context_lines":[{"line_number":51,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"When \u0027iscsi_use_multipath\u0027 is enabled in nova.conf, nova should pass new"},{"line_number":54,"context_line":"optional parameter \u0027multipath\u003dTrue\u0027 to Cinder\u0027s initialize_connection API."},{"line_number":55,"context_line":"If this is specified, some backend drivers of Cinder will return multiple"},{"line_number":56,"context_line":"iSCSI portal addresses and corresponding IQNs/LUNs to login to the iSCSI"},{"line_number":57,"context_line":"target."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_addf1265","line":54,"in_reply_to":"3a961159_72c6e54a","updated":"2015-01-14 19:41:32.000000000","message":"This behavior is open to discussion - please see the comment below from Daniel for the multipathd detection patch:\n\n\"\"\"\nI think this is a really bad practice. Consider consider what happens if there is some bug / problem in the host OS that has caused the multipathd daemon to fail to start up. This code is going to silently change all the guests to use non-multipath setup instead.\n\nIf the CONF.libirt.iscsi_use_multipath is True, then we should *ALWAYS* use multipathd, or raise a hard error. We must never fallback to non-multipath setup if the admin has requested multipath in the config\"\"\"\n\nhttps://review.openstack.org/#/c/134683/11/nova/virt/libvirt/driver.py\n\n\nAs multipath directly impacts the reliability/continuity of instances, I think the admin doesn\u0027t want to use single path, which makes vulnerable to physical path failures, due to misconfiguration of multipathd.","commit_id":"e11d8ebd7898ed6417ac2410f3e6a86f6f35c2a0"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"077ec65a26507499434db601abdccd0d101f29d6","unresolved":false,"context_lines":[{"line_number":51,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"When \u0027iscsi_use_multipath\u0027 is enabled in nova.conf, nova should pass new"},{"line_number":54,"context_line":"optional parameter \u0027multipath\u003dTrue\u0027 to Cinder\u0027s initialize_connection API."},{"line_number":55,"context_line":"If this is specified, some backend drivers of Cinder will return multiple"},{"line_number":56,"context_line":"iSCSI portal addresses and corresponding IQNs/LUNs to login to the iSCSI"},{"line_number":57,"context_line":"target."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_e8082893","line":54,"in_reply_to":"3a961159_addf1265","updated":"2015-01-14 20:08:52.000000000","message":"If iscsi_use_multipath isn\u0027t set, then multipath \u003d False is the answer we return.\n\nIf iscsi_use_multipath is True and we can\u0027t detect multipathd, \nI guess I would be ok with raising an exception in nova at that point and stopping that attachment process.  In which case we don\u0027t even call cinder to do the attachment.   This also prevents the problem of cinder drivers exporting a volume via multiple paths and only detecting one of them on the compute side.  The side affect of this leaving dangling volumes at detach time.","commit_id":"e11d8ebd7898ed6417ac2410f3e6a86f6f35c2a0"},{"author":{"_account_id":10549,"name":"Garth","email":"garth.booth@hpe.com","username":"garthbooth"},"change_message_id":"b332b83410ea50151edff2c64c2582b2b0b777a9","unresolved":false,"context_lines":[{"line_number":61,"context_line":"Even if a part of the portals are not responding, the connection process"},{"line_number":62,"context_line":"should be continued when the other are responding."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"If multiple addresses are not returned from APIs, it should find multiple"},{"line_number":65,"context_line":"targets using discovery, as in the existing design, for compatibility."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a890539_fa37744b","line":64,"updated":"2014-12-06 00:25:44.000000000","message":"Looks good...this closes the loop on the comment I had in the Cinder spec (https://review.openstack.org/#/c/136500) regarding how nova would handle the exising sendTargets query.\n\nGarth","commit_id":"e11d8ebd7898ed6417ac2410f3e6a86f6f35c2a0"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"838c0f8c32c610b9af8c79077f07babad91b0393","unresolved":false,"context_lines":[{"line_number":126,"context_line":"----------"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"- Implement this feature in Cinder"},{"line_number":129,"context_line":"- Modify nova and brick library to login to multiple portals"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Dependencies"},{"line_number":132,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_9df1cb98","line":129,"updated":"2015-01-13 21:38:10.000000000","message":"if nova uses brick is this spec still needed?","commit_id":"e11d8ebd7898ed6417ac2410f3e6a86f6f35c2a0"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"fd2becb85e27a9d35fbf044a9fd42c19a132dd3f","unresolved":false,"context_lines":[{"line_number":126,"context_line":"----------"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"- Implement this feature in Cinder"},{"line_number":129,"context_line":"- Modify nova and brick library to login to multiple portals"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Dependencies"},{"line_number":132,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_cfec7a95","line":129,"in_reply_to":"3a961159_1d331b14","updated":"2015-01-13 22:06:49.000000000","message":"Why not do that first then?","commit_id":"e11d8ebd7898ed6417ac2410f3e6a86f6f35c2a0"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"f18df280bac413c65828d26beb0e061681d252ef","unresolved":false,"context_lines":[{"line_number":126,"context_line":"----------"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"- Implement this feature in Cinder"},{"line_number":129,"context_line":"- Modify nova and brick library to login to multiple portals"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Dependencies"},{"line_number":132,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_1d331b14","line":129,"in_reply_to":"3a961159_9df1cb98","updated":"2015-01-13 21:50:06.000000000","message":"AFAIK, extracting out of brick library to separated library is not yet started. Until then, we need to modify both nova and cinder.","commit_id":"e11d8ebd7898ed6417ac2410f3e6a86f6f35c2a0"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"8f2385e85dce686f7b31ddd272fe5c9c6509bc64","unresolved":false,"context_lines":[{"line_number":126,"context_line":"----------"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"- Implement this feature in Cinder"},{"line_number":129,"context_line":"- Modify nova and brick library to login to multiple portals"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Dependencies"},{"line_number":132,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_85b7b139","line":129,"in_reply_to":"3a961159_cfec7a95","updated":"2015-01-13 22:51:15.000000000","message":"Well, this is what I told from the assigner of brick library (hemna) -- now he is working on multi-attach stuff and cutting out of brick will be after that. Until then, we should modify both implementations.","commit_id":"e11d8ebd7898ed6417ac2410f3e6a86f6f35c2a0"}],"specs/kilo/approved/iscsi-portal-multipath.rst":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"6b3203f42fb6ae4e3c09a993a343e789f790c07d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Proposed change"},{"line_number":42,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Cinder will pass the optional parameters \u0027target_portal_secondary\u0027,"},{"line_number":45,"context_line":"\u0027target_iqn_secondary\u0027, and \u0027target_lun_secondary\u0027 into \u0027connection_info\u0027"},{"line_number":46,"context_line":"returned by os-initialize_connection volume action API, that represents a"},{"line_number":47,"context_line":"list of secondary addresses of the iSCSI portals and the corresponding iqn,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_99721eac","line":44,"updated":"2014-11-18 20:49:16.000000000","message":"I\u0027d suggest renaming these to indicate they are lists rather than single values (like target_portal, target_iqn, etc.).  This seems confusing.\n\ntarget_secondary_portals, target_secondary_iqns, etc., perhaps?","commit_id":"41a535850611e9a9608192d494092bde4d02d05e"}],"specs/liberty/approved/iscsi-multipath-enhancement.rst":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"ff7fdfc92cfe1686dcec8e8a93ddabf22415168f","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"None."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Note that \u0027connection_info\u0027 JSON string with new parameters are stored in the"},{"line_number":82,"context_line":"table \u0027block_device_mapping\u0027, but it doesn\u0027t require changes of schema."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa32b979_aabfe55e","line":81,"updated":"2015-06-23 08:17:50.000000000","message":"It should be the time to play with a real object instead of python primitives for connection_info","commit_id":"0abcba77eef49ba6c1b67b11f3e4968404d7a634"}]}