)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"9f8d304a68afc7f6a9f7e0bb32d6327ae936efe8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This feature will add support for the consideration of PCI"},{"line_number":10,"context_line":"device HW offload capabilities during guest placement. The"},{"line_number":11,"context_line":"user can request PCI device offload functionality for their"},{"line_number":12,"context_line":"guest, this feature will enable the placement of the guest"},{"line_number":13,"context_line":"on a compute node that provides these capabilities."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a890539_d488b2c8","line":11,"updated":"2014-11-20 10:05:45.000000000","message":"I would say its network device offload capabilities","commit_id":"e08ebb1493b821ff0ff95aeab97daaa39625293d"}],"specs/kilo/approved/sriov-sched-with-stateless-offloads.rst":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"9f8d304a68afc7f6a9f7e0bb32d6327ae936efe8","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"SRIOV scheduling with stateless offloads"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/sriov-sched-with-stateless-offloads"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_b47086dd","line":8,"updated":"2014-11-20 10:05:45.000000000","message":"I think this is not limited to SR-IOV, right? Do you mean network device offload capabilities?","commit_id":"e08ebb1493b821ff0ff95aeab97daaa39625293d"},{"author":{"_account_id":11647,"name":"Przemyslaw Czesnowicz","email":"przemyslaw.czesnowicz@intel.com","username":"pczesno"},"change_message_id":"768d6cfd0b9c70f911ffcf3f8e929222d4bfc684","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"SRIOV scheduling with stateless offloads"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/sriov-sched-with-stateless-offloads"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_fc2e62a4","line":8,"in_reply_to":"5a890539_84d3535e","updated":"2014-11-20 17:40:51.000000000","message":"Then, unless more people come up,we would like to keep this limited to SRIOV networking use case. In my opinion PCI passthrough and SRIOV networking are quite different anyway, and it wouldn\u0027t help much if this BP would also target PF\u0027s","commit_id":"e08ebb1493b821ff0ff95aeab97daaa39625293d"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"d8792b7d83b939c18c019bf0effee5a5508b2241","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"SRIOV scheduling with stateless offloads"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/sriov-sched-with-stateless-offloads"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_84d3535e","line":8,"in_reply_to":"5a890539_8e1b727f","updated":"2014-11-20 12:08:51.000000000","message":"I do not have strong opinion on this, but personally prefer to keep things simple. I think that having same way to define this for PF will be appreciated by Cloud admins/operators.","commit_id":"e08ebb1493b821ff0ff95aeab97daaa39625293d"},{"author":{"_account_id":11647,"name":"Przemyslaw Czesnowicz","email":"przemyslaw.czesnowicz@intel.com","username":"pczesno"},"change_message_id":"72f92001902467cca708c8f27270051ebeca4fe9","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"SRIOV scheduling with stateless offloads"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/sriov-sched-with-stateless-offloads"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_8e1b727f","line":8,"in_reply_to":"5a890539_b47086dd","updated":"2014-11-20 11:33:07.000000000","message":"What we plan to do is limited to SR-IOV networking. In the PCI Passthrough case vendor id and device id (passed from flavor ) are enough information to know the capabilities of the device so no additional scheduling is neccessary. Do you think we should extend this to cover passing of pf\u0027s as well and add similar properties to the flavour?","commit_id":"e08ebb1493b821ff0ff95aeab97daaa39625293d"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"9f8d304a68afc7f6a9f7e0bb32d6327ae936efe8","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"With this feature, the user can request certain NIC offloads for their guests,"},{"line_number":83,"context_line":"Openstack will then determine what NIC offloads are available on its compute"},{"line_number":84,"context_line":"nodes and place a guest on a compute node that fulfils the guests requirements."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Project Priority"},{"line_number":87,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_9fa56306","line":84,"updated":"2014-11-20 10:05:45.000000000","message":"In case the request cannot be satisfied, should it fail the VM placement?","commit_id":"e08ebb1493b821ff0ff95aeab97daaa39625293d"},{"author":{"_account_id":11711,"name":"James Chapman","email":"james.p.chapman@intel.com","username":"james-p-chapman"},"change_message_id":"e6157b65175c83531865f7ca0ab51a4b43feb236","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"With this feature, the user can request certain NIC offloads for their guests,"},{"line_number":83,"context_line":"Openstack will then determine what NIC offloads are available on its compute"},{"line_number":84,"context_line":"nodes and place a guest on a compute node that fulfils the guests requirements."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Project Priority"},{"line_number":87,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_3303c3b9","line":84,"in_reply_to":"5a890539_9fa56306","updated":"2014-11-21 12:22:38.000000000","message":"To be consistent with other placement filters, the VM placement should fail if the requested resources cannot be obtained.","commit_id":"e08ebb1493b821ff0ff95aeab97daaa39625293d"},{"author":{"_account_id":11647,"name":"Przemyslaw Czesnowicz","email":"przemyslaw.czesnowicz@intel.com","username":"pczesno"},"change_message_id":"768d6cfd0b9c70f911ffcf3f8e929222d4bfc684","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"With this feature, the user can request certain NIC offloads for their guests,"},{"line_number":83,"context_line":"Openstack will then determine what NIC offloads are available on its compute"},{"line_number":84,"context_line":"nodes and place a guest on a compute node that fulfils the guests requirements."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Project Priority"},{"line_number":87,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_5f02080a","line":84,"in_reply_to":"5a890539_9fa56306","updated":"2014-11-20 17:40:51.000000000","message":"yes","commit_id":"e08ebb1493b821ff0ff95aeab97daaa39625293d"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"c7ef7094e8a6f7f0ec90ea0079788569cc32ff00","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    glance image-update \u003cIMAGE\u003e --property sriov-nic-caps.0\u003dcsum,tso"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"The PCI device model will be extended to add a list of HW offload attributes. A"},{"line_number":106,"context_line":"comma separated list will contain the devices offload information."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Using image properties to change how the image will be scheduled, might involve"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_eeb0d7dd","line":105,"updated":"2014-12-04 13:49:14.000000000","message":"Please specify the model explicitly. Currently, we have \u0027tags\u0027 associated with PCI devices by whitelist configuration.\n\nI guess that they will be added into the \"extra info\"?","commit_id":"e08ebb1493b821ff0ff95aeab97daaa39625293d"},{"author":{"_account_id":11647,"name":"Przemyslaw Czesnowicz","email":"przemyslaw.czesnowicz@intel.com","username":"pczesno"},"change_message_id":"1447aa4c7b90a5294f2bee5e13458bf3d0b2bb5a","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    glance image-update \u003cIMAGE\u003e --property sriov-nic-caps.0\u003dcsum,tso"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"The PCI device model will be extended to add a list of HW offload attributes. A"},{"line_number":106,"context_line":"comma separated list will contain the devices offload information."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Using image properties to change how the image will be scheduled, might involve"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_71892725","line":105,"in_reply_to":"5a890539_eeb0d7dd","updated":"2014-12-04 16:20:44.000000000","message":"Yes we plan to store nic capabilities in extra_info.","commit_id":"e08ebb1493b821ff0ff95aeab97daaa39625293d"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"9f8d304a68afc7f6a9f7e0bb32d6327ae936efe8","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"The PCI device model will be extended to add a list of HW offload attributes. A"},{"line_number":106,"context_line":"comma separated list will contain the devices offload information."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Using image properties to change how the image will be scheduled, might involve"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_5f821b53","line":106,"updated":"2014-11-20 10:05:45.000000000","message":"All options or related subset?","commit_id":"e08ebb1493b821ff0ff95aeab97daaa39625293d"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"e8bce4d47fb470141a098e759bc2aadb04c46752","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"The PCI device model will be extended to add a list of HW offload attributes. A"},{"line_number":106,"context_line":"comma separated list will contain the devices offload information."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Using image properties to change how the image will be scheduled, might involve"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_d7c14130","line":106,"in_reply_to":"5a890539_539a0f6f","updated":"2014-11-23 16:36:00.000000000","message":"Is there any well defined list of supported offload capabilities? Should it be the same list as provided by libvirt discovery? Please add this to the spec.","commit_id":"e08ebb1493b821ff0ff95aeab97daaa39625293d"},{"author":{"_account_id":11711,"name":"James Chapman","email":"james.p.chapman@intel.com","username":"james-p-chapman"},"change_message_id":"e6157b65175c83531865f7ca0ab51a4b43feb236","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"The PCI device model will be extended to add a list of HW offload attributes. A"},{"line_number":106,"context_line":"comma separated list will contain the devices offload information."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Using image properties to change how the image will be scheduled, might involve"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_539a0f6f","line":106,"in_reply_to":"5a890539_5f821b53","updated":"2014-11-21 12:22:38.000000000","message":"All enabled offloads.","commit_id":"e08ebb1493b821ff0ff95aeab97daaa39625293d"},{"author":{"_account_id":11647,"name":"Przemyslaw Czesnowicz","email":"przemyslaw.czesnowicz@intel.com","username":"pczesno"},"change_message_id":"768d6cfd0b9c70f911ffcf3f8e929222d4bfc684","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"The PCI device model will be extended to add a list of HW offload attributes. A"},{"line_number":106,"context_line":"comma separated list will contain the devices offload information."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Using image properties to change how the image will be scheduled, might involve"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_7f0c2495","line":106,"in_reply_to":"5a890539_5f821b53","updated":"2014-11-20 17:40:51.000000000","message":"Intention is to store everything reported by hypervisor","commit_id":"e08ebb1493b821ff0ff95aeab97daaa39625293d"},{"author":{"_account_id":11711,"name":"James Chapman","email":"james.p.chapman@intel.com","username":"james-p-chapman"},"change_message_id":"2895ee09da9ec9983aefd4a22817020e3d12a78d","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"The PCI device model will be extended to add a list of HW offload attributes. A"},{"line_number":106,"context_line":"comma separated list will contain the devices offload information."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Using image properties to change how the image will be scheduled, might involve"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_cd1bb371","line":106,"in_reply_to":"5a890539_d7c14130","updated":"2014-12-01 12:56:16.000000000","message":"We are using ethtool ioctl\u0027s to query the NIC driver for supported offloads. So the plan is to use a list of offloads similar to ethtool.","commit_id":"e08ebb1493b821ff0ff95aeab97daaa39625293d"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"c7ef7094e8a6f7f0ec90ea0079788569cc32ff00","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"The PCI passthrough filter will be modified to take consideration of a PCI"},{"line_number":111,"context_line":"devices offload capabilities during guest placement."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Alternatives"},{"line_number":114,"context_line":"------------"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_2e69ff24","line":112,"updated":"2014-12-04 13:49:14.000000000","message":"Please specify how is the change going to be explicitly. The filter works based on the NUMBER of devices associated with a specific set of \u0027tags\u0027. \n\nNow, the image will be associated with offload properties, which will be translated into requests to PCI devices, right? How is it related to the sr-iov requests specified in --nic? If there are multiple sr-iov ports, does the properties requested in the image apply to all of them?\n\nI\u0027d like to see the above is discussed in this spec.","commit_id":"e08ebb1493b821ff0ff95aeab97daaa39625293d"},{"author":{"_account_id":11647,"name":"Przemyslaw Czesnowicz","email":"przemyslaw.czesnowicz@intel.com","username":"pczesno"},"change_message_id":"1447aa4c7b90a5294f2bee5e13458bf3d0b2bb5a","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"The PCI passthrough filter will be modified to take consideration of a PCI"},{"line_number":111,"context_line":"devices offload capabilities during guest placement."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Alternatives"},{"line_number":114,"context_line":"------------"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_918cd336","line":112,"in_reply_to":"5a890539_2e69ff24","updated":"2014-12-04 16:20:44.000000000","message":"The properties in the image will be matched against sriov ports specified in --nics.\nThe format will allow specifying  different properties for different ports:\n\nglance image-update \u003cIMAGE\u003e --property sriov-nic-caps.0\u003dcsum,tso\n\nglance image-update \u003cIMAGE\u003e --property sriov-nic-caps.1\u003dcsum\n\npci requests will be created with additional tag\nActually no PCI passthrough filter modifications should be neccessary, just modifications to create_pci_requests_for_sriov_ports and pci_stats \n\nWe will update the spec.\n\nThanks","commit_id":"e08ebb1493b821ff0ff95aeab97daaa39625293d"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"796cc5b11e3d7926ff1481a2ad4f0bf524137673","unresolved":false,"context_lines":[{"line_number":94,"context_line":"Libvirt config will be modified to use the NIC offload attributes discovered"},{"line_number":95,"context_line":"when gathering the available resources."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"The user can request PCI device offloads for their guest using the image"},{"line_number":98,"context_line":"properties. The offload properties will then be translated into pci"},{"line_number":99,"context_line":"requests. This gives the user the opportunity to tune their custom image for"},{"line_number":100,"context_line":"optimal performance."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_aea8e920","line":97,"updated":"2014-12-11 08:59:15.000000000","message":"We probably want operator to enable or not this feature for particular tenants. We should make a policy of flavors extra_spec against images meta_data:\n\nsomething like:\n\n   A flavor with property to be a combination of [rx|tx|tso] or the magic \u0027all\u0027 will be confronted to the image meta_data properties.","commit_id":"70c54e806fda0fedeb78a4c69b2ae9c3d7001617"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"e9259daef48176def0aa07e244e4eb01f414ff28","unresolved":false,"context_lines":[{"line_number":94,"context_line":"Libvirt config will be modified to use the NIC offload attributes discovered"},{"line_number":95,"context_line":"when gathering the available resources."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"The user can request PCI device offloads for their guest using the image"},{"line_number":98,"context_line":"properties. The offload properties will then be translated into pci"},{"line_number":99,"context_line":"requests. This gives the user the opportunity to tune their custom image for"},{"line_number":100,"context_line":"optimal performance."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_be5b88f4","line":97,"in_reply_to":"3a961159_4e593a8d","updated":"2014-12-12 12:19:35.000000000","message":"agree it\u0027s out of scope.","commit_id":"70c54e806fda0fedeb78a4c69b2ae9c3d7001617"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"1d1cf2cacb68375a48dfc7d044a1d6cb52c5c814","unresolved":false,"context_lines":[{"line_number":94,"context_line":"Libvirt config will be modified to use the NIC offload attributes discovered"},{"line_number":95,"context_line":"when gathering the available resources."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"The user can request PCI device offloads for their guest using the image"},{"line_number":98,"context_line":"properties. The offload properties will then be translated into pci"},{"line_number":99,"context_line":"requests. This gives the user the opportunity to tune their custom image for"},{"line_number":100,"context_line":"optimal performance."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_4e593a8d","line":97,"in_reply_to":"3a961159_6ef7d6f5","updated":"2014-12-11 14:12:22.000000000","message":"I tend to agree that admin  control over sriov port allocation seems out of scope, but quite important.\nSR-IOV port control may be  leveraged for other attributed, like rate limit /bw guarantee, etc.","commit_id":"70c54e806fda0fedeb78a4c69b2ae9c3d7001617"},{"author":{"_account_id":11711,"name":"James Chapman","email":"james.p.chapman@intel.com","username":"james-p-chapman"},"change_message_id":"ff6967d0ea12c9fbd0175180d5a377418a1a7c59","unresolved":false,"context_lines":[{"line_number":94,"context_line":"Libvirt config will be modified to use the NIC offload attributes discovered"},{"line_number":95,"context_line":"when gathering the available resources."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"The user can request PCI device offloads for their guest using the image"},{"line_number":98,"context_line":"properties. The offload properties will then be translated into pci"},{"line_number":99,"context_line":"requests. This gives the user the opportunity to tune their custom image for"},{"line_number":100,"context_line":"optimal performance."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_b16a087f","line":97,"in_reply_to":"3a961159_aea8e920","updated":"2014-12-11 09:19:44.000000000","message":"The idea behind this feature is that a tenant has a custom image that performs at an optimum when the guest sriov port can avail of certain NIC HW offloads. If we allow the admin to enable/disable this functionality then the tenant might not get the HW offload support they expect.","commit_id":"70c54e806fda0fedeb78a4c69b2ae9c3d7001617"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"262d9041ea79f9d8cc698a80b03facecd2d0e95d","unresolved":false,"context_lines":[{"line_number":94,"context_line":"Libvirt config will be modified to use the NIC offload attributes discovered"},{"line_number":95,"context_line":"when gathering the available resources."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"The user can request PCI device offloads for their guest using the image"},{"line_number":98,"context_line":"properties. The offload properties will then be translated into pci"},{"line_number":99,"context_line":"requests. This gives the user the opportunity to tune their custom image for"},{"line_number":100,"context_line":"optimal performance."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_f4bc7ede","line":97,"in_reply_to":"3a961159_b16a087f","updated":"2014-12-11 09:55:44.000000000","message":"I think I understand; to work as expected only the operator can share custom images with good configurations for the hosts? - In other words, there is no way for an user to upload a custom image which can work as expected?","commit_id":"70c54e806fda0fedeb78a4c69b2ae9c3d7001617"},{"author":{"_account_id":11711,"name":"James Chapman","email":"james.p.chapman@intel.com","username":"james-p-chapman"},"change_message_id":"981ca01e1b7b51fde7e92c0562776096a065b445","unresolved":false,"context_lines":[{"line_number":94,"context_line":"Libvirt config will be modified to use the NIC offload attributes discovered"},{"line_number":95,"context_line":"when gathering the available resources."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"The user can request PCI device offloads for their guest using the image"},{"line_number":98,"context_line":"properties. The offload properties will then be translated into pci"},{"line_number":99,"context_line":"requests. This gives the user the opportunity to tune their custom image for"},{"line_number":100,"context_line":"optimal performance."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_6ef7d6f5","line":97,"in_reply_to":"3a961159_f4bc7ede","updated":"2014-12-11 14:06:56.000000000","message":"It is possible to upload a custom image and modify its meta_data as a tenant user. I have just uploaded a cirros image, modified its meta_data using and booted it.\n\nHowever you are partly correct, the nova API doesn\u0027t let a tenant do this while the glance API does. This is an inconsistency between API\u0027s, i will investigate further and open a bug if required.\n\nE.g\nglance image-update cirros-custom --property offloads\u003dtx\n\nThe functionality you describe in your initial comment is where the admin has control over sriov port allocation. I feel this is a separate feature and out of scope for this spec.\n\nIn my opinion the admin wouldn\u0027t require such granular control over sriov devices, perhaps something like a sriov port quota ?","commit_id":"70c54e806fda0fedeb78a4c69b2ae9c3d7001617"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"e9259daef48176def0aa07e244e4eb01f414ff28","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    glance image-update \u003cIMAGE\u003e --property sriov-nic-caps.0\u003drx,tx,tso"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    glance image-update \u003cIMAGE\u003e --property sriov-nic-caps.1\u003drx,tx"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"The list of HW offload attributes will be stored in PCI device extra_info, this"},{"line_number":113,"context_line":"will consist of a comma separated string."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_fe94308c","line":110,"updated":"2014-12-12 12:19:35.000000000","message":"Is there a use case where the user would like them specified for the all the ports, e.g, for a NFV VM, rather than individually? Is there a simple way to express that?","commit_id":"70c54e806fda0fedeb78a4c69b2ae9c3d7001617"},{"author":{"_account_id":11647,"name":"Przemyslaw Czesnowicz","email":"przemyslaw.czesnowicz@intel.com","username":"pczesno"},"change_message_id":"a8618b8ca844b72c82ede808940944924cef096a","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    glance image-update \u003cIMAGE\u003e --property sriov-nic-caps.0\u003drx,tx,tso"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    glance image-update \u003cIMAGE\u003e --property sriov-nic-caps.1\u003drx,tx"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"The list of HW offload attributes will be stored in PCI device extra_info, this"},{"line_number":113,"context_line":"will consist of a comma separated string."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_73bcc4bb","line":110,"in_reply_to":"3a961159_89e3cad7","updated":"2014-12-15 11:25:33.000000000","message":"Hi sahid,\n\nThis is different from hugepages or numa topology. \nThis feature is to allow the tenant to ask for the right device for his application. \n\nWhat we propose is just a scheduling enhancement not an mechanism that would allow the tenant to consume resources. The tenant still would have to set the right vnic_type if he want\u0027s to request SRIOV devices. \n\nWhat you propose would not allow the admin to set quotas for SRIOV devices. Because that\u0027s not how they are requested.\n\nAdmin should have control over what and how many devices are available to the tenant but at a different level than nic capabilities. Admin control will be addressed by a different blueprint and is out of scope for the bp.","commit_id":"70c54e806fda0fedeb78a4c69b2ae9c3d7001617"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"3b31e2bd3c763fae7f0df74bf0ac69a7c86cfb68","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    glance image-update \u003cIMAGE\u003e --property sriov-nic-caps.0\u003drx,tx,tso"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    glance image-update \u003cIMAGE\u003e --property sriov-nic-caps.1\u003drx,tx"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"The list of HW offload attributes will be stored in PCI device extra_info, this"},{"line_number":113,"context_line":"will consist of a comma separated string."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_89e3cad7","line":110,"in_reply_to":"3a961159_d477549e","updated":"2014-12-15 09:00:27.000000000","message":"We really have to give to the operator the ability to allow a tenant to use this feature, this is not a lot of work to add. since flavor extra-specs can only be updated by operator this is something we usually do.\n\nThe flavor extra specs will be enhanced to support a new parameter\n\n  sriov-nic-caps.[1, 2, ..., all]\u003drx|tx|tso|rx,tx|tx,tso|...\n\nIf the image do not have property and the user try to boot on this flavor; the process will use sriov ports or fails.\n\nThe image can also set some properties to update the values provided by the flavor but can only uses ports defined by the flavor extra-specs and cannot override tx,rx,tso properties.\n\nThis will add a simple quota management.\n\nPlease see how is handled flavor vs image in http://specs.openstack.org/openstack/nova-specs/specs/juno/approved/virt-driver-large-pages.html","commit_id":"70c54e806fda0fedeb78a4c69b2ae9c3d7001617"},{"author":{"_account_id":11711,"name":"James Chapman","email":"james.p.chapman@intel.com","username":"james-p-chapman"},"change_message_id":"87ecf7028e5b59dee39e0c43b000bd96e9c74bed","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    glance image-update \u003cIMAGE\u003e --property sriov-nic-caps.0\u003drx,tx,tso"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    glance image-update \u003cIMAGE\u003e --property sriov-nic-caps.1\u003drx,tx"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"The list of HW offload attributes will be stored in PCI device extra_info, this"},{"line_number":113,"context_line":"will consist of a comma separated string."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_d477549e","line":110,"in_reply_to":"3a961159_fe94308c","updated":"2014-12-12 12:42:35.000000000","message":"Yes i believe this is a realistic use case, so the user might do this:\n\nglance image-update \u003cIMAGE\u003e --property sriov-nic-caps.all\u003drx,tx,tso","commit_id":"70c54e806fda0fedeb78a4c69b2ae9c3d7001617"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d6ab2c411ae3a43afe1b726c3583eb42ff0a81fe","unresolved":false,"context_lines":[{"line_number":201,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"This feature depends on the extra functionality proposed for libvirt. See"},{"line_number":204,"context_line":"references section for more detail."},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"Testing"},{"line_number":207,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_98e76bac","line":204,"updated":"2014-12-16 08:49:12.000000000","message":"Can you refer a bug number of the RFE in libvirt? since this seems not yet implemented  we have to follow closely the state.","commit_id":"70c54e806fda0fedeb78a4c69b2ae9c3d7001617"},{"author":{"_account_id":11711,"name":"James Chapman","email":"james.p.chapman@intel.com","username":"james-p-chapman"},"change_message_id":"f28d21b779f8fe4c8fb37668103dff38f7e2f4d1","unresolved":false,"context_lines":[{"line_number":201,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"This feature depends on the extra functionality proposed for libvirt. See"},{"line_number":204,"context_line":"references section for more detail."},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"Testing"},{"line_number":207,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_94f2cf6d","line":204,"in_reply_to":"3a961159_98e76bac","updated":"2014-12-16 12:39:08.000000000","message":"https://bugzilla.redhat.com/show_bug.cgi?id\u003d1174755\n\nWe are actively working on this patch and hope to share it soon.","commit_id":"70c54e806fda0fedeb78a4c69b2ae9c3d7001617"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"37cba26c8e9f037e5c42aa834576222f7be0564e","unresolved":false,"context_lines":[{"line_number":206,"context_line":"Testing"},{"line_number":207,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"UT will be added for this feature, also some third party tests will need to"},{"line_number":210,"context_line":"be added."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_944a2c53","line":209,"updated":"2014-12-12 12:41:37.000000000","message":"I\u0027d really like to see the Testing section describe what the important test scenarios are and if they require real hardware.","commit_id":"70c54e806fda0fedeb78a4c69b2ae9c3d7001617"},{"author":{"_account_id":11647,"name":"Przemyslaw Czesnowicz","email":"przemyslaw.czesnowicz@intel.com","username":"pczesno"},"change_message_id":"26f85bfa8a5356a244fb911bf5aa67dfab9ea3e9","unresolved":false,"context_lines":[{"line_number":206,"context_line":"Testing"},{"line_number":207,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"UT will be added for this feature, also some third party tests will need to"},{"line_number":210,"context_line":"be added."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_8f420eac","line":209,"in_reply_to":"3a961159_547a84bd","updated":"2014-12-12 17:58:54.000000000","message":"Yes this feature will require third party testing on real hardware. The plan is to test this feature on the SRIOV test setup run by Intel","commit_id":"70c54e806fda0fedeb78a4c69b2ae9c3d7001617"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d6ab2c411ae3a43afe1b726c3583eb42ff0a81fe","unresolved":false,"context_lines":[{"line_number":206,"context_line":"Testing"},{"line_number":207,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"UT will be added for this feature, also some third party tests will need to"},{"line_number":210,"context_line":"be added."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_58dc2319","line":209,"in_reply_to":"3a961159_8f420eac","updated":"2014-12-16 08:49:12.000000000","message":"Ok.. my aim was just to give some control to the operator but I don\u0027t want to block you more. The scope of your spec is precise and we can probably enhance it in the future.","commit_id":"70c54e806fda0fedeb78a4c69b2ae9c3d7001617"},{"author":{"_account_id":11711,"name":"James Chapman","email":"james.p.chapman@intel.com","username":"james-p-chapman"},"change_message_id":"de24b41cd02d85b8bc408a91585c906284933e9b","unresolved":false,"context_lines":[{"line_number":206,"context_line":"Testing"},{"line_number":207,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"UT will be added for this feature, also some third party tests will need to"},{"line_number":210,"context_line":"be added."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_547a84bd","line":209,"in_reply_to":"3a961159_944a2c53","updated":"2014-12-12 13:08:46.000000000","message":"This is how we are currently testing this feature:\n\nUsing a single controller/compute physical node that has multi NIC\u0027s, say nicA and nicB.\nVia ethtool, disable rx csum on  nicA.\nVia ethtool, verify rx csum is enabled on nicB.\nThe DB should now contain 2 PCI NIC VF\u0027s, nicA will not expose rx csum and nicB will.\nThe user requests rx csum HW offload support for their custom image.\nBoot a guest with custom image, requesting an sriov port.\nThe guest is assigned nicB.\n\nWould this be sufficient, maybe with a little more detail ?","commit_id":"70c54e806fda0fedeb78a4c69b2ae9c3d7001617"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"8507a360b7fe06897cb6b2c255291eab8b371c34","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    glance image-update \u003cIMAGE\u003e --property sriov-nic-caps.0\u003drx,tx,tso"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    glance image-update \u003cIMAGE\u003e --property sriov-nic-caps.1\u003drx,tx"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"The list of HW offload attributes will be stored in PCI device extra_info, this"},{"line_number":113,"context_line":"will consist of a comma separated string."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_bc7de2e9","line":110,"updated":"2014-12-16 20:56:06.000000000","message":"Are we dropping this?\nglance image-update \u003cIMAGE\u003e --property sriov-nic-caps.all\u003drx,tx,tso\n\nAlso, the way this is handled seems to open a door to allow something as this in the image property:\n    --property port.0\u003ddirect,rx,tx,tso\n\nit\u0027s like requesting a direct sr-iov port with offload capabilities.","commit_id":"c0af03baf4dd68b89caeb90b45058ad41ff066b5"},{"author":{"_account_id":11647,"name":"Przemyslaw Czesnowicz","email":"przemyslaw.czesnowicz@intel.com","username":"pczesno"},"change_message_id":"c71db849e5d6fd5215b656ef668cd8f46226c7f9","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    glance image-update \u003cIMAGE\u003e --property sriov-nic-caps.0\u003drx,tx,tso"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    glance image-update \u003cIMAGE\u003e --property sriov-nic-caps.1\u003drx,tx"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"The list of HW offload attributes will be stored in PCI device extra_info, this"},{"line_number":113,"context_line":"will consist of a comma separated string."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_1e06d520","line":110,"in_reply_to":"3a961159_7391d951","updated":"2014-12-17 12:22:21.000000000","message":"I think if we were to use image properties to set vnic_type it should be explicit and separate from the sriov-nic-caps.\nSo something like :\n--property port.0.vnic_type\u003ddirect\n--property port.0.caps\u003dtso,rx\nWhere caps would only make sense if vnic_type is either direct or macvtap\nI think the api is the best (and actually the only it\u0027s makes sense) to set the vnic_type.","commit_id":"c0af03baf4dd68b89caeb90b45058ad41ff066b5"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"64e456ac05cdecfe80bc1963828dfab36974e9c5","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    glance image-update \u003cIMAGE\u003e --property sriov-nic-caps.0\u003drx,tx,tso"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    glance image-update \u003cIMAGE\u003e --property sriov-nic-caps.1\u003drx,tx"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"The list of HW offload attributes will be stored in PCI device extra_info, this"},{"line_number":113,"context_line":"will consist of a comma separated string."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_7391d951","line":110,"in_reply_to":"3a961159_bc7de2e9","updated":"2014-12-17 06:20:56.000000000","message":"Actually, additional attribute may not be required. I think just existence of this property means that vnic_type \u0027direct\u0027 is required.\nI think this may be very good direction to request SR_IOV vNIC. Robert, very good catch!\nCan this be considered as part of this spec implementation?","commit_id":"c0af03baf4dd68b89caeb90b45058ad41ff066b5"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"64e456ac05cdecfe80bc1963828dfab36974e9c5","unresolved":false,"context_lines":[{"line_number":191,"context_line":"* Update libvirt config to support the management of new PCI device offload"},{"line_number":192,"context_line":"  data attribute.."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"* The PCI model will be extended with a list to describe the PCI devicesi"},{"line_number":195,"context_line":"  offload."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"* The PCI passthrough filter will be modified to include the checking of the"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_b3ed01f2","line":194,"updated":"2014-12-17 06:20:56.000000000","message":"typo: devices","commit_id":"c0af03baf4dd68b89caeb90b45058ad41ff066b5"}],"specs/liberty/approved/sriov-sched-with-nic-capabilities.rst":[{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"2099e03ebd6c8cd1ff2171c9320ee1f54c4e43b9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"SRIOV scheduling with stateless offloads"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/sriov-sched-with-stateless-offloads"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"7a016987_03be56d4","line":9,"updated":"2015-05-26 21:35:40.000000000","message":"update the header","commit_id":"ef75b01c64f983604a515beaa3ac9b259885685d"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"2099e03ebd6c8cd1ff2171c9320ee1f54c4e43b9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/sriov-sched-with-stateless-offloads"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"There is a per packet overhead associated with the processing of ethernet based"},{"line_number":14,"context_line":"packets, examples of this are packet checksum generation, protocol segmentation"},{"line_number":15,"context_line":"mechanisms and vlan tagging. Without hardware support this work has to be done"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7a016987_43ed6eee","line":12,"updated":"2015-05-26 21:35:40.000000000","message":"please update the link to https://blueprints.launchpad.net/nova/+spec/sriov-sched-with-nic-capabilities","commit_id":"ef75b01c64f983604a515beaa3ac9b259885685d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e499f6cb8810973969541a1169e1878fa3fc567f","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* The scheduling/filtering mechanism will be modified to ensures a guest with"},{"line_number":45,"context_line":"  NIC offload and link speed requirements are scheduled to run on a compute"},{"line_number":46,"context_line":"  node NIC that satisfies the requests."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Problem description"},{"line_number":49,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3afb71cf_912f29a1","line":46,"updated":"2015-06-05 12:58:21.000000000","message":"So this first part of the spec is meant to be a brief summary. \n\nthe details should go in the problem description please.\n\nSorry, but if we don\u0027t correct the ones we merge, others start not following the template as well. The summary bit is to help people quickly scan read the specs to remind them which one it is, and to go inside the BP in launchpad, etc. There is a method behind the madness.","commit_id":"ef75b01c64f983604a515beaa3ac9b259885685d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e499f6cb8810973969541a1169e1878fa3fc567f","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"E.g"},{"line_number":109,"context_line":"    My image needs tx-checksum, rx-checksum and tcp segmentation offloads."},{"line_number":110,"context_line":"    glance image-update \u003cIMAGE\u003e --property sriov-nic-caps.0\u003drx,tx,tso"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    My image needs tx-checksum, rx-checksum and  a 10G capable NIC."},{"line_number":113,"context_line":"    glance image-update \u003cIMAGE\u003e --property sriov-nic-caps.1\u003drx,tx,10G"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3afb71cf_8cf152d0","line":110,"updated":"2015-06-05 12:58:21.000000000","message":"We really need to step back and standardise on these kinds of addition, I hope we can make progress on that quickly, but this might get delated because of that.","commit_id":"ef75b01c64f983604a515beaa3ac9b259885685d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e499f6cb8810973969541a1169e1878fa3fc567f","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    glance image-update \u003cIMAGE\u003e --property sriov-nic-caps.0\u003drx,tx,tso"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    My image needs tx-checksum, rx-checksum and  a 10G capable NIC."},{"line_number":113,"context_line":"    glance image-update \u003cIMAGE\u003e --property sriov-nic-caps.1\u003drx,tx,10G"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"The list of NIC capabilities will be stored in PCI device extra_info, this"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3afb71cf_cca3ca9d","line":113,"updated":"2015-06-05 12:58:21.000000000","message":"we have the .1 and .0 what does that mean? nic 0 and nic 1? if its missing do these apply to all nics?\n\nIs the simpler thing not good enough here?","commit_id":"ef75b01c64f983604a515beaa3ac9b259885685d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e499f6cb8810973969541a1169e1878fa3fc567f","unresolved":false,"context_lines":[{"line_number":120,"context_line":"network device offload requests."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"nova/pci/stats.py will be modified to manage the new PCI network device offload"},{"line_number":123,"context_line":"attributes."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3afb71cf_0c820201","line":123,"updated":"2015-06-05 12:58:21.000000000","message":"I would really like to see a very clear definition of the different options and what they mean here.","commit_id":"ef75b01c64f983604a515beaa3ac9b259885685d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e499f6cb8810973969541a1169e1878fa3fc567f","unresolved":false,"context_lines":[{"line_number":210,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"UT will be added for this feature."},{"line_number":213,"context_line":"Third party tests will be run on real multi NIC HW, examples scenarios:"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"Using multi NIC platform, disable certain offloads on specific NICs."},{"line_number":216,"context_line":"Request certain NIC offloads via image properties."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3afb71cf_4ca11aa9","line":213,"updated":"2015-06-05 12:58:21.000000000","message":"Do we have this CI voting on existing changes already.\n\nThe only reason I mention that, is we have been promised NFV testing for two cycles, but don\u0027t yet have something thats gained the trust of the core team. This is quite a hard problem.","commit_id":"ef75b01c64f983604a515beaa3ac9b259885685d"}]}