)]}'
{"specs/kilo/approved/refactor-allocate-for-instance.rst":[{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"198346382271f829451066d9a1d33d262e12e5a6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/nova-neutron-refactor"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"`allocate_for_instance` in the Network API adapter for neutron has grown"},{"line_number":14,"context_line":"prohibitively complex and is a gallery of sins. On the critical path, the"},{"line_number":15,"context_line":"successful refactoring of this method represents a significant step forward"},{"line_number":16,"context_line":"towards reducing technical debt."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_57de06de","line":14,"updated":"2014-12-12 13:50:51.000000000","message":"This actually made me laugh out loud. +100","commit_id":"a74fb3b717e8c62b2a268e12d8f6c7dda465d597"},{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"198346382271f829451066d9a1d33d262e12e5a6","unresolved":false,"context_lines":[{"line_number":41,"context_line":"All of these variants are handled by this single method with the exception of"},{"line_number":42,"context_line":"a few dedicated helper methods that simply reduce the line count of"},{"line_number":43,"context_line":"`allocate_for_instance` itself. The serial nature in which these different"},{"line_number":44,"context_line":"scenarios prevent invoking unrelated operations asynchronously and"},{"line_number":45,"context_line":"concurrently and batching multiple queries in a single call."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_9a1c156c","line":44,"updated":"2014-12-12 13:50:51.000000000","message":"I think you accidentally a word here.","commit_id":"a74fb3b717e8c62b2a268e12d8f6c7dda465d597"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"1629cf5c1bd04a9a5290ef93efaae7787e35a756","unresolved":false,"context_lines":[{"line_number":41,"context_line":"All of these variants are handled by this single method with the exception of"},{"line_number":42,"context_line":"a few dedicated helper methods that simply reduce the line count of"},{"line_number":43,"context_line":"`allocate_for_instance` itself. The serial nature in which these different"},{"line_number":44,"context_line":"scenarios prevent invoking unrelated operations asynchronously and"},{"line_number":45,"context_line":"concurrently and batching multiple queries in a single call."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_95742d9d","line":44,"in_reply_to":"3a961159_9a1c156c","updated":"2014-12-18 18:16:35.000000000","message":"Done","commit_id":"a74fb3b717e8c62b2a268e12d8f6c7dda465d597"},{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"198346382271f829451066d9a1d33d262e12e5a6","unresolved":false,"context_lines":[{"line_number":55,"context_line":"Project Priority"},{"line_number":56,"context_line":"-----------------"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"This refactoring addresses an issue of significant techncial dept and"},{"line_number":59,"context_line":"facilitates Nova to Neutron migration."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_5a3d4dc3","line":58,"updated":"2014-12-12 13:50:51.000000000","message":"Not so sure it\u0027s a typo the 2nd time: \"debt\".","commit_id":"a74fb3b717e8c62b2a268e12d8f6c7dda465d597"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"1629cf5c1bd04a9a5290ef93efaae7787e35a756","unresolved":false,"context_lines":[{"line_number":55,"context_line":"Project Priority"},{"line_number":56,"context_line":"-----------------"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"This refactoring addresses an issue of significant techncial dept and"},{"line_number":59,"context_line":"facilitates Nova to Neutron migration."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_f571f1a8","line":58,"in_reply_to":"3a961159_5a3d4dc3","updated":"2014-12-18 18:16:35.000000000","message":"Done","commit_id":"a74fb3b717e8c62b2a268e12d8f6c7dda465d597"},{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"198346382271f829451066d9a1d33d262e12e5a6","unresolved":false,"context_lines":[{"line_number":56,"context_line":"-----------------"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"This refactoring addresses an issue of significant techncial dept and"},{"line_number":59,"context_line":"facilitates Nova to Neutron migration."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_1a574503","line":59,"updated":"2014-12-12 13:50:51.000000000","message":"Same comment as on the other spec: does this mean the deprecation of nova-network or something else?","commit_id":"a74fb3b717e8c62b2a268e12d8f6c7dda465d597"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"1629cf5c1bd04a9a5290ef93efaae7787e35a756","unresolved":false,"context_lines":[{"line_number":56,"context_line":"-----------------"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"This refactoring addresses an issue of significant techncial dept and"},{"line_number":59,"context_line":"facilitates Nova to Neutron migration."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_b577699e","line":59,"in_reply_to":"3a961159_1a574503","updated":"2014-12-18 18:16:35.000000000","message":"Done","commit_id":"a74fb3b717e8c62b2a268e12d8f6c7dda465d597"},{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"198346382271f829451066d9a1d33d262e12e5a6","unresolved":false,"context_lines":[{"line_number":134,"context_line":"* Dan Smith - Nova: objects, data model and migration."},{"line_number":135,"context_line":"* Matt Riedemann"},{"line_number":136,"context_line":"* Gary Kotton"},{"line_number":137,"context_line":"* Matthew Gillard"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Primary assignee:"},{"line_number":140,"context_line":"* Brent Eagles  beagles@redhat.com"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_1a6e65c9","line":137,"updated":"2014-12-12 13:50:51.000000000","message":"Gilliard  -  with an extra \"i\" :)","commit_id":"a74fb3b717e8c62b2a268e12d8f6c7dda465d597"},{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"198346382271f829451066d9a1d33d262e12e5a6","unresolved":false,"context_lines":[{"line_number":164,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"As this is part of the Nova-Neutron API refactoring, a CI job will in the"},{"line_number":167,"context_line":"experimental work queue will run the new Tempest tests"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"Documentation Impact"},{"line_number":170,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_9a9ed561","line":167,"updated":"2014-12-12 13:50:51.000000000","message":"See my query about experimental CI in the other specs (tl-dr do we _really_ need it?).","commit_id":"a74fb3b717e8c62b2a268e12d8f6c7dda465d597"},{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"b95455d668f0d1de8055f8b92cd2c2718bcccc62","unresolved":false,"context_lines":[{"line_number":164,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"As this is part of the Nova-Neutron API refactoring, a CI job will in the"},{"line_number":167,"context_line":"experimental work queue will run the new Tempest tests"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"Documentation Impact"},{"line_number":170,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_0396003f","line":167,"in_reply_to":"3a961159_9a9ed561","updated":"2014-12-12 15:15:34.000000000","message":"This is \u0027the other spec\u0027 which I\u0027m referring to: https://review.openstack.org/#/c/131413","commit_id":"a74fb3b717e8c62b2a268e12d8f6c7dda465d597"},{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"4c9822db68793ee4bd1dd2fc7b02b924a4bc124b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"`allocate_for_instance` in the Network API adapter for neutron has grown"},{"line_number":14,"context_line":"prohibitively complex and is a gallery of sins. On the critical path, the"},{"line_number":15,"context_line":"successful refactoring of this method represents a significant step forward"},{"line_number":16,"context_line":"towards reducing technical debt."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3ab451fb_a9e7683f","line":16,"updated":"2015-04-17 13:11:32.000000000","message":"I\u0027m not sure what this means.  \"critical path\" suggests performance to me, while \"technical debt\" suggests maintainability...  What do you really have in mind?","commit_id":"c814b0221976826f186a6da53fdc9ea0ada7bd1c"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"2d562f23197126c129b5a256fbdfc1c55d95c41b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"`allocate_for_instance` in the Network API adapter for neutron has grown"},{"line_number":14,"context_line":"prohibitively complex and is a gallery of sins. On the critical path, the"},{"line_number":15,"context_line":"successful refactoring of this method represents a significant step forward"},{"line_number":16,"context_line":"towards reducing technical debt."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aca2d91_39a250af","line":16,"in_reply_to":"3ab451fb_a9e7683f","updated":"2015-05-07 19:24:03.000000000","message":"I was referring specifically to code that is critical to the normal operation of the system, but I do get the point that this is confusing. I\u0027ll fix.","commit_id":"c814b0221976826f186a6da53fdc9ea0ada7bd1c"},{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"4c9822db68793ee4bd1dd2fc7b02b924a4bc124b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"API call vary depending on the parameters."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"* If no network is requested, neutron is queried for networks that the tenant"},{"line_number":29,"context_line":"  has access to. An exception is thrown if there is more that one. Port will"},{"line_number":30,"context_line":"  be created and assigned to the instance if successful."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"* If one or more networks are requested by network ID, neutron is queried to"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3ab451fb_49d58441","line":29,"updated":"2015-04-17 13:11:32.000000000","message":"\"than\"","commit_id":"c814b0221976826f186a6da53fdc9ea0ada7bd1c"},{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"4c9822db68793ee4bd1dd2fc7b02b924a4bc124b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  verifying access to the related network and obtaining the network ID."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* Variants combining the second and third scenarios can also occur."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"All of these variants are handled by this single method with the exception of"},{"line_number":42,"context_line":"a few dedicated helper methods that simply reduce the line count of"},{"line_number":43,"context_line":"`allocate_for_instance` itself. The serial nature in which these different"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3ab451fb_290fd8e2","line":40,"updated":"2015-04-17 13:11:32.000000000","message":"So do any of these cases _allocate_ anything?  It doesn\u0027t sound like it. :-)","commit_id":"c814b0221976826f186a6da53fdc9ea0ada7bd1c"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"2d562f23197126c129b5a256fbdfc1c55d95c41b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  verifying access to the related network and obtaining the network ID."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* Variants combining the second and third scenarios can also occur."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"All of these variants are handled by this single method with the exception of"},{"line_number":42,"context_line":"a few dedicated helper methods that simply reduce the line count of"},{"line_number":43,"context_line":"`allocate_for_instance` itself. The serial nature in which these different"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aca2d91_d99c7c5f","line":40,"in_reply_to":"3ab451fb_290fd8e2","updated":"2015-05-07 19:24:03.000000000","message":"A port might be created. I get your point, but even pre-created resources are then \"allocated\" to an instance. Semantics. It is about refactoring the implementation of an existing API in any case :).","commit_id":"c814b0221976826f186a6da53fdc9ea0ada7bd1c"},{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"60f1d3086e5ac1ab843f34556742d2ba6ebb745c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"a few dedicated helper methods that simply reduce the line count of"},{"line_number":43,"context_line":"`allocate_for_instance` itself. The serial nature in which these different"},{"line_number":44,"context_line":"scenarios prevent invoking unrelated operations asynchronously and"},{"line_number":45,"context_line":"concurrently as well as batching multiple queries in a single call."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_3c87e1b6","line":45,"updated":"2014-12-18 20:44:04.000000000","message":"My brain stumbles every time I read this sentence. I think its meaning is clear enough though, so it\u0027s only a nit.","commit_id":"c814b0221976826f186a6da53fdc9ea0ada7bd1c"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"2d562f23197126c129b5a256fbdfc1c55d95c41b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"a few dedicated helper methods that simply reduce the line count of"},{"line_number":43,"context_line":"`allocate_for_instance` itself. The serial nature in which these different"},{"line_number":44,"context_line":"scenarios prevent invoking unrelated operations asynchronously and"},{"line_number":45,"context_line":"concurrently as well as batching multiple queries in a single call."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aca2d91_99c60448","line":45,"in_reply_to":"3a961159_3c87e1b6","updated":"2015-05-07 19:24:03.000000000","message":"Gah.. missing some key text there I think. Might make some more sense now.","commit_id":"c814b0221976826f186a6da53fdc9ea0ada7bd1c"},{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"4c9822db68793ee4bd1dd2fc7b02b924a4bc124b","unresolved":false,"context_lines":[{"line_number":55,"context_line":"Project Priority"},{"line_number":56,"context_line":"-----------------"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"This refactoring addresses an issue of significant techncial debt and"},{"line_number":59,"context_line":"is a step towards deprecating nova-network."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3ab451fb_092bfc31","line":58,"updated":"2015-04-17 13:11:32.000000000","message":"\"technical\"","commit_id":"c814b0221976826f186a6da53fdc9ea0ada7bd1c"}],"specs/liberty/approved/refactor-allocate-for-instance.rst":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7cec3cf44190505e9c96b8b49e6349bf4e26b10a","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Refactor allocate_for_instance"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/nova-neutron-refactor"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"`allocate_for_instance` in the Network API adapter for neutron has grown"},{"line_number":14,"context_line":"prohibitively complex and is a gallery of sins. This fundamental API that is"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a0c5dc1_ee0b257c","line":11,"updated":"2015-05-12 13:28:01.000000000","message":"Really this needs a separate blueprint from the already approved blueprint.\n\nThere needs to be one spec per blueprint.\n\nIt might be worth renaming that above blueprint.","commit_id":"349063c5868415fa7304c3bf3d6c824a64d3be07"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"4ac59dc3ac49421ec0317be92bf0b75d24f6d7e9","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Refactor allocate_for_instance"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/nova-neutron-refactor"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"`allocate_for_instance` in the Network API adapter for neutron has grown"},{"line_number":14,"context_line":"prohibitively complex and is a gallery of sins. This fundamental API that is"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a0c5dc1_5b4d4c71","line":11,"updated":"2015-05-12 14:44:31.000000000","message":"This should be named the same as the filename, so refactor-allocate-for-instance.  Or rename both to refactor-neutron-allocate-for-instance.","commit_id":"349063c5868415fa7304c3bf3d6c824a64d3be07"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"aedea6357b4addee8c8df011ef6f7a534c7ea805","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Refactor allocate_for_instance"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/nova-neutron-refactor"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"`allocate_for_instance` in the Network API adapter for neutron has grown"},{"line_number":14,"context_line":"prohibitively complex and is a gallery of sins. This fundamental API that is"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1af86dd1_92a982e2","line":11,"in_reply_to":"9a0c5dc1_ee0b257c","updated":"2015-06-11 23:53:37.000000000","message":"Okay. I didn\u0027t understand that it was a 1:1 relationship. I must have misunderstood some previous advice/direction.This was meant to defined a significant yet related step to the other refactoring activites, ie. recasting allocate_for_instance in terms of a higher level client.","commit_id":"349063c5868415fa7304c3bf3d6c824a64d3be07"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"4ac59dc3ac49421ec0317be92bf0b75d24f6d7e9","unresolved":false,"context_lines":[{"line_number":163,"context_line":"Testing"},{"line_number":164,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"The changes will be exercised through the existing CI."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Documentation Impact"},{"line_number":169,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a0c5dc1_3b097896","line":166,"updated":"2015-05-12 14:44:31.000000000","message":"Is there enough coverage on this to ensure that all changes are tested?","commit_id":"349063c5868415fa7304c3bf3d6c824a64d3be07"}]}