)]}'
{"specs/kilo/oslo_db-enginefacade.rst":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a7ae5f2bdaab23442e50690bfd3c0e2472267de4","unresolved":false,"context_lines":[{"line_number":89,"context_line":"will involve updating call sites and tests. Where the caller no longer uses the"},{"line_number":90,"context_line":"use_slave parameter anywhere, the removal will be propagated as far as possible."},{"line_number":91,"context_line":"The exception will be external interfaces. All uses of use_slave will be"},{"line_number":92,"context_line":"removed. External interfaces will continue to accept it, but will not use it."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Alternatives"},{"line_number":95,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa81d914_4fba5a0b","line":92,"updated":"2015-01-29 00:22:56.000000000","message":"I guess thats because it goes in the context now? I think we avoided doing that, on purpose, when we introduced the use_slave.","commit_id":"dfdceed90b8754a89bb362559283a0099e872a5c"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"9560464f08cdb95516a817616a75ad691ac77a86","unresolved":false,"context_lines":[{"line_number":89,"context_line":"will involve updating call sites and tests. Where the caller no longer uses the"},{"line_number":90,"context_line":"use_slave parameter anywhere, the removal will be propagated as far as possible."},{"line_number":91,"context_line":"The exception will be external interfaces. All uses of use_slave will be"},{"line_number":92,"context_line":"removed. External interfaces will continue to accept it, but will not use it."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Alternatives"},{"line_number":95,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba7be1f8_53f498ce","line":92,"in_reply_to":"fa81d914_1aa79e0d","updated":"2015-03-02 16:48:36.000000000","message":"I think Johns comment about use_slave was that we avoided putting that into the context in favor of explicitly passing the argument.  But it doesn\u0027t seem that you\u0027re moving use_slave from method signatures into the context.  You\u0027re stating that use_slave is no longer necessary because it can be inferred by a method, or chain of methods, being a within a reader context.  It seems to me that there\u0027s no issue here.","commit_id":"dfdceed90b8754a89bb362559283a0099e872a5c"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"c30c0ec45d2fea425dd7c9cca8199f110fa1461a","unresolved":false,"context_lines":[{"line_number":89,"context_line":"will involve updating call sites and tests. Where the caller no longer uses the"},{"line_number":90,"context_line":"use_slave parameter anywhere, the removal will be propagated as far as possible."},{"line_number":91,"context_line":"The exception will be external interfaces. All uses of use_slave will be"},{"line_number":92,"context_line":"removed. External interfaces will continue to accept it, but will not use it."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Alternatives"},{"line_number":95,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa81d914_ddf3569d","line":92,"in_reply_to":"fa81d914_4fba5a0b","updated":"2015-01-29 10:09:20.000000000","message":"Code blocks are annotated as either reader or writer. Writers are allowed to call readers, but not vice versa. This is enforced in code by raising an exception, so by virtue of being able to execute the function we know that anything marked as reader will only ever read. If our outer transaction is a reader, then the entire transaction is read-only and we can use a slave connection.\n\nIf there\u0027s a reason why we shouldn\u0027t do that, we could do with knowing about it urgently! I know this spec isn\u0027t going to make it into K, but this could well impact the oslo.db spec too.","commit_id":"dfdceed90b8754a89bb362559283a0099e872a5c"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"f0bc6d66c9501aa0def39cb9bd0d52ab6d501afd","unresolved":false,"context_lines":[{"line_number":89,"context_line":"will involve updating call sites and tests. Where the caller no longer uses the"},{"line_number":90,"context_line":"use_slave parameter anywhere, the removal will be propagated as far as possible."},{"line_number":91,"context_line":"The exception will be external interfaces. All uses of use_slave will be"},{"line_number":92,"context_line":"removed. External interfaces will continue to accept it, but will not use it."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Alternatives"},{"line_number":95,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa81d914_1aa79e0d","line":92,"in_reply_to":"fa81d914_ddf3569d","updated":"2015-01-29 16:33:08.000000000","message":"the only use case I can see here is if someone wanted to do a @reader on the write-master, e.g. the opposite of use_slave.  You\u0027d never want to do a writer on the slave connection.  Right?  if we really need reader() on the write master, well, first off why not just use writer() and then sure, if there\u0027s really a super duper reason it should be @reader but still use the write master, we can add some new ctx for that.","commit_id":"dfdceed90b8754a89bb362559283a0099e872a5c"}],"specs/liberty/approved/oslo_db-enginefacade.rst":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"cb4b3379869fa0528e5740507fa9a0d28da2d2f1","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"The use_slave parameter will be removed from all upgraded database apis, which"},{"line_number":90,"context_line":"will involve updating call sites and tests. Where the caller no longer uses the"},{"line_number":91,"context_line":"use_slave parameter anywhere, the removal will be propagated as far as possible."},{"line_number":92,"context_line":"The exception will be external interfaces. All uses of use_slave will be"},{"line_number":93,"context_line":"removed. External interfaces will continue to accept it, but will not use it."},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1af86dd1_5aa658c2","line":91,"range":{"start_line":91,"start_character":0,"end_line":91,"end_character":80},"updated":"2015-06-12 20:56:49.000000000","message":"The test failure is this line being too long.","commit_id":"1029a1330d643393c14313393ae953ebbb90cd59"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"b4183c0e99b731fb85422e227cf488571c89a14f","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"The use_slave parameter will be removed from all upgraded database apis, which"},{"line_number":90,"context_line":"will involve updating call sites and tests. Where the caller no longer uses the"},{"line_number":91,"context_line":"use_slave parameter anywhere, the removal will be propagated as far as possible."},{"line_number":92,"context_line":"The exception will be external interfaces. All uses of use_slave will be"},{"line_number":93,"context_line":"removed. External interfaces will continue to accept it, but will not use it."},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_7644a373","line":91,"range":{"start_line":91,"start_character":0,"end_line":91,"end_character":80},"in_reply_to":"1af86dd1_5aa658c2","updated":"2015-06-15 15:56:50.000000000","message":"Done","commit_id":"1029a1330d643393c14313393ae953ebbb90cd59"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"c16ef0520f0637a9e8dbd79159c1c617d6ea99a6","unresolved":false,"context_lines":[{"line_number":138,"context_line":"Performance Impact"},{"line_number":139,"context_line":"------------------"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"By reducing connection load on the database, the change is expected to provide a"},{"line_number":142,"context_line":"small performance improvement. However, the primary purpose is correctness."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Other deployer impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_d6bf7df9","line":141,"updated":"2015-06-16 13:37:08.000000000","message":"Apparently this one as well :(\n\nI guess the test bails on the first failure and doesn\u0027t show them all.","commit_id":"37e62fac7502ca2f6474e5957042644d27e77a51"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"5643be383481437c2759ca042c6cf4fb245c6e3e","unresolved":false,"context_lines":[{"line_number":138,"context_line":"Performance Impact"},{"line_number":139,"context_line":"------------------"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"By reducing connection load on the database, the change is expected to provide a"},{"line_number":142,"context_line":"small performance improvement. However, the primary purpose is correctness."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Other deployer impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_044128a9","line":141,"in_reply_to":"fa32b979_d6bf7df9","updated":"2015-06-16 15:26:17.000000000","message":"Done, and found a couple more. Hopefully that\u0027s the lot!","commit_id":"37e62fac7502ca2f6474e5957042644d27e77a51"}]}