)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"0dff4bbcb399f08e99f9ab8f3ca4e5697624bdaf","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-04-16 09:48:16 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"flavor access create should check public/private"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add check-flavor-type-before-add-tenant.rst"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I7fdc9850da2f75552fde2cebb9811b222b4b0a9b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3acd31a7_49cbf572","line":8,"updated":"2015-05-03 11:58:08.000000000","message":"Could you add APIImpact flag at here?","commit_id":"7b57b8a7859719ac54a3039df3c82c4212f444ab"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"b553cd5a4ef484566d1e04a6ba99acb8b5c721c5","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-04-16 09:48:16 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"flavor access create should check public/private"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add check-flavor-type-before-add-tenant.rst"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I7fdc9850da2f75552fde2cebb9811b222b4b0a9b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3acd31a7_7999ca1e","line":8,"in_reply_to":"3acd31a7_49cbf572","updated":"2015-05-04 16:10:00.000000000","message":"ok","commit_id":"7b57b8a7859719ac54a3039df3c82c4212f444ab"}],"specs/liberty/approved/check-flavor-type-before-add-tenant.rst":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"84e23f98e95cf94c6373a76edd3af2f1dd3c514c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Because flavor can be public and private, we need to check public and private"},{"line_number":18,"context_line":"first before create flavor access, detailed in [1] [2]."},{"line_number":19,"context_line":"This is backward incompatible bug, every API change need spec."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7ad32947_d3af0b7c","line":18,"updated":"2015-04-27 16:54:42.000000000","message":"Specs need to standalone. please describe why inside the spec. Feel free to keep the reference, but this spec should make sense without the reference.","commit_id":"6765045f303f13bcf4289c04bb6c07afdc038314"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"0164f0929303b1102ed065b67b5cc792198b8591","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Because flavor can be public and private, we need to check public and private"},{"line_number":18,"context_line":"first before create flavor access, detailed in [1] [2]."},{"line_number":19,"context_line":"This is backward incompatible bug, every API change need spec."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3acd31a7_d3ada789","line":18,"in_reply_to":"7ad32947_d3af0b7c","updated":"2015-04-30 13:08:50.000000000","message":"ok, copied part of the bug info into spec","commit_id":"6765045f303f13bcf4289c04bb6c07afdc038314"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"84e23f98e95cf94c6373a76edd3af2f1dd3c514c","unresolved":false,"context_lines":[{"line_number":48,"context_line":"---------------"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"os-flavor-access/addTenantAccess will be affected, but input/output will not be"},{"line_number":51,"context_line":"affected, only additional check will be added."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Security impact"},{"line_number":54,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7ad32947_53c41b3f","line":51,"updated":"2015-04-27 16:54:42.000000000","message":"how will it be affected? please state the change here.","commit_id":"6765045f303f13bcf4289c04bb6c07afdc038314"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"0164f0929303b1102ed065b67b5cc792198b8591","unresolved":false,"context_lines":[{"line_number":48,"context_line":"---------------"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"os-flavor-access/addTenantAccess will be affected, but input/output will not be"},{"line_number":51,"context_line":"affected, only additional check will be added."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Security impact"},{"line_number":54,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3acd31a7_f3a0a392","line":51,"in_reply_to":"7ad32947_53c41b3f","updated":"2015-04-30 13:08:50.000000000","message":"done, added some description","commit_id":"6765045f303f13bcf4289c04bb6c07afdc038314"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f713011c35d01e1e3ae2524d0f8ec694f7f95cfd","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Because flavor can be public and private, we need to check public and private"},{"line_number":18,"context_line":"first before create flavor access."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"jichen@cloudcontroller:~$ nova flavor-access-add 1 2"},{"line_number":21,"context_line":"+-----------+-----------+"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9af37de9_c33effb7","line":18,"updated":"2015-05-11 13:47:23.000000000","message":"Sorry, I find this really confusing. Can we say something like:\n\nWe can\u0027t add tenant access to a flavor that has public access. Trying to do such a thing results in a confusing error message. By checking up front, we can give users a better error message.\n\nIs that what you mean here?","commit_id":"45030eb5a3b66dbc6cb2542ab86ad935023a58a6"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"e2544d1b1f414cf7d02e12048662625c87e66aaa","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Because flavor can be public and private, we need to check public and private"},{"line_number":18,"context_line":"first before create flavor access."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"jichen@cloudcontroller:~$ nova flavor-access-add 1 2"},{"line_number":21,"context_line":"+-----------+-----------+"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a0c5dc1_297ee4ae","line":18,"in_reply_to":"9af37de9_c33effb7","updated":"2015-05-12 09:23:16.000000000","message":"yes, almost, I will adjust the words","commit_id":"45030eb5a3b66dbc6cb2542ab86ad935023a58a6"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f713011c35d01e1e3ae2524d0f8ec694f7f95cfd","unresolved":false,"context_lines":[{"line_number":27,"context_line":"jichen@cloudcontroller:~$ nova flavor-access-list --flavor 1"},{"line_number":28,"context_line":"ERROR (CommandError): Failed to get access list for public flavor type."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"we should check public/private before access add"},{"line_number":31,"context_line":"But this is backward incompatible bug, every API change need spec,"},{"line_number":32,"context_line":"so a microversion is needed to handle this problem."},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9af37de9_6374f39b","line":30,"updated":"2015-05-11 13:47:23.000000000","message":"sorry I find this sentence confusing.","commit_id":"45030eb5a3b66dbc6cb2542ab86ad935023a58a6"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"e2544d1b1f414cf7d02e12048662625c87e66aaa","unresolved":false,"context_lines":[{"line_number":27,"context_line":"jichen@cloudcontroller:~$ nova flavor-access-list --flavor 1"},{"line_number":28,"context_line":"ERROR (CommandError): Failed to get access list for public flavor type."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"we should check public/private before access add"},{"line_number":31,"context_line":"But this is backward incompatible bug, every API change need spec,"},{"line_number":32,"context_line":"so a microversion is needed to handle this problem."},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a0c5dc1_094a0084","line":30,"in_reply_to":"9af37de9_6374f39b","updated":"2015-05-12 09:23:16.000000000","message":"same to above, let me adjust the words, thanks","commit_id":"45030eb5a3b66dbc6cb2542ab86ad935023a58a6"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f713011c35d01e1e3ae2524d0f8ec694f7f95cfd","unresolved":false,"context_lines":[{"line_number":84,"context_line":"  def _check_flavor_type(self, req, flavor):"},{"line_number":85,"context_line":"      if req.version \u003e target_version:"},{"line_number":86,"context_line":"           if flavor.type is public:"},{"line_number":87,"context_line":"               raise Exception"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Security impact"},{"line_number":90,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9af37de9_a3341bde","line":87,"updated":"2015-05-11 13:47:23.000000000","message":"please can you specify the HTTP return code?","commit_id":"45030eb5a3b66dbc6cb2542ab86ad935023a58a6"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"e2544d1b1f414cf7d02e12048662625c87e66aaa","unresolved":false,"context_lines":[{"line_number":84,"context_line":"  def _check_flavor_type(self, req, flavor):"},{"line_number":85,"context_line":"      if req.version \u003e target_version:"},{"line_number":86,"context_line":"           if flavor.type is public:"},{"line_number":87,"context_line":"               raise Exception"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Security impact"},{"line_number":90,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a0c5dc1_441a1f70","line":87,"in_reply_to":"9af37de9_a3341bde","updated":"2015-05-12 09:23:16.000000000","message":"ok, right \nchange to HTTPBadRequest,","commit_id":"45030eb5a3b66dbc6cb2542ab86ad935023a58a6"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e7e31c469cb7fb65f904a99c7273f378d718b1b2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/check-flavor-type-before-add-tenant"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Problem description"},{"line_number":15,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3afb71cf_d1347adf","line":12,"updated":"2015-06-05 15:05:47.000000000","message":"we should have a summary here, but I will overlook that.","commit_id":"968a5e2ed0d45964b4ad51ad1c5387006eb90905"}]}
