)]}'
{"specs/liberty/approved/request-spec-object.rst":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"33d51b696292e13e020ee49be3e360362e683d83","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    fields \u003d {"},{"line_number":165,"context_line":"        \u0027image\u0027: fields.DictOfStringsField(nullable\u003dFalse),"},{"line_number":166,"context_line":"        # instance_properties could eventually be deconstructed into component"},{"line_number":167,"context_line":"        # parts"},{"line_number":168,"context_line":"        \u0027instance_properties\u0027: fields.DictOfStringsField(nullable\u003dFalse),"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_aee78811","line":165,"updated":"2015-04-22 23:06:56.000000000","message":"BTW, here, we will probably have an issue because of some metadata but I will have to look at that","commit_id":"0b4b9d070b7bae8b19bb7db9dcd568e1a346baca"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"98ca3e2237bce4acc034678a911ca031cf9e403c","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    fields \u003d {"},{"line_number":165,"context_line":"        \u0027image\u0027: fields.DictOfStringsField(nullable\u003dFalse),"},{"line_number":166,"context_line":"        # instance_properties could eventually be deconstructed into component"},{"line_number":167,"context_line":"        # parts"},{"line_number":168,"context_line":"        \u0027instance_properties\u0027: fields.DictOfStringsField(nullable\u003dFalse),"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_2e1258b5","line":165,"in_reply_to":"bab921fb_aee78811","updated":"2015-04-22 23:14:54.000000000","message":"Now I remember the story. So I had to work with an Image object https://review.openstack.org/#/c/146913/ but sahid left me a -1 because he preferred the approach in https://review.openstack.org/#/c/76234\n\nWe probably need to clean up all of that and discuss how we can fix the Image problem because that sucks and that\u0027s the main reason why this bp has been deferred to Liberty :/","commit_id":"0b4b9d070b7bae8b19bb7db9dcd568e1a346baca"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"33d51b696292e13e020ee49be3e360362e683d83","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        \u0027image\u0027: fields.DictOfStringsField(nullable\u003dFalse),"},{"line_number":166,"context_line":"        # instance_properties could eventually be deconstructed into component"},{"line_number":167,"context_line":"        # parts"},{"line_number":168,"context_line":"        \u0027instance_properties\u0027: fields.DictOfStringsField(nullable\u003dFalse),"},{"line_number":169,"context_line":"        \u0027instance_type\u0027: fields.ObjectField(\u0027Flavor\u0027, nullable\u003dFalse),"},{"line_number":170,"context_line":"        \u0027num_instances\u0027: fields.IntegerField(default\u003d1),"},{"line_number":171,"context_line":"        \u0027force_hosts\u0027: fields.StringField(nullable\u003dTrue),"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_6e1a9019","line":168,"updated":"2015-04-22 23:06:56.000000000","message":"as I said, I would prefer to see each needed Instance field to be a new field for the RequestSpec object.\neg.\n\n  \u0027project_id\u0027: fields.UUIDField(),\n  \u0027availability_zone\u0027: fields.StringField(),\n\n\nThe main method to use the instance_props is HostState.consume_from_instance() also","commit_id":"0b4b9d070b7bae8b19bb7db9dcd568e1a346baca"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"7ab0fe9300844005672be7b779316606a5dc69c9","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    fields \u003d {"},{"line_number":165,"context_line":"        \u0027image\u0027: fields.DictOfStringsField(nullable\u003dFalse),"},{"line_number":166,"context_line":"        # instance_properties could eventually be deconstructed into component"},{"line_number":167,"context_line":"        # parts"},{"line_number":168,"context_line":"        \u0027instance_properties\u0027: fields.ObjectField(\u0027Instance\u0027),"},{"line_number":169,"context_line":"        \u0027instance_type\u0027: fields.ObjectField(\u0027Flavor\u0027, nullable\u003dFalse),"},{"line_number":170,"context_line":"        \u0027num_instances\u0027: fields.IntegerField(default\u003d1),"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bab921fb_21947b89","side":"PARENT","line":167,"updated":"2015-04-23 20:22:22.000000000","message":":)","commit_id":"92a70d900a579808dfd864ef3a770208497be398"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8e898f8d60a326894fa0aaeb759fa38b1f2f7bcd","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        \u0027ephemeral_gb\u0027: fields.IntegerField(nullable\u003dFalse),"},{"line_number":168,"context_line":"        \u0027memory_mb: fields.IntegerField(nullable\u003dFalse),"},{"line_number":169,"context_line":"        \u0027vcpus\u0027: fields.IntegerField(nullable\u003dFalse),"},{"line_number":170,"context_line":"        \u0027numa_topology\u0027: fields.ObjectField(\u0027InstanceNumaTopology\u0027),"},{"line_number":171,"context_line":"        \u0027project_id\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":172,"context_line":"        \u0027os_type\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":173,"context_line":"        \u0027availability_zone\u0027: fields.StringField(nullable\u003dTrue),"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bab921fb_bc0189b1","line":170,"updated":"2015-04-24 23:01:26.000000000","message":"Should we be explicit about this field\u0027s nullability as well?","commit_id":"643a9a886cd84669c8297c0de61431d55bb2cb21"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"ebfabd05a1e3f6f4ef16722389a3f3063d82e6e3","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        \u0027ephemeral_gb\u0027: fields.IntegerField(nullable\u003dFalse),"},{"line_number":168,"context_line":"        \u0027memory_mb: fields.IntegerField(nullable\u003dFalse),"},{"line_number":169,"context_line":"        \u0027vcpus\u0027: fields.IntegerField(nullable\u003dFalse),"},{"line_number":170,"context_line":"        \u0027numa_topology\u0027: fields.ObjectField(\u0027InstanceNumaTopology\u0027),"},{"line_number":171,"context_line":"        \u0027project_id\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":172,"context_line":"        \u0027os_type\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":173,"context_line":"        \u0027availability_zone\u0027: fields.StringField(nullable\u003dTrue),"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7ad32947_132b3884","line":170,"in_reply_to":"bab921fb_bc0189b1","updated":"2015-04-27 22:20:21.000000000","message":"Yes.  Good catch.","commit_id":"643a9a886cd84669c8297c0de61431d55bb2cb21"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"64f01972c7dba5d42cbe97ca0fb2d335aeedfc2d","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        \u0027numa_topology\u0027: fields.ObjectField(\u0027InstanceNumaTopology\u0027),"},{"line_number":171,"context_line":"        \u0027project_id\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":172,"context_line":"        \u0027os_type\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":173,"context_line":"        \u0027availability_zone\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":174,"context_line":"        \u0027instance_type\u0027: fields.ObjectField(\u0027Flavor\u0027, nullable\u003dFalse),"},{"line_number":175,"context_line":"        \u0027num_instances\u0027: fields.IntegerField(default\u003d1),"},{"line_number":176,"context_line":"        \u0027force_hosts\u0027: fields.StringField(nullable\u003dTrue),"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bab921fb_19dae078","line":173,"updated":"2015-04-24 13:26:34.000000000","message":"First glance looks good, I just need further investigation to check if anything was missed","commit_id":"643a9a886cd84669c8297c0de61431d55bb2cb21"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"750a052eccb7f330172c7b8f7f69b1a35999282e","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                                            nullable\u003dTrue),"},{"line_number":172,"context_line":"        \u0027project_id\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":173,"context_line":"        \u0027os_type\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":174,"context_line":"        \u0027availability_zone\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":175,"context_line":"        \u0027instance_type\u0027: fields.ObjectField(\u0027Flavor\u0027, nullable\u003dFalse),"},{"line_number":176,"context_line":"        \u0027num_instances\u0027: fields.IntegerField(default\u003d1),"},{"line_number":177,"context_line":"        \u0027force_hosts\u0027: fields.StringField(nullable\u003dTrue),"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7ad32947_a3ff8400","line":174,"updated":"2015-04-28 09:54:47.000000000","message":"vm_state and task_state are missing IIRC\nhttps://github.com/openstack/nova/blob/0913e799e9ce3138235f5ea6f80159f468ad2aaa/nova/scheduler/host_manager.py#L289-L290","commit_id":"210387e805c1d018706abfc750ffa02b232c3ebf"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"986d4a61d4c78e2a0ab3805919e62a058c0e719b","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                                            nullable\u003dTrue),"},{"line_number":172,"context_line":"        \u0027project_id\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":173,"context_line":"        \u0027os_type\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":174,"context_line":"        \u0027availability_zone\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":175,"context_line":"        \u0027instance_type\u0027: fields.ObjectField(\u0027Flavor\u0027, nullable\u003dFalse),"},{"line_number":176,"context_line":"        \u0027num_instances\u0027: fields.IntegerField(default\u003d1),"},{"line_number":177,"context_line":"        \u0027force_hosts\u0027: fields.StringField(nullable\u003dTrue),"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7ad32947_e1ce9159","line":174,"in_reply_to":"7ad32947_a3ff8400","updated":"2015-04-28 12:14:52.000000000","message":"I addressed vm_state and task_state in the commit message.  They are used, but never vary between requests and don\u0027t need to be in this object.\n\nimage_ref should be in the image dict, as \u0027id\u0027 probably.  Duplicating it here is fine too but I would prefer to update the filter.","commit_id":"210387e805c1d018706abfc750ffa02b232c3ebf"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"636f6ca4dd0ba80e777dbc8214fe009df9bcdd40","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                                            nullable\u003dTrue),"},{"line_number":172,"context_line":"        \u0027project_id\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":173,"context_line":"        \u0027os_type\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":174,"context_line":"        \u0027availability_zone\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":175,"context_line":"        \u0027instance_type\u0027: fields.ObjectField(\u0027Flavor\u0027, nullable\u003dFalse),"},{"line_number":176,"context_line":"        \u0027num_instances\u0027: fields.IntegerField(default\u003d1),"},{"line_number":177,"context_line":"        \u0027force_hosts\u0027: fields.StringField(nullable\u003dTrue),"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7ad32947_e390dc97","line":174,"in_reply_to":"7ad32947_a3ff8400","updated":"2015-04-28 10:01:16.000000000","message":"image_ref is missing too\nhttps://github.com/openstack/nova/blob/af2d6c9576b1ac5f3b3768870bb15d9b5cf1610b/nova/scheduler/filters/isolated_hosts_filter.py#L76\n\nNote, it could be alleviated as we have the image dict probably","commit_id":"210387e805c1d018706abfc750ffa02b232c3ebf"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6b555632ba645754496bc54389a874c5c6efd463","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                                            nullable\u003dTrue),"},{"line_number":172,"context_line":"        \u0027project_id\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":173,"context_line":"        \u0027os_type\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":174,"context_line":"        \u0027availability_zone\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":175,"context_line":"        \u0027instance_type\u0027: fields.ObjectField(\u0027Flavor\u0027, nullable\u003dFalse),"},{"line_number":176,"context_line":"        \u0027num_instances\u0027: fields.IntegerField(default\u003d1),"},{"line_number":177,"context_line":"        \u0027force_hosts\u0027: fields.StringField(nullable\u003dTrue),"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5ad0253b_72aa711b","line":174,"in_reply_to":"7ad32947_e1ce9159","updated":"2015-04-28 20:23:44.000000000","message":"Fair point... I was so focused on double-checking the list that I missed to correctly read the commit msg, while I agree with your opinion","commit_id":"210387e805c1d018706abfc750ffa02b232c3ebf"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c3d0d26a91d220eaa4c46b8211da609bd036d8ca","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    fields \u003d {"},{"line_number":165,"context_line":"        \u0027image\u0027: fields.ObjectField(\u0027ImageMeta\u0027, nullable\u003dFalse),"},{"line_number":166,"context_line":"        \u0027root_gb\u0027: fields.IntegerField(nullable\u003dFalse),"},{"line_number":167,"context_line":"        \u0027ephemeral_gb\u0027: fields.IntegerField(nullable\u003dFalse),"},{"line_number":168,"context_line":"        \u0027memory_mb: fields.IntegerField(nullable\u003dFalse),"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3acd31a7_554634c0","line":165,"updated":"2015-04-29 22:30:46.000000000","message":"eh, you can just jinx the one who provided that change because that\u0027s why you have a rebase to be provided...","commit_id":"4d886bb746bd76ddb01b4a439c8192264cda9e05"}]}