)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f0f937cba18f582671881e0fb658560d51c9493e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-04-28 17:07:17 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\"Adding Python 3.4 support to Nova\" spec"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I957f8488e359f71ab60dd3304f242c823395edec"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3acd31a7_4cf8e3e5","line":8,"updated":"2015-04-30 09:38:04.000000000","message":"Please add the blueprint reference in here:\n\nblueprint nova-python3","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"482c12197ed2c0e2745f4ac2c29205de242cf0ee","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-04-28 17:07:17 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\"Adding Python 3.4 support to Nova\" spec"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I957f8488e359f71ab60dd3304f242c823395edec"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3acd31a7_752b5bec","line":8,"in_reply_to":"3acd31a7_4cf8e3e5","updated":"2015-04-30 14:11:48.000000000","message":"Done","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"}],"specs/liberty/approved/adding-python34-support-to-nova.rst":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d93ceb312525b28b5af847a8cac8cdc809570c1f","unresolved":false,"context_lines":[{"line_number":73,"context_line":"We will also need to run Nova in a DevStack that uses Python 3.4."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Note: Python 2 support is kept. Dropping Python 2 support will require a"},{"line_number":76,"context_line":"different specification."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7ad32947_fa92c556","line":76,"updated":"2015-04-28 09:05:50.000000000","message":"I honestly doubt it could be done in the same cycle. A note mentioning that we only plan to drop py2 suport by a later cycle is worth it to not panic distro vendors that are not supporting yet Py3.","commit_id":"f2910d384b136bb10c99d00fef073730a2cea750"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"865fd8a9efc1f901a09c9ecec3567c033a166482","unresolved":false,"context_lines":[{"line_number":73,"context_line":"We will also need to run Nova in a DevStack that uses Python 3.4."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Note: Python 2 support is kept. Dropping Python 2 support will require a"},{"line_number":76,"context_line":"different specification."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7ad32947_838da833","line":76,"in_reply_to":"7ad32947_fa92c556","updated":"2015-04-28 10:06:00.000000000","message":"I wrote explicitly that Python 2 support is kept at least until the next cycle (M).","commit_id":"f2910d384b136bb10c99d00fef073730a2cea750"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"e8a76d7605fd6fda19827071c44dfd6d423e7eef","unresolved":false,"context_lines":[{"line_number":152,"context_line":"---------------------"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"If deployers want to run services under Python 3, they should install Python 3"},{"line_number":155,"context_line":"with the whole stack."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"There will not be any differences for those who want to stick to Python 2, as"},{"line_number":158,"context_line":"we will make sure not to break anything."}],"source_content_type":"text/x-rst","patch_set":6,"id":"7ad32947_1dfa1bbe","line":155,"updated":"2015-04-28 09:12:57.000000000","message":"IIUC, your proposal is to add a py34 job that runs *unit* tests ?\n\nI think that before we claim Python 3 is supported for deployers, we will need to have the tempest integration test suite gating with a Python 3 configuration on at least one hypervisor.\n\nIOW, if python 3 support merges, but we don\u0027t have integration test coverage, we should make it clear that the py3 support is unsupported proof of concept only - ie it should be considered the same as Group C hypervisors today - it is present but discouraged. For each hypervisor, we\u0027ll probably want to classify the group a/b/c support status separately for Py2 and Py3. IOW for each 3rd party CI we\u0027d require provision of both a Py2 job and Py3 job","commit_id":"f2910d384b136bb10c99d00fef073730a2cea750"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"865fd8a9efc1f901a09c9ecec3567c033a166482","unresolved":false,"context_lines":[{"line_number":152,"context_line":"---------------------"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"If deployers want to run services under Python 3, they should install Python 3"},{"line_number":155,"context_line":"with the whole stack."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"There will not be any differences for those who want to stick to Python 2, as"},{"line_number":158,"context_line":"we will make sure not to break anything."}],"source_content_type":"text/x-rst","patch_set":6,"id":"7ad32947_c0ef16af","line":155,"in_reply_to":"7ad32947_1dfa1bbe","updated":"2015-04-28 10:06:00.000000000","message":"I changed this section to say explicitly that this spec is not enough to get a full Python 3 support ready for the production.","commit_id":"f2910d384b136bb10c99d00fef073730a2cea750"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d93ceb312525b28b5af847a8cac8cdc809570c1f","unresolved":false,"context_lines":[{"line_number":183,"context_line":"----------"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"* Finish the work on porting Nova dependencies to Python 3: it\u0027s almost done"},{"line_number":186,"context_line":"  and it\u0027s moving fast (see the Dependencies section below)."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"* Fix most obvious Python 3 issues. Example with a patch fixing most Python 3"},{"line_number":189,"context_line":"  issues: `Port to Python 3"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7ad32947_fa23e503","line":186,"updated":"2015-04-28 09:05:50.000000000","message":"what worries me a bit is that the spec is more than just code refactoring using six. You should mention that in the proposed change section above","commit_id":"f2910d384b136bb10c99d00fef073730a2cea750"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"865fd8a9efc1f901a09c9ecec3567c033a166482","unresolved":false,"context_lines":[{"line_number":183,"context_line":"----------"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"* Finish the work on porting Nova dependencies to Python 3: it\u0027s almost done"},{"line_number":186,"context_line":"  and it\u0027s moving fast (see the Dependencies section below)."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"* Fix most obvious Python 3 issues. Example with a patch fixing most Python 3"},{"line_number":189,"context_line":"  issues: `Port to Python 3"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7ad32947_6035e244","line":186,"in_reply_to":"7ad32947_fa23e503","updated":"2015-04-28 10:06:00.000000000","message":"The work on dependencies is not specific to Nova. Heat, Neutron, etc. are also impacted. The work already started, it\u0027s in progress.\n\nBut ok, I mentionned dependencies in the Proposed change section.","commit_id":"f2910d384b136bb10c99d00fef073730a2cea750"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d93ceb312525b28b5af847a8cac8cdc809570c1f","unresolved":false,"context_lines":[{"line_number":199,"context_line":"  to pass on Python 3."},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"* Enable a voting ``py34`` gate for Nova. From this point, we should now be"},{"line_number":202,"context_line":"  able to avoid Python 3 regressions while working."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"* Port remaining code to fix more tests, one by one, and enlarge the whitelist"},{"line_number":205,"context_line":"  of tests in ``tox.ini``."}],"source_content_type":"text/x-rst","patch_set":6,"id":"7ad32947_1d69fbbe","line":202,"updated":"2015-04-28 09:05:50.000000000","message":"How are you sure that before you provide that pre-merge job, your code won\u0027t be regressed ?\n\nI think adding a non-voting job first on that subset, then 3 days after that, make it voting on the check pipeline, and then provide it in the gate, could help that without breaking our gate.","commit_id":"f2910d384b136bb10c99d00fef073730a2cea750"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"865fd8a9efc1f901a09c9ecec3567c033a166482","unresolved":false,"context_lines":[{"line_number":199,"context_line":"  to pass on Python 3."},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"* Enable a voting ``py34`` gate for Nova. From this point, we should now be"},{"line_number":202,"context_line":"  able to avoid Python 3 regressions while working."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"* Port remaining code to fix more tests, one by one, and enlarge the whitelist"},{"line_number":205,"context_line":"  of tests in ``tox.ini``."}],"source_content_type":"text/x-rst","patch_set":6,"id":"7ad32947_60e8427d","line":202,"in_reply_to":"7ad32947_1d69fbbe","updated":"2015-04-28 10:06:00.000000000","message":"\u003e How are you sure that before you provide that pre-merge job, your code won\u0027t be regressed ?\n\nPython 3 regressions will only be avoided on the code tested by the whitelist when the py34 gate will be voting, not before.\n\n\u003e I think adding a non-voting job first on that subset, then 3 days after that, make it voting on the check pipeline,\n\nWell, it is how I do that usually in practice. But ok, I will modify the spec to detail the plan.\n\nI modified the Developers impact to explain this explicitly.","commit_id":"f2910d384b136bb10c99d00fef073730a2cea750"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d93ceb312525b28b5af847a8cac8cdc809570c1f","unresolved":false,"context_lines":[{"line_number":249,"context_line":"Developers might be interested in reading the official `Python 3 page"},{"line_number":250,"context_line":"\u003chttps://wiki.openstack.org/wiki/Python3\u003e`_ on the Openstack wiki. It shows"},{"line_number":251,"context_line":"the current progress and details some common issues that arise when porting"},{"line_number":252,"context_line":"code to Python 3."},{"line_number":253,"context_line":""},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7ad32947_daf2699a","line":252,"updated":"2015-04-28 09:05:50.000000000","message":"Well, I would even propose to amend the devref documents to give some common pattern and guidelines about Python 3, and not only keep the reference to the global wikipage","commit_id":"f2910d384b136bb10c99d00fef073730a2cea750"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"865fd8a9efc1f901a09c9ecec3567c033a166482","unresolved":false,"context_lines":[{"line_number":249,"context_line":"Developers might be interested in reading the official `Python 3 page"},{"line_number":250,"context_line":"\u003chttps://wiki.openstack.org/wiki/Python3\u003e`_ on the Openstack wiki. It shows"},{"line_number":251,"context_line":"the current progress and details some common issues that arise when porting"},{"line_number":252,"context_line":"code to Python 3."},{"line_number":253,"context_line":""},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7ad32947_c09036ef","line":252,"in_reply_to":"7ad32947_daf2699a","updated":"2015-04-28 10:06:00.000000000","message":"This can be done in parallel, I don\u0027t think that it needs to be part of the spec.","commit_id":"f2910d384b136bb10c99d00fef073730a2cea750"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d93ceb312525b28b5af847a8cac8cdc809570c1f","unresolved":false,"context_lines":[{"line_number":256,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"* `OpenStack Liberty Summit: \"Port Nova to Python 3\" session"},{"line_number":259,"context_line":"  \u003chttps://etherpad.openstack.org/p/liberty-nova-summit-ideas\u003e`_"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"* Related Liberty specifications:"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7ad32947_daadc989","line":259,"updated":"2015-04-28 09:05:50.000000000","message":"I think you can probably drop that reference","commit_id":"f2910d384b136bb10c99d00fef073730a2cea750"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"865fd8a9efc1f901a09c9ecec3567c033a166482","unresolved":false,"context_lines":[{"line_number":256,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"* `OpenStack Liberty Summit: \"Port Nova to Python 3\" session"},{"line_number":259,"context_line":"  \u003chttps://etherpad.openstack.org/p/liberty-nova-summit-ideas\u003e`_"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"* Related Liberty specifications:"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7ad32947_809a3e13","line":259,"in_reply_to":"7ad32947_daadc989","updated":"2015-04-28 10:06:00.000000000","message":"Done","commit_id":"f2910d384b136bb10c99d00fef073730a2cea750"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"49358ec861258a7c79b439433cf221ea24d603a4","unresolved":false,"context_lines":[{"line_number":203,"context_line":"  suite which pass on Python 3. It will use a whitelist of tests which are know"},{"line_number":204,"context_line":"  to pass on Python 3."},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"* Add a ``py34`` gate for Nova."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"* When the ``py34`` gate is stable enough, make it voting. From this point, we"},{"line_number":209,"context_line":"  should now be able to avoid Python 3 regressions while working."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7ad32947_cb2f2ea0","line":206,"updated":"2015-04-28 14:31:37.000000000","message":"To be precise, it would be a job which would run non-voting for the check pipeline, then voting on it, then being on the gate pipeline. There is no actually need for a non-voting gate job, that\u0027s just useless","commit_id":"db190c9aaa7345a81dac81059799e25f61663835"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"49358ec861258a7c79b439433cf221ea24d603a4","unresolved":false,"context_lines":[{"line_number":256,"context_line":"Developers might be interested in reading the official `Python 3 page"},{"line_number":257,"context_line":"\u003chttps://wiki.openstack.org/wiki/Python3\u003e`_ on the Openstack wiki. It shows"},{"line_number":258,"context_line":"the current progress and details some common issues that arise when porting"},{"line_number":259,"context_line":"code to Python 3."},{"line_number":260,"context_line":""},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7ad32947_662baf83","line":259,"updated":"2015-04-28 14:31:37.000000000","message":"I reemphasize the need of providing a change to the devref documentation giving specific information about Nova. That can be said as a work item either, but that needs to be covered","commit_id":"db190c9aaa7345a81dac81059799e25f61663835"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3ebd6d0406ac18338077383bee452d1dac0d292a","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Adding Python 3.4 support to Nova"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/nova-python3"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_e15578c6","line":8,"updated":"2015-04-30 09:36:22.000000000","message":"appreciate the name change, thank you.","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3ebd6d0406ac18338077383bee452d1dac0d292a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Problem description"},{"line_number":15,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"All Nova dependencies are now Python 3 compatible: see the Dependencies section"},{"line_number":18,"context_line":"below. It\u0027s time to add Python 3 support to Nova by generalizing the usage of"},{"line_number":19,"context_line":"the six module, in addition to the Python 2 support."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_61128864","line":17,"updated":"2015-04-30 09:36:22.000000000","message":"This seem to conflict with what you describe below.","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7087aae5b17f98e99aa9cc2ba46dbcfb189a9325","unresolved":false,"context_lines":[{"line_number":27,"context_line":"not less than 15 new modules. Python 3 is already well supported by major Linux"},{"line_number":28,"context_line":"distributions. Slowly, some bugs cannot be fixed in Python 2.7 anymore and are"},{"line_number":29,"context_line":"only fixed in the latest Python 3 release. Python 3 is now 7 years old and"},{"line_number":30,"context_line":"considered as a mature programming language."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"The motivation to move away from Python 2 is the technical debt. OpenStack is"},{"line_number":33,"context_line":"one of the largest Free Software project in term of lines of code, more than"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_46d0d453","line":30,"updated":"2015-04-29 19:56:57.000000000","message":"I don\u0027t feel like we need to have much of the \"why python 3\" text in here. Just MHO, but I don\u0027t feel like the goal is in need of defense.","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"482c12197ed2c0e2745f4ac2c29205de242cf0ee","unresolved":false,"context_lines":[{"line_number":27,"context_line":"not less than 15 new modules. Python 3 is already well supported by major Linux"},{"line_number":28,"context_line":"distributions. Slowly, some bugs cannot be fixed in Python 2.7 anymore and are"},{"line_number":29,"context_line":"only fixed in the latest Python 3 release. Python 3 is now 7 years old and"},{"line_number":30,"context_line":"considered as a mature programming language."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"The motivation to move away from Python 2 is the technical debt. OpenStack is"},{"line_number":33,"context_line":"one of the largest Free Software project in term of lines of code, more than"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_d5510f64","line":30,"in_reply_to":"3acd31a7_214c9041","updated":"2015-04-30 14:11:48.000000000","message":"Ok, so I replaced this text with a reference to the article.\n\nAnyway, the text was simply copied/pasted from this article (with minor updates).","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3ebd6d0406ac18338077383bee452d1dac0d292a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"not less than 15 new modules. Python 3 is already well supported by major Linux"},{"line_number":28,"context_line":"distributions. Slowly, some bugs cannot be fixed in Python 2.7 anymore and are"},{"line_number":29,"context_line":"only fixed in the latest Python 3 release. Python 3 is now 7 years old and"},{"line_number":30,"context_line":"considered as a mature programming language."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"The motivation to move away from Python 2 is the technical debt. OpenStack is"},{"line_number":33,"context_line":"one of the largest Free Software project in term of lines of code, more than"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_214c9041","line":30,"in_reply_to":"3acd31a7_3b115fad","updated":"2015-04-30 09:36:22.000000000","message":"Sounds like we are starting to agree anyways.\n\nThere is aways a danger of too much info in a spec delaying things.","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"97f7091ceb7aa268173614b7fec0934a21a11128","unresolved":false,"context_lines":[{"line_number":27,"context_line":"not less than 15 new modules. Python 3 is already well supported by major Linux"},{"line_number":28,"context_line":"distributions. Slowly, some bugs cannot be fixed in Python 2.7 anymore and are"},{"line_number":29,"context_line":"only fixed in the latest Python 3 release. Python 3 is now 7 years old and"},{"line_number":30,"context_line":"considered as a mature programming language."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"The motivation to move away from Python 2 is the technical debt. OpenStack is"},{"line_number":33,"context_line":"one of the largest Free Software project in term of lines of code, more than"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_3b115fad","line":30,"in_reply_to":"3acd31a7_46d0d453","updated":"2015-04-30 08:55:10.000000000","message":"Joe Gordon wrote \"nice section, this preempted all my planned complaints about python3 being bamboozled.\":\nhttps://review.openstack.org/#/c/176868/3/specs/liberty/approved/port-nova-to-python3.rst\n\nI chose to explain \"why python3?\" here to put all information in the spec, so you don\u0027t need to follow all links to understand the whole spec.","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7087aae5b17f98e99aa9cc2ba46dbcfb189a9325","unresolved":false,"context_lines":[{"line_number":30,"context_line":"considered as a mature programming language."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"The motivation to move away from Python 2 is the technical debt. OpenStack is"},{"line_number":33,"context_line":"one of the largest Free Software project in term of lines of code, more than"},{"line_number":34,"context_line":"2.5 million lines of code. If an application is not updated to track evolution"},{"line_number":35,"context_line":"of new features, it dies slowly. A technical debt has a concrete price: the"},{"line_number":36,"context_line":"longer you wait to port OpenStack to Python 3, the more expensive the portage"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_c6962494","line":33,"range":{"start_line":33,"start_character":33,"end_line":33,"end_character":40},"updated":"2015-04-29 19:56:57.000000000","message":"should be \"projects\"","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"97f7091ceb7aa268173614b7fec0934a21a11128","unresolved":false,"context_lines":[{"line_number":30,"context_line":"considered as a mature programming language."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"The motivation to move away from Python 2 is the technical debt. OpenStack is"},{"line_number":33,"context_line":"one of the largest Free Software project in term of lines of code, more than"},{"line_number":34,"context_line":"2.5 million lines of code. If an application is not updated to track evolution"},{"line_number":35,"context_line":"of new features, it dies slowly. A technical debt has a concrete price: the"},{"line_number":36,"context_line":"longer you wait to port OpenStack to Python 3, the more expensive the portage"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_1e27b113","line":33,"in_reply_to":"3acd31a7_c6962494","updated":"2015-04-30 08:55:10.000000000","message":"Done","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7087aae5b17f98e99aa9cc2ba46dbcfb189a9325","unresolved":false,"context_lines":[{"line_number":77,"context_line":"We will also need to run Nova in a DevStack that uses Python 3.4."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Note: Python 2 support is kept. Dropping Python 2 support will require a"},{"line_number":80,"context_line":"different specification for the next cycle (\"M\") or later."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_8655ccc7","line":80,"updated":"2015-04-29 19:56:57.000000000","message":"I also don\u0027t feel like we need to talk about dropping py2 support at this point.","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"482c12197ed2c0e2745f4ac2c29205de242cf0ee","unresolved":false,"context_lines":[{"line_number":77,"context_line":"We will also need to run Nova in a DevStack that uses Python 3.4."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Note: Python 2 support is kept. Dropping Python 2 support will require a"},{"line_number":80,"context_line":"different specification for the next cycle (\"M\") or later."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_35d163ce","line":80,"in_reply_to":"3acd31a7_8655ccc7","updated":"2015-04-30 14:11:48.000000000","message":"Done","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"a4324071876097bc13c4fcd6dbf693214db02dff","unresolved":false,"context_lines":[{"line_number":77,"context_line":"We will also need to run Nova in a DevStack that uses Python 3.4."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Note: Python 2 support is kept. Dropping Python 2 support will require a"},{"line_number":80,"context_line":"different specification for the next cycle (\"M\") or later."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_a651e864","line":80,"in_reply_to":"3acd31a7_8655ccc7","updated":"2015-04-29 20:03:47.000000000","message":"Fair point that I mentioned in a previous PS","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"97f7091ceb7aa268173614b7fec0934a21a11128","unresolved":false,"context_lines":[{"line_number":77,"context_line":"We will also need to run Nova in a DevStack that uses Python 3.4."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Note: Python 2 support is kept. Dropping Python 2 support will require a"},{"line_number":80,"context_line":"different specification for the next cycle (\"M\") or later."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_dbe5cba8","line":80,"in_reply_to":"3acd31a7_8655ccc7","updated":"2015-04-30 08:55:10.000000000","message":"It was more or less asked explicitly in previous comments on the spec and on the openstack-dev mailing list.\n\nFor example, Sylvain Bauza wrote \"I honestly doubt it could be done in the same cycle. A note mentioning that we only plan to drop py2 suport by a later cycle is worth it to not panic distro vendors that are not supporting yet Py3.\"\nhttps://review.openstack.org/#/c/176868/6/specs/liberty/approved/adding-python34-support-to-nova.rst\n\nIt\u0027s also a reply to the proposition to immediatly switch to Python 3 (also discussed above in the spec), so drop Python 2 in the same time.","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"fa6cfb4e57b70358f9f7ab6a15ee5300f2aafe96","unresolved":false,"context_lines":[{"line_number":77,"context_line":"We will also need to run Nova in a DevStack that uses Python 3.4."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Note: Python 2 support is kept. Dropping Python 2 support will require a"},{"line_number":80,"context_line":"different specification for the next cycle (\"M\") or later."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_12cfa057","line":80,"in_reply_to":"3acd31a7_a1bae0df","updated":"2015-04-30 10:24:23.000000000","message":"IMO we all agree on \"Note: Python 2 support is kept.\", that\u0027s enough :-) No need to mention a possible change in the future.","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"b7e2574618b9db06b3021a51006744537f813c12","unresolved":false,"context_lines":[{"line_number":77,"context_line":"We will also need to run Nova in a DevStack that uses Python 3.4."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Note: Python 2 support is kept. Dropping Python 2 support will require a"},{"line_number":80,"context_line":"different specification for the next cycle (\"M\") or later."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_bb7c5921","line":80,"in_reply_to":"3acd31a7_a651e864","updated":"2015-04-29 23:51:44.000000000","message":"yeah we just need the \u0027Python 2 support is kept.\u0027 bit","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3ebd6d0406ac18338077383bee452d1dac0d292a","unresolved":false,"context_lines":[{"line_number":77,"context_line":"We will also need to run Nova in a DevStack that uses Python 3.4."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Note: Python 2 support is kept. Dropping Python 2 support will require a"},{"line_number":80,"context_line":"different specification for the next cycle (\"M\") or later."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_a1bae0df","line":80,"in_reply_to":"3acd31a7_dbe5cba8","updated":"2015-04-30 09:36:22.000000000","message":"As I see it...\n\nThe key concern is, \"must not drop py27 support in liberty\".\n\nIts will be easier to get text we all agree to if thats the limit of the discussion here.","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7087aae5b17f98e99aa9cc2ba46dbcfb189a9325","unresolved":false,"context_lines":[{"line_number":83,"context_line":"Alternatives"},{"line_number":84,"context_line":"------------"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Drop Python 2 support"},{"line_number":87,"context_line":"^^^^^^^^^^^^^^^^^^^^^"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Add Python 3.4 support to Nova is not enough to be able to benefit of Python 3"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_46d33439","line":86,"updated":"2015-04-29 19:56:57.000000000","message":"I don\u0027t think this is reasonably an option, so I propose we just drop it. That\u0027s also in line with this work not being up for discussion, or even contentious.","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"b7e2574618b9db06b3021a51006744537f813c12","unresolved":false,"context_lines":[{"line_number":83,"context_line":"Alternatives"},{"line_number":84,"context_line":"------------"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Drop Python 2 support"},{"line_number":87,"context_line":"^^^^^^^^^^^^^^^^^^^^^"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Add Python 3.4 support to Nova is not enough to be able to benefit of Python 3"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_7b76c13f","line":86,"in_reply_to":"3acd31a7_46d33439","updated":"2015-04-29 23:51:44.000000000","message":"++","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"97f7091ceb7aa268173614b7fec0934a21a11128","unresolved":false,"context_lines":[{"line_number":83,"context_line":"Alternatives"},{"line_number":84,"context_line":"------------"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Drop Python 2 support"},{"line_number":87,"context_line":"^^^^^^^^^^^^^^^^^^^^^"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Add Python 3.4 support to Nova is not enough to be able to benefit of Python 3"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_bb90cfed","line":86,"in_reply_to":"3acd31a7_46d33439","updated":"2015-04-30 08:55:10.000000000","message":"Since the point was raised by different developers, I consider that it\u0027s important to mention it *and* explain why I consider why we didn\u0027t choose this option.\n\nWhat\u0027s the problem of mentionning this option in Alternatives? Otherwise, what\u0027s the purpupose of the Alternatives section?","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3ebd6d0406ac18338077383bee452d1dac0d292a","unresolved":false,"context_lines":[{"line_number":83,"context_line":"Alternatives"},{"line_number":84,"context_line":"------------"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Drop Python 2 support"},{"line_number":87,"context_line":"^^^^^^^^^^^^^^^^^^^^^"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Add Python 3.4 support to Nova is not enough to be able to benefit of Python 3"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_81948437","line":86,"in_reply_to":"3acd31a7_bb90cfed","updated":"2015-04-30 09:36:22.000000000","message":"it doesn\u0027t seem worth mentioning.","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3ebd6d0406ac18338077383bee452d1dac0d292a","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Dropping Python 2 support is the final goal of this specification, but it is"},{"line_number":105,"context_line":"out of the scope of the specification. A new dedicated specification should be"},{"line_number":106,"context_line":"written later when Nova will fully support Python 3."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_21d25001","line":106,"updated":"2015-04-30 09:36:22.000000000","message":"So this is where we don\u0027t quite agree I think.\n\nThe goal of this specification, is to allow Nova to run on python 3.4\n\nIt has actually is more about keeping python 2.7 support, as I see it.","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7087aae5b17f98e99aa9cc2ba46dbcfb189a9325","unresolved":false,"context_lines":[{"line_number":156,"context_line":"---------------------"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Since Python 2 support is kept until at least the next cycle (\"M\"), there is no"},{"line_number":159,"context_line":"impact for deployers."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"This specification is not enough to get a full Python 3 support ready for the"},{"line_number":162,"context_line":"production."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_e6afe092","line":159,"updated":"2015-04-29 19:56:57.000000000","message":"I think mentioning a cycle for deprecation (especially the next one) is not a good idea here. Just say \"kept until we decide to drop it\".","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3ebd6d0406ac18338077383bee452d1dac0d292a","unresolved":false,"context_lines":[{"line_number":156,"context_line":"---------------------"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Since Python 2 support is kept until at least the next cycle (\"M\"), there is no"},{"line_number":159,"context_line":"impact for deployers."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"This specification is not enough to get a full Python 3 support ready for the"},{"line_number":162,"context_line":"production."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_4188ace7","line":159,"in_reply_to":"3acd31a7_e6afe092","updated":"2015-04-30 09:36:22.000000000","message":"+1","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7087aae5b17f98e99aa9cc2ba46dbcfb189a9325","unresolved":false,"context_lines":[{"line_number":159,"context_line":"impact for deployers."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"This specification is not enough to get a full Python 3 support ready for the"},{"line_number":162,"context_line":"production."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Developer impact"},{"line_number":165,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_a6cb2872","line":162,"updated":"2015-04-29 19:56:57.000000000","message":"I\u0027m not sure what this means. If you mean \"this is not enough to be able to use shiny new features of python3\" then I think you\u0027ve covered it and can drop this.","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3ebd6d0406ac18338077383bee452d1dac0d292a","unresolved":false,"context_lines":[{"line_number":159,"context_line":"impact for deployers."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"This specification is not enough to get a full Python 3 support ready for the"},{"line_number":162,"context_line":"production."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Developer impact"},{"line_number":165,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_41ed4c8a","line":162,"in_reply_to":"3acd31a7_3e114dad","updated":"2015-04-30 09:36:22.000000000","message":"Full tempest reliably passing is all we can say here.\n\nI think we should remove this statement.","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"97f7091ceb7aa268173614b7fec0934a21a11128","unresolved":false,"context_lines":[{"line_number":159,"context_line":"impact for deployers."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"This specification is not enough to get a full Python 3 support ready for the"},{"line_number":162,"context_line":"production."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Developer impact"},{"line_number":165,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_3e114dad","line":162,"in_reply_to":"3acd31a7_a6cb2872","updated":"2015-04-30 08:55:10.000000000","message":"\u003e I\u0027m not sure what this means.\n\nI don\u0027t know when we will be able to consider that Nova is fully Python 3 compatible: ready for the production.\n\nDo you think that unittest+tempest are enough to announce an official Python3 support?","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3ebd6d0406ac18338077383bee452d1dac0d292a","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"This specification is not enough to get a full Python 3 support ready for the"},{"line_number":162,"context_line":"production."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Developer impact"},{"line_number":165,"context_line":"----------------"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_819a4413","line":163,"updated":"2015-04-30 09:36:22.000000000","message":"What I was expecting to see here, is something like:\n\nDeployers using python 2.7 will see no changes.\n\nThose able to run python 3.4 will now be try that out.","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7087aae5b17f98e99aa9cc2ba46dbcfb189a9325","unresolved":false,"context_lines":[{"line_number":188,"context_line":"----------"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"* Finish the work on porting Nova dependencies to Python 3: it\u0027s almost done"},{"line_number":191,"context_line":"  and it\u0027s moving fast (see the Dependencies section below)."},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"* Fix most obvious Python 3 issues. Example with a patch fixing most Python 3"},{"line_number":194,"context_line":"  issues: `Port to Python 3"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_0682dc00","line":191,"updated":"2015-04-29 19:56:57.000000000","message":"According to the first paragraph in this document, this is not a work item. Drop it?","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"482c12197ed2c0e2745f4ac2c29205de242cf0ee","unresolved":false,"context_lines":[{"line_number":188,"context_line":"----------"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"* Finish the work on porting Nova dependencies to Python 3: it\u0027s almost done"},{"line_number":191,"context_line":"  and it\u0027s moving fast (see the Dependencies section below)."},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"* Fix most obvious Python 3 issues. Example with a patch fixing most Python 3"},{"line_number":194,"context_line":"  issues: `Port to Python 3"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_95f95750","line":191,"in_reply_to":"3acd31a7_0682dc00","updated":"2015-04-30 14:11:48.000000000","message":"I dropped this item.","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"a4324071876097bc13c4fcd6dbf693214db02dff","unresolved":false,"context_lines":[{"line_number":188,"context_line":"----------"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"* Finish the work on porting Nova dependencies to Python 3: it\u0027s almost done"},{"line_number":191,"context_line":"  and it\u0027s moving fast (see the Dependencies section below)."},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"* Fix most obvious Python 3 issues. Example with a patch fixing most Python 3"},{"line_number":194,"context_line":"  issues: `Port to Python 3"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_669070ed","line":191,"in_reply_to":"3acd31a7_0682dc00","updated":"2015-04-29 20:03:47.000000000","message":"The main problem is the scope of this spec. Here are all the efforts for getting a py3 compliant Nova, but it also needs some dependency updates.\n\nJust wondering if that\u0027s worth mentioning that as part of the spec but not as a single work item, I agree.","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"fa6cfb4e57b70358f9f7ab6a15ee5300f2aafe96","unresolved":false,"context_lines":[{"line_number":188,"context_line":"----------"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"* Finish the work on porting Nova dependencies to Python 3: it\u0027s almost done"},{"line_number":191,"context_line":"  and it\u0027s moving fast (see the Dependencies section below)."},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"* Fix most obvious Python 3 issues. Example with a patch fixing most Python 3"},{"line_number":194,"context_line":"  issues: `Port to Python 3"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_92873061","line":191,"in_reply_to":"3acd31a7_2c3b67d3","updated":"2015-04-30 10:24:23.000000000","message":"\u003e Maybe a better question, what are you planning to do in the context of this spec?\n\u003e Update our dependencies to the latest versions that will support py34?\n\nIf needed, writing patches to port remaining dependencies code to Python 3. Since almost all pull requests were merged, in practice it\u0027s now more a matter of getting releases including these changes and then bump versions in global requirements (and then in nova requirements).\n\n\u003e Change the database lib to a py34 supported one? That might have a big performance impact, I think there a separate specs on that.\n\nDon\u0027t worry. mysqlclient is a fork on mysql-python, so there is no reason to have an impact on performances.\n\nmysqlclient and mysql-python have a different package name (on PyPI) but the Python module has the same name (\"MySQLdb\"), so mysqlclient is a drop-in replacement for mysql-python.\n\nLast week, I sent an email to mysql-python author, Andy Dustman aka farcepest, to ask him if it would be possible to merge mysqlclient into mysql-python, but I didn\u0027t get an answer yet :-( mysql-python doesn\u0027t look active anymore, the last commit was done in january 2014.\n\nI don\u0027t think that a whole spec is required, an email to openstack-dev is enough ;-) I\u0027m still waiting a little bit because I still hope to get a reply from mysql-python...","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"97f7091ceb7aa268173614b7fec0934a21a11128","unresolved":false,"context_lines":[{"line_number":188,"context_line":"----------"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"* Finish the work on porting Nova dependencies to Python 3: it\u0027s almost done"},{"line_number":191,"context_line":"  and it\u0027s moving fast (see the Dependencies section below)."},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"* Fix most obvious Python 3 issues. Example with a patch fixing most Python 3"},{"line_number":194,"context_line":"  issues: `Port to Python 3"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_be5f9d0d","line":191,"in_reply_to":"3acd31a7_669070ed","updated":"2015-04-30 08:55:10.000000000","message":"Nova doesn\u0027t work on Python 3 without dependencies. Even if the work on dependencies is not directly related to nova, it\u0027s directly related to this spec. I prefer to keep this work item.","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3ebd6d0406ac18338077383bee452d1dac0d292a","unresolved":false,"context_lines":[{"line_number":188,"context_line":"----------"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"* Finish the work on porting Nova dependencies to Python 3: it\u0027s almost done"},{"line_number":191,"context_line":"  and it\u0027s moving fast (see the Dependencies section below)."},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"* Fix most obvious Python 3 issues. Example with a patch fixing most Python 3"},{"line_number":194,"context_line":"  issues: `Port to Python 3"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_2c3b67d3","line":191,"in_reply_to":"3acd31a7_be5f9d0d","updated":"2015-04-30 09:36:22.000000000","message":"Maybe a better question, what are you planning to do in the context of this spec?\n\nUpdate our dependencies to the latest versions that will support py34?\n\nChange the database lib to a py34 supported one? That might have a big performance impact, I think there a separate specs on that.\n\nWe need to agree the scope of this work. Using a slightly different database lib on py34 might be good enough for now, be if thats what we want to do, we should really state that here.","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"b7e2574618b9db06b3021a51006744537f813c12","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"* Complete the `Nova Developer Guide"},{"line_number":209,"context_line":"  \u003chttp://docs.openstack.org/developer/nova/devref/\u003e`_ to explain how to write"},{"line_number":210,"context_line":"  code compatible on Python 2 and Python 3."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"* When the ``py34`` check job is stable enough, make it voting. From this"},{"line_number":213,"context_line":"  point, we should now be able to avoid Python 3 regressions while working."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_dbb4b5d2","line":210,"updated":"2015-04-29 23:51:44.000000000","message":"I don\u0027t think nova should have its own article written on this, a reference to a more generic python or even OpenStack one is better","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"482c12197ed2c0e2745f4ac2c29205de242cf0ee","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"* Complete the `Nova Developer Guide"},{"line_number":209,"context_line":"  \u003chttp://docs.openstack.org/developer/nova/devref/\u003e`_ to explain how to write"},{"line_number":210,"context_line":"  code compatible on Python 2 and Python 3."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"* When the ``py34`` check job is stable enough, make it voting. From this"},{"line_number":213,"context_line":"  point, we should now be able to avoid Python 3 regressions while working."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_15bb0774","line":210,"in_reply_to":"3acd31a7_dbb4b5d2","updated":"2015-04-30 14:11:48.000000000","message":"I removed this item.","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"97f7091ceb7aa268173614b7fec0934a21a11128","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"* Complete the `Nova Developer Guide"},{"line_number":209,"context_line":"  \u003chttp://docs.openstack.org/developer/nova/devref/\u003e`_ to explain how to write"},{"line_number":210,"context_line":"  code compatible on Python 2 and Python 3."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"* When the ``py34`` check job is stable enough, make it voting. From this"},{"line_number":213,"context_line":"  point, we should now be able to avoid Python 3 regressions while working."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_fedab577","line":210,"in_reply_to":"3acd31a7_dbb4b5d2","updated":"2015-04-30 08:55:10.000000000","message":"Sylvain Bauza asked me twice to add this item, example:\nhttps://review.openstack.org/#/c/176868/7/specs/liberty/approved/adding-python34-support-to-nova.rst\n\"I reemphasize the need of providing a change to the devref documentation giving specific information about Nova. That can be said as a work item either, but that needs to be covered\"","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7087aae5b17f98e99aa9cc2ba46dbcfb189a9325","unresolved":false,"context_lines":[{"line_number":216,"context_line":"  of tests in ``tox.ini``."},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"* Once all tests work, remove the explicit list of tests to run when using"},{"line_number":219,"context_line":"  Python 3 from ``tox.ini``."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"The transition period when Python 3 is only supported partially should be a"},{"line_number":222,"context_line":"short as possible."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_86db8c1b","line":219,"updated":"2015-04-29 19:56:57.000000000","message":"This just applies to the unit tests, right? I think a specific work item of this is also doing the devstack job work, right?","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"482c12197ed2c0e2745f4ac2c29205de242cf0ee","unresolved":false,"context_lines":[{"line_number":216,"context_line":"  of tests in ``tox.ini``."},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"* Once all tests work, remove the explicit list of tests to run when using"},{"line_number":219,"context_line":"  Python 3 from ``tox.ini``."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"The transition period when Python 3 is only supported partially should be a"},{"line_number":222,"context_line":"short as possible."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_f5b08b8d","line":219,"in_reply_to":"3acd31a7_86db8c1b","updated":"2015-04-30 14:11:48.000000000","message":"I replaced \"Once all tests work\" with \"Once all unit tests work\".","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"97f7091ceb7aa268173614b7fec0934a21a11128","unresolved":false,"context_lines":[{"line_number":216,"context_line":"  of tests in ``tox.ini``."},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"* Once all tests work, remove the explicit list of tests to run when using"},{"line_number":219,"context_line":"  Python 3 from ``tox.ini``."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"The transition period when Python 3 is only supported partially should be a"},{"line_number":222,"context_line":"short as possible."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_3e2b8d32","line":219,"in_reply_to":"3acd31a7_86db8c1b","updated":"2015-04-30 08:55:10.000000000","message":"Sorry, I don\u0027t know yet how to handle Tempest. I\u0027m not sure that it\u0027s possible to only run a subset of Tempest tests.\n\nMy hope is that fixing unit test is enough to see Tempest tests running :-)\n\nIf you have a better view than me of what should be done, can you please suggest a work item?","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7087aae5b17f98e99aa9cc2ba46dbcfb189a9325","unresolved":false,"context_lines":[{"line_number":224,"context_line":"Note: No voting ``py34`` gate job will be added to not waste resources of the"},{"line_number":225,"context_line":"OpenStack infra, a ``py27`` gate job is enough. We consider that there is a low"},{"line_number":226,"context_line":"risk of having a Python 3 specific issue introduced by a conflict between the"},{"line_number":227,"context_line":"check and the gate jobs."},{"line_number":228,"context_line":""},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_2694b835","line":227,"updated":"2015-04-29 19:56:57.000000000","message":"+1 (or the opposite, only py34)","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7087aae5b17f98e99aa9cc2ba46dbcfb189a9325","unresolved":false,"context_lines":[{"line_number":241,"context_line":"  ``keystonemiddleware``."},{"line_number":242,"context_line":"* ``websockify``: Python 3 classifier is missing in websockify 0.6.0, but it"},{"line_number":243,"context_line":"  is present in the development version. Tests are failing but they may be"},{"line_number":244,"context_line":"  issues with the tests, not with websockify directly."},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"The development version of ``oslo.messaging`` works on Python 3, except of Qpid"},{"line_number":247,"context_line":"and AMQP 1.0 drivers. Nova may start by only running tests with the RabbitMQ"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_26bb98c6","line":244,"updated":"2015-04-29 19:56:57.000000000","message":"This conflicts with the first paragraph in the document, right? I think we should be internally consistent, regardless of what the right answer is.","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"97f7091ceb7aa268173614b7fec0934a21a11128","unresolved":false,"context_lines":[{"line_number":241,"context_line":"  ``keystonemiddleware``."},{"line_number":242,"context_line":"* ``websockify``: Python 3 classifier is missing in websockify 0.6.0, but it"},{"line_number":243,"context_line":"  is present in the development version. Tests are failing but they may be"},{"line_number":244,"context_line":"  issues with the tests, not with websockify directly."},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"The development version of ``oslo.messaging`` works on Python 3, except of Qpid"},{"line_number":247,"context_line":"and AMQP 1.0 drivers. Nova may start by only running tests with the RabbitMQ"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_fece3559","line":244,"in_reply_to":"3acd31a7_26bb98c6","updated":"2015-04-30 08:55:10.000000000","message":"\"All Nova dependencies are now Python 3 compatible\" is true if you take the development version of some dependencies and switch some dependencies to drop-in replacements (like mysql-python \u003d\u003e mysqlclient).\n\n\"All Nova dependencies are now Python 3 compatible\" is false if you expect nova to fully working without any modification: we need some releases (oslo.messaging) and modify dependencies. That\u0027s also why I added a work item, to \"finish\" the work.\n\nDo you mean that I should rephrase the first paragraph?\n\n\"All Nova dependencies are now Python 3 compatible\" \u003d\u003e \"Almost all Nova dependencies are now Python 3 compatible\"?","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"a4324071876097bc13c4fcd6dbf693214db02dff","unresolved":false,"context_lines":[{"line_number":241,"context_line":"  ``keystonemiddleware``."},{"line_number":242,"context_line":"* ``websockify``: Python 3 classifier is missing in websockify 0.6.0, but it"},{"line_number":243,"context_line":"  is present in the development version. Tests are failing but they may be"},{"line_number":244,"context_line":"  issues with the tests, not with websockify directly."},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"The development version of ``oslo.messaging`` works on Python 3, except of Qpid"},{"line_number":247,"context_line":"and AMQP 1.0 drivers. Nova may start by only running tests with the RabbitMQ"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_4631f40a","line":244,"in_reply_to":"3acd31a7_26bb98c6","updated":"2015-04-29 20:03:47.000000000","message":"Yeah, that\u0027s my main concerns. The spec is about using six, but some further work needs to be done on g-r which is technically not Nova... So, I would mention the g-r effort as a reference, maybe ?","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"b44571f77a54384261746e8be8061d19a80a2693","unresolved":false,"context_lines":[{"line_number":241,"context_line":"  ``keystonemiddleware``."},{"line_number":242,"context_line":"* ``websockify``: Python 3 classifier is missing in websockify 0.6.0, but it"},{"line_number":243,"context_line":"  is present in the development version. Tests are failing but they may be"},{"line_number":244,"context_line":"  issues with the tests, not with websockify directly."},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"The development version of ``oslo.messaging`` works on Python 3, except of Qpid"},{"line_number":247,"context_line":"and AMQP 1.0 drivers. Nova may start by only running tests with the RabbitMQ"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_f220a4f9","line":244,"in_reply_to":"3acd31a7_7299346e","updated":"2015-04-30 10:26:06.000000000","message":"\u003e Ok, I will update the spec to explain better the status of specificiations.\n\nOops: \"the status of dependencies\".","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"fa6cfb4e57b70358f9f7ab6a15ee5300f2aafe96","unresolved":false,"context_lines":[{"line_number":241,"context_line":"  ``keystonemiddleware``."},{"line_number":242,"context_line":"* ``websockify``: Python 3 classifier is missing in websockify 0.6.0, but it"},{"line_number":243,"context_line":"  is present in the development version. Tests are failing but they may be"},{"line_number":244,"context_line":"  issues with the tests, not with websockify directly."},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"The development version of ``oslo.messaging`` works on Python 3, except of Qpid"},{"line_number":247,"context_line":"and AMQP 1.0 drivers. Nova may start by only running tests with the RabbitMQ"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_7299346e","line":244,"in_reply_to":"3acd31a7_c12cbcad","updated":"2015-04-30 10:24:23.000000000","message":"Things are also moving fast. Some dependencies (oslo.messaging, paste) were ported since the first revision of the spec!\n\nOk, I will update the spec to explain better the status of specificiations.","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3ebd6d0406ac18338077383bee452d1dac0d292a","unresolved":false,"context_lines":[{"line_number":241,"context_line":"  ``keystonemiddleware``."},{"line_number":242,"context_line":"* ``websockify``: Python 3 classifier is missing in websockify 0.6.0, but it"},{"line_number":243,"context_line":"  is present in the development version. Tests are failing but they may be"},{"line_number":244,"context_line":"  issues with the tests, not with websockify directly."},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"The development version of ``oslo.messaging`` works on Python 3, except of Qpid"},{"line_number":247,"context_line":"and AMQP 1.0 drivers. Nova may start by only running tests with the RabbitMQ"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3acd31a7_c12cbcad","line":244,"in_reply_to":"3acd31a7_fece3559","updated":"2015-04-30 09:36:22.000000000","message":"Yes, please update that first note.\n\nI think you are trying to say something like this:\n\nIf we move away from mysql-python to a drop-in alternative, that take the latest development version of all other dependencies, the only thing stopping Nova running on python 3.4 is Nova itself.","commit_id":"c298631af4e38e030125bd20c5443fbea3a42f44"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6ad75ff1fe85c700127d99a072ebcbaa0528fe2f","unresolved":false,"context_lines":[{"line_number":47,"context_line":".. note::"},{"line_number":48,"context_line":"   Python 2 support is kept."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":".. note::"},{"line_number":51,"context_line":"   Fixing Tempest tests with Python 3 is out of the scope of this spec.  Fixing"},{"line_number":52,"context_line":"   unit and functional tests with Python 3 should be enough to cover almost all"},{"line_number":53,"context_line":"   Python 3 issues."}],"source_content_type":"text/x-rst","patch_set":9,"id":"3acd31a7_bd328e5d","line":50,"updated":"2015-05-05 13:08:11.000000000","message":"-1 I wasn\u0027t clear but I expect all tempest tests to be running for Python3, in theory that should just happen once the unit tests are OK ;)\n\nI am not expecting you port tempest to py3 though.","commit_id":"e671ee51cd5f53a40180804d26f2fec71d2a1aed"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"01d71dcf95c5535f02d032b18760d534838ee170","unresolved":false,"context_lines":[{"line_number":47,"context_line":".. note::"},{"line_number":48,"context_line":"   Python 2 support is kept."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":".. note::"},{"line_number":51,"context_line":"   Fixing Tempest tests with Python 3 is out of the scope of this spec.  Fixing"},{"line_number":52,"context_line":"   unit and functional tests with Python 3 should be enough to cover almost all"},{"line_number":53,"context_line":"   Python 3 issues."}],"source_content_type":"text/x-rst","patch_set":9,"id":"3acd31a7_e253bd37","line":50,"in_reply_to":"3acd31a7_bd328e5d","updated":"2015-05-05 15:58:15.000000000","message":"Done","commit_id":"e671ee51cd5f53a40180804d26f2fec71d2a1aed"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6ad75ff1fe85c700127d99a072ebcbaa0528fe2f","unresolved":false,"context_lines":[{"line_number":164,"context_line":"  * Once all unit tests work, remove the whitelist of unit tests from"},{"line_number":165,"context_line":"    ``tox.ini``."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"* Functional tests:"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"  * Add a ``py34-functional`` test environment to ``tox.ini`` to run a"},{"line_number":170,"context_line":"    subtest of the functional tests which pass on Python 3. It will use a"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3acd31a7_bdc3aeec","line":167,"updated":"2015-05-05 13:08:11.000000000","message":"I was expecting all tempest tests to run as well, why did we exclude that?\n\nI think it\u0027s simpler to summarise this in one or two sentences. Unit tests, function tests, and tempest should be pass with nova running on py3.4","commit_id":"e671ee51cd5f53a40180804d26f2fec71d2a1aed"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"01d71dcf95c5535f02d032b18760d534838ee170","unresolved":false,"context_lines":[{"line_number":164,"context_line":"  * Once all unit tests work, remove the whitelist of unit tests from"},{"line_number":165,"context_line":"    ``tox.ini``."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"* Functional tests:"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"  * Add a ``py34-functional`` test environment to ``tox.ini`` to run a"},{"line_number":170,"context_line":"    subtest of the functional tests which pass on Python 3. It will use a"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3acd31a7_225e5544","line":167,"in_reply_to":"3acd31a7_bdc3aeec","updated":"2015-05-05 15:58:15.000000000","message":"Done","commit_id":"e671ee51cd5f53a40180804d26f2fec71d2a1aed"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ab411d6cfd98c057299cc510d62f991690b57fd8","unresolved":false,"context_lines":[{"line_number":152,"context_line":"* Fix failing tests, one by one, to enlarge the whitelist of tests"},{"line_number":153,"context_line":"  in ``tox.ini``."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"* Once all tests work, remove the whitelist of tests from ``tox.ini``."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"The transition period, when Python 3 is only supported partially, should be a"},{"line_number":158,"context_line":"short as possible."}],"source_content_type":"text/x-rst","patch_set":10,"id":"3acd31a7_a83da7de","line":155,"updated":"2015-05-05 16:38:45.000000000","message":"I guess we need to add make tempest tests pass.","commit_id":"ed4c86aafcf3bade600324d0985164ccd429f88c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ab411d6cfd98c057299cc510d62f991690b57fd8","unresolved":false,"context_lines":[{"line_number":160,"context_line":"No voting Python 3 gate jobs will be added to not waste resources of the"},{"line_number":161,"context_line":"OpenStack infra, Python 2 gate jobs are enough. We consider that there is a low"},{"line_number":162,"context_line":"risk of having a Python 3 specific issue introduced by a conflict between the"},{"line_number":163,"context_line":"Python 3 check job and the Python 2 gate job."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3acd31a7_e8cddf31","line":163,"updated":"2015-05-05 16:38:45.000000000","message":"I think we will need to gate on this vs just check.\n\nThis is a detail we can deal with later I feel. Lets just make sure the jobs pass here.","commit_id":"ed4c86aafcf3bade600324d0985164ccd429f88c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ab411d6cfd98c057299cc510d62f991690b57fd8","unresolved":false,"context_lines":[{"line_number":197,"context_line":"The current test suite should be enough to test Nova on Python 3."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"We will run tests with Nova running under Python 3.4 by the end of this"},{"line_number":200,"context_line":"process."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3acd31a7_c8ad8385","line":200,"updated":"2015-05-05 16:38:45.000000000","message":"OK, I would like to call out tempest and unit tests explicitly.\n\nBut I love this is much shorter and straight forward, thank you for that.","commit_id":"ed4c86aafcf3bade600324d0985164ccd429f88c"}],"specs/liberty/approved/port-nova-to-python3.rst":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"49c23e2140253b6d125b312ae074fbe42870ffa8","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"All Nova dependencies are now Python 3 compatible: see the"},{"line_number":18,"context_line":"Dependencies section below. It\u0027s time to port Nova to Python 3 which means"},{"line_number":19,"context_line":"adding Python 3 support without loosing Python 2 support."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Use Cases"},{"line_number":22,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_40577702","line":19,"updated":"2015-04-23 17:58:35.000000000","message":"\"losing\".","commit_id":"5c206fe4c15e5be0c3699d44c8aca3c5e0ca54cc"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"fb593308bcee7334d5dd7d994c5b1fc62026f5c9","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"All Nova dependencies are now Python 3 compatible: see the"},{"line_number":18,"context_line":"Dependencies section below. It\u0027s time to port Nova to Python 3 which means"},{"line_number":19,"context_line":"adding Python 3 support without loosing Python 2 support."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Use Cases"},{"line_number":22,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_21734217","line":19,"in_reply_to":"bab921fb_40577702","updated":"2015-04-24 08:23:02.000000000","message":"Done","commit_id":"5c206fe4c15e5be0c3699d44c8aca3c5e0ca54cc"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"49c23e2140253b6d125b312ae074fbe42870ffa8","unresolved":false,"context_lines":[{"line_number":27,"context_line":"not less than 15 new modules. Python 3 is already well supported by major Linux"},{"line_number":28,"context_line":"distributions. Slowly, some bugs cannot be fixed in Python 2.7 anymore and are"},{"line_number":29,"context_line":"only fixed in the latest Python 3 release. Python 3 is now 7 years old and"},{"line_number":30,"context_line":"considered as a mature programming language."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"The motivation to move away from Python 2 is the technical debt. OpenStack is"},{"line_number":33,"context_line":"one of the largest opensource project in term of lines of code, more than 2.5"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_80746f9c","line":30,"updated":"2015-04-23 17:58:35.000000000","message":"Kind of sounds like \"hey look at my language, isn\u0027t it the best ?\", doesn\u0027t it? :p","commit_id":"5c206fe4c15e5be0c3699d44c8aca3c5e0ca54cc"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"fb593308bcee7334d5dd7d994c5b1fc62026f5c9","unresolved":false,"context_lines":[{"line_number":27,"context_line":"not less than 15 new modules. Python 3 is already well supported by major Linux"},{"line_number":28,"context_line":"distributions. Slowly, some bugs cannot be fixed in Python 2.7 anymore and are"},{"line_number":29,"context_line":"only fixed in the latest Python 3 release. Python 3 is now 7 years old and"},{"line_number":30,"context_line":"considered as a mature programming language."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"The motivation to move away from Python 2 is the technical debt. OpenStack is"},{"line_number":33,"context_line":"one of the largest opensource project in term of lines of code, more than 2.5"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_01d4be1d","line":30,"in_reply_to":"bab921fb_80746f9c","updated":"2015-04-24 08:23:02.000000000","message":"It is the best.","commit_id":"5c206fe4c15e5be0c3699d44c8aca3c5e0ca54cc"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"49c23e2140253b6d125b312ae074fbe42870ffa8","unresolved":false,"context_lines":[{"line_number":30,"context_line":"considered as a mature programming language."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"The motivation to move away from Python 2 is the technical debt. OpenStack is"},{"line_number":33,"context_line":"one of the largest opensource project in term of lines of code, more than 2.5"},{"line_number":34,"context_line":"million lines of code. If an application is not updated to track evolution of"},{"line_number":35,"context_line":"new features, it dies slowly. A technical debt has a concrete price: the longer"},{"line_number":36,"context_line":"you wait to port OpenStack to Python 3, the more expensive the portage will be."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_e0656be1","line":33,"updated":"2015-04-23 17:58:35.000000000","message":"s/opensource/Free Software/","commit_id":"5c206fe4c15e5be0c3699d44c8aca3c5e0ca54cc"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"fb593308bcee7334d5dd7d994c5b1fc62026f5c9","unresolved":false,"context_lines":[{"line_number":30,"context_line":"considered as a mature programming language."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"The motivation to move away from Python 2 is the technical debt. OpenStack is"},{"line_number":33,"context_line":"one of the largest opensource project in term of lines of code, more than 2.5"},{"line_number":34,"context_line":"million lines of code. If an application is not updated to track evolution of"},{"line_number":35,"context_line":"new features, it dies slowly. A technical debt has a concrete price: the longer"},{"line_number":36,"context_line":"you wait to port OpenStack to Python 3, the more expensive the portage will be."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_01615e39","line":33,"in_reply_to":"bab921fb_e0656be1","updated":"2015-04-24 08:23:02.000000000","message":"Done","commit_id":"5c206fe4c15e5be0c3699d44c8aca3c5e0ca54cc"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"9665b22edaf04ff6d49471a9f98a23960afceb8b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"developers."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Switching to Python 3 will improve performances, reduce the number of"},{"line_number":49,"context_line":"dependencies, and more generally to make OpenStack more robust."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Read `Why should OpenStack move to Python 3 right now?"},{"line_number":52,"context_line":"\u003chttp://techs.enovance.com/6521/openstack_python3\u003e`_ for the full rationale."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_7a1c51c1","line":49,"range":{"start_line":49,"start_character":23,"end_line":49,"end_character":32},"updated":"2015-04-24 01:05:50.000000000","message":"I want to explore this part more, I\u0027ll put a comment at the top level.","commit_id":"5c206fe4c15e5be0c3699d44c8aca3c5e0ca54cc"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"49c23e2140253b6d125b312ae074fbe42870ffa8","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Switching to Python 3 will improve performances, reduce the number of"},{"line_number":49,"context_line":"dependencies, and more generally to make OpenStack more robust."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Read `Why should OpenStack move to Python 3 right now?"},{"line_number":52,"context_line":"\u003chttp://techs.enovance.com/6521/openstack_python3\u003e`_ for the full rationale."},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_60a03bf5","line":50,"updated":"2015-04-23 17:58:35.000000000","message":"-to","commit_id":"5c206fe4c15e5be0c3699d44c8aca3c5e0ca54cc"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"fb593308bcee7334d5dd7d994c5b1fc62026f5c9","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Switching to Python 3 will improve performances, reduce the number of"},{"line_number":49,"context_line":"dependencies, and more generally to make OpenStack more robust."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Read `Why should OpenStack move to Python 3 right now?"},{"line_number":52,"context_line":"\u003chttp://techs.enovance.com/6521/openstack_python3\u003e`_ for the full rationale."},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_e1630a40","line":50,"in_reply_to":"bab921fb_60a03bf5","updated":"2015-04-24 08:23:02.000000000","message":"Done","commit_id":"5c206fe4c15e5be0c3699d44c8aca3c5e0ca54cc"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"49c23e2140253b6d125b312ae074fbe42870ffa8","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Read `Why should OpenStack move to Python 3 right now?"},{"line_number":52,"context_line":"\u003chttp://techs.enovance.com/6521/openstack_python3\u003e`_ for the full rationale."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Project Priority"},{"line_number":56,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_a0b6533b","line":53,"updated":"2015-04-23 17:58:35.000000000","message":"Honestly, wouldn\u0027t a link to this blog post be enough? :p Feels like you are repeating it.","commit_id":"5c206fe4c15e5be0c3699d44c8aca3c5e0ca54cc"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"fb593308bcee7334d5dd7d994c5b1fc62026f5c9","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Read `Why should OpenStack move to Python 3 right now?"},{"line_number":52,"context_line":"\u003chttp://techs.enovance.com/6521/openstack_python3\u003e`_ for the full rationale."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Project Priority"},{"line_number":56,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_a1ae3296","line":53,"in_reply_to":"bab921fb_a0b6533b","updated":"2015-04-24 08:23:02.000000000","message":"I consider that reading the spec should be enough to take a decision. You should not have to follow each link.","commit_id":"5c206fe4c15e5be0c3699d44c8aca3c5e0ca54cc"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"49c23e2140253b6d125b312ae074fbe42870ffa8","unresolved":false,"context_lines":[{"line_number":66,"context_line":"The goal here is to be able to run the full Nova test suite with Python 3.4."},{"line_number":67,"context_line":"It\u0027s unclear at this point if it will be possible to finish the port during the"},{"line_number":68,"context_line":"Liberty cycle."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"We will also need to run Nova in a DevStack that uses Python 3.4."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_407c1772","line":69,"updated":"2015-04-23 17:58:35.000000000","message":"Why?","commit_id":"5c206fe4c15e5be0c3699d44c8aca3c5e0ca54cc"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"fb593308bcee7334d5dd7d994c5b1fc62026f5c9","unresolved":false,"context_lines":[{"line_number":66,"context_line":"The goal here is to be able to run the full Nova test suite with Python 3.4."},{"line_number":67,"context_line":"It\u0027s unclear at this point if it will be possible to finish the port during the"},{"line_number":68,"context_line":"Liberty cycle."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"We will also need to run Nova in a DevStack that uses Python 3.4."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_21c0e229","line":69,"in_reply_to":"bab921fb_407c1772","updated":"2015-04-24 08:23:02.000000000","message":"If it takes 2 to 3 months to review each minor patch, it would not be possible to merge all Python 3 changes in a single cycle.\n\nJoe Gordon proposed a focus on Python 3 during one or two weeks (a \"virtual sprint\").","commit_id":"5c206fe4c15e5be0c3699d44c8aca3c5e0ca54cc"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"9665b22edaf04ff6d49471a9f98a23960afceb8b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"The goal here is to be able to run the full Nova test suite with Python 3.4."},{"line_number":67,"context_line":"It\u0027s unclear at this point if it will be possible to finish the port during the"},{"line_number":68,"context_line":"Liberty cycle."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"We will also need to run Nova in a DevStack that uses Python 3.4."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_ba69c927","line":69,"in_reply_to":"bab921fb_407c1772","updated":"2015-04-24 01:05:50.000000000","message":"Without any data on how much we need to do, I\u0027d expect a lot of code churn associated with this, which means lots of reviews, which means it will take a while to merge.","commit_id":"5c206fe4c15e5be0c3699d44c8aca3c5e0ca54cc"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"9665b22edaf04ff6d49471a9f98a23960afceb8b","unresolved":false,"context_lines":[{"line_number":67,"context_line":"It\u0027s unclear at this point if it will be possible to finish the port during the"},{"line_number":68,"context_line":"Liberty cycle."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"We will also need to run Nova in a DevStack that uses Python 3.4."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Alternatives"},{"line_number":73,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_1a5b1589","line":70,"range":{"start_line":70,"start_character":13,"end_line":70,"end_character":17},"updated":"2015-04-24 01:05:50.000000000","message":"What is the state of python 3.4 support in the gate?","commit_id":"5c206fe4c15e5be0c3699d44c8aca3c5e0ca54cc"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"fb593308bcee7334d5dd7d994c5b1fc62026f5c9","unresolved":false,"context_lines":[{"line_number":67,"context_line":"It\u0027s unclear at this point if it will be possible to finish the port during the"},{"line_number":68,"context_line":"Liberty cycle."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"We will also need to run Nova in a DevStack that uses Python 3.4."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Alternatives"},{"line_number":73,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_c1992670","line":70,"in_reply_to":"bab921fb_1a5b1589","updated":"2015-04-24 08:23:02.000000000","message":"Currently, it\u0027s not possible to load tests on Python 3, because there are too many Python 3 syntax issues. So a py34 gate would be completly useless.\n\nWith my early patch (*), I already see some tests which pass on Python 3. Joe Gordon wrote \"Overall that is a pretty small patch.\"\n\n(*) https://github.com/haypo/nova/commit/bad54bc2b278c7c7cb7fa6cc73d03c70138bd89d","commit_id":"5c206fe4c15e5be0c3699d44c8aca3c5e0ca54cc"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"49c23e2140253b6d125b312ae074fbe42870ffa8","unresolved":false,"context_lines":[{"line_number":68,"context_line":"Liberty cycle."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"We will also need to run Nova in a DevStack that uses Python 3.4."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Alternatives"},{"line_number":73,"context_line":"------------"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_80822f51","line":71,"updated":"2015-04-23 17:58:35.000000000","message":"Can we really run a full-py34 devstack ?","commit_id":"5c206fe4c15e5be0c3699d44c8aca3c5e0ca54cc"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"fb593308bcee7334d5dd7d994c5b1fc62026f5c9","unresolved":false,"context_lines":[{"line_number":68,"context_line":"Liberty cycle."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"We will also need to run Nova in a DevStack that uses Python 3.4."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Alternatives"},{"line_number":73,"context_line":"------------"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_a1851208","line":71,"in_reply_to":"bab921fb_80822f51","updated":"2015-04-24 08:23:02.000000000","message":"I have no idea.","commit_id":"5c206fe4c15e5be0c3699d44c8aca3c5e0ca54cc"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"49c23e2140253b6d125b312ae074fbe42870ffa8","unresolved":false,"context_lines":[{"line_number":133,"context_line":"  frozenset is stored as a pre-built constant."},{"line_number":134,"context_line":"* Common text codecs (ASCII, Latin1, UTF-8) are two to four times faster."},{"line_number":135,"context_line":"* The ``json`` module now has a C extension to substantially improve its"},{"line_number":136,"context_line":"  performance."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Other Python 3 changes made Python 3 slower on some operations. To be fair,"},{"line_number":139,"context_line":"overall performances of Python 3.3 are *almost the same* than Python 2.7"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_00de1f6d","line":136,"updated":"2015-04-23 17:58:35.000000000","message":"I\u0027ll trust you on that.","commit_id":"5c206fe4c15e5be0c3699d44c8aca3c5e0ca54cc"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"49c23e2140253b6d125b312ae074fbe42870ffa8","unresolved":false,"context_lines":[{"line_number":136,"context_line":"  performance."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Other Python 3 changes made Python 3 slower on some operations. To be fair,"},{"line_number":139,"context_line":"overall performances of Python 3.3 are *almost the same* than Python 2.7"},{"line_number":140,"context_line":"performances. But some functions in Nova can now be much faster on Python 3."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"See the \"Optimizations\" section of each \"What\u0027s New in Python 3.x\" document for"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_60d5db41","line":139,"updated":"2015-04-23 17:58:35.000000000","message":"s/than/as/","commit_id":"5c206fe4c15e5be0c3699d44c8aca3c5e0ca54cc"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"fb593308bcee7334d5dd7d994c5b1fc62026f5c9","unresolved":false,"context_lines":[{"line_number":136,"context_line":"  performance."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Other Python 3 changes made Python 3 slower on some operations. To be fair,"},{"line_number":139,"context_line":"overall performances of Python 3.3 are *almost the same* than Python 2.7"},{"line_number":140,"context_line":"performances. But some functions in Nova can now be much faster on Python 3."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"See the \"Optimizations\" section of each \"What\u0027s New in Python 3.x\" document for"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_61501a5f","line":139,"in_reply_to":"bab921fb_60d5db41","updated":"2015-04-24 08:23:02.000000000","message":"Done","commit_id":"5c206fe4c15e5be0c3699d44c8aca3c5e0ca54cc"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"49c23e2140253b6d125b312ae074fbe42870ffa8","unresolved":false,"context_lines":[{"line_number":178,"context_line":"----------"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"* Finish the work on porting Nova dependencies to Python 3: it\u0027s almost done"},{"line_number":181,"context_line":"  and it\u0027s moving fast."},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"* Fix most obvious Python 3 issues. Example of change fixing most issues"},{"line_number":184,"context_line":"  in a single commit: `Port to Python 3"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_a0bbf30d","line":181,"updated":"2015-04-23 17:58:35.000000000","message":"Could you add \"See \u0027Dependencies\u0027\" here?","commit_id":"5c206fe4c15e5be0c3699d44c8aca3c5e0ca54cc"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"fb593308bcee7334d5dd7d994c5b1fc62026f5c9","unresolved":false,"context_lines":[{"line_number":178,"context_line":"----------"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"* Finish the work on porting Nova dependencies to Python 3: it\u0027s almost done"},{"line_number":181,"context_line":"  and it\u0027s moving fast."},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"* Fix most obvious Python 3 issues. Example of change fixing most issues"},{"line_number":184,"context_line":"  in a single commit: `Port to Python 3"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_a18632d9","line":181,"in_reply_to":"bab921fb_3acb7920","updated":"2015-04-24 08:23:02.000000000","message":"\u003e But you say its complete above?\n\nThere is a difference between \"complete\" and \"almost complete\" :-) Some projects are fixed in the development version, but we still need a release.\n\noslo.messaging patches are blocking by the freeze on OpenStack requirements because of the Kilo release. The situation should be unblocked at the beginning of the Liberty cycle.","commit_id":"5c206fe4c15e5be0c3699d44c8aca3c5e0ca54cc"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"9665b22edaf04ff6d49471a9f98a23960afceb8b","unresolved":false,"context_lines":[{"line_number":178,"context_line":"----------"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"* Finish the work on porting Nova dependencies to Python 3: it\u0027s almost done"},{"line_number":181,"context_line":"  and it\u0027s moving fast."},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"* Fix most obvious Python 3 issues. Example of change fixing most issues"},{"line_number":184,"context_line":"  in a single commit: `Port to Python 3"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_3acb7920","line":181,"in_reply_to":"bab921fb_a0bbf30d","updated":"2015-04-24 01:05:50.000000000","message":"But you say its complete above?","commit_id":"5c206fe4c15e5be0c3699d44c8aca3c5e0ca54cc"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"fb593308bcee7334d5dd7d994c5b1fc62026f5c9","unresolved":false,"context_lines":[{"line_number":178,"context_line":"----------"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"* Finish the work on porting Nova dependencies to Python 3: it\u0027s almost done"},{"line_number":181,"context_line":"  and it\u0027s moving fast."},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"* Fix most obvious Python 3 issues. Example of change fixing most issues"},{"line_number":184,"context_line":"  in a single commit: `Port to Python 3"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_214a22ad","line":181,"in_reply_to":"bab921fb_a0bbf30d","updated":"2015-04-24 08:23:02.000000000","message":"Done","commit_id":"5c206fe4c15e5be0c3699d44c8aca3c5e0ca54cc"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"2633c47a7cf318ec6809d60fb5b7b5d0c130b863","unresolved":false,"context_lines":[{"line_number":110,"context_line":"external resources like databases, libvirtd, RPC calls to other components like"},{"line_number":111,"context_line":"Neutron, Keystone, Cinder, etc. Even inside Nova, Nova uses libraries"},{"line_number":112,"context_line":"implemented in C like libvirt, so the percent of time spent on executing pure"},{"line_number":113,"context_line":"Python bytecode is low."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"In March 2013, Brett Canon ran `the Python benchmarks suite"},{"line_number":116,"context_line":"\u003chttps://hg.python.org/benchmarks\u003e`_ to compare Python 2.7 and 3.3. The result"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bab921fb_f9585efc","line":113,"updated":"2015-04-24 09:34:46.000000000","message":"I would argue that this is actually not true - and that in Nova there are several places where CPU is the bottleneck.\n\nNot relevant to this spec though","commit_id":"c505b56864dc436770127650ac1a239c9f460bf9"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"90e7937563e85eb4f4be1437d66484e996a8b65b","unresolved":false,"context_lines":[{"line_number":110,"context_line":"external resources like databases, libvirtd, RPC calls to other components like"},{"line_number":111,"context_line":"Neutron, Keystone, Cinder, etc. Even inside Nova, Nova uses libraries"},{"line_number":112,"context_line":"implemented in C like libvirt, so the percent of time spent on executing pure"},{"line_number":113,"context_line":"Python bytecode is low."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"In March 2013, Brett Canon ran `the Python benchmarks suite"},{"line_number":116,"context_line":"\u003chttps://hg.python.org/benchmarks\u003e`_ to compare Python 2.7 and 3.3. The result"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9abe1de1_795b7a55","line":113,"in_reply_to":"bab921fb_5cc6119b","updated":"2015-04-27 12:55:39.000000000","message":"Done","commit_id":"c505b56864dc436770127650ac1a239c9f460bf9"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"029aa8e01888964545e71784d307013552a9bf97","unresolved":false,"context_lines":[{"line_number":110,"context_line":"external resources like databases, libvirtd, RPC calls to other components like"},{"line_number":111,"context_line":"Neutron, Keystone, Cinder, etc. Even inside Nova, Nova uses libraries"},{"line_number":112,"context_line":"implemented in C like libvirt, so the percent of time spent on executing pure"},{"line_number":113,"context_line":"Python bytecode is low."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"In March 2013, Brett Canon ran `the Python benchmarks suite"},{"line_number":116,"context_line":"\u003chttps://hg.python.org/benchmarks\u003e`_ to compare Python 2.7 and 3.3. The result"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bab921fb_5cc6119b","line":113,"in_reply_to":"bab921fb_cf9cac5f","updated":"2015-04-24 11:42:03.000000000","message":"I dropped this paragraph. I agree that it\u0027s not very interesting to discuss how Nova uses Python. IMO saying that Python 3 has the same performances than Python 2 and that there is no impact on performances is enough.","commit_id":"c505b56864dc436770127650ac1a239c9f460bf9"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"9f5042cb8e5d435d7ab0fa049a4a3d3df7a5e1bd","unresolved":false,"context_lines":[{"line_number":110,"context_line":"external resources like databases, libvirtd, RPC calls to other components like"},{"line_number":111,"context_line":"Neutron, Keystone, Cinder, etc. Even inside Nova, Nova uses libraries"},{"line_number":112,"context_line":"implemented in C like libvirt, so the percent of time spent on executing pure"},{"line_number":113,"context_line":"Python bytecode is low."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"In March 2013, Brett Canon ran `the Python benchmarks suite"},{"line_number":116,"context_line":"\u003chttps://hg.python.org/benchmarks\u003e`_ to compare Python 2.7 and 3.3. The result"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bab921fb_cf9cac5f","line":113,"in_reply_to":"bab921fb_f9585efc","updated":"2015-04-24 09:48:51.000000000","message":"Do you suggest this simply drop this paragraph?","commit_id":"c505b56864dc436770127650ac1a239c9f460bf9"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"2633c47a7cf318ec6809d60fb5b7b5d0c130b863","unresolved":false,"context_lines":[{"line_number":214,"context_line":"  - replace ``StringIO()`` with ``six.StringIO()``"},{"line_number":215,"context_line":"  - replace ``unichr()`` with ``six.unichr()``"},{"line_number":216,"context_line":"  - see also the `Python 3 wiki page"},{"line_number":217,"context_line":"    \u003chttps://wiki.openstack.org/wiki/Python3\u003e`_"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"* Add a ``py34`` test environment to ``tox.ini`` to run a subtest of the test"},{"line_number":220,"context_line":"  suite which pass on Python 3."}],"source_content_type":"text/x-rst","patch_set":2,"id":"bab921fb_ef6e50c8","line":217,"updated":"2015-04-24 09:34:46.000000000","message":"I\u0027d argue that this spec proposes to make nova run on python 3 instead of porting it. It proposes using six everywhere which completely negates any syntax improvements (actually I\u0027ll argue it makes it much worse).\n\nBeing python 3 compatible is the right thing to do, and I am all for this, but we should call things what they are.","commit_id":"c505b56864dc436770127650ac1a239c9f460bf9"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"c6030b6a255e67615698967e4b748b58f74e6c5b","unresolved":false,"context_lines":[{"line_number":214,"context_line":"  - replace ``StringIO()`` with ``six.StringIO()``"},{"line_number":215,"context_line":"  - replace ``unichr()`` with ``six.unichr()``"},{"line_number":216,"context_line":"  - see also the `Python 3 wiki page"},{"line_number":217,"context_line":"    \u003chttps://wiki.openstack.org/wiki/Python3\u003e`_"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"* Add a ``py34`` test environment to ``tox.ini`` to run a subtest of the test"},{"line_number":220,"context_line":"  suite which pass on Python 3."}],"source_content_type":"text/x-rst","patch_set":2,"id":"bab921fb_da8564ad","line":217,"in_reply_to":"bab921fb_1a9d1c59","updated":"2015-04-24 21:12:12.000000000","message":"Does this really matter that much :-/\n\nMeh, who cares...","commit_id":"c505b56864dc436770127650ac1a239c9f460bf9"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"f5a889e5a40930cb5c905e7c1a4f9a97546c28c2","unresolved":false,"context_lines":[{"line_number":214,"context_line":"  - replace ``StringIO()`` with ``six.StringIO()``"},{"line_number":215,"context_line":"  - replace ``unichr()`` with ``six.unichr()``"},{"line_number":216,"context_line":"  - see also the `Python 3 wiki page"},{"line_number":217,"context_line":"    \u003chttps://wiki.openstack.org/wiki/Python3\u003e`_"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"* Add a ``py34`` test environment to ``tox.ini`` to run a subtest of the test"},{"line_number":220,"context_line":"  suite which pass on Python 3."}],"source_content_type":"text/x-rst","patch_set":2,"id":"bab921fb_1a9d1c59","line":217,"in_reply_to":"bab921fb_ef6e50c8","updated":"2015-04-24 21:01:54.000000000","message":"\"we should call things what they are\"\n\nWhat do you suggest to make the spec more explicit?\n\nShould I change the title? If yes, do you have suggestions please?\n\nOr maybe rephrase the introduction to mention six?\n\nWhat do you prefer?","commit_id":"c505b56864dc436770127650ac1a239c9f460bf9"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"90e7937563e85eb4f4be1437d66484e996a8b65b","unresolved":false,"context_lines":[{"line_number":214,"context_line":"  - replace ``StringIO()`` with ``six.StringIO()``"},{"line_number":215,"context_line":"  - replace ``unichr()`` with ``six.unichr()``"},{"line_number":216,"context_line":"  - see also the `Python 3 wiki page"},{"line_number":217,"context_line":"    \u003chttps://wiki.openstack.org/wiki/Python3\u003e`_"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"* Add a ``py34`` test environment to ``tox.ini`` to run a subtest of the test"},{"line_number":220,"context_line":"  suite which pass on Python 3."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9abe1de1_19311e0c","line":217,"in_reply_to":"bab921fb_ef6e50c8","updated":"2015-04-27 12:55:39.000000000","message":"Done","commit_id":"c505b56864dc436770127650ac1a239c9f460bf9"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"9f5042cb8e5d435d7ab0fa049a4a3d3df7a5e1bd","unresolved":false,"context_lines":[{"line_number":214,"context_line":"  - replace ``StringIO()`` with ``six.StringIO()``"},{"line_number":215,"context_line":"  - replace ``unichr()`` with ``six.unichr()``"},{"line_number":216,"context_line":"  - see also the `Python 3 wiki page"},{"line_number":217,"context_line":"    \u003chttps://wiki.openstack.org/wiki/Python3\u003e`_"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"* Add a ``py34`` test environment to ``tox.ini`` to run a subtest of the test"},{"line_number":220,"context_line":"  suite which pass on Python 3."}],"source_content_type":"text/x-rst","patch_set":2,"id":"bab921fb_4f453cb1","line":217,"in_reply_to":"bab921fb_ef6e50c8","updated":"2015-04-24 09:48:51.000000000","message":"For Python 3, the usual definition of \"porting to Python 3\" is to add Python 3 compatibility in addition to Python 2 compatibility, so write a single code base compatible with Python 2 \u0026 3 using the six module.\n\nI elaborate the title in the introduction of the spec: \"It\u0027s time to port Nova to Python 3 which means *adding Python 3 support without losing Python 2 support*.\"\n\n\u003e It proposes using six everywhere which completely negates any syntax improvements (actually I\u0027ll argue it makes it much worse).\n\nNova already uses six, it\u0027s not something new. Six is the compromize made by almost 100% Python 3 libraries and applications, and it\u0027s also the choice made in OpenStack:\nhttps://wiki.openstack.org/wiki/Python3#Port_Python_2_code_to_Python_3","commit_id":"c505b56864dc436770127650ac1a239c9f460bf9"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8264996e0fbcd024d88d69a7e920720c7c6ed675","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Port Nova to Python 3"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/nova-python3"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9abe1de1_abec2190","line":8,"updated":"2015-04-27 10:26:15.000000000","message":"I think its worth renaming this to something like:\n\nAdding Python 3.4 support to Nova\n\nIt makes it clear there are no immediate plans to remove support for python 2.7, which feels like the right call here.","commit_id":"f2ec92727e9572d91676c43c72e583e99a08f953"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"3a4da545212c385ca198632bbdcf548657dd2c1b","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Port Nova to Python 3"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/nova-python3"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9abe1de1_99252ec4","line":8,"in_reply_to":"9abe1de1_abec2190","updated":"2015-04-27 13:02:56.000000000","message":"Done","commit_id":"f2ec92727e9572d91676c43c72e583e99a08f953"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"1b5f1ee7f923b9a1350d8a1808c1ee1a271cb14e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"longer you wait to port OpenStack to Python 3, the more expensive the portage"},{"line_number":37,"context_line":"will be."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Linux distributions want to slowly remove Python 2 and stop supporting it."},{"line_number":40,"context_line":"Python 2.7 has more and more bugs, some bugs cannot be fixed anymore. If"},{"line_number":41,"context_line":"OpenStack is not ported on Python 3, it will be more and more difficult to"},{"line_number":42,"context_line":"maintain it in a near future."}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab921fb_baf3d09d","line":39,"updated":"2015-04-24 21:43:39.000000000","message":"Suggestion:\n\nFor example, in Debian, the plan is to deprecate Python 2 in Stretch (aka: Debian 9, the next Stable Debian after Jessie) and to completely remove Python 2 for the Buster release of Debian (aka: Debian 10, to be release in approximatively 4 years).","commit_id":"f2ec92727e9572d91676c43c72e583e99a08f953"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"3a4da545212c385ca198632bbdcf548657dd2c1b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"longer you wait to port OpenStack to Python 3, the more expensive the portage"},{"line_number":37,"context_line":"will be."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Linux distributions want to slowly remove Python 2 and stop supporting it."},{"line_number":40,"context_line":"Python 2.7 has more and more bugs, some bugs cannot be fixed anymore. If"},{"line_number":41,"context_line":"OpenStack is not ported on Python 3, it will be more and more difficult to"},{"line_number":42,"context_line":"maintain it in a near future."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9abe1de1_b916b253","line":39,"in_reply_to":"bab921fb_baf3d09d","updated":"2015-04-27 13:02:56.000000000","message":"Thanks for the information. I added a section in the wiki page:\nhttps://wiki.openstack.org/wiki/Python3#Status_of_Python_3_in_Linux_distributions\n\nI added a link from the spec to the wiki page.","commit_id":"f2ec92727e9572d91676c43c72e583e99a08f953"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"c67112fc7812f6d3e8e09de2d5f7b197620294ea","unresolved":false,"context_lines":[{"line_number":50,"context_line":"more robust."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Read `Why should OpenStack move to Python 3 right now?"},{"line_number":53,"context_line":"\u003chttp://techs.enovance.com/6521/openstack_python3\u003e`_ for the full rationale."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Project Priority"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab921fb_e8cce36b","line":53,"range":{"start_line":53,"start_character":2,"end_line":53,"end_character":49},"updated":"2015-04-24 21:56:03.000000000","message":"nice section, this preempted all my planned complaints about python3 being bamboozled.","commit_id":"f2ec92727e9572d91676c43c72e583e99a08f953"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"3a4da545212c385ca198632bbdcf548657dd2c1b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"more robust."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Read `Why should OpenStack move to Python 3 right now?"},{"line_number":53,"context_line":"\u003chttp://techs.enovance.com/6521/openstack_python3\u003e`_ for the full rationale."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Project Priority"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9abe1de1_990c0e44","line":53,"in_reply_to":"bab921fb_e8cce36b","updated":"2015-04-27 13:02:56.000000000","message":"Cool :-)","commit_id":"f2ec92727e9572d91676c43c72e583e99a08f953"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"c67112fc7812f6d3e8e09de2d5f7b197620294ea","unresolved":false,"context_lines":[{"line_number":68,"context_line":"It\u0027s unclear at this point if it will be possible to finish the port during the"},{"line_number":69,"context_line":"Liberty cycle."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"We will also need to run Nova in a DevStack that uses Python 3.4."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Alternatives"},{"line_number":74,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab921fb_28fc1b71","line":71,"updated":"2015-04-24 21:56:03.000000000","message":"maybe worth clarifying that we want to support python3.4 in addition to python2.7 and not instead of.","commit_id":"f2ec92727e9572d91676c43c72e583e99a08f953"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"3a4da545212c385ca198632bbdcf548657dd2c1b","unresolved":false,"context_lines":[{"line_number":68,"context_line":"It\u0027s unclear at this point if it will be possible to finish the port during the"},{"line_number":69,"context_line":"Liberty cycle."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"We will also need to run Nova in a DevStack that uses Python 3.4."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Alternatives"},{"line_number":74,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9abe1de1_79093a31","line":71,"in_reply_to":"bab921fb_28fc1b71","updated":"2015-04-27 13:02:56.000000000","message":"Done","commit_id":"f2ec92727e9572d91676c43c72e583e99a08f953"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"f68846f28a3580928302bab9a554ddffdb8d91c2","unresolved":false,"context_lines":[{"line_number":68,"context_line":"It\u0027s unclear at this point if it will be possible to finish the port during the"},{"line_number":69,"context_line":"Liberty cycle."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"We will also need to run Nova in a DevStack that uses Python 3.4."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Alternatives"},{"line_number":74,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab921fb_ee196489","line":71,"in_reply_to":"bab921fb_28fc1b71","updated":"2015-04-25 15:26:21.000000000","message":"Since Nikola Dipanov wrote a similar comment on the patch set 2, I will change the spec to be more explicit: the spec adds python 3 support to nova by generalizing the usage of the six module.","commit_id":"f2ec92727e9572d91676c43c72e583e99a08f953"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"c67112fc7812f6d3e8e09de2d5f7b197620294ea","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"In short, there is no impact on performances, sorry!"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"In March 2013, Brett Canon ran `the Python benchmarks suite"},{"line_number":111,"context_line":"\u003chttps://hg.python.org/benchmarks\u003e`_ to compare Python 2.7 and 3.3. The result"},{"line_number":112,"context_line":"is unexpected: \"If you sorted all of the benchmarks and looked at the median"},{"line_number":113,"context_line":"result ... Python 3 is the same\". See his slides: `Python 3.3: Trust Me, It\u0027s"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab921fb_687b33f6","line":110,"updated":"2015-04-24 21:56:03.000000000","message":"the rest is this is great to have, but I think the first line plus some references is enough.","commit_id":"f2ec92727e9572d91676c43c72e583e99a08f953"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8264996e0fbcd024d88d69a7e920720c7c6ed675","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"In short, there is no impact on performances, sorry!"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"In March 2013, Brett Canon ran `the Python benchmarks suite"},{"line_number":111,"context_line":"\u003chttps://hg.python.org/benchmarks\u003e`_ to compare Python 2.7 and 3.3. The result"},{"line_number":112,"context_line":"is unexpected: \"If you sorted all of the benchmarks and looked at the median"},{"line_number":113,"context_line":"result ... Python 3 is the same\". See his slides: `Python 3.3: Trust Me, It\u0027s"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9abe1de1_ebba19c0","line":110,"in_reply_to":"bab921fb_687b33f6","updated":"2015-04-27 10:26:15.000000000","message":"+1 to joe\u0027s comments here.","commit_id":"f2ec92727e9572d91676c43c72e583e99a08f953"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"3a4da545212c385ca198632bbdcf548657dd2c1b","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"In short, there is no impact on performances, sorry!"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"In March 2013, Brett Canon ran `the Python benchmarks suite"},{"line_number":111,"context_line":"\u003chttps://hg.python.org/benchmarks\u003e`_ to compare Python 2.7 and 3.3. The result"},{"line_number":112,"context_line":"is unexpected: \"If you sorted all of the benchmarks and looked at the median"},{"line_number":113,"context_line":"result ... Python 3 is the same\". See his slides: `Python 3.3: Trust Me, It\u0027s"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9abe1de1_59067621","line":110,"in_reply_to":"bab921fb_687b33f6","updated":"2015-04-27 13:02:56.000000000","message":"Done","commit_id":"f2ec92727e9572d91676c43c72e583e99a08f953"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"f68846f28a3580928302bab9a554ddffdb8d91c2","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"In short, there is no impact on performances, sorry!"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"In March 2013, Brett Canon ran `the Python benchmarks suite"},{"line_number":111,"context_line":"\u003chttps://hg.python.org/benchmarks\u003e`_ to compare Python 2.7 and 3.3. The result"},{"line_number":112,"context_line":"is unexpected: \"If you sorted all of the benchmarks and looked at the median"},{"line_number":113,"context_line":"result ... Python 3 is the same\". See his slides: `Python 3.3: Trust Me, It\u0027s"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab921fb_810bd923","line":110,"in_reply_to":"bab921fb_687b33f6","updated":"2015-04-25 15:26:21.000000000","message":"Ok, I will simplify this section. I can for example remove the detailed list of performance enhancements. I can just mention the \"Python 3 is fast\" of http://techs.enovance.com/6521/openstack_python3 since I just copied the list from this article (that I wrote one year ago).","commit_id":"f2ec92727e9572d91676c43c72e583e99a08f953"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"9ebb34219d1dbaaaa50945d282225c6ca285f5ce","unresolved":false,"context_lines":[{"line_number":142,"context_line":"  frozenset is stored as a pre-built constant."},{"line_number":143,"context_line":"* Common text codecs (ASCII, Latin1, UTF-8) are two to four times faster."},{"line_number":144,"context_line":"* The ``json`` module now has a C extension to substantially improve its"},{"line_number":145,"context_line":"  performance."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"See the \"Optimizations\" section of each \"What\u0027s New in Python 3.x\" document for"},{"line_number":148,"context_line":"the full list of optimizations: `Python 3.1"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab921fb_3a9a2064","line":145,"updated":"2015-04-24 21:02:59.000000000","message":"I thought the GC also got better to?","commit_id":"f2ec92727e9572d91676c43c72e583e99a08f953"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"f68846f28a3580928302bab9a554ddffdb8d91c2","unresolved":false,"context_lines":[{"line_number":142,"context_line":"  frozenset is stored as a pre-built constant."},{"line_number":143,"context_line":"* Common text codecs (ASCII, Latin1, UTF-8) are two to four times faster."},{"line_number":144,"context_line":"* The ``json`` module now has a C extension to substantially improve its"},{"line_number":145,"context_line":"  performance."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"See the \"Optimizations\" section of each \"What\u0027s New in Python 3.x\" document for"},{"line_number":148,"context_line":"the full list of optimizations: `Python 3.1"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab921fb_c1531116","line":145,"in_reply_to":"bab921fb_3a9a2064","updated":"2015-04-25 15:26:21.000000000","message":"I recall something related to stop tracking some objects to reduce the pressure on the garbage collector.\n\nOh, and the PEP 442 kicks ass, it simply removes a whole class of bugs in Python aplications:\nhttps://www.python.org/dev/peps/pep-0442/\nIt reduces a lot the risk of memory leak because of reference cycles.\n\nI cannot copy/paste the What\u0027s New in Python 3.0/3.1/3.2/3.3/3.4 (and 3.5 in a few months), these documents are very long :-)","commit_id":"f2ec92727e9572d91676c43c72e583e99a08f953"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"c67112fc7812f6d3e8e09de2d5f7b197620294ea","unresolved":false,"context_lines":[{"line_number":164,"context_line":"----------------"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Once Nova has been ported to Python 3, developers will not able to write code"},{"line_number":167,"context_line":"that only works with Python 2."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab921fb_085dd778","line":167,"updated":"2015-04-24 21:56:03.000000000","message":"maybe worth pointing out tox makes testing 2 and 3 locally trivial?","commit_id":"f2ec92727e9572d91676c43c72e583e99a08f953"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"3a4da545212c385ca198632bbdcf548657dd2c1b","unresolved":false,"context_lines":[{"line_number":164,"context_line":"----------------"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Once Nova has been ported to Python 3, developers will not able to write code"},{"line_number":167,"context_line":"that only works with Python 2."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9abe1de1_14044513","line":167,"in_reply_to":"bab921fb_085dd778","updated":"2015-04-27 13:02:56.000000000","message":"Done","commit_id":"f2ec92727e9572d91676c43c72e583e99a08f953"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"f68846f28a3580928302bab9a554ddffdb8d91c2","unresolved":false,"context_lines":[{"line_number":164,"context_line":"----------------"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Once Nova has been ported to Python 3, developers will not able to write code"},{"line_number":167,"context_line":"that only works with Python 2."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab921fb_61432543","line":167,"in_reply_to":"bab921fb_085dd778","updated":"2015-04-25 15:26:21.000000000","message":"Ok, I will mention that.\n\nI regulary uses tox -e py27,py34.","commit_id":"f2ec92727e9572d91676c43c72e583e99a08f953"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"c67112fc7812f6d3e8e09de2d5f7b197620294ea","unresolved":false,"context_lines":[{"line_number":180,"context_line":"  None"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"Work Items"},{"line_number":183,"context_line":"----------"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"* Finish the work on porting Nova dependencies to Python 3: it\u0027s almost done"},{"line_number":186,"context_line":"  and it\u0027s moving fast. See the Dependencies section. Currently, some patches"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab921fb_08471778","line":183,"updated":"2015-04-24 21:56:03.000000000","message":"So I would like to see us have partial python3 support for the least amount of time possible.\n\nOnce we have a py34 test environment it becomes easy to enforce python3 compliance. But having partial python3 support is difficult. \n\nI would like to see this section (or a different one in this spec) explore the possible migration paths and which one will be the quickest.\n\nI personally like the idea of a virtual sprint to add python34. Something along the lines of. One person works on the low hanging fruit work before the sprint. Get a few cores together, land the low hanging fruit. And quickly iterate to get all the unit tests working under python3.\n\nIf this isn\u0027t an option we need a decent way of setting up a programmatic way to check python3 compliance for new code. And how to roll out partial support over time.\n\nOne possibly useful test could be, does this file pass the python3","commit_id":"f2ec92727e9572d91676c43c72e583e99a08f953"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"99594513f560e867054a510461778ce2f8c38044","unresolved":false,"context_lines":[{"line_number":180,"context_line":"  None"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"Work Items"},{"line_number":183,"context_line":"----------"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"* Finish the work on porting Nova dependencies to Python 3: it\u0027s almost done"},{"line_number":186,"context_line":"  and it\u0027s moving fast. See the Dependencies section. Currently, some patches"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9abe1de1_711dd80e","line":183,"in_reply_to":"9abe1de1_069b04cb","updated":"2015-04-27 10:46:40.000000000","message":"Right - so basically we want to figure how to make sure we actually converge, without landing a massive one shot patch (fix all the things) - which to me seems to imply that we need some kind of a way to progress in steps but also make sure we are not regressing elsewhere.","commit_id":"f2ec92727e9572d91676c43c72e583e99a08f953"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8264996e0fbcd024d88d69a7e920720c7c6ed675","unresolved":false,"context_lines":[{"line_number":180,"context_line":"  None"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"Work Items"},{"line_number":183,"context_line":"----------"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"* Finish the work on porting Nova dependencies to Python 3: it\u0027s almost done"},{"line_number":186,"context_line":"  and it\u0027s moving fast. See the Dependencies section. Currently, some patches"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9abe1de1_069b04cb","line":183,"in_reply_to":"9abe1de1_ba258d5d","updated":"2015-04-27 10:26:15.000000000","message":"Surely, what we are talking about is just making sure we don\u0027t live in the land of partial support for py34 for too long, we want full support for py34 as quickly as possible.\n\nThis doesn\u0027t impact the fact we need to keep py27 support working during this transition.","commit_id":"f2ec92727e9572d91676c43c72e583e99a08f953"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"f68846f28a3580928302bab9a554ddffdb8d91c2","unresolved":false,"context_lines":[{"line_number":180,"context_line":"  None"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"Work Items"},{"line_number":183,"context_line":"----------"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"* Finish the work on porting Nova dependencies to Python 3: it\u0027s almost done"},{"line_number":186,"context_line":"  and it\u0027s moving fast. See the Dependencies section. Currently, some patches"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab921fb_c13d5190","line":183,"in_reply_to":"bab921fb_08471778","updated":"2015-04-25 15:26:21.000000000","message":"\u003e Once we have a py34 test environment it becomes easy to enforce python3 compliance.\n\nIMO a dedicated spec must be written, seriously. We cannot add Python 3 support and immediatly drop Python 2 support.\n\nSince it\u0027s not the first time that someone asks for this, I will add a section to explain why I consider a bad idea :-)\n\nFor example, it forces vendors having custom extensions to port their code to Python 3 in a single cycle, without having time to smoothly migrate their applications.\n\n\u003e I would like to see this section (or a different one in this spec) explore the possible migration paths and which one will be the quickest.\n\nTechnically, it\u0027s easy to drop python 2 support in nova :-) For example, modify all code using six to use directly Python 3 functions. And drop py26,py27 from tox.ini.\n\n\u003e I personally like the idea of a virtual sprint to add python34. Something along the lines of. One person works on the low hanging fruit work before the sprint. Get a few cores together, land the low hanging fruit. And quickly iterate to get all the unit tests working under python3.\n\nMy plan for the near future is to wait to get enough opinions on the spec. For example, I will not start to send patches if the avegate vote is negative.\n\nThen I will start to write patches. If needed, I can maybe publish them at review.openstack.org but mark them as WIP.\n\nWhen I will have something interesting, I will ask for review.\n\nFor practical reasons, I prefer to not work in a cave during 6 months and come back with a giant patch. I will simply conflict everywhere.\n\nIt\u0027s more convinient to send a few set of patches, then another set, etc.\n\nI\u0027m not sure that it fits exactly in your description of short sprint.\n\n\u003e If this isn\u0027t an option we need a decent way of setting up a programmatic way to check python3 compliance for new code. And how to roll out partial support over time.\n\nWriting all patches should take less than one month. I hope that getting patches will also take less than one month. I mean, the first set of patches to have something interesting (like having a few tests which pass on python 3).","commit_id":"f2ec92727e9572d91676c43c72e583e99a08f953"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"3a4da545212c385ca198632bbdcf548657dd2c1b","unresolved":false,"context_lines":[{"line_number":180,"context_line":"  None"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"Work Items"},{"line_number":183,"context_line":"----------"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"* Finish the work on porting Nova dependencies to Python 3: it\u0027s almost done"},{"line_number":186,"context_line":"  and it\u0027s moving fast. See the Dependencies section. Currently, some patches"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9abe1de1_d40dad38","line":183,"in_reply_to":"bab921fb_08471778","updated":"2015-04-27 13:02:56.000000000","message":"Done","commit_id":"f2ec92727e9572d91676c43c72e583e99a08f953"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"70188b8eab1f9097e152406e7a5938dc9dc68c86","unresolved":false,"context_lines":[{"line_number":180,"context_line":"  None"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"Work Items"},{"line_number":183,"context_line":"----------"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"* Finish the work on porting Nova dependencies to Python 3: it\u0027s almost done"},{"line_number":186,"context_line":"  and it\u0027s moving fast. See the Dependencies section. Currently, some patches"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9abe1de1_ba258d5d","line":183,"in_reply_to":"bab921fb_c13d5190","updated":"2015-04-27 08:59:29.000000000","message":"\u003e Once we have a py34 test environment it becomes easy to enforce python3 compliance. But having partial python3 support is difficult. \n\nWould introducing something similar (at least in principle) to what we have for max-complexity in tox.ini  help?\n\nIt would probably have to take into account individual tests instead of just a number, and we can\u0027t really prevent people from adding tests that are not py3.4 compatible, as that would mean that fixing bugs in non-ported parts would mean porting those parts first (probably not acceptable). Maybe saying that - you\u0027re not allowed to break passing tests with a patch even though job as a whole is not fully passing yet, could be a good strategy for partial support?","commit_id":"f2ec92727e9572d91676c43c72e583e99a08f953"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"9ebb34219d1dbaaaa50945d282225c6ca285f5ce","unresolved":false,"context_lines":[{"line_number":206,"context_line":"  - replace ``unicode()`` with ``six.text_type``"},{"line_number":207,"context_line":"  - replace ``(int, long)`` with ``six.integer_types``"},{"line_number":208,"context_line":"  - replace ``file()`` with ``open()``"},{"line_number":209,"context_line":"  - replace ``StringIO()`` with ``six.StringIO()``"},{"line_number":210,"context_line":"  - replace ``unichr()`` with ``six.unichr()``"},{"line_number":211,"context_line":"  - see also the `Python 3 wiki page"},{"line_number":212,"context_line":"    \u003chttps://wiki.openstack.org/wiki/Python3\u003e`_"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab921fb_5aba74c1","line":209,"updated":"2015-04-24 21:02:59.000000000","message":"Just a note, depending on how this is used u might need to use six.BytesIO if something really was bytes specific (and won\u0027t work with unicode strings); just something to resolve in a case by case basis...","commit_id":"f2ec92727e9572d91676c43c72e583e99a08f953"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"f68846f28a3580928302bab9a554ddffdb8d91c2","unresolved":false,"context_lines":[{"line_number":206,"context_line":"  - replace ``unicode()`` with ``six.text_type``"},{"line_number":207,"context_line":"  - replace ``(int, long)`` with ``six.integer_types``"},{"line_number":208,"context_line":"  - replace ``file()`` with ``open()``"},{"line_number":209,"context_line":"  - replace ``StringIO()`` with ``six.StringIO()``"},{"line_number":210,"context_line":"  - replace ``unichr()`` with ``six.unichr()``"},{"line_number":211,"context_line":"  - see also the `Python 3 wiki page"},{"line_number":212,"context_line":"    \u003chttps://wiki.openstack.org/wiki/Python3\u003e`_"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab921fb_0150e9d2","line":209,"in_reply_to":"bab921fb_5aba74c1","updated":"2015-04-25 15:26:21.000000000","message":"Yeah, we will have to double check that the right type (bytes or Unicode) in used.","commit_id":"f2ec92727e9572d91676c43c72e583e99a08f953"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8264996e0fbcd024d88d69a7e920720c7c6ed675","unresolved":false,"context_lines":[{"line_number":209,"context_line":"  - replace ``StringIO()`` with ``six.StringIO()``"},{"line_number":210,"context_line":"  - replace ``unichr()`` with ``six.unichr()``"},{"line_number":211,"context_line":"  - see also the `Python 3 wiki page"},{"line_number":212,"context_line":"    \u003chttps://wiki.openstack.org/wiki/Python3\u003e`_"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"* Add a ``py34`` test environment to ``tox.ini`` to run a subtest of the test"},{"line_number":215,"context_line":"  suite which pass on Python 3."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9abe1de1_e6d49048","line":212,"updated":"2015-04-27 10:26:15.000000000","message":"Feels like too much detail, but now its here, thats fine.","commit_id":"f2ec92727e9572d91676c43c72e583e99a08f953"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"3a4da545212c385ca198632bbdcf548657dd2c1b","unresolved":false,"context_lines":[{"line_number":209,"context_line":"  - replace ``StringIO()`` with ``six.StringIO()``"},{"line_number":210,"context_line":"  - replace ``unichr()`` with ``six.unichr()``"},{"line_number":211,"context_line":"  - see also the `Python 3 wiki page"},{"line_number":212,"context_line":"    \u003chttps://wiki.openstack.org/wiki/Python3\u003e`_"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"* Add a ``py34`` test environment to ``tox.ini`` to run a subtest of the test"},{"line_number":215,"context_line":"  suite which pass on Python 3."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9abe1de1_342629bb","line":212,"in_reply_to":"9abe1de1_e6d49048","updated":"2015-04-27 13:02:56.000000000","message":"Done","commit_id":"f2ec92727e9572d91676c43c72e583e99a08f953"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8264996e0fbcd024d88d69a7e920720c7c6ed675","unresolved":false,"context_lines":[{"line_number":237,"context_line":"* ``oslo.messaging``: QPID and AMQP 1.0 drivers don\u0027t work on Python 3. For"},{"line_number":238,"context_line":"  other drivers and executors, there are pending patches which should be"},{"line_number":239,"context_line":"  merged at the beginning of the Liberty cycle (they are currently blocked by"},{"line_number":240,"context_line":"  the freeze on requirements)."},{"line_number":241,"context_line":"* ``python-memcached``: see the pull request `Port memcache to Python 3"},{"line_number":242,"context_line":"  \u003chttps://github.com/linsomniac/python-memcached/pull/67\u003e`_"},{"line_number":243,"context_line":"* ``websockify``: Python 3 classifier is missing in websockify 0.6.0, but it"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9abe1de1_46b9fc2d","line":240,"updated":"2015-04-27 10:26:15.000000000","message":"Hang on... we only really use the AMQP+ rabbit driver in gate, are there no plans for 3.4 support there?","commit_id":"f2ec92727e9572d91676c43c72e583e99a08f953"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"3a4da545212c385ca198632bbdcf548657dd2c1b","unresolved":false,"context_lines":[{"line_number":237,"context_line":"* ``oslo.messaging``: QPID and AMQP 1.0 drivers don\u0027t work on Python 3. For"},{"line_number":238,"context_line":"  other drivers and executors, there are pending patches which should be"},{"line_number":239,"context_line":"  merged at the beginning of the Liberty cycle (they are currently blocked by"},{"line_number":240,"context_line":"  the freeze on requirements)."},{"line_number":241,"context_line":"* ``python-memcached``: see the pull request `Port memcache to Python 3"},{"line_number":242,"context_line":"  \u003chttps://github.com/linsomniac/python-memcached/pull/67\u003e`_"},{"line_number":243,"context_line":"* ``websockify``: Python 3 classifier is missing in websockify 0.6.0, but it"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9abe1de1_14ee8522","line":240,"in_reply_to":"9abe1de1_46b9fc2d","updated":"2015-04-27 13:02:56.000000000","message":"\u003e we only really use the AMQP+ rabbit driver in gate, are there no plans for 3.4 support there?\n\nFYI My remaining Python 3 patches for Oslo Messaging has been merged yesterday.\n\nFor AMQP, it shouldn\u0027t be hard to port the driver. We just have to find a volunteer :-) I don\u0027t think that we should block the whole port to Python 3 just because of an optional driver: the RabbitMQ driver can be used until AMQP is ported.\n\nJust to be clear, AMQP driver is \"amqp\" (py2 only) and RabbitMQ is \"rabbit\" (py2+py3) in Oslo Messaging configuration, the \"oslo.messaging.driver\" option. The \"zmq\" driver was already ported to Python 3 (yesterday ;-)).\n\nIn the latest version of the spec, I propose to start with the RabbitMQ driver, until the AMQP driver is ported.","commit_id":"f2ec92727e9572d91676c43c72e583e99a08f953"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8264996e0fbcd024d88d69a7e920720c7c6ed675","unresolved":false,"context_lines":[{"line_number":250,"context_line":"Testing"},{"line_number":251,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"The current test suite should be enough to test Nova on Python 3."},{"line_number":254,"context_line":""},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9abe1de1_06d0a452","line":253,"updated":"2015-04-27 10:26:15.000000000","message":"Can we please be explicit here and say that we will run both a full devstack gate and unit tests with Nova running under py34, by the end of this process?","commit_id":"f2ec92727e9572d91676c43c72e583e99a08f953"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"3a4da545212c385ca198632bbdcf548657dd2c1b","unresolved":false,"context_lines":[{"line_number":250,"context_line":"Testing"},{"line_number":251,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"The current test suite should be enough to test Nova on Python 3."},{"line_number":254,"context_line":""},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9abe1de1_143c4592","line":253,"in_reply_to":"9abe1de1_06d0a452","updated":"2015-04-27 13:02:56.000000000","message":"Done","commit_id":"f2ec92727e9572d91676c43c72e583e99a08f953"}]}
