)]}'
{"specs/liberty/approved/compute-node-metrics-api.rst":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"a03d23e6820dcdd3e396f49d9cdba992f8e50380","unresolved":false,"context_lines":[{"line_number":51,"context_line":"the compute node hypervisor. It pulls the information from the DB, but it"},{"line_number":52,"context_line":"ignores the metrics related information."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"We need to modified the os-hypervisors API extension to list the metrics"},{"line_number":55,"context_line":"of each compute node hypervisor through the following restful API call:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    GET /v2.1/os-hypervisors/{hypervisor_id}/metrics"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1aca2d91_5b02bb0c","line":54,"updated":"2015-05-07 10:09:55.000000000","message":"guess we can avoid extension since v2.1?","commit_id":"b4e967cedf815a6cb25b0416161a1bcab095152c"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"a03d23e6820dcdd3e396f49d9cdba992f8e50380","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Security impact"},{"line_number":108,"context_line":"---------------"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"None"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Notifications impact"},{"line_number":113,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1aca2d91_3b2c9f01","line":110,"updated":"2015-05-07 10:09:55.000000000","message":"will this expose too much detail on the cloud info? \nI think we need to say the policy here to avoid mal-user usage","commit_id":"b4e967cedf815a6cb25b0416161a1bcab095152c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"af7162fff07c78d21340e3f38f9ee18d0426acd0","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"We need to add an API to list the available metrics stored in the DB for"},{"line_number":32,"context_line":"each compute node hypervisor so the administrator can configure the"},{"line_number":33,"context_line":"MetricWeigher much more easily."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Use Cases"},{"line_number":36,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a0c5dc1_c49def5a","line":33,"updated":"2015-05-12 09:45:53.000000000","message":"I worry that we are going down the direction of slowly reimplementing Nagios.\n\nI need to think about whether this is a good idea.\n\nWith the changes in the scheduler, this API may not longer belong as part of the Nova API, so I do worry a little about reporting these details.","commit_id":"a17286abca88dab0a871c49a257deefa19f8fd9f"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"731768b85216d6643d59947649b54fec86fb9623","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"We need to add an API to list the available metrics stored in the DB for"},{"line_number":32,"context_line":"each compute node hypervisor so the administrator can configure the"},{"line_number":33,"context_line":"MetricWeigher much more easily."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Use Cases"},{"line_number":36,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a016987_efc80357","line":33,"in_reply_to":"7a016987_939e6605","updated":"2015-05-22 06:48:59.000000000","message":"Here we just list what is stored in the DB. If the admin doesn\u0027t enable some plugins, there won\u0027t be data from those plugins stored in the DB, so those data won\u0027t be listed here.","commit_id":"a17286abca88dab0a871c49a257deefa19f8fd9f"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"9da01b0a253093f4f44e07a49313dbd17c8ae73f","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"We need to add an API to list the available metrics stored in the DB for"},{"line_number":32,"context_line":"each compute node hypervisor so the administrator can configure the"},{"line_number":33,"context_line":"MetricWeigher much more easily."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Use Cases"},{"line_number":36,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a016987_701cbd13","line":33,"in_reply_to":"7a016987_a750e70b","updated":"2015-05-26 00:48:07.000000000","message":"These metrics are already broadcast on the notification bus when they\u0027re collected. The problems is that the admin doesn\u0027t have easy access to the notification bus to get those info.\n\nMy whole intention for this blueprint is to ease the life of admin by provide the admin or others a way to look at the metrics without depending on other projects/software to decode the notification and show the metrics. \n\nUsing this api, the admin can configure the correct settings of the nova sheduler\u0027s MetricWeigher much more easily.","commit_id":"a17286abca88dab0a871c49a257deefa19f8fd9f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ea8df58a6aa89af6c73e155b7086b6ea0b22d174","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"We need to add an API to list the available metrics stored in the DB for"},{"line_number":32,"context_line":"each compute node hypervisor so the administrator can configure the"},{"line_number":33,"context_line":"MetricWeigher much more easily."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Use Cases"},{"line_number":36,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a016987_a750e70b","line":33,"in_reply_to":"7a016987_efc80357","updated":"2015-05-22 16:27:37.000000000","message":"But then the output of this resource will not be consistent depending on the plugins you use, right?\n\nAlso, I don\u0027t really see added value to get those metrics using a REST API since you could rather provide those as notifications IMHO.","commit_id":"a17286abca88dab0a871c49a257deefa19f8fd9f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c2ed3c8a3fe77ba05d11bb783696093d5ce319c8","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"We need to add an API to list the available metrics stored in the DB for"},{"line_number":32,"context_line":"each compute node hypervisor so the administrator can configure the"},{"line_number":33,"context_line":"MetricWeigher much more easily."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Use Cases"},{"line_number":36,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a016987_939e6605","line":33,"in_reply_to":"9a0c5dc1_c49def5a","updated":"2015-05-21 20:31:28.000000000","message":"The main problem I can see is that the monitors are plugins so can be different for each cloud. How can you provide a REST API implementation enough abstract so it would just make sure it\u0027s not different based on which plugins are where or not ?","commit_id":"a17286abca88dab0a871c49a257deefa19f8fd9f"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"db690c766961cf6f260bf245f582e07e5c3969bb","unresolved":false,"context_lines":[{"line_number":54,"context_line":"We need to modified the os-hypervisors API extension to list the metrics"},{"line_number":55,"context_line":"of each compute node hypervisor through the following restful API call:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    GET /v2.1/os-hypervisors/{hypervisor_id}/metrics"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"The above API would query the DB and return the metrics stored in the DB"},{"line_number":60,"context_line":"for the specified compute node hypervisor."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_92e67642","line":57,"updated":"2015-06-18 12:26:26.000000000","message":"So, I\u0027m generally supportive of this change. However, I am definitely not supportive of any modification to the (horribly-implemented) os-hypervisors API extension :)\n\nThe use case here is to allow an administrator to view the *metric keys* -- e.g. \"cpu.kernel.time\" -- that are available for the administrator to configure the MetricsWeigher to consider during placement of the VM to a compute host.\n\nTherefore, instead of having an API that returns the metrics themselves (which as John Garbutt mentioned, is getting too similar to reimplementing Nagios), I would advise developing a new top-level REST API resource that simply lists the keys that are made available as metrics by the drivers loaded into the system.\n\nSo, for example, such a new REST API might look like this:\n\n GET /metrics\n 200 OK\n {\n   \u0027metrics\u0027: [\n     \u0027cpu.kernel.time\u0027,\n     \u0027cpu.user.time\u0027,\n    ...\n   ]\n }\n\nAnd the implementation of this REST API resource would rely on a new method on the nova.compute.monitors.ResourceMonitorBase class that would return a list of the metrics keys that each plugin supported.","commit_id":"a17286abca88dab0a871c49a257deefa19f8fd9f"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"1c9d9fe514e7a8a67c335e2d460617eb334ffaa9","unresolved":false,"context_lines":[{"line_number":54,"context_line":"We need to modified the os-hypervisors API extension to list the metrics"},{"line_number":55,"context_line":"of each compute node hypervisor through the following restful API call:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    GET /v2.1/os-hypervisors/{hypervisor_id}/metrics"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"The above API would query the DB and return the metrics stored in the DB"},{"line_number":60,"context_line":"for the specified compute node hypervisor."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_9b80b2f8","line":57,"in_reply_to":"fa32b979_92e67642","updated":"2015-06-19 01:28:35.000000000","message":"@Jay, thanks for the careful review. I\u0027ll change the implementation based on your comment","commit_id":"a17286abca88dab0a871c49a257deefa19f8fd9f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c2ed3c8a3fe77ba05d11bb783696093d5ce319c8","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                \"source\": \"libvirt.LibvirtDriver\","},{"line_number":101,"context_line":"                \"timestamp\": \"2015-04-01T00:00:00Z\","},{"line_number":102,"context_line":"                \"value\": 1600,"},{"line_number":103,"context_line":"            },"},{"line_number":104,"context_line":"        ]"},{"line_number":105,"context_line":"    }"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a016987_53b46e7e","line":103,"updated":"2015-05-21 20:31:28.000000000","message":"How we can be sure that each metric is having the same output ?","commit_id":"a17286abca88dab0a871c49a257deefa19f8fd9f"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"731768b85216d6643d59947649b54fec86fb9623","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                \"source\": \"libvirt.LibvirtDriver\","},{"line_number":101,"context_line":"                \"timestamp\": \"2015-04-01T00:00:00Z\","},{"line_number":102,"context_line":"                \"value\": 1600,"},{"line_number":103,"context_line":"            },"},{"line_number":104,"context_line":"        ]"},{"line_number":105,"context_line":"    }"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a016987_afa7aba5","line":103,"in_reply_to":"7a016987_53b46e7e","updated":"2015-05-22 06:48:59.000000000","message":"all the monitor plugin should inherit from class ResourceMonitorBase, https://github.com/openstack/nova/blob/master/nova/compute/monitors/__init__.py#L69\n\nand the base class ensures that all the monitors return their data in the same format.","commit_id":"a17286abca88dab0a871c49a257deefa19f8fd9f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c2ed3c8a3fe77ba05d11bb783696093d5ce319c8","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Security impact"},{"line_number":108,"context_line":"---------------"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Relevant policy will only allow this API be accessed by administrator."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Notifications impact"},{"line_number":113,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a016987_f3a47a4b","line":110,"updated":"2015-05-21 20:31:28.000000000","message":"Well, that\u0027s RBAC so just mention it\u0027s admin by default.","commit_id":"a17286abca88dab0a871c49a257deefa19f8fd9f"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"731768b85216d6643d59947649b54fec86fb9623","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Security impact"},{"line_number":108,"context_line":"---------------"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Relevant policy will only allow this API be accessed by administrator."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Notifications impact"},{"line_number":113,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a016987_8f92af4a","line":110,"in_reply_to":"7a016987_f3a47a4b","updated":"2015-05-22 06:48:59.000000000","message":"got that, thanks for the review","commit_id":"a17286abca88dab0a871c49a257deefa19f8fd9f"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"3495af72036dde1a47c2ceb355e507715b494f9a","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/compute-node-metrics-api"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"We need to add an API to list the available metric name stored in the DB"},{"line_number":14,"context_line":"which is reported by the compute monitor plugins, so the administrator"},{"line_number":15,"context_line":"can easily configure the schedule MetricWeigher settings."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_f4d2c733","line":13,"updated":"2015-06-22 20:27:13.000000000","message":"s/name/names/","commit_id":"aefca81670897e0ed0d0b0555ffe10369fa01e2a"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"879210cc8bb26f4b25ade15a4c4d02bfb46d4064","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/compute-node-metrics-api"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"We need to add an API to list the available metric name stored in the DB"},{"line_number":14,"context_line":"which is reported by the compute monitor plugins, so the administrator"},{"line_number":15,"context_line":"can easily configure the schedule MetricWeigher settings."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba3cc151_9a952834","line":13,"in_reply_to":"fa32b979_f4d2c733","updated":"2015-07-02 21:31:51.000000000","message":"Done","commit_id":"aefca81670897e0ed0d0b0555ffe10369fa01e2a"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"3495af72036dde1a47c2ceb355e507715b494f9a","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"We need to add an API to list the available metric name stored in the DB"},{"line_number":14,"context_line":"which is reported by the compute monitor plugins, so the administrator"},{"line_number":15,"context_line":"can easily configure the schedule MetricWeigher settings."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_f4b967ed","line":15,"updated":"2015-06-22 20:27:13.000000000","message":"s/schedule/scheduler\u0027s/","commit_id":"aefca81670897e0ed0d0b0555ffe10369fa01e2a"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"879210cc8bb26f4b25ade15a4c4d02bfb46d4064","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"We need to add an API to list the available metric name stored in the DB"},{"line_number":14,"context_line":"which is reported by the compute monitor plugins, so the administrator"},{"line_number":15,"context_line":"can easily configure the schedule MetricWeigher settings."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba3cc151_3a989c69","line":15,"in_reply_to":"fa32b979_f4b967ed","updated":"2015-07-02 21:31:51.000000000","message":"Done","commit_id":"aefca81670897e0ed0d0b0555ffe10369fa01e2a"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"3495af72036dde1a47c2ceb355e507715b494f9a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"through the MetricsWeigher configured by the administrator."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"When the administrator wants to configure the settings for MetricsWeigher,"},{"line_number":27,"context_line":"he/she need to know the exact metric names to make the settings working."},{"line_number":28,"context_line":"Currently, we don\u0027t have a way to let the administrator know what metrics"},{"line_number":29,"context_line":"are available unless asking the administrator to look at the monitor"},{"line_number":30,"context_line":"plug-ins code or looking certain tables in the DB."}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_d4ad439c","line":27,"updated":"2015-06-22 20:27:13.000000000","message":"s/working/work properly/","commit_id":"aefca81670897e0ed0d0b0555ffe10369fa01e2a"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"879210cc8bb26f4b25ade15a4c4d02bfb46d4064","unresolved":false,"context_lines":[{"line_number":24,"context_line":"through the MetricsWeigher configured by the administrator."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"When the administrator wants to configure the settings for MetricsWeigher,"},{"line_number":27,"context_line":"he/she need to know the exact metric names to make the settings working."},{"line_number":28,"context_line":"Currently, we don\u0027t have a way to let the administrator know what metrics"},{"line_number":29,"context_line":"are available unless asking the administrator to look at the monitor"},{"line_number":30,"context_line":"plug-ins code or looking certain tables in the DB."}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba3cc151_5ab240e6","line":27,"in_reply_to":"fa32b979_d4ad439c","updated":"2015-07-02 21:31:51.000000000","message":"Done","commit_id":"aefca81670897e0ed0d0b0555ffe10369fa01e2a"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"3495af72036dde1a47c2ceb355e507715b494f9a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"he/she need to know the exact metric names to make the settings working."},{"line_number":28,"context_line":"Currently, we don\u0027t have a way to let the administrator know what metrics"},{"line_number":29,"context_line":"are available unless asking the administrator to look at the monitor"},{"line_number":30,"context_line":"plug-ins code or looking certain tables in the DB."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"We need to add an API to list the available metric names currently reported"},{"line_number":33,"context_line":"by the nova compute monitors and stored in the DB, so the administrator"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_747c7720","line":30,"updated":"2015-06-22 20:27:13.000000000","message":"s/looking certain tables/looking in certain tables/","commit_id":"aefca81670897e0ed0d0b0555ffe10369fa01e2a"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"879210cc8bb26f4b25ade15a4c4d02bfb46d4064","unresolved":false,"context_lines":[{"line_number":27,"context_line":"he/she need to know the exact metric names to make the settings working."},{"line_number":28,"context_line":"Currently, we don\u0027t have a way to let the administrator know what metrics"},{"line_number":29,"context_line":"are available unless asking the administrator to look at the monitor"},{"line_number":30,"context_line":"plug-ins code or looking certain tables in the DB."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"We need to add an API to list the available metric names currently reported"},{"line_number":33,"context_line":"by the nova compute monitors and stored in the DB, so the administrator"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba3cc151_9ae3e8d8","line":30,"in_reply_to":"fa32b979_747c7720","updated":"2015-07-02 21:31:51.000000000","message":"Done","commit_id":"aefca81670897e0ed0d0b0555ffe10369fa01e2a"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"3495af72036dde1a47c2ceb355e507715b494f9a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"A new method will be added in nova.compute.monitors.ResourceMonitorBase class"},{"line_number":51,"context_line":"that would return a list of the metric names that all the loaded plugin"},{"line_number":52,"context_line":"supports."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"A new top-level REST API resource will be added, it simply lists the metric"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_d49b0365","line":51,"updated":"2015-06-22 20:27:13.000000000","message":"s/all the loaded plugin/each plugin/","commit_id":"aefca81670897e0ed0d0b0555ffe10369fa01e2a"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"879210cc8bb26f4b25ade15a4c4d02bfb46d4064","unresolved":false,"context_lines":[{"line_number":48,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"A new method will be added in nova.compute.monitors.ResourceMonitorBase class"},{"line_number":51,"context_line":"that would return a list of the metric names that all the loaded plugin"},{"line_number":52,"context_line":"supports."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"A new top-level REST API resource will be added, it simply lists the metric"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba3cc151_bac7cc62","line":51,"in_reply_to":"fa32b979_d49b0365","updated":"2015-07-02 21:31:51.000000000","message":"Done","commit_id":"aefca81670897e0ed0d0b0555ffe10369fa01e2a"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"3495af72036dde1a47c2ceb355e507715b494f9a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"A new top-level REST API resource will be added, it simply lists the metric"},{"line_number":55,"context_line":"names which is returned by the new method mentioned above:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    GET /v2.1/metrics"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_54bff3a9","line":57,"updated":"2015-06-22 20:27:13.000000000","message":"Please add that this new API will be admin-only by default.","commit_id":"aefca81670897e0ed0d0b0555ffe10369fa01e2a"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"879210cc8bb26f4b25ade15a4c4d02bfb46d4064","unresolved":false,"context_lines":[{"line_number":54,"context_line":"A new top-level REST API resource will be added, it simply lists the metric"},{"line_number":55,"context_line":"names which is returned by the new method mentioned above:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    GET /v2.1/metrics"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba3cc151_da99707a","line":57,"in_reply_to":"fa32b979_54bff3a9","updated":"2015-07-02 21:31:51.000000000","message":"Done","commit_id":"aefca81670897e0ed0d0b0555ffe10369fa01e2a"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"3495af72036dde1a47c2ceb355e507715b494f9a","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            \u0027cpu.user.time\u0027,"},{"line_number":95,"context_line":"            ......"},{"line_number":96,"context_line":"        ]"},{"line_number":97,"context_line":"    }"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Security impact"},{"line_number":100,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_14e08bcb","line":97,"updated":"2015-06-22 20:27:13.000000000","message":"++ :)","commit_id":"aefca81670897e0ed0d0b0555ffe10369fa01e2a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"9335f1a788cae6b5501b2703bc6f47204119a3d1","unresolved":false,"context_lines":[{"line_number":27,"context_line":"he/she need to know the exact metric names to make the settings working"},{"line_number":28,"context_line":"properly. Currently, we don\u0027t have a way to let the administrator know what"},{"line_number":29,"context_line":"metrics are available unless asking the administrator to look at the monitor"},{"line_number":30,"context_line":"plug-ins code or looking in certain DB tables."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"We need to add an API to list the available metric names currently reported"},{"line_number":33,"context_line":"by the nova compute monitors and stored in the DB, so the administrator"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba3cc151_7c3dabc2","line":30,"updated":"2015-07-03 11:19:16.000000000","message":"we can actually get the metrics from the notification bus, but that\u0027s indeed maybe not as handy as a single REST call.","commit_id":"c713950836dec2d0345c31a720113476ab40c246"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"9335f1a788cae6b5501b2703bc6f47204119a3d1","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    GET /v2.1/metrics"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"This new API by default is admin only."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Alternatives"},{"line_number":61,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba3cc151_3c196322","line":58,"updated":"2015-07-03 11:19:16.000000000","message":"To be clear, while I agree on getting a read-only API for the metrics taxonomy, I don\u0027t want to have the values of those metrics exposed by the REST API, because we have notifications for that.\n\nIMHO, that needs to be clearly mentioned in the implementation change.","commit_id":"c713950836dec2d0345c31a720113476ab40c246"}],"specs/mitaka/approved/compute-node-metrics-api.rst":[{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"06e024a5e51ef3b40db01f38899c2fb23d68fe90","unresolved":false,"context_lines":[{"line_number":32,"context_line":"We need to add an API to list the available metric names currently reported"},{"line_number":33,"context_line":"by the nova compute monitors and stored in the DB, so the administrator"},{"line_number":34,"context_line":"can configure the MetricWeigher much more easily."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Use Cases"},{"line_number":37,"context_line":"----------"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a1a9d01_69e9b5e5","line":35,"updated":"2015-09-29 14:33:48.000000000","message":"I am wonder if this needs a new API or if this change fits better as a new nova-manage command, I know that I could be completely wrong but it seems to me like a handy tool for the administrator to run while they configure the system.\nPlus note that in the review of the liberty specs johnthetubaguy was not completely sure about having a new nova API as this could become something specific for the new scheduler.","commit_id":"10725139681eb4109c2d7bc5f6ecd2e7ba556e84"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"db38120c27494598767678fef7b6a8e2b38cb41b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"We need to add an API to list the available metric names currently reported"},{"line_number":33,"context_line":"by the nova compute monitors and stored in the DB, so the administrator"},{"line_number":34,"context_line":"can configure the MetricWeigher much more easily."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Use Cases"},{"line_number":37,"context_line":"----------"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a1a9d01_976f692a","line":35,"in_reply_to":"9a1a9d01_69e9b5e5","updated":"2015-09-30 01:28:06.000000000","message":"Yes, that was his concern about the API to list each metrics details. But later, we change the API to list only metric names, and he gave +2. Sadly this didn\u0027t make in because of the spec freeze window.","commit_id":"10725139681eb4109c2d7bc5f6ecd2e7ba556e84"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"5f83ced32a694532a7ead4d8dee4c7e2a7d0920c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"Proposed change"},{"line_number":48,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"A new method will be added in nova.compute.monitors.ResourceMonitorBase class"},{"line_number":51,"context_line":"that would return a list of the metric names that each plugin supports."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"A new top-level REST API resource will be added, it simply lists the metric"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a29b11f_443501d8","line":50,"updated":"2015-10-20 10:02:28.000000000","message":"Now I can not find this class under nova/compute/monitors.\nMaybe here should be\n\n nova.compute.monitors.base.MonitorBase","commit_id":"10725139681eb4109c2d7bc5f6ecd2e7ba556e84"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"676d0ee473df62a4378d32668fcee081996dbe6b","unresolved":false,"context_lines":[{"line_number":47,"context_line":"Proposed change"},{"line_number":48,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"A new method will be added in nova.compute.monitors.ResourceMonitorBase class"},{"line_number":51,"context_line":"that would return a list of the metric names that each plugin supports."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"A new top-level REST API resource will be added, it simply lists the metric"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a26ad4f_b16ae37f","line":50,"in_reply_to":"3a29b11f_443501d8","updated":"2015-11-03 05:23:43.000000000","message":"Done","commit_id":"10725139681eb4109c2d7bc5f6ecd2e7ba556e84"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"5f83ced32a694532a7ead4d8dee4c7e2a7d0920c","unresolved":false,"context_lines":[{"line_number":53,"context_line":"A new top-level REST API resource will be added, it simply lists the metric"},{"line_number":54,"context_line":"names which is returned by the new method mentioned above:"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    GET /v2.1/metrics"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"This new API by default is admin only."},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a29b11f_c441110d","line":56,"updated":"2015-10-20 10:02:28.000000000","message":"I feel \"metrics\" seems too generic from the viewpoint of API users.\n\nHow about\n\n GET /v2.1/compute-monitor-metrics\n\nor something?","commit_id":"10725139681eb4109c2d7bc5f6ecd2e7ba556e84"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"676d0ee473df62a4378d32668fcee081996dbe6b","unresolved":false,"context_lines":[{"line_number":53,"context_line":"A new top-level REST API resource will be added, it simply lists the metric"},{"line_number":54,"context_line":"names which is returned by the new method mentioned above:"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    GET /v2.1/metrics"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"This new API by default is admin only."},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a26ad4f_d1675fb5","line":56,"in_reply_to":"3a29b11f_c441110d","updated":"2015-11-03 05:23:43.000000000","message":"Done","commit_id":"10725139681eb4109c2d7bc5f6ecd2e7ba556e84"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"92734927e17b4cd8c4cf4a38a0f34a790df3f44d","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    200 OK"},{"line_number":91,"context_line":"    {"},{"line_number":92,"context_line":"        \"metrics\": ["},{"line_number":93,"context_line":"            \u0027cpu.kernel.time\u0027,"},{"line_number":94,"context_line":"            \u0027cpu.user.time\u0027,"},{"line_number":95,"context_line":"            ......"},{"line_number":96,"context_line":"        ]"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a1a9d01_b6c5133d","line":93,"updated":"2015-09-28 17:38:22.000000000","message":"I wonder if this is really enough. If I don\u0027t see an example, I don\u0027t know if this is in seconds, milliseconds, jiffies, etc. So, I\u0027m not sure this gives me enough information to really do my configuration.\n\nit seems like your alternative above for listing it per-hypervisor might be more useful. It would not only show us what metrics are exposed for each hypervisor (in case it differs by driver), it would also give us current values. The current values might be interesting from a debug perspective anyway, but would also give us example values so we have a better idea for configuration.","commit_id":"10725139681eb4109c2d7bc5f6ecd2e7ba556e84"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"79c7e8e2caa698293a2b74c535b47666c7ba9cf0","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    200 OK"},{"line_number":91,"context_line":"    {"},{"line_number":92,"context_line":"        \"metrics\": ["},{"line_number":93,"context_line":"            \u0027cpu.kernel.time\u0027,"},{"line_number":94,"context_line":"            \u0027cpu.user.time\u0027,"},{"line_number":95,"context_line":"            ......"},{"line_number":96,"context_line":"        ]"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba8a016a_b30c8543","line":93,"in_reply_to":"1a26ad4f_b8c37a88","updated":"2015-11-16 18:35:11.000000000","message":"So we can create a separate scheduler REST API now, just no one has created that yet.\n\nAgreed with Sean about the middle ground not being very useful.\n\nCeilometer might be a better way to consume this data, for example.","commit_id":"10725139681eb4109c2d7bc5f6ecd2e7ba556e84"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"676d0ee473df62a4378d32668fcee081996dbe6b","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    200 OK"},{"line_number":91,"context_line":"    {"},{"line_number":92,"context_line":"        \"metrics\": ["},{"line_number":93,"context_line":"            \u0027cpu.kernel.time\u0027,"},{"line_number":94,"context_line":"            \u0027cpu.user.time\u0027,"},{"line_number":95,"context_line":"            ......"},{"line_number":96,"context_line":"        ]"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a26ad4f_b8c37a88","line":93,"in_reply_to":"3a29b11f_27fc47b7","updated":"2015-11-03 05:23:43.000000000","message":"I admit the best place for this is the splitted out scheduler. But seems that the scheduler splitting is not gonna to happen soon, we\u0027ve been there waiting for it.","commit_id":"10725139681eb4109c2d7bc5f6ecd2e7ba556e84"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"5dc54a0e941a3d0028ee5f8529adbc8a4c06c2a3","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    200 OK"},{"line_number":91,"context_line":"    {"},{"line_number":92,"context_line":"        \"metrics\": ["},{"line_number":93,"context_line":"            \u0027cpu.kernel.time\u0027,"},{"line_number":94,"context_line":"            \u0027cpu.user.time\u0027,"},{"line_number":95,"context_line":"            ......"},{"line_number":96,"context_line":"        ]"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a29b11f_27fc47b7","line":93,"in_reply_to":"9a1a9d01_536caacf","updated":"2015-10-21 12:45:04.000000000","message":"But the middle ground doesn\u0027t make a ton of sense either.\n\nI think the real question is returning this information to the user the job of Nova. And it\u0027s not really clear to me that it is. There are lots of ways to get that information, and this seems to expand Nova scope into a metric system.\n\nIf this is going to get exposed at all, it seems like it should be exposed on a scheduler resource, so that should we split off the scheduler we would have a dedicated set of interfaces there, and not another proxy issue.","commit_id":"10725139681eb4109c2d7bc5f6ecd2e7ba556e84"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"4a26eee7e096cbd7ecb3db4a2f36b6677892fca4","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    200 OK"},{"line_number":91,"context_line":"    {"},{"line_number":92,"context_line":"        \"metrics\": ["},{"line_number":93,"context_line":"            \u0027cpu.kernel.time\u0027,"},{"line_number":94,"context_line":"            \u0027cpu.user.time\u0027,"},{"line_number":95,"context_line":"            ......"},{"line_number":96,"context_line":"        ]"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a1a9d01_536caacf","line":93,"in_reply_to":"9a1a9d01_b6c5133d","updated":"2015-09-29 10:46:50.000000000","message":"@Dan, the alternative was my very first thought of this spec, but jaypipes and johnthetubaguy were opposed to list the metric detail values on each compute node, they don\u0027t like the idea of giving detail metrics, and were afraid of making nova like nagios. \n\n https://review.openstack.org/#/c/180049/2/specs/liberty/approved/compute-node-metrics-api.rst","commit_id":"10725139681eb4109c2d7bc5f6ecd2e7ba556e84"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"46412efa18321cdc7160116c0615379dd17e663f","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            \u0027cpu.user.time\u0027,"},{"line_number":95,"context_line":"            ......"},{"line_number":96,"context_line":"        ]"},{"line_number":97,"context_line":"    }"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Security impact"},{"line_number":100,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa1b9901_2c95193e","line":97,"updated":"2015-08-19 21:37:13.000000000","message":"sounds good to me as a discoverable-only mechanism for knowing what to tune.","commit_id":"10725139681eb4109c2d7bc5f6ecd2e7ba556e84"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6a2a33e67e7ef7c4ee4b63db67b6a5f1b1d089c4","unresolved":false,"context_lines":[{"line_number":51,"context_line":"that would return a list of the metric names that each plugin supports."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"A new top-level REST API resource will be added, it simply lists the metric"},{"line_number":54,"context_line":"names which is returned by the new method mentioned above:"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    GET /v2.1/compute-monitor-metrics"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba8a016a_53c199e3","line":54,"updated":"2015-11-16 18:32:35.000000000","message":"Nit: s/is/are/","commit_id":"48cf6f26bfb5d650d110c890eb96519cff39fb7d"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"baffffa9b857ccde53123a834e08051eb6c31577","unresolved":false,"context_lines":[{"line_number":51,"context_line":"that would return a list of the metric names that each plugin supports."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"A new top-level REST API resource will be added, it simply lists the metric"},{"line_number":54,"context_line":"names which is returned by the new method mentioned above:"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    GET /v2.1/compute-monitor-metrics"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba8a016a_4c401b57","line":54,"in_reply_to":"ba8a016a_53c199e3","updated":"2015-11-16 19:44:43.000000000","message":"Done","commit_id":"48cf6f26bfb5d650d110c890eb96519cff39fb7d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6a2a33e67e7ef7c4ee4b63db67b6a5f1b1d089c4","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"A new API is added:"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"GET /v2.1/metrics"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"A array \u0027metrics\u0027 will be returned in the response of this API, listing"},{"line_number":88,"context_line":"all the metrics names. The response will looks like::"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba8a016a_93a7014f","line":85,"updated":"2015-11-16 18:32:35.000000000","message":"not consistent with line 56 GET /v2.1/compute-monitor-metrics","commit_id":"48cf6f26bfb5d650d110c890eb96519cff39fb7d"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"baffffa9b857ccde53123a834e08051eb6c31577","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"A new API is added:"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"GET /v2.1/metrics"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"A array \u0027metrics\u0027 will be returned in the response of this API, listing"},{"line_number":88,"context_line":"all the metrics names. The response will looks like::"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba8a016a_4faa4dd6","line":85,"in_reply_to":"ba8a016a_2e26eeba","updated":"2015-11-16 19:44:43.000000000","message":"changed to host-metrics","commit_id":"48cf6f26bfb5d650d110c890eb96519cff39fb7d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"220513581aa68a6b997be4ef8d586db22d4fcba5","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"A new API is added:"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"GET /v2.1/metrics"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"A array \u0027metrics\u0027 will be returned in the response of this API, listing"},{"line_number":88,"context_line":"all the metrics names. The response will looks like::"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba8a016a_2e26eeba","line":85,"in_reply_to":"ba8a016a_93a7014f","updated":"2015-11-16 18:36:54.000000000","message":"seems like this should be compute-monitor-metrics, to be consistent, not sure I totally like the name,\n\nhost-metrics might be better?\n\nBut I think the question is really, do we want to have this API at all.","commit_id":"48cf6f26bfb5d650d110c890eb96519cff39fb7d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"da80f81cff90f06f4924f7e6669b3973cc4afee6","unresolved":false,"context_lines":[{"line_number":109,"context_line":"Other end user impact"},{"line_number":110,"context_line":"---------------------"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"None"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Performance Impact"},{"line_number":115,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba8a016a_334ad584","line":112,"updated":"2015-11-16 18:33:09.000000000","message":"you mention CLI impact, please describe the CLI changes you are planning here.","commit_id":"48cf6f26bfb5d650d110c890eb96519cff39fb7d"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"baffffa9b857ccde53123a834e08051eb6c31577","unresolved":false,"context_lines":[{"line_number":109,"context_line":"Other end user impact"},{"line_number":110,"context_line":"---------------------"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"None"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Performance Impact"},{"line_number":115,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba8a016a_ef41c13a","line":112,"in_reply_to":"ba8a016a_334ad584","updated":"2015-11-16 19:44:43.000000000","message":"Done","commit_id":"48cf6f26bfb5d650d110c890eb96519cff39fb7d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"f2d7f013ea1418e76d80b04d203fa54cabba3645","unresolved":false,"context_lines":[{"line_number":37,"context_line":"----------"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The Administrator will use this API to list all the available metric names,"},{"line_number":40,"context_line":"in order to configure the MetricsWeigher to work as expected."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Project Priority"},{"line_number":43,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba8a016a_32b5ec7d","line":40,"updated":"2015-11-20 21:49:27.000000000","message":"So, after thinking about that, I feel that having an API resource for that would mean that it could be needed for end-users. But I don\u0027t see why it could be needed for those users, right? Instead, we have a nova-manage command which help operators getting some DB stuff if really needed.","commit_id":"23d2d5f1b2a023bbbbb96fd7da68f3e3cd50e34e"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"88314f698c34c5ccac4d9d5602e17b845cb46e1a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"A new top-level REST API resource will be added, it simply lists the metric"},{"line_number":54,"context_line":"names which are returned by the new method mentioned above:"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    GET /v2.1/host-metrics"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"This new API by default is admin only."},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba8a016a_87070381","line":56,"updated":"2015-11-19 17:19:00.000000000","message":"I think this is still not clear enough. Ken\u0027ichi\u0027s suggestion of \u0027compute-monitor-metrics\u0027 is much clearer about what it is representing.","commit_id":"23d2d5f1b2a023bbbbb96fd7da68f3e3cd50e34e"},{"author":{"_account_id":6804,"name":"bruce-benjamin","email":"bruce.benjamin@jhuapl.edu","username":"bruce-benjamin"},"change_message_id":"53aa12d1c13b5d4deccf2100635b6eb7e97b997c","unresolved":false,"context_lines":[{"line_number":64,"context_line":"the compute node hypervisor. It pulls the information from the DB, but it"},{"line_number":65,"context_line":"ignores the metrics related information."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"We need to modified the os-hypervisors API extension to list the metrics"},{"line_number":68,"context_line":"of each compute node hypervisor through the following restful API call:"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    GET /v2.1/os-hypervisors/{hypervisor_id}/metrics"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba8a016a_21be11d5","line":67,"updated":"2015-11-20 14:33:40.000000000","message":"s/modified/modify/\n\nI also like the this API extension update alternative more than the proposed API change.","commit_id":"23d2d5f1b2a023bbbbb96fd7da68f3e3cd50e34e"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"88314f698c34c5ccac4d9d5602e17b845cb46e1a","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    GET /v2.1/os-hypervisors/{hypervisor_id}/metrics"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"The above API would query the DB and return the metrics stored in the DB"},{"line_number":73,"context_line":"for the specified compute node hypervisor."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Data model impact"},{"line_number":76,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba8a016a_074313b3","line":73,"updated":"2015-11-19 17:19:00.000000000","message":"I think that this would be a better approach, actually. We already have most of the things in place, and would be a logical expansion of an existing API resource schema instead of a whole new resource.","commit_id":"23d2d5f1b2a023bbbbb96fd7da68f3e3cd50e34e"}],"specs/mitaka/approved/compute-node-metrics-list.rst":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8f1122fe6b12b895a837648aced1d170ba1958c1","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Adding new nova-manage cmd to list compute node metrics"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/compute-node-metrics-api"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"We need a way to list the available metrics stored in the DB"},{"line_number":14,"context_line":"which is reported by the compute monitor plugins, so the administrator"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a8ffd7b_cd8ff321","line":11,"updated":"2015-11-25 15:29:39.000000000","message":"Nit: should that be compute-node-metrics-list now?","commit_id":"cda18032ab40e578311dc0135ef69f24293b5ea0"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"02dd13414ce4ed8dbadb299cb4ad6464d88bb5d7","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Adding new nova-manage cmd to list compute node metrics"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/compute-node-metrics-api"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"We need a way to list the available metrics stored in the DB"},{"line_number":14,"context_line":"which is reported by the compute monitor plugins, so the administrator"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a8ffd7b_a6336e13","line":11,"in_reply_to":"9a8ffd7b_cd8ff321","updated":"2015-11-26 15:39:56.000000000","message":"created a dependent patch https://review.openstack.org/250452 to fix this","commit_id":"cda18032ab40e578311dc0135ef69f24293b5ea0"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"a71c614d4221933f77565dc19c91dba5d13b7f07","unresolved":false,"context_lines":[{"line_number":43,"context_line":"-----------------"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"None"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Proposed change"},{"line_number":48,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba8a016a_1412b457","line":46,"updated":"2015-11-24 09:16:05.000000000","message":"if you need to put a new patch please remove that section as it is not in template anymore","commit_id":"cda18032ab40e578311dc0135ef69f24293b5ea0"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"02dd13414ce4ed8dbadb299cb4ad6464d88bb5d7","unresolved":false,"context_lines":[{"line_number":43,"context_line":"-----------------"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"None"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Proposed change"},{"line_number":48,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a8ffd7b_6642666a","line":46,"in_reply_to":"9a8ffd7b_cdddb315","updated":"2015-11-26 15:39:56.000000000","message":"created dependent patch https://review.openstack.org/250452 to fix this","commit_id":"cda18032ab40e578311dc0135ef69f24293b5ea0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8f1122fe6b12b895a837648aced1d170ba1958c1","unresolved":false,"context_lines":[{"line_number":43,"context_line":"-----------------"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"None"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Proposed change"},{"line_number":48,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a8ffd7b_cdddb315","line":46,"in_reply_to":"ba8a016a_1412b457","updated":"2015-11-25 15:29:39.000000000","message":"+1","commit_id":"cda18032ab40e578311dc0135ef69f24293b5ea0"}]}