)]}'
{"specs/liberty/approved/cleanup-scheduled-at.rst":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e68018cfeb65665b1568c3f1c63f5b9f40d50a47","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Remove \u0027scheduled_at\u0027 column in nova instances table"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/cleanup-scheduled-at"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a0c5dc1_735bab55","line":8,"updated":"2015-05-12 08:28:53.000000000","message":"Cleanup \u0027scheduled_at\u0027 would be more consistent with the name of the blueprint?","commit_id":"4681e9d83e4030f617a2aa8edf252c1eb1d4994e"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"f3458fe26db22a9a1307361bb4187817c6737c76","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Remove \u0027scheduled_at\u0027 column in nova instances table"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/cleanup-scheduled-at"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a0c5dc1_3e270a14","line":8,"in_reply_to":"9a0c5dc1_735bab55","updated":"2015-05-13 05:28:38.000000000","message":"Done","commit_id":"4681e9d83e4030f617a2aa8edf252c1eb1d4994e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e68018cfeb65665b1568c3f1c63f5b9f40d50a47","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Use Cases"},{"line_number":34,"context_line":"----------"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* This is a cleanup effort on the instances table."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Project Priority"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a0c5dc1_b3ec8390","line":36,"updated":"2015-05-12 08:28:53.000000000","message":"Nit: no need for the bullet here.","commit_id":"4681e9d83e4030f617a2aa8edf252c1eb1d4994e"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"f3458fe26db22a9a1307361bb4187817c6737c76","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Use Cases"},{"line_number":34,"context_line":"----------"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* This is a cleanup effort on the instances table."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Project Priority"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a0c5dc1_9e7ef6e2","line":36,"in_reply_to":"9a0c5dc1_b3ec8390","updated":"2015-05-13 05:28:38.000000000","message":"Done","commit_id":"4681e9d83e4030f617a2aa8edf252c1eb1d4994e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e68018cfeb65665b1568c3f1c63f5b9f40d50a47","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Proposed change"},{"line_number":46,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":47,"context_line":"Estimated changes are going to be in the following places:"},{"line_number":48,"context_line":"* Remove the sqlalchemy initializations for the \u0027scheduled_at\u0027 field"},{"line_number":49,"context_line":"* Remove all unit tests, involving this field."},{"line_number":50,"context_line":"* Ensure that the NovaObjects adapt to this change for handling"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a0c5dc1_f399db20","line":47,"updated":"2015-05-12 08:28:53.000000000","message":"are you sure this renders correctly? I think you need a few new lines in here really.\n\nSee how it looks here:\nhttp://docs-draft.openstack.org/20/180120/1/check/gate-nova-specs-docs/17b16f0//doc/build/html/specs/liberty/approved/cleanup-scheduled-at.html","commit_id":"4681e9d83e4030f617a2aa8edf252c1eb1d4994e"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"f3458fe26db22a9a1307361bb4187817c6737c76","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Proposed change"},{"line_number":46,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":47,"context_line":"Estimated changes are going to be in the following places:"},{"line_number":48,"context_line":"* Remove the sqlalchemy initializations for the \u0027scheduled_at\u0027 field"},{"line_number":49,"context_line":"* Remove all unit tests, involving this field."},{"line_number":50,"context_line":"* Ensure that the NovaObjects adapt to this change for handling"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a0c5dc1_de4b4eaf","line":47,"in_reply_to":"9a0c5dc1_f399db20","updated":"2015-05-13 05:28:38.000000000","message":"Done","commit_id":"4681e9d83e4030f617a2aa8edf252c1eb1d4994e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e68018cfeb65665b1568c3f1c63f5b9f40d50a47","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Data model impact"},{"line_number":60,"context_line":"-----------------"},{"line_number":61,"context_line":"None"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"REST API impact"},{"line_number":64,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a0c5dc1_731deb0e","line":61,"updated":"2015-05-12 08:28:53.000000000","message":"Does this suggest you are not actually removing the column from the database?\n\nI am guessing that we are actually safe to drop this column.","commit_id":"4681e9d83e4030f617a2aa8edf252c1eb1d4994e"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"f3458fe26db22a9a1307361bb4187817c6737c76","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Data model impact"},{"line_number":60,"context_line":"-----------------"},{"line_number":61,"context_line":"None"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"REST API impact"},{"line_number":64,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a0c5dc1_7ed102cd","line":61,"in_reply_to":"9a0c5dc1_731deb0e","updated":"2015-05-13 05:28:38.000000000","message":"Done","commit_id":"4681e9d83e4030f617a2aa8edf252c1eb1d4994e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e68018cfeb65665b1568c3f1c63f5b9f40d50a47","unresolved":false,"context_lines":[{"line_number":102,"context_line":"Assignee(s)"},{"line_number":103,"context_line":"-----------"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Primary assignee:"},{"line_number":106,"context_line":"* Sudipta Biswas sbiswas7@in.ibm.com"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a0c5dc1_53aae71a","line":105,"updated":"2015-05-12 08:28:53.000000000","message":"you need a new line in here, ideally, see:\nhttp://docs-draft.openstack.org/20/180120/1/check/gate-nova-specs-docs/17b16f0//doc/build/html/specs/liberty/approved/cleanup-scheduled-at.html","commit_id":"4681e9d83e4030f617a2aa8edf252c1eb1d4994e"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"f3458fe26db22a9a1307361bb4187817c6737c76","unresolved":false,"context_lines":[{"line_number":102,"context_line":"Assignee(s)"},{"line_number":103,"context_line":"-----------"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Primary assignee:"},{"line_number":106,"context_line":"* Sudipta Biswas sbiswas7@in.ibm.com"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a0c5dc1_3edcaae3","line":105,"in_reply_to":"9a0c5dc1_53aae71a","updated":"2015-05-13 05:28:38.000000000","message":"Done","commit_id":"4681e9d83e4030f617a2aa8edf252c1eb1d4994e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e68018cfeb65665b1568c3f1c63f5b9f40d50a47","unresolved":false,"context_lines":[{"line_number":103,"context_line":"-----------"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Primary assignee:"},{"line_number":106,"context_line":"* Sudipta Biswas sbiswas7@in.ibm.com"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Work Items"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a0c5dc1_f3679b23","line":106,"updated":"2015-05-12 08:28:53.000000000","message":"I would leave off your email and put your launchpad id, but its up to you.","commit_id":"4681e9d83e4030f617a2aa8edf252c1eb1d4994e"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"f3458fe26db22a9a1307361bb4187817c6737c76","unresolved":false,"context_lines":[{"line_number":103,"context_line":"-----------"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Primary assignee:"},{"line_number":106,"context_line":"* Sudipta Biswas sbiswas7@in.ibm.com"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Work Items"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a0c5dc1_1e00c633","line":106,"in_reply_to":"9a0c5dc1_f3679b23","updated":"2015-05-13 05:28:38.000000000","message":"Done","commit_id":"4681e9d83e4030f617a2aa8edf252c1eb1d4994e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e68018cfeb65665b1568c3f1c63f5b9f40d50a47","unresolved":false,"context_lines":[{"line_number":109,"context_line":"Work Items"},{"line_number":110,"context_line":"----------"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"1. Remove all the column initialization for \u0027scheduled_at\u0027."},{"line_number":113,"context_line":"2. Change the instances object module for migration related issues."},{"line_number":114,"context_line":"3. Remove all dormant unit tests for this column."},{"line_number":115,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a0c5dc1_337413fc","line":112,"updated":"2015-05-12 08:28:53.000000000","message":"Thats not possible.\n\nDo you mean add a migration to drop the column?\n\nAlso I guess you mean drop the column from the sqlalchemy model?","commit_id":"4681e9d83e4030f617a2aa8edf252c1eb1d4994e"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"f3458fe26db22a9a1307361bb4187817c6737c76","unresolved":false,"context_lines":[{"line_number":109,"context_line":"Work Items"},{"line_number":110,"context_line":"----------"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"1. Remove all the column initialization for \u0027scheduled_at\u0027."},{"line_number":113,"context_line":"2. Change the instances object module for migration related issues."},{"line_number":114,"context_line":"3. Remove all dormant unit tests for this column."},{"line_number":115,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a0c5dc1_5ea4fe55","line":112,"in_reply_to":"9a0c5dc1_337413fc","updated":"2015-05-13 05:28:38.000000000","message":"Yeah I actually meant dropping the column from sqlalchemy. Done.","commit_id":"4681e9d83e4030f617a2aa8edf252c1eb1d4994e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e68018cfeb65665b1568c3f1c63f5b9f40d50a47","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"1. Remove all the column initialization for \u0027scheduled_at\u0027."},{"line_number":113,"context_line":"2. Change the instances object module for migration related issues."},{"line_number":114,"context_line":"3. Remove all dormant unit tests for this column."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a0c5dc1_b3d5a3ba","line":114,"updated":"2015-05-12 08:28:53.000000000","message":"minor nit: I wouldn\u0027t add that here, its implicitly part of (1) and (2) really.","commit_id":"4681e9d83e4030f617a2aa8edf252c1eb1d4994e"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"f3458fe26db22a9a1307361bb4187817c6737c76","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"1. Remove all the column initialization for \u0027scheduled_at\u0027."},{"line_number":113,"context_line":"2. Change the instances object module for migration related issues."},{"line_number":114,"context_line":"3. Remove all dormant unit tests for this column."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a0c5dc1_9ec156e7","line":114,"in_reply_to":"9a0c5dc1_b3d5a3ba","updated":"2015-05-13 05:28:38.000000000","message":"Done","commit_id":"4681e9d83e4030f617a2aa8edf252c1eb1d4994e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d304040a8003b11bbbf85d27dc778c2ebbf51644","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"The \u0027scheduled_at\u0027 column in the nova instances table is now"},{"line_number":23,"context_line":"redundant. This field was estwhile used by the scheduler to denote"},{"line_number":24,"context_line":"the time of the instance scheduling."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Now since all of the basic VM lifecyle operations go through the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_023882d2","line":23,"updated":"2015-06-05 16:01:25.000000000","message":"Actually could we add the commit were it stopped being used, so we can check which release that was?","commit_id":"14e9a3b8668630564f3b36976e96f8fff48044d1"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"1afc9faee3671a5b730d5a69a6120b6b70107e77","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"1. Drop the column for \u0027scheduled_at\u0027 from Sqlalchemy model."},{"line_number":118,"context_line":"2. Add migration to drop the column from the instances table."},{"line_number":119,"context_line":"3. Change the instances object module for migration related issues."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_f722c6b8","line":119,"updated":"2015-06-05 15:59:48.000000000","message":"not sure about the ordering here, but I will ignore that, its best dealt with in the code review.","commit_id":"14e9a3b8668630564f3b36976e96f8fff48044d1"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"e244822319e210a7550091c886afe3022776d1d8","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"1. Drop the column for \u0027scheduled_at\u0027 from Sqlalchemy model."},{"line_number":118,"context_line":"2. Add migration to drop the column from the instances table."},{"line_number":119,"context_line":"3. Change the instances object module for migration related issues."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_b49afa12","line":119,"in_reply_to":"3afb71cf_f722c6b8","updated":"2015-06-06 03:23:08.000000000","message":"Done","commit_id":"14e9a3b8668630564f3b36976e96f8fff48044d1"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e030f245a33901102ba11b39def32e61f7fb38ab","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"The \u0027scheduled_at\u0027 column in the nova instances table is now"},{"line_number":23,"context_line":"redundant. This field was estwhile used by the scheduler to denote"},{"line_number":24,"context_line":"the time of the instance scheduling. The commit that removed it is:"},{"line_number":25,"context_line":"https://review.openstack.org/#/c/143725/"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3afb71cf_bf64e748","line":23,"updated":"2015-06-08 16:58:33.000000000","message":"I think you mean \"erstwhile\" here? However, \"formerly\" would be more appropriate.","commit_id":"c3bcc1f5e6dd3bf1595b0e7f858036455873804f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"090988b630205a01bf336fc8f5c125a1c1a06590","unresolved":false,"context_lines":[{"line_number":22,"context_line":"The \u0027scheduled_at\u0027 column in the nova instances table is now"},{"line_number":23,"context_line":"redundant. This field was estwhile used by the scheduler to denote"},{"line_number":24,"context_line":"the time of the instance scheduling. The commit that removed it is:"},{"line_number":25,"context_line":"https://review.openstack.org/#/c/143725/"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Now since all of the basic VM lifecyle operations go through the"},{"line_number":28,"context_line":"scheduler, the \u0027launched_at\u0027 field is sufficient for the above"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3afb71cf_b38310cc","line":25,"updated":"2015-06-08 12:06:18.000000000","message":"It was dropped in early kilo I think, given this commit:\nhttps://github.com/openstack/nova/commit/cd16fa7b485e53f611a3f831569ddacce5393368\n\nSo we should be OK.","commit_id":"c3bcc1f5e6dd3bf1595b0e7f858036455873804f"}]}