)]}'
{"specs/liberty/approved/service-status-notification.rst":[{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"69341e572eb1d7ba8748ba7275dcd1ef567d7867","unresolved":false,"context_lines":[{"line_number":102,"context_line":"---------------------"},{"line_number":103,"context_line":"A new configuration parameter notify_service_status will be introduced to"},{"line_number":104,"context_line":"nova.conf with a default value False so that Deployer needs to explicitly"},{"line_number":105,"context_line":"enable this new notification."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Developer impact"},{"line_number":108,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a0c5dc1_afbe38fd","line":105,"updated":"2015-05-12 19:14:03.000000000","message":"I\u0027m not sure I see the value in a separate flag to turn this on. Are there good reasons people might want to disable these notifications?","commit_id":"7ec63b79aa08a6669996200ecd4d62b3f857341a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"eebc1b78cfe8e7974d75669b9356b3e291b936df","unresolved":false,"context_lines":[{"line_number":102,"context_line":"---------------------"},{"line_number":103,"context_line":"A new configuration parameter notify_service_status will be introduced to"},{"line_number":104,"context_line":"nova.conf with a default value False so that Deployer needs to explicitly"},{"line_number":105,"context_line":"enable this new notification."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Developer impact"},{"line_number":108,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a0c5dc1_f7be35fe","line":105,"in_reply_to":"9a0c5dc1_afbe38fd","updated":"2015-05-13 07:04:52.000000000","message":"Honestly I\u0027ve just tried to follow the existing pattern where certain types of notification can be turned on and off with a config flag. \nAs this does not generate big amount of notification I have no objection removing this config option from the spec.","commit_id":"7ec63b79aa08a6669996200ecd4d62b3f857341a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"48c80bbcc3764c59b1666a6ee9977ec825c25c21","unresolved":false,"context_lines":[{"line_number":15,"context_line":"nova-manage tool or via os-services/disable API. Having such a notification"},{"line_number":16,"context_line":"helps to measure the length of maintenance windows or notify users about"},{"line_number":17,"context_line":"maintenance actions that possibly effect the operation of the"},{"line_number":18,"context_line":"infrastructure."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_e249e6d1","line":18,"updated":"2015-06-05 16:18:25.000000000","message":"Currently users should not consume notifications, because they are un protected and unversioned.","commit_id":"2f75722ff315cc26054d0162a889cf9f75eb2bc9"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"925e722462269fcd6838cb186983149ba272c3ef","unresolved":false,"context_lines":[{"line_number":15,"context_line":"nova-manage tool or via os-services/disable API. Having such a notification"},{"line_number":16,"context_line":"helps to measure the length of maintenance windows or notify users about"},{"line_number":17,"context_line":"maintenance actions that possibly effect the operation of the"},{"line_number":18,"context_line":"infrastructure."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_7d8adb1c","line":18,"in_reply_to":"3afb71cf_e249e6d1","updated":"2015-06-09 12:44:41.000000000","message":"Today it is possible to consume notification via Ceilometer\u0027s alarm interface. The sample policy.json suggest this API should be admin only, but deployer can change that to allow consuming alarms for tenants. Ceilometer API is stable and versioned so I don\u0027t see this as such a big problem. There is even an enhancement effort to have better response time for event based alarms. See https://review.openstack.org/#/c/172893/4/specs/liberty/notification-alarm-evaluator.rst,cm \nAlso my proposal does not change this situation in Ceilometer. \nI\u0027ve updated the spec so that it clarifies this existing possibility","commit_id":"2f75722ff315cc26054d0162a889cf9f75eb2bc9"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"48c80bbcc3764c59b1666a6ee9977ec825c25c21","unresolved":false,"context_lines":[{"line_number":29,"context_line":"information might be part of the agreement between Deployer and End User."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"End User wants to get notification about maintenance actions so that she can"},{"line_number":32,"context_line":"act on the possible service level change."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Project Priority"},{"line_number":35,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_226ede2f","line":32,"updated":"2015-06-05 16:18:25.000000000","message":"This is not a solution for that, due to the versioning and stability issues.\n\nNow there is talk of making such a system:\nhttps://etherpad.openstack.org/p/liberty-cross-project-user-notifications","commit_id":"2f75722ff315cc26054d0162a889cf9f75eb2bc9"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"925e722462269fcd6838cb186983149ba272c3ef","unresolved":false,"context_lines":[{"line_number":29,"context_line":"information might be part of the agreement between Deployer and End User."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"End User wants to get notification about maintenance actions so that she can"},{"line_number":32,"context_line":"act on the possible service level change."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Project Priority"},{"line_number":35,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_dd530f6a","line":32,"in_reply_to":"3afb71cf_226ede2f","updated":"2015-06-09 12:44:41.000000000","message":"See my Ceilometer related answer above. I can remove this use case from the spec but it does not change the fact that the notifications can be externalized via Ceilometer already.","commit_id":"2f75722ff315cc26054d0162a889cf9f75eb2bc9"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"48c80bbcc3764c59b1666a6ee9977ec825c25c21","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Project Priority"},{"line_number":35,"context_line":"-----------------"},{"line_number":36,"context_line":"Libery priorities hasn\u0027t been defined."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_e220c6f9","line":36,"updated":"2015-06-05 16:18:25.000000000","message":"This isn\u0027t one of them, I am afraid.","commit_id":"2f75722ff315cc26054d0162a889cf9f75eb2bc9"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"925e722462269fcd6838cb186983149ba272c3ef","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Project Priority"},{"line_number":35,"context_line":"-----------------"},{"line_number":36,"context_line":"Libery priorities hasn\u0027t been defined."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_5d0b9f8e","line":36,"in_reply_to":"3afb71cf_e220c6f9","updated":"2015-06-09 12:44:41.000000000","message":"You are right.\nDone","commit_id":"2f75722ff315cc26054d0162a889cf9f75eb2bc9"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"48c80bbcc3764c59b1666a6ee9977ec825c25c21","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Then ceilometer can receive these notifications and the Deployer and"},{"line_number":54,"context_line":"the End User can define and subscribe for alarms related to these"},{"line_number":55,"context_line":"notifications."},{"line_number":56,"context_line":"Alternatively other third party tools like StackTach can receive the new"},{"line_number":57,"context_line":"notifications via AMQP."},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_c2e26a9f","line":55,"updated":"2015-06-05 16:18:25.000000000","message":"I would by happier if it were just the deployer.","commit_id":"2f75722ff315cc26054d0162a889cf9f75eb2bc9"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"925e722462269fcd6838cb186983149ba272c3ef","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Then ceilometer can receive these notifications and the Deployer and"},{"line_number":54,"context_line":"the End User can define and subscribe for alarms related to these"},{"line_number":55,"context_line":"notifications."},{"line_number":56,"context_line":"Alternatively other third party tools like StackTach can receive the new"},{"line_number":57,"context_line":"notifications via AMQP."},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_3d3903f3","line":55,"in_reply_to":"3afb71cf_c2e26a9f","updated":"2015-06-09 12:44:41.000000000","message":"I can remove this from the spec but Ceilometer with a modified policy.json file already allows consuming notifications for tenants via alarms.","commit_id":"2f75722ff315cc26054d0162a889cf9f75eb2bc9"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"48c80bbcc3764c59b1666a6ee9977ec825c25c21","unresolved":false,"context_lines":[{"line_number":89,"context_line":"* service.disabled_reason"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"where service refers to the given instance of the Service object in nova."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Other end user impact"},{"line_number":94,"context_line":"---------------------"},{"line_number":95,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_629f3604","line":92,"updated":"2015-06-05 16:18:25.000000000","message":"Please define more information about the format of the JSON payload here.","commit_id":"2f75722ff315cc26054d0162a889cf9f75eb2bc9"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"925e722462269fcd6838cb186983149ba272c3ef","unresolved":false,"context_lines":[{"line_number":89,"context_line":"* service.disabled_reason"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"where service refers to the given instance of the Service object in nova."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Other end user impact"},{"line_number":94,"context_line":"---------------------"},{"line_number":95,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_e504e918","line":92,"in_reply_to":"3afb71cf_629f3604","updated":"2015-06-09 12:44:41.000000000","message":"Done","commit_id":"2f75722ff315cc26054d0162a889cf9f75eb2bc9"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a25be87a0f1a6116b068eb877bb50480e21e32eb","unresolved":false,"context_lines":[{"line_number":28,"context_line":"administratively due to troubleshooting or maintenance actions as this"},{"line_number":29,"context_line":"information might be part of the agreement between Deployer and End User."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"End User wants to get notification about maintenance actions so that she can"},{"line_number":32,"context_line":"act on the possible service level change. The End User cannot directly consume"},{"line_number":33,"context_line":"this notification but the Deployer can either configure ceilometer to allow"},{"line_number":34,"context_line":"End User to consume this notification via alarms or the Deployer can use a"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_6bcdd185","line":31,"updated":"2015-06-19 09:19:41.000000000","message":"I think we should remove this, as I don\u0027t want to encourage end users to consume nova notifications at this point.","commit_id":"8b859e9d9647297dbe9e593b3c6c9b3ed4db52f3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"199ff0c72a6d296044f5661c70cf030a7c9d4b89","unresolved":false,"context_lines":[{"line_number":28,"context_line":"administratively due to troubleshooting or maintenance actions as this"},{"line_number":29,"context_line":"information might be part of the agreement between Deployer and End User."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"End User wants to get notification about maintenance actions so that she can"},{"line_number":32,"context_line":"act on the possible service level change. The End User cannot directly consume"},{"line_number":33,"context_line":"this notification but the Deployer can either configure ceilometer to allow"},{"line_number":34,"context_line":"End User to consume this notification via alarms or the Deployer can use a"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_dcb385e8","line":31,"in_reply_to":"fa32b979_6bcdd185","updated":"2015-06-19 10:32:34.000000000","message":"I\u0027ve removed the problematic part from the spec. I accept the even if it can be done this way today we don\u0027t want to promote this use case in the documentation of Nova.","commit_id":"8b859e9d9647297dbe9e593b3c6c9b3ed4db52f3"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"bfb2c9af593d9451325fcc36a1d0d7125d6f799e","unresolved":false,"context_lines":[{"line_number":82,"context_line":"Notifications impact"},{"line_number":83,"context_line":"--------------------"},{"line_number":84,"context_line":"A new notification service.status will be introduced with INFO priority and"},{"line_number":85,"context_line":"with the follwing payload schema::"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    {\"type\": \"object\","},{"line_number":88,"context_line":"     \"properties\": {"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1af86dd1_d579fb30","line":85,"updated":"2015-06-12 21:31:19.000000000","message":"There was talk at the summit of standardizing our notifications within a Notification Nova object to help consumers not need to track multiple formats.  While I\u0027m in favor of this proposal I would like to see it work together with the object effort.\n\nI\u0027m not sure there\u0027s a spec up for that yet but there should be one at some point.  If it doesn\u0027t seem to be forthcoming in this cycle I would be okay with this moving forward and not being blocked on it.","commit_id":"8b859e9d9647297dbe9e593b3c6c9b3ed4db52f3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9fdf968f915c3646136a4105033c4055b9a870f3","unresolved":false,"context_lines":[{"line_number":82,"context_line":"Notifications impact"},{"line_number":83,"context_line":"--------------------"},{"line_number":84,"context_line":"A new notification service.status will be introduced with INFO priority and"},{"line_number":85,"context_line":"with the follwing payload schema::"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    {\"type\": \"object\","},{"line_number":88,"context_line":"     \"properties\": {"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_2794bc89","line":85,"in_reply_to":"1af86dd1_d579fb30","updated":"2015-06-15 07:23:40.000000000","message":"I agree with you. I\u0027m happy to help with the notification standardization work. But I also would like to move this small spec forward as it seems the spec for the notification standardization is not up on review yet and spec deadline is mid next week.","commit_id":"8b859e9d9647297dbe9e593b3c6c9b3ed4db52f3"}],"specs/mitaka/approved/service-status-notification.rst":[{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"669d2bd4f7d754fe6e511a72d855454dfacdd1c6","unresolved":false,"context_lines":[{"line_number":76,"context_line":"Notifications impact"},{"line_number":77,"context_line":"--------------------"},{"line_number":78,"context_line":"A new notification service.status will be introduced with INFO priority and"},{"line_number":79,"context_line":"with the follwing payload schema::"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    {\"type\": \"object\","},{"line_number":82,"context_line":"     \"properties\": {"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da20952f_77a65010","line":79,"updated":"2015-09-05 15:11:46.000000000","message":"s/follwing/following/","commit_id":"5c93828dfc20dbae73b8f58e5eefdb8254fe8165"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"79c8f61dc7f6a263dc4859b635d0d591ffa6c06f","unresolved":false,"context_lines":[{"line_number":76,"context_line":"Notifications impact"},{"line_number":77,"context_line":"--------------------"},{"line_number":78,"context_line":"A new notification service.status will be introduced with INFO priority and"},{"line_number":79,"context_line":"with the follwing payload schema::"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    {\"type\": \"object\","},{"line_number":82,"context_line":"     \"properties\": {"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba15a1d1_c0d139fd","line":79,"in_reply_to":"da20952f_77a65010","updated":"2015-09-14 12:07:17.000000000","message":"Done","commit_id":"5c93828dfc20dbae73b8f58e5eefdb8254fe8165"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"09c171ebb675d13d6a4a72f6db1f5382e68934a4","unresolved":false,"context_lines":[{"line_number":93,"context_line":"         },"},{"line_number":94,"context_line":"         \"disabled\": {"},{"line_number":95,"context_line":"             \"type\": \"boolean\""},{"line_number":96,"context_line":"         }"},{"line_number":97,"context_line":"     },"},{"line_number":98,"context_line":"     \"required\": ["},{"line_number":99,"context_line":"         \"host\","}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a1a9d01_269f0861","line":96,"updated":"2015-09-24 15:10:59.000000000","message":"Can you add force_down here as well, and fire the notification for that reason too?","commit_id":"dfda4d1c2b2cd093733cde3920af1623e7f9e348"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6cea73b1dd7de60dc303b4ae484b42afde15821a","unresolved":false,"context_lines":[{"line_number":93,"context_line":"         },"},{"line_number":94,"context_line":"         \"disabled\": {"},{"line_number":95,"context_line":"             \"type\": \"boolean\""},{"line_number":96,"context_line":"         }"},{"line_number":97,"context_line":"     },"},{"line_number":98,"context_line":"     \"required\": ["},{"line_number":99,"context_line":"         \"host\","}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a1a9d01_decb151d","line":96,"in_reply_to":"9a1a9d01_269f0861","updated":"2015-09-28 10:04:57.000000000","message":"Good point. I extended the notification with the forced_down information.","commit_id":"dfda4d1c2b2cd093733cde3920af1623e7f9e348"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"09c171ebb675d13d6a4a72f6db1f5382e68934a4","unresolved":false,"context_lines":[{"line_number":147,"context_line":"----------"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"* Create a common code path for nova-manage and os-service so that both"},{"line_number":150,"context_line":"  action use the Service object"},{"line_number":151,"context_line":"* Send a new notification if the disabled field of the Service object is"},{"line_number":152,"context_line":"  updated"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a1a9d01_e6035075","line":150,"updated":"2015-09-24 15:10:59.000000000","message":"I actually think we should exclude nova-manage from this, as it is currently only a DB-targeted tool. Further, its use for anything other that critical DB operations is discouraged (even deprecated).\n\nIf operators want the notification, they should do it via the API, which is the right way anyway. Can we just remove that from this spec?","commit_id":"dfda4d1c2b2cd093733cde3920af1623e7f9e348"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6cea73b1dd7de60dc303b4ae484b42afde15821a","unresolved":false,"context_lines":[{"line_number":147,"context_line":"----------"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"* Create a common code path for nova-manage and os-service so that both"},{"line_number":150,"context_line":"  action use the Service object"},{"line_number":151,"context_line":"* Send a new notification if the disabled field of the Service object is"},{"line_number":152,"context_line":"  updated"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a1a9d01_beef4186","line":150,"in_reply_to":"9a1a9d01_e6035075","updated":"2015-09-28 10:04:57.000000000","message":"Done","commit_id":"dfda4d1c2b2cd093733cde3920af1623e7f9e348"},{"author":{"_account_id":15834,"name":"Tomi Juvonen","email":"tomi.juvonen@nokia.com","username":"tojuvone"},"change_message_id":"50eb81fe5d5080cef77441cf51da87add9968f20","unresolved":false,"context_lines":[{"line_number":28,"context_line":"administratively due to troubleshooting or maintenance actions as this"},{"line_number":29,"context_line":"information might be part of the agreement between Deployer and End User."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Deplyoer wantss to measure the time certain nova services was forced down due"},{"line_number":32,"context_line":"to an externally detected error as this information might be part of the"},{"line_number":33,"context_line":"agreement between Deployer and End User."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"9a1a9d01_bc59f2fe","line":31,"updated":"2015-10-01 09:19:59.000000000","message":"wantss with double s","commit_id":"d4d3bcad422133e6d069beaa6158f08e473ef4b9"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"90fbb86ee2ef1d274d10e480d95f99c679d973ff","unresolved":false,"context_lines":[{"line_number":28,"context_line":"administratively due to troubleshooting or maintenance actions as this"},{"line_number":29,"context_line":"information might be part of the agreement between Deployer and End User."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Deplyoer wantss to measure the time certain nova services was forced down due"},{"line_number":32,"context_line":"to an externally detected error as this information might be part of the"},{"line_number":33,"context_line":"agreement between Deployer and End User."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"9a1a9d01_26f14896","line":31,"in_reply_to":"9a1a9d01_bc59f2fe","updated":"2015-10-01 13:43:07.000000000","message":"Done","commit_id":"d4d3bcad422133e6d069beaa6158f08e473ef4b9"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"388fe1c15f457bb099cd56e4413605405ae4ebb4","unresolved":false,"context_lines":[{"line_number":28,"context_line":"administratively due to troubleshooting or maintenance actions as this"},{"line_number":29,"context_line":"information might be part of the agreement between Deployer and End User."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Deplyoer wants to measure the time certain nova services was forced down due"},{"line_number":32,"context_line":"to an externally detected error as this information might be part of the"},{"line_number":33,"context_line":"agreement between Deployer and End User."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a1a9d01_a3cd3888","line":31,"updated":"2015-10-01 19:46:36.000000000","message":"typo, Deployer","commit_id":"ac27e7d78c13ed60e14d081d40935eb12d35efa0"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7a1f9cc887c4f5cb502c166cdc4735740bc560f6","unresolved":false,"context_lines":[{"line_number":28,"context_line":"administratively due to troubleshooting or maintenance actions as this"},{"line_number":29,"context_line":"information might be part of the agreement between Deployer and End User."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Deplyoer wants to measure the time certain nova services was forced down due"},{"line_number":32,"context_line":"to an externally detected error as this information might be part of the"},{"line_number":33,"context_line":"agreement between Deployer and End User."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a1a9d01_f273e5e5","line":31,"in_reply_to":"9a1a9d01_a3cd3888","updated":"2015-10-02 08:47:00.000000000","message":"Done","commit_id":"ac27e7d78c13ed60e14d081d40935eb12d35efa0"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"388fe1c15f457bb099cd56e4413605405ae4ebb4","unresolved":false,"context_lines":[{"line_number":47,"context_line":"* /v2/{tenant_id}/os-services/disable"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"* /v2/{tenant_id}/os-services/enable"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Then ceilometer can receive these notifications and the length of the"},{"line_number":52,"context_line":"maintenance window can be calculated via ceilometer queries."},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a1a9d01_03ec248e","line":50,"updated":"2015-10-01 19:46:36.000000000","message":"disable-log-reason force-down also need mentioned?","commit_id":"ac27e7d78c13ed60e14d081d40935eb12d35efa0"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7a1f9cc887c4f5cb502c166cdc4735740bc560f6","unresolved":false,"context_lines":[{"line_number":47,"context_line":"* /v2/{tenant_id}/os-services/disable"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"* /v2/{tenant_id}/os-services/enable"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Then ceilometer can receive these notifications and the length of the"},{"line_number":52,"context_line":"maintenance window can be calculated via ceilometer queries."},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a1a9d01_b22b2d94","line":50,"in_reply_to":"9a1a9d01_03ec248e","updated":"2015-10-02 08:47:00.000000000","message":"Good catch. Done","commit_id":"ac27e7d78c13ed60e14d081d40935eb12d35efa0"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"388fe1c15f457bb099cd56e4413605405ae4ebb4","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        \"binary\": \"nova-compute\","},{"line_number":131,"context_line":"        \"host\": \"Devstack\","},{"line_number":132,"context_line":"        \"disabled_reason\": \"my reason\","},{"line_number":133,"context_line":"        \"forced_down\": false}"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Other end user impact"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a1a9d01_be0f8b2d","line":133,"updated":"2015-10-01 19:46:36.000000000","message":"force down is added by microversion\nhow can we handle it given some API less than 2.11?","commit_id":"ac27e7d78c13ed60e14d081d40935eb12d35efa0"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"0c98fdf96a2cf1c50011b64cff6e92b749c3ff20","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        \"binary\": \"nova-compute\","},{"line_number":131,"context_line":"        \"host\": \"Devstack\","},{"line_number":132,"context_line":"        \"disabled_reason\": \"my reason\","},{"line_number":133,"context_line":"        \"forced_down\": false}"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Other end user impact"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a1a9d01_aeebc1af","line":133,"in_reply_to":"9a1a9d01_956133d6","updated":"2015-10-02 12:18:45.000000000","message":"ok, make sense","commit_id":"ac27e7d78c13ed60e14d081d40935eb12d35efa0"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7a1f9cc887c4f5cb502c166cdc4735740bc560f6","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        \"binary\": \"nova-compute\","},{"line_number":131,"context_line":"        \"host\": \"Devstack\","},{"line_number":132,"context_line":"        \"disabled_reason\": \"my reason\","},{"line_number":133,"context_line":"        \"forced_down\": false}"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Other end user impact"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a1a9d01_956133d6","line":133,"in_reply_to":"9a1a9d01_be0f8b2d","updated":"2015-10-02 08:47:00.000000000","message":"The object model and the DB contains the forced_down flag even if the clients use microversion \u003c 2.11 in their requests. So the data is there but it will never be anything other than false which is the value when the service is created. So technically it is possible to send the notification with this above defined content regardless of the API microversion used in the requests.","commit_id":"ac27e7d78c13ed60e14d081d40935eb12d35efa0"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"05d7841aa38d73399a25d778b750b8a7fae0d275","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Service status can be changed in the nova db directly via nova-manage command"},{"line_number":62,"context_line":"but notification will not be sent for that command as nova-manage is intended"},{"line_number":63,"context_line":"for critical db operation only."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7a2fa921_0bb67c8a","line":63,"updated":"2015-10-06 00:54:19.000000000","message":"If we offer this through the API now is there a good reason to keep this functionality in nova-manage at all? Perhaps its time for it to move to just python-novaclient?","commit_id":"dd4ce47b636fa96c80f7c4c33bbc4a94b125a61e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c7cfe7a83ddc7375ce7a5c098595cc86eadb3aa7","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Service status can be changed in the nova db directly via nova-manage command"},{"line_number":62,"context_line":"but notification will not be sent for that command as nova-manage is intended"},{"line_number":63,"context_line":"for critical db operation only."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7a2fa921_ae48b65c","line":63,"in_reply_to":"7a2fa921_0bb67c8a","updated":"2015-10-06 00:55:58.000000000","message":"Agreed, I said that here:\n\nhttps://review.openstack.org/#/c/182350/7/specs/mitaka/approved/service-status-notification.rst,cm","commit_id":"dd4ce47b636fa96c80f7c4c33bbc4a94b125a61e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a79981edfea4c7bfdc6c33ea2b047a09fab134d8","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Service status can be changed in the nova db directly via nova-manage command"},{"line_number":62,"context_line":"but notification will not be sent for that command as nova-manage is intended"},{"line_number":63,"context_line":"for critical db operation only."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7a2fa921_577967fb","line":63,"in_reply_to":"7a2fa921_0bb67c8a","updated":"2015-10-06 12:00:54.000000000","message":"I removed every reference to the nova-manage command from this spec. I hope this is clearer now.\n\nBTW, I don\u0027t think removing the service status change support should be part of this purely notification related spec but I can create a separate blueprint to remove the nova-manage service command. Do we need a spec for that or a bp is enough?","commit_id":"dd4ce47b636fa96c80f7c4c33bbc4a94b125a61e"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"6637ba81ddd30e897bbb6ed797b50cbb7607c61c","unresolved":false,"context_lines":[{"line_number":113,"context_line":"         \"disabled\","},{"line_number":114,"context_line":"         \"forced_down\""},{"line_number":115,"context_line":"     ],"},{"line_number":116,"context_line":"     \"additionalProperties\": false}"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"where host, binary, disabled_reason, disabled and forced_down refers to the"},{"line_number":119,"context_line":"field of the Service object affected by the status change. The disabled_reason"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7a2fa921_bde7a0ab","line":116,"updated":"2015-10-05 16:56:03.000000000","message":"I don\u0027t want to block on this point, but it would be ideal if the version could also be included in the notification.  It is available with the other fields and should be no real additional work to include it.","commit_id":"dd4ce47b636fa96c80f7c4c33bbc4a94b125a61e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a79981edfea4c7bfdc6c33ea2b047a09fab134d8","unresolved":false,"context_lines":[{"line_number":113,"context_line":"         \"disabled\","},{"line_number":114,"context_line":"         \"forced_down\""},{"line_number":115,"context_line":"     ],"},{"line_number":116,"context_line":"     \"additionalProperties\": false}"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"where host, binary, disabled_reason, disabled and forced_down refers to the"},{"line_number":119,"context_line":"field of the Service object affected by the status change. The disabled_reason"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7a2fa921_774fc392","line":116,"in_reply_to":"7a2fa921_bde7a0ab","updated":"2015-10-06 12:00:54.000000000","message":"I agree that it is no additional work so let\u0027s add the version to the notification as well.","commit_id":"dd4ce47b636fa96c80f7c4c33bbc4a94b125a61e"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c7c0dbbf1639346c2f76ff6e15345e759872d7b4","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Project Priority"},{"line_number":37,"context_line":"----------------"},{"line_number":38,"context_line":"Mitaka priorities hasn\u0027t been defined yet."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7a2fa921_f3308303","line":38,"updated":"2015-10-07 16:07:22.000000000","message":"nit: you should respin to remove that section, see http://lists.openstack.org/pipermail/openstack-dev/2015-October/076326.html","commit_id":"a3cccb9e0ef36dc26cd34aceac15628a84765786"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ca032f5b3bab8f47894a0e9654c9ab57ec3bf3e7","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Project Priority"},{"line_number":37,"context_line":"----------------"},{"line_number":38,"context_line":"Mitaka priorities hasn\u0027t been defined yet."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7a2fa921_534902b6","line":38,"in_reply_to":"7a2fa921_f3308303","updated":"2015-10-08 15:14:00.000000000","message":"Done","commit_id":"a3cccb9e0ef36dc26cd34aceac15628a84765786"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"475d61f0b4a02554cf8f48c5be55e6db438309a6","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Proposed change"},{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"An easy solution for the problem above is to add AMQP notification for the"},{"line_number":39,"context_line":"following actions:"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* /v2/{tenant_id}/os-services/disable"}],"source_content_type":"text/x-rst","patch_set":12,"id":"5a2ca52d_b2e4a90d","line":38,"updated":"2015-10-13 13:16:47.000000000","message":"nit: technically its an olso.messaging notification, with various drivers possible, but thats fine, the point is clear.","commit_id":"7b0add4a555e91289b494fc8876f69cf9c3ca675"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c66bb180cb4334290a89d454a034d621f137b17c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Proposed change"},{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"An easy solution for the problem above is to add AMQP notification for the"},{"line_number":39,"context_line":"following actions:"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* /v2/{tenant_id}/os-services/disable"}],"source_content_type":"text/x-rst","patch_set":12,"id":"5a2ca52d_1b4bdfca","line":38,"in_reply_to":"5a2ca52d_b2e4a90d","updated":"2015-10-15 07:55:11.000000000","message":"Done","commit_id":"7b0add4a555e91289b494fc8876f69cf9c3ca675"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"475d61f0b4a02554cf8f48c5be55e6db438309a6","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        \"host\": \"Devstack\","},{"line_number":130,"context_line":"        \"disabled_reason\": \"my reason\","},{"line_number":131,"context_line":"        \"forced_down\": false,"},{"line_number":132,"context_line":"        \"version\": 0}"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Other end user impact"}],"source_content_type":"text/x-rst","patch_set":12,"id":"5a2ca52d_529f555f","line":132,"updated":"2015-10-13 13:16:47.000000000","message":"so its very tempting to queue this behind:\nhttps://review.openstack.org/#/c/224755/6/specs/mitaka/approved/versioned-notification-api.rst,cm\n\nWhat about just serialising the object here, as described above.","commit_id":"7b0add4a555e91289b494fc8876f69cf9c3ca675"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c66bb180cb4334290a89d454a034d621f137b17c","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        \"host\": \"Devstack\","},{"line_number":130,"context_line":"        \"disabled_reason\": \"my reason\","},{"line_number":131,"context_line":"        \"forced_down\": false,"},{"line_number":132,"context_line":"        \"version\": 0}"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Other end user impact"}],"source_content_type":"text/x-rst","patch_set":12,"id":"5a2ca52d_7b3c532f","line":132,"in_reply_to":"5a2ca52d_529f555f","updated":"2015-10-15 07:55:11.000000000","message":"I agree that if the versioned notification spec gets accepted for Mitaka then this spec should be queued behind it and the rules of versioned notification should be applied on this notification as well.\nI have high hopes about the versioned notifications but as it is quite big change I cannot tell if that is gets accepted for Mitaka or not. However this particular notification has high importance for OPNFV doctor project so I don\u0027t want to be blocked for yet another cycle with this. \n\nI think what we can do is to use a versioned object as a payload in this notification regardless of the versioned notification spec status as it is not forbidden by the current notification rules but do not queue this spec hardly behind the versioned notification spec. I hope this is a good compromise for you as well.","commit_id":"7b0add4a555e91289b494fc8876f69cf9c3ca675"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"28451b62b5a0c2c0cd9caa7a8f094f20a9ab6349","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Today external system cannot get notification based information about the nova"},{"line_number":14,"context_line":"service status. Nova service status can be changed administratively via"},{"line_number":15,"context_line":"os-services/disable API."},{"line_number":16,"context_line":"Having such a notification helps to measure the length of maintenance windows"},{"line_number":17,"context_line":"or indirectly notify users about maintenance actions that possibly effect the"},{"line_number":18,"context_line":"operation of the infrastructure."}],"source_content_type":"text/x-rst","patch_set":13,"id":"1a26ad4f_c5d4aa21","line":15,"updated":"2015-10-30 01:26:50.000000000","message":"nit: blank line between the two paras.","commit_id":"046c90b8fa881fcf227215a05a3cf3a7b854264b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0840cc9927f7231366f653417a20e6c7194b09c7","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Today external system cannot get notification based information about the nova"},{"line_number":14,"context_line":"service status. Nova service status can be changed administratively via"},{"line_number":15,"context_line":"os-services/disable API."},{"line_number":16,"context_line":"Having such a notification helps to measure the length of maintenance windows"},{"line_number":17,"context_line":"or indirectly notify users about maintenance actions that possibly effect the"},{"line_number":18,"context_line":"operation of the infrastructure."}],"source_content_type":"text/x-rst","patch_set":13,"id":"1a26ad4f_41d885ef","line":15,"in_reply_to":"1a26ad4f_c5d4aa21","updated":"2015-10-30 07:33:48.000000000","message":"Done","commit_id":"046c90b8fa881fcf227215a05a3cf3a7b854264b"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"eea0db06c5f2d5bd7da71e4ce84cece4463e9221","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    PUT /v2/{tenant_id}/os-services/disable-log-reason"},{"line_number":93,"context_line":"        {\"host\": \"Devstack\","},{"line_number":94,"context_line":"         \"binary\": \"nova-compute\","},{"line_number":95,"context_line":"         \"disabled_reason\": \"my reason\"}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"The notification would contain the following payload::"}],"source_content_type":"text/x-rst","patch_set":14,"id":"fa80f949_4d8318cd","line":95,"updated":"2015-11-04 15:19:16.000000000","message":"I do not think we should add the reason to the notification message. The disable reason could be an internal/reserved information and putting it in the notification systems we lose the control about who/what can read it.","commit_id":"b4635b5110df2ea66d662c9d0b5a6bb53df94b13"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"bf9da3ea12bb685dee4693c22a7617c8627ca6c0","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    PUT /v2/{tenant_id}/os-services/disable-log-reason"},{"line_number":93,"context_line":"        {\"host\": \"Devstack\","},{"line_number":94,"context_line":"         \"binary\": \"nova-compute\","},{"line_number":95,"context_line":"         \"disabled_reason\": \"my reason\"}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"The notification would contain the following payload::"}],"source_content_type":"text/x-rst","patch_set":14,"id":"fa80f949_ad6401e5","line":95,"in_reply_to":"fa80f949_08789ec3","updated":"2015-11-04 16:05:11.000000000","message":"Agree, let\u0027s do that.","commit_id":"b4635b5110df2ea66d662c9d0b5a6bb53df94b13"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b34c7687a99bbf8cb6b397f05208273f3cb6b180","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    PUT /v2/{tenant_id}/os-services/disable-log-reason"},{"line_number":93,"context_line":"        {\"host\": \"Devstack\","},{"line_number":94,"context_line":"         \"binary\": \"nova-compute\","},{"line_number":95,"context_line":"         \"disabled_reason\": \"my reason\"}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"The notification would contain the following payload::"}],"source_content_type":"text/x-rst","patch_set":14,"id":"fa80f949_c8be16ff","line":95,"in_reply_to":"fa80f949_4d8318cd","updated":"2015-11-04 15:26:49.000000000","message":"Notification is not a end user facing interface. Notifications are emitted to the message bus and to access the message bus one needs admin privileges in the deployment. Therefore I think it is not a problem to include the disable_reason in the notification.\nIf for example ceilometer processes this notification and give and API to the end user then ceilometer shall take care of not publishing sensitive information. \nI think the use case of this spec especially needs the disabled_reason to be included in the notification so that the admin can easily calculate different downtime amounts per reason.","commit_id":"b4635b5110df2ea66d662c9d0b5a6bb53df94b13"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"ed7638a9b0da7a7330f355a68303489f7406b2c9","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    PUT /v2/{tenant_id}/os-services/disable-log-reason"},{"line_number":93,"context_line":"        {\"host\": \"Devstack\","},{"line_number":94,"context_line":"         \"binary\": \"nova-compute\","},{"line_number":95,"context_line":"         \"disabled_reason\": \"my reason\"}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"The notification would contain the following payload::"}],"source_content_type":"text/x-rst","patch_set":14,"id":"fa80f949_0a164855","line":95,"in_reply_to":"fa80f949_ad6401e5","updated":"2015-11-04 20:40:05.000000000","message":"I really do want to expose everything in these notifications since they are a primary resource for operators.  Thanks.","commit_id":"b4635b5110df2ea66d662c9d0b5a6bb53df94b13"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"038ea849ec4280c889ee39b061930eb3caf530c0","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    PUT /v2/{tenant_id}/os-services/disable-log-reason"},{"line_number":93,"context_line":"        {\"host\": \"Devstack\","},{"line_number":94,"context_line":"         \"binary\": \"nova-compute\","},{"line_number":95,"context_line":"         \"disabled_reason\": \"my reason\"}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"The notification would contain the following payload::"}],"source_content_type":"text/x-rst","patch_set":14,"id":"fa80f949_08789ec3","line":95,"in_reply_to":"fa80f949_c8be16ff","updated":"2015-11-04 15:41:34.000000000","message":"ok maybe we can just add a warning about that in the documentation (?) or something similar.","commit_id":"b4635b5110df2ea66d662c9d0b5a6bb53df94b13"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"3a6fd7e1ef1c9cf69b92e86d5d6a6ed0b3c84f99","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                \"forced_down\": false,"},{"line_number":115,"context_line":"                \"version\": 2,"},{"line_number":116,"context_line":"            }"},{"line_number":117,"context_line":"           \"nova_object.changes\":["},{"line_number":118,"context_line":"                \"disabled\","},{"line_number":119,"context_line":"                \"disabled_reason\","},{"line_number":120,"context_line":"                ]"}],"source_content_type":"text/x-rst","patch_set":14,"id":"da85f559_6d9c905d","line":117,"updated":"2015-11-10 21:30:27.000000000","message":"I would caution against including the changed fields in the notification.  This has no meaningful information for consumers of the notification and is not going to be stable.  The value of this field could change at any time for any notification and consumers should not be given a chance to depend on what is in here.","commit_id":"b4635b5110df2ea66d662c9d0b5a6bb53df94b13"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"072c9af0ec9f186638c74218f768059c5a908474","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                \"forced_down\": false,"},{"line_number":115,"context_line":"                \"version\": 2,"},{"line_number":116,"context_line":"            }"},{"line_number":117,"context_line":"           \"nova_object.changes\":["},{"line_number":118,"context_line":"                \"disabled\","},{"line_number":119,"context_line":"                \"disabled_reason\","},{"line_number":120,"context_line":"                ]"}],"source_content_type":"text/x-rst","patch_set":14,"id":"da85f559_31e33535","line":117,"in_reply_to":"da85f559_43a39d00","updated":"2015-11-11 09:25:45.000000000","message":"I agree. I also added a wrapper Payload object to the next patch set to provide a place where the advanced reason change field can be added later without backward compatibility.","commit_id":"b4635b5110df2ea66d662c9d0b5a6bb53df94b13"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"0d289df2638d285f1ee024d4de8eda377ead5a18","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                \"forced_down\": false,"},{"line_number":115,"context_line":"                \"version\": 2,"},{"line_number":116,"context_line":"            }"},{"line_number":117,"context_line":"           \"nova_object.changes\":["},{"line_number":118,"context_line":"                \"disabled\","},{"line_number":119,"context_line":"                \"disabled_reason\","},{"line_number":120,"context_line":"                ]"}],"source_content_type":"text/x-rst","patch_set":14,"id":"da85f559_43a39d00","line":117,"in_reply_to":"da85f559_6d9c905d","updated":"2015-11-10 22:07:32.000000000","message":"After a chat with Dan about this I\u0027ve convinced myself that having the list of changed_fields is useful.  What I\u0027d really like to see is the list of changes, like disabled_reason \"foo\"-\u003e\"bar\" but that is totally out of scope here.","commit_id":"b4635b5110df2ea66d662c9d0b5a6bb53df94b13"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7a7efaac6d61a34c8a6a820c377746b7ed75eb53","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Dependencies"},{"line_number":162,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":163,"context_line":"None"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":14,"id":"da85f559_20ce8f82","line":163,"updated":"2015-11-10 21:51:05.000000000","message":"nit: well, it needs the Versioned Notification spec, right? :-)\n\nYou said it above so I\u0027m fine approving it tho","commit_id":"b4635b5110df2ea66d662c9d0b5a6bb53df94b13"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"072c9af0ec9f186638c74218f768059c5a908474","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Dependencies"},{"line_number":162,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":163,"context_line":"None"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":14,"id":"da85f559_11bdd101","line":163,"in_reply_to":"da85f559_20ce8f82","updated":"2015-11-11 09:25:45.000000000","message":"It is not a hard dependency. On the summit we agreed to add this new notification as the first step of the versioned notification api work to serve us as a carrot motivating the operators to start consuming new versioned notifications.","commit_id":"b4635b5110df2ea66d662c9d0b5a6bb53df94b13"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"bdaea1667237a1e63ae39732d653f6692c348c68","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Please note that the compute_node field will not be serialized into the"},{"line_number":154,"context_line":"notification payload as that will bring in a lot of additional data not needed"},{"line_number":155,"context_line":"here."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Other end user impact"},{"line_number":158,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":15,"id":"da85f559_1c9dd865","line":155,"updated":"2015-11-11 14:26:21.000000000","message":"Hmm, I think thats the correct choice. Its interesting though, its not a complete object, with that field missing:\nhttps://github.com/openstack/nova/blob/master/nova/objects/service.py#L97\n\nGiven we always lazy load the compute node, its actually OK I think. But its really an implementation detail, mostly.","commit_id":"0ebacbe6bad74607e9082e3ae3e06246dd4363e3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"bdaea1667237a1e63ae39732d653f6692c348c68","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"Documentation Impact"},{"line_number":205,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":206,"context_line":"None"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":15,"id":"da85f559_9c7f8816","line":206,"updated":"2015-11-11 14:26:21.000000000","message":"I guess, for now.","commit_id":"0ebacbe6bad74607e9082e3ae3e06246dd4363e3"}]}