)]}'
{"specs/liberty/approved/remove-disable-terminate.rst":[{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"3bd5ebd994e7c4fa514bfc34d66eaf559abbcaf3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/remove-disable-terminate"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Remove the property \"disable_terminate\" from current instance object,"},{"line_number":14,"context_line":"or add an API to modify this property to make it actually functional."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a016987_5d031110","line":14,"updated":"2015-05-14 12:28:31.000000000","message":"Which? According to \"Proposed change\", the former - so remove the latter option.","commit_id":"33e66b5da91efef232806e4aa14fb245fdf00958"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"3bd5ebd994e7c4fa514bfc34d66eaf559abbcaf3","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Add methods to modify this property in Create-instance, Update-instance, etc."},{"line_number":57,"context_line":"Allowing admins to update disable_terminate flag, similar to the lock instance"},{"line_number":58,"context_line":"API. Which make this parameter actually useful."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Data model impact"},{"line_number":61,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a016987_0852f513","line":58,"updated":"2015-05-14 12:28:31.000000000","message":"If you want to ask a question, use the mailing list. If you don\u0027t get an answer after a day or two, post again I guess?\n\nThe \"Alternatives\" section is for explaining what you\u0027re not doing, and why.","commit_id":"33e66b5da91efef232806e4aa14fb245fdf00958"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"d358bc2eb821c3bb2a531f52c5ffc82cd870d32b","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Add methods to modify this property in Create-instance, Update-instance, etc."},{"line_number":57,"context_line":"Allowing admins to update disable_terminate flag, similar to the lock instance"},{"line_number":58,"context_line":"API. Which make this parameter actually useful."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Data model impact"},{"line_number":61,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a016987_0379b693","line":58,"in_reply_to":"7a016987_0852f513","updated":"2015-05-14 12:48:37.000000000","message":"Thank you.This is actually an alternative way to fix this problem, John   agreed with me to remove this parameter directly but add an API is also a good choice, we want to discuss it here to see what other people thinks. Maybe my sentence is confusing, I will fix it.","commit_id":"33e66b5da91efef232806e4aa14fb245fdf00958"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9f69cfabe78d8242da93b7536ae49cc837ca6d82","unresolved":false,"context_lines":[{"line_number":66,"context_line":"---------------"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"If remove the \"disable_terminate\" property, no impact."},{"line_number":69,"context_line":"If add new API, new API will be added or the current API can be modified."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_e163fa3f","line":69,"updated":"2015-06-08 09:39:56.000000000","message":"Sorry this is a bit unclear to me.\n\nI think you mean:\n\"None\"\n\ni.e. there is no API that returns the property, except maybe ec2 where this can be removed.","commit_id":"5d781d4cfe219c2deeb6b49dd9aadc8621f61e14"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"01e597a9964d92327391d18e251d2423bcd39399","unresolved":false,"context_lines":[{"line_number":123,"context_line":"1. Remove instance object property \"disable_terminate\"."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"2. Delete the column ``disable_terminate`` in table ``instances``"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Dependencies"},{"line_number":129,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3afb71cf_ed376bae","line":126,"updated":"2015-06-08 11:11:16.000000000","message":"nit: 3. Remove redundant checks from code","commit_id":"93263ddb320744c0f0cda4deedebc21dd9b8ec61"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"7cf4520796bc5e6bc4895d301f553f8eca36f4b9","unresolved":false,"context_lines":[{"line_number":66,"context_line":"---------------"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"If remove the \"disable_terminate\" property, no impact."},{"line_number":69,"context_line":"If add new API, new API will be added or the current API can be modified."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3afb71cf_e5209f9d","line":69,"updated":"2015-06-08 12:17:52.000000000","message":"Why did you revert the change you made in response to John\u0027s comment on PS#2 please?","commit_id":"945587cb2872d8184c7074c8d0d69f23dfb2e642"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"15c349477c3844aee355d3f39973d075f73777ab","unresolved":false,"context_lines":[{"line_number":66,"context_line":"---------------"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"If remove the \"disable_terminate\" property, no impact."},{"line_number":69,"context_line":"If add new API, new API will be added or the current API can be modified."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3afb71cf_dc21dffc","line":69,"in_reply_to":"3afb71cf_e5209f9d","updated":"2015-06-09 00:08:20.000000000","message":"Sorry I didn\u0027t notice this, it might be a mistake when I use git command","commit_id":"945587cb2872d8184c7074c8d0d69f23dfb2e642"}]}