)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"0c5fa80964d1381fd58a57722eddcb57a8fadf88","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve nova attach volume api to support disk-bus"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The purpose of this spec is to add disk-bus paramter"},{"line_number":10,"context_line":"to nova attach volume api."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ibc3629f10b59fe99b5b8dddefd04c6ea0279394d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"da20952f_fad9e022","line":9,"updated":"2015-09-06 05:37:43.000000000","message":"s/paramter/parameter","commit_id":"22d537b071d8a8e0c04687e49f949dc1178eec77"}],"specs/liberty/approved/enhance-attach-volume-api.rst":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"a3183c14ebb2f549c427dbbc8de2b92e5273c17e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"volume api, which leads to many inconveniences such as the inability for"},{"line_number":25,"context_line":"users to utilize the bus type they desire, the extra care and attention needed"},{"line_number":26,"context_line":"to be paid for the device name that is available on the current instance to be"},{"line_number":27,"context_line":"attached, and so forth."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5afe65bd_c672857c","line":27,"updated":"2015-06-02 08:48:11.000000000","message":"Actually the disk bus is overridable by the user via the \u0027hw_disk_bus\u0027 image property. The only reason I could see for specifying it explicitly in the API was if you wanted one VM to make use of multiple different disk buses at the same time. eg attach a bunch of disks as virtio-blk and later also attach disks as scsi. This seems like a fairly niche use case to me - it feels like  the hw_disk_bus image property ought to be sufficient","commit_id":"0e1ca00ca01859003424d0f17cdc3e7bd63c4cb9"},{"author":{"_account_id":11538,"name":"Zhang Ni","email":"zhangni@huawei.com","username":"zhangni"},"change_message_id":"e445185447d574ada74a6749a0395d40c7843e42","unresolved":false,"context_lines":[{"line_number":24,"context_line":"volume api, which leads to many inconveniences such as the inability for"},{"line_number":25,"context_line":"users to utilize the bus type they desire, the extra care and attention needed"},{"line_number":26,"context_line":"to be paid for the device name that is available on the current instance to be"},{"line_number":27,"context_line":"attached, and so forth."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5afe65bd_9ef8fa4a","line":27,"in_reply_to":"5afe65bd_015f34e6","updated":"2015-06-04 02:28:31.000000000","message":"Hi Daniel, for the three scenario in zhipeng\u0027s comment, we\u0027d better provide a more simple and general solution, and let user decide which disk_bus to use. \nFor hw_disk_bus also can be used, to let image provide decide which disk_bus is better for this image, and we can write another bp to describe this problem. Do you think so?\n\nPS: The third scenario is mainly for SSD disk, which can use qemu scisi or NVMe bus, user can decide to use which bus from a performance view.","commit_id":"0e1ca00ca01859003424d0f17cdc3e7bd63c4cb9"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"9b93294eb4162faf1a805be0483f9260ef2582ba","unresolved":false,"context_lines":[{"line_number":24,"context_line":"volume api, which leads to many inconveniences such as the inability for"},{"line_number":25,"context_line":"users to utilize the bus type they desire, the extra care and attention needed"},{"line_number":26,"context_line":"to be paid for the device name that is available on the current instance to be"},{"line_number":27,"context_line":"attached, and so forth."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5afe65bd_d2347edf","line":27,"in_reply_to":"5afe65bd_af69998d","updated":"2015-06-02 11:17:53.000000000","message":"So your broader problem is that you want one image, but with different properties set for each hypervisor. This really applies to a huge number of things that can be set on the image metadata, so I think if we want to solve that, then we need a more general purpose solution, not a special case for volume disk bus.\n\neg, we could allow a hypervisor specific suffix on all image properties, eg\n\n   hw_disk_bus\u003d\"ide\"\n   hw_disk_bus:kvm\u003d\"scsi\"\n   hw_disk_bus:xen\u003d\"xen\"\n\nor come up with some other general purpose way to vary properties per hypervisor, for use in heterogeneous hypervisor Nova deployments","commit_id":"0e1ca00ca01859003424d0f17cdc3e7bd63c4cb9"},{"author":{"_account_id":11538,"name":"Zhang Ni","email":"zhangni@huawei.com","username":"zhangni"},"change_message_id":"40cf1c5b464364f4973616f6181fcd0740fb7aba","unresolved":false,"context_lines":[{"line_number":24,"context_line":"volume api, which leads to many inconveniences such as the inability for"},{"line_number":25,"context_line":"users to utilize the bus type they desire, the extra care and attention needed"},{"line_number":26,"context_line":"to be paid for the device name that is available on the current instance to be"},{"line_number":27,"context_line":"attached, and so forth."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5afe65bd_af69998d","line":27,"in_reply_to":"5afe65bd_c672857c","updated":"2015-06-02 10:54:02.000000000","message":"Hi Daniel,\nThanks for your comment.\nYes, it\u0027s a usecase. And user can use \u0027hw_disk_bus\u0027, but each hypervisor have different disk bus and user generally does not set this parameter when they want more than one hypervisor using the same image. And now \u0027block_device_mapping_v2\u0027 in \u0027create instance\u0027 API already have disk_bus. So I think \u0027attach volume\u0027 api is better to align with \u0027create instance\u0027 api and it\u0027s convenient for user instead of specifying device_name.","commit_id":"0e1ca00ca01859003424d0f17cdc3e7bd63c4cb9"},{"author":{"_account_id":13629,"name":"Zhipeng","email":"huangzhipeng@huawei.com","username":"zhipengh"},"change_message_id":"bb5c76c7abd15deb4dc135201335c261c86eb9de","unresolved":false,"context_lines":[{"line_number":24,"context_line":"volume api, which leads to many inconveniences such as the inability for"},{"line_number":25,"context_line":"users to utilize the bus type they desire, the extra care and attention needed"},{"line_number":26,"context_line":"to be paid for the device name that is available on the current instance to be"},{"line_number":27,"context_line":"attached, and so forth."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5afe65bd_015f34e6","line":27,"in_reply_to":"5afe65bd_d2347edf","updated":"2015-06-03 09:09:45.000000000","message":"Hi Daniel,\n\nI think what Zhang Ni meant to solve is that for the following scenario to be fulfilled altogether:\n1)One VM to be able to attach different disks (thus different disk_bus)\n2)One Image to be able to be used by different Hypervisors (each of which has different disk_bus)\n3)multi-channel (SCSI, NVMe) support for the volume attach process\n\nTherefore for all the above three to work, it is the problem that how user could override image disk settings with their own preferred \"disk_bus\" when they attach volumes, rather than how user could designate their own hw_disk_bus type with image, need to be solved here. \n\nIn short not image problem, but volume problem I think :)","commit_id":"0e1ca00ca01859003424d0f17cdc3e7bd63c4cb9"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a202aaed4c96efa87be992edd08faf7134ebb54f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Use Cases"},{"line_number":31,"context_line":"----------"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* End User attaches volume with specified virt-IO disk-bus type."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Project Priority"},{"line_number":36,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_f1bbc473","line":33,"updated":"2015-06-22 15:57:50.000000000","message":"Given the discussions above, this needs expanding to include the specifics on the use case you are targeting here please.","commit_id":"0e1ca00ca01859003424d0f17cdc3e7bd63c4cb9"},{"author":{"_account_id":11538,"name":"Zhang Ni","email":"zhangni@huawei.com","username":"zhangni"},"change_message_id":"fb1d1adffa388512ff7782410e29e3d6d660cb49","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Use Cases"},{"line_number":31,"context_line":"----------"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* End User attaches volume with specified virt-IO disk-bus type."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Project Priority"},{"line_number":36,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_d19ea7b7","line":33,"in_reply_to":"fa32b979_f1bbc473","updated":"2015-06-23 04:44:24.000000000","message":"Done, thank you!","commit_id":"0e1ca00ca01859003424d0f17cdc3e7bd63c4cb9"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fb46cdffaf58fe3f6093e48aed19627b4ec130aa","unresolved":false,"context_lines":[{"line_number":71,"context_line":"REST API impact"},{"line_number":72,"context_line":"---------------"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"The new API will have the following definition:"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Request::"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa32b979_3faeae98","line":74,"updated":"2015-06-23 11:18:45.000000000","message":"worth metioning it will be a new API microversion to add this API","commit_id":"d379322f6fe4747b3ff451f976ded3c86a36a351"},{"author":{"_account_id":11538,"name":"Zhang Ni","email":"zhangni@huawei.com","username":"zhangni"},"change_message_id":"57f8842a3acbdf842aba2e3d36cab94789bf1738","unresolved":false,"context_lines":[{"line_number":71,"context_line":"REST API impact"},{"line_number":72,"context_line":"---------------"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"The new API will have the following definition:"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Request::"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa32b979_e3e17d2b","line":74,"in_reply_to":"fa32b979_3faeae98","updated":"2015-06-23 16:42:39.000000000","message":"Done","commit_id":"d379322f6fe4747b3ff451f976ded3c86a36a351"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fb46cdffaf58fe3f6093e48aed19627b4ec130aa","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Request::"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    POST /v2/?{tenant_id}?/servers/?{server_id}?/os-volume_attachments"},{"line_number":79,"context_line":"    {"},{"line_number":80,"context_line":"        \"volumeAttachment\": {"},{"line_number":81,"context_line":"            \"volumeId\": \"a26887c6-c47b-4654-abb5-dfadf7d3f803\","}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa32b979_5fba92e2","line":78,"updated":"2015-06-23 11:18:45.000000000","message":"This has to be for v2.1 only please.","commit_id":"d379322f6fe4747b3ff451f976ded3c86a36a351"},{"author":{"_account_id":11538,"name":"Zhang Ni","email":"zhangni@huawei.com","username":"zhangni"},"change_message_id":"57f8842a3acbdf842aba2e3d36cab94789bf1738","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Request::"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    POST /v2/?{tenant_id}?/servers/?{server_id}?/os-volume_attachments"},{"line_number":79,"context_line":"    {"},{"line_number":80,"context_line":"        \"volumeAttachment\": {"},{"line_number":81,"context_line":"            \"volumeId\": \"a26887c6-c47b-4654-abb5-dfadf7d3f803\","}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa32b979_03dfc169","line":78,"in_reply_to":"fa32b979_5fba92e2","updated":"2015-06-23 16:42:39.000000000","message":"Done","commit_id":"d379322f6fe4747b3ff451f976ded3c86a36a351"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fb46cdffaf58fe3f6093e48aed19627b4ec130aa","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        \"volumeAttachment\": {"},{"line_number":81,"context_line":"            \"volumeId\": \"a26887c6-c47b-4654-abb5-dfadf7d3f803\","},{"line_number":82,"context_line":"            \"device\": \"/dev/vdd\""},{"line_number":83,"context_line":"            \"bus\": [\"scsi\"|\"virtio\"|\"ide\"|\"usb\"|\"sata\"...]"},{"line_number":84,"context_line":"        }"},{"line_number":85,"context_line":"    }"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa32b979_3f38ee3c","line":83,"updated":"2015-06-23 11:18:45.000000000","message":"I assume this is optional, and not required?\n\nhow does the API user discover what the default would be? maybe they can\u0027t?\n\nshould this not include pv?","commit_id":"d379322f6fe4747b3ff451f976ded3c86a36a351"},{"author":{"_account_id":11538,"name":"Zhang Ni","email":"zhangni@huawei.com","username":"zhangni"},"change_message_id":"57f8842a3acbdf842aba2e3d36cab94789bf1738","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        \"volumeAttachment\": {"},{"line_number":81,"context_line":"            \"volumeId\": \"a26887c6-c47b-4654-abb5-dfadf7d3f803\","},{"line_number":82,"context_line":"            \"device\": \"/dev/vdd\""},{"line_number":83,"context_line":"            \"bus\": [\"scsi\"|\"virtio\"|\"ide\"|\"usb\"|\"sata\"...]"},{"line_number":84,"context_line":"        }"},{"line_number":85,"context_line":"    }"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa32b979_63f56deb","line":83,"in_reply_to":"fa32b979_3f38ee3c","updated":"2015-06-23 16:42:39.000000000","message":"yes, it\u0027s optinal. When user didn\u0027t set disk_bus, nova will decide a bus using virt-type, device-type and device-name.","commit_id":"d379322f6fe4747b3ff451f976ded3c86a36a351"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fb46cdffaf58fe3f6093e48aed19627b4ec130aa","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            \"device\": \"/dev/vdd\""},{"line_number":83,"context_line":"            \"bus\": [\"scsi\"|\"virtio\"|\"ide\"|\"usb\"|\"sata\"...]"},{"line_number":84,"context_line":"        }"},{"line_number":85,"context_line":"    }"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"The \u0027bus\u0027 parameter is added and optional in the request and should be used"},{"line_number":88,"context_line":"when user want specify disk-bus."}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa32b979_bfd63eef","line":85,"updated":"2015-06-23 11:18:45.000000000","message":"please note the spec requires you to give the JSON schema validation for this addition please.","commit_id":"d379322f6fe4747b3ff451f976ded3c86a36a351"},{"author":{"_account_id":11538,"name":"Zhang Ni","email":"zhangni@huawei.com","username":"zhangni"},"change_message_id":"57f8842a3acbdf842aba2e3d36cab94789bf1738","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            \"device\": \"/dev/vdd\""},{"line_number":83,"context_line":"            \"bus\": [\"scsi\"|\"virtio\"|\"ide\"|\"usb\"|\"sata\"...]"},{"line_number":84,"context_line":"        }"},{"line_number":85,"context_line":"    }"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"The \u0027bus\u0027 parameter is added and optional in the request and should be used"},{"line_number":88,"context_line":"when user want specify disk-bus."}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa32b979_a32cd599","line":85,"in_reply_to":"fa32b979_bfd63eef","updated":"2015-06-23 16:42:39.000000000","message":"Done","commit_id":"d379322f6fe4747b3ff451f976ded3c86a36a351"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"828e58b82b3f6f93d0b10708acf4a12014f9488e","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    }"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"The \u0027bus\u0027 parameter is added and optional in the request and should be used"},{"line_number":88,"context_line":"when user want specify disk-bus."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Response::"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa32b979_93025c08","line":88,"updated":"2015-06-23 08:58:38.000000000","message":"If we look at the image meta, we have the disk bus similar to what you suggest\n\nhttps://github.com/openstack/nova/blob/master/nova/objects/image_meta.py#L158\n\nBut also have a SCSI model field to distinguish between the multiple different implementations for the SCSI bus\n\nhttps://github.com/openstack/nova/blob/master/nova/objects/image_meta.py#L201\n\nand this isn\u0027t handled with this extension to the API. It feels like if you want to add a bus attribute to the API, people wil soon want the scsi model attribute too","commit_id":"d379322f6fe4747b3ff451f976ded3c86a36a351"},{"author":{"_account_id":11538,"name":"Zhang Ni","email":"zhangni@huawei.com","username":"zhangni"},"change_message_id":"7dde22adccdc377032a7a4bb2688f1ab9f32ac15","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    }"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"The \u0027bus\u0027 parameter is added and optional in the request and should be used"},{"line_number":88,"context_line":"when user want specify disk-bus."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Response::"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa32b979_b3776001","line":88,"in_reply_to":"fa32b979_93025c08","updated":"2015-06-23 09:09:15.000000000","message":"Hi Daniel, yes, you are right, i clarified the problem in \"Problem description\" section, please check it, thanks!\n\nAlso user can use \u0027hw_disk_bus\u0027 image property, but each hypervisor have different disk bus, different disks even one disk(SSD) can use different disk_bus in the same VM, and user generally does not set this parameter when they want more than one hypervisor using the same image, so we should allow user to override image disk settings with their own preferred \"disk_bus\" when they attach volumes.","commit_id":"d379322f6fe4747b3ff451f976ded3c86a36a351"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fb46cdffaf58fe3f6093e48aed19627b4ec130aa","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    {"},{"line_number":94,"context_line":"        \"volumeAttachment\": {"},{"line_number":95,"context_line":"            \"device\": \"/dev/vdd\","},{"line_number":96,"context_line":"            \"bus\": \"virtio\","},{"line_number":97,"context_line":"            \"id\": \"a26887c6-c47b-4654-abb5-dfadf7d3f803\","},{"line_number":98,"context_line":"            \"serverId\": \"0c92f3f6-c253-4c9b-bd43-e880a8d2eb0a\","},{"line_number":99,"context_line":"            \"volumeId\": \"a26887c6-c47b-4654-abb5-dfadf7d3f803\""}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa32b979_dfca224f","line":96,"updated":"2015-06-23 11:18:45.000000000","message":"does this change all the volume attachement listing APIs now? I think it should.\n\nplease make a note to ensure the bus will always get returned, even if the user didn\u0027t specify the bus? Maybe thats not possible, I am not sure?\n\nHow will this impact all the other hypervisor drivers? are you going to fix them up so they work?","commit_id":"d379322f6fe4747b3ff451f976ded3c86a36a351"},{"author":{"_account_id":11538,"name":"Zhang Ni","email":"zhangni@huawei.com","username":"zhangni"},"change_message_id":"57f8842a3acbdf842aba2e3d36cab94789bf1738","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    {"},{"line_number":94,"context_line":"        \"volumeAttachment\": {"},{"line_number":95,"context_line":"            \"device\": \"/dev/vdd\","},{"line_number":96,"context_line":"            \"bus\": \"virtio\","},{"line_number":97,"context_line":"            \"id\": \"a26887c6-c47b-4654-abb5-dfadf7d3f803\","},{"line_number":98,"context_line":"            \"serverId\": \"0c92f3f6-c253-4c9b-bd43-e880a8d2eb0a\","},{"line_number":99,"context_line":"            \"volumeId\": \"a26887c6-c47b-4654-abb5-dfadf7d3f803\""}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa32b979_832751b5","line":96,"in_reply_to":"fa32b979_dfca224f","updated":"2015-06-23 16:42:39.000000000","message":"OK, response will always return \"bus\", if user didn\u0027t specify the bus, nova can use the virt-type, device-type and device-name to decide a bus to use.\nYes, it will impact all the other hypervisor drivers and I will fix them in the following patch.","commit_id":"d379322f6fe4747b3ff451f976ded3c86a36a351"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fb46cdffaf58fe3f6093e48aed19627b4ec130aa","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            \"volumeId\": \"a26887c6-c47b-4654-abb5-dfadf7d3f803\""},{"line_number":100,"context_line":"        }"},{"line_number":101,"context_line":"    }"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Security impact"},{"line_number":104,"context_line":"---------------"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa32b979_dff8e27e","line":102,"updated":"2015-06-23 11:18:45.000000000","message":"To me I feel we should also be adding these details to the boot API as well as the attachment API?","commit_id":"d379322f6fe4747b3ff451f976ded3c86a36a351"},{"author":{"_account_id":11538,"name":"Zhang Ni","email":"zhangni@huawei.com","username":"zhangni"},"change_message_id":"57f8842a3acbdf842aba2e3d36cab94789bf1738","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            \"volumeId\": \"a26887c6-c47b-4654-abb5-dfadf7d3f803\""},{"line_number":100,"context_line":"        }"},{"line_number":101,"context_line":"    }"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Security impact"},{"line_number":104,"context_line":"---------------"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa32b979_08b28094","line":102,"in_reply_to":"fa32b979_dff8e27e","updated":"2015-06-23 16:42:39.000000000","message":"I find there is \"block_device_mapping_v2\" and disk_bus in boot api currently. http://developer.openstack.org/api-ref-compute-v2-ext.html","commit_id":"d379322f6fe4747b3ff451f976ded3c86a36a351"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fb46cdffaf58fe3f6093e48aed19627b4ec130aa","unresolved":false,"context_lines":[{"line_number":146,"context_line":"Work Items"},{"line_number":147,"context_line":"----------"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"* Enhance Nova attach volume API."},{"line_number":150,"context_line":"* Enhance hypervisor attach volume function."},{"line_number":151,"context_line":"* Enhance Nova-client attach volume CLI."},{"line_number":152,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa32b979_df6d4233","line":149,"updated":"2015-06-23 11:18:45.000000000","message":"There is some work in each of the hypervisor drivers I think.","commit_id":"d379322f6fe4747b3ff451f976ded3c86a36a351"},{"author":{"_account_id":11538,"name":"Zhang Ni","email":"zhangni@huawei.com","username":"zhangni"},"change_message_id":"57f8842a3acbdf842aba2e3d36cab94789bf1738","unresolved":false,"context_lines":[{"line_number":146,"context_line":"Work Items"},{"line_number":147,"context_line":"----------"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"* Enhance Nova attach volume API."},{"line_number":150,"context_line":"* Enhance hypervisor attach volume function."},{"line_number":151,"context_line":"* Enhance Nova-client attach volume CLI."},{"line_number":152,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa32b979_c8d81821","line":149,"in_reply_to":"fa32b979_df6d4233","updated":"2015-06-23 16:42:39.000000000","message":"Yes.","commit_id":"d379322f6fe4747b3ff451f976ded3c86a36a351"},{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"0c5fa80964d1381fd58a57722eddcb57a8fadf88","unresolved":false,"context_lines":[{"line_number":52,"context_line":"Proposed change"},{"line_number":53,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"The proposal is to add disk-bus paramter to nova attach volume api. When user"},{"line_number":56,"context_line":"only specifies disk-bus, Nova then would generate a device-name for volume"},{"line_number":57,"context_line":"based on virt-type and disk-bus. When user specifies both disk-bus and"},{"line_number":58,"context_line":"device-name, Nova then will need to determine if disk-bus and device-name"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da20952f_ba060884","line":55,"updated":"2015-09-06 05:37:43.000000000","message":"s/paramter/parameter/","commit_id":"22d537b071d8a8e0c04687e49f949dc1178eec77"}]}