)]}'
{"specs/liberty/approved/implementation-of-remote-fs-driver-based-on-rsync-for-libvirt.rst":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"2873e49defd1b755cdd46a8ad6b713b4442614c4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"libvirt cannot use RPC to copy files over network to/from other compute"},{"line_number":14,"context_line":"nodes. That\u0027s why libvirt uses additional interface to communicate with"},{"line_number":15,"context_line":"other compute nodes."},{"line_number":16,"context_line":"Usage of smaller number of tools for communication between compute nodes"},{"line_number":17,"context_line":"can improve security, ease of testing and deployment, give better flexibility."},{"line_number":18,"context_line":"Target of this BP is implementation of whole set of libvirt remote FS"},{"line_number":19,"context_line":"operations using ssh and rsync tools(not mix ssh and rsync)."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_9a649649","line":16,"updated":"2015-06-08 18:23:18.000000000","message":"s/of smaller number of/of fewer/","commit_id":"b8163190157bebfee8cbc5b4d891f77462e6c894"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"6fad822b37362653c12b3340549dc6fc10c6e036","unresolved":false,"context_lines":[{"line_number":13,"context_line":"libvirt cannot use RPC to copy files over network to/from other compute"},{"line_number":14,"context_line":"nodes. That\u0027s why libvirt uses additional interface to communicate with"},{"line_number":15,"context_line":"other compute nodes."},{"line_number":16,"context_line":"Usage of smaller number of tools for communication between compute nodes"},{"line_number":17,"context_line":"can improve security, ease of testing and deployment, give better flexibility."},{"line_number":18,"context_line":"Target of this BP is implementation of whole set of libvirt remote FS"},{"line_number":19,"context_line":"operations using ssh and rsync tools(not mix ssh and rsync)."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_ae56e2cf","line":16,"in_reply_to":"3afb71cf_9a649649","updated":"2015-06-09 13:21:20.000000000","message":"Done","commit_id":"b8163190157bebfee8cbc5b4d891f77462e6c894"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"2873e49defd1b755cdd46a8ad6b713b4442614c4","unresolved":false,"context_lines":[{"line_number":14,"context_line":"nodes. That\u0027s why libvirt uses additional interface to communicate with"},{"line_number":15,"context_line":"other compute nodes."},{"line_number":16,"context_line":"Usage of smaller number of tools for communication between compute nodes"},{"line_number":17,"context_line":"can improve security, ease of testing and deployment, give better flexibility."},{"line_number":18,"context_line":"Target of this BP is implementation of whole set of libvirt remote FS"},{"line_number":19,"context_line":"operations using ssh and rsync tools(not mix ssh and rsync)."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_da732e14","line":17,"updated":"2015-06-08 18:23:18.000000000","message":"s/give better/and give better/","commit_id":"b8163190157bebfee8cbc5b4d891f77462e6c894"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"6fad822b37362653c12b3340549dc6fc10c6e036","unresolved":false,"context_lines":[{"line_number":14,"context_line":"nodes. That\u0027s why libvirt uses additional interface to communicate with"},{"line_number":15,"context_line":"other compute nodes."},{"line_number":16,"context_line":"Usage of smaller number of tools for communication between compute nodes"},{"line_number":17,"context_line":"can improve security, ease of testing and deployment, give better flexibility."},{"line_number":18,"context_line":"Target of this BP is implementation of whole set of libvirt remote FS"},{"line_number":19,"context_line":"operations using ssh and rsync tools(not mix ssh and rsync)."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_4e62ceae","line":17,"in_reply_to":"3afb71cf_da732e14","updated":"2015-06-09 13:21:20.000000000","message":"Done","commit_id":"b8163190157bebfee8cbc5b4d891f77462e6c894"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"2873e49defd1b755cdd46a8ad6b713b4442614c4","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Usage of smaller number of tools for communication between compute nodes"},{"line_number":17,"context_line":"can improve security, ease of testing and deployment, give better flexibility."},{"line_number":18,"context_line":"Target of this BP is implementation of whole set of libvirt remote FS"},{"line_number":19,"context_line":"operations using ssh and rsync tools(not mix ssh and rsync)."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_3a048248","line":19,"updated":"2015-06-08 18:23:18.000000000","message":"This last sentence doesn\u0027t really make sense to me. You are saying the proposed implementation should use a whole set of libvirt remote FS operations using SSH and rsync, but then in parentheses you say you should not mix ssh and rsync? Do you mean to say that the *current* implementation of remote FS operations has a mix of ssh and rsync and this proposal will stick with only rsync or ssh, but not both?","commit_id":"b8163190157bebfee8cbc5b4d891f77462e6c894"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"6fad822b37362653c12b3340549dc6fc10c6e036","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Usage of smaller number of tools for communication between compute nodes"},{"line_number":17,"context_line":"can improve security, ease of testing and deployment, give better flexibility."},{"line_number":18,"context_line":"Target of this BP is implementation of whole set of libvirt remote FS"},{"line_number":19,"context_line":"operations using ssh and rsync tools(not mix ssh and rsync)."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_0e7296ad","line":19,"in_reply_to":"3afb71cf_3a048248","updated":"2015-06-09 13:21:20.000000000","message":"\u003e\u003e\u003eDo you mean to say that the *current* implementation of remote FS operations has a mix of ssh and rsync and this proposal will stick with only rsync or ssh, but not both?\nYes, I mean that there will be two drivers: the first driver will use ssh command only and the second driver will use rsync command only.\nRephrased.","commit_id":"b8163190157bebfee8cbc5b4d891f77462e6c894"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"2873e49defd1b755cdd46a8ad6b713b4442614c4","unresolved":false,"context_lines":[{"line_number":29,"context_line":"* scp,"},{"line_number":30,"context_line":"* rsync"},{"line_number":31,"context_line":"for communication(creation directory, creation file, removing file, copying"},{"line_number":32,"context_line":"file over SSH to other nodes(for migration purposes)."},{"line_number":33,"context_line":"This fact force us to use additional shell and it can cause security risk."},{"line_number":34,"context_line":"We can not avoid shell usage because copying files over network requires"},{"line_number":35,"context_line":"shell. It is possible to decrease the interface between nodes by using ssh"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_7ab79a86","line":32,"updated":"2015-06-08 18:23:18.000000000","message":"The above is awkward phrasing. Perhaps consider rewriting it to just be this:\n\n The current libvirt driver uses the following commands for executing remote filesystem operations:\n * ssh touch\n * ssh mkdir\n * ssh rm\n * scp\n * rsync","commit_id":"b8163190157bebfee8cbc5b4d891f77462e6c894"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"6fad822b37362653c12b3340549dc6fc10c6e036","unresolved":false,"context_lines":[{"line_number":29,"context_line":"* scp,"},{"line_number":30,"context_line":"* rsync"},{"line_number":31,"context_line":"for communication(creation directory, creation file, removing file, copying"},{"line_number":32,"context_line":"file over SSH to other nodes(for migration purposes)."},{"line_number":33,"context_line":"This fact force us to use additional shell and it can cause security risk."},{"line_number":34,"context_line":"We can not avoid shell usage because copying files over network requires"},{"line_number":35,"context_line":"shell. It is possible to decrease the interface between nodes by using ssh"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_0e2a962c","line":32,"in_reply_to":"3afb71cf_7ab79a86","updated":"2015-06-09 13:21:20.000000000","message":"Done","commit_id":"b8163190157bebfee8cbc5b4d891f77462e6c894"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"2873e49defd1b755cdd46a8ad6b713b4442614c4","unresolved":false,"context_lines":[{"line_number":30,"context_line":"* rsync"},{"line_number":31,"context_line":"for communication(creation directory, creation file, removing file, copying"},{"line_number":32,"context_line":"file over SSH to other nodes(for migration purposes)."},{"line_number":33,"context_line":"This fact force us to use additional shell and it can cause security risk."},{"line_number":34,"context_line":"We can not avoid shell usage because copying files over network requires"},{"line_number":35,"context_line":"shell. It is possible to decrease the interface between nodes by using ssh"},{"line_number":36,"context_line":"commands or rsync commands only. Such separation can allow us to decrease"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_9a4ed694","line":33,"updated":"2015-06-08 18:23:18.000000000","message":"s/force us/forces us/\n\ns/use additional/use an additional/\n\ns/it can cause security risk/this can cause security risks/","commit_id":"b8163190157bebfee8cbc5b4d891f77462e6c894"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"6fad822b37362653c12b3340549dc6fc10c6e036","unresolved":false,"context_lines":[{"line_number":30,"context_line":"* rsync"},{"line_number":31,"context_line":"for communication(creation directory, creation file, removing file, copying"},{"line_number":32,"context_line":"file over SSH to other nodes(for migration purposes)."},{"line_number":33,"context_line":"This fact force us to use additional shell and it can cause security risk."},{"line_number":34,"context_line":"We can not avoid shell usage because copying files over network requires"},{"line_number":35,"context_line":"shell. It is possible to decrease the interface between nodes by using ssh"},{"line_number":36,"context_line":"commands or rsync commands only. Such separation can allow us to decrease"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_aef262d0","line":33,"in_reply_to":"3afb71cf_9a4ed694","updated":"2015-06-09 13:21:20.000000000","message":"Done","commit_id":"b8163190157bebfee8cbc5b4d891f77462e6c894"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"2873e49defd1b755cdd46a8ad6b713b4442614c4","unresolved":false,"context_lines":[{"line_number":32,"context_line":"file over SSH to other nodes(for migration purposes)."},{"line_number":33,"context_line":"This fact force us to use additional shell and it can cause security risk."},{"line_number":34,"context_line":"We can not avoid shell usage because copying files over network requires"},{"line_number":35,"context_line":"shell. It is possible to decrease the interface between nodes by using ssh"},{"line_number":36,"context_line":"commands or rsync commands only. Such separation can allow us to decrease"},{"line_number":37,"context_line":"number of opened ports on node. Also usage rsync/scp commands only can allow"},{"line_number":38,"context_line":"us to use secure shells like rssh."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_ba32b20e","line":35,"updated":"2015-06-08 18:23:18.000000000","message":"s/shell/a shell/\n\ns/interface/interaction/","commit_id":"b8163190157bebfee8cbc5b4d891f77462e6c894"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"6fad822b37362653c12b3340549dc6fc10c6e036","unresolved":false,"context_lines":[{"line_number":32,"context_line":"file over SSH to other nodes(for migration purposes)."},{"line_number":33,"context_line":"This fact force us to use additional shell and it can cause security risk."},{"line_number":34,"context_line":"We can not avoid shell usage because copying files over network requires"},{"line_number":35,"context_line":"shell. It is possible to decrease the interface between nodes by using ssh"},{"line_number":36,"context_line":"commands or rsync commands only. Such separation can allow us to decrease"},{"line_number":37,"context_line":"number of opened ports on node. Also usage rsync/scp commands only can allow"},{"line_number":38,"context_line":"us to use secure shells like rssh."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_6e890a26","line":35,"in_reply_to":"3afb71cf_ba32b20e","updated":"2015-06-09 13:21:20.000000000","message":"Done","commit_id":"b8163190157bebfee8cbc5b4d891f77462e6c894"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"2873e49defd1b755cdd46a8ad6b713b4442614c4","unresolved":false,"context_lines":[{"line_number":34,"context_line":"We can not avoid shell usage because copying files over network requires"},{"line_number":35,"context_line":"shell. It is possible to decrease the interface between nodes by using ssh"},{"line_number":36,"context_line":"commands or rsync commands only. Such separation can allow us to decrease"},{"line_number":37,"context_line":"number of opened ports on node. Also usage rsync/scp commands only can allow"},{"line_number":38,"context_line":"us to use secure shells like rssh."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_fa302a03","line":37,"updated":"2015-06-08 18:23:18.000000000","message":"s/usage/using only\n\ns/commands only/commands/","commit_id":"b8163190157bebfee8cbc5b4d891f77462e6c894"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"6fad822b37362653c12b3340549dc6fc10c6e036","unresolved":false,"context_lines":[{"line_number":34,"context_line":"We can not avoid shell usage because copying files over network requires"},{"line_number":35,"context_line":"shell. It is possible to decrease the interface between nodes by using ssh"},{"line_number":36,"context_line":"commands or rsync commands only. Such separation can allow us to decrease"},{"line_number":37,"context_line":"number of opened ports on node. Also usage rsync/scp commands only can allow"},{"line_number":38,"context_line":"us to use secure shells like rssh."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_2e9af263","line":37,"in_reply_to":"3afb71cf_fa302a03","updated":"2015-06-09 13:21:20.000000000","message":"Done","commit_id":"b8163190157bebfee8cbc5b4d891f77462e6c894"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"2873e49defd1b755cdd46a8ad6b713b4442614c4","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Use Cases"},{"line_number":41,"context_line":"----------"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"None."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Project Priority"},{"line_number":46,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_6d21269f","line":43,"updated":"2015-06-08 18:23:18.000000000","message":"How about this?\n\n The cloud operator wishes to reduce the number of commands\n used and the number of ports opened by the\n nova-compute daemon when migrating workloads\n between compute nodes in order to reduce attack vectors.","commit_id":"b8163190157bebfee8cbc5b4d891f77462e6c894"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"6fad822b37362653c12b3340549dc6fc10c6e036","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Use Cases"},{"line_number":41,"context_line":"----------"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"None."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Project Priority"},{"line_number":46,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_0eb4d6ce","line":43,"in_reply_to":"3afb71cf_6d21269f","updated":"2015-06-09 13:21:20.000000000","message":"Added.","commit_id":"b8163190157bebfee8cbc5b4d891f77462e6c894"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"2873e49defd1b755cdd46a8ad6b713b4442614c4","unresolved":false,"context_lines":[{"line_number":45,"context_line":"Project Priority"},{"line_number":46,"context_line":"-----------------"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Priorities for Liberty have not yet been decided."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Proposed change"},{"line_number":51,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_8d78e290","line":48,"updated":"2015-06-08 18:23:18.000000000","message":"Just list \"None\" above.","commit_id":"b8163190157bebfee8cbc5b4d891f77462e6c894"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"2873e49defd1b755cdd46a8ad6b713b4442614c4","unresolved":false,"context_lines":[{"line_number":51,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"To achieve these goals abstract class \u0027RemoteFs\u0027 will be added in"},{"line_number":54,"context_line":"nova/virt/libvirt/remotefs.py. This class will contain set of operations"},{"line_number":55,"context_line":"needed for libvirt to communicate with other nodes(create_file, remove_file,"},{"line_number":56,"context_line":"create_dir, remove_dir, copy_file). This abstract class will be implemented"},{"line_number":57,"context_line":"in SshRemoteFs and RsyncRemoteFs classes."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_4d72eaae","line":54,"updated":"2015-06-08 18:23:18.000000000","message":"s/set of//","commit_id":"b8163190157bebfee8cbc5b4d891f77462e6c894"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"6fad822b37362653c12b3340549dc6fc10c6e036","unresolved":false,"context_lines":[{"line_number":51,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"To achieve these goals abstract class \u0027RemoteFs\u0027 will be added in"},{"line_number":54,"context_line":"nova/virt/libvirt/remotefs.py. This class will contain set of operations"},{"line_number":55,"context_line":"needed for libvirt to communicate with other nodes(create_file, remove_file,"},{"line_number":56,"context_line":"create_dir, remove_dir, copy_file). This abstract class will be implemented"},{"line_number":57,"context_line":"in SshRemoteFs and RsyncRemoteFs classes."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_8ed7a6ec","line":54,"in_reply_to":"3afb71cf_4d72eaae","updated":"2015-06-09 13:21:20.000000000","message":"Done","commit_id":"b8163190157bebfee8cbc5b4d891f77462e6c894"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"2873e49defd1b755cdd46a8ad6b713b4442614c4","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"To achieve these goals abstract class \u0027RemoteFs\u0027 will be added in"},{"line_number":54,"context_line":"nova/virt/libvirt/remotefs.py. This class will contain set of operations"},{"line_number":55,"context_line":"needed for libvirt to communicate with other nodes(create_file, remove_file,"},{"line_number":56,"context_line":"create_dir, remove_dir, copy_file). This abstract class will be implemented"},{"line_number":57,"context_line":"in SshRemoteFs and RsyncRemoteFs classes."},{"line_number":58,"context_line":"Class SshRemoteFs will use ssh and scp tools only(scp uses ssh for data"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_cdb5ba31","line":55,"updated":"2015-06-08 18:23:18.000000000","message":"remove the stuff in parentheses and just write \"community with other nodes and perform filesystem operations on those nodes\".","commit_id":"b8163190157bebfee8cbc5b4d891f77462e6c894"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"6fad822b37362653c12b3340549dc6fc10c6e036","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"To achieve these goals abstract class \u0027RemoteFs\u0027 will be added in"},{"line_number":54,"context_line":"nova/virt/libvirt/remotefs.py. This class will contain set of operations"},{"line_number":55,"context_line":"needed for libvirt to communicate with other nodes(create_file, remove_file,"},{"line_number":56,"context_line":"create_dir, remove_dir, copy_file). This abstract class will be implemented"},{"line_number":57,"context_line":"in SshRemoteFs and RsyncRemoteFs classes."},{"line_number":58,"context_line":"Class SshRemoteFs will use ssh and scp tools only(scp uses ssh for data"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_6eefca87","line":55,"in_reply_to":"3afb71cf_cdb5ba31","updated":"2015-06-09 13:21:20.000000000","message":"Done","commit_id":"b8163190157bebfee8cbc5b4d891f77462e6c894"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"2873e49defd1b755cdd46a8ad6b713b4442614c4","unresolved":false,"context_lines":[{"line_number":54,"context_line":"nova/virt/libvirt/remotefs.py. This class will contain set of operations"},{"line_number":55,"context_line":"needed for libvirt to communicate with other nodes(create_file, remove_file,"},{"line_number":56,"context_line":"create_dir, remove_dir, copy_file). This abstract class will be implemented"},{"line_number":57,"context_line":"in SshRemoteFs and RsyncRemoteFs classes."},{"line_number":58,"context_line":"Class SshRemoteFs will use ssh and scp tools only(scp uses ssh for data"},{"line_number":59,"context_line":"transfer, and it uses the same authentication and provides the same security"},{"line_number":60,"context_line":"as ssh)."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_0ddab278","line":57,"updated":"2015-06-08 18:23:18.000000000","message":"Please use \"Filesystem\" instead of the abbreviation \"Fs\".","commit_id":"b8163190157bebfee8cbc5b4d891f77462e6c894"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"6fad822b37362653c12b3340549dc6fc10c6e036","unresolved":false,"context_lines":[{"line_number":54,"context_line":"nova/virt/libvirt/remotefs.py. This class will contain set of operations"},{"line_number":55,"context_line":"needed for libvirt to communicate with other nodes(create_file, remove_file,"},{"line_number":56,"context_line":"create_dir, remove_dir, copy_file). This abstract class will be implemented"},{"line_number":57,"context_line":"in SshRemoteFs and RsyncRemoteFs classes."},{"line_number":58,"context_line":"Class SshRemoteFs will use ssh and scp tools only(scp uses ssh for data"},{"line_number":59,"context_line":"transfer, and it uses the same authentication and provides the same security"},{"line_number":60,"context_line":"as ssh)."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_8e2b2694","line":57,"in_reply_to":"3afb71cf_0ddab278","updated":"2015-06-09 13:21:20.000000000","message":"Done","commit_id":"b8163190157bebfee8cbc5b4d891f77462e6c894"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"2873e49defd1b755cdd46a8ad6b713b4442614c4","unresolved":false,"context_lines":[{"line_number":60,"context_line":"as ssh)."},{"line_number":61,"context_line":"Additional remote FS driver will be implemented in RsyncRemoteFs class. This"},{"line_number":62,"context_line":"class will use rsync command only."},{"line_number":63,"context_line":"Configuration option \u0027remote_fs_transport\u0027 will be added with default value"},{"line_number":64,"context_line":"\u0027ssh\u0027 and \u0027choices ssh\u0027, \u0027rsync\u0027. Depending on option value corresponding"},{"line_number":65,"context_line":"class will be instantiated."},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_add15e59","line":63,"updated":"2015-06-08 18:23:18.000000000","message":"Please use \"filesystem\" instead of \"fs\" :)","commit_id":"b8163190157bebfee8cbc5b4d891f77462e6c894"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"6fad822b37362653c12b3340549dc6fc10c6e036","unresolved":false,"context_lines":[{"line_number":60,"context_line":"as ssh)."},{"line_number":61,"context_line":"Additional remote FS driver will be implemented in RsyncRemoteFs class. This"},{"line_number":62,"context_line":"class will use rsync command only."},{"line_number":63,"context_line":"Configuration option \u0027remote_fs_transport\u0027 will be added with default value"},{"line_number":64,"context_line":"\u0027ssh\u0027 and \u0027choices ssh\u0027, \u0027rsync\u0027. Depending on option value corresponding"},{"line_number":65,"context_line":"class will be instantiated."},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_ae302202","line":63,"in_reply_to":"3afb71cf_add15e59","updated":"2015-06-09 13:21:20.000000000","message":"Done","commit_id":"b8163190157bebfee8cbc5b4d891f77462e6c894"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"2873e49defd1b755cdd46a8ad6b713b4442614c4","unresolved":false,"context_lines":[{"line_number":144,"context_line":"Documentation Impact"},{"line_number":145,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Adding new option \u0027remote_fs_transport\u0027 to configure method of compute node"},{"line_number":148,"context_line":"communication."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_4dce6ab5","line":147,"updated":"2015-06-08 18:23:18.000000000","message":"ditto.","commit_id":"b8163190157bebfee8cbc5b4d891f77462e6c894"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"6fad822b37362653c12b3340549dc6fc10c6e036","unresolved":false,"context_lines":[{"line_number":144,"context_line":"Documentation Impact"},{"line_number":145,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Adding new option \u0027remote_fs_transport\u0027 to configure method of compute node"},{"line_number":148,"context_line":"communication."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_ce211eb6","line":147,"in_reply_to":"3afb71cf_4dce6ab5","updated":"2015-06-09 13:21:20.000000000","message":"Done","commit_id":"b8163190157bebfee8cbc5b4d891f77462e6c894"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c2bdb17802ff11f2a51ad55648bba60e852e6f82","unresolved":false,"context_lines":[{"line_number":58,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"To achieve these goals abstract class \u0027RemoteFilesystem\u0027 will be added in"},{"line_number":61,"context_line":"nova/virt/libvirt/remotefs.py. This class will contain operations needed for"},{"line_number":62,"context_line":"libvirt to communicate with other nodes perform filesystem operations on those"},{"line_number":63,"context_line":"nodes. This abstract class will be implemented in SshRemoteFilesystem and"},{"line_number":64,"context_line":"RsyncRemoteFilesystem classes."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1af86dd1_03abef8a","line":61,"updated":"2015-06-12 15:09:11.000000000","message":"I would love to see this in virt so it could be shared, but thats fine for now.","commit_id":"3110b946aa390e4ff1c5e727aeae393d35c123a4"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c2bdb17802ff11f2a51ad55648bba60e852e6f82","unresolved":false,"context_lines":[{"line_number":145,"context_line":"Testing"},{"line_number":146,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"tempest test for migration instances will be added."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1af86dd1_839fdf5e","line":148,"updated":"2015-06-12 15:09:11.000000000","message":"There are no tests that need to be added for this, but its a nit.","commit_id":"3110b946aa390e4ff1c5e727aeae393d35c123a4"}]}