)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"432f91997a4291eb0171bf9256f3eb1143f982f0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add volume type to create server API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently in create server API, using block_device_mapping"},{"line_number":10,"context_line":"para can create cinder volume and attach to instance, but there"},{"line_number":11,"context_line":"aren\u0027t volume type para to create a SLA based volume, so"},{"line_number":12,"context_line":"this bp will add the volume type to create api."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5afe65bd_aae6feb1","line":10,"updated":"2015-06-03 06:52:51.000000000","message":"para \u003d\u003e parameter","commit_id":"5dcf81737b761f14bd259e66afa101df1ed7e811"},{"author":{"_account_id":11538,"name":"Zhang Ni","email":"zhangni@huawei.com","username":"zhangni"},"change_message_id":"93eb53c5292af7b5d7c8fca1817053338fdc18e8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add volume type to create server API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently in create server API, using block_device_mapping"},{"line_number":10,"context_line":"para can create cinder volume and attach to instance, but there"},{"line_number":11,"context_line":"aren\u0027t volume type para to create a SLA based volume, so"},{"line_number":12,"context_line":"this bp will add the volume type to create api."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5afe65bd_4a354af5","line":10,"in_reply_to":"5afe65bd_aae6feb1","updated":"2015-06-03 07:07:15.000000000","message":"OK!","commit_id":"5dcf81737b761f14bd259e66afa101df1ed7e811"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"432f91997a4291eb0171bf9256f3eb1143f982f0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently in create server API, using block_device_mapping"},{"line_number":10,"context_line":"para can create cinder volume and attach to instance, but there"},{"line_number":11,"context_line":"aren\u0027t volume type para to create a SLA based volume, so"},{"line_number":12,"context_line":"this bp will add the volume type to create api."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I6289203860130c3f002adb212ceaef2952f12ecb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5afe65bd_8ae1029d","line":11,"updated":"2015-06-03 06:52:51.000000000","message":"para \u003d\u003e parameter","commit_id":"5dcf81737b761f14bd259e66afa101df1ed7e811"},{"author":{"_account_id":11538,"name":"Zhang Ni","email":"zhangni@huawei.com","username":"zhangni"},"change_message_id":"93eb53c5292af7b5d7c8fca1817053338fdc18e8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently in create server API, using block_device_mapping"},{"line_number":10,"context_line":"para can create cinder volume and attach to instance, but there"},{"line_number":11,"context_line":"aren\u0027t volume type para to create a SLA based volume, so"},{"line_number":12,"context_line":"this bp will add the volume type to create api."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I6289203860130c3f002adb212ceaef2952f12ecb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5afe65bd_0a3f52d7","line":11,"in_reply_to":"5afe65bd_8ae1029d","updated":"2015-06-03 07:07:15.000000000","message":"OK.","commit_id":"5dcf81737b761f14bd259e66afa101df1ed7e811"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"432f91997a4291eb0171bf9256f3eb1143f982f0","unresolved":false,"context_lines":[{"line_number":12,"context_line":"this bp will add the volume type to create api."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I6289203860130c3f002adb212ceaef2952f12ecb"},{"line_number":15,"context_line":"Blueprint:add-volume-type-to-create-server--api"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5afe65bd_0aecf28d","line":15,"updated":"2015-06-03 06:52:51.000000000","message":"why not point it to https://blueprints.launchpad.net/openstack/?searchtext\u003denable-volume-types","commit_id":"5dcf81737b761f14bd259e66afa101df1ed7e811"},{"author":{"_account_id":11538,"name":"Zhang Ni","email":"zhangni@huawei.com","username":"zhangni"},"change_message_id":"93eb53c5292af7b5d7c8fca1817053338fdc18e8","unresolved":false,"context_lines":[{"line_number":12,"context_line":"this bp will add the volume type to create api."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I6289203860130c3f002adb212ceaef2952f12ecb"},{"line_number":15,"context_line":"Blueprint:add-volume-type-to-create-server--api"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5afe65bd_050d0537","line":15,"in_reply_to":"5afe65bd_0aecf28d","updated":"2015-06-03 07:07:15.000000000","message":"OK. This is better! I hope so!","commit_id":"5dcf81737b761f14bd259e66afa101df1ed7e811"}],"specs/liberty/approved/add-volume-type-to-create-server-api.rst":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"432f91997a4291eb0171bf9256f3eb1143f982f0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/add-volume-type-to-create"},{"line_number":12,"context_line":"-server--api"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The purpose of this spec is to add volume-type to block_device_mapping"},{"line_number":15,"context_line":"parameter nova create instance API."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5afe65bd_cafeda37","line":12,"updated":"2015-06-03 06:52:51.000000000","message":"https://blueprints.launchpad.net/openstack/?searchtext\u003denable-volume-types","commit_id":"5dcf81737b761f14bd259e66afa101df1ed7e811"},{"author":{"_account_id":11538,"name":"Zhang Ni","email":"zhangni@huawei.com","username":"zhangni"},"change_message_id":"93eb53c5292af7b5d7c8fca1817053338fdc18e8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/add-volume-type-to-create"},{"line_number":12,"context_line":"-server--api"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The purpose of this spec is to add volume-type to block_device_mapping"},{"line_number":15,"context_line":"parameter nova create instance API."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5afe65bd_c50fed2c","line":12,"in_reply_to":"5afe65bd_cafeda37","updated":"2015-06-03 07:07:15.000000000","message":"OK","commit_id":"5dcf81737b761f14bd259e66afa101df1ed7e811"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"432f91997a4291eb0171bf9256f3eb1143f982f0","unresolved":false,"context_lines":[{"line_number":92,"context_line":"Other end user impact"},{"line_number":93,"context_line":"---------------------"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"There will be a new \u0027volume_type\u0027 parameter in Nova boot CLI."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Performance Impact"},{"line_number":98,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5afe65bd_ea8ab6be","line":95,"updated":"2015-06-03 06:52:51.000000000","message":"The end user will gain from being able to leverage cinder volume types.","commit_id":"5dcf81737b761f14bd259e66afa101df1ed7e811"},{"author":{"_account_id":11538,"name":"Zhang Ni","email":"zhangni@huawei.com","username":"zhangni"},"change_message_id":"93eb53c5292af7b5d7c8fca1817053338fdc18e8","unresolved":false,"context_lines":[{"line_number":92,"context_line":"Other end user impact"},{"line_number":93,"context_line":"---------------------"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"There will be a new \u0027volume_type\u0027 parameter in Nova boot CLI."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Performance Impact"},{"line_number":98,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5afe65bd_652719b7","line":95,"in_reply_to":"5afe65bd_ea8ab6be","updated":"2015-06-03 07:07:15.000000000","message":"OK","commit_id":"5dcf81737b761f14bd259e66afa101df1ed7e811"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"432f91997a4291eb0171bf9256f3eb1143f982f0","unresolved":false,"context_lines":[{"line_number":120,"context_line":"  zhangni \u003czhangni@huawei.com\u003e"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Other contributors:"},{"line_number":123,"context_line":"  None"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Work Items"},{"line_number":126,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5afe65bd_aa94bee1","line":123,"updated":"2015-06-03 06:52:51.000000000","message":"Please add me here as I have done the DB and object part and am currently working on passing the volume type ...","commit_id":"5dcf81737b761f14bd259e66afa101df1ed7e811"},{"author":{"_account_id":11538,"name":"Zhang Ni","email":"zhangni@huawei.com","username":"zhangni"},"change_message_id":"93eb53c5292af7b5d7c8fca1817053338fdc18e8","unresolved":false,"context_lines":[{"line_number":120,"context_line":"  zhangni \u003czhangni@huawei.com\u003e"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Other contributors:"},{"line_number":123,"context_line":"  None"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Work Items"},{"line_number":126,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5afe65bd_45865d66","line":123,"in_reply_to":"5afe65bd_aa94bee1","updated":"2015-06-03 07:07:15.000000000","message":"OK. I hope so and first need to get your consent：）","commit_id":"5dcf81737b761f14bd259e66afa101df1ed7e811"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"569a5bfd689bcdcedcf6cb60a83a98320ae6b9dd","unresolved":false,"context_lines":[{"line_number":28,"context_line":"user can set both volume size and volume_type which is always used to"},{"line_number":29,"context_line":"define the volume SLA/QoS. Therefore it is better for nova api to be"},{"line_number":30,"context_line":"aligned with Cinder on this feature so that user can define the volume"},{"line_number":31,"context_line":"SLA/QoS level when creating a volume associated with a given instance."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Use Cases"},{"line_number":34,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3afb71cf_cfcf6027","line":31,"updated":"2015-06-11 11:35:36.000000000","message":"So given we haven\u0027t removed the creation of volumes from the API, this is a good add.\n\nBut we really should decide about that soon, before we add more features like this.","commit_id":"84578b24677e3152814782cf207561f0b88f132c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"921e08476bec3e5ec20c9c558a784c33a8e34f12","unresolved":false,"context_lines":[{"line_number":28,"context_line":"user can set both volume size and volume_type which is always used to"},{"line_number":29,"context_line":"define the volume SLA/QoS. Therefore it is better for nova api to be"},{"line_number":30,"context_line":"aligned with Cinder on this feature so that user can define the volume"},{"line_number":31,"context_line":"SLA/QoS level when creating a volume associated with a given instance."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Use Cases"},{"line_number":34,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_a1043c15","line":31,"in_reply_to":"3afb71cf_cfcf6027","updated":"2015-06-15 06:17:32.000000000","message":"Can you please elaborate more on the decision? At the moment the functionality in the API regarding the volumes is half baked and this closes that gap.","commit_id":"84578b24677e3152814782cf207561f0b88f132c"},{"author":{"_account_id":11538,"name":"Zhang Ni","email":"zhangni@huawei.com","username":"zhangni"},"change_message_id":"84a0471ed5b9a73f40d1164f4db23b94b52ebb86","unresolved":false,"context_lines":[{"line_number":28,"context_line":"user can set both volume size and volume_type which is always used to"},{"line_number":29,"context_line":"define the volume SLA/QoS. Therefore it is better for nova api to be"},{"line_number":30,"context_line":"aligned with Cinder on this feature so that user can define the volume"},{"line_number":31,"context_line":"SLA/QoS level when creating a volume associated with a given instance."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Use Cases"},{"line_number":34,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_c14e20c1","line":31,"in_reply_to":"3afb71cf_cfcf6027","updated":"2015-06-15 06:38:51.000000000","message":"Hi John, maybe we can remove the create volume api in the volume.py which is totally a proxy, not this one in server.py. In create server API, it a complete service and very useful for end user. do you think so?","commit_id":"84578b24677e3152814782cf207561f0b88f132c"},{"author":{"_account_id":8574,"name":"Qin Zhao","username":"zhaoqin","inactive":true},"change_message_id":"8a46a7aef67450cbcddca0a6baf1af70efd17de4","unresolved":false,"context_lines":[{"line_number":28,"context_line":"user can set both volume size and volume_type which is always used to"},{"line_number":29,"context_line":"define the volume SLA/QoS. Therefore it is better for nova api to be"},{"line_number":30,"context_line":"aligned with Cinder on this feature so that user can define the volume"},{"line_number":31,"context_line":"SLA/QoS level when creating a volume associated with a given instance."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Use Cases"},{"line_number":34,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_0d22ab52","line":31,"in_reply_to":"fa32b979_a1043c15","updated":"2015-06-16 16:12:39.000000000","message":"Personally I would be 70% percent agree to remove creating volume via Nova api. Cinder api and capability is also always changing. If we plan fix the gap, it will be continous effort in the future, which may not benefit Nova a lot.\n\nProviding many alternatives to end user may not be always a good thing. The alternatives require more complex api and code, and may result in more bugs. If creating volumes before booting instances is the exact way for user to achieve the goal, let them do it in that way.","commit_id":"84578b24677e3152814782cf207561f0b88f132c"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"0ae5691972a491f5d85fcbffd2af1dc4d5b67be6","unresolved":false,"context_lines":[{"line_number":50,"context_line":"default, unless when destination_type is volume and source_type is one"},{"line_number":51,"context_line":"of {blank, image or snapshot}, user then could specify the value of"},{"line_number":52,"context_line":"volume_type. Under this circumstance Nova will save the volume_type"},{"line_number":53,"context_line":"value to DB and post it to cinder in create volume api."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Alternatives"},{"line_number":56,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1af86dd1_e968a8bc","line":53,"updated":"2015-06-12 19:36:15.000000000","message":"There doesn\u0027t appear to be anywhere to store this in Nova.  I think it should just be something that is passed through to Cinder.","commit_id":"84578b24677e3152814782cf207561f0b88f132c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"921e08476bec3e5ec20c9c558a784c33a8e34f12","unresolved":false,"context_lines":[{"line_number":50,"context_line":"default, unless when destination_type is volume and source_type is one"},{"line_number":51,"context_line":"of {blank, image or snapshot}, user then could specify the value of"},{"line_number":52,"context_line":"volume_type. Under this circumstance Nova will save the volume_type"},{"line_number":53,"context_line":"value to DB and post it to cinder in create volume api."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Alternatives"},{"line_number":56,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_01140842","line":53,"in_reply_to":"1af86dd1_e968a8bc","updated":"2015-06-15 06:17:32.000000000","message":"Why we can just add a property to the volume - please see patch - https://review.openstack.org/139992 and the patch above.","commit_id":"84578b24677e3152814782cf207561f0b88f132c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"569a5bfd689bcdcedcf6cb60a83a98320ae6b9dd","unresolved":false,"context_lines":[{"line_number":55,"context_line":"Alternatives"},{"line_number":56,"context_line":"------------"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"None"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Data model impact"},{"line_number":61,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3afb71cf_4f1ff0b6","line":58,"updated":"2015-06-11 11:35:36.000000000","message":"So the main alternative here, is that we expect users to create their volumes before booting their instance.\n\nThe bits that create volumes are in many ways quite unfortunate. Its stuff where Nova is doing orchestration and is being a proxy to cinder, and we are planning on doing no more of either of those things:\nhttp://docs.openstack.org/developer/nova/devref/project_scope.html#no-more-api-proxies","commit_id":"84578b24677e3152814782cf207561f0b88f132c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"921e08476bec3e5ec20c9c558a784c33a8e34f12","unresolved":false,"context_lines":[{"line_number":55,"context_line":"Alternatives"},{"line_number":56,"context_line":"------------"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"None"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Data model impact"},{"line_number":61,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_21382cd3","line":58,"in_reply_to":"3afb71cf_4f1ff0b6","updated":"2015-06-15 06:17:32.000000000","message":"So does that mean we will purge nova of all of the proxying that it is doing at the moment? That may break existing orchestration built.","commit_id":"84578b24677e3152814782cf207561f0b88f132c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"347d77f55904d0762e35569c3c5f86d9a70c72b2","unresolved":false,"context_lines":[{"line_number":60,"context_line":"Data model impact"},{"line_number":61,"context_line":"-----------------"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"None"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"REST API impact"},{"line_number":66,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_e7e689b3","line":63,"updated":"2015-06-16 14:52:21.000000000","message":"There is obvious data model impact if you want to add a volume_type column to the block_device_mapping table per https://review.openstack.org/#/c/139992/.","commit_id":"84578b24677e3152814782cf207561f0b88f132c"},{"author":{"_account_id":11538,"name":"Zhang Ni","email":"zhangni@huawei.com","username":"zhangni"},"change_message_id":"b5530223a743b1f09ca0bc54e9ab795f3341869a","unresolved":false,"context_lines":[{"line_number":60,"context_line":"Data model impact"},{"line_number":61,"context_line":"-----------------"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"None"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"REST API impact"},{"line_number":66,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_11308fe7","line":63,"in_reply_to":"fa32b979_e7e689b3","updated":"2015-06-23 04:34:02.000000000","message":"Done","commit_id":"84578b24677e3152814782cf207561f0b88f132c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"347d77f55904d0762e35569c3c5f86d9a70c72b2","unresolved":false,"context_lines":[{"line_number":65,"context_line":"REST API impact"},{"line_number":66,"context_line":"---------------"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Volume_type will be added to block_device_mapping_v2 when destination_type"},{"line_number":69,"context_line":"is volume and source_type is one of {blank, snapshot or image}."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"\"block_device_mapping_v2\": ["}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_475bb554","line":68,"updated":"2015-06-16 14:52:21.000000000","message":"Can you explain a bit more here - is this saying volume_type would be required if destination_type is volume and source_type is one of blank, snapshot or image?  That would be a backwards incompatible change, at least w/o a microversion.  Or are you saying a request with volume_type in it would fail with a 400 if the other values weren\u0027t ^?\n\nAlso, you\u0027re not calling out if this is a v2 or v2.1 microversion change, since v2 is frozen though I\u0027m assuming this will be a v2.1 microversion.\n\nThe spec template has more details required for an API change that I don\u0027t think are called out here, like jsonschema validation of the request.","commit_id":"84578b24677e3152814782cf207561f0b88f132c"},{"author":{"_account_id":11538,"name":"Zhang Ni","email":"zhangni@huawei.com","username":"zhangni"},"change_message_id":"b5530223a743b1f09ca0bc54e9ab795f3341869a","unresolved":false,"context_lines":[{"line_number":65,"context_line":"REST API impact"},{"line_number":66,"context_line":"---------------"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Volume_type will be added to block_device_mapping_v2 when destination_type"},{"line_number":69,"context_line":"is volume and source_type is one of {blank, snapshot or image}."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"\"block_device_mapping_v2\": ["}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_f1340bdf","line":68,"in_reply_to":"fa32b979_475bb554","updated":"2015-06-23 04:34:02.000000000","message":"Hi Matt, it is the second case you said，when destination_type is volume and source_type is one of\n{blank, snapshot or image}, the \"volume_type\" is valid, Nova accept it,\ncheck it from Cinder and deliver to Cinder in create volume request.\nIn other situation, the \"volume_type\" is invalid\nand is none by default, Nova will return error when user set it.\n\nAnd yes,we should add the change to v2.1 microversion.\n\nI will modify these in the spec, thank you very much!","commit_id":"84578b24677e3152814782cf207561f0b88f132c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"569a5bfd689bcdcedcf6cb60a83a98320ae6b9dd","unresolved":false,"context_lines":[{"line_number":129,"context_line":"Enhance block_device_mapping object to include volume_type."},{"line_number":130,"context_line":"Enhance block_device_mapping table to include volume_type."},{"line_number":131,"context_line":"Enhance attach function in DriverBlankBlockDevice class to \"create_volume\""},{"line_number":132,"context_line":"API using volume_type."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3afb71cf_af5b0485","line":132,"updated":"2015-06-11 11:35:36.000000000","message":"This doesn\u0027t render well, you probably want to add \"* \" in front of these lines to they are bullets.","commit_id":"84578b24677e3152814782cf207561f0b88f132c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"347d77f55904d0762e35569c3c5f86d9a70c72b2","unresolved":false,"context_lines":[{"line_number":129,"context_line":"Enhance block_device_mapping object to include volume_type."},{"line_number":130,"context_line":"Enhance block_device_mapping table to include volume_type."},{"line_number":131,"context_line":"Enhance attach function in DriverBlankBlockDevice class to \"create_volume\""},{"line_number":132,"context_line":"API using volume_type."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_4722d5ba","line":132,"in_reply_to":"3afb71cf_af5b0485","updated":"2015-06-16 14:52:21.000000000","message":"+1","commit_id":"84578b24677e3152814782cf207561f0b88f132c"},{"author":{"_account_id":11538,"name":"Zhang Ni","email":"zhangni@huawei.com","username":"zhangni"},"change_message_id":"b5530223a743b1f09ca0bc54e9ab795f3341869a","unresolved":false,"context_lines":[{"line_number":129,"context_line":"Enhance block_device_mapping object to include volume_type."},{"line_number":130,"context_line":"Enhance block_device_mapping table to include volume_type."},{"line_number":131,"context_line":"Enhance attach function in DriverBlankBlockDevice class to \"create_volume\""},{"line_number":132,"context_line":"API using volume_type."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_164085a4","line":132,"in_reply_to":"3afb71cf_af5b0485","updated":"2015-06-23 04:34:02.000000000","message":"Done, thank you!","commit_id":"84578b24677e3152814782cf207561f0b88f132c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"347d77f55904d0762e35569c3c5f86d9a70c72b2","unresolved":false,"context_lines":[{"line_number":147,"context_line":"Documentation Impact"},{"line_number":148,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"None"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_07036d10","line":150,"updated":"2015-06-16 14:52:21.000000000","message":"The REST API and CLI docs would obviously need to change to say this would be supported if approved.","commit_id":"84578b24677e3152814782cf207561f0b88f132c"},{"author":{"_account_id":11538,"name":"Zhang Ni","email":"zhangni@huawei.com","username":"zhangni"},"change_message_id":"b5530223a743b1f09ca0bc54e9ab795f3341869a","unresolved":false,"context_lines":[{"line_number":147,"context_line":"Documentation Impact"},{"line_number":148,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"None"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_363b493a","line":150,"in_reply_to":"fa32b979_07036d10","updated":"2015-06-23 04:34:02.000000000","message":"Done","commit_id":"84578b24677e3152814782cf207561f0b88f132c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"347d77f55904d0762e35569c3c5f86d9a70c72b2","unresolved":false,"context_lines":[{"line_number":153,"context_line":"References"},{"line_number":154,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"None"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"History"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_4210834e","line":156,"updated":"2015-06-16 14:52:21.000000000","message":"You might want to refer to any documentation on cinder volume_type APIs and the cinder volume create API.","commit_id":"84578b24677e3152814782cf207561f0b88f132c"},{"author":{"_account_id":11538,"name":"Zhang Ni","email":"zhangni@huawei.com","username":"zhangni"},"change_message_id":"b5530223a743b1f09ca0bc54e9ab795f3341869a","unresolved":false,"context_lines":[{"line_number":153,"context_line":"References"},{"line_number":154,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"None"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"History"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_d649bdd1","line":156,"in_reply_to":"fa32b979_4210834e","updated":"2015-06-23 04:34:02.000000000","message":"Done","commit_id":"84578b24677e3152814782cf207561f0b88f132c"}]}