)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a18e3e1c84a8bb06ae026a59f96960c901ce6e6c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add a new microversion in order to be able to implement a fix for"},{"line_number":10,"context_line":"bug #1450859."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic0234d79523f532524e02eb54aec96cb8139f546"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3afb71cf_44510e62","line":11,"updated":"2015-06-04 19:05:57.000000000","message":"Add:\n\nSpec for blueprint allow-ip6-search-for-non-admin\n\nSo it links to the bp here.\n\nAlso, you need the APIImpact tag in the commit message per the spec template.","commit_id":"fff689cd85215d7f12bb432e89d4dbd50bbb5777"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d3227503c09972c85a7fa8daed544c78173ac530","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add a new microversion in order to be able to implement a fix for"},{"line_number":10,"context_line":"bug #1450859."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic0234d79523f532524e02eb54aec96cb8139f546"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3afb71cf_3fef30b2","line":11,"in_reply_to":"3afb71cf_44510e62","updated":"2015-06-05 02:03:55.000000000","message":"Done","commit_id":"fff689cd85215d7f12bb432e89d4dbd50bbb5777"}],"specs/liberty/approved/allow-ip6-search-for-non-admin.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a18e3e1c84a8bb06ae026a59f96960c901ce6e6c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Proposed change"},{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Add a new API microversion to such that the ``ip6`` option will no longer be"},{"line_number":39,"context_line":"filtered out for non-admins."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_04e2f69f","line":38,"updated":"2015-06-04 19:05:57.000000000","message":"s/to such/such/","commit_id":"fff689cd85215d7f12bb432e89d4dbd50bbb5777"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d3227503c09972c85a7fa8daed544c78173ac530","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Proposed change"},{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Add a new API microversion to such that the ``ip6`` option will no longer be"},{"line_number":39,"context_line":"filtered out for non-admins."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_a4d557ba","line":38,"in_reply_to":"3afb71cf_04e2f69f","updated":"2015-06-05 02:03:55.000000000","message":"Done","commit_id":"fff689cd85215d7f12bb432e89d4dbd50bbb5777"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a18e3e1c84a8bb06ae026a59f96960c901ce6e6c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"------------"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Treat the bug fix as a minor patch that will not require a new API"},{"line_number":45,"context_line":"microversion."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Data model impact"},{"line_number":48,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_c4c05ee3","line":45,"updated":"2015-06-04 19:05:57.000000000","message":"You might want to document the main points from the review about why a microversion is being used, which was from dims\u0027 conversation with sdague, which I believe was something along the lines of, the microversion is how a user can tell if searching by IPv6 address is available in multiple clouds.","commit_id":"fff689cd85215d7f12bb432e89d4dbd50bbb5777"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d3227503c09972c85a7fa8daed544c78173ac530","unresolved":false,"context_lines":[{"line_number":42,"context_line":"------------"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Treat the bug fix as a minor patch that will not require a new API"},{"line_number":45,"context_line":"microversion."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Data model impact"},{"line_number":48,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_c46cd30a","line":45,"in_reply_to":"3afb71cf_c4c05ee3","updated":"2015-06-05 02:03:55.000000000","message":"Done","commit_id":"fff689cd85215d7f12bb432e89d4dbd50bbb5777"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a18e3e1c84a8bb06ae026a59f96960c901ce6e6c","unresolved":false,"context_lines":[{"line_number":52,"context_line":"REST API impact"},{"line_number":53,"context_line":"---------------"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"* The ``ip6`` option will no longer be filtered as server search option"},{"line_number":56,"context_line":"  for non-admins."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_047e76ae","line":55,"updated":"2015-06-04 19:05:57.000000000","message":"The template has some other information on the API impact here, so you might want to address those.  I there is no change to the request or response, you can already pass ip6 in the request as a search parameter, but the API extension code is filtering it out, which this would change.","commit_id":"fff689cd85215d7f12bb432e89d4dbd50bbb5777"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d3227503c09972c85a7fa8daed544c78173ac530","unresolved":false,"context_lines":[{"line_number":52,"context_line":"REST API impact"},{"line_number":53,"context_line":"---------------"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"* The ``ip6`` option will no longer be filtered as server search option"},{"line_number":56,"context_line":"  for non-admins."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_df349c4b","line":55,"in_reply_to":"3afb71cf_047e76ae","updated":"2015-06-05 02:03:55.000000000","message":"Done","commit_id":"fff689cd85215d7f12bb432e89d4dbd50bbb5777"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a18e3e1c84a8bb06ae026a59f96960c901ce6e6c","unresolved":false,"context_lines":[{"line_number":98,"context_line":"Work Items"},{"line_number":99,"context_line":"----------"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"* Add a new microversion and change nova/api/openstack/compute/servers.py"},{"line_number":102,"context_line":"  to add ``ip6`` to the list of allowed server search options."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_445b4e55","line":101,"updated":"2015-06-04 19:05:57.000000000","message":"This is the wrong API extension (this is v2), you need the v2.1 (v3 code path) extension.","commit_id":"fff689cd85215d7f12bb432e89d4dbd50bbb5777"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d3227503c09972c85a7fa8daed544c78173ac530","unresolved":false,"context_lines":[{"line_number":98,"context_line":"Work Items"},{"line_number":99,"context_line":"----------"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"* Add a new microversion and change nova/api/openstack/compute/servers.py"},{"line_number":102,"context_line":"  to add ``ip6`` to the list of allowed server search options."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_1fe9141b","line":101,"in_reply_to":"3afb71cf_445b4e55","updated":"2015-06-05 02:03:55.000000000","message":"Done","commit_id":"fff689cd85215d7f12bb432e89d4dbd50bbb5777"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a18e3e1c84a8bb06ae026a59f96960c901ce6e6c","unresolved":false,"context_lines":[{"line_number":111,"context_line":"Testing"},{"line_number":112,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"* Unit tests and possibly API samples functional tests in the nova tree."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_0455561c","line":114,"updated":"2015-06-04 19:05:57.000000000","message":"Yeah probably integrated API samples tests would be good.","commit_id":"fff689cd85215d7f12bb432e89d4dbd50bbb5777"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d3227503c09972c85a7fa8daed544c78173ac530","unresolved":false,"context_lines":[{"line_number":111,"context_line":"Testing"},{"line_number":112,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"* Unit tests and possibly API samples functional tests in the nova tree."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afb71cf_7f3c882f","line":114,"in_reply_to":"3afb71cf_0455561c","updated":"2015-06-05 02:03:55.000000000","message":"Done","commit_id":"fff689cd85215d7f12bb432e89d4dbd50bbb5777"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"cea5c248df3869c0021e2f0c437bb1f8d692e647","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Filtering by IPv6 address is currently only allowed for admins, but there"},{"line_number":21,"context_line":"is no reason to treat this differently than IPv4. It is also quite surprising"},{"line_number":22,"context_line":"for a user to find that ``nova list --ip6 xxx`` will list all servers."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1af86dd1_a46d4e34","line":21,"updated":"2015-06-12 10:48:54.000000000","message":"agreed","commit_id":"7711c950a45caba0f81bf89217caa07e93f8cafd"}]}