)]}'
{"specs/liberty/approved/check-if-destination_type-in-block_device_mapping_v2.rst":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"90ce77fa1aeff3f187c2bb89f2a3ee3a24108bf3","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Proposed change"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Add a new API microversion to the server API."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Alternatives"},{"line_number":44,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1af86dd1_f803f574","line":41,"updated":"2015-06-12 01:35:55.000000000","message":"we should say:\n\n\"Propose add more strict checks for ensure destination_type is provided in the request\". (you should have better word, just example at here)\n\nThis is your propose. Not just for adding new api version.","commit_id":"48245f530448277228a203f27c34f016fa82bb5f"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"90ce77fa1aeff3f187c2bb89f2a3ee3a24108bf3","unresolved":false,"context_lines":[{"line_number":54,"context_line":"---------------"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"The proposed change just updates the schema of block_device_mapping."},{"line_number":57,"context_line":"Change the type of the param named destination_type from string to enum."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Security impact"},{"line_number":60,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1af86dd1_98864112","line":57,"updated":"2015-06-12 01:35:55.000000000","message":"we should show the schema at here.","commit_id":"48245f530448277228a203f27c34f016fa82bb5f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"84730186934ab858f61e2700a2aea4ac8f8b66d0","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                \u0027additionalProperties\u0027: False"},{"line_number":113,"context_line":"            }"},{"line_number":114,"context_line":"        ]"},{"line_number":115,"context_line":"    }"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Security impact"},{"line_number":118,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_3e9f9704","line":115,"updated":"2015-06-23 09:33:03.000000000","message":"There is an issue, that we can only add this for requests to the new micro version and higher.\n\nCan you please describe in this spec how older requests will not be affected by this policy change?","commit_id":"92983e23d912b2f2170bf950ccec6d0a3dd986ef"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"80735b286b62e00bb9aa0aa8625672beb7aa5d21","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"* Add a new microversion"},{"line_number":161,"context_line":"* Change nova/api/openstack/compute/schemas/v3/block_device_mapping.py"},{"line_number":162,"context_line":"* Change nova/block_device.py"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Dependencies"},{"line_number":165,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1af86dd1_3a839cce","line":162,"updated":"2015-06-12 21:05:17.000000000","message":"What needs to change in here?  Above it seemed like just a schema update for API validation.","commit_id":"92983e23d912b2f2170bf950ccec6d0a3dd986ef"},{"author":{"_account_id":3211,"name":"zhangjialong","email":"zhangjl@awcloud.com","username":"zhangjl"},"change_message_id":"3285460340574ce5e6a30eaa8e626f9f9d5d0b93","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"* Add a new microversion"},{"line_number":161,"context_line":"* Change nova/api/openstack/compute/schemas/v3/block_device_mapping.py"},{"line_number":162,"context_line":"* Change nova/block_device.py"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Dependencies"},{"line_number":165,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_f1dc721a","line":162,"in_reply_to":"1af86dd1_3a839cce","updated":"2015-06-13 02:00:08.000000000","message":"In nova/api/openstack/compute/plugins/v3/block_device_mapping.py line 64-67, \nblock_device_mapping \u003d[\n    block_device.BlockDeviceDict.from_api(\n       bdm_dict,image_uuid_specified)\n    for bdm_dict in bdm]\nwe also need to check the destination_type.\nBecause of the above, we need to change the nova/block_device.py\n\nAnd for more detail, please visit \nhttps://review.openstack.org/#/c/173357/","commit_id":"92983e23d912b2f2170bf950ccec6d0a3dd986ef"}]}