)]}'
{"specs/liberty/approved/remove-flavor-from-scheduler-request.rst":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"11db1f3ffcf77dc9969717cb7ff5e60e7382e8d6","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Problem description"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Current the request to start an instance includes a the contents of the"},{"line_number":22,"context_line":"flavor that identifies attributes for that instance.  Rather than specifying"},{"line_number":23,"context_line":"just the raw contents of the flavor (including info like date the flavor was"},{"line_number":24,"context_line":"modified and whether the flavor was deleted) the request should just specify"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3afb71cf_a4d437bd","line":21,"range":{"start_line":21,"start_character":50,"end_line":21,"end_character":51},"updated":"2015-06-11 17:38:52.000000000","message":"extraneous \u0027a\u0027.","commit_id":"4315ceca018544eeb4c097da69f2fcfbaacb9f46"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"50658de69a2fe4bc6cb33de22ccf8e72e2d75170","unresolved":false,"context_lines":[{"line_number":22,"context_line":"flavor that identifies attributes for that instance.  Rather than specifying"},{"line_number":23,"context_line":"just the raw contents of the flavor (including info like date the flavor was"},{"line_number":24,"context_line":"modified and whether the flavor was deleted) the request should just specify"},{"line_number":25,"context_line":"the specific attributes that then instance needs.  This is a cleaner interface"},{"line_number":26,"context_line":"and, in addition, will allow specification of propterties (like numa topology)"},{"line_number":27,"context_line":"that don\u0027t fit well in the flavor model."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_7d16bbf2","line":25,"updated":"2015-06-15 18:31:03.000000000","message":"s/then/the/","commit_id":"4315ceca018544eeb4c097da69f2fcfbaacb9f46"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"11db1f3ffcf77dc9969717cb7ff5e60e7382e8d6","unresolved":false,"context_lines":[{"line_number":23,"context_line":"just the raw contents of the flavor (including info like date the flavor was"},{"line_number":24,"context_line":"modified and whether the flavor was deleted) the request should just specify"},{"line_number":25,"context_line":"the specific attributes that then instance needs.  This is a cleaner interface"},{"line_number":26,"context_line":"and, in addition, will allow specification of propterties (like numa topology)"},{"line_number":27,"context_line":"that don\u0027t fit well in the flavor model."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"It makes more sense to have Nova decompose the resources from the flavor and"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3afb71cf_64fe3f3a","line":26,"range":{"start_line":26,"start_character":46,"end_line":26,"end_character":57},"updated":"2015-06-11 17:38:52.000000000","message":"properties","commit_id":"4315ceca018544eeb4c097da69f2fcfbaacb9f46"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"56951c06b4ca387294d2acbf487269bfd5c4a073","unresolved":false,"context_lines":[{"line_number":55,"context_line":"Instead, Nova will create a new dictionary \u0027resources\u0027 that will only"},{"line_number":56,"context_line":"contain resources that are required for the new instance.  To do this, a"},{"line_number":57,"context_line":"new method, \u0027resource_required\u0027, will be added that adds entries to the"},{"line_number":58,"context_line":"\u0027resources\u0027 dictionary."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Handling the extra specs field from the flavor will actually be rather"},{"line_number":61,"context_line":"simple.  Rather than putting an extra specs entry into the scheduler"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1af86dd1_c8f974ca","line":58,"updated":"2015-06-12 14:48:38.000000000","message":"I think that this should be dependent on the RequestSpec object (https://review.openstack.org/#/c/145528/), and work with that, rather than continuing to pass dicts around.","commit_id":"4315ceca018544eeb4c097da69f2fcfbaacb9f46"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"50658de69a2fe4bc6cb33de22ccf8e72e2d75170","unresolved":false,"context_lines":[{"line_number":55,"context_line":"Instead, Nova will create a new dictionary \u0027resources\u0027 that will only"},{"line_number":56,"context_line":"contain resources that are required for the new instance.  To do this, a"},{"line_number":57,"context_line":"new method, \u0027resource_required\u0027, will be added that adds entries to the"},{"line_number":58,"context_line":"\u0027resources\u0027 dictionary."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Handling the extra specs field from the flavor will actually be rather"},{"line_number":61,"context_line":"simple.  Rather than putting an extra specs entry into the scheduler"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_ddb027e0","line":58,"in_reply_to":"1af86dd1_c8f974ca","updated":"2015-06-15 18:31:03.000000000","message":"++","commit_id":"4315ceca018544eeb4c097da69f2fcfbaacb9f46"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"11db1f3ffcf77dc9969717cb7ff5e60e7382e8d6","unresolved":false,"context_lines":[{"line_number":64,"context_line":"call \u0027resource_required\u0027 to add each key/value pair as a separate entry"},{"line_number":65,"context_line":"in the \u0027resources\u0027 dictionary.  This way the request that the scheduler"},{"line_number":66,"context_line":"receives will just contain a single dictionary that contains all of the"},{"line_number":67,"context_line":"resource requirements needed for that request."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Alternatives"},{"line_number":70,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3afb71cf_3f19707a","line":67,"updated":"2015-06-11 17:38:52.000000000","message":"There is already an approved spec to stop shoving instance into the request_spec.  That doesn\u0027t change the value of what you\u0027re proposing here, but affects the starting point.\n\nAlso, I think this gets more into implementation details than necessary.  What\u0027s important is the api between Nova and the scheduler, not the methods we create to make that happen.  I would prefer they be left out so later reviews don\u0027t get held up on implementation details proposed here.","commit_id":"4315ceca018544eeb4c097da69f2fcfbaacb9f46"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"e8dbb4e0106ce44a856656902cf58b04b5170ff0","unresolved":false,"context_lines":[{"line_number":64,"context_line":"call \u0027resource_required\u0027 to add each key/value pair as a separate entry"},{"line_number":65,"context_line":"in the \u0027resources\u0027 dictionary.  This way the request that the scheduler"},{"line_number":66,"context_line":"receives will just contain a single dictionary that contains all of the"},{"line_number":67,"context_line":"resource requirements needed for that request."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Alternatives"},{"line_number":70,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3afb71cf_5fe66c45","line":67,"in_reply_to":"3afb71cf_3f19707a","updated":"2015-06-11 17:40:49.000000000","message":"Meant to mention http://specs.openstack.org/openstack/nova-specs/specs/liberty/approved/request-spec-object.html in that comment.","commit_id":"4315ceca018544eeb4c097da69f2fcfbaacb9f46"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"56951c06b4ca387294d2acbf487269bfd5c4a073","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":" * Add Nova method to create entries in the \u0027resources\u0027 dictionary"},{"line_number":139,"context_line":" * Change Nova call to scheduler to pass specific \u0027resources\u0027 dictionary"},{"line_number":140,"context_line":" * Change scheduler to use specific resource requirements from \u0027resources\u0027"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1af86dd1_e839d042","line":140,"updated":"2015-06-12 14:48:38.000000000","message":"I think that there is a ton more work involved. Every reference to an instance\u0027s flavor will have to be removed or modified, as flavor will now be an API-only concept.","commit_id":"4315ceca018544eeb4c097da69f2fcfbaacb9f46"},{"author":{"_account_id":4992,"name":"malini-k-bhandaru","email":"malini.k.bhandaru@intel.com","username":"malini-k-bhandaru"},"change_message_id":"75a4cb83b52ab8eeb65ec9cea71fa61f6e174fd4","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Problem description"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Current the request to start an instance includes a the contents of the"},{"line_number":22,"context_line":"flavor that identifies attributes for that instance.  Rather than specifying"},{"line_number":23,"context_line":"just the raw contents of the flavor (including info like date the flavor was"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a8ffd7b_05bcef6a","line":20,"updated":"2015-12-01 19:01:47.000000000","message":"s/Current/Currently\ns/a//\n\ncomment about (including..)  a little confusing, perhaps add and dropping unnecessary inclusions such as the date flavor was created ...","commit_id":"15f5db4d1ecd2c23b29ba93cc38c7f3c1a10c6ff"},{"author":{"_account_id":4992,"name":"malini-k-bhandaru","email":"malini.k.bhandaru@intel.com","username":"malini-k-bhandaru"},"change_message_id":"75a4cb83b52ab8eeb65ec9cea71fa61f6e174fd4","unresolved":false,"context_lines":[{"line_number":22,"context_line":"flavor that identifies attributes for that instance.  Rather than specifying"},{"line_number":23,"context_line":"just the raw contents of the flavor (including info like date the flavor was"},{"line_number":24,"context_line":"modified and whether the flavor was deleted) the request should just specify"},{"line_number":25,"context_line":"the specific attributes that then instance needs.  This is a cleaner interface"},{"line_number":26,"context_line":"and, in addition, will allow specification of propterties (like numa topology)"},{"line_number":27,"context_line":"that don\u0027t fit well in the flavor model."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a8ffd7b_65013b06","line":25,"updated":"2015-12-01 19:01:47.000000000","message":"s/then/the","commit_id":"15f5db4d1ecd2c23b29ba93cc38c7f3c1a10c6ff"},{"author":{"_account_id":4992,"name":"malini-k-bhandaru","email":"malini.k.bhandaru@intel.com","username":"malini-k-bhandaru"},"change_message_id":"75a4cb83b52ab8eeb65ec9cea71fa61f6e174fd4","unresolved":false,"context_lines":[{"line_number":44,"context_line":"Project Priority"},{"line_number":45,"context_line":"-----------------"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"This is part of the scheduler priority for LIberty."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Proposed change"},{"line_number":50,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a8ffd7b_385596c5","line":47,"updated":"2015-12-01 19:01:47.000000000","message":"S/LIberty/Mitaka","commit_id":"15f5db4d1ecd2c23b29ba93cc38c7f3c1a10c6ff"},{"author":{"_account_id":4992,"name":"malini-k-bhandaru","email":"malini.k.bhandaru@intel.com","username":"malini-k-bhandaru"},"change_message_id":"75a4cb83b52ab8eeb65ec9cea71fa61f6e174fd4","unresolved":false,"context_lines":[{"line_number":52,"context_line":"is sent to the scheduler.  This dictionary is nothing but a copy of all the"},{"line_number":53,"context_line":"DB fields for the flavor that the user requested."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Instead, Nova will create a new dictionary \u0027resources\u0027 that will only"},{"line_number":56,"context_line":"contain resources that are required for the new instance.  To do this, a"},{"line_number":57,"context_line":"new method, \u0027resource_required\u0027, will be added that adds entries to the"},{"line_number":58,"context_line":"\u0027resources\u0027 dictionary."}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a8ffd7b_7820fe49","line":55,"updated":"2015-12-01 19:01:47.000000000","message":"Why not  call dictionary required-resources and the method \"add\"","commit_id":"15f5db4d1ecd2c23b29ba93cc38c7f3c1a10c6ff"},{"author":{"_account_id":4992,"name":"malini-k-bhandaru","email":"malini.k.bhandaru@intel.com","username":"malini-k-bhandaru"},"change_message_id":"75a4cb83b52ab8eeb65ec9cea71fa61f6e174fd4","unresolved":false,"context_lines":[{"line_number":62,"context_line":"request (that entry containing a list of key/value pairs) Nova will take"},{"line_number":63,"context_line":"each key/value pair from the extra specs field for the flavor and then"},{"line_number":64,"context_line":"call \u0027resource_required\u0027 to add each key/value pair as a separate entry"},{"line_number":65,"context_line":"in the \u0027resources\u0027 dictionary.  This way the request that the scheduler"},{"line_number":66,"context_line":"receives will just contain a single dictionary that contains all of the"},{"line_number":67,"context_line":"resource requirements needed for that request."},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a8ffd7b_d8dfaa38","line":65,"updated":"2015-12-01 19:01:47.000000000","message":"+1","commit_id":"15f5db4d1ecd2c23b29ba93cc38c7f3c1a10c6ff"}]}